Commit graph

12477 commits

Author SHA1 Message Date
Paul Selkirk 1450ecde99
fix: Retain date of cancelled virtual interim meeting (#6708) (#6852) 2023-12-27 10:39:13 -06:00
Robert Sparks 2c11b544f1
fix: show state help for the editorial stream (#6836) 2023-12-26 08:53:52 -06:00
Robert Sparks c328ff7425
fix: improve idnits2_state document creation time calculations (#6832)
* fix: improve idnits2_state document creation time calculations

* chore: apply black to the idnits2_state function
2023-12-21 17:52:55 -06:00
Paul Selkirk 359a107fc5
fix: Include RFCs when searching on a draft name (#6787) (#6827) 2023-12-21 17:27:32 -06:00
Robert Sparks bc74977fcc
fix: 404 requests for bibtex for none draft or rfc documents (#6834)
* fix: 404 requests for bibtex for none draft or rfc documents

* test: test rejecting the types with factories already being imported
2023-12-21 16:27:48 -06:00
Paul Selkirk c1e40ff100
feat: Allow entering agenda text directly (#6792)
* feat: Allow entering agenda text directly (#6532)

* fix: Hide label as well as file/text input box

* refactor: Package javascript for static/dist

* fix: Fix test cases broken by view changes

* test: Add test case for entering agenda text

* refactor: assertRedirects
2023-12-20 16:40:13 -06:00
Lars Eggert db8fba486b
fix: Deduplicate referenced_by (#6820)
Fixes #6808
2023-12-20 16:36:55 -06:00
Robert Sparks ca664c4162
fix: don't create a volunteer object when a person has already volunt… (#6809)
* fix: don't create a volunteer object when a person has already volunteered

* fix: safer create

* refactor: use shorthand from django

* fix: also protect volunteer from datatracker from race
2023-12-18 16:49:27 -06:00
Jennifer Richards 7d447802d2
fix: no dups on stream documents view (#6804) 2023-12-18 10:45:51 -06:00
Jennifer Richards 149f82f578
fix: Include refs to pre-RFC drafts as refs to the RFC (#6784)
* fix: clean up shadowed name in document_referenced_by.html

* fix: include refs to rfc's came_from_draft()

* fix: include refs to draft's became_rfc()

* fix: Count indirect refs by RFCs

* refactor: break indirect ref_by counting to its own fn

* fix: only count refs to pre-rfc draft, not post-draft rfc

(and rename a method)

* test: test referenced_by_rfcs methods

The test_referenced_by_rfcs_as_rfc_or_draft() test
fails because there's a bug!

* test: actually, do double-count refs to rfc/draft

Let's do include refs to an rfc and its precursor draft
as separate refs. This almost surely indicates a data
error because it would mean an rfc referenced both an
rfc and the draft that it came from. That should never
be allowed, so at least let some light fall on it if
it happens.

* chore: Add docstring to document_referenced_by view
2023-12-18 09:11:53 -06:00
Lars Eggert f5bd078351
fix: AD queue graphs and AD doc list sorting (#6752)
* Fix AD queue graphs and AD doc list sorting.

Fixes #6700
Fixes #6720

* Fix the issue @rdanyliw found. Hopefully.

* More fixes

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-12-14 15:05:00 -06:00
Robert Sparks 4216c129fe
fix: change verbosity of api key purge mgmt command (#6758)
* fix: change verbosity of api key purge mgmt command

* test: adjust mgmt command test arguments
2023-12-14 15:04:27 -06:00
Paul Selkirk cfaf84f08f
refactor: Convert custom form template to bootstrap (#6763)
* refactor: Convert custom form template to bootstrap

* refactor: Match form fields to old version
2023-12-14 14:19:22 -06:00
Ryan Cross e9d44d41f0
feat: Capture volunteers from the registration system (#6605)
* feat: Capture volunteers from the registration system. Fixes #5938

* fix: allow withdrawn field to be null

* docs: add explanatory code comments

* fix: identify current nomcom by is_accepting_volunteers

* fix: use auto_now_add instead of auto_now

* fix: update migration

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-12-14 13:46:27 -06:00
Robert Sparks 501a5b8e58
fix: consider subseries when calculating downref (#6777) 2023-12-14 09:35:30 -06:00
Jennifer Richards 6083205cc8
fix: Update group dependencies for new rfc model (#6773)
* fix: Avoid accessing slug when state is None

* fix: ignore pre-rfc drafts as rfc-to-rfc references

* fix: also ignore pre-rfc to pre-rfc refs

* chore: remove breakpoint

* fix: ignore subseries non-downrefs

* fix: label nodes as RFCS when possible

* fix: get "rfc" flag right

* chore: Remove comment, answer seems to be "no"

* refactor: Specify state type; drop redundant source doc type check

We're only admitting source__type="draft", so
no need to check it again in filter queries

* refactor: Specify state type in old code
2023-12-14 09:29:55 -06:00
Robert Sparks 6ccf9080b4
Merge pull request #6776 from rjsparks/statsfixes
fix: gather interesting years for stats accounting for published rfcs
2023-12-13 15:22:58 -06:00
Robert Sparks e130a301de
fix: gather interesting years for stats accounting for published rfcs 2023-12-13 13:14:38 -06:00
Robert Sparks d74d5ed233
fix: ignore attempts to look for versions of rfcs, but find the rfc. 2023-12-13 11:54:22 -06:00
Robert Sparks e211dc57d4
feat!: RFCs and subseries as Document types 2023-12-11 09:36:21 -06:00
Robert Sparks 4823dfe8eb
chore: move some things that had been moved but later touched in main again (#6751) 2023-12-07 18:27:08 -04:00
Jennifer Richards cbe710d3fd
fix: Migrate and handle subseries IprDocRels (#6745)
* chore: Stash orig IprDocRel document alias

* chore: Point IprDocRel at subseries docs

* fix: Fix IprDocRel.document usage in templates

* fix: Handle subseries in IprDocRel.formatted_name()

* refactor: Better presentation of IprDocRel subseries

* fix: Allow blank originaldocumentaliasname
2023-12-07 15:40:18 -04:00
Jennifer Richards dd41234bb4
fix: Allow blank originaltargetaliasname (#6748) 2023-12-07 15:01:55 -04:00
Jennifer Richards 8351b4528f
test: RFC pub date is in RPC_TZINFO (#6747) 2023-12-07 11:57:24 -04:00
Jennifer Richards 2e2960a2af
refactor: Use type_id="rfc" in migration (#6746) 2023-12-07 11:38:03 -04:00
Robert Sparks ce918c4d18
chore: remove management commands already removed in main 2023-12-05 13:14:52 -06:00
Robert Sparks 402186477f
chore: reorder migrations 2023-12-05 12:15:17 -06:00
Robert Sparks 03e161bae9
chore: merge branch 'main' into feat/rfc 2023-12-05 09:12:11 -06:00
Paul Selkirk 5006ea53e6
fix: Reject obvious bad encoding pastes into the Submitter field in submissions (#6702) 2023-12-04 13:10:36 -06:00
Robert Sparks e7bf4e0931
fix: replace copy of draft minutes on iesg moderator page with a link 2023-11-30 12:04:31 -06:00
Jennifer Richards e3ba021e1d
feat: Teach ajax_select2_search about subseries (#6709)
* feat: Teach ajax_select2_search about subseries

* refactor: "draft,rfc" -> "all" in a missed spot
2023-11-30 11:22:32 -04:00
Jennifer Richards ddebdf0263
test: Add delay to upcoming mtg filter tests (#6707) 2023-11-29 16:02:27 -06:00
Jennifer Richards b281919d4c
feat: Sort RFCs on subseries views; fix page title (#6704)
* feat: Sort RFCs on subseries doc pages

* feat: Sort RFCs on subseries index pages

* fix: Show subseries doc name as page title

* refactor: Use prettystdname filter for consistency
2023-11-29 12:34:18 -06:00
Jennifer Richards b011f0ab32
fix: Show requested rev if it is current, even w/o dochistory (#6703) 2023-11-29 08:20:46 -06:00
Jennifer Richards d1909fd0c3
fix: Combine Group and GroupHistory when counting (#6701)
* fix: Combine Group and GroupHistory when counting

* refactor: Use same symbol in parallel iterators

* fix: Handle group acronym changes in assertion

* refactor: Avoid reference to GroupHistory in assertions

* chore: Revert so assertion fails on changed acronym

The filtering and meeting displays disagree on how to handle this,
so let's get a notification if it comes up in production.
2023-11-28 14:06:36 -06:00
Kesara Rathnayake f442d6c0af
fix: Remove extra spaces in bibtex (#6688) 2023-11-27 08:13:14 -06:00
Robert Sparks 9dec409b41
feat: iab workshops (#6684)
* feat: iab workshops

* chore: keep names fixture up to date
2023-11-27 08:09:30 -06:00
Nicolas Giard 8bd5d9481f
fix: chatlog component missing pinia + agenda switch to text dark mode colors (#6653) 2023-11-22 12:43:20 -06:00
Jennifer Richards 62775bc56e
chore: Squelch celery deprecation warning (#6662) 2023-11-22 08:59:53 -06:00
Kesara Rathnayake bcca519d67
fix: Fix document not found bug in rfcdiff API (#6681)
Fixes #6675
2023-11-22 08:37:45 -06:00
Robert Sparks 2137dd8491
fix: teach ajax_select2_search_docs about rfcs (#6679) 2023-11-21 15:33:44 -06:00
Lars Eggert 3d44825333
ci: Switch to using geckodriver (#6541)
* Switch to using geckodriver

* Switch to selenium 4

* Undo

* Remove comment

* Fixes

* Restore non-standard line endings to minimize diff

* Undo

* Remove comment

* test: Fix test_upcoming_view_time_zone_selection

The inputs are hidden and managed by JS, so click
the visible elements instead.

* test: Clumsy fix to test_upcoming_materials_modal

Waiting for the button to be clickable does not
work because the modal is still fading in, so does
not actually close. Would be better to check for it
responding, but I haven't found the right way to do
that yet.

* test: Fix test_add_author_forms

Sending '\n' does not seem to work as it did before,
so click the option instead.

Also reverted some fixme hacks that seem to be obe.

* ci: Update base.Dockerfile

* test: add resource limits to dev/tests/debug.sh env

* ci: add upload of geckodriver.log on failure

* ci: run tests as user 1001

* ci: run app-create-dirs as sudo

* ci: set home folder to root to run tests

---------

Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
Co-authored-by: Nicolas Giard <github@ngpixel.com>
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-11-21 15:30:50 -06:00
Robert Sparks eb22d6a12f
fix: address dangling pyflake (#6678) 2023-11-21 13:17:55 -06:00
Robert Sparks b760248cc0
fix: correct stream document view (#6677)
* fix: correct stream document view

* fix: better filtering for stream view
2023-11-21 12:33:36 -06:00
Jennifer Richards ab3864e07a
refactor: Minor clean up of rfc index sync (#6661)
* chore: Remove commented code

* refactor: Drop unneeded local variable

* refactor: Eliminate no-op code branch
2023-11-17 17:09:11 -04:00
Jennifer Richards 4ac1153d7d
fix: Label draft change log with rfc number (#6659)
* fix: Label draft change log with rfc num

* test: Update test
2023-11-17 15:49:34 -04:00
Jennifer Richards b215867cb1
chore: Reorder migrations (#6660) 2023-11-17 14:56:21 -04:00
Robert Sparks c1627ed011
fix: restore attendee dbtemplate for old meetings pending data correction (#6656)
* fix: restore attendee dbtemplate for old meetings pending data correction

* test: adjust attendees test to match workaround
2023-11-17 10:01:09 -06:00
Robert Sparks b89c44f443
chore: merge main and fix new views 2023-11-16 15:58:22 -06:00
Robert Sparks 0051aa9844
fix: search correct doc type/states, switch rfc correctly in html_body, remove dead code. (#6640)
* fix: search correct doc type/states, switch rfc correctly in html_body, remove dead code

* chore: Add unreachable() marker

---------

Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
2023-11-16 13:05:58 -06:00
Robert Sparks 925e22006b
ci: change test coverage fudge factor (#6649) 2023-11-16 12:46:36 -06:00
Robert Sparks 9fedce005f
fix: restore rfcs on document graph when looking at rfc predecesors (#6646) 2023-11-16 12:49:50 -04:00
Robert Sparks a035c93351
fix: favor RFCs over drafts in related document section (#6643) 2023-11-16 11:08:16 -04:00
Jennifer Richards 53e232302e
fix: Sort milestones for groups not using dates (#6642)
* fix: Respect uses_milestone_dates == False

* test: Test milestone ordering

* test: Fix temp variable naming
2023-11-15 13:32:27 -06:00
Lars Eggert c36f63baf9
feat: Revamp AD dashboard (#6534)
* fix: Reorder conflict review columns

Fixes #6528

Also remove some redundant computation while I'm here.

* Remove some more stuff that isn't needed

* Progress

* Delivers current functionality

* Add some comments

* Handle expired docs

* Interim commit

* Fix tests

* Cleanup

* More cleanup

* Reduce differences to current view

* Interim commit

* More progress

* Getting close

* Make page functional again

* Remove unused variable

* Suppress mypy warning

* Fix #6553

* Log in as secretary to execute new code, and remove redundant check

* Remove unneeded code

* Fix #6608 by adding link to state description to state heading

* Missed part of this change in last commit.

Also fix an unrelated template nit while I'm here.
2023-11-15 11:25:30 -06:00
Robert Sparks 4fa8bfa543
fix: use correct doc types and states for rfcs (#6639) 2023-11-15 10:08:39 -04:00
Lars Eggert 5d2ac56858
feat: Now that charters are Markdown, render them as such on charter page (#6628) 2023-11-10 09:26:02 +01:00
Eric Vyncke 639043e890
Fix: meeting important dates can have markdown links (#6594)
* Fix #3911 by adding a markdown filter for template

* fix: move the new markdown filter to utils

* fix: linkify after markdown

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
2023-11-10 09:24:13 +01:00
Ryan Cross 2974e81624
fix: build proceedings attendee list from MeetingRegistration table. … (#6567)
* fix: build proceedings attendee list from MeetingRegistration table. Fixes #6265

* fix: move participants_for_meeting to meeting.utils

* fix: move test_participants_for_meeting to meeting tests
2023-11-07 13:09:19 +01:00
Rich Salz bb8cf21bd1
fix: show nomcoms by convening year only (#6585)
* ci: Update build-base-app.yml workflow

* fix: Relabel NomCom to show start year, not range

Show just the year that a NomCom started, because showing
the start/end years is confusing.

Fixes: #3419

* fix: Shwo Nomcoms year convened only

Fix the main nomcom index page and the announcement archive page

---------

Co-authored-by: Nicolas Giard <github@ngpixel.com>
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-11-07 09:57:19 +01:00
Rich Salz 35bec48e90
fix: Update NomCom references (#6583)
Add nomcom eligibility RFC to the references section

Fixes: #6581

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-11-07 09:53:49 +01:00
Paul Selkirk 2bec81da95
fix: Don't include csrf_token in GET-only form (#6549) 2023-11-07 09:50:23 +01:00
Ryan Cross 6986e65665
fix: prevent creation of duplicate MeetingRegistration records (#6593)
* fix: prevent creation of duplicate MeetingRegistration records

* fix: use get_or_create to prevent duplicate MeetingRegistrations

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-11-06 18:22:42 +01:00
Peter Yee f1425e4a52
fix: move meeting management from base Docs to Meeting (#6586)
* fix: move meeting management from base Docs to Meeting

* fix: add permission check for ability to request an interim meeting

* fix: guard against no user being logged in

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-11-06 17:45:07 +01:00
Tero Kivinen f8a06f663e
fix: Add history entry when approving the slides. (#6588)
* Added history entry when approving the slides.

Also changed os.rename to shutils.move as the submissions and
proceedings are on the separate filesystems on the docker image,
and this same thing might happen in the real environment in the
future.

* Add migrations for the docevents type.
2023-11-06 17:19:32 +01:00
Robert Sparks 37c796ebef
fix: repair ad-dashboard test 2023-11-06 09:39:10 +01:00
Robert Sparks b78eb448a5
chore: remove some unused code 2023-11-06 09:12:40 +01:00
Robert Sparks 195926ada7
fix:bring rfc-index sync test into sync with function changes 2023-11-05 14:47:43 +01:00
Robert Sparks bdeab001e6
chore: sync subseries index test with view changes 2023-11-05 13:56:50 +01:00
Robert Sparks 801b79fbb1
fix: repair is_downref 2023-11-05 13:49:56 +01:00
Robert Sparks 3fea443f59
fix: use valid ids on subseries index page 2023-11-05 12:35:34 +01:00
Paul Selkirk b5ee9ec9ab
fix: Don't allow group chair to change group parent (#6496)
* fix: Don't allow group chair to change group parent (#6037)

* test: Fix test_edit_parent_field, add test_edit_parent (whole form)

* test: Verify that the chair can't circumvent the system to change the group parent

* fix: 403 if user tries to edit an unknown or hidden field

* fix: Give edwg GroupFeatures a parent type

This tracks a change that was made directly in the production database
to fix the immediate cause of #6037.

* Empty commit to trigger github unit test
2023-11-05 12:32:03 +01:00
Paul Selkirk a3b4162841
fix: Don't redirect user to the login page when logging in (#6570)
* fix: Don't redirect user to the login page when logging in (#5876)

(Embrace and extend c4bf508cd8.)

* test: Add test case for login button

* refactor: The template filter just strips off a path prefix, so rename/recode accordingly

Also test with a non-trivial redirect target.
2023-11-05 11:09:07 +01:00
Lars Eggert 1df7319e26
fix: Remove time from materials cell (#6584)
Fixes #6542
2023-11-05 11:04:25 +01:00
Lars Eggert 275b3b2b0a
fix: Make authors take at least two lines in HTMLized (#6606)
From 32f8003712

Fixes #6575
2023-11-05 10:40:34 +01:00
Tero Kivinen 2f5bbebf70
Add link to review request page to review result page. (#6596)
Remove link to self on review result page.
2023-11-05 09:57:04 +01:00
Tero Kivinen 53d0014826
feat: add "add comment" feature to the review requests. (#6603) 2023-11-05 09:29:25 +01:00
Robert Sparks 9a2b0cf947
fix: better empty text and prettystdname on subseries index view 2023-11-01 16:21:05 -05:00
Robert Sparks 3836f76052
feat: add subseries to main menu 2023-11-01 16:20:18 -05:00
Robert Sparks 575560a885
fix: don't parameterize search for subseries types. 2023-11-01 16:08:39 -05:00
Robert Sparks 71a760f05a
feat: show references to and from subseries 2023-11-01 15:57:34 -05:00
Robert Sparks 1f82fab2cd
fix: silenced (and explained) several warnings 2023-11-01 15:20:29 -05:00
Robert Sparks 942c4d42af
fix: better message on first import of subseries membership 2023-11-01 13:29:12 -05:00
Robert Sparks 986e002c1d
chore: repair merge damage 2023-11-01 12:41:15 -05:00
Robert Sparks 8e3e59079a
chore: reorder migrations 2023-11-01 11:45:23 -05:00
Robert Sparks 28c3e1bd5d
chore: merge branch 'main' into feat/rfc 2023-11-01 10:54:29 -05:00
Robert Sparks e65c4c3f7f
fix: use clearer descriptions on docevents for initial sync run 2023-10-31 16:36:47 -05:00
Robert Sparks 320ca6232b
chore: remove spurious whitespace change 2023-10-31 15:54:15 -05:00
Robert Sparks 0afe496aa3
fix: preserve RelatedDocument references to subseries 2023-10-31 15:52:11 -05:00
Robert Sparks 466921728f
chore: reorder migrations 2023-10-31 11:56:44 -05:00
Lars Eggert d246879069
Fix code review comments 2023-10-27 17:29:09 -07:00
Robert Sparks 1130f1f790
Merge branch 'main' into feat-md-bs 2023-10-25 20:46:00 -05:00
Lars Eggert 6d87279895
fix: BCPs can normatively cite all other standards levels (#6530)
* fix: BCPs can normatively cite all other standards levels

Fixes #6524

* Revise the logic and add tests

* Fix bug in truth table
2023-10-25 20:43:05 -05:00
Lars Eggert 5f8bf4b6f7
Merge branch 'main' into feat-md-bs 2023-10-25 20:23:33 +02:00
Ryan Cross 601ab53db9
refactor: remove secr IPR admin link (#6540) 2023-10-25 12:45:22 -05:00
Jennifer Richards be4a6ef6f5
chore: Revert agenda editor font change (#6538)
* Revert "fix: Change some colors to make agenda tool work in dark mode (#6428)"

This reverts commit 699a8e2d9e.

* Revert "Revert "fix: Change some colors to make agenda tool work in dark mode (#6428)""

This reverts commit 5adafac4cb7896e9dd309a3385ec9aab5035e7d3.

* chore: Revert only font-family change

* chore: Add comment to ietf.scss
2023-10-25 12:43:17 -05:00
Lars Eggert c2a44dbad0
fix: Use d-none class instead of hide (#6535)
Fixes #6531
2023-10-25 08:37:14 -05:00
Lars Eggert 888a4f2efe
fix: Add link to session to material metadata (#6536)
* fix: Add link to session to material metadata

Fixes #6533

* Fix CI
2023-10-25 08:28:50 -05:00
Lars Eggert e7639e94ed
Merge branch 'main' into feat-md-bs 2023-10-24 19:49:17 +02:00
Lars Eggert fd03ab13d7
Small fixes 2023-10-23 17:44:12 -07:00