Commit graph

4054 commits

Author SHA1 Message Date
Robert Sparks 8cb7f3dcae
feat: Import IESG artifacts into the datatracker (#6908)
* chore: remove unused setting

* feat: initial import of iesg minutes

* fix: let the meetings view show older iesg meetings

* feat: iesg narrative minutes

* feat: import bof coordination call minutes

* wip: import commands for iesg appeals and statements

* feat: import iesg statements.

* feat: import iesg artifacts

* feat: many fewer n+1 queries for the group meetings view

* fix: restore chain of elifs in views_doc

* fix: use self.stdout.write vs print in mgmt commands

* fix: use replace instead of astimezone when appropriate

* chore: refactor new migrations into one

* fix: transcode some old files into utf8

* fix: repair overzealous replace

* chore: black

* fix: address minro review comments

* fix: actually capture transcoding work

* fix: handle multiple iesg statements on the same day

* fix: better titles

* feat: pill badge replaced statements

* fix: consolodate source repos to one

* feat: liberal markdown for secretariat controlled content

* fix: handle (and clean) html narrative minutes

* feat: scrub harder

* fix: simplify and improve a scrubber

* chore: reorder migrations
2024-02-20 16:35:08 -06:00
Jennifer Richards 5fc0f6926b
feat: Show room functional name when editing timeslots (#7075)
* feat: Show functional name in str(Room)

* feat: Show func name in edit_timeslots.html

* test: Update test_location_options
2024-02-20 11:02:48 -06:00
Paul Selkirk 52a707628f
feat: Links to chatlogs and session recordings on proceedings page (#7042)
* feat: Links to chatlogs and session recordings on proceedings page (#6791)

* refactor: Add a url template and convenience function for session_recording url

* refactor: Avoid using the walrus operator
2024-02-20 09:40:31 -06:00
Paul Selkirk 9ab820fca9
fix: Expand and enforce Cancel Interim Meeting Request comments length to 512 (#7069)
* fix: Expand and enforce Cancel Interim Meeting Request comments length to 512 (#6998)

* fix: Verify comment text in generated email
2024-02-20 09:30:41 -06:00
Paul Selkirk 3ba39c956a
refactor: Remove BOF chairs from bofreq template, because BOF requesters shouldn't fill it in (#7065) 2024-02-15 09:43:39 -06:00
Robert Sparks ae01f6fb92
chore: clean away unused views/tests related to the Allowlisted model (#7027) 2024-02-06 09:39:09 -06:00
Robert Sparks d9cc26be96
feat: replace references to User with references to Person (#6024)
* refactor: change references from User to Person (#5821)

* refactor: Change CommunityList reference from User to Person

* refactor: Convert more user references to person

* refactor: Change augment_docs_and_user_with_user_info to person

* refactor: Change Nomination and Feedback references from User to Person

* refactor: Change a few test case function signatures to be more pythonic

* refactor: Harmonize how profile and photo views look up email_or_name

* refactor: Rework community views to operate on Person instead of User (#5859)

* test: Update tests to try all of the person's emails and aliases

* fix: Recode a test case to avoid an exception if there's Unicode in the URL

This only happens using the form-filling and submission feature of
WebTest, which is only used in this one test case, so just it rip out.

* test: Add duplicate-person tests

* fix: If there are multiple matching users, prefer the logged-in one.

* chore: We no longer use WebTest, so don't include it.

* fix: Address review comments

* fix: case-insensitive person name or email matching (#6096)

* chore: Renumber migrations

* fix: Update merged code so tests pass (#6887)

* fix: Use refactored method

* fix: Don't assume user has person

* fix: Use new view param name

* chore: Drop community lists w/o person; cleanup (#6896)

* fix: Don't assume user has person

* fix: user->person in update_community_list_index.py

* feat: Remove CommunityLists without Person

* refactor: Speed up nomcom migrations

---------

Co-authored-by: Paul Selkirk <paul@painless-security.com>
Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
2024-01-24 11:00:19 -06:00
Robert Sparks 06f496ca6c
fix: reduce database queries when building menues (#6928) 2024-01-17 13:19:20 -06:00
Jennifer Richards cb70da9584
fix: Never show AD col on drafts_for_ad.html (#6914)
* fix: Pass ad as Person instead of name

* refactor: Remove redundant AD check

Results being shown are already filtered by AD if the `ad`
variable is not `None`

* refactor: Add show_ad... flag to prepare_document_table

* refactor: Expose show_ad_and_shepherd flag
2024-01-12 16:39:59 -06:00
Jennifer Richards c7ca0b7d8e
Revert "chore: Replace markup_txt with rfc2html (#6632)" (#6909)
This reverts commit e24fb601db.
2024-01-11 13:08:24 -06:00
Robert Sparks 38ffd8ad2e
fix: correct DATE DTEND values - they are non-inclusive (#6907) 2024-01-10 13:55:07 -06:00
Robert Sparks 3312913c6f
fix: better archive search links for group documents (#6835) 2024-01-09 15:17:11 -06:00
Lars Eggert e24fb601db
chore: Replace markup_txt with rfc2html (#6632)
* chore: Replace markup_txt with rfc2html

* Suppress HTML issues

* Remove comment

* Suppress harder

* Suppress even more

* Fix test

* Ignore vnu "duplicate ID" errors

* Undo accidental commit

* Fix RFCs

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2024-01-05 12:29:28 -06:00
Paul Selkirk 02e0d960a4 fix: Correctly display the last pre-RFC rev of a draft 2024-01-04 00:50:08 -05:00
Paul Selkirk 748bcc328f
fix: Wrap weasyprint to catch exceptions (#6728)
* fix: Wrap weasyprint to catch exceptions (#6324)

* test: Restore socket function after test

* test: Use mock instead of monkeying with sockets

* refactor: Log the error

* fix: Don't catch non-Exception interruptions

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-12-27 11:56:38 -06:00
Paul Selkirk 1450ecde99
fix: Retain date of cancelled virtual interim meeting (#6708) (#6852) 2023-12-27 10:39:13 -06:00
Paul Selkirk c1e40ff100
feat: Allow entering agenda text directly (#6792)
* feat: Allow entering agenda text directly (#6532)

* fix: Hide label as well as file/text input box

* refactor: Package javascript for static/dist

* fix: Fix test cases broken by view changes

* test: Add test case for entering agenda text

* refactor: assertRedirects
2023-12-20 16:40:13 -06:00
Jennifer Richards 149f82f578
fix: Include refs to pre-RFC drafts as refs to the RFC (#6784)
* fix: clean up shadowed name in document_referenced_by.html

* fix: include refs to rfc's came_from_draft()

* fix: include refs to draft's became_rfc()

* fix: Count indirect refs by RFCs

* refactor: break indirect ref_by counting to its own fn

* fix: only count refs to pre-rfc draft, not post-draft rfc

(and rename a method)

* test: test referenced_by_rfcs methods

The test_referenced_by_rfcs_as_rfc_or_draft() test
fails because there's a bug!

* test: actually, do double-count refs to rfc/draft

Let's do include refs to an rfc and its precursor draft
as separate refs. This almost surely indicates a data
error because it would mean an rfc referenced both an
rfc and the draft that it came from. That should never
be allowed, so at least let some light fall on it if
it happens.

* chore: Add docstring to document_referenced_by view
2023-12-18 09:11:53 -06:00
Paul Selkirk cfaf84f08f
refactor: Convert custom form template to bootstrap (#6763)
* refactor: Convert custom form template to bootstrap

* refactor: Match form fields to old version
2023-12-14 14:19:22 -06:00
Robert Sparks e211dc57d4
feat!: RFCs and subseries as Document types 2023-12-11 09:36:21 -06:00
Jennifer Richards cbe710d3fd
fix: Migrate and handle subseries IprDocRels (#6745)
* chore: Stash orig IprDocRel document alias

* chore: Point IprDocRel at subseries docs

* fix: Fix IprDocRel.document usage in templates

* fix: Handle subseries in IprDocRel.formatted_name()

* refactor: Better presentation of IprDocRel subseries

* fix: Allow blank originaldocumentaliasname
2023-12-07 15:40:18 -04:00
Robert Sparks 03e161bae9
chore: merge branch 'main' into feat/rfc 2023-12-05 09:12:11 -06:00
Robert Sparks e7bf4e0931
fix: replace copy of draft minutes on iesg moderator page with a link 2023-11-30 12:04:31 -06:00
Jennifer Richards e3ba021e1d
feat: Teach ajax_select2_search about subseries (#6709)
* feat: Teach ajax_select2_search about subseries

* refactor: "draft,rfc" -> "all" in a missed spot
2023-11-30 11:22:32 -04:00
Jennifer Richards b281919d4c
feat: Sort RFCs on subseries views; fix page title (#6704)
* feat: Sort RFCs on subseries doc pages

* feat: Sort RFCs on subseries index pages

* fix: Show subseries doc name as page title

* refactor: Use prettystdname filter for consistency
2023-11-29 12:34:18 -06:00
Kesara Rathnayake f442d6c0af
fix: Remove extra spaces in bibtex (#6688) 2023-11-27 08:13:14 -06:00
Nicolas Giard 8bd5d9481f
fix: chatlog component missing pinia + agenda switch to text dark mode colors (#6653) 2023-11-22 12:43:20 -06:00
Robert Sparks 2137dd8491
fix: teach ajax_select2_search_docs about rfcs (#6679) 2023-11-21 15:33:44 -06:00
Robert Sparks c1627ed011
fix: restore attendee dbtemplate for old meetings pending data correction (#6656)
* fix: restore attendee dbtemplate for old meetings pending data correction

* test: adjust attendees test to match workaround
2023-11-17 10:01:09 -06:00
Robert Sparks b89c44f443
chore: merge main and fix new views 2023-11-16 15:58:22 -06:00
Lars Eggert c36f63baf9
feat: Revamp AD dashboard (#6534)
* fix: Reorder conflict review columns

Fixes #6528

Also remove some redundant computation while I'm here.

* Remove some more stuff that isn't needed

* Progress

* Delivers current functionality

* Add some comments

* Handle expired docs

* Interim commit

* Fix tests

* Cleanup

* More cleanup

* Reduce differences to current view

* Interim commit

* More progress

* Getting close

* Make page functional again

* Remove unused variable

* Suppress mypy warning

* Fix #6553

* Log in as secretary to execute new code, and remove redundant check

* Remove unneeded code

* Fix #6608 by adding link to state description to state heading

* Missed part of this change in last commit.

Also fix an unrelated template nit while I'm here.
2023-11-15 11:25:30 -06:00
Lars Eggert 5d2ac56858
feat: Now that charters are Markdown, render them as such on charter page (#6628) 2023-11-10 09:26:02 +01:00
Eric Vyncke 639043e890
Fix: meeting important dates can have markdown links (#6594)
* Fix #3911 by adding a markdown filter for template

* fix: move the new markdown filter to utils

* fix: linkify after markdown

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
2023-11-10 09:24:13 +01:00
Ryan Cross 2974e81624
fix: build proceedings attendee list from MeetingRegistration table. … (#6567)
* fix: build proceedings attendee list from MeetingRegistration table. Fixes #6265

* fix: move participants_for_meeting to meeting.utils

* fix: move test_participants_for_meeting to meeting tests
2023-11-07 13:09:19 +01:00
Rich Salz bb8cf21bd1
fix: show nomcoms by convening year only (#6585)
* ci: Update build-base-app.yml workflow

* fix: Relabel NomCom to show start year, not range

Show just the year that a NomCom started, because showing
the start/end years is confusing.

Fixes: #3419

* fix: Shwo Nomcoms year convened only

Fix the main nomcom index page and the announcement archive page

---------

Co-authored-by: Nicolas Giard <github@ngpixel.com>
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-11-07 09:57:19 +01:00
Rich Salz 35bec48e90
fix: Update NomCom references (#6583)
Add nomcom eligibility RFC to the references section

Fixes: #6581

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-11-07 09:53:49 +01:00
Paul Selkirk 2bec81da95
fix: Don't include csrf_token in GET-only form (#6549) 2023-11-07 09:50:23 +01:00
Peter Yee f1425e4a52
fix: move meeting management from base Docs to Meeting (#6586)
* fix: move meeting management from base Docs to Meeting

* fix: add permission check for ability to request an interim meeting

* fix: guard against no user being logged in

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-11-06 17:45:07 +01:00
Robert Sparks 3fea443f59
fix: use valid ids on subseries index page 2023-11-05 12:35:34 +01:00
Paul Selkirk a3b4162841
fix: Don't redirect user to the login page when logging in (#6570)
* fix: Don't redirect user to the login page when logging in (#5876)

(Embrace and extend c4bf508cd8.)

* test: Add test case for login button

* refactor: The template filter just strips off a path prefix, so rename/recode accordingly

Also test with a non-trivial redirect target.
2023-11-05 11:09:07 +01:00
Lars Eggert 1df7319e26
fix: Remove time from materials cell (#6584)
Fixes #6542
2023-11-05 11:04:25 +01:00
Tero Kivinen 2f5bbebf70
Add link to review request page to review result page. (#6596)
Remove link to self on review result page.
2023-11-05 09:57:04 +01:00
Tero Kivinen 53d0014826
feat: add "add comment" feature to the review requests. (#6603) 2023-11-05 09:29:25 +01:00
Robert Sparks 9a2b0cf947
fix: better empty text and prettystdname on subseries index view 2023-11-01 16:21:05 -05:00
Robert Sparks 3836f76052
feat: add subseries to main menu 2023-11-01 16:20:18 -05:00
Robert Sparks 71a760f05a
feat: show references to and from subseries 2023-11-01 15:57:34 -05:00
Robert Sparks 28c3e1bd5d
chore: merge branch 'main' into feat/rfc 2023-11-01 10:54:29 -05:00
Lars Eggert 5f8bf4b6f7
Merge branch 'main' into feat-md-bs 2023-10-25 20:23:33 +02:00
Lars Eggert c2a44dbad0
fix: Use d-none class instead of hide (#6535)
Fixes #6531
2023-10-25 08:37:14 -05:00
Lars Eggert 888a4f2efe
fix: Add link to session to material metadata (#6536)
* fix: Add link to session to material metadata

Fixes #6533

* Fix CI
2023-10-25 08:28:50 -05:00