Commit graph

222 commits

Author SHA1 Message Date
Ole Laursen 9457669310 Merge in changes from the old shimfree branch
- Legacy-Id: 6764
2013-11-27 12:55:50 +00:00
Ole Laursen ecf68dbb05 Revamp and clean up submit models:
- Rename IdSubmissionDetail to Submission
- Rename various submission fields to correspond to the conventions in
  the new schema
- Use a name model for the states instead of IdSubmissionStatus
- Drop the TempIdAuthor model which is based on splitting up author
  names
- Add a simple textual SubmissionEvent for tracking events in the
  lifetime of a submission
- Delete a bunch of obsolete fields
- Make sure all submission have an access key so we can depend on it
- Add state for when approval is needed from previous authors

A couple of migrations take care of transforming the
IdSubmissionDetail and moving data over/cleaning it up.

Also revamp the submit view code:

- Make form code do validation/cleaning only so there's a clear
  separation of concerns
- Reduce uses of inheritance that made the code hard to follow -
  forms now don't inherit from each other, views don't call each other
  but instead reuse common utilities, templates share CSS/utilities
  instead of relying on inheritance
- Move email rendering/sending to separate file
- Drop the in-grown terminology use (auto post vs. manual posts)
- Make the status page explain who is emailed for what purpose
- Add history table with recorded events
- Make the status page handle its post actions by itself instead of
  duplicating most of the setup logic in a number of simple views
- Fix a couple of minor bugs and handle some edge cases better
- Expand tests with a couple of more cases

Possibly the submit tool could still use more help text added to
explain the process, ideally what's explained in the tool instructions
page should be inlined or self-evident.
 - Legacy-Id: 6714
2013-11-15 13:30:32 +00:00
Ole Laursen 8020650566 Fix color of links in form errors
- Legacy-Id: 6700
2013-11-11 12:52:07 +00:00
Henrik Levkowetz 8e8cfc05db Changed things so the left-side navbar doesn't jump to full page width in the instant before the main content is loaded. NB: Cleanup action needed: replace all px dimensions with em, consistently.
- Legacy-Id: 6650
2013-11-04 20:46:15 +00:00
Ole Laursen d915a31833 Add some styling from previous adaptation of Secretariat telechat tool that were missing from the commit
- Legacy-Id: 6467
2013-10-18 16:42:30 +00:00
Henrik Levkowetz a7838d8765 Cleanup action: replaced screaming html id with non-screaming version;
replaced the noTable block construct with start/end table_content blocks
in order to not have to open and close tables in different blocks, and
not have empty tables lying about.
 - Legacy-Id: 6439
2013-10-13 21:09:32 +00:00
Ole Laursen 1975ff27d0 Port IESG discusses to new schema
- Legacy-Id: 6418
2013-10-11 13:03:40 +00:00
Ole Laursen d11f2331fe Remove invalid text-align: top from CSS
- Legacy-Id: 6417
2013-10-11 13:02:08 +00:00
Henrik Levkowetz a3c8adfdf6 Merged in the contents of commit [6337] from mcr@sandelman.ca, with some changes to take out dead code that inadvertently came back in.
- Legacy-Id: 6344
Note: SVN reference [6337] has been migrated to Git commit d0d1d949a9328da6c4e30d8f5e0d14ffb204e678
2013-10-02 21:53:28 +00:00
Henrik Levkowetz 08e90fd63f Enabling jquery again in template base.html. Moving library pack jquery-1.8.2 from /static/js/ to /static/js/lib/. Replacing jquery-1.5.1 with 1.8.2 in some places; the incompatibilities listed on the jquery pages seem to be small, and on a cursory inspection not present in the current usage.
- Legacy-Id: 6342
2013-10-02 15:44:50 +00:00
Henrik Levkowetz ae666688f7 Added missing TXT_icon
- Legacy-Id: 6323
2013-09-30 20:48:38 +00:00
Henrik Levkowetz 95f9436507 Undid gratuitous whitespace changes.
- Legacy-Id: 6287
2013-09-26 22:00:45 +00:00
Henrik Levkowetz ad7ba6e494 Undid gratuitous whitespace changes.
- Legacy-Id: 6286
2013-09-26 21:58:09 +00:00
Henrik Levkowetz 6154b9922d This commit isn't tested. It captures the state after merging in branch/ssw/agenda/v4.70.
- Legacy-Id: 6273
2013-09-26 19:56:17 +00:00
Henrik Levkowetz 0016c69b61 Added an index page for nomcoms, at /nomcom/, with links to nomcom pages and announcements, where they exist.
- Legacy-Id: 6245
2013-09-22 18:59:24 +00:00
Ole Laursen 2e29298d0c Move group charter actions from box and button next to header up to an
edit menu under the ordinary group menu
 - Legacy-Id: 6219
2013-09-20 14:09:30 +00:00
Ole Laursen 019ca2ae03 Merge changes from attic/shimfree into new branch to complete rebasing shimfree on trunk
- Legacy-Id: 6215
2013-09-20 09:48:58 +00:00
Henrik Levkowetz d8074d39d3 Merged the latest secretariat code from rcross@amsl.com, from branch/amsl/trunkmerge@6149.
- Legacy-Id: 6168
2013-09-18 19:33:36 +00:00
Henrik Levkowetz 78a0fd7759 Added a dev-specific robots.txt, which blocks all robots.
- Legacy-Id: 6164
2013-09-18 17:44:51 +00:00
Ryan Cross 097c920b33 Rename secretariat static files subdirectory. Branch ready for merge.
- Legacy-Id: 6149
2013-09-12 18:33:16 +00:00
Ole Laursen 3c8f5d3521 CSS styling for state help icon
- Legacy-Id: 6135
2013-09-10 16:16:11 +00:00
Henrik Levkowetz 5a06a9f17c Tweaked the nomcom private menus a bit.
- Legacy-Id: 6025
2013-08-09 18:19:00 +00:00
Henrik Levkowetz c345d2f9d6 Fixed the red-on-red error message style which came in with the nomcom code merge.
- Legacy-Id: 5993
2013-08-08 12:25:42 +00:00
Henrik Levkowetz 6baea429aa Merged in the nomcom app from ejimenez@yaco.es and esanchez@yaco.es, and accompanying dbtemplate app and the (standard) docutils module. Added some tweaks to get all tests to pass and migrations to run.
- Legacy-Id: 5948
2013-08-06 10:09:29 +00:00
Henrik Levkowetz 6794113320 Merged [5898] from adam@nostrum.com, with
additional tweaks from henrik: Added the capability to search for all kinds
 of documents in the main datatracker search page.  Fixes bug #838.
 - Legacy-Id: 5926
Note: SVN reference [5898] has been migrated to Git commit b14a8d0cee
2013-07-31 12:45:32 +00:00
Ryan Cross 744e302159 fix bug with upload form validation
- Legacy-Id: 5922
2013-07-30 14:57:37 +00:00
Ryan Cross b14e3ddce9 add javascript form validation to materials upload form
- Legacy-Id: 5919
2013-07-30 13:01:38 +00:00
Ryan Cross 5855140136 changes to announcements: default reply_to=ietf@ietf.org, widen body field, add back button
- Legacy-Id: 5889
2013-07-27 10:16:23 +00:00
Henrik Levkowetz dfee10aa92 Restored the functionality of showing both AD and Shepherd for documents
shown for searches and document lists.
 - Legacy-Id: 5842
2013-07-18 15:42:30 +00:00
Henrik Levkowetz b31c781603 Reverted changes to document ballot colours -- the colours that came in with
the shimfree merge [5836] don't work as well for some kinds of
colour-blindness.
 - Legacy-Id: 5839
Note: SVN reference [5836] has been migrated to Git commit cbfe489ff5
2013-07-17 21:59:53 +00:00
Henrik Levkowetz cbfe489ff5 Merged in more shim-layer removals from olau@iola.dk
(-r5465:HEAD from branch/iola/shimfree).  Copying relevant
commit messages here:

 - Deleted dead code in many places.

 - Renamed id-something to draft-something, make the "is
   this eligible for expiration" logic clearer

 - Added a name for IPR search URL

 - Revamped the ballot popup view

 - URL reversed the IPR search link instead of hardcoding it

 - Cleaned up search views and remove dead code, port them to the new DB
   schema, hack related views in iesg/ and wginfo/ to use the new search
   interfaces, avoid camelCase in search GET parameters (with
   backwards-compat fallback), add some simple search unit tests, remove
   caching from views_search.py index pages as they're now pretty fast to
   generate, rewrite ballot popup JS, regularize some CSS classes to use
   hyphen-notation rather than camelCase, move some of the search
   templates to doc/.

   idrfc/ now mostly contains some wrapper code still in use by other
   subdirs, some ported code not yet moved, and dead code.

 - Fixed output bug in test crawler and print referrer upon errors so it's
   easier to figure out where a link came from

 - Added /doc/in-last-call/ to crawler, report original page as referrer in
   a redirect chain rather than intermediate URL

 - Ported idindex to new schema, speed them up, add tests, refactor index
   page in views_search to share code with the text index file, get rid
   of some special-case idindex filters from ietf_filters, move
   "/drafts/" redirects to a file in /doc/

 - Ported /idtracker/status/ and /idtracker/status/last-call/ overview of
   drafts in IESG process to new schema in /doc/iesg/ and
   /doc/iesg/last-call/

 - Added redirects for all of /idtracker/*, removed all view code and other
   dead code from idtracker/

 - Removed the idtracker sitemap indexing drafts - in its current form,
   it adds nothing of value to the HTML-based /doc/all/ view, and it's
   pretty slow

 - Ported idtracker feeds to new schema, move them to doc/, cleaned up
   idtracker/ - only templatetags/ietf_filters and proxy code is left
 - Legacy-Id: 5836
2013-07-17 20:52:39 +00:00
Henrik Levkowetz e678659b56 Merged in a lot of shim-layer removals from olau@iola.dk
(-r5194:5465 from branch/iola/shimfree).  Copying relevant
commit messages here:

  - Removed .related many to many relationship, it's not really useful
    since we always have to restrict on the relationship type anyway,
    instead add two helpers for doing the necessary queries (in both
    directions)

  - Added migration for transforming the .desc on the new_revision events
    into something more akin to what is actually shown in the history page

  - Added migration for blanking IESG notes that just consist of "RFC
    XXXX", these have been superfluous for some time

  - Grant stream chairs access to changing the stream on a draft

  - Hacked the format_history_text filter to be less weird, using the same
    formatting for snippets and full text, also link up legacy ballot set
    events

  - Moved the decoraters + utilities to new ietfauth/utils.py file

  - Added simple helper to Email to identify invalid email addresses (from
    legacy author entries)

  - Used new new_revision .desc format for when drafts are submitted

  - Improved the looks of the button class by adding extra contrast and a
    linear gradient. Currently the gradient is only visible in fairly
    recent browsers.

  - Rewrote draft and RFC tabs in terms of the new schema, porting
    write-up and history tabs as well

  - Fixed two bugs in RFC Editor syncing: make sure documents we don't know
    beforehand get a "draft" type and make sure individually submitted
    drafts get the type="individ" group instead of NULL

  - Made the CSS-styled button feel a bit nicer to use by flattening the
    active state, also introduce some temporary styles until browsers
    catch up with the standard syntax

  - Added migrations for fixing 1) a dummy RFC entry, 2) three stand-alone
    RFCs that didn't get their doc.type set, 3) a big bunch of historic
    stand-alone RFCs that have doc.group=None - set these to the
    individual submission "none" group for the time being so the view code
    doesn't have to deal with a special case.

    In some cases this is wrong since there actually was a WG associated
    but unfortunately fixing them properly requires detective work
    (probably parsing the RFCs) and in at least some cases recreating
    historic WGs. In case someone ends up doing this, the documents to
    check can still be found with

    Document.objects.filter(name__startswith="rfc", group__type="individ")
    since there are almost no new RFCs that didn't went through the I-D
    process.

  - Merged the I-D and RFC views by showing I-D information on RFCs too.
    I-Ds that have been published as RFCs redirect to the RFC URL. Also
    support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.

  - Fixed revision augmentation so events after RFC publication gets a "RFC"
    designation

  - Fixed a bug with tabs not using provided name but rather doc.name

  - Displaying draft-iesg state rather than doc.friendly_state as IESG state,
    also show a notice that the IESG state refers to post-RFC processing
    if it does, like the old separate RFC page did

  - Fixed the RFC number doc.note migration to catch combined "RFC XXX; BCP
    XXX" notes too, use the opportunity to remove inserted HTML tags from
    notes and rely on linebreaksbr filter instead (the other thing was a
    left-over from the Perl days), update the various uses of the note to
    reflect that

  - Refactored slightly to make views_doc.py independent of other idrfc code

  - Moveed idrfc/views_doc.py to doc/ with associated templates, replace the
    somewhat fragile simple URL tests for views_doc.py with ordinary unit
    tests. The new tests are still fairly basic but at least test more
    than the URL tests did.

  - Made sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
    RFC0123 in the alias table with a new migration and a change to the
    RFC Editor sync, this in turn makes /doc/std1/ do the right thing

  - Now /doc/std1/ works, we can actually do a local link in
    urlize_ietf_docs rather than linking to the tools.ietf.org server

  - Fixed history text formatter: sanitize HTML before adding linebreaks and
    non-breaking spaces, this cuts the time to render a history page with
    long comments in half

  - Added a test crawler that walks through the crawlable part of the site,
    reporting errors and slow pages

  - Got rid of initial "No record" positions when showing old positions,
    it's just noise

  - Added a .select_related() to the document main tab to reduce the number
    of DB queries, unfortunately it seems it doesn't really help with
    Django 1.2.x due to a bug (Document inherits from DocumentInfo which
    makes things a bit more complicated)

  - Introduced a simple cache in doc.get_state so repeated reads don't
    cause a DB query

  - Cleaned up the search code in preparation for removal of the shim-layer;
    use a static button and don't send extraneous GET parameters

  - Removed dead code in several places
 - Legacy-Id: 5830
2013-07-15 20:55:24 +00:00
Henrik Levkowetz c696c0618d Removed duplicate '.errorlist' style.
- Legacy-Id: 5788
2013-06-11 10:46:47 +00:00
Emilio A. Sánchez López c12400641a Redesign the feedback pending template. See #975
- Legacy-Id: 5774
2013-06-05 06:32:17 +00:00
Henrik Levkowetz b7246168bf Fixed a problem with mismatched attribute names for ajax form field autocompletes. Closes issue #1049.
- Legacy-Id: 5771
2013-06-01 21:22:06 +00:00
Henrik Levkowetz bd0c07290a Merged in branch/iola/milestones, which provides datatracker support for management of WG milestones.
- Legacy-Id: 5739
2013-05-15 22:07:23 +00:00
Emilio A. Sánchez López ee1eec7de8 Refactored the feedback pending list. Now you can classify feedback as any type of feedback.
The feedback of a type that is not related to a nominee is classified inmediatly.
The feedback of a type that is related to a nominee must be completed with the nominee information.
Created a view to list feedback that is not related to nominees (e.g. offtopic)
Changed the command that retrieves feedback from email to add the subject inside the comment and to set the author using the from field of the email.
Fixes #1036. Fixes #1035
 - Legacy-Id: 5738
2013-05-15 16:33:01 +00:00
Ole Laursen 4db36b0fbc Add a generic state help page, make provisions for displaying
IESG I-D states in it
 - Legacy-Id: 5635
2013-04-10 16:11:27 +00:00
Ole Laursen e94d1df549 Clean up search views and remove dead code, port them to the new DB
schema, hack related views in iesg/ and wginfo/ to use the new search
interfaces, avoid camelCase in search GET parameters (with
backwards-compat fallback), add some simple search unit tests, remove
caching from views_search.py index pages as they're now pretty fast to
generate, rewrite ballot popup JS, regularize some CSS classes to use
hyphen-notation rather than camelCase, move some of the search
templates to doc/.

idrfc/ now mostly contains some wrapper code still in use by other
subdirs, some ported code not yet moved, and dead code.
 - Legacy-Id: 5611
2013-04-04 13:42:57 +00:00
Henrik Levkowetz 168d5a3836 From cabo@tzi.org: Added javascript functionality to make the UTC agenda convert it's UTC times to Browser local time.
- Legacy-Id: 5544
2013-03-10 14:56:28 +00:00
Suresh Krishnan edfc7b8193 Checking for loss of comments when AD enters comments without changing state. Also modified the base css to have an unified errorlist format.
- Legacy-Id: 5518
2013-03-09 18:47:03 +00:00
Henrik Levkowetz fc369a6e30 Provide html agendas with local and UTC timezone indications.
- Legacy-Id: 5484
2013-03-05 22:46:16 +00:00
Henrik Levkowetz 7e67b40a87 Merged in branch/amsl/trunkmerge@5449 from rcross@amsl.com, with some tweaks. This provides the secretariat apps.
- Legacy-Id: 5482
2013-03-05 22:43:31 +00:00
Henrik Levkowetz bf7b128ef0 Applied patch from olau@iola.dk, see issues #949 and #877.
- Legacy-Id: 5479
2013-03-05 10:31:03 +00:00
Ole Laursen a43ccee911 Cleanup the search code in preparation for removal of the shim-layer,
use a static button and don't send extraneous GET parameters
 - Legacy-Id: 5464
2013-02-25 11:50:00 +00:00
Ryan Cross 806c1429d3 fix hardcoded URLs in javascript
- Legacy-Id: 5448
2013-02-21 23:15:42 +00:00
Ryan Cross e32b157b3a move secr static file path so as not to conflict with app path
- Legacy-Id: 5444
2013-02-21 21:50:40 +00:00
Ole Laursen c0ecb78761 Merge the I-D and RFC views by showing I-D information on RFCs too.
I-Ds that have been published as RFCs redirect to the RFC URL. Also
support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.
 - Legacy-Id: 5285
2013-01-17 13:28:42 +00:00
Ole Laursen 0454f5e414 Make the CSS-styled button feel a bit nicer to use by flattening the
active state, also introduce some temporary styles until browsers
catch up with the standard syntax
 - Legacy-Id: 5283
2013-01-17 12:45:25 +00:00
Ole Laursen aa70cffe73 Rewrite draft and RFC tabs in terms of the new schema, porting
write-up and history tabs as well
 - Legacy-Id: 5214
2013-01-16 14:57:01 +00:00