Commit graph

16352 commits

Author SHA1 Message Date
Jennifer Richards bb0b342716
test: fix DraftFormTest setup (#7828)
* test: fix DraftFormTest setup

Tests were failing when the doc factories started
producing pks >= 10 because of an incorrect test
data structure.

* chore: improve comments
2024-08-15 16:33:14 -05:00
Jennifer Richards 00d6143293
fix: guard against missing ipr revisions (#7826)
* fix: guard against missing "revisions"

* test: add tests for DraftForm

Only testing the part relevant to this issue.

* test: clarify intentions

* chore: "document" -> "draft" in comments
2024-08-14 11:43:21 -05:00
Matthew Holloway ff8898186b
fix: Ballot return to url via url params rather than session (#7788)
* fix: #7287 ballot return params

* fix: Moving Ballot edit position ballot_edit_return_point from session to query param

* fix: tests for return_to_path param

* chore: removing Playwright tests until we can figure out a plan

* feat: return_to path utility refactoring

* fix: throw HTTP 400 in view rather than bubbling up a 500

* fix: return http400 rather than raising
2024-08-09 09:24:04 -05:00
Warren Kumari 1252cd2ac2
fix: badgeify "Serious Issues", "On the right track" review summaries. (#7809)
Addresses #7808
2024-08-08 12:10:54 -05:00
Robert Sparks c4ff0a52b2
ci: merge release to main (#7805)
ci: merge main to release (#7780)
2024-08-07 13:38:04 -05:00
Matthew Holloway e5e6c9bc89
feat: Site status message (#7659)
* Status WIP

* feat: Status

* fix: Status tests

* feat: status redirect

* chore: Status tests

* chore: Status tests

* feat: Status tests

* chore: Status playwright tests

* fix: PR feedback, mostly Vue and copyright dates

* fix: Status model migration tidy up

* chore: Status - one migration

* feat: status on doc/html pages

* chore: Resetting Status migration

* chore: removing unused FieldError

* fix: Update Status test to remove 'by'

* chore: fixing API test to exclude 'status'

* chore: fixing status_page test

* feat: Site Status PR feedback. URL coverage debugging

* Adding ietf.status to Tastypie omitted apps

* feat: Site Status PR feedback

* chore: correct copyright year on newly created files

* chore: repair merge damage

* chore: repair more merge damage

* fix: reconcile the api init refactor with ignoring apps

---------

Co-authored-by: Matthew Holloway <Matthew Holloway>
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2024-08-07 13:36:21 -05:00
Emelia Smith 30970749e3
fix: Send create user email for password resets where we have an email and person, but no user. (#7729)
* fix: Send create user email for password resets where we have an email and person, but no user account

This fixes https://github.com/ietf-tools/datatracker/issues/6458

* fix: create User straight away and use nomral password reset

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2024-08-07 13:25:08 -05:00
Rich Salz 0c8db80b18
fix: Show recordings for interims (#7197)
* fix: Show recordings for interims

Add methods uses_notes(), has_recordings(), and uses_chat_logs() to the
meeting object (with semantically correct tests) and use them consistently
throughout.  List the recordings if the "meeting numnber" starts with
"interim"

Fixes: #6543

* style: Use "is not" and "is" for None comparisons

* None comparison and non-IETF meetings

style: Use "is not None" instead of "!="
For non-IETF meetings assume chat logs exist

* fix: Restore useNotes for JS fields

* fix: uses_notes->useNotes (in JavaScript)

Also add comment about meeting number field in tests

* Missed a uses_notes->useNotes edit

* fix: useNotes->usesNotes

---------

Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2024-08-07 11:23:18 -05:00
Jennifer Richards f921cdba5d
fix: disable nginx body size check (#7803)
* fix: increase nginx client_max_body_size

* fix: entirely disable nginx body size check
2024-08-07 10:37:26 -05:00
Jennifer Richards 4b912d55a5
fix: better handle "entered" agendas (#7721)
* fix: don't assume file has open method

The open method is specific to Django's uploaded
file classes, where it just calls seek(0)

* refactor: better upload/enter agenda abstraction
2024-08-07 10:14:39 -05:00
Russ Housley 7d6d7e1c44
Update session_details_panel.html (#7719)
Add rows for interim meeting recordings. Fixes #7699.
2024-08-07 10:12:40 -05:00
Russ Housley 1de41965be
fix: add celery tasks for idnits2 and bibxml file generation (#7204)
* Add celery tasks for idnits2 and bibxml file generation

* Update tests_tasks.py

Fix typo: bad_vakue -> bad_value

* Update utils.py

Don't raise error inbibxml_for_all_drafts

* chore: fixup merge

* chore: more merge cleanup

* chore: one last merge cleanup

---------

Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
2024-08-07 09:18:13 -05:00
Jennifer Richards 95a7e14ada
feat: dev mode admin + refactor api init (#7628)
* feat: style admin site in dev mode

* refactor: eliminate base_site.html

* fix: remove debug

* fix: commit missing __init__.py

* refactor: make method static; fix tests

* refactor: move api init to AppConfig.ready()

Avoids interacting with the app registry before
it's ready.
2024-08-07 09:16:40 -05:00
Sangho Na b90820eb7a
fix: Hide last modified field in agenda when unavailable (#7722)
* test: Update tests to check for Updated field in agenda.txt

* fix: Hide Updated in agenda.txt if too old

* test: Remove confusing tests on CSV agenda

* refactor: Make updated() return None when no valid timestamp found

* refactor: Remove walrus operator
2024-08-07 09:15:01 -05:00
Jim Fenton 9ef7bff77c
feat: Unify slide upload and proposal (#7787)
* attempt at optional approval

* Update of meeting slides propose/upload

* Fix tests and residual coding bugs

* Remove gratuitous blank lines
2024-08-06 10:03:37 -05:00
Russ Housley 63d13074d1
fix: use area-acronym-at-the-time in proceedings (#7723)
When generating IETF meeting proceedings, use the Area Acronym for each WG at the time of the meeting. Fixes #7706.
2024-08-05 11:03:17 -05:00
Jennifer Richards 16ac73d4b7
fix: use BOF states in concluded_groups() (#7771)
* fix: use BOF states in concluded_groups()

* fix: handle events for older BOFs

These could be cleaned up in the database, but I think this
change does the right thing for the existing data.

* style: Black
2024-08-05 10:18:01 -05:00
Rich Salz 8a5826a941
fix: redundant word in banner for Legacy stream documents (#7207)
* fix: Remove redundant "stream stream" output

fix: Change "Legacy stream" to "Legacy"

chore: Add "stream" to stream.desc as needed

Fixes: #6902

* chore: Remove unused stream_desc parameter

The stream_desc key isn't used in template/doc/docuemnt_draft.html to
don't pass it in nor compute it

Fixes: #6902

* fix: migrate the legacy StreamName

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2024-08-05 09:48:48 -05:00
Jennifer Richards b13a606a24
feat: recognize HTTPS via proxy (#7765)
* feat: set SECURE_PROXY_SSL_HEADER

* chore: update comment
2024-08-05 09:00:15 -05:00
Jennifer Richards 0b445a9f09
docs: fix email in README.md (#7784) 2024-08-05 08:47:32 -05:00
Robert Sparks 7c89b4faab
ci: merge main to release (#7780) 2024-08-01 16:36:04 -05:00
Robert Sparks 755d5b6567
ci: merge release to main (#7779) 2024-08-01 16:35:09 -05:00
Jennifer Richards d683920cec
test: log in before pdfize test (#7778) 2024-08-01 16:33:49 -05:00
Robert Sparks 9704eed16a
ci: merge main to release (#7777)
ci: merge main to release
2024-08-01 15:32:26 -05:00
Robert Sparks ca1b3e0172
ci: merge release to main (#7776)
ci: merge release to main
2024-08-01 15:25:40 -05:00
Jennifer Richards 06677a9863
fix: require login to pdfize (#7775)
* fix: require login to pdfize

* fix: suppress "pdfized" button when it won't work
2024-08-01 15:23:35 -05:00
Matthew Holloway fb1942a538
fix: Sort RFCs by date (#7766)
* fix: Sort RFCs by date

* fix: concluded wgs and bofs date sort #7350
2024-08-01 14:25:03 -05:00
Jennifer Richards 247361b7dd
ci: better access logs+redirect auth URLs+fix X-Request-Start header (#7700)
* fix: silence nginx healthcheck logs

* fix: nginx logs in JSON

* fix: typos in nginx conf

* refactor: repeat less nginx config

* fix: log more req headers from gunicorn

* fix: redirect auth->datatracker, not deny

* feat: log X-Forwarded-Proto
2024-07-30 20:55:07 -03:00
Robert Sparks b5ab4b6611
chore: update test name fixture (#7751) 2024-07-25 15:31:53 -07:00
Jennifer Richards d5ceb7b20d
fix: optional / for /person/merge/ URL (#7746) 2024-07-24 14:20:18 -07:00
Sangho Na aa36f481e1
chore: Add additional log messages to directauth() (#7716)
* chore: Add additional log messages to directauth()

* chore: Keep single log message for each successful response
2024-07-21 11:15:33 -07:00
Sangho Na a3e4e634fc
fix: Exclude replaced documents from IESG discusses (#7712)
* fix: Exclude replaced documents from IESG discusses

* test: Add checks for filtering replaced IESG drafts

* chore: Improve replaced draft filter

---------

Co-authored-by: Paul Selkirk <paul@painless-security.com>
2024-07-21 11:14:02 -07:00
Lars Eggert 363c01e711
fix: Explicitly set executable_path for Selenium (#7715)
* fix: Explicitly set `executable_path` for Selenium

So it finds `geckodriver` again.

* Minimize diff

* fix: use existing executable_name

Co-authored-by: Lars Eggert <lars@eggert.org>

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2024-07-20 17:14:40 -07:00
Ryan Cross c5ca0ea405
fix: force choice of From address in Announcement form. Fixes #7679. (#7720) 2024-07-20 15:24:14 -07:00
Robert Sparks 60a3976c3d
Fixed 'to' to 'review_to' and 'cc' to 'review_cc'. (#7710)
Co-authored-by: Tero Kivinen <kivinen@iki.fi>
2024-07-20 15:23:56 -07:00
Robert Sparks 9783756992
Changed milestones to use RFC number if draft is published as RFC. (#7718)
Co-authored-by: Tero Kivinen <kivinen@iki.fi>
2024-07-20 15:23:32 -07:00
Jennifer Richards a86c62e133
fix: raw_id_fields for EventAdmin classes (#7711)
* fix: raw_id_fields for ReviewRequestDocEventAdmin

* fix: raw_id_fields for ReviewAssignmentDocEventAdmin

* fix: raw_id_fields for AddedMessageEventAdmin

* fix: raw_id_fields for SubmissionDocEventAdmin

* refactor: make inheritance clearer
2024-07-20 15:17:43 -07:00
Robert Sparks 7b82e60552
Merge pull request #7714 from jennifer-richards/agenda-upload-error
fix: handle missing minutes / agenda file cleanly
2024-07-20 16:31:07 -05:00
Jennifer Richards c7f6bdef0a
test: test missing file 2024-07-20 13:02:32 -07:00
Jennifer Richards 0555eef13a
fix: prevent error when no file selected 2024-07-20 12:47:43 -07:00
Nicolas Giard 02baeef01f
docs: Update README.md postgres badge version 2024-07-17 22:00:56 -04:00
Nicolas Giard d0976ec7ab
ci: add concurrency group to deploy workflow 2024-07-17 21:54:32 -04:00
Robert Sparks 6c74980b35
Merge pull request #7702 from holloway/feat/overflow-shadows
feat: Groups menu overflow shadows
2024-07-17 18:05:31 -05:00
Matthew Holloway b00dfd3c99 feat: Overflow shadows 2024-07-17 12:31:00 +12:00
Robert Sparks c1688f294b
ci: merge main to release (#7696)
ci: merge main to release
2024-07-15 17:59:02 -05:00
Robert Sparks 3a839ecfe8
ci: merge release to main (#7695)
ci: merge main to release (#7693)
2024-07-15 17:58:02 -05:00
Jennifer Richards 30510d97d8
ci: fix migration container secrets (#7694) 2024-07-15 17:57:25 -05:00
Robert Sparks 865bfb5451
ci: merge main to release (#7693)
ci: merge main to release
2024-07-15 16:54:26 -05:00
Robert Sparks 078a22d606
ci: merge release to main (#7692)
ci: merge main to release (#7682)
2024-07-15 16:53:23 -05:00
Jennifer Richards 18bb793b2d
feat: add nginx, robots.txt, HTTP headers (#7683)
* feat: nginx + robots.txt

* feat: minimal /health/ endpoint

* ci: startupProbe for datatracker pod

* ci: probe auth pod; set timeoutSeconds

* feat: add CSP and other headers to nginx

* fix: typo in nginx.conf

* feat: split auth/dt nginx confs

* test: test health endpoint

* ci: auth service on port 80

We'll remove http-old (8080) in the future.

* ci: rename auth container/nginx cfg
2024-07-15 16:45:51 -05:00