Commit graph

12379 commits

Author SHA1 Message Date
Robert Sparks b89c44f443
chore: merge main and fix new views 2023-11-16 15:58:22 -06:00
Robert Sparks 0051aa9844
fix: search correct doc type/states, switch rfc correctly in html_body, remove dead code. (#6640)
* fix: search correct doc type/states, switch rfc correctly in html_body, remove dead code

* chore: Add unreachable() marker

---------

Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
2023-11-16 13:05:58 -06:00
Robert Sparks 925e22006b
ci: change test coverage fudge factor (#6649) 2023-11-16 12:46:36 -06:00
Robert Sparks 9fedce005f
fix: restore rfcs on document graph when looking at rfc predecesors (#6646) 2023-11-16 12:49:50 -04:00
Robert Sparks a035c93351
fix: favor RFCs over drafts in related document section (#6643) 2023-11-16 11:08:16 -04:00
Jennifer Richards 53e232302e
fix: Sort milestones for groups not using dates (#6642)
* fix: Respect uses_milestone_dates == False

* test: Test milestone ordering

* test: Fix temp variable naming
2023-11-15 13:32:27 -06:00
Lars Eggert c36f63baf9
feat: Revamp AD dashboard (#6534)
* fix: Reorder conflict review columns

Fixes #6528

Also remove some redundant computation while I'm here.

* Remove some more stuff that isn't needed

* Progress

* Delivers current functionality

* Add some comments

* Handle expired docs

* Interim commit

* Fix tests

* Cleanup

* More cleanup

* Reduce differences to current view

* Interim commit

* More progress

* Getting close

* Make page functional again

* Remove unused variable

* Suppress mypy warning

* Fix #6553

* Log in as secretary to execute new code, and remove redundant check

* Remove unneeded code

* Fix #6608 by adding link to state description to state heading

* Missed part of this change in last commit.

Also fix an unrelated template nit while I'm here.
2023-11-15 11:25:30 -06:00
Robert Sparks 4fa8bfa543
fix: use correct doc types and states for rfcs (#6639) 2023-11-15 10:08:39 -04:00
Lars Eggert 5d2ac56858
feat: Now that charters are Markdown, render them as such on charter page (#6628) 2023-11-10 09:26:02 +01:00
Eric Vyncke 639043e890
Fix: meeting important dates can have markdown links (#6594)
* Fix #3911 by adding a markdown filter for template

* fix: move the new markdown filter to utils

* fix: linkify after markdown

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
2023-11-10 09:24:13 +01:00
Ryan Cross 2974e81624
fix: build proceedings attendee list from MeetingRegistration table. … (#6567)
* fix: build proceedings attendee list from MeetingRegistration table. Fixes #6265

* fix: move participants_for_meeting to meeting.utils

* fix: move test_participants_for_meeting to meeting tests
2023-11-07 13:09:19 +01:00
Rich Salz bb8cf21bd1
fix: show nomcoms by convening year only (#6585)
* ci: Update build-base-app.yml workflow

* fix: Relabel NomCom to show start year, not range

Show just the year that a NomCom started, because showing
the start/end years is confusing.

Fixes: #3419

* fix: Shwo Nomcoms year convened only

Fix the main nomcom index page and the announcement archive page

---------

Co-authored-by: Nicolas Giard <github@ngpixel.com>
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-11-07 09:57:19 +01:00
Rich Salz 35bec48e90
fix: Update NomCom references (#6583)
Add nomcom eligibility RFC to the references section

Fixes: #6581

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-11-07 09:53:49 +01:00
Paul Selkirk 2bec81da95
fix: Don't include csrf_token in GET-only form (#6549) 2023-11-07 09:50:23 +01:00
Ryan Cross 6986e65665
fix: prevent creation of duplicate MeetingRegistration records (#6593)
* fix: prevent creation of duplicate MeetingRegistration records

* fix: use get_or_create to prevent duplicate MeetingRegistrations

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-11-06 18:22:42 +01:00
Peter Yee f1425e4a52
fix: move meeting management from base Docs to Meeting (#6586)
* fix: move meeting management from base Docs to Meeting

* fix: add permission check for ability to request an interim meeting

* fix: guard against no user being logged in

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-11-06 17:45:07 +01:00
Tero Kivinen f8a06f663e
fix: Add history entry when approving the slides. (#6588)
* Added history entry when approving the slides.

Also changed os.rename to shutils.move as the submissions and
proceedings are on the separate filesystems on the docker image,
and this same thing might happen in the real environment in the
future.

* Add migrations for the docevents type.
2023-11-06 17:19:32 +01:00
Robert Sparks 37c796ebef
fix: repair ad-dashboard test 2023-11-06 09:39:10 +01:00
Robert Sparks b78eb448a5
chore: remove some unused code 2023-11-06 09:12:40 +01:00
Robert Sparks 195926ada7
fix:bring rfc-index sync test into sync with function changes 2023-11-05 14:47:43 +01:00
Robert Sparks bdeab001e6
chore: sync subseries index test with view changes 2023-11-05 13:56:50 +01:00
Robert Sparks 801b79fbb1
fix: repair is_downref 2023-11-05 13:49:56 +01:00
Robert Sparks 3fea443f59
fix: use valid ids on subseries index page 2023-11-05 12:35:34 +01:00
Paul Selkirk b5ee9ec9ab
fix: Don't allow group chair to change group parent (#6496)
* fix: Don't allow group chair to change group parent (#6037)

* test: Fix test_edit_parent_field, add test_edit_parent (whole form)

* test: Verify that the chair can't circumvent the system to change the group parent

* fix: 403 if user tries to edit an unknown or hidden field

* fix: Give edwg GroupFeatures a parent type

This tracks a change that was made directly in the production database
to fix the immediate cause of #6037.

* Empty commit to trigger github unit test
2023-11-05 12:32:03 +01:00
Paul Selkirk a3b4162841
fix: Don't redirect user to the login page when logging in (#6570)
* fix: Don't redirect user to the login page when logging in (#5876)

(Embrace and extend c4bf508cd8.)

* test: Add test case for login button

* refactor: The template filter just strips off a path prefix, so rename/recode accordingly

Also test with a non-trivial redirect target.
2023-11-05 11:09:07 +01:00
Lars Eggert 1df7319e26
fix: Remove time from materials cell (#6584)
Fixes #6542
2023-11-05 11:04:25 +01:00
Lars Eggert 275b3b2b0a
fix: Make authors take at least two lines in HTMLized (#6606)
From 32f8003712

Fixes #6575
2023-11-05 10:40:34 +01:00
Tero Kivinen 2f5bbebf70
Add link to review request page to review result page. (#6596)
Remove link to self on review result page.
2023-11-05 09:57:04 +01:00
Tero Kivinen 53d0014826
feat: add "add comment" feature to the review requests. (#6603) 2023-11-05 09:29:25 +01:00
Robert Sparks 9a2b0cf947
fix: better empty text and prettystdname on subseries index view 2023-11-01 16:21:05 -05:00
Robert Sparks 3836f76052
feat: add subseries to main menu 2023-11-01 16:20:18 -05:00
Robert Sparks 575560a885
fix: don't parameterize search for subseries types. 2023-11-01 16:08:39 -05:00
Robert Sparks 71a760f05a
feat: show references to and from subseries 2023-11-01 15:57:34 -05:00
Robert Sparks 1f82fab2cd
fix: silenced (and explained) several warnings 2023-11-01 15:20:29 -05:00
Robert Sparks 942c4d42af
fix: better message on first import of subseries membership 2023-11-01 13:29:12 -05:00
Robert Sparks 986e002c1d
chore: repair merge damage 2023-11-01 12:41:15 -05:00
Robert Sparks 8e3e59079a
chore: reorder migrations 2023-11-01 11:45:23 -05:00
Robert Sparks 28c3e1bd5d
chore: merge branch 'main' into feat/rfc 2023-11-01 10:54:29 -05:00
Robert Sparks e65c4c3f7f
fix: use clearer descriptions on docevents for initial sync run 2023-10-31 16:36:47 -05:00
Robert Sparks 320ca6232b
chore: remove spurious whitespace change 2023-10-31 15:54:15 -05:00
Robert Sparks 0afe496aa3
fix: preserve RelatedDocument references to subseries 2023-10-31 15:52:11 -05:00
Robert Sparks 466921728f
chore: reorder migrations 2023-10-31 11:56:44 -05:00
Lars Eggert d246879069
Fix code review comments 2023-10-27 17:29:09 -07:00
Robert Sparks 1130f1f790
Merge branch 'main' into feat-md-bs 2023-10-25 20:46:00 -05:00
Lars Eggert 6d87279895
fix: BCPs can normatively cite all other standards levels (#6530)
* fix: BCPs can normatively cite all other standards levels

Fixes #6524

* Revise the logic and add tests

* Fix bug in truth table
2023-10-25 20:43:05 -05:00
Lars Eggert 5f8bf4b6f7
Merge branch 'main' into feat-md-bs 2023-10-25 20:23:33 +02:00
Ryan Cross 601ab53db9
refactor: remove secr IPR admin link (#6540) 2023-10-25 12:45:22 -05:00
Jennifer Richards be4a6ef6f5
chore: Revert agenda editor font change (#6538)
* Revert "fix: Change some colors to make agenda tool work in dark mode (#6428)"

This reverts commit 699a8e2d9e.

* Revert "Revert "fix: Change some colors to make agenda tool work in dark mode (#6428)""

This reverts commit 5adafac4cb7896e9dd309a3385ec9aab5035e7d3.

* chore: Revert only font-family change

* chore: Add comment to ietf.scss
2023-10-25 12:43:17 -05:00
Lars Eggert c2a44dbad0
fix: Use d-none class instead of hide (#6535)
Fixes #6531
2023-10-25 08:37:14 -05:00
Lars Eggert 888a4f2efe
fix: Add link to session to material metadata (#6536)
* fix: Add link to session to material metadata

Fixes #6533

* Fix CI
2023-10-25 08:28:50 -05:00