Robert Sparks
1517efaba2
Return new forms instead of validated forms for nomcom nominations and feedback. Fixes #1703 . Commit ready for merge.
...
- Legacy-Id: 10004
2015-08-10 18:28:08 +00:00
Ole Laursen
a3399b0bcd
Summary: Port remaining parts of nomcom to bootstrap, fix some bugs,
...
let the private/public feedback pages share the same template, remove
the edit NomCom chair thing - there's no link to it and the
Secretariat can instead use the ordinary group management tool they
have available
- Legacy-Id: 8721
2014-12-02 10:43:20 +00:00
Ole Laursen
87870ca954
Fix more test errors - now only two not yet fully ported views remain
...
- Legacy-Id: 8571
2014-11-03 16:39:41 +00:00
Ole Laursen
41cb195f52
Rebase /personal/lars/5.6.4-facelift/ on trunk
...
- Legacy-Id: 8520
2014-10-30 14:31:07 +00:00
Henrik Levkowetz
0d61e270d6
Normalized a couple of NameModels subclasses.
...
- Legacy-Id: 8460
2014-10-23 21:14:41 +00:00
Lars Eggert
a4daf2630c
Merge branch 'lars/5.6.3-facelift' into lars/5.6.4-facelift
...
Conflicts:
ietf/doc/templatetags/ietf_filters.py
ietf/doc/views_charter.py
ietf/templates/doc/charter/edit_notify.html
ietf/templates/doc/charter/edit_telechat_date.html
ietf/templates/doc/document_ballot_content.html
ietf/templates/doc/document_history.html
ietf/templates/doc/edit_notify.html
ietf/templates/doc/edit_telechat_date.html
ietf/templates/doc/notify.html
ietf/templates/group/concluded_groups.html
- Legacy-Id: 8429
2014-10-14 11:48:57 +00:00
Henrik Levkowetz
25423f6779
Added some formset attributes which are needed by the current Django (1.6) code. A better way would maybe be to use formset_factory(), but a simple invocation of that gives other problems. Leaving as is for now, to get a patch out so the nomcom chair can get on with things.
...
- Legacy-Id: 8370
2014-09-29 21:16:55 +00:00
Henrik Levkowetz
563f584a9e
Made ietf/nomcom pyflakes-clean. Removed some dead code.
...
- Legacy-Id: 7476
2014-03-15 19:26:01 +00:00
Ole Laursen
ab382a726f
While cleaning up the Javascript includes in the nomcom app, it turns
...
out nomcom.js is included in the wrong pages, and on the pages it is
actually useful in, it's obsolete, so delete it together with the
obsoleted AJAX view and the other JS left-over cruft in nomcom/, this
fixes an include 404 and removes the remaining dependency on
jquery-1.5.1 apart from the Secretariat tools
- Legacy-Id: 7097
2014-01-10 14:06:36 +00:00
Ole Laursen
fdb6baf4e6
Use collections.OrderedDict instead of the SortedDict bundled with Django
...
- Legacy-Id: 7026
2013-12-20 11:00:07 +00:00
Ole Laursen
d66ac15fc2
Rewrite a bunch of HttpResponseRedirect + url reverse calls to instead
...
take advantage of the redirect shortcut (introduced in Django 1.1)
- Legacy-Id: 6960
2013-12-17 10:23:42 +00:00
Ole Laursen
84a9f49053
mimetype -> content_type (mimetype is deprecated)
...
- Legacy-Id: 6945
2013-12-16 16:53:47 +00:00
Ole Laursen
3febf7d216
Fix odd boolean calculation in nomcom view
...
- Legacy-Id: 6923
2013-12-13 16:48:37 +00:00
Ole Laursen
771591f0db
Remove use of obsolete generic delete view
...
- Legacy-Id: 6891
2013-12-12 12:06:09 +00:00
Ole Laursen
6a98fec2c3
Use built-in json module in Python instead of simplejson bundled with Django
...
- Legacy-Id: 6883
2013-12-11 16:59:19 +00:00
Ole Laursen
d0f2859631
Move NomCom announcements view to nomcom/, move message view to
...
message/, add tests, add redirects, fix a couple of small bugs in the
announcements view
- Legacy-Id: 6769
2013-11-28 17:55:10 +00:00
Ole Laursen
9457669310
Merge in changes from the old shimfree branch
...
- Legacy-Id: 6764
2013-11-27 12:55:50 +00:00
Henrik Levkowetz
5f2da7ba9e
Merged [6486] from rjsparks@nostrum.com:
...
Slightly more than minimal changes to have questionnaire reminders go only to those nominees who have accepted but have not yet sent in a questionnaire for a given position
- Legacy-Id: 6573
Note: SVN reference [6486] has been migrated to Git commit 2a1b4c7775
2013-10-30 21:17:46 +00:00
Henrik Levkowetz
6928ff2927
Correct sequence typo.
...
- Legacy-Id: 6491
2013-10-26 15:32:04 +00:00
Henrik Levkowetz
d649fd5e10
Merged [6465] and [6466] from rjsparks@nostrum.com:
...
Added the ability to send reminders to complete questionnaires to nominees in
the accepted state. Changed the send_reminders management command to not take
any arguments and run against all active nomcoms. Removed bugs from the
send_reminders management command and added tests for it. Adjusted several
dbtemplate titles and content.
Fixes bug 1157
- Legacy-Id: 6471
Note: SVN reference [6465] has been migrated to Git commit 22f356434a
Note: SVN reference [6466] has been migrated to Git commit a461e6c4a4
2013-10-21 20:12:00 +00:00
Henrik Levkowetz
6c13e8027b
Fixed the language in some UI strings in the nomcom tool.
...
- Legacy-Id: 6358
2013-10-03 20:56:59 +00:00
Henrik Levkowetz
d2df8cac78
Fixed the manyfold duplicated position names in the position selection drop-down list in the nomcom private index page. Fixes issue #1137 .
...
- Legacy-Id: 6327
2013-10-01 13:42:30 +00:00
Henrik Levkowetz
8d9c1e9177
Changed 'requirement' to 'desired expertise' in user-visible places in the nomcom app.
...
- Legacy-Id: 6259
2013-09-24 17:50:02 +00:00
Henrik Levkowetz
5d9e6c0b6a
Fixed the language of the nomination confirmation message.
...
- Legacy-Id: 6250
2013-09-23 19:27:17 +00:00
Henrik Levkowetz
0016c69b61
Added an index page for nomcoms, at /nomcom/, with links to nomcom pages and announcements, where they exist.
...
- Legacy-Id: 6245
2013-09-22 18:59:24 +00:00
Ole Laursen
5924024513
Swap the arguments to group.has_role so they match the arguments to
...
the existing has_role
- Legacy-Id: 6218
2013-09-20 13:46:47 +00:00
Ole Laursen
0eed4ad9e5
Add has_role(role_name, user) utility to group, used like
...
group.has_role("chair", request.user). Remove the NomCom specific
group utilities, apparently they're not actually used.
- Legacy-Id: 6217
2013-09-20 11:23:17 +00:00
Henrik Levkowetz
641bcccfba
Replaced the ad_hoc nomcom_member_required() decorator with our generic role_required() decorator. Changed access permission for nomcom-chair only pages to also permit nomcom advisor access (this lets the previous nomcom chair explain and assist as needed). Also tweaked some text strings in the email feedback pipe script.
...
- Legacy-Id: 6160
2013-09-16 21:05:25 +00:00
Henrik Levkowetz
6baea429aa
Merged in the nomcom app from ejimenez@yaco.es and esanchez@yaco.es, and accompanying dbtemplate app and the (standard) docutils module. Added some tweaks to get all tests to pass and migrations to run.
...
- Legacy-Id: 5948
2013-08-06 10:09:29 +00:00
Emilio A. Sánchez López
49117c1622
Nominations are processed first and then the rest of feedback.
...
Select multiple resizable when selecting a nominee.
Fixed command that gets the feedback from email to retrieve the full address on the from header.
Added a "feedback pending" link in the top bar.
Fixed escaped html tags when displaying comments from feedback.
See #975
- Legacy-Id: 5781
2013-06-10 10:42:11 +00:00
Emilio A. Sánchez López
c12400641a
Redesign the feedback pending template. See #975
...
- Legacy-Id: 5774
2013-06-05 06:32:17 +00:00
Emilio Jiménez
66c4a32c57
Add subject field to feedback model
...
New form to fill feedback mail via web.
Fixes #1042 #1043
- Legacy-Id: 5748
2013-05-21 12:31:24 +00:00
Emilio Jiménez
f998e0d29f
Add form to change email of nominees.
...
Refactor merge form to avoid merge old duplicate nominees.
See #1013
- Legacy-Id: 5747
2013-05-20 18:17:31 +00:00
Emilio A. Sánchez López
ee1eec7de8
Refactored the feedback pending list. Now you can classify feedback as any type of feedback.
...
The feedback of a type that is not related to a nominee is classified inmediatly.
The feedback of a type that is related to a nominee must be completed with the nominee information.
Created a view to list feedback that is not related to nominees (e.g. offtopic)
Changed the command that retrieves feedback from email to add the subject inside the comment and to set the author using the from field of the email.
Fixes #1036 . Fixes #1035
- Legacy-Id: 5738
2013-05-15 16:33:01 +00:00
Emilio Jiménez
a6fdc52397
Refactor code to send reminders in a unique function
...
Refactor reminder command.
Fixes #1040
- Legacy-Id: 5736
2013-05-15 09:08:49 +00:00
Emilio Jiménez
3d25fa261e
now reminder form sends accept and decline links, and questionnaires.
...
See #1040
- Legacy-Id: 5735
2013-05-15 07:24:32 +00:00
Emilio Jiménez
7042e8896a
now you can see new feedback types
...
See #973
- Legacy-Id: 5726
2013-05-12 18:46:53 +00:00
Emilio A. Sánchez López
a7af017465
Rename member_required decorator to nomcom_member_required
...
Rename private_key_required decorator to nomcom_private_key_required
Fixes #1038
- Legacy-Id: 5716
2013-05-09 09:19:06 +00:00
Emilio Jiménez
3cbdecd3c3
Show a message if there is or not a private kay in the user session
...
See #1033
- Legacy-Id: 5713
2013-05-08 16:19:03 +00:00
Emilio Jiménez
f3b3a21ccb
Show if nomcom has a public key
...
Fixes #1033
- Legacy-Id: 5712
2013-05-08 12:59:55 +00:00
Emilio Jiménez
868a82a327
Change message when public key does not exists
...
Refactor context views
Add new templatetags to check if the nomcom has public key
Fixes #1030
- Legacy-Id: 5710
2013-05-08 12:37:12 +00:00
Emilio Jiménez
3d747dbcb7
Delete * of date field in remider dates
...
Fixes #1031
- Legacy-Id: 5709
2013-05-08 11:00:47 +00:00
Emilio Jiménez
c3ff510ed0
Change questionnaire response view.
...
Fixes #1007
- Legacy-Id: 5689
2013-05-02 09:42:00 +00:00
Emilio Jiménez
9409776be8
change "Questionnaire Response" label
...
See #1003
- Legacy-Id: 5687
2013-05-02 08:03:24 +00:00
Emilio Jiménez
519d628cde
Add command to send reminders
...
Add fields date an interval in nomcom models to send reminders
Refactor some managers
Add help_text to pending feedback form
Limit types in pending feedback form
See #969 #975
- Legacy-Id: 5683
2013-04-23 08:24:21 +00:00
Emilio A. Sánchez López
6898c51490
Merge position and nominee into one field in the feedback pending forms.
...
Style the feedback pending forms.
See #975
- Legacy-Id: 5668
2013-04-19 07:46:23 +00:00
Emilio Jiménez
85ab39f1ab
Refactor feedback, now feedback belong many to many nominees
...
See #913 #929 #930 #965 #970 #975
- Legacy-Id: 5598
2013-03-26 13:35:58 +00:00
Emilio Jiménez
da031d0a7b
Better not show private key by default
...
See #947
- Legacy-Id: 5597
2013-03-26 12:05:17 +00:00
Emilio Jiménez
69c704de2d
better errors control in feedback form.
...
See #970
- Legacy-Id: 5593
2013-03-25 18:02:00 +00:00
Emilio Jiménez
da52637e9b
Not show nominees and nominee positions duplicated
...
See #970 #973
- Legacy-Id: 5589
2013-03-22 13:22:37 +00:00