Lars Eggert
d246879069
Fix code review comments
2023-10-27 17:29:09 -07:00
Robert Sparks
1130f1f790
Merge branch 'main' into feat-md-bs
2023-10-25 20:46:00 -05:00
Lars Eggert
6d87279895
fix: BCPs can normatively cite all other standards levels ( #6530 )
...
* fix: BCPs can normatively cite all other standards levels
Fixes #6524
* Revise the logic and add tests
* Fix bug in truth table
2023-10-25 20:43:05 -05:00
Lars Eggert
5f8bf4b6f7
Merge branch 'main' into feat-md-bs
2023-10-25 20:23:33 +02:00
Ryan Cross
601ab53db9
refactor: remove secr IPR admin link ( #6540 )
2023-10-25 12:45:22 -05:00
Jennifer Richards
be4a6ef6f5
chore: Revert agenda editor font change ( #6538 )
...
* Revert "fix: Change some colors to make agenda tool work in dark mode (#6428 )"
This reverts commit 699a8e2d9e
.
* Revert "Revert "fix: Change some colors to make agenda tool work in dark mode (#6428 )""
This reverts commit 5adafac4cb7896e9dd309a3385ec9aab5035e7d3.
* chore: Revert only font-family change
* chore: Add comment to ietf.scss
2023-10-25 12:43:17 -05:00
Lars Eggert
c2a44dbad0
fix: Use d-none class instead of hide ( #6535 )
...
Fixes #6531
2023-10-25 08:37:14 -05:00
Lars Eggert
888a4f2efe
fix: Add link to session to material metadata ( #6536 )
...
* fix: Add link to session to material metadata
Fixes #6533
* Fix CI
2023-10-25 08:28:50 -05:00
Lars Eggert
e7639e94ed
Merge branch 'main' into feat-md-bs
2023-10-24 19:49:17 +02:00
Lars Eggert
fd03ab13d7
Small fixes
2023-10-23 17:44:12 -07:00
Martin Thomson
902d657c9f
Icons for sidebar collapse/expand ( #6465 )
...
This change uses [bi-arrow-bar-left](https://icons.getbootstrap.com/icons/arrow-bar-left/ ) and [bi-arrow-bar-right](https://icons.getbootstrap.com/icons/arrow-bar-right/ ). This is a minimal change, but changes from .
I started off with just changing the open one to use [bi-layout-sidebar](https://icons.getbootstrap.com/icons/layout-sidebar/ ), which is the mirror of the collapsed icon. I also considered changing the icon that shows when collapsed to [bi-layout-sidebar-text-reverse](https://icons.getbootstrap.com/icons/layout-text-sidebar-reverse/ ). Both of those seemed less clear than these.
Note that the "shown"/"collapsed" classes on these elements appear to be reversed. I didn't touch that.
2023-10-23 18:40:24 -05:00
Lars Eggert
0a4fc286cd
fix: More darkmode fixes ( #6477 )
...
* fix: More dark mode fixes
This first commit increases contrast of the leftmenu text.
* Fix own ballot position highlight in dark mode
* Fix dark mode axis color in timeline diagrams
* Enable highcharts dark mode
* Fix template
* Properly import our customized bs5 everywhere
* Fix #6499
* Use bs5 color for border-left
* Remove superfluous load
2023-10-23 18:38:35 -05:00
Lars Eggert
699a8e2d9e
fix: Change some colors to make agenda tool work in dark mode ( #6428 )
...
This is not a proper fix. This tool doesn't bootstrap much and is
hence full of custom CSS. Really needs a redo.
2023-10-23 18:34:59 -05:00
Lars Eggert
caa4e837ad
fix: Remove menu item for outdated tutorials list ( #6521 )
...
Fixes #6473
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-10-23 18:32:08 -05:00
Ryan Cross
c9e14cb45a
refactor: remove unused physical bluesheet functions ( #6525 )
...
* refactor: remove unused secr/console app
* refactor: remove unused secr/areas app
* refactor: remove unused physical bluesheets functions
---------
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-10-23 18:31:47 -05:00
Lars Eggert
3bfe90e755
fix: Add "numeric" option to localecompare ( #6520 )
...
Fixes #6493
2023-10-23 15:08:56 -05:00
Lars Eggert
f5507daef1
feat: Render markdown agendas with bs5 styles
...
So that the look is consistent with the rest of the datatracker.
2023-10-23 18:55:31 +03:00
Jennifer Richards
dc14308700
refactor: Drop submission validation via libmagic ( #6500 )
...
* refactor: Update parsers/base.py for Python3
* style: Black
* refactor: Remove mime type check from FileParser
* refactor: Validate that submission is UTF-8
The mime check distinguished us-ascii from UTF-8,
but as far as I can tell the code relying on it
treated both as equally valid.
* feat: Clear error when file is not valid XML
* chore: Remove unused import
* test: Update tests to match changes
* fix: Count bytes starting from 1
* test: Add tests of FileParser validations
* fix: Fix / simplify regexp
* test: Test error caused by bad XML submission
---------
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-10-23 10:00:04 -05:00
Paul Selkirk
a6a39a04dc
feat: Show/edit shepherd for IAB-stream documents ( #6498 )
...
* feat: Show/edit shepherd for IAB-stream documents (#4810 )
* style: Shepherd for IAB documents is called 'IAB shepherd'
2023-10-23 09:57:23 -05:00
Ryan Cross
4575864bfe
refactor: remove unused secr/areas app ( #6509 )
...
* refactor: remove unused secr/areas app
2023-10-23 09:55:54 -05:00
Ryan Cross
16c876b24d
refactor: remove unused secr/console app ( #6508 )
2023-10-23 09:53:57 -05:00
Martin Thomson
6e3c663484
fix: hide sidebar and dark/light toggles from print ( #6502 )
...
Fixes #6501 .
2023-10-20 08:08:55 -05:00
Robert Sparks
431856eb5f
Merge pull request #6478 from pselkirk/fix-6474
...
feat: Update ISE state when entering/exiting IETF conflict review
2023-10-16 12:51:03 -05:00
Robert Sparks
c84199630b
Merge pull request #6470 from pselkirk/feat-5440
...
feat: Send mail when slides are approved
2023-10-16 12:46:13 -05:00
Paul Selkirk
f6a2d8c534
refactor: More efficient mail construction/sending
2023-10-13 19:22:06 -04:00
Paul Selkirk
bdf71caaf1
feat: Update ISE state when entering/exiting IETF conflict review ( #6474 )
...
This extends PR #6424 to cover ISE as well as IRTF documents.
2023-10-13 17:50:05 -04:00
Robert Sparks
6e502fa20e
fix: de-docalias merge from main ( #6471 )
2023-10-13 14:53:43 -03:00
Robert Sparks
c036bc6822
Merge pull request #6476 from larseggert/fix-better-nomcom-fb-buttons
...
fix: Use smaller buttons for NomCom feedback and color the count bubble
2023-10-13 09:03:32 -05:00
Lars Eggert
ba66d25372
fix: Use smaller buttons for NomCom feedback and color the count bubble
2023-10-13 16:14:59 +03:00
Lars Eggert
e9a8c341e8
fix: Nicer formatting for group milestone tables
2023-10-13 14:07:20 +03:00
Paul Selkirk
6f634a049a
fix: Don't forget to empty_outbox
2023-10-12 16:28:26 -04:00
Robert Sparks
ab931f0510
chore: merge main into feat/rfc
2023-10-12 15:11:02 -05:00
Paul Selkirk
b04ffe1631
feat: Send mail when slides are approved ( #5440 )
2023-10-12 13:13:14 -04:00
Lars Eggert
fa00abf9de
fix: Add remote instructions and date/time to interim agenda page ( #6442 )
...
* fix: Add remote instructions to interim agenda page
Fixes #6433
Fixes #6249
* Also add date and time
* Fix HTML
* Fix CI fail
* Address code review comments
* More suggestions from @rjsparks
* Fix HTML
* Add suffix
2023-10-12 06:29:03 -05:00
Lars Eggert
0f6b403904
fix: Fix "Is Accepting Feedback: yes" action for NomCom ( #6467 )
...
Fixes #6466
While I'm here, apply list styling more consistently across NomCom pages.
2023-10-12 06:15:14 -05:00
Paul Selkirk
16f9e0e974
fix: Adjust IRTF charter approval email headers ( #5917 ) ( #6460 )
2023-10-11 11:09:10 -05:00
Lars Eggert
a02812bf7c
fix: Use String.prototype.localeCompare() when sorting table rows ( #6441 )
...
Fixes #6437
2023-10-10 10:10:30 -05:00
Paul Selkirk
72fef7bc69
fix: Don't allow ADs to set docs to -sent states ( #6445 )
2023-10-10 10:09:04 -05:00
Paul Selkirk
f19d1047c4
feat: Update IRTF state when entering/exiting IETF conflict review ( #6424 )
...
* feat: Update IRTF state when entering/exiting IETF conflict review (#3469 )
* fix: Update IRTF state in approve_conflict_review() as well
* chore: Add "new_state != prev_state" guard
2023-10-09 15:01:35 -05:00
David Schinazi
5e0d1bef0f
fix: Remove incorrect line from submission API info web page ( #6432 )
...
* Submit can replace
* Empty commit for CI
* revert change to api_submit_info
2023-10-09 12:15:47 -05:00
Lars Eggert
7dbfc0208a
feat: Remove document notes from the datatracker ( #6387 )
...
* Remove doc.note
* Address comments from @rjsparks
* Consistently display doc notes
2023-10-09 12:15:18 -05:00
Lars Eggert
0f16012c73
fix: Add html-validate suppression that should have been part of #6356 ( #6440 )
2023-10-09 11:30:45 -05:00
Robert Sparks
a97f306555
fix: improve handling malformed new specific ipr submissions ( #6420 )
2023-10-04 16:41:24 -05:00
Robert Sparks
4b1274c44d
fix: teach search about rfcs and subseries ( #6431 )
...
* fix: teach search about rfcs and subseries
* fix: more general manipulation of searches for rfc and subseries
* fix: only tweak subseries search if the thing after the subseries id is digits
2023-10-04 17:12:01 -03:00
Robert Sparks
9a09bf1f7b
fix: make statement published time match statement doc time ( #6419 )
...
* fix: make statement published time match statement doc time
* test: improve testing of creating statements
2023-10-02 09:51:33 -05:00
Lars Eggert
250e045ec3
Simpler fix
2023-10-02 11:43:11 +03:00
Lars Eggert
510570521d
fix: Limit group names to 80 characters
...
Fixes #6416
2023-10-02 10:40:43 +03:00
Robert Sparks
d6f5564a82
ci: merge release to main
2023-09-29 14:02:18 -05:00
Robert Sparks
c5a955d798
fix: restore interim announce ability ( #6410 )
2023-09-29 11:33:14 -05:00
Robert Sparks
486a4f5370
Merge pull request #6345 from larseggert/fix-6343
...
fix: Add link to public pages to private NomCom pages
2023-09-29 10:13:58 -05:00
Robert Sparks
e48eb84f44
Merge pull request #6397 from larseggert/feat-rerun-tests
...
feat: Add the ability to rerun a test suite until a failure occurs
2023-09-29 10:12:58 -05:00
Robert Sparks
18c6c12f24
Merge pull request #6406 from pselkirk/fix-5943
...
fix: The NomCom chair is not eligible for NomCom
2023-09-29 10:12:35 -05:00
Robert Sparks
40dc24e44b
chore: tweak comments
2023-09-29 07:52:32 -05:00
Paul Selkirk
cbd49a737f
fix: Disqualify the nomcom chair from volunteering for the nomcom
2023-09-28 14:55:06 -04:00
Paul Selkirk
658f7edeef
test: Add test for RFC8713 section 4.15 disqualified roles
2023-09-28 14:53:38 -04:00
Lars Eggert
8abbaae0c0
Update ietf/utils/test_runner.py
2023-09-28 11:34:03 +03:00
Lars Eggert
abe93a42b2
feat: Add the ability to rerun a test suite until a failure occurs
...
More quickly than looping in the shell around a non-zero error code.
This only incurs all the setup and scaffolding overheads once.
2023-09-28 11:31:16 +03:00
Lars Eggert
7398ea0523
Merge branch 'main' into fix-6393
2023-09-28 11:29:59 +03:00
Lars Eggert
37e98d3b5c
Fix the actual issue
2023-09-28 11:28:41 +03:00
Paul Selkirk
c718fedb6c
feat: Allow review rejections to be undone ( #6312 )
...
* feat: Allow reviewer to accept a review they're previously rejected
* feat: Add a reviewer who has previously rejected a review to the list of suggested reviewers.
This largely un-does d105f8b
, at the request of at least one team secretary.
* fix: Went a little overboard on the previous commit
one_assignment still has to exclude reviewers who rejected the assignment,
or they could end up being the suggested reviewer.
* fix: Actually do the assignment
* fix: If there's an existing assignment, don't create a new one
* style: Restructure conditional for clarity
* test: Add test cases for accepting or assigning a review assignment after rejecting it
2023-09-27 08:57:34 -05:00
Lars Eggert
d282cd3a37
Merge branch 'main' into fix-6393
2023-09-27 16:27:41 +03:00
Lars Eggert
c2c02273c3
fix: Allow filtering for nominees who have not declined ( #6382 )
...
* fix: Allow filtering for nominees who have not declined
Fixes #6380
* Update views.py
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
---------
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-09-27 08:21:36 -05:00
Lars Eggert
a469f08d63
Remove debug prints
2023-09-27 16:01:21 +03:00
Lars Eggert
4f6caa89b2
fix: Make sure groups in test have different acronyms
...
Fixes #6393
2023-09-27 15:59:59 +03:00
Jennifer Richards
82c70a2d5d
Merge pull request #6374 from rjsparks/more_docalias_removal
...
fix: cleaner search_result_row diff links for recent drafts replacing other drafts
2023-09-26 22:24:17 -03:00
Robert Sparks
4ba62bf149
fix: put rfc history on left
2023-09-26 17:17:04 -05:00
Robert Sparks
1b32fde588
fix: cleaner sync test ( #6372 )
2023-09-26 17:11:10 -05:00
Lars Eggert
a8f50f50b0
fix: Only enable city/country entry for in-person interims ( #6383 )
...
Was probably broken during the bs5 transition.
Fixes #6346
2023-09-26 12:00:05 -05:00
Lars Eggert
7e18a0fad2
fix: Allow editing of interim meeting subject lines ( #6385 )
...
Also change "readonly" to "disabled" to give a visual hint about which
fields are not changeable.
Fixes #6310
2023-09-26 08:10:46 -05:00
Lars Eggert
5db70b2787
fix: State descriptions can have HTML in them, mark them safe ( #6384 )
2023-09-26 08:09:39 -05:00
Lars Eggert
6acc7aa848
fix: Restore the ability to search in tables ( #6386 )
...
This was broken by 57030e4303
2023-09-26 08:03:29 -05:00
Robert Sparks
9e4166393d
fix: cleaner search_result_row diff links for recent drafts replacing other drafts
2023-09-25 15:39:48 -05:00
Lars Eggert
73008596ee
fix: Enable editing of related liaison statement information ( #6371 )
...
Fixes #6264
2023-09-25 10:17:35 -05:00
Jennifer Richards
8f0a0da5a3
fix: Typo
2023-09-25 12:01:27 -03:00
Lars Eggert
a42ef589f3
Unsplit conditionals
2023-09-25 17:41:30 +03:00
Lars Eggert
9efcce227d
Be less clever
2023-09-25 13:42:15 +03:00
Lars Eggert
d0de2294a3
Merge remote-tracking branch 'origin/main' into fix-6343
2023-09-25 13:05:31 +03:00
Robert Sparks
092e572e16
feat: move errata tags
2023-09-22 16:35:54 -05:00
Lars Eggert
910a266126
fix: Prevent duplicate HTML IDs on photo page ( #6356 )
...
* fix: Prevent duplicate HTML IDs on photo page
Fixes #6355
* Just don't slugify the ID.
See https://mathiasbynens.be/notes/html5-id-class
2023-09-22 12:50:43 -05:00
Robert Sparks
8732dcb706
fix: bring tests up current. add subseries names to rfc view. fix html.
2023-09-22 12:40:15 -05:00
Lars Eggert
26f34f4aef
Merge branch 'main' into fix-6343
2023-09-22 08:32:17 +03:00
Robert Sparks
48cb06d20d
fix: subseries specific docevent types. get_or_create contain relationship. remove spurious "
2023-09-21 16:38:41 -05:00
Jennifer Richards
b08d26d36e
feat: Scout monitoring for celery workers ( #6342 )
...
* feat: Scout APM instrumentation for celery
* fix: Remove guard that caused problem on production
2023-09-21 14:43:19 -05:00
Robert Sparks
0390f1868f
feat: subseries
2023-09-21 12:54:17 -05:00
Lars Eggert
e76201103f
Fix pyflake
2023-09-21 18:15:12 +03:00
Lars Eggert
9391985cbb
fix: Add link to public pages to private NomCom pages
...
Fixes #6343
Also fix highlighting of the active tab in the nav tab bar while I'm here.
2023-09-21 17:20:38 +03:00
Jennifer Richards
f15960d32d
Merge pull request #6328 from rjsparks/dochistory_rfcnumber
...
fix: populate rfc_number on DocHistory with type_id rfc
2023-09-15 20:41:43 -03:00
Jennifer Richards
f4629bc750
Merge pull request #6326 from rjsparks/email_expansions
...
fix: tune mailtrigger recipients and set relevant expansions for rfcs
2023-09-15 20:12:39 -03:00
Robert Sparks
a39a058a01
fix: populate rfc_number on DocHistory with type_id rfc
2023-09-15 17:33:05 -05:00
Robert Sparks
88e66048da
fix: make Was link go to the right place. Remove unreachable code.
2023-09-15 16:49:21 -05:00
Robert Sparks
bc177b08ea
chore: black
2023-09-15 16:15:47 -05:00
Robert Sparks
edadd99044
fix: tune mailtrigger recipients and set relevant expansions for rfcs
2023-09-15 16:02:08 -05:00
Robert Sparks
e0e647fa75
chore: repair merge damage
2023-09-15 13:59:19 -05:00
Robert Sparks
4811374014
chore: reorder migrations ( #6325 )
2023-09-15 13:10:19 -05:00
Robert Sparks
621528ad03
ci: Merge branch 'main' into feat/rfc
2023-09-15 11:48:44 -05:00
Lars Eggert
303ff70e64
fix: Linkify email address lists one-by-one ( #6315 )
...
* fix: Linkify email address lists one-by-one
Seems to work around a bug in mozilla/bleach.
Fixes #6307
* Cosmetic change
* Fix test
2023-09-15 10:45:58 -05:00
Jennifer Richards
b635045aab
Merge pull request #6309 from rjsparks/crawl-fixes
...
fix: missed docalias artifact removal. Better use of became_rfc.
2023-09-15 11:55:27 -03:00
Robert Sparks
4ddf132efb
fix: remove leftover docalias detritus
2023-09-15 09:51:15 -05:00
Robert Sparks
20f427e013
chore: remove unused view ( #6304 )
...
* chore: remove unused view
* chore: deflake
* chore: deflake
2023-09-14 17:10:26 -05:00
Robert Sparks
536c1fb6fc
fix: missed docalias artifact removal. Better use of became_rfc.
2023-09-14 16:43:26 -05:00