Henrik Levkowetz
ac52ce6595
Updated the NomCom eligibility calculation to use the last 5 in-person meetings, in accordance with draft-iesg-nomcom-eligibility-2020-03 which has now been approved for publication. The code will need revisiting when the long-term policy is available.
...
- Legacy-Id: 17859
2020-05-20 19:41:25 +00:00
Robert Sparks
d981076432
Refactor disqualifying roles into one place. Commit ready for merge.
...
- Legacy-Id: 17650
2020-04-15 22:34:44 +00:00
Robert Sparks
b387599dac
Follow RFC8713 section 4.15 for roles that disqualify for nomcom. Fixes #2944 . Commit ready for merge.
...
- Legacy-Id: 17649
2020-04-15 21:39:58 +00:00
Henrik Levkowetz
f10ddadc0e
Merged in changes from trunk up to r17584.
...
- Legacy-Id: 17593
2020-04-07 16:02:52 +00:00
Henrik Levkowetz
dc4c05ec5b
Changed the object factory instances of nomcom private key and cert to be byte objects (matching the production settings), and fixed the issue with nomcom key handling under Py3 found by fenton@bluepopcorn.net. Did some renaming in nomcom/tests.py to better match setup/teardown function names to functionality.
...
- Legacy-Id: 17536
2020-03-25 13:36:29 +00:00
Henrik Levkowetz
726fcbf27d
Removed all __future__ imports.
...
- Legacy-Id: 17391
2020-03-05 23:53:42 +00:00
Robert Sparks
7aa57e9f57
Restrict comments total on nomcom private index to comments on positions. Fixes #2792 . Commit ready for merge.
...
- Legacy-Id: 16759
2019-09-26 21:49:55 +00:00
Henrik Levkowetz
a5e31c3f40
Py2/3 compatibility: Added __future__ import.
...
- Legacy-Id: 16452
2019-07-15 15:52:18 +00:00
Henrik Levkowetz
1e115539c4
The previous nomcom.fields.EncryptedTextField relied on initial cleartext content having the same type as ciphertext. Under Python3, that's not the case (ciphertext has type bytes). Rewrote the nomcom app and tests to handle capture of comments and encryption to the Feedback.comments ciphertext differently.
...
- Legacy-Id: 16350
2019-07-01 11:59:59 +00:00
Henrik Levkowetz
d7f5c84182
Initial 2to3 patch with added copyright statement updates.
...
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz
f54d6cd23d
Merged in [16092] from rcross@amsl.com:
...
Remove ability to cancel a break session. Fixes #2703 .
- Legacy-Id: 16105
Note: SVN reference [16092] has been migrated to Git commit b5850d5c7f
2019-03-26 15:53:41 +00:00
Robert Sparks
6118975620
Added an explicit ID-Exists state for the IESG state machine. Reworked code so that the IESG state machine always has a state. Added the ability to release a document from a working group, research group, or the independent stream. Releasing a document removes all stream state, and sets the document to have no stream.
...
- Legacy-Id: 15809
2018-12-11 22:38:05 +00:00
Henrik Levkowetz
fcddc86447
Fixed some incorrect topic audience id slugs, to make the topic availability filtering work correctly.
...
- Legacy-Id: 15598
2018-10-19 12:53:16 +00:00
Henrik Levkowetz
b984422471
Added pagination to the nomcom pending-feedback page, to reduce load time.
...
- Legacy-Id: 15534
2018-10-08 11:51:21 +00:00
Henrik Levkowetz
64ba033a6c
Changed the default sort for nomcom.models.Nominees to be 'person__name'.
...
- Legacy-Id: 15532
2018-10-08 09:55:10 +00:00
Henrik Levkowetz
29ae7809d7
Merged in [15486] from rjsparks@nostrum.com:
...
Allow a nomcom to show nominees that have accepted nomination before feedback is open. Fixes #2598 .
- Legacy-Id: 15487
Note: SVN reference [15486] has been migrated to Git commit 4d5de5dee6
2018-09-26 21:54:05 +00:00
Robert Sparks
4d5de5dee6
Allow a nomcom to show nominees that have accepted nomination before feedback is open. Fixes #2598 . Commit ready for merge.
...
- Legacy-Id: 15486
2018-09-26 18:57:30 +00:00
Henrik Levkowetz
120d78bbbf
Changed the sort order of nominees on the private index page to be according to name (instead of email address).
...
- Legacy-Id: 15479
2018-09-21 19:47:40 +00:00
Henrik Levkowetz
fcc22da623
Removed a chunk of code that won't be executed in all test environments from the test coverage measurements
...
- Legacy-Id: 14550
2018-01-23 17:29:41 +00:00
Henrik Levkowetz
374950ede8
Removed code generating nomcom page urls which doesn't resolve any more. Added a comment about the eligibility view for previous nomcoms.
...
- Legacy-Id: 14540
2018-01-19 15:06:23 +00:00
Robert Sparks
4ce6b934b8
Add a page for the nomcom-chair and the secretariat to view who the datatracker thinks is nomcom eligible. Related to #2257 . Commit ready for merge.
...
- Legacy-Id: 14533
2018-01-17 17:58:58 +00:00
Robert Sparks
5835e52759
Allow all the nomcom private tabs to show on the nomcom chair configuration help page. Fixes #2303 . Commit ready for merge.
...
- Legacy-Id: 14511
2018-01-11 16:28:19 +00:00
Robert Sparks
c8b451094a
Make extracting lists of nomcom-related email addresses easier for the nomcom chair. Fixes #1852 . Commit ready for merge.
...
- Legacy-Id: 14505
2018-01-10 21:54:10 +00:00
Robert Sparks
94f4e9ac58
Simplify the edit nomcom members forms. Fixes #1756 . Commit ready for merge.
...
- Legacy-Id: 14504
2018-01-10 18:26:20 +00:00
Robert Sparks
7cecd9fe38
Further refinements to the nominee status table. Related to #2261 . Commit ready for merge.
...
- Legacy-Id: 14058
2017-08-16 21:59:51 +00:00
Robert Sparks
2dbb0766fd
Improve the nominee status table to serve as a nomcom dashboard. Fixes #2261 . Commit ready for merge.
...
- Legacy-Id: 14057
2017-08-16 20:42:33 +00:00
Henrik Levkowetz
3c727106a2
Merged in [13717] from rjsparks@nostrum.com:
...
Actually use the topic audience type in the feedback view. Fixes #2320 .
- Legacy-Id: 13728
Note: SVN reference [13717] has been migrated to Git commit 9638cb2e397beab18f3607b324518fd2900215f7
2017-06-29 12:52:25 +00:00
Robert Sparks
4813177086
Allow the nomcom to collect feedback on arbitrary topics. Fixes #2256 and #1846 . Commit ready for merge.
...
- Legacy-Id: 13474
2017-05-30 19:54:31 +00:00
Robert Sparks
ab6820e938
Correctly calculate statistics on the nomcom private index page. Fixes #2254 . Commit ready for merge.
...
- Legacy-Id: 13400
2017-05-22 19:07:52 +00:00
Robert Sparks
ac8e5f5402
Make it possible to close nominations without closing feedback. Fixes #2255 . Commit ready for merge.
...
- Legacy-Id: 13399
2017-05-22 18:40:05 +00:00
Robert Sparks
1a18130c57
Avoid confusing messages saying a key has not been entered when it has. Fixes #2250 . Commit ready for merge.
...
- Legacy-Id: 13390
2017-05-17 21:02:20 +00:00
Robert Sparks
ceff54480c
Update the feedback count badge when new feedback is provided. Fixes #2260 . Commit ready for merge.
...
- Legacy-Id: 13388
2017-05-17 13:55:39 +00:00
Lars Eggert
8a70e9773d
Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
...
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Henrik Levkowetz
5f053ad21a
Cleaned up the remaining explicit url names, using dotted-paths to view
...
functions instead. In all almost 700 changes.
- Legacy-Id: 12923
2017-02-26 23:21:49 +00:00
Henrik Levkowetz
aa5e61d958
Updated all urlpatterns to use ietf.utils.urls.url() instead of django's,
...
in order to autogenerate dotted path url pattern names. Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.
Changed some imports to prevent import of ietf.urls before django
initialization was complete.
Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.
Started converting old-style middleware classes to new-style middleware
functions (incomplete).
Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.
Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.
Rewrote the filename argument handling in a management command which had
broken with the upgrade.
- Legacy-Id: 12818
2017-02-11 14:43:01 +00:00
Henrik Levkowetz
1fef6fb1d3
Deprecation fix: removed additional cases of using instance_context in render*()
...
- Legacy-Id: 12720
2017-01-23 22:56:34 +00:00
Henrik Levkowetz
7b95411f58
The context_instance parameter to render_to_response() and render_to_string() is now deprecated. Fixed this, and generally changed the idiom render_to_response('template.html', {}, RequestContext(request)) to the newer and simpler render(request, 'template.html', {}). About 200 instances.
...
- Legacy-Id: 12637
2017-01-09 21:26:30 +00:00
Henrik Levkowetz
26fcce9c28
Brought back the nomcom nominee merge functionality which was inadvertently removed in January. There is now both a Merge Nominee and a Merge Person form, with additional instructions which should make it easier to choose the right one for the task.
...
- Legacy-Id: 12017
2016-09-22 14:23:20 +00:00
Robert Sparks
dc5ae398f2
Improved SearchablePersonField to show the primary email address for any search results where a name appears more than once.
...
Simplified the edit nominee form.
Replaced the merge nominee form with a request to the secretariat to merge Person records. Fixes #1847 .
Added merging nominees to the secretariat's person merging script.
Restructured the person merging script to make it testable.
Updated some tests to match changes to the mailtriggers that hadn't made it to the fixtures.
- Legacy-Id: 10625
2015-12-22 21:42:55 +00:00
Robert Sparks
fa53de03e3
Guide the workflow back to normal nominations after nominating a new person.
...
- Legacy-Id: 10619
2015-12-21 21:01:23 +00:00
Robert Sparks
85c13d65b4
Replaced the custom message infrastructure in the nomcom app with django.contrib.messages
...
- Legacy-Id: 10618
2015-12-21 20:46:56 +00:00
Robert Sparks
2120b79d6b
collapse some duplicated code
...
- Legacy-Id: 10617
2015-12-21 16:50:46 +00:00
Robert Sparks
8261507e80
Added forms for the exceptional "create a new person for this nomination" workflow. Checkpointing before a round of simplification refactors.
...
- Legacy-Id: 10610
2015-12-18 23:11:24 +00:00
Robert Sparks
de0b7c9a37
Checkpoint: views tests at 96%
...
- Legacy-Id: 10606
2015-12-16 23:12:40 +00:00
Robert Sparks
f68d546233
removed move_to_default
...
- Legacy-Id: 10603
2015-12-16 12:07:32 +00:00
Robert Sparks
df571c2fcc
Improved test coverage (from 66 to 87%) - checkpointing before removing move_to_default
...
- Legacy-Id: 10602
2015-12-16 11:51:32 +00:00
Robert Sparks
5e0632e8eb
Regroup the view-feedback view to make it easier to see where to spend review effort. Fixes #1866 .
...
- Legacy-Id: 10592
2015-12-14 21:05:52 +00:00
Robert Sparks
9ddcd62c44
Allow nominees to add a comment when accepting or declining. Fixes #1845 .
...
- Legacy-Id: 10589
2015-12-14 03:26:43 +00:00
Robert Sparks
b653e8fe8a
Removed the description field from Position. Simplified the Position list and the Position edit form. Tweaked several places to make the pages more self documenting. Added a page to help nomcom chairs through setting up a new nomcom. Fixes #1867 and #1768 .
...
- Legacy-Id: 10565
2015-12-09 23:24:46 +00:00
Robert Sparks
f566a83d1d
Captured when nomcom members reviewed feedback for a given nominee last. Added badges when new feedback is available. Improved layout of feedback index page. Fixes #1850 .
...
- Legacy-Id: 10535
2015-12-02 23:25:42 +00:00