altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
6432 commits 1 branch 0 tags 2.6 GiB
Commit graph

251 commits

Author SHA1 Message Date
Robert Sparks aadcf2d056 Added selecting existing people to the workflow for chair classification of nominations. Renamed some utility functions to be slightly more self-documenting. 
- Legacy-Id: 10620
 2015-12-22 04:32:48 +00:00
Robert Sparks fa53de03e3 Guide the workflow back to normal nominations after nominating a new person. 
- Legacy-Id: 10619
 2015-12-21 21:01:23 +00:00
Robert Sparks 85c13d65b4 Replaced the custom message infrastructure in the nomcom app with django.contrib.messages 
- Legacy-Id: 10618
 2015-12-21 20:46:56 +00:00
Robert Sparks 2120b79d6b collapse some duplicated code 
- Legacy-Id: 10617
 2015-12-21 16:50:46 +00:00
Robert Sparks 8261507e80 Added forms for the exceptional "create a new person for this nomination" workflow. Checkpointing before a round of simplification refactors. 
- Legacy-Id: 10610
 2015-12-18 23:11:24 +00:00
Robert Sparks 6bf4227974 Checkpoint: main nomination forms use SearchableEmailField 
- Legacy-Id: 10609
 2015-12-18 20:38:17 +00:00
Robert Sparks a2af7cfa25 Removed BaseNomcomForm and the notion of custom fieldsets 
- Legacy-Id: 10608
 2015-12-17 22:31:29 +00:00
Robert Sparks ebb6884b70 Beginning to rework Nominee and Nomination 
- Legacy-Id: 10607
 2015-12-17 21:53:39 +00:00
Robert Sparks de0b7c9a37 Checkpoint: views tests at 96% 
- Legacy-Id: 10606
 2015-12-16 23:12:40 +00:00
Robert Sparks f68d546233 removed move_to_default 
- Legacy-Id: 10603
 2015-12-16 12:07:32 +00:00
Robert Sparks df571c2fcc Improved test coverage (from 66 to 87%) - checkpointing before removing move_to_default 
- Legacy-Id: 10602
 2015-12-16 11:51:32 +00:00
Robert Sparks bf54e2b3f5 Regroup multiselect options to make classifying pending feedback simpler. Make the control larger and resizable. Fixes #1854. 
- Legacy-Id: 10593
 2015-12-14 23:14:44 +00:00
Robert Sparks 5e0632e8eb Regroup the view-feedback view to make it easier to see where to spend review effort. Fixes #1866. 
- Legacy-Id: 10592
 2015-12-14 21:05:52 +00:00
Robert Sparks 9ddcd62c44 Allow nominees to add a comment when accepting or declining. Fixes #1845. 
- Legacy-Id: 10589
 2015-12-14 03:26:43 +00:00
Robert Sparks 7d120da9ef Removed the type from the template pathname for the requirements templates. Made the requiremetns view work for both template types plain and rst. Changed the default for the requirements template for new nomcoms to rst. Migrated 2015 requirements to rst (except for the IAB position, which would require a significant edit) 
- Legacy-Id: 10587
 2015-12-12 03:49:23 +00:00
Robert Sparks d2f1d1ff12 corrected an improper import and removed some flakes 
- Legacy-Id: 10582
 2015-12-11 19:49:33 +00:00
Robert Sparks ea6d82846f Avoiding an initialization problem by setting NOMCOM_PUBLIC_KEYS_DIR in settings_sqlitetest. This is not the best long term fix 
- Legacy-Id: 10581
 2015-12-11 17:30:13 +00:00
Robert Sparks 6574618cdf a stab in the dark at initializing the public_key in a test friendly way 
- Legacy-Id: 10575
 2015-12-11 05:06:58 +00:00
Robert Sparks 3bc615883d normalizes management of a test directory for test nomcom public keys 
- Legacy-Id: 10574
 2015-12-11 04:01:11 +00:00
Robert Sparks 66e89e7d29 improved creation of FeedbackLastSeen 
- Legacy-Id: 10572
 2015-12-10 23:07:57 +00:00
Robert Sparks b653e8fe8a Removed the description field from Position. Simplified the Position list and the Position edit form. Tweaked several places to make the pages more self documenting. Added a page to help nomcom chairs through setting up a new nomcom. Fixes #1867 and #1768. 
- Legacy-Id: 10565
 2015-12-09 23:24:46 +00:00
Robert Sparks f566a83d1d Captured when nomcom members reviewed feedback for a given nominee last. Added badges when new feedback is available. Improved layout of feedback index page. Fixes #1850. 
- Legacy-Id: 10535
 2015-12-02 23:25:42 +00:00
Robert Sparks d65987b935 Improve the questionnaire templates, reminding the nominee that receiving the questionnaire does not imply they have accepted the nomination. Fixes #1807. 
- Legacy-Id: 10534
 2015-12-02 17:01:10 +00:00
Robert Sparks 5de9343359 Removes the generation of the count badge from a templatetag into the template 
- Legacy-Id: 10531
 2015-12-02 15:45:40 +00:00
Robert Sparks 2a63f91d31 Simplify pass of counts 
- Legacy-Id: 10527
 2015-12-02 04:44:42 +00:00
Robert Sparks a4561f55f2 improvement that makes only one counting query 
- Legacy-Id: 10526
 2015-12-02 04:31:35 +00:00
Robert Sparks f4f67425bf fixes a type error in the feedback form. Starts to simplify construction of the feedback badges. 
- Legacy-Id: 10525
 2015-12-02 03:32:06 +00:00
Robert Sparks 121c4d2b2d Improve the list of nominees on the feedback page. Fixes #1786 and #1809. 
- Legacy-Id: 10524
 2015-11-29 21:12:19 +00:00
Robert Sparks 473970a767 Missed an svn add 
- Legacy-Id: 10523
 2015-11-29 04:16:07 +00:00
Robert Sparks a2b03420b7 Removed the notion of an incumbent. Fixes #1771. 
- Legacy-Id: 10522
 2015-11-29 04:00:02 +00:00
Robert Sparks 5bafd3d8fe Conditioned behavior of views for concluded nomcoms. Fixes #1856. 
- Legacy-Id: 10521
 2015-11-28 21:51:37 +00:00
Robert Sparks e81b473282 Expose views for concluded nomcoms. Close feedback and nomination. Initial work on factory-boy based testing. Partially addresses #1856 
- Legacy-Id: 10520
 2015-11-25 22:17:41 +00:00
Robert Sparks 2197259102 Reorganized the tab navigation on the nomcom private pages. Made it more obvious when the chair is doing something that only the chair gets to see. Fixes #1788 and #1795. 
- Legacy-Id: 10505
 2015-11-17 22:50:35 +00:00
Robert Sparks 00e5762e20 Simplify the nomcom feedback comment form. Make that more obvious who receives mail when that form is used. Fixes #1849. 
- Legacy-Id: 10501
 2015-11-16 21:46:29 +00:00
Henrik Levkowetz cf7d794b09 Modified the test data to use some AD and WG chair names that contain non-ascii characters, and fixed test issues found. 
- Legacy-Id: 10418
 2015-11-04 07:34:56 +00:00
Henrik Levkowetz 97f7159a48 Migration for the nomcom 'public_key' field change to a settings-agnostic FileStorage. 
- Legacy-Id: 10301
 2015-10-27 15:34:43 +00:00
Henrik Levkowetz 4eaadddf9e Changed nomcom.models.Nomcom() to use a FileSystemStorage which doesn't record the file system location in the migration, in order to avoid having model changes detected when switching from one development path to another. 
- Legacy-Id: 10280
 2015-10-24 20:13:18 +00:00
Henrik Levkowetz 4a80395a63 Removed support for perma_fixtures, using the blobal test fixtures instead. 
- Legacy-Id: 10228
 2015-10-18 11:49:15 +00:00
Robert Sparks f0f5a51eb6 (Rocky) merge forward. 
- Legacy-Id: 10157
 2015-10-09 03:16:24 +00:00
Henrik Levkowetz e1cc8218e7 Merged in [10115] from rjsparks@nostrum.com: 
Remove an extraneous field from the form that lets the nomcom chair paste in a questionnaire response.
 - Legacy-Id: 10118
Note: SVN reference [10115] has been migrated to Git commit 3ee236d3ee25dffdd3516b0740251705c4db248c
 2015-10-01 20:44:47 +00:00
Robert Sparks f5b6465e81 mailtoken becomes mailtrigger 
- Legacy-Id: 10090
 2015-09-17 20:03:45 +00:00
Robert Sparks 90c3426e2f updated mailtoken utilities to match the model refactor. Morphed all the code using the utilities to match. Added paths to get Cc through as needed. Next up: Recipient selection form for the iesg save-and-send-email workflow 
- Legacy-Id: 10040
 2015-08-23 18:15:06 +00:00
Henrik Levkowetz cb75c7d908 Added a migration for the Nomination.share_nominator field. 
- Legacy-Id: 10039
 2015-08-23 09:15:20 +00:00
Henrik Levkowetz f6c78bcecb Merged in [10004] from rjsparks@nostrum.com: 
Return new forms instead of validated forms for nomcom nominations and feedback. Fixes #1703.
 - Legacy-Id: 10037
Note: SVN reference [10004] has been migrated to Git commit 1517efaba2
 2015-08-22 18:00:16 +00:00
Robert Sparks 8a74604a1b Done with the second pass focusing on test coverage. Lots of test tweaks, some new tests, a couple of bugs fixed. The session request code views need to be redone to allow testing. 
- Legacy-Id: 10035
 2015-08-21 16:39:00 +00:00
Robert Sparks 83753dd24e Tests nomcom confirmation receipts. Fixes bug in submission blackout test where test was using local time, but view was using utc 
- Legacy-Id: 10034
 2015-08-20 04:23:40 +00:00
Robert Sparks 65be4190a7 Done with the first pass instrumenting all mail points. There is one spot in the ipr code that's complicated and will require some refactor before instrumenting. There are a few places to add explicit messages (templates and all) to replace the simple use of email_ad. The next pass will be to make sure every spot that sends mail is covered by a test, and that the tests look at the headers sensibly. That will be followed by a moderately heavy refactor of MailToken and the gather_address utilities. Then pages showing the expansions of a token for a given document/group. Long way to go, but this is working well, and I think it will make things much easier later. 
- Legacy-Id: 10030
 2015-08-19 21:53:02 +00:00
Henrik Levkowetz 0449ebcdfa Merged in [10002] from rjsparks@nostrum.com: 
Add a checkbox to the nomination form to indicate permission to nomcom to share the nominator's name with the nominee.
 - Legacy-Id: 10023
Note: SVN reference [10002] has been migrated to Git commit bcc14cb0d1
 2015-08-18 15:39:12 +00:00
Robert Sparks 1517efaba2 Return new forms instead of validated forms for nomcom nominations and feedback. Fixes #1703. Commit ready for merge. 
- Legacy-Id: 10004
 2015-08-10 18:28:08 +00:00
Robert Sparks bcc14cb0d1 Add a checkbox to the nomination form to indicate permission to nomcom to share the nominator's name with the nominee. Commit ready for merge. 
- Legacy-Id: 10002
 2015-08-10 17:57:38 +00:00