* feat: Allow reviewer to accept a review they're previously rejected
* feat: Add a reviewer who has previously rejected a review to the list of suggested reviewers.
This largely un-does d105f8b, at the request of at least one team secretary.
* fix: Went a little overboard on the previous commit
one_assignment still has to exclude reviewers who rejected the assignment,
or they could end up being the suggested reviewer.
* fix: Actually do the assignment
* fix: If there's an existing assignment, don't create a new one
* style: Restructure conditional for clarity
* test: Add test cases for accepting or assigning a review assignment after rejecting it
* fix: Allow filtering for nominees who have not declined
Fixes#6380
* Update views.py
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
---------
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
* Added a new review team setting
allow_reviewer_to_reject_after_deadline that will allow rejecting
review requests, even after the deadline is past. Also modified that
the secretary, or whoever manages the reviews is always allowed to
reject the review regardless of the deadline as he/she could change
the deadline anyways.
* Fixed but in view_reviews (wrong variable name), added more test
cases to the test_reviews.py for different reject cases.
* test: More thoroughly exercise assignment rejection
* chore: Renumber migration
* test: Unrelated user cannot reject assignments
---------
Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
* refactor: Add helper class to compare tag changes
* feat: Give AD the action in ad-f-up state
* refactor: Remove unnecessary check
* refactor: Reorganize update_action_holders()
* refactor: Remove unnecessary guard
* test: Update test for new AD handling
* test: Update another test
* test: Test ad-f-up effect on action holders
---------
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
* fix: Reject nul characters in ipr search parameters
Really ought to rework this as a form, but in the meantime
this should prevent 500s. Could probably reduce the number
of places we check the value.
* fix: Guard against absent parameters
* fix: Remove stray junk
* fix: Use correct response code (400, not 405)
* test: Test handling of null chars in IPR search
* refactor: Simplify branch statements
This helps my code validator see that "start" is
always set.
* fix: Allow secretariat to change the state of a dead draft (#6051)
* refactor: Move the secretariat-can-edit-dead-state enablement to the template to limit side-effects.
* style: Correct whitespace to fully revert file
---------
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
