Commit graph

12457 commits

Author SHA1 Message Date
Jennifer Richards 0dadeb2af8
fix: Fix task specs in periodic_tasks.py (#6965) 2024-01-24 11:31:34 -06:00
Robert Sparks d9cc26be96
feat: replace references to User with references to Person (#6024)
* refactor: change references from User to Person (#5821)

* refactor: Change CommunityList reference from User to Person

* refactor: Convert more user references to person

* refactor: Change augment_docs_and_user_with_user_info to person

* refactor: Change Nomination and Feedback references from User to Person

* refactor: Change a few test case function signatures to be more pythonic

* refactor: Harmonize how profile and photo views look up email_or_name

* refactor: Rework community views to operate on Person instead of User (#5859)

* test: Update tests to try all of the person's emails and aliases

* fix: Recode a test case to avoid an exception if there's Unicode in the URL

This only happens using the form-filling and submission feature of
WebTest, which is only used in this one test case, so just it rip out.

* test: Add duplicate-person tests

* fix: If there are multiple matching users, prefer the logged-in one.

* chore: We no longer use WebTest, so don't include it.

* fix: Address review comments

* fix: case-insensitive person name or email matching (#6096)

* chore: Renumber migrations

* fix: Update merged code so tests pass (#6887)

* fix: Use refactored method

* fix: Don't assume user has person

* fix: Use new view param name

* chore: Drop community lists w/o person; cleanup (#6896)

* fix: Don't assume user has person

* fix: user->person in update_community_list_index.py

* feat: Remove CommunityLists without Person

* refactor: Speed up nomcom migrations

---------

Co-authored-by: Paul Selkirk <paul@painless-security.com>
Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
2024-01-24 11:00:19 -06:00
Jennifer Richards 36c43c8520
chore: add task tests; move message task to message app (#6964)
* test: Test send_review_reminders_task

* refactor: Move send_scheduled_mail_task to message app

* chore: Remove unused import

* test: Add Message/SendQueue factories

* test: Test send_scheduled_mail_task

* test: Reset mocks before reuse

* test: Cover error conditions

* test: Return non-empty change set

* test: Test SMTPException handling

* test: Test fetch_attendance_from_meetings()

* test: Test RuntimeError handling

* test: RFC index sync should populate authors
2024-01-24 08:53:42 -06:00
Robert Sparks 7438a4e87a
chore: remove unused code (#6963) 2024-01-23 18:24:25 -06:00
Jennifer Richards 7dbb7e36d3
fix: Add testing, fix bug in fetch_meeting_attendance_task (#6961)
* test: Test rfc_editor_index_update_task

* chore: Add docstring to test

* fix: Reuse stats instead of fetching twice

* test: Test fetch_meeting_attendance_task

* chore: Remove outdated tasks

* Revert "chore: Add docstring to test"

This reverts commit 0395410d665c0d310248fd151386f013357c5d13.

* Revert "test: Test rfc_editor_index_update_task"

This reverts commit 4dd9dd131723497db3d2aa76166169fd32c42fdd.

* test: Test rfc_editor_index_update_task

This time without reformatting the entire file...

* chore: Remove accidentally committed fragment

* test: Annotate function to satisfy mypy

* chore: Remove unused imports
2024-01-23 16:14:37 -06:00
Jennifer Richards 4227ef5948
fix: do nothing if rfc has no draft; add test (#6960)
* fix: Check that rfc came from draft first

* test: Add mgmt command test

* test: Cannot force-reset draftless RFC
2024-01-23 10:58:34 -06:00
Jennifer Richards 97822214eb
fix: Set authors when publishing an RFC (#6957)
* fix: Copy authors from draft when RFC is published

* feat: Mgmt command to set RFC authors from draft

* feat: Better event messages
2024-01-23 09:04:13 -06:00
Jennifer Richards 7de8feca83
chore: Remove unused import (#6958) 2024-01-23 08:41:23 -06:00
Jennifer Richards 8d12071bf5
refactor: Move cron jobs to celery tasks (#6926)
* refactor: Factor out helper from fetch_meeting_attendance.py

* feat: Define fetch_meeting_attendance_task task

Equivalent to the fetch_meeting_attendance management command

* chore: Disable fetch_meeting_attendance in bin/daily

* feat: Log errors in fetch_meeting_attendance_task

* feat: Enable a result backend for celery

Ignore results by default, but enable the backend so we
can manage tasks

* feat: Define daily task in ietf.utils.tasks

* refactor: Make bin/send-review-reminders into a task

* refactor: Make bin/send-scheduled-mail into a task

* chore: Update copyright years

* refactor: Make bin/rfc-editor-index-updates into a task

* refactor: Accept date type in rfc index update fn

* chore: Update comment

* fix: Annotate param as Optional

* fix: Revert treating skip_older_than_date as str

Misunderstood the comment, "fixed" a non-bug. Oops.

* feat: mgmt command to create periodic tasks

* feat: add summary of tasks to mgmt cmd

* style: black

* fix: Remove debug statements

* feat: Enable/disable tasks

* chore: Disable periodic tasks by default

* chore: Revert changes to daily and every15m

* fix: Call intended function

* chore: Add task descriptions
2024-01-22 12:04:16 -06:00
Robert Sparks b38e8c38ae
chore: shadowbox with mypy 2024-01-19 14:21:09 -06:00
Robert Sparks fc2673c13c
refactor: use statics.ietf.org for all statics 2024-01-18 16:51:09 -06:00
Robert Sparks 473b84ef90
feat: color for wit in the schedule editor (#6930) 2024-01-17 15:39:28 -06:00
Robert Sparks 06f496ca6c
fix: reduce database queries when building menues (#6928) 2024-01-17 13:19:20 -06:00
dependabot[bot] 1bcee8b506
chore(deps): bump the yarn group with 15 updates (#6924)
* chore(deps): bump the yarn group with 15 updates

Bumps the yarn group with 15 updates:

| Package | From | To |
| --- | --- | --- |
| [caniuse-lite](https://github.com/browserslist/caniuse-lite) | `1.0.30001572` | `1.0.30001576` |
| [highcharts](https://github.com/highcharts/highcharts-dist) | `11.2.0` | `11.3.0` |
| [naive-ui](https://github.com/tusen-ai/naive-ui) | `2.36.0` | `2.37.3` |
| [sortablejs](https://github.com/SortableJS/Sortable) | `1.15.1` | `1.15.2` |
| [vue](https://github.com/vuejs/core) | `3.4.4` | `3.4.13` |
| [@parcel/optimizer-data-url](https://github.com/parcel-bundler/parcel) | `2.10.3` | `2.11.0` |
| [@parcel/transformer-inline-string](https://github.com/parcel-bundler/parcel) | `2.10.3` | `2.11.0` |
| [@parcel/transformer-sass](https://github.com/parcel-bundler/parcel) | `2.10.3` | `2.11.0` |
| [@vitejs/plugin-vue](https://github.com/vitejs/vite-plugin-vue/tree/HEAD/packages/plugin-vue) | `4.5.0` | `4.6.2` |
| [c8](https://github.com/bcoe/c8) | `9.0.0` | `9.1.0` |
| [eslint-plugin-n](https://github.com/eslint-community/eslint-plugin-n) | `16.6.1` | `16.6.2` |
| [eslint-plugin-vue](https://github.com/vuejs/eslint-plugin-vue) | `9.19.2` | `9.20.1` |
| [html-validate](https://gitlab.com/html-validate/html-validate) | `8.8.0` | `8.9.1` |
| [parcel](https://github.com/parcel-bundler/parcel) | `2.10.3` | `2.11.0` |
| [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) | `4.5.0` | `4.5.1` |


Updates `caniuse-lite` from 1.0.30001572 to 1.0.30001576
- [Commits](https://github.com/browserslist/caniuse-lite/compare/1.0.30001572...1.0.30001576)

Updates `highcharts` from 11.2.0 to 11.3.0
- [Commits](https://github.com/highcharts/highcharts-dist/compare/v11.2.0...v11.3.0)

Updates `naive-ui` from 2.36.0 to 2.37.3
- [Changelog](https://github.com/tusen-ai/naive-ui/blob/main/CHANGELOG.en-US.md)
- [Commits](https://github.com/tusen-ai/naive-ui/compare/v2.36.0...v2.37.3)

Updates `sortablejs` from 1.15.1 to 1.15.2
- [Release notes](https://github.com/SortableJS/Sortable/releases)
- [Commits](https://github.com/SortableJS/Sortable/compare/1.15.1...1.15.2)

Updates `vue` from 3.4.4 to 3.4.13
- [Release notes](https://github.com/vuejs/core/releases)
- [Changelog](https://github.com/vuejs/core/blob/main/CHANGELOG.md)
- [Commits](https://github.com/vuejs/core/compare/v3.4.4...v3.4.13)

Updates `@parcel/optimizer-data-url` from 2.10.3 to 2.11.0
- [Release notes](https://github.com/parcel-bundler/parcel/releases)
- [Changelog](https://github.com/parcel-bundler/parcel/blob/v2/CHANGELOG.md)
- [Commits](https://github.com/parcel-bundler/parcel/compare/v2.10.3...v2.11.0)

Updates `@parcel/transformer-inline-string` from 2.10.3 to 2.11.0
- [Release notes](https://github.com/parcel-bundler/parcel/releases)
- [Changelog](https://github.com/parcel-bundler/parcel/blob/v2/CHANGELOG.md)
- [Commits](https://github.com/parcel-bundler/parcel/compare/v2.10.3...v2.11.0)

Updates `@parcel/transformer-sass` from 2.10.3 to 2.11.0
- [Release notes](https://github.com/parcel-bundler/parcel/releases)
- [Changelog](https://github.com/parcel-bundler/parcel/blob/v2/CHANGELOG.md)
- [Commits](https://github.com/parcel-bundler/parcel/compare/v2.10.3...v2.11.0)

Updates `@vitejs/plugin-vue` from 4.5.0 to 4.6.2
- [Release notes](https://github.com/vitejs/vite-plugin-vue/releases)
- [Changelog](https://github.com/vitejs/vite-plugin-vue/blob/plugin-vue@4.6.2/packages/plugin-vue/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite-plugin-vue/commits/plugin-vue@4.6.2/packages/plugin-vue)

Updates `c8` from 9.0.0 to 9.1.0
- [Release notes](https://github.com/bcoe/c8/releases)
- [Changelog](https://github.com/bcoe/c8/blob/main/CHANGELOG.md)
- [Commits](https://github.com/bcoe/c8/compare/v9.0.0...v9.1.0)

Updates `eslint-plugin-n` from 16.6.1 to 16.6.2
- [Release notes](https://github.com/eslint-community/eslint-plugin-n/releases)
- [Commits](https://github.com/eslint-community/eslint-plugin-n/compare/16.6.1...16.6.2)

Updates `eslint-plugin-vue` from 9.19.2 to 9.20.1
- [Release notes](https://github.com/vuejs/eslint-plugin-vue/releases)
- [Commits](https://github.com/vuejs/eslint-plugin-vue/compare/v9.19.2...v9.20.1)

Updates `html-validate` from 8.8.0 to 8.9.1
- [Release notes](https://gitlab.com/html-validate/html-validate/tags)
- [Commits](https://gitlab.com/html-validate/html-validate/compare/v8.8.0...v8.9.1)

Updates `parcel` from 2.10.3 to 2.11.0
- [Release notes](https://github.com/parcel-bundler/parcel/releases)
- [Changelog](https://github.com/parcel-bundler/parcel/blob/v2/CHANGELOG.md)
- [Commits](https://github.com/parcel-bundler/parcel/compare/v2.10.3...v2.11.0)

Updates `vite` from 4.5.0 to 4.5.1
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v4.5.1/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.5.1/packages/vite)

---
updated-dependencies:
- dependency-name: caniuse-lite
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: yarn
- dependency-name: highcharts
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: yarn
- dependency-name: naive-ui
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: yarn
- dependency-name: sortablejs
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: yarn
- dependency-name: vue
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: yarn
- dependency-name: "@parcel/optimizer-data-url"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: yarn
- dependency-name: "@parcel/transformer-inline-string"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: yarn
- dependency-name: "@parcel/transformer-sass"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: yarn
- dependency-name: "@vitejs/plugin-vue"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: yarn
- dependency-name: c8
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: yarn
- dependency-name: eslint-plugin-n
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: yarn
- dependency-name: eslint-plugin-vue
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: yarn
- dependency-name: html-validate
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: yarn
- dependency-name: parcel
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: yarn
- dependency-name: vite
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: yarn
...

Signed-off-by: dependabot[bot] <support@github.com>

* test: Disable hidden-focusable and unique-landmark validations

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
2024-01-16 11:00:23 -06:00
Jennifer Richards 47dad0706d
refactor: Avoid module-level queries (#6916)
* refactor: Avoid module-level queries

* refactor: Avoid repeated State queries
2024-01-16 08:53:24 -06:00
Jennifer Richards cb70da9584
fix: Never show AD col on drafts_for_ad.html (#6914)
* fix: Pass ad as Person instead of name

* refactor: Remove redundant AD check

Results being shown are already filtered by AD if the `ad`
variable is not `None`

* refactor: Add show_ad... flag to prepare_document_table

* refactor: Expose show_ad_and_shepherd flag
2024-01-12 16:39:59 -06:00
Jennifer Richards c7ca0b7d8e
Revert "chore: Replace markup_txt with rfc2html (#6632)" (#6909)
This reverts commit e24fb601db.
2024-01-11 13:08:24 -06:00
Robert Sparks 38ffd8ad2e
fix: correct DATE DTEND values - they are non-inclusive (#6907) 2024-01-10 13:55:07 -06:00
Jennifer Richards 81dc5554a8
test: unpin django-stubs and update mypy (#6901)
* chore: Unpin django-stubs / update mypy

* test: Use "app.model" for ManyToManyField

django-stubs requires "app.model" instead of just "model" for
ManyToManyField lazy model references.

See https://github.com/typeddjango/django-stubs/issues/1802
2024-01-10 09:53:43 -06:00
Robert Sparks 3312913c6f
fix: better archive search links for group documents (#6835) 2024-01-09 15:17:11 -06:00
Lars Eggert e24fb601db
chore: Replace markup_txt with rfc2html (#6632)
* chore: Replace markup_txt with rfc2html

* Suppress HTML issues

* Remove comment

* Suppress harder

* Suppress even more

* Fix test

* Ignore vnu "duplicate ID" errors

* Undo accidental commit

* Fix RFCs

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2024-01-05 12:29:28 -06:00
Robert Sparks 88bc604949
fix: filter draft documents that became RFCs out of docs by ad (#6884) 2024-01-05 08:10:24 -06:00
Lars Eggert 5174e399ed
fix: Adjust dark theme to make range slider more visible (#6885)
Fixes #6881
2024-01-05 07:47:39 -06:00
Robert Sparks 678feca759
fix: remove unneeded (and broken) redirect (#6866) 2024-01-04 12:08:06 -06:00
Robert Sparks 2331b7541b
Merge pull request #6878 from pselkirk/fix-6861
fix: Correctly display the last pre-RFC rev of a draft
2024-01-04 11:01:08 -06:00
Paul Selkirk 02e0d960a4 fix: Correctly display the last pre-RFC rev of a draft 2024-01-04 00:50:08 -05:00
Paul Selkirk b445119428
fix: Properly set AD as action holder when submitting to IESG for publication (#6854)
* fix: Properly set AD as action holder when submitting to IESG for publication (#5227)

The clear intent of `to_iesg` is that
a) the document AD should be the group AD, if not already set, and
b) the document Action Holder should be the document AD;
but there was an order-of-operation error,
such that the Action Holder remained empty.

* refactor: Don't take values out of the parent scope, don't insert values into the parent scope

* refactor: Streamline DocEvent creation
2024-01-03 16:30:06 -06:00
Robert Sparks bbc64d30fd
fix: count RFCs correctly for doc/ad (#6833)
* fix: count RFCs correctly for doc/ad

* chore: improve query legibility
2024-01-03 10:37:44 -06:00
Paul Selkirk 748bcc328f
fix: Wrap weasyprint to catch exceptions (#6728)
* fix: Wrap weasyprint to catch exceptions (#6324)

* test: Restore socket function after test

* test: Use mock instead of monkeying with sockets

* refactor: Log the error

* fix: Don't catch non-Exception interruptions

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-12-27 11:56:38 -06:00
Paul Selkirk 288b69d0f3
fix: Allow reassignment of withdrawn review assignment (#6723) (#6850) 2023-12-27 11:09:45 -06:00
Paul Selkirk 1450ecde99
fix: Retain date of cancelled virtual interim meeting (#6708) (#6852) 2023-12-27 10:39:13 -06:00
Robert Sparks 2c11b544f1
fix: show state help for the editorial stream (#6836) 2023-12-26 08:53:52 -06:00
Robert Sparks c328ff7425
fix: improve idnits2_state document creation time calculations (#6832)
* fix: improve idnits2_state document creation time calculations

* chore: apply black to the idnits2_state function
2023-12-21 17:52:55 -06:00
Paul Selkirk 359a107fc5
fix: Include RFCs when searching on a draft name (#6787) (#6827) 2023-12-21 17:27:32 -06:00
Robert Sparks bc74977fcc
fix: 404 requests for bibtex for none draft or rfc documents (#6834)
* fix: 404 requests for bibtex for none draft or rfc documents

* test: test rejecting the types with factories already being imported
2023-12-21 16:27:48 -06:00
Paul Selkirk c1e40ff100
feat: Allow entering agenda text directly (#6792)
* feat: Allow entering agenda text directly (#6532)

* fix: Hide label as well as file/text input box

* refactor: Package javascript for static/dist

* fix: Fix test cases broken by view changes

* test: Add test case for entering agenda text

* refactor: assertRedirects
2023-12-20 16:40:13 -06:00
Lars Eggert db8fba486b
fix: Deduplicate referenced_by (#6820)
Fixes #6808
2023-12-20 16:36:55 -06:00
Robert Sparks ca664c4162
fix: don't create a volunteer object when a person has already volunt… (#6809)
* fix: don't create a volunteer object when a person has already volunteered

* fix: safer create

* refactor: use shorthand from django

* fix: also protect volunteer from datatracker from race
2023-12-18 16:49:27 -06:00
Jennifer Richards 7d447802d2
fix: no dups on stream documents view (#6804) 2023-12-18 10:45:51 -06:00
Jennifer Richards 149f82f578
fix: Include refs to pre-RFC drafts as refs to the RFC (#6784)
* fix: clean up shadowed name in document_referenced_by.html

* fix: include refs to rfc's came_from_draft()

* fix: include refs to draft's became_rfc()

* fix: Count indirect refs by RFCs

* refactor: break indirect ref_by counting to its own fn

* fix: only count refs to pre-rfc draft, not post-draft rfc

(and rename a method)

* test: test referenced_by_rfcs methods

The test_referenced_by_rfcs_as_rfc_or_draft() test
fails because there's a bug!

* test: actually, do double-count refs to rfc/draft

Let's do include refs to an rfc and its precursor draft
as separate refs. This almost surely indicates a data
error because it would mean an rfc referenced both an
rfc and the draft that it came from. That should never
be allowed, so at least let some light fall on it if
it happens.

* chore: Add docstring to document_referenced_by view
2023-12-18 09:11:53 -06:00
Lars Eggert f5bd078351
fix: AD queue graphs and AD doc list sorting (#6752)
* Fix AD queue graphs and AD doc list sorting.

Fixes #6700
Fixes #6720

* Fix the issue @rdanyliw found. Hopefully.

* More fixes

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-12-14 15:05:00 -06:00
Robert Sparks 4216c129fe
fix: change verbosity of api key purge mgmt command (#6758)
* fix: change verbosity of api key purge mgmt command

* test: adjust mgmt command test arguments
2023-12-14 15:04:27 -06:00
Paul Selkirk cfaf84f08f
refactor: Convert custom form template to bootstrap (#6763)
* refactor: Convert custom form template to bootstrap

* refactor: Match form fields to old version
2023-12-14 14:19:22 -06:00
Ryan Cross e9d44d41f0
feat: Capture volunteers from the registration system (#6605)
* feat: Capture volunteers from the registration system. Fixes #5938

* fix: allow withdrawn field to be null

* docs: add explanatory code comments

* fix: identify current nomcom by is_accepting_volunteers

* fix: use auto_now_add instead of auto_now

* fix: update migration

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-12-14 13:46:27 -06:00
Robert Sparks 501a5b8e58
fix: consider subseries when calculating downref (#6777) 2023-12-14 09:35:30 -06:00
Jennifer Richards 6083205cc8
fix: Update group dependencies for new rfc model (#6773)
* fix: Avoid accessing slug when state is None

* fix: ignore pre-rfc drafts as rfc-to-rfc references

* fix: also ignore pre-rfc to pre-rfc refs

* chore: remove breakpoint

* fix: ignore subseries non-downrefs

* fix: label nodes as RFCS when possible

* fix: get "rfc" flag right

* chore: Remove comment, answer seems to be "no"

* refactor: Specify state type; drop redundant source doc type check

We're only admitting source__type="draft", so
no need to check it again in filter queries

* refactor: Specify state type in old code
2023-12-14 09:29:55 -06:00
Robert Sparks 6ccf9080b4
Merge pull request #6776 from rjsparks/statsfixes
fix: gather interesting years for stats accounting for published rfcs
2023-12-13 15:22:58 -06:00
Robert Sparks e130a301de
fix: gather interesting years for stats accounting for published rfcs 2023-12-13 13:14:38 -06:00
Robert Sparks d74d5ed233
fix: ignore attempts to look for versions of rfcs, but find the rfc. 2023-12-13 11:54:22 -06:00
Robert Sparks e211dc57d4
feat!: RFCs and subseries as Document types 2023-12-11 09:36:21 -06:00