Commit graph

15773 commits

Author SHA1 Message Date
Jennifer Richards a66457bfaf
test: Remove python lint 2023-08-10 18:01:11 -03:00
Jennifer Richards 92ad44e70c
test: Test more fields on the rfc doc 2023-08-10 17:53:35 -03:00
Jennifer Richards ab99972d76
fix: Check state correctly 2023-08-10 17:44:37 -03:00
Jennifer Richards 8b636216d0
feat: describe change as "set" or "changed" as appropriate 2023-08-10 17:35:12 -03:00
Jennifer Richards 39ccea92f9
feat: Set published state on rfc doc 2023-08-10 17:01:06 -03:00
Jennifer Richards 7535df3eeb
feat: Set more fields on rfc doc 2023-08-10 17:00:08 -03:00
Jennifer Richards fd1d425db6
feat: Log warning if rfc index refers to unknown draft 2023-08-10 16:12:01 -03:00
Jennifer Richards e898e43bc8
fix: Only consider rfcs for updates/obsoletes targets 2023-08-10 16:09:53 -03:00
Jennifer Richards 112ac906dc
test: Confirm changes are returned for draft and rfc 2023-08-10 16:01:34 -03:00
Jennifer Richards 4437796bc3
test: Update test_rfc_index() 2023-08-10 15:43:10 -03:00
Jennifer Richards 542b87209d
chore: Eliminate python lint 2023-08-10 14:59:55 -03:00
Jennifer Richards eaf8d459ec
fix: Only match draft docs to rfc index draft name 2023-08-10 14:58:32 -03:00
Jennifer Richards c37e3b4a39
refactor: Consolidate draft handling 2023-08-10 14:29:02 -03:00
Jennifer Richards 4f9a2316ef
style: Run Black and use f-strings / str.format() 2023-08-10 14:10:49 -03:00
Robert Sparks 9f4b3d80b9
ci: merge main to release 2023-08-10 12:10:47 -05:00
Robert Sparks 3e51287052
ci: merge release to main
ci: merge release to main
2023-08-10 12:09:47 -05:00
Robert Sparks 0faac4aafc
fix: address hard html validation complaint (#6121) 2023-08-10 11:10:42 -05:00
Robert Sparks 9ccd43f7a3
ci: merge feat/dark-mode to main
feat: dark mode
2023-08-10 09:57:07 -05:00
Robert Sparks 7773e9ab98
Merge branch 'main' into feat/dark-mode 2023-08-10 09:53:35 -05:00
Lars Eggert 57f23f5198
chore: feat/dark-mode <- main (#6103)
* chore: Remove unused "rendertest" stuff (#6015)

* fix: restore ability to create status change documents (#5963)

* fix: restore ability to create status change documents

Fixes #5962

* chore: address review comment

* fix: Provide human-friendly status in submission status API response (#6011)

Co-authored-by: nectostr <bastinda96@gmail.com>

* fix: Make name/email lookups case-insensitive (#5972) (#6007)

* fix: Make name/email lookups case-insensitive (#5972)

Use icontains so that looking up name or email is case insensitive
Added a test

Fixes: 5972

* fix: Use __iexact not __icontains

* fix: Clarify no-action-needed (#5918) (#6020)

When a draft is submitted for manual processing, clarify that
no action is needed; the Secretariat has the next steps.

Fixes: #5918

* fix: Fix menu hover issue (#6019)

* fix: Fix menu hover issue

Fixes #5702

* Fix leftmenu hover issue

* fix: Server error from api_get_session_materials() (#6025)

Fixes #5877

* fix: Clarify Questionnaire label (#4688) (#6017)

When filtering nominees, `Questionnaire` implies `Accepted == yes`
so fix the dropdown test tosay that.

Fixes: #4688

* chore: Merge from @martinthomson's rfc-txt-html (#6023)

* fix:no history entry when changing RFC Editor note for doc (#6021)

* fix:no history entry when changing RFC Editor note for doc

* fix:no history entry when changing RFC Editor note for doc

---------

Co-authored-by: Priyanka Narkar <priyankanarkar@dhcp-91f8.meeting.ietf.org>

* fix: avoid deprecation warning on view_list() for objs without CommunityList

Fixes #5942

* fix: return 404 for non-existing revisions (#6014)

* fix: return 404 for non-existing revisions
Links to non-existing revisions to docs should return 404

* fix: change rfc/rev and search behaviour

* refactor: fix tab level

* fix: return 404 for rfc revision for bibtex

* fix: provide date for revisions in bibtex output (#6029)

* fix: provide date for revisions in bibtex output

* refactor: change walrus to if's

* fix: specify particular revision for events

* fix: review refactoring issue

fixes #5447

* fix:  Remove automatically suggested document for document that is already has review request (fixes #3211) (#5425)

* Added check that if there is already review request for the document
in question, ignore the automatic suggestion for that document.
Fixes #3211.

* fix: dont block on open requests for a previous version. Add tests

---------

Co-authored-by: Nicolas Giard <github@ngpixel.com>
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* feat: IAB statements (#5940)

* feat: support iab and iesg statements. Import iab statements. (#5895)

* feat: infrastructure for statements doctype

* chore: basic test framework

* feat: basic statement document view

* feat: show replaced statements

* chore: black

* fix: state help for statements

* fix: cleanout non-relevant email expansions

* feat: import iab statements, provide group statements tab

* fix: guard against running import twice

* feat: build redirect csv for iab statements

* fix: set document state on import

* feat: show published date on main doc view

* feat: handle pdf statements

* feat: create new and update statements

* chore: copyright block updates

* chore: remove flakes

* chore: black

* feat: add edit/new buttons for the secretariat

* fix: address PR #5895 review comments

* fix: pin pydantic until inflect catches up (#5901) (#5902)

* chore: re-un-pin pydantic

* feat: include submitter in email about submitted slides (#6033)

* feat: include submitter in email about submitted slides

fixes #6031

* chore: remove unintended whitespace change

* chore(dev): update .vscode/settings.json with new taskExplorer settings

* fix: Add editorial stream to proceedings (#6027)

* fix: Add editorial stream to proceedings

Fixes #5717

* fix: Move editorial stream after the irtf in proceedings

* fix: Add editorial stream to meeting materials (#6047)

Fixes #6042

* fix: Shows requested reviews for doc fixes (#6022)

* Fix: Shows requested reviews for doc

* Changed template includes to only give required variables to them.

* feat: allow openId to choose an unactive email if there are none active (#6041)

* feat: allow openId to choose an unactive email if there are no active ones

* chore: correct typo

* chore: rename unactive to inactive

* fix: Make review table more responsive (#6053)

* fix: Improve layout of review table

* Progress

* Progress

* Final changes

* Fix tests

* Remove fluff

* Undo commits

* ci: add --validate-html-harder to tests

* ci: add  --validate-html-harder to build.yml workflow

* fix: Set colspan to actual number of columns (#6069)

* fix: Clean up view_feedback_pending (#6070)

- Remove "Unclassified" column header, which caused misalignment in the table body.

- Show the message author - previously displayed as `(None)`.

* docs: Update LICENSE year

* fix: Remove IESG state edit button when state is 'dead' (#6051) (#6065)

* fix: Correctly order "last call requested" column in the IESG dashboard (#6079)

* ci: update dev sandbox init script to start memcached

* feat: Reclassify nomcom feedback (#6002)

* fix: Clean up view_feedback_pending

- Remove "Unclassified" column header, which caused misalignment in the table body.

- Show the message author - previously displayed as `(None)`.

* feat: Reclassify nomcom feedback (#4669)

- There's a new `Chair/Advisor Tasks` menu item `Reclassify feedback`.

- I overloaded `view_feedback*` URLs with a `?reclassify` parameter.

- This adds a checkbox to each feedback message, and a `Reclassify` button
at the bottom of each feedback page.

- "Reclassifying" basically de-classifies the feedback, and punts it back
to the "Pending emails" view for reclassification.

- If a feedback has been applied to multiple nominees, declassifying it
from one nominee removes it from all.

* fix: Remove unused local variables

* fix: Fix some missing and mis-nested html

* test: Add tests for reclassifying feedback

* refactor: Substantial redesign of feedback reclassification

- Break out reclassify_feedback* as their own URLs and views,
  and revert changes to view_feedback*.html.

- Replace checkboxes with a Reclassify button on each message.

* fix: Remember to clear the feedback associations when reclassifying

* feat: Add an 'Overcome by events' feedback type

* refactor: When invoking reclassification from a view-feedback page, load the corresponding reclassify-feedback page

* fix: De-conflict migration with 0004_statements

Also change the coding style to match, and add a reverse migration.

* fix: Fix a test case to account for new feedback type

* fix: 842e730 broke the Back button

* refactor: Reclassify feedback directly instead of putting it back in the work queue

* fix: Adjust tests to new workflow

* refactor: Further refine reclassification to avoid redirects

* refactor: Impose a FeedbackTypeName ordering

Also add FeedbackTypeName.legend field, rather than synthesizing it every
time we classify or reclassify feedback.

In the reclassification forms, only show the relevant feedback types.

* refactor: Merge reclassify_feedback_* back into view_feedback_*

This means the "Reclassify" button is always present, but eliminates some
complexity.

* refactor: Add filter(used=True) on FeedbackTypeName querysets

* refactor: Add the new FeedbackTypeName to the reclassification success message

* fix: Secure reclassification against rogue nomcom members

* fix: Print decoded key and fully clean up test nomcom (#6094)

* fix: Delete Person records when deleting a test nomcom

* fix: Decode test nomcom private key before printing

* test: Use correct time zone for test_statement_doc_view (#6064)

* chore(deps): update all npm dependencies for playwright (#6061)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* chore(deps): update all npm dependencies for dev/diff (#6062)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* chore(deps): update all npm dependencies for dev/coverage-action (#6063)

Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>

* fix: Hash cache key for default memcached cache (#6089)

* feat: Show docs that an AD hasn't balloted on that need ballots to progress (#6075)

* fix(doc): Unify help texts for document states (#6060)

* Fix IESG State help text link (only)

* Intermediate checkpoint

* Correct URL filtering of state descriptions

* Unify help texts for document states

* Remove redundant load static from template

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* ci: fix sandbox start.sh memcached user

* fix: refactor how settings handles cache definitions (#6099)

* fix: refactor how settings handles cache definitions

* chore: more english-speaker readable expression

* fix: Cast cache key to str before calling encode (#6100)

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
Co-authored-by: Liubov Kurafeeva <liubov.kurafeeva@gmail.com>
Co-authored-by: nectostr <bastinda96@gmail.com>
Co-authored-by: Rich Salz <rsalz@akamai.com>
Co-authored-by: PriyankaN <priyanka@amsl.com>
Co-authored-by: Priyanka Narkar <priyankanarkar@dhcp-91f8.meeting.ietf.org>
Co-authored-by: Ali <alireza83@gmail.com>
Co-authored-by: Roman Beltiukov <maybe.hello.world@gmail.com>
Co-authored-by: Tero Kivinen <kivinen@iki.fi>
Co-authored-by: Nicolas Giard <github@ngpixel.com>
Co-authored-by: Kesara Rathnayake <kesara@fq.nz>
Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
Co-authored-by: Paul Selkirk <paul@painless-security.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Jim Fenton <fenton@bluepopcorn.net>
2023-08-10 09:49:15 -05:00
Lars Eggert d0f9738e2a
fix: Increase menu bar contrast (#6115)
Fixes #6112, #6113
2023-08-10 09:07:18 -05:00
Jennifer Richards 87bd9bbd6d
feat: Use rfc doc type when updating from rfc index 2023-08-10 10:36:49 -03:00
Robert Sparks ddf229c51d
ci: merge main to release 2023-08-09 10:31:40 -05:00
Robert Sparks 4bffde1bf9
ci: merge release to main 2023-08-09 10:30:43 -05:00
Jennifer Richards f464f3172d
chore: Add type annotation to complex return value 2023-08-09 11:42:36 -03:00
Jennifer Richards 1df5450790
style: Run Black on update_docs_from_rfc_index() 2023-08-09 11:40:00 -03:00
Jennifer Richards 82d91d371a
fix: Cast cache key to str before calling encode (#6100) 2023-08-08 17:38:59 -05:00
Robert Sparks baa5127d25
fix: refactor how settings handles cache definitions (#6099)
* fix: refactor how settings handles cache definitions

* chore: more english-speaker readable expression
2023-08-08 17:31:59 -05:00
Robert Sparks 5955154223
ci: merge main to release 2023-08-08 15:09:31 -05:00
Nicolas Giard 5de4c0b45b
ci: fix sandbox start.sh memcached user 2023-08-08 16:08:11 -04:00
Robert Sparks 91f6b9a16c
ci: merge release to main 2023-08-08 15:07:30 -05:00
Jim Fenton 71ccba6215
fix(doc): Unify help texts for document states (#6060)
* Fix IESG State help text link (only)

* Intermediate checkpoint

* Correct URL filtering of state descriptions

* Unify help texts for document states

* Remove redundant load static from template

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-08-08 13:39:25 -05:00
Lars Eggert aa6136deae
feat: Show docs that an AD hasn't balloted on that need ballots to progress (#6075) 2023-08-08 13:37:36 -05:00
Jennifer Richards 7e852aebfc
fix: Hash cache key for default memcached cache (#6089) 2023-08-08 13:21:19 -05:00
depfu[bot] 4653906eec
chore(deps): update all npm dependencies for dev/coverage-action (#6063)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-08-08 13:08:02 -05:00
depfu[bot] d28eabef0d
chore(deps): update all npm dependencies for dev/diff (#6062)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-08-08 13:07:45 -05:00
depfu[bot] 3a17abe32a
chore(deps): update all npm dependencies for playwright (#6061)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-08-08 13:07:17 -05:00
Jennifer Richards d87e504c4d
test: Use correct time zone for test_statement_doc_view (#6064) 2023-08-08 13:05:39 -05:00
Jennifer Richards b574a6e17a
fix: Print decoded key and fully clean up test nomcom (#6094)
* fix: Delete Person records when deleting a test nomcom

* fix: Decode test nomcom private key before printing
2023-08-08 12:34:27 -05:00
Paul Selkirk 06c9f06d55
feat: Reclassify nomcom feedback (#6002)
* fix: Clean up view_feedback_pending

- Remove "Unclassified" column header, which caused misalignment in the table body.

- Show the message author - previously displayed as `(None)`.

* feat: Reclassify nomcom feedback (#4669)

- There's a new `Chair/Advisor Tasks` menu item `Reclassify feedback`.

- I overloaded `view_feedback*` URLs with a `?reclassify` parameter.

- This adds a checkbox to each feedback message, and a `Reclassify` button
at the bottom of each feedback page.

- "Reclassifying" basically de-classifies the feedback, and punts it back
to the "Pending emails" view for reclassification.

- If a feedback has been applied to multiple nominees, declassifying it
from one nominee removes it from all.

* fix: Remove unused local variables

* fix: Fix some missing and mis-nested html

* test: Add tests for reclassifying feedback

* refactor: Substantial redesign of feedback reclassification

- Break out reclassify_feedback* as their own URLs and views,
  and revert changes to view_feedback*.html.

- Replace checkboxes with a Reclassify button on each message.

* fix: Remember to clear the feedback associations when reclassifying

* feat: Add an 'Overcome by events' feedback type

* refactor: When invoking reclassification from a view-feedback page, load the corresponding reclassify-feedback page

* fix: De-conflict migration with 0004_statements

Also change the coding style to match, and add a reverse migration.

* fix: Fix a test case to account for new feedback type

* fix: 842e730 broke the Back button

* refactor: Reclassify feedback directly instead of putting it back in the work queue

* fix: Adjust tests to new workflow

* refactor: Further refine reclassification to avoid redirects

* refactor: Impose a FeedbackTypeName ordering

Also add FeedbackTypeName.legend field, rather than synthesizing it every
time we classify or reclassify feedback.

In the reclassification forms, only show the relevant feedback types.

* refactor: Merge reclassify_feedback_* back into view_feedback_*

This means the "Reclassify" button is always present, but eliminates some
complexity.

* refactor: Add filter(used=True) on FeedbackTypeName querysets

* refactor: Add the new FeedbackTypeName to the reclassification success message

* fix: Secure reclassification against rogue nomcom members
2023-08-08 12:33:17 -05:00
Jennifer Richards a867de25b0
test: Remove setup that does not apply to rfc docs (#6082)
* test: Remove setup that does not apply to rfc docs

* style: Run black on test_document_bibtex()
2023-08-08 13:34:11 -03:00
Jennifer Richards a0f6201fc4
Merge pull request #6083 from jennifer-richards/fix-statement-test
test: RelatedDocument target is now Document
2023-08-08 13:33:25 -03:00
Nicolas Giard b327a27736
ci: update dev sandbox init script to start memcached 2023-08-08 11:44:05 -04:00
Lars Eggert 399b7b9994
fix: Correctly order "last call requested" column in the IESG dashboard (#6079) 2023-08-07 16:53:19 -05:00
Paul Selkirk 638f7ea598
fix: Remove IESG state edit button when state is 'dead' (#6051) (#6065) 2023-08-07 15:14:56 -05:00
Jennifer Richards 015d64bef3
test: RelatedDocument target is now Document 2023-08-04 20:55:40 -03:00
Jennifer Richards 91f8ed7d24
Merge pull request #6078 from ietf-tools/main-merge-feat-rfc
chore: Merge main into feat/rfc
2023-08-04 02:16:46 -03:00
Jennifer Richards 2d46a978e0
chore: Renumber migrations 2023-08-04 00:42:16 -03:00
Jennifer Richards 48d4072eeb
Merge branch 'feat/rfc' into main-merge
# Conflicts:
#	ietf/doc/factories.py
#	ietf/doc/tests_status_change.py
#	ietf/name/fixtures/names.json
#	ietf/templates/doc/document_info.html
2023-08-03 18:34:06 -03:00
Nicolas Giard 59c1db196a
docs: Update LICENSE year 2023-08-02 03:47:17 -04:00