altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
15773 commits 1 branch 0 tags 2.6 GiB
Commit graph

12362 commits

Author SHA1 Message Date
Roman Beltiukov 001719b3b5
fix: provide date for revisions in bibtex output (#6029) 
* fix: provide date for revisions in bibtex output

* refactor: change walrus to if's

* fix: specify particular revision for events
 2023-07-23 09:21:16 -07:00
Roman Beltiukov 4d611706d4
fix: return 404 for non-existing revisions (#6014) 
* fix: return 404 for non-existing revisions
Links to non-existing revisions to docs should return 404

* fix: change rfc/rev and search behaviour

* refactor: fix tab level

* fix: return 404 for rfc revision for bibtex
 2023-07-23 09:16:12 -07:00
Ali e61f779816
fix: avoid deprecation warning on view_list() for objs without CommunityList 
Fixes #5942
 2023-07-23 09:12:13 -07:00
PriyankaN 00c0389c1f
fix:no history entry when changing RFC Editor note for doc (#6021) 
* fix:no history entry when changing RFC Editor note for doc

* fix:no history entry when changing RFC Editor note for doc

---------

Co-authored-by: Priyanka Narkar <priyankanarkar@dhcp-91f8.meeting.ietf.org>
 2023-07-22 17:33:11 -07:00
Lars Eggert 36a7c5c647
chore: Merge from @martinthomson's rfc-txt-html (#6023) 2023-07-22 16:53:10 -07:00
Rich Salz ebad9489b8
fix: Clarify Questionnaire label (#4688) (#6017) 
When filtering nominees, `Questionnaire` implies `Accepted == yes`
so fix the dropdown test tosay that.

Fixes: #4688
 2023-07-22 16:40:24 -07:00
Liubov Kurafeeva 3a499cd068
fix: Server error from api_get_session_materials() (#6025) 
Fixes #5877
 2023-07-22 16:36:35 -07:00
Jennifer Richards 2b0f95477e
test: Remove unused import 2023-07-22 15:45:25 -07:00
Lars Eggert c717673060
fix: Fix menu hover issue (#6019) 
* fix: Fix menu hover issue

Fixes #5702

* Fix leftmenu hover issue
 2023-07-22 15:38:20 -07:00
Rich Salz 8a8821072f
fix: Clarify no-action-needed (#5918) (#6020) 
When a draft is submitted for manual processing, clarify that
no action is needed; the Secretariat has the next steps.

Fixes: #5918
 2023-07-22 15:37:34 -07:00
Jennifer Richards eef6a22601
Merge branch 'feat/rfc' into rfc-community-lists 
# Conflicts:
#	ietf/templates/doc/search/search_result_row.html
 2023-07-22 14:28:05 -07:00
Jennifer Richards 423514467d
fix: Track RFC documents that came from tracked drafts 2023-07-22 14:23:44 -07:00
Jennifer Richards 938f862cc2
refactor: Prevent undefined variable reference 2023-07-22 14:11:57 -07:00
Jennifer Richards 4e670692f8
refactor: Clear rule.state when migrating *_rfc rules 2023-07-22 13:29:43 -07:00
Rich Salz 9aea2a2e8b
fix: Make name/email lookups case-insensitive (#5972) (#6007) 
* fix: Make name/email lookups case-insensitive (#5972)

Use icontains so that looking up name or email is case insensitive
Added a test

Fixes: 5972

* fix: Use __iexact not __icontains
 2023-07-22 13:16:42 -07:00
Lars Eggert 97c7dd4d67
fix: Use correct logo in dark mode menubar (#6016) 
Also use the "nor" variant elsewhere the logo is small.
 2023-07-22 12:56:06 -07:00
Liubov Kurafeeva 91297f18e6
fix: Provide human-friendly status in submission status API response (#6011) 
Co-authored-by: nectostr <bastinda96@gmail.com>
 2023-07-22 12:43:08 -07:00
Robert Sparks f82988d8b7
fix: restore ability to create status change documents (#5963) 
* fix: restore ability to create status change documents

Fixes #5962

* chore: address review comment
 2023-07-22 12:40:38 -07:00
Lars Eggert 5f8fca68f4
chore: Remove unused "rendertest" stuff (#6015) 2023-07-22 12:36:07 -07:00
Jennifer Richards 8f73849343
refactor: Remove "state" field entirely for rfc rules 2023-07-22 11:51:27 -07:00
Robert Sparks 4ec22dae19
Merge branch 'main' into feat/dark-mode 2023-07-22 13:49:24 -05:00
Jennifer Richards a6d5cb69d4
refactor: Use empty rule.states for _rfc rules 2023-07-22 11:39:34 -07:00
Jennifer Richards 2f94383fca
refactor: Find SearchRules using rfc doc type 2023-07-22 11:29:18 -07:00
Jennifer Richards 0959a2e82e
refactor: Filter SearchRule matching using rfc doc type 2023-07-22 11:13:51 -07:00
Lars Eggert 8e439df7c5
fix: HTML-escape person name in tests (#5986) 
* fix: Add `mark_safe` to `person_link` to prevent HTML escaping

Fixes part of #5834, namely https://github.com/ietf-tools/datatracker/issues/5834#issuecomment-1627454562

* fix: Fix tests instead of marking name safe
 2023-07-21 15:52:19 -07:00
Jennifer Richards 1660a14331
test: Use (rfc, published) state in test 2023-07-21 13:33:33 -03:00
Lars Eggert 3a47871f5e
fix: More dark mode fixes (#6001) 
* fix: More small dark mode fixes

* "badge rounded-pill bg-" -> "badge rounded-pill text-bg-"

This sets the text color correctly for more readable badges.

* Same for cards

* Fix tests
 2023-07-20 13:48:52 -05:00
Robert Sparks 2593c0396b
chore: style fixes 2023-07-20 13:40:09 -05:00
Robert Sparks 189c32194d
test: construct the right kind of document for the rfc-index tests 2023-07-20 13:25:12 -05:00
Robert Sparks 51c22d8e6c
fix: repairs reflecting removal of DocAlias from the RelatedDocument models 2023-07-20 13:03:58 -05:00
Robert Sparks 1ad19e0256
Merge branch 'feat/rfc' into related_no_alias 2023-07-20 09:43:05 -05:00
Robert Sparks ac4ee27387
fix: track style changes in main 2023-07-20 09:41:23 -05:00
Robert Sparks d6186af2cc
Merge branch 'main' into feat/rfc 2023-07-20 09:35:58 -05:00
Robert Sparks c8684f727a
Merge branch 'main' into related_no_alias 2023-07-20 09:31:52 -05:00
Robert Sparks 81734443a5
fix: continued repair of code/tests re: RelatedDocument model change 2023-07-20 09:25:14 -05:00
Robert Sparks f52d0ddcf8
test: verify newsubmissiondocevent count by day is correct (#6000) 2023-07-20 08:53:23 -05:00
Jennifer Richards ba356397c0
fix: Specify UTC for TruncDate (#5996) 2023-07-20 08:29:30 -05:00
Nicolas Giard 05644a16ff
feat: agenda / floor-plan dark mode support (#5995) 2023-07-19 18:23:37 -05:00
Robert Sparks 59c0a1f7f9
chore: repair merge damage 2023-07-19 18:09:23 -05:00
Robert Sparks cf3a270cd2
Merge branch 'feat/rfc' into related_no_alias 2023-07-19 17:48:22 -05:00
Robert Sparks a20d1f4d9b
Merge remote-tracking branch 'ietf-tools/main' into feat/dark-mode 2023-07-19 12:18:07 -05:00
Lars Eggert d8c0ae5faf
fix: Add numeric localhost addresses to CSRF_TRUSTED_ORIGINS (#5989) 2023-07-19 09:55:22 -05:00
Lars Eggert 9d5d9d5172
fix: replace deprecated bootstrap things (#5858) 
* text-muted -> text-body-secondary

* navbar-dark is deprecated

* Remove FIXME block, not an issue anymore

* Remove `navbar-light`
 2023-07-18 12:22:28 -05:00
Paul Selkirk 3f228c788d
feat: Add totals to nominee feedback page (#5977) 
* feat: Add totals to nominee feedback page (#4727)

* test: Add a unit test for feedback totals

Also remember to wrap the totals in a <tr> tag.
 2023-07-18 09:17:06 -05:00
Lars Eggert bd9d3285b5
fix: #timeline -> #doc-timeline (#5985) 
Fixes #5923
 2023-07-18 09:01:43 -05:00
Lars Eggert 57843d8538
fix: Import fix from 7a946424c1 (#5984) 2023-07-18 08:58:22 -05:00
Paul Selkirk 0693a4357d
feat: Add "generate email" to action on nominees page (#4893) (#5959) 
* feat: Add "generate email" to action on nominees page (#4893)

* fix: Use bare email address for now
 2023-07-17 16:00:16 -05:00
Jennifer Richards 9bf0063f11
fix: Preserve Document.time when migrating rfcs (#5954) 2023-07-12 11:02:12 -05:00
Robert Sparks 3fe1fcf122
fix: send the whole txt submission to te DraftParser (#5956) 2023-07-12 08:58:08 -05:00
Jennifer Richards 7d5b1767f5
fix: Fix display of RFCs in search_result_row.html 
n.b., dropped the "(was draft...)" suffix for now - need to revive
that or commit to removing it.
 2023-07-11 16:35:25 -03:00
Jennifer Richards e42ac40ec4
fix: Use (rfc, published) state for RFC SearchRules 2023-07-11 16:16:05 -03:00
Jennifer Richards 5385760f2a
chore: Migrate SearchRules for the rfc state 2023-07-11 16:14:49 -03:00
Jennifer Richards 71270621b7
chore: Track RFCs if they were tracked as a draft 2023-07-11 11:59:39 -03:00
Robert Sparks 6305555480
chore: address pyflake issues 2023-07-10 14:41:45 -05:00
Robert Sparks b2ebad11d5
fix: repaired rfcdiff api endpoint 2023-07-10 12:56:06 -05:00
Robert Sparks 35ba49f5cc
test: cleanup use of factory 2023-07-08 13:20:17 -05:00
Robert Sparks 63c809a20b
test: adjust secr tests 2023-07-08 12:42:21 -05:00
Robert Sparks 16b1583e33
test: adjust iesg tests 2023-07-08 09:58:45 -05:00
Robert Sparks b8febcb7a3
test: adjusted fuzzy_find_document_rfc test 2023-07-08 09:42:52 -05:00
Robert Sparks 0b9d450a3e
test: adjust status change test to reflect rfc target 2023-07-07 17:55:50 -05:00
Robert Sparks c980649c32
chore: remove unintended commit of temporary skip 2023-07-07 17:49:55 -05:00
Robert Sparks f0a32edec6
chore: note odd placement of code 2023-07-07 17:48:21 -05:00
Robert Sparks d4f5bc6707
fix: make factory name derivation better. Adjust status_change test 2023-07-07 17:48:00 -05:00
Robert Sparks 2c6fe0383c
fix: adjust gating of review requests 2023-07-07 17:31:24 -05:00
Robert Sparks ffb11fd0c1
fix: downref form validation 2023-07-07 17:15:39 -05:00
Robert Sparks 09f0710e77
test: correct use of factories for downref tests 2023-07-07 17:02:16 -05:00
Robert Sparks 632293d369
fix: repaired RelatedDocument is_downref and is_approved_downref methods 2023-07-07 16:14:18 -05:00
Robert Sparks bbef89140e
fix: removed notion of submitting RFCs from find_submission_filenames 2023-07-07 15:41:38 -05:00
Jennifer Richards 8267f4b452
test: Fix typo in names.json (#5939) 2023-07-07 15:10:47 -05:00
Robert Sparks 457b95094a
fix: improvements to submit form validation 2023-07-07 15:08:41 -05:00
Robert Sparks ff058e3c63
test: repair draft_group_link test 2023-07-07 14:03:16 -05:00
Robert Sparks d3f1794fd4
chore: apply black to GenerateDraftAliasesTests 2023-07-07 13:53:37 -05:00
Robert Sparks 78b6f06519
fix: repair generate_draft_aliases 2023-07-07 13:47:50 -05:00
Robert Sparks 11ec3685c4
fix: repaired idnits2_state 2023-07-07 13:10:52 -05:00
Robert Sparks e6a1a17973
fix: typo/logic error in get_base_name 2023-07-07 12:56:23 -05:00
Robert Sparks f30613973c
test: repair pdfized tests 2023-07-07 12:32:48 -05:00
Robert Sparks 06e711288a
test: adjusted RawIdTests 2023-07-07 11:31:11 -05:00
Robert Sparks 8b1fcfdbdd
fix: repair views_search.index_all_drafts 2023-07-07 11:22:44 -05:00
Robert Sparks 6eeffb116f
fix: become agnostic about RFC states until we care 2023-07-07 10:33:29 -05:00
Robert Sparks f7d9e49731
test: pass a correct type 2023-07-07 10:30:57 -05:00
Jennifer Richards 117e07e5ff
Merge pull request #5935 from rjsparks/fixups3 
fix: repair various doc view and tests
 2023-07-07 11:47:13 -03:00
Robert Sparks 285b11a053
fix: better use of factory 2023-07-07 09:32:29 -05:00
Paul Selkirk bae204862d
feat: Add bibxml button to document info page (#5921) 
* feat: Add bibxml button to document info page (#5908)

* fix: No bibxml for RFCs
 2023-07-07 08:23:15 -05:00
Robert Sparks a3c87a1945
fix: repaired rfc_feed 2023-07-06 17:43:40 -05:00
Robert Sparks 3486f38421
fix: adjust (useless) assertion in status_change test to reflect that the relevant relation points to an RFC 2023-07-06 17:31:11 -05:00
Robert Sparks 799d3a1a3e
fix: adjusted bibtex view and tests 2023-07-06 17:24:05 -05:00
Robert Sparks 400280e50c
fix: repair test_history_bis_00 2023-07-06 16:05:10 -05:00
Jennifer Richards fc284be6d8
fix: Deal with rfc doc types for references/referenced_by views 2023-07-06 17:44:32 -03:00
Jennifer Richards 9f1b05a518
chore: Move/copy RelatedDocuments to rfcs 2023-07-06 17:44:28 -03:00
Jennifer Richards 563b5a9fe2
chore: Migrate RelatedDocuments for RFCs 2023-07-06 17:44:24 -03:00
Robert Sparks f53a849660
fix: various corrections to rfc main document view and tests (#5931) 2023-07-06 17:24:35 -03:00
Robert Sparks 63a9920685
fix: restored where an rfc came from to the main rfc view (#5930) 2023-07-06 15:11:26 -03:00
Jennifer Richards 8f0b459050
refactor: Replace is_rfc() tests (#5925) 
* refactor: Remove is_rfc() - test type_id instead

* fix: Guard against unknown pub_date

This should not ever come up - we have a published_rfc event for
every rfc. Should investigate fixing pub_date() to always return a val.
 2023-07-06 12:07:53 -03:00
Jennifer Richards 5d9d87897d
fix: Show rfc documents via document_main view (#5919) 
* fix: Fix friendly_state() for drafts in rfc state

* refactor: Change became-rfc to became_rfc for consistency

* refactor: Begin handling RFCs separatly in document_main

WIP

* chore: Hide reviews and conflict reviews for RFCs

* chore: Remove irrelevant fields from rfc doc view

* chore: Remove unused variables

* chore: Remove "Versions" field from document_rfc.html

* chore: Hide "Nits" button for RFC documents
 2023-07-05 17:30:20 -03:00
Jennifer Richards 09f347727b
chore: Remove temporary pin on pydantic (#5911) 
* chore: Remove temporary pin on pydantic

* test: Guarantee ordering of sessions in test

Should fix an intermittent test failure.
 2023-07-05 08:50:50 -05:00
Jennifer Richards 60dc60234d
fix: Better match xml2rfc date parsing (#5914) 
* refactor: Split up get_creation_date to ease testing

* test: Add tests of parse_creation_date()

Note change in expected output when date_elt is None:
instead of returning None, this expects today's date.

* fix: Return today instead of None when date is absent

* fix: Handle empty string for day attribute

* test: Check a couple more parse_creation_date cases

* fix: Revert to returning None when date elt is absent

* style: black
 2023-07-05 08:23:37 -05:00
Jennifer Richards d87ffb6912
Merge pull request #5912 from ietf-tools/main 
chore: Merge main into feat/rfc
 2023-07-04 12:09:46 -03:00
Robert Sparks db670dadc5
chore: continued refactor 2023-06-30 17:27:27 -05:00
Jennifer Richards 771296bbe6
feat: Link rfc/draft document history pages (#5894) 
* fix: Do not show "rev" column for rfc document history

* style: Reformat document_history() using Black

* refactor: Use "is not None" instead of "!= None"

* refactor: Convert dict() to dict literal

* fix: Migrate group, stream, and ad from draft to rfc Document

* feat: Link rfc/draft history pages
 2023-06-28 17:51:31 -03:00
Jennifer Richards bff145f975
fix: Create relationships between draft and rfc Documents (#5890) 
* fix: Create RelatedDocument between draft and rfc Documents

* chore: Improve comment

* refactor: Clarify migration
 2023-06-28 11:41:08 -03:00
Jennifer Richards 877bc02d77
refactor: Refactor build_file_urls() (#5886) 2023-06-27 11:14:19 -03:00
Robert Sparks e910836ad4
fix: teach build_file_urls about rfc type documents. (#5880) 2023-06-26 21:33:02 -03:00
Jennifer Richards 1db267dd7d
fix: Set has_onsite_tool correctly in no_session() view (#5879) 
This will prevent a session that was changed from "notmeet" to
 being scheduled from having its has_onsite_tool flag left as False
 2023-06-26 16:10:51 -05:00
Paul Selkirk 98bf7afeab
feat: Display and bulk-edit nomcom position flags (#4681) (#5878) 
This adds a table to show the state of all nomcom positions, and lets the
chair set or un-set multiple state flags at the same time.

As a consequence, it moves the email templates to the "Edit position" form.
 2023-06-26 16:10:05 -05:00
Robert Sparks 75d199fe31
chore: correct merge errors 2023-06-26 13:14:31 -05:00
Robert Sparks ad0071fd7d
chore: merge feat/rfc 2023-06-26 13:12:15 -05:00
Robert Sparks 69f882d833
chore: tweaks for rebuild_reference_relations 2023-06-26 13:03:59 -05:00
Jennifer Richards 106c67ec95
feat: Migrate docevents onto rfc documents (#5872) 
* refactor: Separately migrate DocAliases to rfc Documents

The gap in numbering is intentional, another migration will be along
shortly.

* feat: Migrate docevents onto rfc documents

* chore: Refining DocEvent migration (WIP)

* chore: Move IANA Action state change docevents to rfc docs

* chore: Fix typo

* refactor: Eliminate "created" rfc state

* chore: Leave "ballot set" comments on drafts
 2023-06-23 17:16:04 -03:00
Lars Eggert f250a653a2
fix: Remove IESG-related about tabs from non-IETF-stream docs (#5515) 
* fix: Remove IESG-related about tabs from non-IETF-stream docs

Fixes #5514

* Fix code review comments

* Address review comments

* Address code review comments
 2023-06-22 10:35:59 -05:00
Paul Selkirk 53b5e23612
fix: Be a little clearer when feedback is closed (or not yet open). (#5861) 2023-06-22 08:13:32 -05:00
Lars Eggert 62523eb02c
fix: More dark mode fixes (#5852) 
* fix: Correctly indicate "auto" theme is default

* fix: .pnp.js changes were missing

* fix: Use a "-subtle" background color for the menu bar

Because those change correctly with theme changes. That the
non-"-subtle" ones may be a bs5 bug, but enough people complained
about the yellow background in dev mode in dark mode that this change
may be worth it.

* fix: Try and recolor black colors in SVGs for dark mode

* Apply suggestions from @martinthomson
 2023-06-21 11:46:16 -05:00
Jennifer Richards 0144ee991e
fix: Include time zone information in v1 api datetimes (#5851) 
* fix: Include time zone information in v1 api datetimes

* fix: Use Z suffix instead of offset in API datetimes
 2023-06-21 11:43:19 -05:00
Jennifer Richards f2c2957925
refactor: Represent RFCs as their own DocType (#5835) 
* feat: Add RFC DocTypeName, StateType, and States

* refactor: Rename rfc_number() to deprecated_rfc_number()

* feat: Add rfc_number field to DocInfo

* feat: Add DocRelationshipName "became-rfc"

* chore: First-pass migration to create rfc Documents

* chore: create_rfc_documents migration depends on new names

* refactor: Rename variable

* fix: Fix revname / downcase name for "became-rfc" DocRelationshipName

* chore: Remove debugging print statements

* feat: Point rfc aliases at rfc Documents

* test: Refactor RFC factories

* refactor: Rewrite is_rfc() in terms of type_id

* test: Use RfcFactory as base for IndividualRfcFactory

* refactor: Replace calls to deprecated_rfc_number()

* refactor: Remove deprecated_rfc_number() method

* test: Import WgRfcFactory
 2023-06-20 15:28:16 -03:00
Lars Eggert a6cc12c14b
fix: Don't (re)sort obsoleted/updated info (#5391) 
* fix: Don't (re)sort obsoleted/updated info

Rebased against feat/postgres

* Update ietf/doc/utils_search.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* Update ietf/doc/utils_search.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* Update ietf/doc/utils_search.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* Fix review comments

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
 2023-06-20 12:07:45 -05:00
Robert Sparks 8ff14419c2
chore: continued refactoring 2023-06-16 16:59:20 -05:00
Robert Sparks 3c016cc5c8
feat: v3-era aware feed for rfcs (#5828) 
* feat: v3-era aware feed for rfcs

* chore: remove obviated comment

* test: improve rfc feed tests
 2023-06-16 15:52:42 -05:00
Robert Sparks ac65232115
fix: improve when Message objects are created (#5836) 
* fix: improve when Message objects are created

* test: further improve feedback test

* fix: improve and test another form

* test: Restructure test infrastructure
 2023-06-16 15:51:31 -05:00
Robert Sparks d6f58b3e67
chore: use more expressive related_name 2023-06-16 15:26:52 -05:00
Robert Sparks f3566c2743
chore: include (nontrivial) migrations 2023-06-16 15:07:51 -05:00
Robert Sparks 769d85a6c4
chore: explore architecture change in RelatedDocument 2023-06-16 14:58:42 -05:00
Robert Sparks 7798ea8d66
Merge remote-tracking branch 'ietf-tools/main' into feat/rfc 2023-06-15 16:07:42 -05:00
Jennifer Richards f04d356834
fix: Do not cache official_timeslotassignment when None (#5830) 2023-06-15 09:27:31 -05:00
Jennifer Richards 6f361f9574
chore: Keep default CSRF_TRUSTED_ORIGINS when in debug mode (#5827) 2023-06-15 09:04:43 -05:00
Lars Eggert 01e2d8b2bf
fix: Don't resort a table if sort query argument is present (#5825) 
* fix: Don't resort a table if sort query argument is present

Fixes #5686

* Address code review comments
 2023-06-15 08:56:27 -05:00
Lars Eggert fd09e60369
fix: RFC9389 obsoleted RFC8989 (#5822) 
Fixes #5820
 2023-06-14 12:35:07 -05:00
Lars Eggert 55f481ff74
fix: Also point to IETF web page for liaison relationships (#5823) 
Fixes #5780
 2023-06-14 12:34:46 -05:00
Lars Eggert a3d9cf3723
fix: Make attendee table sortable (#5824) 
Fixes #5606
 2023-06-14 12:34:27 -05:00
Lars Eggert e3a0f476c9
Fix test failure (#5826) 2023-06-14 12:17:07 -05:00
Jennifer Richards c8dcda0fae
refactor: Do not use canonical_name() for charters (#5818) 
* fix: Enforce naming of charter docs in submit()

* style: Reformat submit() with Black

* refactor: Remove redundant check of charter name

* style: Reformat charter_with_milestones_txt with Black

* refactor: Drop canonical_name, use Path in charter_with_milestones_txt

* style: Reformat review_announcement_text() with Black

* style: Reformat action_announcement_text() with Black

* refactor: Change uses of charter.canonical_name() to charter.name

* refactor: Skip docialias when retrieving charter

* refactor: Change canonical_name() to name in utils_charter.py

* refactor: Use Path in read_charter_text()

* refactor: Drop canonical_name, minor refactor of tests_charter.py

* refactor: charter.name instead of canonical_name in milestones.py

* refactor: charter.name instead of canonical_name in tests_info.py

* refactor: Remove unused functions in ietf/secr/utils/groups.py

* refactor: charter.canonical_name -> charter.name in templates

* refactor: Remove charter handling from canonical_name

Temporarily raise an exception for testing

* refactor: Refactor get_charter_text() without canonical_name

* refactor: Remove raise when canonical_name called on a charter

* fix: Add back missing ".txt" extension

* test: Test rejection of invalid charter names
 2023-06-14 08:32:21 -05:00
Robert Sparks 518aedb0f0
chore: remove already run single-use management command (#5815) 2023-06-13 15:53:36 -05:00
Robert Sparks 772b6e8c3c
Merge branch 'main' into feat/dark-mode 2023-06-13 13:37:04 -05:00
Robert Sparks a3db61cf69
Merge pull request #5795 from rjsparks/markdowncharters 
feat: render charters on about page using markdown
 2023-06-13 12:22:51 -05:00
Jennifer Richards f5365b2229
test: Fix test_meetings_misc_session_edit (#5807) 2023-06-12 15:55:46 -05:00
Jennifer Richards 2bf7e8250c
fix: Import DEFAULT_TIMEOUT correctly (#5803) 2023-06-12 13:50:14 -05:00
Jennifer Richards 12f1ac10ad
fix: Fix signature for LenientMemcacheCache.set() (#5800) 2023-06-12 12:48:32 -05:00
Robert Sparks b75b560dea
feat: import IAB minutes from the IAB wordpress site (#5689) 
* feat: import IAB minutes from the IAB wordpress site

Work in Progress

* fix: refactor as management commands

* fix: use datetime.timezone.utc for comparisons

* fix: coerce an argument. Command now runs

* chore: extend queryset in a better way

* fix: fetch kesara's repo and move files into place.

* fix: add a DocEvent explaining where the Documents came from

* fix: small optimizations and typo fixes

* fix: performance compromise for very old meetings

* fix: ensure variable is initialized

* fix: avoid operating on null by changing method signature - address review comments

* fix: repair html typo and address pyflake complaint

* chore: run black on a new and changed things
 2023-06-09 17:07:31 -05:00
Robert Sparks c3da3088fb
feat: render charters on about page uring markdown 2023-06-09 16:57:41 -05:00
Robert Sparks c7d98a1cdb
chore: remove stale commented codeblock (#5794) 2023-06-09 16:56:09 -05:00
Guillaume Ayoub 2e5c9ed160
fix: use v59.0 options for WeasyPrint (#5713) 2023-06-09 12:54:35 -05:00
Paul Selkirk 0567b3dea2
fix: /meeting/materials splits out named sessions the same way /meeting/proceedings does (#5715) 
* fix: /meeting/materials splits out named sessions the same way /meeting/proceedings does

* test: Test separation of named sessions in the materials
 2023-06-09 12:41:01 -05:00
Lars Eggert fbe876b758
fix: Produce correct HTML for the meeting requests table (#5712) 
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
 2023-06-08 15:39:55 -05:00
Jennifer Richards d18db5bb76
feat: Improve submission status UX during validation (#5742) 
* feat: Quietly check submission status before reloading

* chore: Remove misleading "time since" display

* feat: Back off submission status poll frequency

* chore: Fix code comment
 2023-06-08 15:15:27 -05:00
Lars Eggert 818f0a9938
fix: Add definition of DOWNREF from RFC3967 (#5789) 
Fixes #2788, #5759
 2023-06-08 15:14:14 -05:00
Paul Selkirk 2ca4f7beaf
fix: Improve validation for form that accepts pasted email feedback (#5761) 
* test: Test paste-email-feedback-form with missing headers and/or body

* fix: Don't crash if paste-email-feedback-form doesn't contain a Subject line

* test: Test that paste-email-feedback-form requires headers

* fix: If email headers are missing, prompt the user to try again

* chore: retrigger PR checks
 2023-06-08 13:56:24 -05:00
Lars Eggert cc35a2d678
fix: Don't add "essential people" to session requests by default (#5734) 
* fix: Don't add "essential people" to session requests by default

Because since #5169 we ask they not be included anymore. (This was part of my
original change but I guess I forgot to add it to the PR...)

* Don't import Person
 2023-06-08 13:48:53 -05:00
Paul Selkirk d2406d8420
fix: tweak Nomination.share_nominator label text (#5775) 
* fix: tweak Nomination.share_nominator label text

"Share nominator name with candidate" was confusing, because it's
imperative, where it's really intended to be permissive - it's okay to
share with the candidate.

* chore: add migration for label text
 2023-06-08 13:47:46 -05:00
Robert Sparks fcfe54baaf
Merge pull request #5766 from pselkirk/fix-4771 
fix: Don't use an uninitialized variable (#4771)
 2023-06-08 13:36:44 -05:00
Robert Sparks dfc5cc4b4b
Merge pull request #5768 from pselkirk/cleanup-feedback-email 
fix: Remove leading 32 spaces in feedback email rendering
 2023-06-08 13:36:23 -05:00
Robert Sparks 88a878fd61
Merge pull request #5774 from rjsparks/dont_come_around_here_no_more 
chore: remove unused mgmt commands
 2023-06-08 13:35:50 -05:00
Robert Sparks d6da25a448
fix: better caching of search results (#5782) 2023-06-07 16:25:19 -05:00
Robert Sparks 0864b73aab
fix: use slowpages to cache doc/active (#5781) 2023-06-07 15:35:17 -05:00
Robert Sparks ccf82bbd17
doc: update about.html for version 11 (#5770) 2023-06-06 18:14:29 -05:00
Robert Sparks 18941434c3
chore: remove unused mgmt commands 2023-06-06 16:12:35 -05:00
Jennifer Richards 9cee31613b
chore: Set CSRF_TRUSTED_HOSTS to localhost for dev (#5771) 2023-06-06 15:58:06 -05:00
Jennifer Richards edd72826e6
fix: Prevent errors when memcached object size is exceeded (#5769) 
* feat: Subclass PyMemcacheCache to tolerate too-large object errors

* fix: Use LenientMemcacheCache to prevent search errors

* fix: Re-raise errors other than "object too large"
 2023-06-06 14:35:41 -05:00
Paul Selkirk 4748a830fe fix: Remove leading 32 spaces in feedback email rendering 2023-06-06 00:07:49 -04:00
Paul Selkirk 1ad2e6bd59 fix: Don't use an uninitialized variable (#4771) 2023-06-05 23:15:02 -04:00
Robert Sparks 3fc77633a7
fix: protect htmlize and opengraph templates from fake dochistory objects (#5764) 2023-06-05 20:19:25 -05:00
Nicolas Giard cfaf966492
fix: add internal static.ietf.org var for pdfized render (#5765) 2023-06-05 20:18:35 -05:00
Nicolas Giard 7d04a71a94
chore: update .gitignore 2023-06-05 18:10:50 -04:00
Robert Sparks 4a062f5250
Merge pull request #5757 from ietf-tools/release 
ci: merge release commit and patch back into main
 2023-06-05 08:14:03 -05:00
Jennifer Richards d33a6f3c0c
fix: Handle missing date fields in XML submissions (#5744) 
* refactor: Eliminate _construct_creation_date helper

* fix: Use xml2rfc method for filling in missing date fields

* fix: Set options.date for xml2rfc writers

* test: Test handling of missing date element/fields
 2023-06-02 14:40:52 -05:00
Lars Eggert 7497143116
Better select2 fix 2023-06-02 11:46:10 +03:00
Lars Eggert e6f47a0474
Fix title 2023-06-02 11:43:54 +03:00
Lars Eggert 27f9e6aadb
Address review comments 2023-06-02 11:43:53 +03:00
Lars Eggert 8caf3a70f8
Fix some badges 2023-06-02 11:43:53 +03:00
Lars Eggert e5163b651b
Load theme.js in header, to avoid flickering 2023-06-02 11:43:53 +03:00
Lars Eggert f850061dff
Fix switching in HTMLized view 2023-06-02 11:43:53 +03:00
Lars Eggert 342e6f58bd
Color mode fixes 2023-06-02 11:43:53 +03:00
Lars Eggert 112d3b9f2a
Enable dark mode in other views 2023-06-02 11:43:53 +03:00
Lars Eggert 93d50f96c5
feat: Upgrade bootstrap to 5.3.0 and enable dark mode 
Fixes #3365
 2023-06-02 11:43:53 +03:00
Lars Eggert e6f351b3c9
Fix more colors 2023-06-02 11:43:53 +03:00
Lars Eggert 54c7951f7b
Fix some colors 2023-06-02 11:43:53 +03:00
Lars Eggert df1a4bf40f
Enable dark mode in other views 2023-06-02 11:43:53 +03:00
Lars Eggert b3c7094dc8
feat: Upgrade bootstrap to 5.3.0 and enable dark mode 
Fixes #3365
 2023-06-02 11:43:53 +03:00
Jennifer Richards 5d467d996c
Merge pull request #5739 from jennifer-richards/coop_setting 
chore: Use permissive cross-origin-opener-policy setting
 2023-06-01 18:44:00 -03:00
Jennifer Richards c8f9739604
Merge pull request #5738 from ietf-tools/main 
chore: Merge main into feat/django4
 2023-06-01 17:32:27 -03:00
Jennifer Richards 2d661a1a5f
chore: Use permissive cross-origin-opener-policy setting 2023-06-01 17:12:15 -03:00
Jennifer Richards e3d16bc8e6
feat: Use distinct event desc for drafts received via api_submit (#5735) 2023-06-01 11:15:57 -05:00
Jennifer Richards 5a2708283b
feat: Extract document creation date from XML draft (#5733) 
* fix: Extract document creation date from XML draft

* test: Fix test
 2023-06-01 09:58:55 -05:00
Jennifer Richards 8d4780d304
fix: Ignore failure to extract text draft title unless it is needed (#5730) 
* fix: Accept a Path as source for a PlaintextDraft

* fix: Guard against failure to extract PlaintextDraft title

* fix: Ignore failure to extract text draft title unless it is needed
 2023-06-01 09:39:59 -05:00
Robert Sparks 36b847b57a
fix: explain what is not counted in the meeting request summary (#5728) 2023-06-01 09:32:11 -05:00
Jennifer Richards 3391166aaf
fix: Return NomComs, not Groups, from active_nomcoms filter (#5726) 
* fix: Return NomComs, not Groups, from active_nomcoms filter

* fix: deduplicate and order nomcoms in active_nomcoms filter
 2023-05-31 15:05:59 -05:00
Robert Sparks c12f810dd4
test: ignore acceptable order change (#5727) 
* test: ignore acceptable order change

* fix: address review comments
 2023-05-31 15:04:51 -05:00
Nicolas Giard 1ec403dc8c
feat: disable login button on submit (#5718) 
* feat: disable login button on submit

* refactor: move login js into its own file
 2023-05-31 14:58:09 -05:00
Lars Eggert e5dcc1667c
fix: Fix overscrolling of rfc2html pre tags with new fonts (#5709) 2023-05-31 12:39:31 -05:00
Lars Eggert 48dce85cac
fix: Remove "purpose" column, show purpose as badge (#5721) 
Fixes #5711
 2023-05-31 12:37:21 -05:00
Jennifer Richards 8cd09ab3be
Revert "fix: Return NomComs, not Groups, from active_nomcoms filter" 
This reverts commit e121b5dd50.
 2023-05-31 14:13:46 -03:00
Jennifer Richards e121b5dd50
fix: Return NomComs, not Groups, from active_nomcoms filter 2023-05-31 12:36:49 -03:00
Jennifer Richards 3015359323
test: Use QuerySetAny alias for QuerySet type checks 2023-05-31 11:09:08 -03:00
Jennifer Richards 1922a6066e
Merge pull request #5700 from ietf-tools/main 
chore: main -> django4
 2023-05-31 10:59:09 -03:00
Lars Eggert f8e1899108
fix: Don't include modal headings in right-hand nav menu (#5710) 
Fixes #5701
 2023-05-30 11:56:17 -05:00
Jennifer Richards d595aaced0
fix: Skip title validation if only XML uploaded (#5694) 2023-05-26 09:28:16 -05:00
Nicolas Giard 0a11892414
chore: use variable for static.ietf.org references (#5692) 2023-05-25 17:23:18 -05:00
Lars Eggert 5f4dfb87b6
fix: Use new fonts for PDFization (#5688) 2023-05-25 09:43:15 -05:00
Robert Sparks 66f1ba3088
fix: reflect publication of rfc9389 (#5685) 2023-05-25 08:28:13 -05:00
Paul Selkirk 65bd689daa
fix: make chat room an overrideable property of Session (#5681) 
* fix: make chat room an overrideable property of Session

* test: validate that /meeting/session/<sessionid>/edit shows and sets chat room

* test: validate Session.chat_room_name
 2023-05-24 10:26:19 -05:00
Robert Sparks 4012a213c5
feat!: Version 11 based on Django 4 2023-05-23 11:25:28 -05:00
Robert Sparks 6178519d43
fix: optimize queries for DocumentChangesFeed (#5675) 2023-05-23 10:14:13 -05:00
Jennifer Richards e973672c25
Merge branch 'feat/django4' into dev/merge-main-5679 2023-05-23 12:11:17 -03:00
Jennifer Richards ceb41e6106
test: Check that error is displayed on decode failure 2023-05-23 11:30:35 -03:00
Jennifer Richards 5f0e1a524b
chore: Display errors if nomcom private key encoding fails 2023-05-23 11:30:14 -03:00
Jennifer Richards 58182fd7f6
test: Fix selectors in selenium tests 2023-05-19 17:54:24 -03:00
Jennifer Richards 2a29be5d6a
test: Remove unused import 2023-05-19 16:23:42 -03:00
Jennifer Richards 2eaea55ce8
chore: Move log out suppression to settings,py 2023-05-19 15:25:35 -03:00
Jennifer Richards 579d187f0c
chore: Suppress deprecation warning in oidc_provider 2023-05-19 15:20:09 -03:00
Jennifer Richards bc3dcb6c03
test: Fix another test broken by changing "Sign out" to a form 2023-05-19 15:11:59 -03:00
Jennifer Richards 36fe6a0206
fix: Store nomcom private key in session as str 
bytes are incompatible with JSONSerializer
 2023-05-19 14:57:27 -03:00
Jennifer Richards 93e9f8e850
fix: Do not set update_fields when saving new instance 2023-05-19 14:36:08 -03:00
Jennifer Richards be25fb954b
test: Ignore menu bar when counting "submit" buttons 
(the "Sign out" link is now a submit button)
 2023-05-19 14:18:02 -03:00
Jennifer Richards 102a612857
test: POST instead of GET for logout tests 2023-05-19 14:12:12 -03:00
Jennifer Richards 37a6521879
test: Form is r.context["form"], not r["form"] 2023-05-19 13:37:39 -03:00
Jennifer Richards 1eafdca65c
chore: Replace django.utils.timezone.utc with dateutil.timezone.utc 2023-05-19 13:23:38 -03:00
Jennifer Richards fdc074b313
test: Use new signature for assertFormError 2023-05-19 13:23:07 -03:00
Jennifer Richards da8717f0e9
chore: Set chunk_size on QuerySet.iterator() 2023-05-19 13:10:06 -03:00
Jennifer Richards 7ae0576a44
style: Apply Black style to methods in review.utils 2023-05-19 13:08:47 -03:00
Jennifer Richards b6a791511f
chore: Use DjangoDivFormRenderer to opt in to new default 2023-05-19 12:52:26 -03:00
Jennifer Richards 2d6681d78c
refactor: logout via GET is deprecated, use POST 2023-05-19 11:42:43 -03:00
Jennifer Richards b06fc7acc4
chore: Suppress warning about CryptPasswordHasher 2023-05-19 11:28:58 -03:00
Jennifer Richards 19abdfe5e7
refactor: Inject tests without using deprecated extra_tests 2023-05-19 11:09:05 -03:00
Jennifer Richards 25b9976460
chore: Switch to JSONSerializer 
PickleSerializer is deprecated
 2023-05-18 18:37:25 -03:00
Jennifer Richards 39a854fa1a
fix: Use arbitrary date in the past instead of datetime.min 2023-05-18 18:36:38 -03:00
Robert Sparks d0f8e1148a
chore: keep csp config in sync with production configuration (#5656) 2023-05-18 16:29:30 -05:00
Robert Sparks 34d714c4ec
chore: remove gather from CRSF_TRUSTED_ORIGINS (#5657) 2023-05-18 16:29:18 -05:00
Jennifer Richards c71f44fdb2
chore: Suppress deprecation warning for oidc_provider 2023-05-18 18:00:46 -03:00
Jennifer Richards 6df5d4c67f
chore: Suppress CICharField deprecation warning 2023-05-18 18:00:46 -03:00
Jennifer Richards 65ea426793
fix: Add changed fields to update_fields in Model.save() methods 2023-05-18 18:00:45 -03:00
Jennifer Richards 171a5bec73
chore: Update setuptools version and suppress warnings 
pkg_resources warning is caused by a few packages
(django-simple-history. django-widget-tweaks, etc). The datetime_safe
warning is in tastypie, as indicated. The others are deprecated
settings we already have tickets for.
 2023-05-18 18:00:45 -03:00
Jennifer Richards 55fb502179
test: Iterate over template.nodelist in apply_template_test 2023-05-18 15:18:02 -03:00
Jennifer Richards 47e2b0b027
fix: Prevent use of FK relation before review request is saved 2023-05-18 15:18:02 -03:00
Jennifer Richards c26c9c71e4
chore: Switch to PyMemcacheCache backend 2023-05-18 15:18:01 -03:00
Jennifer Richards cdec6cc0aa
Merge pull request #5655 from ietf-tools/main 
chore: Merge main into feat/django4
 2023-05-18 15:15:42 -03:00
Robert Sparks f9322391dd
fix: change trac.ietf.org links to what they redirect to now (#5651) 2023-05-18 08:31:54 -05:00
Jennifer Richards cbabb864c2
test: Use issubclass, not isinstance, to ID view_class 2023-05-17 16:09:56 -03:00
Jennifer Richards d519bca12c
test: Fix ignore_pattern so Redirect/TemplateViews are ignored again 2023-05-17 15:59:28 -03:00
Eric Vyncke 2a27a2bffc
feat: Can we provide a better review assignment email subject. #3760 (#5415) 
* Specific email subject + requester/secretary in cc

* Send the deadline in the subject

* Use unicode rather than ASCII for reviewer's name

* More log info in the test

* Fix the closing parenthesis

* Fix the email test  when review is assigned

* chore: address review comment

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
 2023-05-17 12:23:20 -05:00
Jennifer Richards f85978fe24
chore: Disable L10N localization 2023-05-17 12:52:34 -03:00
Robert Sparks ab01e72ada
fix: tweak submit instructions to match very recent changes to the UI (#5646) 2023-05-17 09:25:17 -05:00
Russ Housley ef598a6dae
fix: Update I-D submission instructions. Fix #5264 (#5407) 
* Fix: Update I-D submission instructions. Fix #5264

* Resolve comments in PR 5407
 2023-05-17 09:17:30 -05:00
Jennifer Richards 8cf609bfa9
refactor: Implement require_api_key with functools.wraps 
The @decorator mechanism does not seem to work with @method_decorator
in Django 4.0, have not tracked down why.
 2023-05-17 09:45:07 -03:00
Robert Sparks 38bab2575e
fix: better htmlized access to uncurrent revisions (#5639) 2023-05-16 17:08:18 -05:00
Jennifer Richards 223c679942
chore: Add no-op migration to satisfy Django bookkeeping changes 2023-05-16 17:48:44 -03:00
Nicolas Giard 12f1cb200a
feat: set fonts for htmlized doc template (#5636) 2023-05-16 14:56:36 -05:00
Jennifer Richards 88452a2db1
chore: Add USE_DEPRECATED_PYTZ to settings.py 2023-05-16 16:20:51 -03:00
Jennifer Richards 76fa01b817
chore: Suppress deprecation warning for oidc_provider AppConfig 2023-05-16 13:21:12 -03:00
Jennifer Richards 374c1a40be
chore: Use new format for CSRF_TRUSTED_ORIGINS setting 2023-05-16 13:14:48 -03:00
Jennifer Richards 7475aa01b6
Merge pull request #5634 from ietf-tools/main 
chore: Merge main into feat/django4
 2023-05-16 13:06:49 -03:00
Paul Selkirk 37118a623a
fix: change api_submission blackout message to match web ui (#5623) 
* test: api_submission returns an error in the blackout period

* fix: change api_submission blackout message to match web ui (#5350)
 2023-05-16 09:43:20 -05:00
Robert Sparks c16a9d6cb5
fix: better area links from the menus (#5620) 
* fix: better area links from the menus

* chore: remove debugging line
 2023-05-15 16:41:42 -05:00
Robert Sparks 6fd9a39df8
chore: update test name fixuture (#5627) 2023-05-15 16:38:11 -05:00
Nicolas Giard 3d6ca172ce
feat: change fonts to Inter and Noto Sans Mono (#5628) 2023-05-15 16:37:00 -05:00
Jennifer Richards b714bfb083
chore: Put widgets from django-password-strength into ietfauth 2023-05-15 17:55:11 -03:00
Robert Sparks b4a692fac1
fix: show session times in meeting timezone when announcing scheduling (#5622) 2023-05-15 14:55:37 -05:00
Robert Sparks 7dbac2067f
fix: show meeting timezone when editing sessions (#5619) 
* fix: show meeting timezone when editing sessions

* chore: run black on session_filters
 2023-05-15 14:50:10 -05:00
Jennifer Richards 329fa26ee0
chore: Remove abandoned django-password-strength package 2023-05-15 15:29:00 -03:00
Robert Sparks 962af9feb3
fix: tweak removal of document info order (#5624) 
* fix: tweak removal of document info order

* chore: add copyright line

* chore: correct dependencies
 2023-05-15 13:20:59 -05:00
Jennifer Richards 0319f35e0f
test: Use Django 3.2 HttpResponse.headers API 2023-05-15 13:01:59 -03:00
Peter Yee 369fe0dfe5
fix: remove order from DocumentInfo as apparently unneeded (fixes #5245) (#5417) 
* fix: remove order from DocumentInfo as apparently unneeded (fixes #5245)

Fixes #5245. Includes migration, however I did not test the reverse.

* Merge branch 'main' into pr/Spectre17/5417

* chore: Renumber migrations

* Revert "Merge branch 'main' into pr/Spectre17/5417"

This reverts commit 77b4a46f84e9ece6778dec6e8127aedad71c2625.

---------

Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
 2023-05-15 10:35:54 -05:00
Jennifer Richards 22bf508922
test: Suppress notices from mypy involving factory types 2023-05-15 12:20:02 -03:00
Jennifer Richards cbb946455f
test: Remove unused assignment that caused a mypy error 2023-05-15 11:25:38 -03:00
Jennifer Richards c840d53cb2
test: Suppress mypy error on import of _lazy_re_compile() 2023-05-15 11:04:29 -03:00
Jennifer Richards 68eb685382
test: Use django_stubs_ext.QuerySetAny for isinstance() checks 
mypy complains if QuerySet is used because it uses a parameterized
generic type.
 2023-05-13 10:05:33 -03:00
Jennifer Richards 7ad74c99e4
refactor: import from django.urls instead of django.conf.urls 2023-05-12 20:29:11 -03:00
Jennifer Richards 00f3f01e7e
fix: {% endif %}, not {% end %} 2023-05-12 18:52:35 -03:00
Jennifer Richards 872bdef06b
refactor: Use gettext instead of deprecated ugettext 2023-05-12 18:37:01 -03:00
Jennifer Richards 79b749fcdf
style: Restyle method using Black 2023-05-12 18:36:05 -03:00
Jennifer Richards 21004864b0
refactor: Replace deprecated is_safe_url with new name 2023-05-12 18:35:12 -03:00
Jennifer Richards 32ed1b7c4a
refactor: Replace deprecated {% ifequal %} with {% if %} 2023-05-12 18:33:15 -03:00
Jennifer Richards bee7e11360
chore: Remove accidental import from settings.py 2023-05-12 18:29:39 -03:00
Jennifer Richards b5d9e9b14c
refactor: Replace deprecated django.utils.http.urlquote 2023-05-12 18:27:51 -03:00
Jennifer Richards 075aed7e9a
refactor: Replace deprecated request.is_ajax() 2023-05-12 18:26:56 -03:00
Jennifer Richards 9d21196adc
chore: Add DEFAULT_AUTO_FIELD to settings.py 2023-05-12 18:03:28 -03:00
Jennifer Richards aa4c04126c
chore: Use re_path() instead of url(), its deprecated synonym, 2023-05-12 17:09:32 -03:00
Jennifer Richards d0cb46d320
fix: Use TruncDate instead of QuerySet.extra() 2023-05-12 15:47:37 -03:00
Jennifer Richards ccb7d666ce
chore: Remove add-django-http-cookie-value-none.patch 
Fixed upstream
 2023-05-12 15:47:37 -03:00
Jennifer Richards 1419a0e7c8
test: Remove ScheduleEditTests.testUnschedule (#5607) 
* test: Remove ScheduleEditTests.testUnschedule

Has been disabled under Django 2. Simple refactoring does not make it
functional under Django 3. Probably because we know that Selenium does
not handle HTML5 drag-and-drop well. Discarding until we move to a
better JS testing framework.

* test: Remove unused imports
 2023-05-12 13:18:15 -03:00
Jennifer Richards 96396b833c
Merge pull request #5611 from ietf-tools/main 
chore: merge main into feat/django4
 2023-05-12 11:05:57 -03:00
Robert Sparks 6b4115a52b
test: ignore irrelevant difference in list element order (#5609) 2023-05-12 09:03:13 -05:00
Robert Sparks 1afdb0b7cc
fix: show htmlized views of draft revisions without DocHistory (#5599) 
* fix: show htmlized views of draft revisions without DocHistory

* fix: handle htmlized views of rfcs corectly
 2023-05-11 17:15:01 -05:00
Jennifer Richards 264ff60cd2
Merge pull request #5601 from jennifer-richards/django4 
chore: Upgrade to Django 3.0
 2023-05-11 11:04:36 -04:00
Robert Sparks 6089d4726c
chore: remove debugging file write from test (#5598) 2023-05-11 09:37:02 -05:00
Jennifer Richards 0d070597b4
style: Double backslashes in strings 
Not sure why, but if I change the DeprecationWarning filter to
"error", I get a SyntaxError from the \[ because it is an invalid
escape sequence. Not sure why that change triggers it, but
"\[" and "\\[" are the same, so this is a no-op.
 2023-05-10 19:21:47 -03:00
Jennifer Richards eee145ee67
fix: Explicitly order GroupTypeNames in active_group_types 
Relying on Meta.ordering to order querysets involving GROUP BY queries
is deprecated and will be dropped in Django 3.1.
 2023-05-10 19:19:39 -03:00
Jennifer Richards 406ba7bf0b
style: Apply Black style to active_group_types() view 2023-05-10 19:18:30 -03:00
Jennifer Richards e6259a5218
chore: Remove filter on staticfiles DeprecationWarning 2023-05-10 18:52:52 -03:00
Jennifer Richards 1015cf83f8
fix: Finish refactoring LiaisonModelForm subclasses without BetterModelForm 2023-05-10 18:47:36 -03:00
Jennifer Richards 4f443cc445
refactor: Explicitly allow name=None for a couple of views 2023-05-10 17:16:20 -03:00
Jennifer Richards 163479bc06
refactor: Replace obsolete staticfiles template lib with static 2023-05-10 17:12:34 -03:00
Jennifer Richards 85d0934ba0
refactor: Refactor LiaisonForm without BetterModelForm 2023-05-10 17:03:31 -03:00
Jennifer Richards a75dbd4f40
chore: Remove accidentally reverted removal of form_utils app 2023-05-10 16:50:42 -03:00
Jennifer Richards 57026bbb5f
Revert "chore: Remove django-cookie-delete-with-all-settings.patch" 
This reverts commit 2cf2a3dee6.
 2023-05-10 15:55:25 -03:00
Jennifer Richards 69eb6340fd
test: Do not misuse django.conf.settings for HTML validation params 2023-05-10 15:41:36 -03:00
Robert Sparks f8113cb862
fix: close open things (#5593) 
* fix: close open things

* fix: clean up test created files

* fix: remove one close too many
 2023-05-10 11:19:34 -05:00
Jennifer Richards ed571ae50b
chore: Rename DB engine to drop the deprecated "_psycopg2" suffix 2023-05-10 12:40:37 -03:00
Jennifer Richards a0f6cdb661
feat: Process uploaded submissions asynchronously (#5580) 
* fix: Use relative URL for submission status link

* refactor: Refactor/rename process_uploaded_submission async task

* feat: Add async task to process but not accept a submission

* feat: Replace upload_submission() with an async implementation (WIP)

* fix: Do not put Submission in "uploaded" state if an error occured

* refactor: Improve text/XML draft processing flow

* feat: Extract authors from text in async processing

* fix: Fix call signatures and abort submission on failed validation

* feat: Validate submission name format

* fix: Correctly validate emails from text submission

* fix: Clean up submission validation

* fix: Better display errors on upload_submission page

* feat: Reload submission status page when awaiting validation

* test: Fix call signatures; remove unused imports

* chore: Add type hint

* test: Update tests to match renamed task

* fix: Fix typo in error message

* test: Fix failing Api- and AsyncSubmissionTests

* Rename process_uploaded_submission to process_and_accept_...
* Remove outdated tests

Does not yet test new behavior.

* refactor: Break up submission_file() helper

* test: Refactor tests to run the async processing (wip)

* test: Drop test of bad PDF submission

The PDF submission field was removed, so no need to test it.

* test: Update more tests

* test: Bring back create_and_post_submission() and fix more tests

* fix: Drop to manual, don't cancel, on revision inconsistency

Fixes remaining failing SubmitTest tests

* style: Restyle upload_submission() with black

* test: Verify that async submission processing is invoked on upload

* test: Bring back old do_submission and fix tests

Properly separating the upload and async processing stages of submission
is a bigger refactoring than will fit right now. This better exercises
the submission pipeline.

* fix: Accept only XML for API submissions

* test: Test submission processing utilities

* feat: Improve status display for "validating" submissions

* chore: Remove obsolete code

* test: Update test to match amended text

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
 2023-05-09 15:21:46 -05:00
Jennifer Richards da168395fc
refactor: Replace deprecated smart_text with smart_str 2023-05-09 15:23:33 -03:00
Jennifer Richards 07e26dd52e
refactor: Replace deprecated force_text with force_str 2023-05-09 15:21:50 -03:00
Jennifer Richards dcb211fbb3
Merge remote-tracking branch 'origin/main' into django4 2023-05-09 14:26:47 -03:00
Jennifer Richards 2cf2a3dee6
chore: Remove django-cookie-delete-with-all-settings.patch 
Patch no longer applies. Needed until Django 4.2.1, so bring it back
if we deploy something earlier than that to production.
 2023-05-09 11:09:41 -03:00
Jennifer Richards 6d4d09542f
fix: Replace obsolete curry() with functools.partialmethod() 2023-05-08 22:55:15 -03:00