Commit graph

74 commits

Author SHA1 Message Date
Ole Laursen 1b56a33d21 Fix bugs in abandoning chartering of a proposed/bof/unknown group,
apparently most of the problems are inherited from trunk
 - Legacy-Id: 5092
2012-12-03 15:00:07 +00:00
Ole Laursen b19f6d8060 Merge in milestones branch
- Legacy-Id: 5091
2012-12-03 14:36:30 +00:00
Henrik Levkowetz 7e226be6fb Removed debug statements.
- Legacy-Id: 5062
2012-11-13 14:52:55 +00:00
Henrik Levkowetz ebef7416d2 Resolved a naming conflict between the builtin messages framework and a variable named messages in wgcharter.views.change_state. Fixes issue #901.
- Legacy-Id: 5061
2012-11-13 14:51:50 +00:00
Henrik Levkowetz 440ca88dd2 Added an 'email sent' success message after sending out a WG review announcement. XXX: Todo: Add equivalent messages in all other situations where email is sent out, for consistency.
- Legacy-Id: 4965
2012-10-30 13:30:01 +00:00
Henrik Levkowetz 6a5a5c2200 Merged [4811] from rjsparks@nostrum.com:
Cleaned up setting wg state, leaving events, and facilitated creating an initial charter for an existing unchartered group
 - Legacy-Id: 4940
2012-10-21 15:04:58 +00:00
Henrik Levkowetz d0214d3b25 Merged [4806] from rjsparks@nostrum.com:
Better handling for BoFs, particularly those that won't create WGs
 - Legacy-Id: 4939
2012-10-21 14:40:02 +00:00
Henrik Levkowetz 53b35ac4a5 Merged [4805] from rjsparks@nostrum.com:
When abandoning a chartering effort, only revert to approved charters if there's a chance one is there.
Fixes bug #868
 - Legacy-Id: 4917
Note: SVN reference [4805] has been migrated to Git commit 51426f1bd0
2012-10-15 21:19:02 +00:00
Henrik Levkowetz 6943ecb930 Added the creation of a WG state change event for WG state changes.
- Legacy-Id: 4915
2012-10-15 21:01:20 +00:00
Robert Sparks 2ec91d3835 Warn when putting a charter in an unusual state onto a telechat agenda
- Legacy-Id: 4842
2012-09-12 21:00:47 +00:00
Henrik Levkowetz d23a769dd9 Merged [4773] from olau@iola.dk:
Encode uploaded charter text with UTF-8 to avoid crashing on Unicode content
 - Legacy-Id: 4802
Note: SVN reference [4773] has been migrated to Git commit 2f48dfc713
2012-08-23 10:07:20 +00:00
Robert Sparks e5c3a5adc5 Liasion Manager:
* Patch from Yaco to avoid resetting the From field when changing other items on the form
* Gave the secretariat the ability to find/approve any unapproved liaisons
* Changed all the email code to use ietf.mail.utils (and removed the fake-mail concept)

Charter documents and the Agenda pages:
* Added charter documents to iesg/agenda and iesg/agenda/documents
* Synced the ordering of drafts on iesg/agenda and iesg/agenda/documents
* Allow setting a responsible AD for charter documents
* Changed the UI of the charter page to use editlink for changing attributes and buttons for actions (to align with drafts and conflict-reviews)

Moderator package:
* Refactor: Simplified access to the current BallotDocEvent from a Document
* Added functions to BallotDocEvents? to faciliate access to BallotPositionDocEvents?, both for all positions, and current AD postions.
* Updated the moderator package to use the Documents from _agenda_data.
* Added a filter to assist with rendering the moderator package.
* Fixed a bug where different functions in idrfc/views_ballot were using log_state_changed expecting different implementations (a cleanup task should reconcile the _three_ implementations in the codebase of that function).

Cleanup from codesprint:
* Removed some duplication between doc/util and doc/models by moving things into doc/models
* Do not show non-empty discuss text when the ballot position is not blocking
* Added a migration to update non-blocking ballot positions that have non-empty discuss text


DEPLOYMENT NOTES
Please be aware that migration step will take a few minutes to complete.

Fixes bug 865
 - Legacy-Id: 4772
2012-08-21 04:46:01 +00:00
Robert Sparks 735efac3b0 Add charter documents to iesg/agenda and iesg/agenda/documents
Keep the ordering for drafts the same on iesg/agenda and iesg/agenda/documents
Allow setting the responsible AD for a charter document
Change the UI of the charter page to use editlink for changing attributes and buttons for actions (to align with drafts and conflict-reviews)
 - Legacy-Id: 4769
2012-08-21 03:57:17 +00:00
Ole Laursen 32430915e1 Fix missing group variable in template context (regression introduced with generalization of WG strings)
- Legacy-Id: 4751
2012-08-02 21:47:19 +00:00
Robert Sparks fb2b9c9e6c Removed some duplication between doc/util and doc/models by moving things into doc/models. Fixes bug #857
- Legacy-Id: 4750
2012-08-02 21:36:36 +00:00
Ole Laursen ce8d7728d8 Apply bug fix from charter branch in sending review announcements
- Legacy-Id: 4608
2012-07-09 14:55:09 +00:00
Ole Laursen 967494548e Remove unused testurl.list file
- Legacy-Id: 4602
2012-07-06 13:24:22 +00:00
Ole Laursen bcf6ef0230 Add milestone support in charter diffs by outputting them on a special
.txt generating page that looks up the milestones available at the
time the charter was submitted (actually just before the next one was
submitted)
 - Legacy-Id: 4578
2012-07-03 23:12:42 +00:00
Henrik Levkowetz 22c3ae22b9 Handle additional call modes and call cases for wgcharter.views.submit.
- Legacy-Id: 4555
2012-06-29 00:37:26 +00:00
Ole Laursen 2b5345cf67 Add some polish, send email notifications on milestone changes
- Legacy-Id: 4544
2012-06-28 19:00:24 +00:00
Ole Laursen 319a202900 Finish charter milestones support so they're merged in after approval
of the charter, also replace references to WGs in wgcharter with a
more generic counterpart so will be easier to add support for RGs if
someone ever gets that far (will still need testing and probably some
minor adjustments though).
 - Legacy-Id: 4534
2012-06-27 16:24:04 +00:00
Ole Laursen 7538eab96f Fix flow of approval of charters/announcement of the WG action based
on feedback from Cindy Morgan, now there's a link on the approval page
to go to the edit page which sends you back upon saving, and the edit
page doesn't provide a button to send the announcement since you
should do that on the approve page (instead it provides a link).
 - Legacy-Id: 4474
2012-06-19 18:48:02 +00:00
Ole Laursen 4cb42fd91c Include current milestones in charter action/review announcements,
fixes issue #835.
 - Legacy-Id: 4473
2012-06-19 17:06:56 +00:00
Henrik Levkowetz 802ee2905d Quick fix for crash when going to /wg/imapmove/charter/. I'm not happy about the 'charter-ietf-' constant which now appears several places in the code; we need settings which defines the correct name pattern for different document types (or a table or table column, maybe). But this hopefully will make it possible to continue processing proposed WGs ...
- Legacy-Id: 4459
2012-06-14 20:32:35 +00:00
Henrik Levkowetz afe3ee71b8 Merged in fixes from Ole, from branch/charter:r4382-4407, and some changes from Henrik (removing the use of pos.blocked in views_ballot.py, and setting a ballot id in idrfc/testsREDESIGN.py) to make idrfc.EditPositionTestCase succeed.
- Legacy-Id: 4444
2012-06-10 16:22:16 +00:00
Ole Laursen 88d083ff72 Turn chartering process around so one submits the charter text before
putting the charter document into the review state and emailing the
Secretariat.
 - Legacy-Id: 4404
2012-05-07 17:18:45 +00:00
Ole Laursen 2e4ceb5a55 Fixup special init charter/recharter pages to make the process more self-explanatory.
- Legacy-Id: 4403
2012-05-07 16:25:04 +00:00
Ole Laursen e2aa218b8a Hide mail to Secretariat and initial review time on rechartering, also
fix some phrasing problems.
 - Legacy-Id: 4398
2012-05-04 17:06:24 +00:00
Ole Laursen 4f9bacbe74 Add notify edit functionality, and send email to charter.notify when
the state is changed as is done for drafts.
 - Legacy-Id: 4396
2012-05-04 16:56:12 +00:00
Henrik Levkowetz 2bd427ec0f Add quotes around the WG name in the state change text, for better readability.
- Legacy-Id: 4394
2012-05-04 14:59:30 +00:00
Henrik Levkowetz 839df60480 Merged in charter branch fixes from olau@iola.dk, from r4354 through r4381.
- Legacy-Id: 4382
2012-05-04 11:47:30 +00:00
Ole Laursen 3ec4dffd24 Check and sanitize text file upload (code is factored out in a new
helper so it can be reused elsewhere in the future).
 - Legacy-Id: 4380
2012-05-04 11:37:16 +00:00
Ole Laursen eaf09d9dc5 Move charter state help to /doc/help/state/charter/.
- Legacy-Id: 4379
2012-05-03 19:23:24 +00:00
Ole Laursen 1526857f43 Fix test broken by previous commit.
- Legacy-Id: 4371
2012-05-03 18:34:54 +00:00
Ole Laursen c8e9362ba0 Amend previous commit to generate writeups on entering internal review instead.
- Legacy-Id: 4368
2012-05-03 18:09:29 +00:00
Ole Laursen c69174a483 Generate action and review text automatically.
- Legacy-Id: 4367
2012-05-03 18:06:03 +00:00
Ole Laursen 7573505b09 Make it move obvious what the change state view actually does by
rephrasing the form.
 - Legacy-Id: 4365
2012-05-03 17:49:12 +00:00
Ole Laursen cb634216b5 Fix terminology confusion and say "send ballot" rather than "issue
ballot" to clear up that it is not actually created.
 - Legacy-Id: 4362
2012-05-03 17:02:55 +00:00
Ole Laursen 7c8d018ad4 Fix bug in hiding "external review needed" checkbox.
- Legacy-Id: 4358
2012-05-03 15:33:08 +00:00
Henrik Levkowetz 462aff53ad Merged in fixes to the charter branch (r4345 - r4353) from olau@iola.dk.
- Legacy-Id: 4354
2012-05-02 19:37:46 +00:00
Henrik Levkowetz bcd28cc45f Merged in fixes to the migration from olau@iola.dk. Merged in charter branch from olau@iola.dk. Added various fixes and correction of merge errors.
- Legacy-Id: 4353
2012-05-02 19:35:32 +00:00
Ole Laursen 79d9eb84a9 Fix bug in event description when copying over the final approved
charter file.
 - Legacy-Id: 4351
2012-05-02 14:52:16 +00:00
Ole Laursen c4298f602a Offer text from latest approved revision in case there's no initial text
for a recharter submit form.
 - Legacy-Id: 4350
2012-05-02 12:18:40 +00:00
Ole Laursen 7f5a86f5dd Fix problem with running script again when there are existing ballot
events
 - Legacy-Id: 4343
2012-04-30 18:24:28 +00:00
Ole Laursen 3c7d546816 Swap order of event generation in previous commit.
- Legacy-Id: 4294
2012-04-20 12:54:24 +00:00
Ole Laursen 6ef8b8227c Fix bug in diff'ing charter revisions.
- Legacy-Id: 4293
2012-04-20 12:51:24 +00:00
Ole Laursen 0970082178 Some further cleanup.
- Legacy-Id: 4292
2012-04-20 12:24:31 +00:00
Ole Laursen d166ef284b Fixup revision oddity left by yesterdays refactor.
- Legacy-Id: 4291
2012-04-20 11:48:27 +00:00
Ole Laursen b9a90f35e1 Clean up and polish charter branch code, fix some subtle bugs with
revision and approved charter lookup.
 - Legacy-Id: 4290
2012-04-19 15:15:43 +00:00
Ole Laursen 7fbff575a5 Fix ballot closing in migration script
- Legacy-Id: 4281
2012-04-17 15:49:44 +00:00