Commit graph

14630 commits

Author SHA1 Message Date
Jennifer Richards 895aff9480
test: suppress deprecation warning from selenium internals (#4836) 2022-12-06 08:42:13 -06:00
Jennifer Richards 0abebf2f10
feat: add 'IETF Meetings' filter to upcoming meetings page (#4826)
* feat: add 'IETF Meetings' filter to upcoming meetings page

* feat: apply 'ietf-meetings' filter to upcoming.ics

* fix: also filter upcoming IETF meetings in the graphical calendar

* test: update tests to match changes

Includes fixing an error in test_upcoming_view_filter_hide_type().
Due to a copy/paste error, it claimed to be testing with a type
both shown and hidden but was not actually hiding a type at all.
2022-12-05 15:19:36 -06:00
Robert Sparks 562d5cceeb
fix: include html when syncing extra assets 2022-12-02 16:28:08 -06:00
Lars Eggert d59c64943d
fix: Fix spurious author extraction errors (#4799)
* Handle single-word author names

* Some i18n names, e.g., "शिला के.सी." have a dot at the end that is
also part of the ASCII, e.g., "Shilaa Kesii." That trailing dot breaks
extract_authors(). Avoid this issue by stripping the dot from the
ASCII.

* Honorifics need to be part of the extracted ASCII name (e.g., "Lady Garcia")

* feat: stop supporting pre-tzaware migration database dumps. (#4782)

* feat: stop supporting pre-tzaware migration database dumps.

* chore: remove unnecessary env variable

* chore: Use `codespell` to fix typos in comments. (#4794)

First part of replacement of #4651

* feat: Only show IPR search form when not showing search results  (#4793)

* feat: Only show IPR search form when not showing search results

Put it into a collapsible that is only expanded by default when not
showing search results.

Fixes #4569

* Don't use example target name

* fix: Don't show reorder UI fixtures unless user can reorder (#4785)

Fixes #4773

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* chore: Update deps and fix resulting HTML validation issues (#4790)

* ci: add missing build matrix config for test-playwright-legacy step

* Single-letter last names exist (e.g., "Carolina de la O")

* Align regex with others

* Fix extraction of very long author names

* Need to be more general

* Add comment

* Also handle i18n names with trailing semicolons

* Name suffixes need to be part of the extracted author names

* Handle i18n names with embedded commas

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-12-02 15:41:21 -06:00
Jennifer Richards 3af68b6fbb
fix: avoid readonly attribute on select element (#4819)
* fix: avoid readonly attribute on select element

* chore: remove now-unused CSS for select2

* test: don't ignore `readonly` on `select`

* refactor: simplify OutgoingLiaisonForm base class overrides
2022-12-02 15:39:21 -06:00
Robert Sparks 9457e2b1e1
feat: better htmlization views (#4825)
* feat: Use bs5 for htmlized doc (#4082)

Co-authored-by: Martin Thomson <mt@lowentropy.net>

* fix: Various fixes to HTMLized document view (#4501)

* fix: Pref labels were switched

* fix: Fix ToC for htmlized docs

* Replace datatracker button with document name link to datatracker

* ui: Make fonts even larger on larger window widths

* fix: Document format buttons open new tabs

* fix: Various suggestions from Jay

* fix: Don't show "htmlized" self-link under formats

* ui: Font size fix for iOS

* ui: More little tweaks

* feat/htmlize fixes and improvements (#4506)

* fix: Don't open htmlized view in new tab

* fix: Tests were failing

* feat: Add pref settings to cap max font size

* feat: Add ability to hide side panel

* fix: And more `feat/htmlize` fixes (#4511)

* fix: Remove superfluous scrollbars

* fix: Show email links for authors

* fix: Only show "email authors" button for latest reversion

* fix: Remove duplicate code, fix nav scrolling

* feat: Add RFCs to revision lists

* feat: Add pref option to control dependency inlining

* fix: Add analytical tags

* feat: Notify user of rendering inconsistencies

* feat: Split out bootstrap-icons when not inlining dependencies

* fix: Revision list and minor other fixes

* feat: Show stream logo when possible (#4516)

* fix: Remove superfluous scrollbars

* fix: Show email links for authors

* fix: Only show "email authors" button for latest reversion

* fix: Remove duplicate code, fix nav scrolling

* feat: Add RFCs to revision lists

* feat: Add pref option to control dependency inlining

* fix: Add analytical tags

* feat: Notify user of rendering inconsistencies

* feat: Split out bootstrap-icons when not inlining dependencies

* fix: Revision list and minor other fixes

* feat: Show stream logos when possible

* fix: Pick up CSS changes from https://github.com/martinthomson/rfc-txt-html (#4520)

* fix: Remove superfluous scrollbars

* fix: Show email links for authors

* fix: Only show "email authors" button for latest reversion

* fix: Remove duplicate code, fix nav scrolling

* feat: Add RFCs to revision lists

* feat: Add pref option to control dependency inlining

* fix: Add analytical tags

* feat: Notify user of rendering inconsistencies

* feat: Split out bootstrap-icons when not inlining dependencies

* fix: Revision list and minor other fixes

* feat: Show stream logos when possible

* fix: Pick up CSS changes from https://github.com/martinthomson/rfc-txt-html

* chore: add debug script to replicate GitHub Actions test environment

* chore: cleanup from merge of main

* fix: Fix PDFixation crash due to referencing renamed CSS asset (#4665)

* fix: Rename some CSS classes to handle recent xml2rfc changes (#4791)

* Merge main

* fix: Rename some CSS classes to handle recent xml2rfc changes

Fixes #4784.

* chore: repair merge damage

* chore: more merge corrections

* chore: one more merge correction

* fix: npm dependencies

* fix: Change default font size (#4817)

* Fix dependency issues

* Cap fontsize at 12pt by default

Co-authored-by: Nicolas Giard <github@ngpixel.com>

Co-authored-by: Lars Eggert <lars@eggert.org>
Co-authored-by: Martin Thomson <mt@lowentropy.net>
Co-authored-by: Nicolas Giard <github@ngpixel.com>
2022-12-02 15:17:14 -06:00
Nicolas Giard d8db6e7102
ci: build workflow dynamic name (2) 2022-12-02 14:41:10 -05:00
Nicolas Giard 1ca716faf7
ci: build workflow dynamic name 2022-12-02 14:31:46 -05:00
Nicolas Giard 3c6a60e260
ci: build workflow dynamic name 2022-12-02 14:30:44 -05:00
Nicolas Giard 1e99f88c44
ci: update sandbox to dev.ietf.org 2022-12-01 18:04:18 -05:00
Nicolas Giard 507c6b1914
ci: always run slack notify 2022-12-01 01:20:38 -05:00
Jennifer Richards b8dbd65f76
fix: use consistent timezone for IDs in timeslot editor (#4813)
* test: be more careful with timezone arithmetic

Drops a test case (other day, other time) that was an unlikely corner
case. It was an easy check to include with the old code but is less
so with the rewrite.

* fix: use consistent timezone for IDs in timeslot editor

* chore: remove stray testing/debug code
2022-11-30 15:31:40 -06:00
Jennifer Richards e56135a30c
chore: apply patches as root inside celery container (#4803) 2022-11-29 13:25:39 -06:00
Robert Sparks 4e2f5d50f8
feat: add row of button-links to group meetings and meeting session views (#4774)
* refactor: clarify handling what groups looked like at past session times

* feat: add row of button-links to group meetings and meeting session views

* fix: remove unneeded `with` clause

* fix: replace missed instance of historic_parent reference

* fix: reflect that group_at_the_time always returns something

* chore: update copyright lines
2022-11-29 11:10:44 -06:00
Robert Sparks 0b3f9f5dc5
refactor: clarify handling what groups looked like at past session times (#4767)
* refactor: clarify handling what groups looked like at past session times

* fix: replace missed instance of historic_parent reference

* fix: reflect that group_at_the_time always returns something

* chore: update copyright lines
2022-11-29 11:08:16 -06:00
Nicolas Giard 6293e61287
ci: add missing build matrix config for test-playwright-legacy step 2022-11-28 18:15:39 -05:00
Lars Eggert d508a786ec
chore: Update deps and fix resulting HTML validation issues (#4790) 2022-11-28 11:46:04 -06:00
Lars Eggert f567b0c5af
fix: Don't show reorder UI fixtures unless user can reorder (#4785)
Fixes #4773

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-11-28 11:40:45 -06:00
Lars Eggert baaa8f15c2
feat: Only show IPR search form when not showing search results (#4793)
* feat: Only show IPR search form when not showing search results

Put it into a collapsible that is only expanded by default when not
showing search results.

Fixes #4569

* Don't use example target name
2022-11-28 10:39:43 -06:00
Lars Eggert 6eabd4a3a1
chore: Use codespell to fix typos in comments. (#4794)
First part of replacement of #4651
2022-11-28 10:36:36 -06:00
Robert Sparks 2636c59f99
feat: stop supporting pre-tzaware migration database dumps. (#4782)
* feat: stop supporting pre-tzaware migration database dumps.

* chore: remove unnecessary env variable
2022-11-28 10:17:22 -06:00
Lars Eggert cb2f4afc8b
fix: Ignore readonly on select (#4786)
This was caused by #4708
2022-11-23 15:03:13 -06:00
Nicolas Giard ae51096c65
fix: agenda meeting updated datetime (#4783)
* fix: agenda meeting updated datetime

* test: correct updated datetime format
2022-11-23 12:43:26 -06:00
Lars Eggert ba9f44093f
fix: Say when no IRSG ballots exist (#4788)
Fixes #4749
2022-11-23 10:01:02 -06:00
Lars Eggert 273b2fab98
fix: Float nomcom feedback form to the left (#4787)
Fixes #4770
2022-11-23 09:54:46 -06:00
Nicolas Giard a79e9ab571
ci: run pr tests on client file changes 2022-11-22 18:18:29 -05:00
Nicolas Giard 1acd348767
docs: add info for firefox root workaround in tests workflow 2022-11-22 17:54:19 -05:00
Nicolas Giard deb01f2d83
test: remove cypress + migrate existing tests to playwright (#4781)
* test: remove cypress + migrate existing tests to playwright + update workflows

* ci: remove leftover condition in ci-run-tests workflow

* ci: add missing matrix to tests-playwright-legacy

* ci: run playwright legacy as user 1001

* ci: set home var for firefox

* ci: allow firefox to run as root for tests
2022-11-22 16:26:19 -06:00
Nicolas Giard 72648dc01c
ci: replace set-output from deb db workflow 2022-11-18 19:53:47 -05:00
Nicolas Giard c864c90538
ci: update dev db workflow to latest actions 2022-11-18 19:52:07 -05:00
Nicolas Giard be5197c9bd
ci: update lock-threads workflow (2) 2022-11-17 15:22:00 -05:00
Nicolas Giard fa50b33812
ci: update lock-threads workflow 2022-11-17 15:14:55 -05:00
Nicolas Giard c405264811
ci: use from/to tags for changelog build action 2022-11-16 19:05:21 -05:00
Nicolas Giard 9579f6143c
ci: enable skipInvalidTags option in semver build action 2022-11-16 17:28:25 -05:00
Nicolas Giard 8b23be83d2
ci: build workflow explicit default values 2022-11-16 16:46:23 -05:00
Robert Sparks 41eafa2727
fix: Abstract code knowledge of the notes function away from specific implementations (#4761)
* fix: abstract codes knowledge of the note function away from specific implementations.

* refactor: make uses_notes a meeting's responsibility.
2022-11-15 14:10:13 -06:00
Jennifer Richards 3c2e004ab8
fix: use UTC for model_to_timeline_data() (#4763)
This changes the method to operate in UTC instead of server time.
The existing code was mixing UTC and server time, though, giving
timestamps purporting to be UTC but computed from the date in the
server timezone. To the extent that it matters, I think this change
is preferable to restoring the original behavior.
2022-11-15 13:02:09 -06:00
Jennifer Richards 8caa4ce0cc
fix: remove extra ':' after DTSTAMP in .ics templates (#4762) 2022-11-15 12:22:00 -06:00
Robert Sparks aefb5f1ca1
fix: use tzaware today while expiring drafts (#4759) 2022-11-15 10:02:31 -06:00
Jennifer Richards 0c458ef048
fix: make a few datetime manipulations timezone-aware (#4755)
* fix: set tz when passing a date to timesince_days filter

* fix: fill in tz for a constructed datetime in idindex/index.py

* test: simplify double-negatives in test assertions

* test: fix I-D expiration test cases to be tz aware

* fix: use tz-aware comparisons for in_draft_expire_freeze method

* test: fix tz used for timesince_days filter test case
2022-11-15 07:55:13 -06:00
Jennifer Richards 36bbc9bc08
test: increase number of tries to find tz not near midnight (#4756) 2022-11-15 07:53:21 -06:00
Jennifer Richards 611d732869
test: fix a couple tz problems in tests run soon after midnight UTC (#4757)
* test: fix tz problem in test_document_ballot() test

* test: fix tz problem in IprTests.test_notify() test

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-11-15 07:46:42 -06:00
Nicolas Giard cfda9892b2
ci: update build dev base version to 9.0.x 2022-11-14 19:42:58 -05:00
Robert Sparks 2c304d0364
feat: UI enhancements to allow control-click etc on the search results (provided by @kivinen - see #4747)
Fixes #4711 i.e., allows using control-click or context menu to open items in the top right search list to open multiple documents in different tabs.

Authored by @kivinen
2022-11-14 17:08:28 -06:00
Nicolas Giard 4c471983c3
ci: revert prod settings change when deploying to sandbox 2022-11-14 17:26:48 -05:00
Jennifer Richards 5e7debb8db
fix: supply tzinfo to datetime in iana-protocols-updates script (#4753) 2022-11-14 14:51:24 -06:00
Nicolas Giard 069c913817
ci: force set server mode to dev for sandbox deploy 2022-11-14 15:48:13 -05:00
Robert Sparks cdfe7ea4cf
feat!: Timezone aware database 2022-11-14 08:02:44 -06:00
Jennifer Richards eb41424ea4
test: permit multiple <h1> tags in a document (#4741) 2022-11-10 16:17:43 +00:00
Jennifer Richards e77419029a
test: validate HTML in own test case and report all results (#4740)
* ci: move HTML validation out of teardown so all failures are caught

Failures in the last batch were suppressed by the original implementation.

* test: rename template validation "test" so it is not auto-discovered

* test: run all HTML validation in a single batch at the end

Adds ~50 MB peak RAM usage during a full test run.

* test: refactor validation to collect failures of all kinds before exit
2022-11-10 16:17:00 +00:00