Commit graph

111 commits

Author SHA1 Message Date
Nicolas Giard bdf753e052
chore: set gitattributes for normalizing line endings (#8245)
* chore: add proper .gitattributes

* chore: normalize file endings

* chore: fix .gitattributes

* chore: normalize file endings (2)
2024-11-20 16:48:00 -06:00
Jennifer Richards 72954c24fc
chore: Add type annotations to satisfy linter (#5435) 2023-03-29 09:06:14 +09:00
Jennifer Richards 6b826fd985
refactor: Purge old migrations and update ci to build on a clean schema (#5431)
* refactor: Remove all existing migrations

* refactor: Create clean set of migrations

* chore: Skip check_statetype_slugs when DB is not yet populated

* fix: Do not cache active_groups_menu on module import

* fix: Do not patch timezone awareness out of oidc-provider

* refactor: Migrate to create postgres schema, only use pgloader for data

* ci: Use migration scripts from feat/pg-migrations branch

* Revert "ci: Use migration scripts from feat/pg-migrations branch"

This reverts commit c82f64c614241ccede4865a50d494725c8a47c15.

* ci: Run check before migrate

* fix: Remove redundant migration caused by merge error

* chore: Add casts/ALTER TABLEs to eliminate pgloader errors/warnings

* chore: Change schema name to match docker image assumptions

* chore: Clear out schema so we get a clean start in case of a retry
2023-03-28 18:06:07 +09:00
Lars Eggert 220be21998
chore: Use codespell to fix typos in code. (#4797)
* chore: Use codespell to fix typos in code.

Second part of replacement of #4651

@rjsparks, I probably need to revert some things here, and I also
still need to add that new migration - how do I do that?

* Revert migrations

* Migrate "Whitelisted" to "Allowlisted"

* TEST_COVERAGE_MASTER_FILE -> TEST_COVERAGE_MAIN_FILE

* Fix permissions

* Add suggestions from @jennifer-richards
2022-12-07 15:10:35 -06:00
Jean Mahoney ec9d122488
fix use of http URLs, fix #4702 (#4707) 2022-11-05 17:19:42 +00:00
Robert Sparks de3dbdca04
fix(nomcom-ui): Use pre instead of relying on now-missing pasted styling (#4658) 2022-10-28 10:58:38 -05:00
Robert Sparks 8e04feb498
fix: reference correct template in dbtemplate views (#4667) 2022-10-28 10:57:46 -05:00
Lars Eggert 3234f1a121
test: Validate HTML rendered during tests (#3782) 2022-04-07 13:30:38 -03:00
Lars Eggert eb5423d084
ci: Also check generated HTML with the "vnu" validator (#3682)
* ci: Also check generated HTML with the "vnu" validator

Because HTML Tidy apparently misses a bunch of errors.

* thead -> tbody

* More fixes

* More fixes

* Start checker in test runner
2022-03-21 12:50:23 -05:00
Lars Eggert 373b5dbbf4 More fixes.
- Legacy-Id: 19827
2022-01-10 08:41:20 +00:00
Lars Eggert a9738bc2b2 Many more changes related to tablesorter.
- Legacy-Id: 19702
2021-11-23 15:31:34 +00:00
Lars Eggert 6b7beb17bf panel -> card
- Legacy-Id: 19618
2021-11-10 12:59:12 +00:00
Lars Eggert 021ba39712 Reindent all templates with djhtml
- Legacy-Id: 19610
2021-11-10 09:41:11 +00:00
Lars Eggert 288b937ff5 django_bootstrap5 removed button/endbutton tags
- Legacy-Id: 19609
2021-11-10 09:35:10 +00:00
Lars Eggert df2565096d bootstrap3 -> django_bootstrap5
Only load the module, no other changes yet.
 - Legacy-Id: 19586
2021-11-09 14:09:28 +00:00
Robert Sparks b99eecc1ae Bring the factory-boy and Faker dependencies forward through some minor breaking changes. Stop using the deprecated fr_QC locale in Faker. Commit ready for merge.
- Legacy-Id: 19270
2021-08-03 22:22:35 +00:00
Henrik Levkowetz ac51f185bc Merged in [18446] from rcross@amsl.com:
Remove reference to old style exception attribute 'message'.
 - Legacy-Id: 18456
Note: SVN reference [18446] has been migrated to Git commit 6a2ed891eb
2020-09-01 13:03:04 +00:00
Ryan Cross 6a2ed891eb Remove reference to old style exception attribute 'message'. Commit ready for merge.
- Legacy-Id: 18446
2020-08-29 00:17:56 +00:00
Henrik Levkowetz 3e16da6591 Fixed an issue that could prevent error messages from docutils from propagating to the end user when editing RST templates.
- Legacy-Id: 18416
2020-08-25 22:46:03 +00:00
Henrik Levkowetz 57938b039d Converted many cases of plain-text 403 messages to use a properly styled page instead, with a login link when appropriate. Also changed some API endpoint 400 responses to a more correct 403.
- Legacy-Id: 18339
2020-08-06 10:59:52 +00:00
Henrik Levkowetz 6d7c5b52ee Django 2.0 conversion. Test suite passes, except for javascript tests.
- Legacy-Id: 17762
2020-05-08 13:07:07 +00:00
Henrik Levkowetz 9aeda11a29 Removed some Py2 compatibility decorators.
- Legacy-Id: 17673
2020-04-21 13:54:31 +00:00
Henrik Levkowetz 726fcbf27d Removed all __future__ imports.
- Legacy-Id: 17391
2020-03-05 23:53:42 +00:00
Henrik Levkowetz a33f9724af Merged in [17201] from rjsparks@nostrum.com:
Make it easier for the nomcom chair to manage generic IESG requirements. Fixes #2794.
 - Legacy-Id: 17216
Note: SVN reference [17201] has been migrated to Git commit c9d944b312
2020-01-10 16:16:31 +00:00
Robert Sparks c9d944b312 Make it easier for the nomcom chair to manage generic IESG requirements. Fixes #2794. Commit ready for merge.
- Legacy-Id: 17201
2020-01-08 19:51:14 +00:00
Robert Sparks 38e73b6f89 Change the default template for assigned review emails to name the assigned reviewer. Fixes #2830. Commit ready for merge.
- Legacy-Id: 17062
2019-11-19 21:27:23 +00:00
Henrik Levkowetz b7724c43d7 Changed some # type: ignore statements to work with the latest mypy
- Legacy-Id: 16968
2019-11-05 22:41:18 +00:00
Henrik Levkowetz 09c34fa131 Merged in [16921] from sasha@dashcare.nl:
Fix #2123 - Use a DBTemplate when a review assignment is mailed.
The message sent to a reviewer when a new review is assigned to them,
is now taken from a DBTemplate, allowing it to be customised
per team. This includes a migration to create a default template,
which looks the same as before.
 - Legacy-Id: 16928
Note: SVN reference [16921] has been migrated to Git commit 9df5839874
2019-10-26 15:16:18 +00:00
Sasha Romijn 9df5839874 Fix #2123 - Use a DBTemplate when a review assignment is mailed.
The message sent to a reviewer when a new review is assigned to them,
is now taken from a DBTemplate, allowing it to be customised
per team. This includes a migration to create a default template,
which looks the same as before.

Commit ready for merge.
 - Legacy-Id: 16921
2019-10-23 16:06:44 +00:00
Henrik Levkowetz 97be7f31ea Merged in [16895] from sasha@dashcare.nl:
Fix #2526 - List previous reviews in assignments email.
This includes a migration to update the database templates. Note that
not all templates currently included them (secdir at least), and
previous reviews are only listed in templates that included */** before.
As before, previous reviews are only included if they are done by the
same reviewer(s) as the current assignment.
This also fixes a bug in database template 182
(/group/defaults/email/open_assignments.txt) which referred to 
r.review_request..doc.rev and r.review_request..requested_rev
in the template, and updates the test to use the current version of
template 182.
 - Legacy-Id: 16911
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0
2019-10-22 22:09:08 +00:00
Sasha Romijn ef1e8006f0 Fix #2526 - List previous reviews in assignments email.
This includes a migration to update the database templates. Note that
not all templates currently included them (secdir at least), and
previous reviews are only listed in templates that included */** before.

As before, previous reviews are only included if they are done by the
same reviewer(s) as the current assignment.

This also fixes a bug in database template 182
(/group/defaults/email/open_assignments.txt) which referred to 
r.review_request..doc.rev and r.review_request..requested_rev
in the template, and updates the test to use the current version of
template 182.

Commit ready for merge.
 - Legacy-Id: 16895
2019-10-21 19:11:56 +00:00
Henrik Levkowetz 902f7769d1 Fixed incorrect type hints for Migration.dependencies.
- Legacy-Id: 16776
2019-09-30 16:25:58 +00:00
Henrik Levkowetz 33e8733b91 Fixed up mypy issues or added type:ignore comments as needed for a clean mypy run.
- Legacy-Id: 16772
2019-09-30 15:42:18 +00:00
Henrik Levkowetz ea8c84d2f6 Python2/3 compatibility: used @python_2_unicode_compatible to provide __unicode__() versions of __str__() methods.
- Legacy-Id: 16455
2019-07-15 18:01:26 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3
- Legacy-Id: 16446
2019-07-15 15:40:51 +00:00
Henrik Levkowetz 484dcece5f Changed all model __unicode__() methods to __str__()
- Legacy-Id: 16330
2019-06-28 21:07:08 +00:00
Henrik Levkowetz 218f6d86a6 Replaced smart_unicode() with smart_text()
- Legacy-Id: 16311
2019-06-27 18:04:50 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates.
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz 7270d5f67a Added the option to order API resource lists by primary key, for stable ordering when paging through a list.
- Legacy-Id: 16284
2019-06-18 12:40:19 +00:00
Henrik Levkowetz 8726e74709 Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself.
- Legacy-Id: 16177
2019-04-30 16:54:06 +00:00
Henrik Levkowetz bb4fe3fbbf Undid previous commit
- Legacy-Id: 16153
2019-04-22 19:22:42 +00:00
Henrik Levkowetz cfcefc2e32 Merged in [16144] from housley@vigilsec.com:
Remove some clutter from I-D upload page.  The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes #2057.
 - Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
2019-04-22 17:39:26 +00:00
Henrik Levkowetz f54d6cd23d Merged in [16092] from rcross@amsl.com:
Remove ability to cancel a break session.  Fixes #2703.
 - Legacy-Id: 16105
Note: SVN reference [16092] has been migrated to Git commit b5850d5c7f
2019-03-26 15:53:41 +00:00
Henrik Levkowetz a60ac983d7 Added dbtemplate validation to the class, to make sure one cannot enter invalid DBtemplates through the admin.
- Legacy-Id: 16100
2019-03-25 10:03:46 +00:00
Robert Sparks a4db66564c Checkpoint. Ended up chasing group.views_review before stats.
- Legacy-Id: 16030
2019-03-13 22:02:10 +00:00
Robert Sparks b85052fe63 Checkpoint. Lots of tests will still fail. Reordered some migrations. Brought about half of the ietf.doc.views_review views into line with the new models. Next step is the other half.
- Legacy-Id: 16012
2019-03-07 23:08:14 +00:00
Henrik Levkowetz 1389775488 Added some missing migrations.
- Legacy-Id: 14696
2018-02-25 20:06:50 +00:00
Henrik Levkowetz a4768bb514 Removed unused imports. Added some explicit orderings to avoid pagination issues.
- Legacy-Id: 14664
2018-02-21 23:54:31 +00:00
Henrik Levkowetz 06362ec046 Got rid of old migrations and created new initial migrations.
- Legacy-Id: 14662
2018-02-21 23:46:22 +00:00
Henrik Levkowetz 5638cf3da3 Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models.
- Legacy-Id: 14661
2018-02-20 15:36:05 +00:00