Commit graph

211 commits

Author SHA1 Message Date
Lars Eggert c09fd9dad2
chore: Use URL resolver in more places (#4104)
* chore: Use URL resolver more

* Use settings.IDTRACKER_BASE_URL

* More fixes

* Use URL resolver for things under /accounts

* Use URL resolver for things under /stream

* Use URL resolver for things under /iesg

* Use URL resolver for things under /meeting

* Fix bugs

* Use URL resolver for things under /help

* Use URL resolver for things under /ipr

* More changes

* Revert vnu.jar

* Fix typos

* Address review comments by @rjsparks

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-06-22 14:10:16 -05:00
Lars Eggert cfa0886343
fix: Make the IPR search form work when enter is pressed (#4114) 2022-06-22 11:59:32 -05:00
Lars Eggert 63d80bff4c
chore: Remove various unused template tags (#4101)
* chore: Remove various unused template tags

* Replace rfcnospace with parameterized prettystdname

* Use URL resolver

* Use the URL resolver more
2022-06-21 14:05:02 -05:00
Lars Eggert 6e97628a64
fix(ui): badge -> badge rounded-pill (#4076)
* ui: badge -> badge rounded-pill

To make badges look a little less like small buttons.

* Rip out copy&paste error
2022-06-15 13:43:49 -05:00
Lars Eggert 5f8d4ed718
More HTML nitfixing (#3934)
* Unicode messages are triggered by both db content and tests

* Make ids unique

* Avoid "No value found" message on page

* Strip HTML from history entries, it's often broken

* Check HTML sources for occurrences of "** No value found for" and fix them

* Fix another occurrence of "** No value found for"

* Fix more occurrences of "** No value found for"

* Fix document revision stripping

* Force breaks of long (garbage) words

* Check URL validity before urlizing them

* Handle some additional corner cases

* Linkify action items

* Don't create profile/email links for System

* Handle headings with HTML elements in them better

* Fix comment

* Fix another occurrence of "** No value found for"

* Better I-D URLization that handles more edge cases. Also, test for them.

* Remove print

* Handle charters better

* Cache for one day
2022-05-10 12:37:14 -05:00
Lars Eggert 5598762608
fix: add more HTML validation & fixes (#3891)
* Update vnu.jar

* Fix py2 -> py3 issue

* Run pyupgrade

* test: Add default-jdk to images

* test: Add option to also validate HTML with vnu.jar

Since it's already installed in bin. Don't do this by default, since it
increases the time needed for tests by ~50%.

* fix: Stop the urlizer from urlizing in linkified mailto: text

* More HTML fixes

* More HTML validation fixes

* And more HTML fixes

* Fix floating badge

* Ignore unicode errors

* Only URLize docs that are existing

* Final fixes

* Don't URLize everything during test-crawl

* Feed HTML into vnu using python rather than Java to speed things up

* Allow test-crawl to start vnu on a different port

* Increase retry count to vnu. Restore batch size to 30.

* More HTML validation fixes

* Use urllib3 to make requests to vnu, since overriding requests_mock is tricky

* Undo commit of unmodified file

* Also urlize ftp links

* Fix matching of file name

* More HTML fixes

* Add `is_valid_url` filter

* weekday -> data-weekday

* urlencode URLs

* Add and use vnu_fmt_message. Bump vnu max buffer.

* Simplify doc_exists

* Don't add tab link to mail archive if the URL is invalid

* Run urlize_ietf_docs before linkify

Reduces the possibility of generating incorrect HTML

* Undo superfluous change

* Runner fixes

* Consolidate vnu message filtering into vnu_filter_message

* Correctly handle multiple persons with same name

* Minimze diff

* Fix HTML nits

* Print source snippet in vnu_fmt_message

* Only escape if there is something to escape

* Fix snippet

* Skip crufty old IPR declarations

* Only include modal when needed. Add handles.

* Fix wordwrap+linkification

* Update ietf/doc/templatetags/ietf_filters.py

* Update ietf/doc/templatetags/tests_ietf_filters.py

* Don't right-align second column
2022-05-03 13:55:48 -05:00
Lars Eggert 19e639f779
fix: .visually-hidden -> .d-none (#3800)
In bs5, `.visually-hidden` is the equivalent of bs3's `.sr-only`, i.e., it's
still shown on screen readers, which is not what we want. Use `.d-none` instead,
which is the equivalent of bs3's `.hidden`.
2022-04-08 14:53:56 -03:00
Lars Eggert 3234f1a121
test: Validate HTML rendered during tests (#3782) 2022-04-07 13:30:38 -03:00
Lars Eggert 870fed030f
fix: More fixes for narrow screens (#3662)
* fix: More fixes for narrow screens

Need to keep checking for issues, there are more.

* Make columns more narrow on narrow screens

* More fixes

* More fixes

* Test fixes

* Fix more tests

* Close tbody
2022-03-24 12:40:48 -03:00
Lars Eggert eb5423d084
ci: Also check generated HTML with the "vnu" validator (#3682)
* ci: Also check generated HTML with the "vnu" validator

Because HTML Tidy apparently misses a bunch of errors.

* thead -> tbody

* More fixes

* More fixes

* Start checker in test runner
2022-03-21 12:50:23 -05:00
Lars Eggert 1795609816 Some more cosmetic tweaks.
- Legacy-Id: 19914
2022-02-09 14:17:11 +00:00
Lars Eggert bbf088e18b Hopefully the final check-ins.
- Legacy-Id: 19909
2022-02-08 17:29:15 +00:00
Lars Eggert ed30521e14 Many more HTML fixes.
- Legacy-Id: 19908
2022-02-03 07:49:34 +00:00
Lars Eggert a507b31669 More nits fixed.
- Legacy-Id: 19903
2022-02-01 08:29:55 +00:00
Lars Eggert 53089a94f6 And more fixes.
- Legacy-Id: 19902
2022-02-01 07:47:25 +00:00
Lars Eggert 9c05373699 More fixes.
- Legacy-Id: 19856
2022-01-18 20:04:55 +00:00
Lars Eggert 0bfaa63722 More fixes.
- Legacy-Id: 19855
2022-01-17 15:05:22 +00:00
Lars Eggert 6ca6c35186 More fixes.
- Legacy-Id: 19829
2022-01-11 15:02:27 +00:00
Lars Eggert 8bc7fde027 More fixes.
- Legacy-Id: 19828
2022-01-11 07:02:39 +00:00
Lars Eggert 373b5dbbf4 More fixes.
- Legacy-Id: 19827
2022-01-10 08:41:20 +00:00
Lars Eggert 6fa5fa073e More fixes.
- Legacy-Id: 19812
2022-01-06 12:26:10 +00:00
Lars Eggert c68446ae93 More select2 and test fixes.
- Legacy-Id: 19781
2021-12-14 18:19:12 +00:00
Lars Eggert f974fd3c04 Fix more things
- Legacy-Id: 19762
2021-12-09 06:41:00 +00:00
Lars Eggert 448c6dbe9e And more bs5 stuff
- Legacy-Id: 19717
2021-12-01 13:52:50 +00:00
Lars Eggert 9e038d3e98 Bring back some additional js dependencies.
- Legacy-Id: 19707
2021-11-24 14:32:35 +00:00
Lars Eggert a189b51b30 More template changes.
- Legacy-Id: 19706
2021-11-24 13:15:11 +00:00
Lars Eggert a9738bc2b2 Many more changes related to tablesorter.
- Legacy-Id: 19702
2021-11-23 15:31:34 +00:00
Lars Eggert a114ad9ecc More agenda fixes.
- Legacy-Id: 19674
2021-11-17 12:56:09 +00:00
Lars Eggert a8764f225f Track CSS class name changes in bs5.
- Legacy-Id: 19663
2021-11-15 16:49:09 +00:00
Lars Eggert f17a7eddd4 pull-right -> float-end
- Legacy-Id: 19613
2021-11-10 09:57:57 +00:00
Lars Eggert 021ba39712 Reindent all templates with djhtml
- Legacy-Id: 19610
2021-11-10 09:41:11 +00:00
Lars Eggert 288b937ff5 django_bootstrap5 removed button/endbutton tags
- Legacy-Id: 19609
2021-11-10 09:35:10 +00:00
Lars Eggert 726b29bf74 fontawesome -> bootstrap-icons
- Legacy-Id: 19608
2021-11-10 09:28:38 +00:00
Lars Eggert 1d559374ec Replace glyphicons with bootstrap-icons.
- Legacy-Id: 19607
2021-11-10 08:08:02 +00:00
Lars Eggert 94b12af9da btn-default -> btn-primary
- Legacy-Id: 19606
2021-11-10 07:54:58 +00:00
Lars Eggert 6b15c3de95 Fix nav-tabs
- Legacy-Id: 19593
2021-11-09 17:20:28 +00:00
Lars Eggert 9cf29baf5b table-condensed -> table-sm
- Legacy-Id: 19589
2021-11-09 14:21:05 +00:00
Lars Eggert 39d500de8f tablesorter -> datatables
https://datatables.net/ has way more features and better support, and bootstrap5
styling.
 - Legacy-Id: 19587
2021-11-09 14:16:13 +00:00
Lars Eggert df2565096d bootstrap3 -> django_bootstrap5
Only load the module, no other changes yet.
 - Legacy-Id: 19586
2021-11-09 14:09:28 +00:00
Robert Sparks f4ebe39e87 Adjust the IPR declaration submission form to remove the line about limiting the declaration solely to stardards-track IETF documents. Commit ready to merge.
- Legacy-Id: 19454
2021-10-25 17:08:30 +00:00
Jennifer Richards 17d37723f7 Consolidate repeated searchable field code into SearchableField class. Fix single-valued searchable fields. Make javascript test config reusable. Use Django Form.media for JS/CSS inclusion. Fixes #3196, #3204. Commit ready for merge.
- Legacy-Id: 18939
2021-04-09 15:18:11 +00:00
Robert Sparks 8fe779cac3 Template condition tweak
- Legacy-Id: 18887
2021-03-03 20:45:35 +00:00
Robert Sparks 550c1233fe Change ipr pages to say General rather than Generic, and to change the text to note email submissions are not accepted. Fixes #3209. Commit ready for merge.
- Legacy-Id: 18886
2021-03-03 20:15:57 +00:00
Henrik Levkowetz 93e07f8650 Changed deprecated 'load staticfiles' to recommended 'load static'
- Legacy-Id: 18080
2020-06-27 13:51:19 +00:00
Henrik Levkowetz f8760cdf6f In IPR disclosure statement updates, don't show links to parked IPR declarations, since they will 404.
- Legacy-Id: 17691
2020-04-26 11:04:16 +00:00
Henrik Levkowetz a4e49d8ec0 Merged in [16853] from rjsparks@nostrum.com:
Add submitted and posted dates to several ipr notification email messages. Fixes #2807.
 - Legacy-Id: 16899
Note: SVN reference [16853] has been migrated to Git commit f39d1568f0c4a8f4b1ebd3dee887fff6b3d8049b
2019-10-22 12:23:07 +00:00
Henrik Levkowetz 1ea89276ce Merged in [16558] from rjsparks@nostrum.com:
Make removed IPR disclosures visually distinctive on search results. Partially addresses #2687.
 - Legacy-Id: 16585
Note: SVN reference [16558] has been migrated to Git commit b4a27c59164d13a0840d285532355e0af696be33
2019-07-24 19:04:45 +00:00
Henrik Levkowetz 13c69a1a55 Turned off html autoescape in IPR email templates.
- Legacy-Id: 16423
2019-07-07 13:14:42 +00:00
Henrik Levkowetz 84a80e99a8 Fixed bad logic for the display of previous related IPR informatio in the IPR details template.
- Legacy-Id: 16291
2019-06-19 15:05:59 +00:00
Henrik Levkowetz 8e6eb3068a Builds on [16168]. Removed additional instances of links to unposted IPR disclosures that would result in 404 pages.
- Legacy-Id: 16212
Note: SVN reference [16168] has been migrated to Git commit 17db4cd4a4
2019-05-16 19:43:25 +00:00