Commit graph

372 commits

Author SHA1 Message Date
Lars Eggert 58b4649aef
fix: Show Zulip room URL (#4296). Fixes #4269 2022-07-29 15:42:07 -05:00
Justin Iurman b1aecf9525
fix: dates alignment in group/review_requests (#4268)
Remove "-date" from data-sort fields for all dates, so that all columns
are now much better aligned.

Note: did not find an opened issue related to this after a quick search.
2022-07-26 11:23:44 -05:00
Justin Iurman f58033e36f
fix: closed review request "by (System)" (#4255)
Only display the user in the "Requested" column if it's a real human
(i.e., not "System").

Fix #3687
2022-07-24 07:28:06 -05:00
Lars Eggert e465f1f0f0
feat: Replace graphviz with d3 (#4067)
* feat: Use d3 for doc dependencies

* Interim commit

* Progress

* Progress

* Auto pan and zoom

* Arrows

* Remove graphviz and the code that uses it

* More graphviz-related changes

* Interim commit

* Move things into place

* Add test

* Final touches

* Make SVG work in Chrome

* Get the docs more similarly to how the group doc page does it

* Reindent

* Add ability to download the SVG, and use bs fonts.

* Follow @rjsparks' advice on how to compute the reference list

* Interim commit

* Add legend

* Speed up simulation

* Fix tooltips

* fix: escape a period in a new url regex

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-07-21 12:14:45 -05:00
Robert Sparks 6ed4ea0f93
feat: point to Zulip chat rather than jabber. (#4218)
* feat: point to Zulip chat rather than jabber.

* fix: Address review comments from Jennifer and Nick
2022-07-15 13:48:54 -05:00
Lars Eggert c09fd9dad2
chore: Use URL resolver in more places (#4104)
* chore: Use URL resolver more

* Use settings.IDTRACKER_BASE_URL

* More fixes

* Use URL resolver for things under /accounts

* Use URL resolver for things under /stream

* Use URL resolver for things under /iesg

* Use URL resolver for things under /meeting

* Fix bugs

* Use URL resolver for things under /help

* Use URL resolver for things under /ipr

* More changes

* Revert vnu.jar

* Fix typos

* Address review comments by @rjsparks

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-06-22 14:10:16 -05:00
Lars Eggert d06219388f
fix: Remove stray space from end of href (#4113)
This caused the testcrawl to fail, because the new icons were a 404. Also
fix some similar stray spaces in some other tags.
2022-06-22 12:00:54 -05:00
Lars Eggert 6e97628a64
fix(ui): badge -> badge rounded-pill (#4076)
* ui: badge -> badge rounded-pill

To make badges look a little less like small buttons.

* Rip out copy&paste error
2022-06-15 13:43:49 -05:00
Lars Eggert 3d9310818b
fix: Don't allow sorting milestone by order if group doesn't use dates (#4074)
Fixes #4072
2022-06-13 11:08:23 -05:00
Robert Sparks 2f4b493575
fix: Don't show To Subscribe on group about when there's no url to subscribe with. Fixes #4022. (#4023) 2022-05-25 14:52:44 -05:00
Robert Sparks c89f7c89c5
feat: begin supporting the new rfc editor model (#3960)
* feat: restructure rfcedtype groups. add rpc, rswg, rsab.

* feat: show rfc editor groups on menu

* feat: add the editorial stream

* fix: repair broken html and extent dest coverage.

* chore: address Lars review comment

* chore: update copyright notices.
2022-05-20 12:22:17 -05:00
Lars Eggert 8ef92312d0
fix: Don't urlencode all resource URLs (#3988)
While this does suppress errors, it breaks even valid URLs. Instead, just
suppress the validation error for those few cases in the database.
2022-05-19 12:31:29 -05:00
Lars Eggert de7ff7e84e
test: fix more validation issues (#3975)
* fix: Avoid numeric IDs on NomCom pages

* fix: Correctly group last names with lowercase/i18n parts

* Remove some unneeded CSS

* fix: Remove extra div closing tag
2022-05-18 10:58:39 -05:00
Lars Eggert 5f8d4ed718
More HTML nitfixing (#3934)
* Unicode messages are triggered by both db content and tests

* Make ids unique

* Avoid "No value found" message on page

* Strip HTML from history entries, it's often broken

* Check HTML sources for occurrences of "** No value found for" and fix them

* Fix another occurrence of "** No value found for"

* Fix more occurrences of "** No value found for"

* Fix document revision stripping

* Force breaks of long (garbage) words

* Check URL validity before urlizing them

* Handle some additional corner cases

* Linkify action items

* Don't create profile/email links for System

* Handle headings with HTML elements in them better

* Fix comment

* Fix another occurrence of "** No value found for"

* Better I-D URLization that handles more edge cases. Also, test for them.

* Remove print

* Handle charters better

* Cache for one day
2022-05-10 12:37:14 -05:00
Lars Eggert 5598762608
fix: add more HTML validation & fixes (#3891)
* Update vnu.jar

* Fix py2 -> py3 issue

* Run pyupgrade

* test: Add default-jdk to images

* test: Add option to also validate HTML with vnu.jar

Since it's already installed in bin. Don't do this by default, since it
increases the time needed for tests by ~50%.

* fix: Stop the urlizer from urlizing in linkified mailto: text

* More HTML fixes

* More HTML validation fixes

* And more HTML fixes

* Fix floating badge

* Ignore unicode errors

* Only URLize docs that are existing

* Final fixes

* Don't URLize everything during test-crawl

* Feed HTML into vnu using python rather than Java to speed things up

* Allow test-crawl to start vnu on a different port

* Increase retry count to vnu. Restore batch size to 30.

* More HTML validation fixes

* Use urllib3 to make requests to vnu, since overriding requests_mock is tricky

* Undo commit of unmodified file

* Also urlize ftp links

* Fix matching of file name

* More HTML fixes

* Add `is_valid_url` filter

* weekday -> data-weekday

* urlencode URLs

* Add and use vnu_fmt_message. Bump vnu max buffer.

* Simplify doc_exists

* Don't add tab link to mail archive if the URL is invalid

* Run urlize_ietf_docs before linkify

Reduces the possibility of generating incorrect HTML

* Undo superfluous change

* Runner fixes

* Consolidate vnu message filtering into vnu_filter_message

* Correctly handle multiple persons with same name

* Minimze diff

* Fix HTML nits

* Print source snippet in vnu_fmt_message

* Only escape if there is something to escape

* Fix snippet

* Skip crufty old IPR declarations

* Only include modal when needed. Add handles.

* Fix wordwrap+linkification

* Update ietf/doc/templatetags/ietf_filters.py

* Update ietf/doc/templatetags/tests_ietf_filters.py

* Don't right-align second column
2022-05-03 13:55:48 -05:00
Lars Eggert f8c06fa5cf
fix: Use unique data-sort attributes (#3836)
* fix: Use unique `data-sort` attributes

So list.js properly sorts columns.

* Address @rjsparks' comments
2022-04-19 10:16:32 -05:00
Lars Eggert 09a898e88e
fix: Improve the layout of the photo pages (#3807) 2022-04-12 12:02:16 -03:00
Lars Eggert 19e639f779
fix: .visually-hidden -> .d-none (#3800)
In bs5, `.visually-hidden` is the equivalent of bs3's `.sr-only`, i.e., it's
still shown on screen readers, which is not what we want. Use `.d-none` instead,
which is the equivalent of bs3's `.hidden`.
2022-04-08 14:53:56 -03:00
Lars Eggert 3234f1a121
test: Validate HTML rendered during tests (#3782) 2022-04-07 13:30:38 -03:00
Jennifer Richards db254f7a48
fix: tweak review assignment tooltips and control row height (#3788) 2022-04-07 09:48:23 -03:00
Robert Sparks 6867b1b667
fix: put unassigned review assignment contols on one small line (#3780) 2022-04-06 14:05:37 -03:00
Jennifer Richards 3865c4bc9c
fix: restore function of unassigned review management page (#3774)
* style: reformat manage-review-requests.js as StandardJS style

* refactor: use switch statement instead of if/else-if/else

* style: remove needless line break

* fix: fix jquery selectors to be less fragile and easier to read

* fix: clean up bs5 HTML/CSS for review request buttons
2022-04-01 17:42:12 -03:00
Robert Sparks cb4a288ab6
fix: separate tables on team review page. Fixes #3679. (#3770) 2022-03-30 18:42:29 -03:00
Robert Sparks 1d8746cd63
fix: add tooltips to calendar icons on group meeting pages. Fixes #3695. (#3767) 2022-03-30 18:37:29 -03:00
Robert Sparks eaf1f01e4d
fix: point wg about pages directly to jabber archives. Fixes #3462 and #3368. (#3750) 2022-03-25 13:48:47 -03:00
Lars Eggert 870fed030f
fix: More fixes for narrow screens (#3662)
* fix: More fixes for narrow screens

Need to keep checking for issues, there are more.

* Make columns more narrow on narrow screens

* More fixes

* More fixes

* Test fixes

* Fix more tests

* Close tbody
2022-03-24 12:40:48 -03:00
Lars Eggert eb5423d084
ci: Also check generated HTML with the "vnu" validator (#3682)
* ci: Also check generated HTML with the "vnu" validator

Because HTML Tidy apparently misses a bunch of errors.

* thead -> tbody

* More fixes

* More fixes

* Start checker in test runner
2022-03-21 12:50:23 -05:00
Tero Kivinen 311bbf8826
fix: Fix the doc_name to have class text-nowrap as we want to keep the entries in one line if possible. (#3683) 2022-03-19 11:56:22 -05:00
Lars Eggert fd8d9762f2
fix: Use fixed lengths for the first three columns of "meta" tables (#3637)
Fixes #3615.
2022-03-14 11:32:28 -05:00
Jennifer Richards 6c260a5b7e Merge 7.45.1.dev0 into Bootstrap 5 update branch. Made a first pass at reconciling differences.
- Legacy-Id: 19945
2022-02-17 20:09:49 +00:00
Robert Sparks fa952976ab Simplify search for link back to group from the review management view. Commit ready for merge.
- Legacy-Id: 19915
2022-02-09 17:25:43 +00:00
Lars Eggert 1795609816 Some more cosmetic tweaks.
- Legacy-Id: 19914
2022-02-09 14:17:11 +00:00
Lars Eggert bbf088e18b Hopefully the final check-ins.
- Legacy-Id: 19909
2022-02-08 17:29:15 +00:00
Lars Eggert ed30521e14 Many more HTML fixes.
- Legacy-Id: 19908
2022-02-03 07:49:34 +00:00
Lars Eggert 64d2ba2558 Run tidy as part of tests, and fix HTML issues it finds.
- Legacy-Id: 19904
2022-02-01 16:11:34 +00:00
Lars Eggert a507b31669 More nits fixed.
- Legacy-Id: 19903
2022-02-01 08:29:55 +00:00
Lars Eggert 53089a94f6 And more fixes.
- Legacy-Id: 19902
2022-02-01 07:47:25 +00:00
Lars Eggert 335a39d4fc More fixes.
- Legacy-Id: 19884
2022-01-28 13:00:47 +00:00
Lars Eggert cf629a42ad And more fixes.
- Legacy-Id: 19877
2022-01-25 10:14:25 +00:00
Lars Eggert 9c05373699 More fixes.
- Legacy-Id: 19856
2022-01-18 20:04:55 +00:00
Lars Eggert 0bfaa63722 More fixes.
- Legacy-Id: 19855
2022-01-17 15:05:22 +00:00
Jennifer Richards d4dbb1bc1f Allow editing of group non-chartered group descriptions through UI. Fixes #3388. Commit ready for merge.
- Legacy-Id: 19838
2022-01-12 21:04:13 +00:00
Lars Eggert edf3242665 More fixes.
- Legacy-Id: 19836
2022-01-12 18:37:18 +00:00
Lars Eggert a5cbf5307e More fixes
- Legacy-Id: 19835
2022-01-12 11:54:00 +00:00
Lars Eggert 6ca6c35186 More fixes.
- Legacy-Id: 19829
2022-01-11 15:02:27 +00:00
Lars Eggert 8bc7fde027 More fixes.
- Legacy-Id: 19828
2022-01-11 07:02:39 +00:00
Lars Eggert 373b5dbbf4 More fixes.
- Legacy-Id: 19827
2022-01-10 08:41:20 +00:00
Lars Eggert 6fa5fa073e More fixes.
- Legacy-Id: 19812
2022-01-06 12:26:10 +00:00
Lars Eggert 5132661b06 More test fixes
- Legacy-Id: 19803
2022-01-05 11:25:25 +00:00
Lars Eggert 7f918b00da More test fixes
- Legacy-Id: 19784
2021-12-15 20:38:28 +00:00