Reviewers can set this flag in their reviewer settings, which triggers
a mail to be sent to the secretary. They are then kept on top of the
recommended assignment order. This flag is automatically reset when any
assignment is made to the reviewer.
- Legacy-Id: 17048
one to set how many days to include in the reviewers list, and
another one to limit the number of completed items in the list for
each person. This version replaces the one I did earlier, and includes
much more test cases to test different limits on the reviewers page.
Commit ready for merge.
- Legacy-Id: 17034
Fix#2119 - Allow specifying review type for suggested reviews in LC and telechat
If a review is suggested on the 'manage unassigned reviews' page, and
the document is in both last call and telechat, the assign form now asks
for the type of review that should be assigned.
This commit also fixes two bugs in this process:
- Comparisons in some cases between strings and integers
(group/views.py:1485/1487)
- Rejections when assigning suggested reviews, as they could be
considered a newly opened request due to not having a pk
(group/views.py:1508)
- Legacy-Id: 16951
Note: SVN reference [16933] has been migrated to Git commit ee4bc0cb07
Flipped a sense to put the grace period on the right side of 'today' when sending review overdue reminders to team secretaries. Fixes#2816.
- Legacy-Id: 16940
Note: SVN reference [16926] has been migrated to Git commit 7560e116bf
If a review is suggested on the "manage unassigned reviews" page, and
the document is in both last call and telechat, the assign form now asks
for the type of review that should be assigned.
This commit also fixes two bugs in this process:
- Comparisons in some cases between strings and integers
(group/views.py:1485/1487)
- Rejections when assigning suggested reviews, as they could be
considered a newly opened request due to not having a pk
(group/views.py:1508)
Commit ready for merge.
- Legacy-Id: 16933
Fix#2217 - Allow submission of unsolicited reviews by secretaries.
- For team secretaries, a button 'Submit unsolicited review' will now
appear next to 'Request review' on the document's main page.
- If the secretary is a secretary for multiple teams, they are taken
through an intermediate page to select for which team they are
submitting their review.
- The form is similar (and using the same code) as the usual review
completion, with a few extra fields for the review type and reviewer,
which would usually already be known.
- When submitting the review, a ReviewRequest and ReviewAssignment are
automatically created. The assignment is then immediately closed in
the usual way.
- Other workflows are unchanged.
The issues with the review form in #2061 are slightly worse for the
unsolicited review scenario, but that will be improved when #2061 is
fixed.
- Legacy-Id: 16932
Note: SVN reference [16924] has been migrated to Git commit 871a4b653b
Fix#2123 - Use a DBTemplate when a review assignment is mailed.
The message sent to a reviewer when a new review is assigned to them,
is now taken from a DBTemplate, allowing it to be customised
per team. This includes a migration to create a default template,
which looks the same as before.
- Legacy-Id: 16928
Note: SVN reference [16921] has been migrated to Git commit 9df5839874
- For team secretaries, a button "Submit unsolicited review" will now
appear next to "Request review" on the document's main page.
- If the secretary is a secretary for multiple teams, they are taken
through an intermediate page to select for which team they are
submitting their review.
- The form is similar (and using the same code) as the usual review
completion, with a few extra fields for the review type and reviewer,
which would usually already be known.
- When submitting the review, a ReviewRequest and ReviewAssignment are
automatically created. The assignment is then immediately closed in
the usual way.
- Other workflows are unchanged.
The issues with the review form in #2061 are slightly worse for the
unsolicited review scenario, but that will be improved when #2061 is
fixed.
Commit ready for merge.
- Legacy-Id: 16924
The message sent to a reviewer when a new review is assigned to them,
is now taken from a DBTemplate, allowing it to be customised
per team. This includes a migration to create a default template,
which looks the same as before.
Commit ready for merge.
- Legacy-Id: 16921
Fix#2198 - Set default start date for UnavailabilityPeriod to today.
- Legacy-Id: 16910
Note: SVN reference [16891] has been migrated to Git commit a7a2ee4a39
Remove some pre-ReviewAssignment refactor logic, and simplify what remains while still allowing a group secretary to not assign a row on the unassigned requests form after touching the control to assign a reviewer. Fixes#2812.
- Legacy-Id: 16900
Note: SVN reference [16854] has been migrated to Git commit b158807134e2d26b3e013b6414b6fcbaa0e39f77
Fix#2186 - Return review req to 'requested' status if no review assignments are open.
If a review assignment is rejected, withdrawn, marked no response, etc.,
and this leaves a review request without any assigned/accepted/completed
review assignments, return the request state to 'requested', which means
it will be shown as an unassigned review in all interfaces.
- Legacy-Id: 16881
Note: SVN reference [16819] has been migrated to Git commit fdb4c2a055
Fix#2475 - Send opt-in reminders for unconfirmed review assignments.
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.
- Legacy-Id: 16846
Note: SVN reference [16792] has been migrated to Git commit 486b6daa29
Add migration intended for r16770. Related to #2782.
- Legacy-Id: 16842
Note: SVN reference [16771] has been migrated to Git commit f3fb0f8c20941710d675ca4bb2873635c2fa8624
Refs #2277 - Send daily reminders of overdue reviews to secretaries
- Legacy-Id: 16839
Note: SVN reference [16765] has been migrated to Git commit cc64992204
Fix#2337 - Send periodic reminders of open reviews every X days (opt-in)
The interleaved_migrations_test currently fails due to the various
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.
- Legacy-Id: 16823
Note: SVN reference [16705] has been migrated to Git commit ec56a03ec6
Fix#2231 - Send reminders before long UnavailabilityPeriods expire
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
- Legacy-Id: 16822
Note: SVN reference [16704] has been migrated to Git commit 179c151f9e
If a review assignment is rejected, withdrawn, marked no response, etc.,
and this leaves a review request without any assigned/accepted/completed
review assignments, return the request state to "requested", which means
it will be shown as an unassigned review in all interfaces.
Commit ready for merge.
- Legacy-Id: 16819
Fix#2328 - Use mailtriggers to find destinations in review app
As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.
- Legacy-Id: 16793
Note: SVN reference [16672] has been migrated to Git commit 88b7b45b0e
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.
Commit ready for merge.
- Legacy-Id: 16792
Corrected a view that was looking at review assignment ids when it should have been looking at request review ids. Fixes#2776.
- Legacy-Id: 16708
Note: SVN reference [16647] has been migrated to Git commit 87de06c97c
The interleaved_migrations_test currently fails due to the various
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.
Commit ready for merge.
- Legacy-Id: 16705
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
Commit ready for merge.
- Legacy-Id: 16704
As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.
Commit ready for merge.
- Legacy-Id: 16672
primary keys from character strings to integers, and makes corresponding code
changes.
This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.
Changing the primary keys to integers should also improve efficiency.
Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time. The total set of migrations are expected to have
a runtime on the order of 2 hours.
- Legacy-Id: 16237
Remove some clutter from I-D upload page. The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes#2057.
- Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
