Commit graph

344 commits

Author SHA1 Message Date
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias.
- Legacy-Id: 16261
2019-06-15 12:00:48 +00:00
Henrik Levkowetz a2cafded25 Changed DocAlias to be many-to-many, in order to be able to handle STD aliases referring to multiple RFCs.
- Legacy-Id: 16249
2019-06-14 20:38:14 +00:00
Henrik Levkowetz 815602351f This is a series of 50 migrations that changes the Document and DocAlias
primary keys from character strings to integers, and makes corresponding code
changes.

This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.

Changing the primary keys to integers should also improve efficiency.  

Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time.  The total set of migrations are expected to have
a runtime on the order of 2 hours.
 - Legacy-Id: 16237
2019-06-10 11:32:46 +00:00
Robert Sparks 25cc00f925 Refactored DocumentInfo to address overloading the external_url field with strings that are not URLs. Commit ready for merge.
- Legacy-Id: 15864
2019-01-02 22:55:00 +00:00
Robert Sparks 8004ba367a Better constrain a liaison test object to match the preconditions for the test. Commit ready for merge.
- Legacy-Id: 15580
2018-10-15 17:46:04 +00:00
Henrik Levkowetz 889babc17f Merged in [15523] from rjsparks@nostrum.com:
Converted the liaisons tests to use factories.
 - Legacy-Id: 15531
Note: SVN reference [15523] has been migrated to Git commit 5e29f56494
2018-10-07 22:15:37 +00:00
Robert Sparks 5e29f56494 Converted the liaisons tests to use factories. Commit ready for merge.
- Legacy-Id: 15523
2018-10-05 21:50:20 +00:00
Ryan Cross c6bc55207c Change content-type of ajax_get_liaison_info to application/json. Commit ready for merge.
- Legacy-Id: 15450
2018-09-12 20:53:53 +00:00
Ben Campbell f8853fa468 Change newlines to commas in to contacts for new liaison email notification. Fixes issue 2525. Commit ready for merge.
- Legacy-Id: 15356
2018-07-14 22:05:34 +00:00
Henrik Levkowetz aa1e42100b Fixed a long-standing bug in the liaison.name() code.
- Legacy-Id: 15177
2018-05-26 08:39:28 +00:00
Henrik Levkowetz c97f6376a3 Simplified the email.origin assignment code for outgoing liaisons.
- Legacy-Id: 15176
2018-05-26 08:38:40 +00:00
Henrik Levkowetz 6c3ec5b18e Added Email origin to Email record creation throughout the codebase.
- Legacy-Id: 15149
2018-05-17 16:56:26 +00:00
Henrik Levkowetz 6e1d4d45d8 Added some missing migrations
- Legacy-Id: 14697
2018-02-25 20:08:37 +00:00
Henrik Levkowetz e859a556f7 Removed unused imports
- Legacy-Id: 14670
2018-02-22 00:06:24 +00:00
Henrik Levkowetz a4768bb514 Removed unused imports. Added some explicit orderings to avoid pagination issues.
- Legacy-Id: 14664
2018-02-21 23:54:31 +00:00
Henrik Levkowetz 06362ec046 Got rid of old migrations and created new initial migrations.
- Legacy-Id: 14662
2018-02-21 23:46:22 +00:00
Henrik Levkowetz 5638cf3da3 Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models.
- Legacy-Id: 14661
2018-02-20 15:36:05 +00:00
Henrik Levkowetz 4dad8cdf9a Added a test to check for missing admin models, and added the admin models that were currently missing.
- Legacy-Id: 14021
2017-08-01 14:00:29 +00:00
Ryan Cross 9972a5464a Fixes #2002. Trailing comma in Liaison cc_contacts field causes invalid email address error. Commit ready for merge.
- Legacy-Id: 13292
2017-05-09 23:28:35 +00:00
Henrik Levkowetz 14c748df98 Changed the creation of temporary test dirs to use names which include the test class name, in order to make it possible to run test cases in parallel. Disabled coverage testing when running in parallel (those classes cannot be pickled and distributed to the test runner threads, and also won't pass coverage data back). Tweaked the TestCase.tempdir() method.
- Legacy-Id: 13157
2017-03-27 21:41:18 +00:00
Henrik Levkowetz d2c2d80341 Merged in [13112] from lars@netapp.com:
Fix various \'RemovedInDjango20Warning\' warnings.
 - Legacy-Id: 13141
Note: SVN reference [13112] has been migrated to Git commit 8a70e9773d
2017-03-26 22:06:47 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
2017-02-26 23:21:49 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's,
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
2017-02-11 14:43:01 +00:00
Henrik Levkowetz 19d585255a Django 1.10 does not permit the view argument to url() to be a string any more. Changed all cases view arguments to url() which were strings to instead reference the actual imported function.
- Legacy-Id: 12815
2017-02-10 14:49:16 +00:00
Henrik Levkowetz 6de7be6953 Specified strip=False for another bunch of CharField form fields with Textarea widgets.
- Legacy-Id: 12711
2017-01-23 17:38:56 +00:00
Henrik Levkowetz 6eec4c2648 Converted all management commands which set up additional command-line switches to use the argparse approach instead of the deprecated optparse approach.
- Legacy-Id: 12645
2017-01-11 18:42:38 +00:00
Henrik Levkowetz 7b95411f58 The context_instance parameter to render_to_response() and render_to_string() is now deprecated. Fixed this, and generally changed the idiom render_to_response('template.html', {}, RequestContext(request)) to the newer and simpler render(request, 'template.html', {}). About 200 instances.
- Legacy-Id: 12637
2017-01-09 21:26:30 +00:00
Henrik Levkowetz c2541ec04b Django 1.9: Removed deprecated use of django.conf.urls.patterns() from all urls*.py files.
- Legacy-Id: 12618
2016-12-22 17:21:57 +00:00
Henrik Levkowetz ff9b8a9bdb Deprecation fixes: Explicitly say that redirects are permanent.
- Legacy-Id: 12532
2016-12-15 13:19:51 +00:00
Henrik Levkowetz 8e56935cfd Undid commit 12527, which contained much too much.
- Legacy-Id: 12528
2016-12-15 10:38:54 +00:00
Henrik Levkowetz e3c6e0ac6b Changed the state shown in all_id.txt for drafts which have entered IESG processing, but then been replaced, to show as 'Replaced' instead of 'In IESG Processing'. This is consistent with how they are shown in all_id2.txt.
- Legacy-Id: 12527
2016-12-15 10:36:15 +00:00
Henrik Levkowetz 19ec458668 Added migrations for the model changes done for the Django 1.8 upgrade.
- Legacy-Id: 12478
2016-12-07 19:41:48 +00:00
Henrik Levkowetz 7c2a1b2ee4 Undid a FK to o2o change we don't want to do (we have instances where the FK is None).
- Legacy-Id: 12402
2016-11-28 17:50:08 +00:00
Henrik Levkowetz 87e1339924 Fixed all the warnings emitted by the check command; mostly use of null=True on ManyToManyFields, which doesn't make sense.
- Legacy-Id: 12256
2016-11-03 20:13:44 +00:00
Henrik Levkowetz ca570ae355 Reverted an inadvertent commit of all changes.
- Legacy-Id: 12253
2016-11-03 20:10:09 +00:00
Henrik Levkowetz 276c9c1030 Removed use of the fix_ampersands() function.
- Legacy-Id: 12252
2016-11-03 20:08:44 +00:00
Henrik Levkowetz aec77c2385 Rewrote Document.href() to not do database queries when possible, as that has a big performance impact. Fixed a number of tests which relied on href() not doing the right thing for simplified test data. Added caching of canonical_name(), which can be quite heavy. Additional refactoring in a number of places, to use better test data and avoid test failures for good code :-)
- Legacy-Id: 12226
2016-10-28 16:59:42 +00:00
Ryan Cross 4634b2dd73 Extended Liaison to_contacts field to 2000 characters. Fixes #2024. Commit ready for merge.
- Legacy-Id: 12132
2016-10-13 18:31:18 +00:00
Henrik Levkowetz 7f772641d4 Change the cache key construction to deal with query arguments containing spaces. Fixes 500 errors which would otherwise occur.
- Legacy-Id: 12035
2016-09-25 13:53:22 +00:00
Henrik Levkowetz ec684e1b4e Added a pylint rc-file, and fixed or silenced a number of issues found by pylint using the settings .pylintrc (which enable only error checking).
- Legacy-Id: 11941
2016-09-08 14:48:59 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method.
- Legacy-Id: 11840
2016-08-23 10:52:08 +00:00
Henrik Levkowetz e6a005dba6 Added a score of setting save/restores to test setup/teardown actions.
- Legacy-Id: 11436
2016-06-21 07:51:02 +00:00
Henrik Levkowetz aa61123937 Modified a few tests to handle the improved handling of error messages (not conflating them with help text any more).
- Legacy-Id: 11181
2016-05-12 13:47:10 +00:00
Henrik Levkowetz 6e6a8baa13 Fixed a typo.
- Legacy-Id: 10931
2016-03-15 23:15:44 +00:00
Henrik Levkowetz adb8625635 Introduced caching for the api resources.
- Legacy-Id: 10929
2016-03-15 23:12:04 +00:00
Henrik Levkowetz 846a02c3f9 Fixed pyflakes complaints introduced with pyflakes 1.1.0
- Legacy-Id: 10896
2016-03-04 21:24:26 +00:00
Henrik Levkowetz 321bce54b0 Merged in [10764] from lars@netapp.com:
Fix \'RemovedInDjango19Warning: The django.forms.util module has been renamed.
Use django.forms.utils instead.\'
 - Legacy-Id: 10778
Note: SVN reference [10764] has been migrated to Git commit a001822cab
2016-02-04 16:29:30 +00:00
Lars Eggert a001822cab Fix "RemovedInDjango19Warning: The django.forms.util module has been renamed.
Use django.forms.utils instead." Commit ready for merge.
 - Legacy-Id: 10764
2016-02-03 13:33:37 +00:00
Robert Sparks 757397330c Addresses issues uncovered by the test-crawler. Adds missing DocAlias records for several document types. Creates DocAlias objects when createing Document objects for those document types. Identifies places in code to touch when we are ready to expose the bluesheets and recording document types at /doc/. (The data rows and the content store need work before doing so).
- Legacy-Id: 10731
2016-01-25 19:40:35 +00:00
Henrik Levkowetz a5a502c48e Augmented the new liaison add_comment test to test the add_comment page and template.
- Legacy-Id: 10511
2015-11-20 20:16:06 +00:00
Henrik Levkowetz ff6969815c Added a migration to go with the liaison updates.
- Legacy-Id: 10507
2015-11-19 21:19:52 +00:00
Henrik Levkowetz 6ab5365296 Merged in^/personal/rcross/v6.7.3.dev0@10465, which included [10382],[10464],[10465], introducing a number of usability fixes to the liaison tool, including a new tab for action needed statements and the ability to add comments to liaison statements' history.
- Legacy-Id: 10506
Note: SVN reference [10382] has been migrated to Git commit b7bbfd8312

Note: SVN reference [10464] has been migrated to Git commit 1ea5dcf907

Note: SVN reference [10465] has been migrated to Git commit eed28dbb49
2015-11-19 19:53:12 +00:00
Ryan Cross eed28dbb49 Small fixes to Liaison Tool changes. Commit ready for merge
- Legacy-Id: 10465
2015-11-12 18:44:28 +00:00
Ryan Cross 1ea5dcf907 Liaison changes from IETF 94 demo. Includes tab for Action Needed statements and ability to add comments to history. Commit ready for merge
- Legacy-Id: 10464
2015-11-12 00:26:52 +00:00
Henrik Levkowetz cf7d794b09 Modified the test data to use some AD and WG chair names that contain non-ascii characters, and fixed test issues found.
- Legacy-Id: 10418
2015-11-04 07:34:56 +00:00
Ryan Cross b7bbfd8312 Various small bug fixes and tweaks to UI of Liaison Management Tool. Commit ready for merge
- Legacy-Id: 10382
2015-11-03 07:52:05 +00:00
Ryan Cross 99e4d0105e Fixes Ticket #1805. Change liaisons ShowAttachmentsWidget to use href(). Commit ready for merge
- Legacy-Id: 10340
2015-10-31 05:41:46 +00:00
Ole Laursen fe0d35a170 Add FIXME about POST, remove some unnecessary is_authenticated calls
from liaisons
 - Legacy-Id: 10332
2015-10-30 09:51:26 +00:00
Ole Laursen 86c3a430d1 Merge in ^/branch/iola/event-saving-refactor-r10076, fixing a few problems
- Legacy-Id: 10298
2015-10-27 10:37:06 +00:00
Henrik Levkowetz a6b5453e69 Merged in [10186] from rjsparks@nostrum.com:
This release improves visibility into where and when the datatracker
sends email. It makes where the datatracker sends email for a given
action data driven, and it shows where email will be sent for actions
on documents and groups.
 - Legacy-Id: 10200
Note: SVN reference [10186] has been migrated to Git commit 1a277b00ec
2015-10-13 17:30:11 +00:00
Henrik Levkowetz 9aade6b558 Updated liaison resources file.
- Legacy-Id: 10193
2015-10-13 16:36:29 +00:00
Robert Sparks 1a277b00ec This release improves visibility into where and when the datatracker
sends email. It makes where the datatracker sends email for a given 
action data driven, and it shows where email will be sent for actions
on documents and groups.

Commit ready for merge.
 - Legacy-Id: 10186
2015-10-10 23:08:09 +00:00
Henrik Levkowetz a7667fb29e Merged in branch/amsl/liaisons/6.4.1@10160 from rcross@amsl.com, bringing in the new liaison tool.
- Legacy-Id: 10161
2015-10-09 19:48:21 +00:00
Robert Sparks f0f5a51eb6 (Rocky) merge forward.
- Legacy-Id: 10157
2015-10-09 03:16:24 +00:00
Ole Laursen 40308d429b Summary: Make sure liaison edit page is using full URL to attachments
to not confuse the crawler, and make all liaison pages use the setting
from settings instead of hardcoding it
 - Legacy-Id: 10125
2015-10-02 12:15:57 +00:00
Robert Sparks f5b6465e81 mailtoken becomes mailtrigger
- Legacy-Id: 10090
2015-09-17 20:03:45 +00:00
Robert Sparks 90c3426e2f updated mailtoken utilities to match the model refactor. Morphed all the code using the utilities to match. Added paths to get Cc through as needed. Next up: Recipient selection form for the iesg save-and-send-email workflow
- Legacy-Id: 10040
2015-08-23 18:15:06 +00:00
Robert Sparks 8a74604a1b Done with the second pass focusing on test coverage. Lots of test tweaks, some new tests, a couple of bugs fixed. The session request code views need to be redone to allow testing.
- Legacy-Id: 10035
2015-08-21 16:39:00 +00:00
Robert Sparks 5db9e0d6a8 checkpoint
- Legacy-Id: 10029
2015-08-19 19:53:09 +00:00
Henrik Levkowetz 2fe8dcb4c2 Added a very simple html version of the json API, to make it easier to explore the api manually.
- Legacy-Id: 9991
2015-08-09 16:28:55 +00:00
Henrik Levkowetz cc4190f1f0 Merged in [9781] from lars@netapp.com:
Move a (duplicate) style tag from python into the template CSS.
The liaison manager is horrible in the amount of HTML it includes in python.
 - Legacy-Id: 9799
Note: SVN reference [9781] has been migrated to Git commit d41e3db6fc40dcd5bacb9bf5a17b24f459203bd2
2015-07-18 15:14:16 +00:00
Henrik Levkowetz d713728072 Merged in [9595] from rcross@amsl.com:
Fixed an issue where an authorized individual was unable to add an incoming liaison.  Fixed a problem with the incoming liaison form requiring a deadline date for information only statements.
 - Legacy-Id: 9605
Note: SVN reference [9595] has been migrated to Git commit fca04d97e5
2015-05-06 17:22:13 +00:00
Ryan Cross fca04d97e5 Fixes issue where authorized individual unable to add incoming liaison. Fixes problem with incoming liaison form requiring deadline date for information only statements. Commit ready for merge.
- Legacy-Id: 9595
2015-05-01 18:11:00 +00:00
Henrik Levkowetz acc2c59920 Updated a bunch of links from http: to https: based on a patch from lars@netapp.com.
- Legacy-Id: 9556
2015-04-24 21:47:12 +00:00
Henrik Levkowetz 625347cd2f Merged trunk@9354 to facelift copy
- Legacy-Id: 9357
2015-04-02 06:51:34 +00:00
Henrik Levkowetz 6f285a12f4 Changed the handling of some test directory creation and removal code, to be more consistent. Fixed a problem where a test didn't create and remove a test directory it used.
- Legacy-Id: 9203
2015-03-15 16:01:15 +00:00
Ole Laursen a225fd5069 Make new branch from trunk and merge facelift-r9007 into it, fixing a few merge conflicts
- Legacy-Id: 9072
2015-02-12 10:43:52 +00:00
Henrik Levkowetz 7ecfac6308 Merged in personal/henrik/django-1.7@9020 which upgrades Django from 1.6.0 to 1.7.4 and applies the needed changes to the datatracker code to work with release 1.7.x.
- Legacy-Id: 9028
2015-02-08 21:16:44 +00:00
Henrik Levkowetz 028b7e315a Reverted to [9025] because commit [9026] failed (it was incomplete with a broken working dir).
- Legacy-Id: 9027
Note: SVN reference [9026] has been migrated to Git commit 4a3749a66b
2015-02-08 20:03:16 +00:00
Henrik Levkowetz 4a3749a66b Merged in personal/henrik/django-1.7@9020 which upgrades Django from 1.6.0 to 1.7.4 and applies the needed changes to the datatracker code to work with release 1.7.x.
- Legacy-Id: 9026
2015-02-08 19:16:46 +00:00
Henrik Levkowetz 24abae6d26 Added back a modified version of get_fieldsets for liaison forms; in this case the parent class doesn't have this method..
- Legacy-Id: 9011
2015-02-06 12:30:51 +00:00
Ole Laursen 4087a9837f End help_texts with period consistently - the default error rendering in the bootstrap3 library depends on it
- Legacy-Id: 8940
2015-01-28 13:25:21 +00:00
Ole Laursen d0999c8b5e Merge facelift-r8510 branch with trunk. The IPR tool still has some non-facelifted parts and ideosyncracies. Fix a couple of minor bugs (including infamous empty licensing choice) in the IPR code, and port the IPR views to use the render shortcut.
- Legacy-Id: 8896
2015-01-22 17:38:05 +00:00
Henrik Levkowetz 030eb5ff9f Merged in [8733] from olau@iola.dk:\n Summary: Fix old bug in liaison tool - WG discussion lists where being
CC'ed with their list_subscribe rather than list_email address, and
the former is usually a URL, not an email address so cause a
validation error when submitting the statement
 - Legacy-Id: 8868
Note: SVN reference [8733] has been migrated to Git commit 7f1683f093
2015-01-15 20:58:37 +00:00
Henrik Levkowetz f4ce5e033c Fix django 1.7 incompatibilities: Remove get_fieldsets() methods which don't work any more because of Django's move from using its own SortedDict to python's OrderedDict (which always is available in python 2.7 and later). The get_fieldsets() method on Form wasn't available in early versions of django, but since it's provided now, we don't need own code for this method.
- Legacy-Id: 8830
2014-12-22 17:54:32 +00:00
Henrik Levkowetz 770b36d575 Added generated (and sometimes manually tweaked) resources.py files.
- Legacy-Id: 8744
2014-12-14 20:33:25 +00:00
Ole Laursen 373644edf4 Port liaison submission/editing to Bootstrap, revamp the select related widget to use select2 rather than the longish popup table
- Legacy-Id: 8738
2014-12-12 17:59:57 +00:00
Ole Laursen 70ad4d1742 Add liaisons migration to fix the few old statements that do not have a title (add an empty initial migration to make South happy)
- Legacy-Id: 8735
2014-12-12 17:30:55 +00:00
Ole Laursen 7f1683f093 Summary: Fix old bug in liaison tool - WG discussion lists where being
CC'ed with their list_subscribe rather than list_email address, and
the former is usually a URL, not an email address so cause a
validation error when submitting the statement
 - Legacy-Id: 8733
2014-12-12 17:06:05 +00:00
Emilio A. Sánchez López a071764c64 Remove unneeded code. Close #1449
- Legacy-Id: 8109
2014-07-18 17:13:00 +00:00
Emilio A. Sánchez López d4831d4e3a Remove restriction with duplicated titles. See #1449
- Legacy-Id: 8108
2014-07-18 17:12:17 +00:00
Emilio A. Sánchez López c414e14597 Fix reply_to and contact fields in form. See #1435
- Legacy-Id: 8107
2014-07-18 17:09:32 +00:00
Emilio A. Sánchez López 1bcb8ca8c6 Fix when an initial value does not exist. See #739
- Legacy-Id: 8104
2014-07-18 16:18:19 +00:00
Emilio A. Sánchez López 0ccbe9144f Allow multiple related liaisons. Close #739
- Legacy-Id: 8103
2014-07-18 16:15:16 +00:00
Emilio A. Sánchez López 439a3b16c7 Replace reply to field with response contacts and remove old response contact field. See #1435
- Legacy-Id: 8052
2014-07-04 12:07:20 +00:00
Emilio A. Sánchez López 00f6bb6023 Mark liaison statements that need action. See #1434. Close #740
- Legacy-Id: 8051
2014-07-04 11:25:10 +00:00
Emilio A. Sánchez López abb74d9977 Search form for liaison statement list. See #1434
- Legacy-Id: 8049
2014-07-04 09:45:13 +00:00
Emilio A. Sánchez López f72b0a1c93 Add log functionality to migrations. Close #1424
- Legacy-Id: 8048
2014-07-04 09:42:29 +00:00
Emilio A. Sánchez López 6c927f11a1 Liaison data migration to new models. See #1424
- Legacy-Id: 7913
2014-06-13 10:34:14 +00:00