Anyone with a role in a group could preapprove drafts. Changed that to an explicit subset of roles. Fixes ticket 998.
- Legacy-Id: 7609
Note: SVN reference [7587] has been migrated to Git commit 5ba0a274933e61e242ebcbf72b2f37e27d1da60d
posts a draft without an access token from the email confirmation step
- Legacy-Id: 7600
Note: SVN reference [7421] has been migrated to Git commit c0e34dbcad
- Rename IdSubmissionDetail to Submission
- Rename various submission fields to correspond to the conventions in
the new schema
- Use a name model for the states instead of IdSubmissionStatus
- Drop the TempIdAuthor model which is based on splitting up author
names
- Add a simple textual SubmissionEvent for tracking events in the
lifetime of a submission
- Delete a bunch of obsolete fields
- Make sure all submission have an access key so we can depend on it
- Add state for when approval is needed from previous authors
A couple of migrations take care of transforming the
IdSubmissionDetail and moving data over/cleaning it up.
Also revamp the submit view code:
- Make form code do validation/cleaning only so there's a clear
separation of concerns
- Reduce uses of inheritance that made the code hard to follow -
forms now don't inherit from each other, views don't call each other
but instead reuse common utilities, templates share CSS/utilities
instead of relying on inheritance
- Move email rendering/sending to separate file
- Drop the in-grown terminology use (auto post vs. manual posts)
- Make the status page explain who is emailed for what purpose
- Add history table with recorded events
- Make the status page handle its post actions by itself instead of
duplicating most of the setup logic in a number of simple views
- Fix a couple of minor bugs and handle some edge cases better
- Expand tests with a couple of more cases
Possibly the submit tool could still use more help text added to
explain the process, ideally what's explained in the tool instructions
page should be inlined or self-evident.
- Legacy-Id: 6714
of assigning them to individual submission, this is not a complete
overhaul but at least basic support so submission works and doesn't
say WG when it means RG.
- Legacy-Id: 4910
subpages for adding and canceling pre-approvals and a set of
migrations for replacing the old IdApprovedDetail with a slightly less
confusing Preapproval model.
- Legacy-Id: 4411
- Legacy-Id: 3086
Note: SVN reference [3063] has been migrated to Git commit af039fba02
Note: SVN reference [3064] has been migrated to Git commit fe466900e1
Note: SVN reference [3065] has been migrated to Git commit be0f5e4962
Note: SVN reference [3075] has been migrated to Git commit e0f4185c54
Note: SVN reference [3076] has been migrated to Git commit ccfd8b5eed
Note: SVN reference [3078] has been migrated to Git commit fe699f7062
Note: SVN reference [3085] has been migrated to Git commit 7fb27754f7
