Commit graph

64 commits

Author SHA1 Message Date
Robert Sparks 02a9da52a1 Manually moved the concepts forward. Reworked some presentation. Working enough to bring testers in at Sprint93
- Legacy-Id: 9717
2015-07-13 21:09:39 +00:00
Ole Laursen eccd8d27c4 Make new branch from trunk (r9007) and merge facelift-r8876 into it, fixing a few merge conflicts
- Legacy-Id: 9014
2015-02-06 14:08:34 +00:00
Ole Laursen 4087a9837f End help_texts with period consistently - the default error rendering in the bootstrap3 library depends on it
- Legacy-Id: 8940
2015-01-28 13:25:21 +00:00
Ole Laursen d0999c8b5e Merge facelift-r8510 branch with trunk. The IPR tool still has some non-facelifted parts and ideosyncracies. Fix a couple of minor bugs (including infamous empty licensing choice) in the IPR code, and port the IPR views to use the render shortcut.
- Legacy-Id: 8896
2015-01-22 17:38:05 +00:00
Robert Sparks 65804be683 This is the second step towards ADs out of GroupInfo into Role.
The use of group.ad has been scrubbed from the code and templates.
  - Those places that set group.ad have been directly manipulate Role objects instead
  - Most places that read group.ad now use a new group.ad_role() that returns a Role object, simplifing some views.

Related to #1555 and #1557.

Commit ready for merge.
 - Legacy-Id: 8854
2015-01-09 18:52:06 +00:00
Robert Sparks 4c9db8f250 This is the first step towards using Role to represent Area directors. It
- Migrates the information captured in GroupInfo.ad to Role objects.
- Renames GroupInfo.ad to GroupInfo._ad (retaining the current column name) to prepare for deletion of that field.
- Provides ad property accessor and setter methods implemented using the group's role_set (so that the existing view code continues to work with minimal changes)
- Improved selection in many querysets that assumed only groups of type 'area' would have area directors.

Related to #1557 and #1555.

Commit ready to merge.
 - Legacy-Id: 8851
2015-01-08 20:22:23 +00:00
Ole Laursen cebc979282 Summary: Resolve person/email/document multiselect issue by importing
select2 and switching the widgets over to using that. Port the
milestones editing page to Bootstrap.
 - Legacy-Id: 8713
2014-11-25 16:47:48 +00:00
Henrik Levkowetz 0f4ae8fe85 Merged in [8608] from rjsparks@nostrum.com:\n Allow chosing the initial state when beginning WG processing of a draft. Fixes bug #1406.
- Legacy-Id: 8615
Note: SVN reference [8608] has been migrated to Git commit 696e93254a
2014-11-09 01:32:41 +00:00
Robert Sparks 696e93254a Allow chosing the initial state when beginning WG processing of a draft. Fixes bug #1406. Commit ready for merge.
- Legacy-Id: 8608
2014-11-09 00:37:47 +00:00
Suresh Krishnan 16c5e24782 Synchronize the currently set tags when document state is edited
- Legacy-Id: 8602
2014-11-08 22:46:40 +00:00
Henrik Levkowetz 370f9efa56 Merged in [8506] from rjsparks@nostrum.com:\n change default notify address for IRTF stream documents. Fixes bug #1489.
- Legacy-Id: 8533
Note: SVN reference [8506] has been migrated to Git commit 31da337eb2
2014-10-31 21:47:50 +00:00
Henrik Levkowetz 4fda60a42a Merged in [8505] from rjsparks@nostrum.com:\n Allow removing a document shepherd, and test that it works. Fixes bug #1509.
- Legacy-Id: 8532
Note: SVN reference [8505] has been migrated to Git commit 0496ee1b73
2014-10-31 21:38:55 +00:00
Henrik Levkowetz cea2e8e603 Merged in [8504] from rjsparks@nostrum.com:\n Added tests that would have caught bug #1508. Added message to edit_shepherd_email to match that added in edit_shepherd.
- Legacy-Id: 8531
Note: SVN reference [8504] has been migrated to Git commit 905df236c3
2014-10-31 21:34:00 +00:00
Ole Laursen 7d0e817e5d Fix a bunch of failing tests, mostly due to changes in markup
- Legacy-Id: 8529
2014-10-31 17:20:14 +00:00
Henrik Levkowetz 7635d8d11a Fixed a bug in calculating can_edit_shepherd_writeup, triggered by the change in what Document.shepherd refers to (now, Email, used to be Person).
- Legacy-Id: 8510
2014-10-29 14:23:17 +00:00
Robert Sparks 31da337eb2 change default notify address for IRTF stream documents. Fixes bug #1489. Commit ready for merge.
- Legacy-Id: 8506
2014-10-27 22:23:09 +00:00
Robert Sparks 0496ee1b73 Allow removing a document shepherd, and test that it works. Fixes bug #1509. Commit ready for merge.
- Legacy-Id: 8505
2014-10-27 21:27:49 +00:00
Robert Sparks 905df236c3 Added tests that would have caught bug #1508. Added message to edit_shepherd_email to match that added in edit_shepherd. Commit ready for merge
- Legacy-Id: 8504
2014-10-27 18:35:57 +00:00
Robert Sparks 055202dee4 Reworked logic flow for editing shepherds. Added message to inform the user when the shepherd is not changed. Fixes bug #1508. Commit ready for merge.
- Legacy-Id: 8498
2014-10-27 15:54:08 +00:00
Henrik Levkowetz 704589b4c7 Merged in branch/iola/people-cleanup @ [8471] from olau@iola.dk, which
enhances a number of pages in the datatracker where forms contain fields
  where a person should be chosen, such as for instance when choosing the
  shepherd of a document, so that they uniformly display choices which show
  both email address and name.

  Furthermore, changes have been made so as to make the email address
  uniformly act as reference to the person record.  

  Autocompletion is now consistently provided when looking for the email
  address or name of the person to choose.  

  This solves a number of issues where it has been difficult to choose the
  correct Person/Email combination, and where the correct email address to use
  for an association has been unavailable previously.
 - Legacy-Id: 8472
Note: SVN reference [8471] has been migrated to Git commit d62f2343e8
2014-10-25 21:05:50 +00:00
Henrik Levkowetz d4e5f070af Merged in [8293] from rjsparks@nostrum.com:\n XXX: Should what is now captured in the list of STATUSCHANGE_RELATIONS instead be captured in the database in name_docrelationshipname?
Refactored editing the notify field to remove redundant code.
Changed the default notification list to include .all for documents, and the wg list for wg documents.
Allowed recalculating the notification list for all document types.
Improved the calculated notification list value for charters, conflict-reviews, and status-changes.
Adds shepherds to the notification list when they are assigned to a document.
Adds the working group email list to the notification list when a document is adopted.
Fixes #1438
 - Legacy-Id: 8385
Note: SVN reference [8293] has been migrated to Git commit 640c5eb52ace8bb6d2c1b3ca6c14ef10ad0f324f
2014-10-12 17:32:11 +00:00
Henrik Levkowetz ec3e247732 Merged in [8262] and [8263] from rjsparks@nostrum.com:
Changes when returning_item is automatically set to match the
    current IESGs preferences.  Removes several chunks of dead code
    related to editing telechat dates.  Improves returning item tests.

    Refactored multiple edit_telechat functions into one function in
    doc_views.  Added a helper function for determining if ballots have
    changed to isolate the implementation.  Fixed the issue with
    update_agenda setting the returning item bit even when the user
    explicitly said not to.  Added prompting to encourage proper setting
    of the returning item bit to the edit_telechat view.

    Fixes #1209
 - Legacy-Id: 8369
Note: SVN reference [8262] has been migrated to Git commit 9d8d0d63e2338d6fa81a82c553b8c6a1c3a105c1

Note: SVN reference [8263] has been migrated to Git commit 35a7436b782fc45e224ac9ea29bfb535fd3ce959
2014-09-28 19:57:01 +00:00
Ole Laursen 5b7258ae12 Add change shepherd email page so that a document shepherd can change
the email address used for shepherding a document
 - Legacy-Id: 8297
2014-08-25 22:59:33 +00:00
Ole Laursen 92e5694ed3 Revamp the AutocompletedEmailsField API a bit to allow for an AutocompletedPersonsField
- Legacy-Id: 8282
2014-08-18 13:55:43 +00:00
Ole Laursen 7b36280070 Rename EmailsField to AutocompletedEmailsField and add a singular
AutocompletedEmailField that cleans to a single Email to make it
easier to use with ModelForms
 - Legacy-Id: 8280
2014-08-18 11:50:04 +00:00
Ole Laursen 9e9ec98206 Moved EmailsField from person.forms to person.fields
- Legacy-Id: 8269
2014-08-14 08:03:11 +00:00
Ole Laursen f291a466d7 Change Document.shepherd to point to the email address rather than the
person, add migration to fix the existing shepherds, fix wording and
max entries on change shepherd page to be more self-explanatory
 - Legacy-Id: 8268
2014-08-13 11:40:01 +00:00
Timothy B. Terriberry e9c79a9e19 Allow IRTF chair to adopt a draft into any RG.
Fixes #1082.
Commit ready for merge.
 - Legacy-Id: 8143
2014-07-19 21:15:47 +00:00
Henrik Levkowetz 1d9e9e7745 Merged [7589] from rjsparks@nostrum.com: Functional changes allowing consensus to be set back to Unknown. Fixes ticket #1150.
- Legacy-Id: 7611
Note: SVN reference [7589] has been migrated to Git commit 7fb3e913e5377aa4e38c369aeefe2449e07e3c4e
2014-04-16 18:45:55 +00:00
Henrik Levkowetz 5a424fe2da Merged in [7153] from rjsparks@nostrum.com:
Fixed a typo in code that looks for the IRTF chair email address while adding replaces relationships.
Made that code slightly more robust.
Fixes ticket #1253
 - Legacy-Id: 7531
Note: SVN reference [7153] has been migrated to Git commit 99c01fa54a
2014-03-21 11:55:51 +00:00
Henrik Levkowetz c19268f6a1 A second pass of pyflakes cleanup, removing additional bulk imports, fixing a bug in get_initial_notify(), and removing some dead (and buggy) code.
- Legacy-Id: 7509
2014-03-16 22:15:46 +00:00
Henrik Levkowetz 8a6c121073 Made ietf/secr/groups pyflakes-clean.
- Legacy-Id: 7480
2014-03-15 21:13:21 +00:00
Henrik Levkowetz b9c38d3c06 Merged pyflakes fixes forward to new copy of trunk.
- Legacy-Id: 7463
2014-03-15 16:27:05 +00:00
Henrik Levkowetz 5bef5d11ae Made doc/ pyflakes-clean.
- Legacy-Id: 7462
2014-03-15 16:09:47 +00:00
Henrik Levkowetz ebc6608387 Merged in part of [7375] from jmh@joelhalpern.com.
Now sending draft update notices to IRSG for IRTF stream drafts.  Fixes issue #1227.
 - Legacy-Id: 7402
Note: SVN reference [7375] has been migrated to Git commit 5f89d9ab996c4b0519ec23accb288e02961c62bf
2014-03-04 18:12:38 +00:00
Robert Sparks ff48d32c08 Migration to repair missing StateDocEvents from wg chairs using
the datatracker to request publication of ietf stream documents.

Incremental improvement to the request publication view to create
those StateDocEvents going forward.

This is related to bug #1312
Commit ready to merge
 - Legacy-Id: 7371
2014-02-28 17:14:18 +00:00
Henrik Levkowetz 3abaab1d98 Merged [7076] from rjsparks@nostrum.com:
Sets the State(type=draft) to Replaced when a document is replaced using views_draft.replaces.
Sets the state back to Active or Expired when a document is no longer replaced by another document.
Adds tests for the above functionality.
Provides a patch to repair the state of documents pointed to by RelatedDocument(relationship__slug='replaces') objects created by views_draft.replaces before this fix.
Fixes bug 1234
 - Legacy-Id: 7222
Note: SVN reference [7076] has been migrated to Git commit a3da5bbd87
2014-02-09 20:33:15 +00:00
Henrik Levkowetz 62e7b515a8 Added stream change and state change emails in adopt_draft() -- otherwise we wouldn't have the state change emails assumed in the previous commit. See issue #1246.
- Legacy-Id: 7207
2014-02-04 23:27:40 +00:00
Henrik Levkowetz 41c1c1a5fe Removing the extra (misleading) draft about WG adoption which is sent out in addition to the state change emails when a call for addoption (WG) or adoption (RG) is done using the 'Adopt Draft in Group' form. The state change messages should be sufficient, and are not misleading. Fixes issue #1246 (and 1290).
- Legacy-Id: 7206
2014-02-04 22:00:07 +00:00
Robert Sparks 99c01fa54a Fixed a typo in code that looks for the IRTF chair email address while adding replaces relationships.
Made that code slightly more robust.
Fixes ticket #1253
Commit ready for merge
 - Legacy-Id: 7153
2014-01-21 20:53:07 +00:00
Ole Laursen 87ca10d122 Remove usage of log_state_changed (and duplicate in
doc/utils_charter.py) in favour of add_state_change_event which has
slightly better API but otherwise does basically the same except it
sets an event type we can later search for. Also expand tests slightly
to exercise three more templates.
 - Legacy-Id: 7129
2014-01-15 17:52:00 +00:00
Ole Laursen b4dfae121b Integrate old patch for warning on the request for publication page if
intended std level and consensus is not filled in for the draft before
sending it (as per discussion with Alice Russo) - the consensus check
is skipped for ISE drafts
 - Legacy-Id: 7103
2014-01-10 17:16:12 +00:00
Robert Sparks a3da5bbd87 Sets the State(type=draft) to Replaced when a document is replaced using views_draft.replaces.
Sets the state back to Active or Expired when a document is no longer replaced by another document.
Adds tests for the above functionality.
Provides a patch to repair the state of documents pointed to by RelatedDocument(relationship__slug='replaces') objects created by views_draft.replaces before this fix.

Fixes bug 1234
Commit ready for merge
 - Legacy-Id: 7076
2014-01-07 22:58:52 +00:00
Ole Laursen 7f277a8fbb Replace user.get_profile() with user.person, the profile stuff is deprecated since Django 1.5
- Legacy-Id: 6968
2013-12-18 10:13:40 +00:00
Ole Laursen d66ac15fc2 Rewrite a bunch of HttpResponseRedirect + url reverse calls to instead
take advantage of the redirect shortcut (introduced in Django 1.1)
 - Legacy-Id: 6960
2013-12-17 10:23:42 +00:00
Ole Laursen 6a98fec2c3 Use built-in json module in Python instead of simplejson bundled with Django
- Legacy-Id: 6883
2013-12-11 16:59:19 +00:00
Ole Laursen e63ac36b8f Remove shim layer from ietfauth, delete some dead code and migrate
remaining importers of ietfauth.decorators to ietfauth.utils
 - Legacy-Id: 6797
2013-12-05 16:24:03 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch
- Legacy-Id: 6764
2013-11-27 12:55:50 +00:00
Henrik Levkowetz ba70c3067a Merged [6696] from tterriberry@mozilla.com:
Improve e-mails from replaced-by updates.

Fix an incorrectly-expanded file tag in the subject.
Fixes #1178.
Use a slightly more natural grammatical construct in the message body.
Fixes #1179.
 - Legacy-Id: 6699
Note: SVN reference [6696] has been migrated to Git commit 03896647cc
2013-11-08 18:56:24 +00:00
Henrik Levkowetz 9aefd3dccf Fixed the saving of shepherd writeups for documents in iesg processing without
a stream state (ad-sponsored documents). Fixes issue #1186 and #1187.
 - Legacy-Id: 6697
2013-11-08 16:33:35 +00:00