Commit graph

562 commits

Author SHA1 Message Date
Sasha Romijn 93797b3fc1 Fix #2087 - Show doc authors and WG chairs in unassigned reviews views.
Commit ready for merge.
 - Legacy-Id: 16923
2019-10-24 07:25:47 +00:00
Sasha Romijn 82c63b49f3 Fix #2118 - Always list all last call drafts in assignment summary.
If a draft is scheduled for a telechat, but also assigned for LC review,
it will now be listed both in the telechat section and under "last calls".

Commit ready for merge.
 - Legacy-Id: 16904
2019-10-22 14:55:04 +00:00
Sasha Romijn 78a1464e77 Ref #2526 - Fix test failure in [16895]
This also makes a small text clarification, which was also the initial
reason for the test failure.

Commit ready for merge.
 - Legacy-Id: 16902
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0
2019-10-22 14:34:36 +00:00
Sasha Romijn ef1e8006f0 Fix #2526 - List previous reviews in assignments email.
This includes a migration to update the database templates. Note that
not all templates currently included them (secdir at least), and
previous reviews are only listed in templates that included */** before.

As before, previous reviews are only included if they are done by the
same reviewer(s) as the current assignment.

This also fixes a bug in database template 182
(/group/defaults/email/open_assignments.txt) which referred to 
r.review_request..doc.rev and r.review_request..requested_rev
in the template, and updates the test to use the current version of
template 182.

Commit ready for merge.
 - Legacy-Id: 16895
2019-10-21 19:11:56 +00:00
Sasha Romijn a7a2ee4a39 Fix #2198 - Set default start date for UnavailabilityPeriod to today.
Commit ready for merge.
 - Legacy-Id: 16891
2019-10-21 15:16:33 +00:00
Sasha Romijn e145832808 Fix #2185 - Close review assignments when reviewer is removed from team.
If a reviewer is removed from a team, any accepted or assigned review
assignments are set to rejected if the request deadline has not passed,
or set to no-response when the request deadline has passed.

Per [16819], if this scenario happens, and there are no other active or 
completed review assignments, the request is shown as an
unassigned review.

Commit ready for merge.
 - Legacy-Id: 16850
Note: SVN reference [16819] has been migrated to Git commit fdb4c2a055
2019-10-09 13:36:25 +00:00
Sasha Romijn fdb4c2a055 Fix #2186 - Return review req to 'requested' status if no review assignments are open.
If a review assignment is rejected, withdrawn, marked no response, etc.,
and this leaves a review request without any assigned/accepted/completed
review assignments, return the request state to "requested", which means
it will be shown as an unassigned review in all interfaces.

Commit ready for merge.
 - Legacy-Id: 16819
2019-10-03 09:02:34 +00:00
Sasha Romijn 486b6daa29 Fix #2475 - Send opt-in reminders for unconfirmed review assignments.
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.

Commit ready for merge.
 - Legacy-Id: 16792
2019-10-01 13:01:19 +00:00
Sasha Romijn cc64992204 Refs #2277 - Send daily reminders of overdue reviews to secretaries
Commit ready for merge.
 - Legacy-Id: 16765
2019-09-30 12:27:43 +00:00
Sasha Romijn ec56a03ec6 Fix #2337 - Send periodic reminders of open reviews every X days (opt-in)
The interleaved_migrations_test currently fails due to the various 
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.

Commit ready for merge.
 - Legacy-Id: 16705
2019-09-05 15:02:56 +00:00
Sasha Romijn 179c151f9e Fix #2231 - Send reminders before long UnavailabilityPeriods expire
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
Commit ready for merge.
 - Legacy-Id: 16704
2019-09-05 11:59:40 +00:00
Sasha Romijn de9cde9e43 Fix #2560 - Sort names in history when changing list of members. Commit ready for merge.
- Legacy-Id: 16668
2019-08-23 11:57:40 +00:00
Sasha Romijn 4669b0934b Fix #2071 - Add optional comment field for close request. Commit ready for merge.
- Legacy-Id: 16667
2019-08-23 11:37:41 +00:00
Henrik Levkowetz de43926eba Merged in [16559] from fenton@bluepopcorn.net:
Added Closing Notes to history and about pages for groups. Fixes issue #2725.
 - Legacy-Id: 16586
Note: SVN reference [16559] has been migrated to Git commit 93b4d6fcc4
2019-07-24 19:49:45 +00:00
Henrik Levkowetz 5a1c35909a Updated a test to match the change in r16560
- Legacy-Id: 16575
2019-07-22 17:55:29 +00:00
Jim Fenton 93b4d6fcc4 Added Closing Notes to history and about pages for groups. Fixes issue #2725. Commit ready for merge.
- Legacy-Id: 16559
2019-07-20 19:47:32 +00:00
Henrik Levkowetz bdc73e771a Python2/3 compatibility: replaced six.ensure_text() with either six.text_type or django's force_text(), depending on the case, and fixed a variable scope issue.
- Legacy-Id: 16461
2019-07-16 13:20:05 +00:00
Henrik Levkowetz 8c6eb3a30a Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc.
- Legacy-Id: 16458
2019-07-15 19:14:04 +00:00
Henrik Levkowetz a5e31c3f40 Py2/3 compatibility: Added __future__ import.
- Legacy-Id: 16452
2019-07-15 15:52:18 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3
- Legacy-Id: 16446
2019-07-15 15:40:51 +00:00
Henrik Levkowetz f481f5c3e6 Replaced use of six with the equivalent pure python3 constructs.
- Legacy-Id: 16428
2019-07-08 10:43:47 +00:00
Henrik Levkowetz 4368e8cca1 Corrected a comment
- Legacy-Id: 16414
2019-07-07 12:51:06 +00:00
Henrik Levkowetz dfd3b60322 Removed tests for the confirm_acronym field removed in [16412].
- Legacy-Id: 16413
Note: SVN reference [16412] has been migrated to Git commit 1997a90d10
2019-07-07 12:50:27 +00:00
Henrik Levkowetz 1997a90d10 Removed the insertion of 'confirm_acronym' in the active form in clean_acronym(). It triggers an exception due to changing a dictionary while the django validation code is iterating through the form fields. XXX Check if we need to put this back some other way, or if we can handle acronym re-use through the admin instead.
- Legacy-Id: 16412
2019-07-07 12:49:17 +00:00
Henrik Levkowetz 0679eaa8d4 Removed unused imports.
- Legacy-Id: 16402
2019-07-04 21:06:57 +00:00
Henrik Levkowetz f480799af9 Undid unintentional bulk commit
- Legacy-Id: 16401
2019-07-04 21:04:46 +00:00
Henrik Levkowetz fc09a59950 Added decode() of command pipe output.
- Legacy-Id: 16400
2019-07-04 21:01:39 +00:00
Henrik Levkowetz fa85e6edee Typo fixes and removal of an unused import.
- Legacy-Id: 16394
2019-07-04 20:55:32 +00:00
Henrik Levkowetz 89e265d798 Fixed an instance of changing a dictionary inside a loop over its keys.
- Legacy-Id: 16387
2019-07-04 16:12:09 +00:00
Henrik Levkowetz 97a555936d Changed a large number of test assertions to use assertContains() and removed separate, now unnecessary,status_code checks. Also changed many assertTrue(... in ...) to use assertIn().
- Legacy-Id: 16346
2019-06-30 21:03:34 +00:00
Henrik Levkowetz aad1d0f1e5 Fixed another str/bytes issue.
- Legacy-Id: 16344
2019-06-30 21:00:38 +00:00
Henrik Levkowetz 15e74e89cb Converted instances of assertTrue(text in response.content) to the recommended assertContains(response, text), and similar for assertFalse(... in ...)
- Legacy-Id: 16336
2019-06-29 13:43:31 +00:00
Henrik Levkowetz 2b1f238204 Changed regex strings to raw strings and fixed a sort comparison int/str issue.
- Legacy-Id: 16333
2019-06-29 13:29:13 +00:00
Henrik Levkowetz 484dcece5f Changed all model __unicode__() methods to __str__()
- Legacy-Id: 16330
2019-06-28 21:07:08 +00:00
Henrik Levkowetz e39ac52071 Removed 2to3-generated list() around .items() iterator in for loops.
- Legacy-Id: 16315
2019-06-27 18:11:17 +00:00
Henrik Levkowetz 240d5bc64d Replaced force_unicode() with force_text()
- Legacy-Id: 16313
2019-06-27 18:08:56 +00:00
Henrik Levkowetz 06daf6ac65 Changed regex strings to raw strings.
- Legacy-Id: 16312
2019-06-27 18:08:02 +00:00
Henrik Levkowetz 3ec7e864be Converted leading tabs to spaces in ietf/**/*.py
- Legacy-Id: 16310
2019-06-27 14:51:02 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates.
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz db12f2b948 Fixed some name versus pk issues lingering after the Document/DocAlias primary key refactoring. Fixes issue #2729.
- Legacy-Id: 16288
2019-06-19 12:57:52 +00:00
Henrik Levkowetz 7270d5f67a Added the option to order API resource lists by primary key, for stable ordering when paging through a list.
- Legacy-Id: 16284
2019-06-18 12:40:19 +00:00
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias.
- Legacy-Id: 16261
2019-06-15 12:00:48 +00:00
Henrik Levkowetz a2cafded25 Changed DocAlias to be many-to-many, in order to be able to handle STD aliases referring to multiple RFCs.
- Legacy-Id: 16249
2019-06-14 20:38:14 +00:00
Henrik Levkowetz 815602351f This is a series of 50 migrations that changes the Document and DocAlias
primary keys from character strings to integers, and makes corresponding code
changes.

This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.

Changing the primary keys to integers should also improve efficiency.  

Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time.  The total set of migrations are expected to have
a runtime on the order of 2 hours.
 - Legacy-Id: 16237
2019-06-10 11:32:46 +00:00
Henrik Levkowetz f4e2352eed Fixed the 'Request closing group' button incorrectly showing for group chairs. Fixes issue #2724.
- Legacy-Id: 16233
2019-06-05 14:16:14 +00:00
Henrik Levkowetz a62e029932 After feedback from the RFC-Editor staff, changed the URL POST notification of Group name changes to an Email notification.
- Legacy-Id: 16210
2019-05-15 18:40:23 +00:00
Henrik Levkowetz de471d4e18 Added a signal receiver for notifications to the RFC editor about changed Group names.
- Legacy-Id: 16208
2019-05-14 13:59:32 +00:00
Henrik Levkowetz 60fdfa2c83 Fixed template and view to restore previous review display on the Manage Unassigned Reviews page. Fixes issue #2718.
- Legacy-Id: 16205
2019-05-13 12:19:05 +00:00
Henrik Levkowetz 5def83ef16 Removed links to the old MHonArc mail archives, and related view.
- Legacy-Id: 16179
2019-05-01 21:24:41 +00:00
Henrik Levkowetz 8726e74709 Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself.
- Legacy-Id: 16177
2019-04-30 16:54:06 +00:00