out nomcom.js is included in the wrong pages, and on the pages it is
actually useful in, it's obsolete, so delete it together with the
obsoleted AJAX view and the other JS left-over cruft in nomcom/, this
fixes an include 404 and removes the remaining dependency on
jquery-1.5.1 apart from the Secretariat tools
- Legacy-Id: 7097
meeting AJAX code is using PUT instead of POST (even if it's not
PUT'ing in the literal sense but POST'ing). Theoretical discussions
aside, Django has poor support for PUTs turned POSTs so rewriting them
removes the need for a couple of hacks, and makes it easier to test.
- Legacy-Id: 7067
duplicated code, make sure the custom form widgets escape their input.
There's still a bit of custom proxying going on in the IETFHM class
hierarchy.
- Legacy-Id: 6794
- Rename IdSubmissionDetail to Submission
- Rename various submission fields to correspond to the conventions in
the new schema
- Use a name model for the states instead of IdSubmissionStatus
- Drop the TempIdAuthor model which is based on splitting up author
names
- Add a simple textual SubmissionEvent for tracking events in the
lifetime of a submission
- Delete a bunch of obsolete fields
- Make sure all submission have an access key so we can depend on it
- Add state for when approval is needed from previous authors
A couple of migrations take care of transforming the
IdSubmissionDetail and moving data over/cleaning it up.
Also revamp the submit view code:
- Make form code do validation/cleaning only so there's a clear
separation of concerns
- Reduce uses of inheritance that made the code hard to follow -
forms now don't inherit from each other, views don't call each other
but instead reuse common utilities, templates share CSS/utilities
instead of relying on inheritance
- Move email rendering/sending to separate file
- Drop the in-grown terminology use (auto post vs. manual posts)
- Make the status page explain who is emailed for what purpose
- Add history table with recorded events
- Make the status page handle its post actions by itself instead of
duplicating most of the setup logic in a number of simple views
- Fix a couple of minor bugs and handle some edge cases better
- Expand tests with a couple of more cases
Possibly the submit tool could still use more help text added to
explain the process, ideally what's explained in the tool instructions
page should be inlined or self-evident.
- Legacy-Id: 6714
replaced the noTable block construct with start/end table_content blocks
in order to not have to open and close tables in different blocks, and
not have empty tables lying about.
- Legacy-Id: 6439
additional tweaks from henrik: Added the capability to search for all kinds
of documents in the main datatracker search page. Fixes bug #838.
- Legacy-Id: 5926
Note: SVN reference [5898] has been migrated to Git commit b14a8d0cee
the shimfree merge [5836] don't work as well for some kinds of
colour-blindness.
- Legacy-Id: 5839
Note: SVN reference [5836] has been migrated to Git commit cbfe489ff5
(-r5465:HEAD from branch/iola/shimfree). Copying relevant
commit messages here:
- Deleted dead code in many places.
- Renamed id-something to draft-something, make the "is
this eligible for expiration" logic clearer
- Added a name for IPR search URL
- Revamped the ballot popup view
- URL reversed the IPR search link instead of hardcoding it
- Cleaned up search views and remove dead code, port them to the new DB
schema, hack related views in iesg/ and wginfo/ to use the new search
interfaces, avoid camelCase in search GET parameters (with
backwards-compat fallback), add some simple search unit tests, remove
caching from views_search.py index pages as they're now pretty fast to
generate, rewrite ballot popup JS, regularize some CSS classes to use
hyphen-notation rather than camelCase, move some of the search
templates to doc/.
idrfc/ now mostly contains some wrapper code still in use by other
subdirs, some ported code not yet moved, and dead code.
- Fixed output bug in test crawler and print referrer upon errors so it's
easier to figure out where a link came from
- Added /doc/in-last-call/ to crawler, report original page as referrer in
a redirect chain rather than intermediate URL
- Ported idindex to new schema, speed them up, add tests, refactor index
page in views_search to share code with the text index file, get rid
of some special-case idindex filters from ietf_filters, move
"/drafts/" redirects to a file in /doc/
- Ported /idtracker/status/ and /idtracker/status/last-call/ overview of
drafts in IESG process to new schema in /doc/iesg/ and
/doc/iesg/last-call/
- Added redirects for all of /idtracker/*, removed all view code and other
dead code from idtracker/
- Removed the idtracker sitemap indexing drafts - in its current form,
it adds nothing of value to the HTML-based /doc/all/ view, and it's
pretty slow
- Ported idtracker feeds to new schema, move them to doc/, cleaned up
idtracker/ - only templatetags/ietf_filters and proxy code is left
- Legacy-Id: 5836
(-r5194:5465 from branch/iola/shimfree). Copying relevant
commit messages here:
- Removed .related many to many relationship, it's not really useful
since we always have to restrict on the relationship type anyway,
instead add two helpers for doing the necessary queries (in both
directions)
- Added migration for transforming the .desc on the new_revision events
into something more akin to what is actually shown in the history page
- Added migration for blanking IESG notes that just consist of "RFC
XXXX", these have been superfluous for some time
- Grant stream chairs access to changing the stream on a draft
- Hacked the format_history_text filter to be less weird, using the same
formatting for snippets and full text, also link up legacy ballot set
events
- Moved the decoraters + utilities to new ietfauth/utils.py file
- Added simple helper to Email to identify invalid email addresses (from
legacy author entries)
- Used new new_revision .desc format for when drafts are submitted
- Improved the looks of the button class by adding extra contrast and a
linear gradient. Currently the gradient is only visible in fairly
recent browsers.
- Rewrote draft and RFC tabs in terms of the new schema, porting
write-up and history tabs as well
- Fixed two bugs in RFC Editor syncing: make sure documents we don't know
beforehand get a "draft" type and make sure individually submitted
drafts get the type="individ" group instead of NULL
- Made the CSS-styled button feel a bit nicer to use by flattening the
active state, also introduce some temporary styles until browsers
catch up with the standard syntax
- Added migrations for fixing 1) a dummy RFC entry, 2) three stand-alone
RFCs that didn't get their doc.type set, 3) a big bunch of historic
stand-alone RFCs that have doc.group=None - set these to the
individual submission "none" group for the time being so the view code
doesn't have to deal with a special case.
In some cases this is wrong since there actually was a WG associated
but unfortunately fixing them properly requires detective work
(probably parsing the RFCs) and in at least some cases recreating
historic WGs. In case someone ends up doing this, the documents to
check can still be found with
Document.objects.filter(name__startswith="rfc", group__type="individ")
since there are almost no new RFCs that didn't went through the I-D
process.
- Merged the I-D and RFC views by showing I-D information on RFCs too.
I-Ds that have been published as RFCs redirect to the RFC URL. Also
support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.
- Fixed revision augmentation so events after RFC publication gets a "RFC"
designation
- Fixed a bug with tabs not using provided name but rather doc.name
- Displaying draft-iesg state rather than doc.friendly_state as IESG state,
also show a notice that the IESG state refers to post-RFC processing
if it does, like the old separate RFC page did
- Fixed the RFC number doc.note migration to catch combined "RFC XXX; BCP
XXX" notes too, use the opportunity to remove inserted HTML tags from
notes and rely on linebreaksbr filter instead (the other thing was a
left-over from the Perl days), update the various uses of the note to
reflect that
- Refactored slightly to make views_doc.py independent of other idrfc code
- Moveed idrfc/views_doc.py to doc/ with associated templates, replace the
somewhat fragile simple URL tests for views_doc.py with ordinary unit
tests. The new tests are still fairly basic but at least test more
than the URL tests did.
- Made sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
RFC0123 in the alias table with a new migration and a change to the
RFC Editor sync, this in turn makes /doc/std1/ do the right thing
- Now /doc/std1/ works, we can actually do a local link in
urlize_ietf_docs rather than linking to the tools.ietf.org server
- Fixed history text formatter: sanitize HTML before adding linebreaks and
non-breaking spaces, this cuts the time to render a history page with
long comments in half
- Added a test crawler that walks through the crawlable part of the site,
reporting errors and slow pages
- Got rid of initial "No record" positions when showing old positions,
it's just noise
- Added a .select_related() to the document main tab to reduce the number
of DB queries, unfortunately it seems it doesn't really help with
Django 1.2.x due to a bug (Document inherits from DocumentInfo which
makes things a bit more complicated)
- Introduced a simple cache in doc.get_state so repeated reads don't
cause a DB query
- Cleaned up the search code in preparation for removal of the shim-layer;
use a static button and don't send extraneous GET parameters
- Removed dead code in several places
- Legacy-Id: 5830
The feedback of a type that is not related to a nominee is classified inmediatly.
The feedback of a type that is related to a nominee must be completed with the nominee information.
Created a view to list feedback that is not related to nominees (e.g. offtopic)
Changed the command that retrieves feedback from email to add the subject inside the comment and to set the author using the from field of the email.
Fixes#1036. Fixes#1035
- Legacy-Id: 5738
schema, hack related views in iesg/ and wginfo/ to use the new search
interfaces, avoid camelCase in search GET parameters (with
backwards-compat fallback), add some simple search unit tests, remove
caching from views_search.py index pages as they're now pretty fast to
generate, rewrite ballot popup JS, regularize some CSS classes to use
hyphen-notation rather than camelCase, move some of the search
templates to doc/.
idrfc/ now mostly contains some wrapper code still in use by other
subdirs, some ported code not yet moved, and dead code.
- Legacy-Id: 5611
I-Ds that have been published as RFCs redirect to the RFC URL. Also
support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.
- Legacy-Id: 5285
Liasion Manager:
* Patch from Yaco to avoid resetting the From field when changing other items on the form
* Gave the secretariat the ability to find/approve any unapproved liaisons
* Changed all the email code to use ietf.mail.utils (and removed the fake-mail concept)
Charter documents and the Agenda pages:
* Added charter documents to iesg/agenda and iesg/agenda/documents
* Synced the ordering of drafts on iesg/agenda and iesg/agenda/documents
* Allow setting a responsible AD for charter documents
* Changed the UI of the charter page to use editlink for changing attributes and buttons for actions (to align with drafts and conflict-reviews)
Moderator package:
* Refactor: Simplified access to the current BallotDocEvent from a Document
* Added functions to BallotDocEvents? to faciliate access to BallotPositionDocEvents?, both for all positions, and current AD postions.
* Updated the moderator package to use the Documents from _agenda_data.
* Added a filter to assist with rendering the moderator package.
* Fixed a bug where different functions in idrfc/views_ballot were using log_state_changed expecting different implementations (a cleanup task should reconcile the _three_ implementations in the codebase of that function).
Cleanup from codesprint:
* Removed some duplication between doc/util and doc/models by moving things into doc/models
* Do not show non-empty discuss text when the ballot position is not blocking
* Added a migration to update non-blocking ballot positions that have non-empty discuss text
DEPLOYMENT NOTES
Please be aware that migration step will take a few minutes to complete.
Fixes bug 865
- Legacy-Id: 4780
Note: SVN reference [4772] has been migrated to Git commit e5c3a5adc5
* Adds a new document type for conflict reviews, with a ballot for the IESG 5742 response to a review request
* Integrated the new document type into the iESG agenda views (including RSS feeds)* Removed the Edit and Add buttons from the document main view.
* Replaced Add with actions appropriate for the document type, such as "Begin IESG Processing" or "Begin IETF Conflict Review", and made most data directly editable on the document's main page, depending on access permissions.
* Removed a manual editing step that the secretariat had to perform when sending conflict review messages. The view now composes the message correctly given the stream.
* Added a pencil icon motif to differentiate fields that are editable.
* Generalized several views and helper functions to use Document instead of (e.g.) IdWrapper
* Generalized reading documents from the repository
* Added a way to get from IdWrapper to the underlying Document to facilitate migrating way from the Wrapper classes* Added many helpers to Document to assist with migrating off IdWrapper
* Minor fixes and other changes
* Fixes to document main view to avoid (silent) template failures.
* Began removing some of the code that is no longer reachable post-migration * Corrected the behavior of the undefer code and added test cases for it
* Improved initial population of notification lists and added the ability to regenerate the initial list
* Made the test code that scans for template coverage more robust
* Deployment notes:
* new setting: CONFLICT_REVIEW_PATH. The associated directory will need to be created
This branch fixes bugs #805, #744 and #812
- Legacy-Id: 4652
Note: SVN reference [4600] has been migrated to Git commit 798e7a50e7
/doc/<doc-name>/charter/ since they now all concern the actual charter
documents rather than the WG (this removes some redundant code).
- Legacy-Id: 4271
Fixes bug #659
2) Copied the jquery-1.5.1.min.js library into /static/js/lib (from /static/js)
because that's where the main document template was looking for it. There have
probably been several problems since the change that left this dangling that
showed up as things not behaving, but not as errors. The one that clued me in
was the discuss text-box not being hidden when the position wasn't DISCUSS.
They should all behave better now.
3) Added a django form validator to the discuss text field to not allow actions
when the position is Discuss, but the discuss-text is empty.
2 and 3 together fix bug #660
4) Added logic to the undefer fuction to put the document back on the previous
telechat (if that hasn't already passed). That is, date1 from telechat dates,
and not date2.
Fixes bug #661
5) Changed the last_call_announcement generation function's template to include
the abstracts from the document sets (which with modern usage means the abstract
of the document) reflecting the IESGs decision of a few months back.
Fixes bug #662
6) Removed the old tracker link from the document's main page
Fixes bug #663
_M .
M ietf/idrfc/views_ballot.py
M ietf/templates/idrfc/last_call_announcement.txt
M ietf/templates/idrfc/undefer_ballot.html
M ietf/templates/idrfc/doc_tab_document.html
M ietf/templates/idrfc/edit_position.html
_M ietf/utils/draft.py
_M static/media
A + static/js/lib/jquery-1.5.1.min.js
- Legacy-Id: 3107
2) Copied the jquery-1.5.1.min.js library into /static/js/lib (from /static/js)
because that's where the main document template was looking for it. There have
probably been several problems since the change that left this dangling that
showed up as things not behaving, but not as errors. The one that clued me in
was the discuss text-box not being hidden when the position wasn't DISCUSS.
They should all behave better now.
3) Added a django form validator to the discuss text field to not allow actions
when the position is Discuss, but the discuss-text is empty.
4) Added logic to the undefer fuction to put the document back on the previous
telechat (if that hasn't already passed). That is, date1 from telechat dates,
and not date2.
5) Changed the last_call_announcement generation function's template to include
the abstracts from the document sets (which with modern usage means the abstract
of the document) reflecting the IESGs decision of a few months back.
- Legacy-Id: 3097
In response to early feedback, changed 'close' metaphor from 'click anywhere' to 'click on the red "x" icon.'
- Legacy-Id: 2993
Note: SVN reference [2990] has been migrated to Git commit 04289ed0e3dd56899a7c3cfa6ee43cdcd9eb68f5
Update jQuery to 1.5.1 and jQuery UI to 1.8.11.
- Legacy-Id: 2986
Note: SVN reference [2984] has been migrated to Git commit c7c2a690e98e3541a810e6beb60b1469c4f78dd7
Remove unused images. Convert GIFs to smaller PNGs.
Optimize all images with http://www.smushit.com/ysmush.it/
- Legacy-Id: 2979
Note: SVN reference [2976] has been migrated to Git commit 92b7e87a963787459fe3e75654b3ff2a0deaf34f
Change default vertical alignment of various datatracker tables
for better readability.
- Legacy-Id: 2977
Note: SVN reference [2971] has been migrated to Git commit bc4610ad313fcc48f2e4cacb47275432e9d3ab37
Make search result table headers clickable; clicking will sort on said column, see trac #484
- Legacy-Id: 2974
Note: SVN reference [2967] has been migrated to Git commit a6ef460f3a3a24b9f32f83bf8dbeffe2fa220958
