altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
8102 commits 1 branch 0 tags 2.6 GiB
Commit graph

349 commits

Author SHA1 Message Date
Henrik Levkowetz 8e56935cfd Undid commit 12527, which contained much too much. 
- Legacy-Id: 12528
 2016-12-15 10:38:54 +00:00
Henrik Levkowetz e3c6e0ac6b Changed the state shown in all_id.txt for drafts which have entered IESG processing, but then been replaced, to show as 'Replaced' instead of 'In IESG Processing'. This is consistent with how they are shown in all_id2.txt. 
- Legacy-Id: 12527
 2016-12-15 10:36:15 +00:00
Henrik Levkowetz 57eb5844e5 Merged in [12489] from rjsparks@nostrum.com: 
Save a new reviewrequest for each team requested in the request form. Fixes #2094.
 - Legacy-Id: 12491
Note: SVN reference [12489] has been migrated to Git commit 4fff1ab101e4f7cd27dc8ded889e09905866076f
 2016-12-09 12:01:48 +00:00
Henrik Levkowetz 83a260c6c0 Merged in [12482] from rjsparks@nostrum.com: 
Improves control of email headers for review summary messages. Provides team-specific templates for review summary messages. Fixes #2092 and #2082.
 - Legacy-Id: 12483
Note: SVN reference [12482] has been migrated to Git commit 06179c7485dac6c69b2aa30e66095a23a4460209
 2016-12-08 17:55:37 +00:00
Ole Laursen 7d8baf0015 Add reviewer name and completion date to previous reviews in manage 
review page
 - Legacy-Id: 12397
 2016-11-25 10:53:37 +00:00
Ole Laursen 39d674b4ca Add missing resource and missing test review secretary settings 
- Legacy-Id: 12313
 2016-11-09 10:07:49 +00:00
Ole Laursen ceec1254f2 Add review team secretary reminders, like those for reviewers 
- Legacy-Id: 12283
 2016-11-08 16:24:28 +00:00
Ole Laursen cde7cfacd5 Modify the reviewer overview page to display up to 10 historic reviews 
per person from the past year instead of only 5.

Add basic reviewer stats to the assignment select box.
 - Legacy-Id: 12279
 2016-11-07 22:32:53 +00:00
Ole Laursen c3e8cabafb Revamp the layout in the manage review requests page. Drop the table 
and instead provide more information about each document to be
reviewed, to help the secretaries determine locally on that page what
action to take. The new layout should also make it easier to fit in
more info, in case it is still found lacking.

The public review request page still provides the previous information
in the summarized tabular form, so the overview can be found there.
 - Legacy-Id: 12278
 2016-11-07 21:20:15 +00:00
Ole Laursen 58dd25ff79 Split up open review requests on the review team page in assigned and 
unassigned requests to make it easier to just work with the unassigned
ones. Use same split on the manage reviews page which is now two
pages.
 - Legacy-Id: 12266
 2016-11-04 17:19:33 +00:00
Ole Laursen b9d5352afd Display the reviewed revision in reviewer overview page 
- Legacy-Id: 12245
 2016-11-02 11:33:25 +00:00
Ole Laursen 3835532d71 Insert iconic link to review statistics from the team pages 
- Legacy-Id: 12215
 2016-10-26 13:35:32 +00:00
Ole Laursen 1febf2465d Fix a bug in the logic that determines which roles are editable (the 
bug had the reviewer field showing up on non-dir pages)
 - Legacy-Id: 12186
 2016-10-20 15:30:35 +00:00
Ole Laursen 4b987436c0 Fix a missing HttpResponseForbidden in review statistics, make the 
review test code use a separate reviewer and reviewsecretary user to
avoid confounding things - also let these use Unicode in their names
to check for Unicode trouble.
 - Legacy-Id: 12175
 2016-10-19 11:58:49 +00:00
Ole Laursen d0877a0aa9 Change default of ReviewerSettings.min_interval to null - if it's not 
specified for a reviewer, we don't take it into account
 - Legacy-Id: 12168
 2016-10-18 10:36:42 +00:00
Ole Laursen a216694c4c Add missing guard on the manage review button so it only shows up if 
the user can access the manage review page
 - Legacy-Id: 12166
 2016-10-17 21:43:35 +00:00
Ole Laursen 399bb3bf4d Make UnavailablePeriod.start_date nullable and import the unavailable 
periods from the Perl tool with start date null as we don't know when
they started.
 - Legacy-Id: 12161
 2016-10-17 19:37:56 +00:00
Ole Laursen 505b4fcea3 Fix redirection problem when group_type is not given. 
- Legacy-Id: 12136
 2016-10-13 19:34:39 +00:00
Ole Laursen 958ba5ba95 Make new branch from trunk and merge in review-tracker-r11921 
- Legacy-Id: 12129
 2016-10-13 16:38:47 +00:00
Ole Laursen bf55237112 Add statistics section with review statistics. Fix a couple of missing tests. 
- Legacy-Id: 12124
 2016-10-13 15:20:04 +00:00
Ole Laursen 46dd4682bf Remove debug output 
- Legacy-Id: 12102
 2016-10-07 16:49:37 +00:00
Ole Laursen 59180240af Add a simple reminder system for reviewers so that they can opt in to 
being reminded X days before deadline of an assignment
 - Legacy-Id: 12101
 2016-10-07 16:43:29 +00:00
Ole Laursen 227fdd7953 Add reviews to search results and IESG agenda. Support restricting 
review types so that teams will only have those review types
listed and suggested that they are configured to have.

Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.

Fix a couple of bugs.
 - Legacy-Id: 12095
 2016-10-06 14:47:41 +00:00
Ole Laursen a177dc616b Fix a couple of bugs, add test for reviewer overview page 
- Legacy-Id: 12081
 2016-10-04 20:22:11 +00:00
Ole Laursen 4c7b2847ba Add a utility function for extracting information about review 
requests for a given set of teams/reviewers (making it trivial to
compute statistics), revamp the related doc event code to support this
by referencing the review request directly, add a reviewer overview
page with recent performance for each reviewer as well as
settings/unavailable periods. Fix some bugs and shuffle some of the
review code a bit around.

Finish the importer from the previous Perl-based review tool,
importing log entries, figuring out whether a given review is
early/telechat/last call and fixing corner cases.
 - Legacy-Id: 12080
 2016-10-03 15:52:32 +00:00
Henrik Levkowetz 7f772641d4 Change the cache key construction to deal with query arguments containing spaces. Fixes 500 errors which would otherwise occur. 
- Legacy-Id: 12035
 2016-09-25 13:53:22 +00:00
Ole Laursen 99beb58291 Implement a round-robin rotation scheme for reviewers instead of 
relying on when they last reviewed. In-order assignments automatically
move the rotation forwards while out-of-order assignments increment
the skip next of the assigned reviewer. Include rotation in open
review assignments email. Fix a couple of issues in the importer.
 - Legacy-Id: 12015
 2016-09-21 16:52:50 +00:00
Henrik Levkowetz e553ff80d8 Added an is_bof flag to json_agenda. Also added group state information. Changed the group information to use historic information instead of current. 
- Legacy-Id: 12009
 2016-09-20 20:28:22 +00:00
Ole Laursen 6da25e6bd9 Add personal review overview page for reviewers, add page for editing 
reviewer availability settings, emailing the reviewer/secretary as
necessary, add tests for these pages. Fix a bunch of bugs.
 - Legacy-Id: 11998
 2016-09-19 16:05:32 +00:00
Ole Laursen 74a02be9bf Create new branch from trunk@r11921, and merge review-tracker-r11360 into it 
- Legacy-Id: 11923
 2016-09-06 10:17:12 +00:00
Ole Laursen 1f7d4870a8 Refactor role handling in group editing slightly and add support for 
editing reviewer roles in review teams. Also fix a couple of review
related bugs.
 - Legacy-Id: 11921
 2016-09-05 12:33:54 +00:00
Henrik Levkowetz 2c484d5abb Added another migration dependency, to avoid looking for removed tables. 
- Legacy-Id: 11880
 2016-08-26 10:30:21 +00:00
Henrik Levkowetz 2b226ae7b7 Improved test coverage somewhat by making more of the group tests apply to both the /group/acronym and /wg/acronym (or equivalent) url forms. 
- Legacy-Id: 11857
 2016-08-24 16:50:54 +00:00
Henrik Levkowetz cf5ac68b09 Renumbered and updated the migrations merged in from the eventsaving work. Made the dochistory-adding migration idempotent, and added progress indication as this migration may take as much as an hour to run. 
- Legacy-Id: 11854
 2016-08-24 15:37:25 +00:00
Ole Laursen dd190b87fe Follow replacements when displaying reviews for a draft on the 
document page, too. Add a test to check that recursive replacements
are handled correctly. Polish the display a bit.
 - Legacy-Id: 11847
 2016-08-23 14:55:42 +00:00
Ole Laursen 16e28481f6 Add page for emailing open review assignments summary to the review team list 
- Legacy-Id: 11846
 2016-08-23 14:06:47 +00:00
Ole Laursen 1f71268da1 More polish on manage review requests page: Add save and continue 
editing button, reverse sort order so latest (and probably most
interesting) is at the top, disable save buttons when there are no
changes to save
 - Legacy-Id: 11843
 2016-08-23 12:12:24 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method. 
- Legacy-Id: 11840
 2016-08-23 10:52:08 +00:00
Ole Laursen 507baade01 Add refresh button to manage reviews page, make save detect changes in 
the requests and pop the page back up for confirmation if so
 - Legacy-Id: 11827
 2016-08-19 16:40:09 +00:00
Ole Laursen 5eba7bf38e Fix a bug 
- Legacy-Id: 11807
 2016-08-17 16:12:17 +00:00
Ole Laursen 426542771a Turn ReviewRequest.deadline into a date field with no time 
- Legacy-Id: 11801
 2016-08-17 15:10:39 +00:00
Robert Sparks 4631df61ef improve some test coverage. Commit ready for merge. 
- Legacy-Id: 11767
 2016-08-09 18:31:05 +00:00
Robert Sparks 9b2d73b365 add status reports to proceedings. add a view for the applicable status report for a given meeting. Commit ready for merge. 
- Legacy-Id: 11766
 2016-08-09 15:42:40 +00:00
Henrik Levkowetz 34370c6e16 Merged in [11656] from rjsparks@nostrum.com: 
Enhanced factories to simplify test writing.
 - Legacy-Id: 11682
Note: SVN reference [11656] has been migrated to Git commit 030ea1c939
 2016-07-16 14:15:41 +00:00
Henrik Levkowetz c7cecf66e9 Added a test case for group home. 
- Legacy-Id: 11652
 2016-07-13 19:20:13 +00:00
Henrik Levkowetz 8ca48aac42 Make group acronym regex patterns consistent. 
There were multiple different regex patterns in different urlpattern
declarations, with some of them permitting characters which should not
occur in group acronym.  Changed them to consistently use [-a-z0-9]+ .
 - Legacy-Id: 11651
 2016-07-13 19:19:15 +00:00
Henrik Levkowetz 211943148d Make the group factory produce groups with valid acronyms 
- Legacy-Id: 11650
 2016-07-13 18:48:53 +00:00
Ole Laursen f7eeb1f0f1 Add missing constraint on team in manage review request page 
- Legacy-Id: 11636
 2016-07-12 16:12:04 +00:00
Ole Laursen db4ea01e20 Take a bunch of factors into account when sorting reviewers for 
assignment to a review request
 - Legacy-Id: 11626
 2016-07-12 13:04:14 +00:00
Henrik Levkowetz 8b6d8c9f44 Replaced the hardcoded 'Area Director' approval role with a group-dependent list of approval roles. Fixes issue #1980. 
- Legacy-Id: 11575
 2016-07-09 16:59:50 +00:00