Commit graph

12666 commits

Author SHA1 Message Date
Matthew Holloway 8bc51e3cc2
feat: important dates page: autoid-n to IETFn (#8175)
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2024-11-15 12:16:34 -06:00
Matthew Holloway c89646ef8d
feat: Agenda proposed badge (#8164) 2024-11-14 16:59:05 -06:00
Jennifer Richards b65a37b6e8
feat: POST for document search requests (#8206)
* refactor: doc search via POST (WIP)

Changes the search view to use a POST instead of a GET. Refactors cache key computation to use cleaned data.

Still todo:
 * refactor frontpage view to match
 * refactor menubar search (?)
 * refactor stats view that uses SearchForm
 * revive or drop the "backwards compatibility" branch

* feat: convert GET search to POST

Still todo:
 * refactor frontpage view to match
 * refactor menubar search (?)
 * refactor stats view that uses SearchForm

* fix: revert frontpage changes, search works

Still todo:
 * refactor stats view that uses SearchForm

* fix: define vars in all branches

* refactor: update stats use of SearchForm

* chore: improve message

* fix: remove lint

* chore: comments re: QuerySetAny

* test: test query string search params

* style: Black

* test: refactor test_search()

* test: refactor test_search_became_rfc()

* test: use scroll_and_click helper
2024-11-14 16:05:38 -06:00
Jennifer Richards 901fdd8d44
chore: remove newrevisiondocevent stats view (#8210)
* refactor: update node, eslint, neostandard + fix esm (#8083)

* chore: update dependencies

* fix: eslint + neostandard

* fix: add corepack prompt env var to init script

* docs: Update README.md

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

* chore: remove newrevisiondocevent stats view

Not functional anyway

* chore: fix lint

* chore: remove unused template

* Revert "refactor: update node, eslint, neostandard + fix esm (#8083)"

This reverts commit 649879efd745470f6e0cc6768d889f45640e1505.

---------

Co-authored-by: Nicolas Giard <github@ngpixel.com>
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2024-11-14 15:21:48 -06:00
Jennifer Richards a70171dfd9
chore: remove more dead code (#8208)
* chore: remove unused settings

* chore: remove unused ietf.utils.aliases / config
2024-11-13 10:51:04 -06:00
Robert Sparks b4fd3bfbb7
chore: remove dead code (#8207)
* chore: remove dead SYNC_BIN_PATH

* chore: remove unused Status class name attribute

* chore: remove unused import
2024-11-13 09:51:43 -06:00
Jennifer Richards a35aa67c70
chore: clarify transaction-related comments (#8180) 2024-11-08 11:55:47 +00:00
Robert Sparks 8c787b54f9
fix: control test meeting date to be in the past (#8177) 2024-11-07 17:41:36 +00:00
Robert Sparks 277f1aafeb
fix: search for correct ids in test (#8168) 2024-11-06 16:38:37 +00:00
Matthew Holloway 5348aefef9
feat: show existing recordings on materials page (#8102)
* feat: show existing recordings on materials page

* chore: notes and recordings tests WIP

* chore: test session recordings

* feat: label all session recording urls as meetecho
2024-11-06 08:52:04 +00:00
Jennifer Richards afbe6aa429
fix: queue tasks in on_commit hook (#8149)
* fix: dispatch tasks in on_commit hook

* test: fix test
2024-11-06 08:49:54 +00:00
Matthew Holloway de494790b6
fix: Selenium tests via scroll_and_click (#8150)
* fix: selenium tests scroll_and_click

* fix: reduce default timeout to 5 seconds

* fix: also use scroll_and_click on test_upcoming_materials_modal

* fix: remove conditional check on restoring scroll CSS

* fix: restore conditional check on restoring scroll CSS

* chore: code comments and adding jstest.py to coverage ignore
2024-11-05 15:03:21 +00:00
Jennifer Richards 7a5b152c5e
feat: async refresh of agenda data (#8146) 2024-11-04 15:24:35 +00:00
Tero Kivinen 19d80ffc83
fix: fix statistics for RFCs to show properly. (#8139) 2024-11-03 16:29:53 +00:00
Matthew Holloway deb58a1a63
fix: disallow header wrapping (#8134) 2024-11-03 16:23:29 +00:00
Jennifer Richards 087bf1e77c
fix: prefer PDF in (+refactor) materials_document view (#8136)
* fix: prefer PDF in materials_document(); refactor

* style: Black

* refactor: split urls entry into simpler pair

It seems Django cannot reverse a URL pattern that uses "|" to
combine options when one inclues a named variable and the other
does not.

* test: test extension choice

* fix: fix test failures

* refactor: get rid of io.open()

* refactor: reunite url patterns

Adds option for a trailing "/" when using an extension,
which was not previously supported but should be somewhere
between harmless and a feature.
2024-11-03 14:34:16 +00:00
Robert Sparks b926178e62
fix: quicker calculation of status from draft text (#8111)
* fix: quicker calculation of status from draft text

* chore: remove unused import

* fix: only read a small prefix of draft text when needed
2024-10-29 11:18:31 -05:00
Robert Sparks 94f95c0eba
fix: correct label for objectively false ipr disclosures (#8101) 2024-10-28 11:57:06 -05:00
Jennifer Richards 3130ecd9f5
fix: add recording-name api key endpoint; appauth url fix (#8081)
* fix: add endpoint option for recording-name

* chore: migration

* test: validate PersonalApiKey when used in tests

* fix: limit /api/appauth URLs as intended

* test: fix tests

* chore: fix lint

* test: PersonalApiKey create -> factory

* chore: remove unused import
2024-10-25 08:52:09 -05:00
Jennifer Richards c26ba974ba
refactor: use form for search_submission (#8065)
* refactor: use form for search_submission

* chore: remove lint

* style: Black
2024-10-22 10:51:16 -05:00
Robert Sparks 8881010051
feat: explicit names for meetecho recordings (#8062)
* feat: explicit names for meetecho recordings

* fix: better regex and kebab-styled-endpoint-name

* fix: spaces around comparison operator
2024-10-21 16:45:36 -05:00
Jennifer Richards 9c56ba9a0a
fix: drop, not bounce, uninteresting ipr emails (#8057)
* fix: drop, not bounce, uninteresting ipr emails

* chore: log to address

* chore: unused import
2024-10-17 16:23:34 -05:00
Jennifer Richards de2e66ede3
feat: report xml2rfc errors for submissions (#8000)
* feat: capture xml2rfc output on exception

* fix: chain exception properly

* feat: log xml2rfc stderr/stdout

May want to pass these back to the submitter, but
let's watch them to see what sorts of sanitizing we
should do first.

* Revert "feat: log xml2rfc stderr/stdout"

This reverts commit 959c54d30733a4a3df7ed0250fef347ed6f03a08.

* feat: log xml2rfc stderr/stdout

This time without reformatting all the imports

* feat: path sanitization for submission errors

* fix: parentheses in regex

* test: test SubmissionError sanitization

* style: consolidate imports

* fix: apply sanitization to all args

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2024-10-17 16:23:13 -05:00
Jennifer Richards a338df16f2
fix: 404 instead of 300 for ambiguous email_or_person (#8004)
* fix: 404 on CommunityList name collision

* fix: 404 on ambiuous person for photo() view

* test: update tests

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2024-10-16 11:36:54 -05:00
Martin Thomson 166340842e
fix: Set overflow-y to clip for pre (#8047)
Browsers treat an overflow: auto directive as a request to make an
element scrollable, even if the element does not need it.
This results in scrolling being confined to that element sometimes,
such as when a document is scrolled using a mouse wheel
if the document scrolls the pointer into that element.
The result is that scrolling can be "trapped" on an element that
doesn't really need to scroll.

This disables vertical scrolling for those pre elements that might
trap scrolling in this way.
2024-10-14 15:24:49 -05:00
Jennifer Richards 2d2e879bd1
fix: versioned href for slides URL (#8040) 2024-10-14 10:22:19 -05:00
Robert Sparks 83f5fc8d1a
fix: add exception to last<->first name swap (#8043) 2024-10-11 12:24:35 -05:00
Jennifer Richards 148fa2f9f6
fix: decode header fields for alert msg (#8034)
* style: Black

* chore: type hints

* refactor: % to f-string

* refactor: helper to decode header values

* fix: decode header fields for pop-up msg

* test: add tests

* fix: use truthiness check

We want to suppress empty strings, too...

* refactor: use f-string for time formatting

* test: clarify side_effect intention
2024-10-10 12:23:25 -05:00
Sangho Na f7e0a67095
fix: turn off automatic escaping in session request templates (#8007)
* fix: turn off automatic escaping in session request templates

* test: ensure no unwanted escaping in session request emails

* test: use PersonFactory to create test users

* test: minor refactoring
2024-10-09 14:49:05 -05:00
Jennifer Richards a6d15c98ba
test: fill in milestone descriptions (#8002)
* test: fill in milestone descriptions

If "Next" or "Last" appear in the descriptions, the
selectors used by the tests get confused.

* test: avoid fragile selectors
2024-10-09 11:04:54 -05:00
Jennifer Richards 6aff818b72
feat: remove deprecated /api/submit/ endpoint (#8017)
* feat: remove deprecated /api/submit endpoint

* chore: remove unused imports

* test: test api_submit_tombstone view
2024-10-09 10:56:00 -05:00
Sangho Na 364dec3e33
fix: fix wg anchor tags (case-sensitive) (#7995)
* fix: fix wg anchor tags in areas page

* fix: fix wg anchor tags in IESG agenda page

* test: ensure wg anchor tags to be all uppercase

* test: improve tests
2024-10-02 19:37:49 -03:00
Sangho Na b34bbe59ad
fix: hide rounded pill if session has no purpose specified (#7997) 2024-10-02 11:44:52 -05:00
Jennifer Richards fbcfa19add
feat: remove "AD is watching" state (#7960)
* feat: remove "AD is watching" state

* chore: update names.json

* refactor: use idexists state, not dead

* fix: remove guidance to use watching state

* chore: remove references to 'watching' state

* feat: remove create_in_state from edit_info view

* test: update test

* style: Black + move class closer to use

* refactor: remove lint

* fix: restore missing admonition

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2024-09-24 12:13:12 -05:00
Jennifer Richards 5581dc79e1
feat: doc mgrs can edit/remind action holders (#7971)
* feat: doc mgrs can edit/remind action holders

* test: test docman_roles, not "chair"
2024-09-24 10:46:00 -05:00
Robert Sparks 06b9df10ee
feat: warn about materials for cancelled sessions (#7959)
* feat: warn about materials for cancelled sessions

* fix: handle viewing a DocHistory material object
2024-09-23 10:09:50 -05:00
Robert Sparks 25fd4fce5d
fix: show correct time for cancelled sessions. (#7958) 2024-09-23 09:41:18 -05:00
Jennifer Richards 32057f335a
feat: allow blanket IPR disclosures (#7934)
* refactor: avoid shadowing type()

* style: Black

* feat: is_blanket_disclosure field

* feat: add field to form

* feat: js to mark field required/not required

* feat: blanket disclosure = royalty-free license

* feat: manage licensing radio buttons

* fix: adjust wording/format of disclosure page

* fix: point at RFC 8179 in checkbox label

* test: test blanket disclosure licensing restrictions

* fix: conditionally render is_blanket_disclosure

* test: refactor test case

* test: patent details optional for blanket ipr
2024-09-18 16:37:02 -05:00
Lars Eggert 35074660dc
chore: Prevent test suite artifact creation in work directory (#6438)
* chore: Prevent test suite artifact creation in work directory

Also remove a few other stale test assets while I'm here.

* Try and fix CI

* Change IDSUBMIT_REPOSITORY_PATH

* Make the dir

* test: clean up media/nomcom directories

* test: de-dup settings_temp_path_overrides

* chore: remove debug

* refactor: avoid premature import of test_utils

* refactor: drop useless lambda wrapper

---------

Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
2024-09-18 14:08:01 -05:00
Jennifer Richards c6389ba65f
fix: only send state change notifications once (#7953)
* feat: split state_change_event create / save

* refactor: avoid double-save in rfceditor.py

* feat: only send notifications on event creation

* test: update test_notification_signal_receiver()

* chore: update comment
2024-09-18 14:02:00 -05:00
Robert Sparks 97b719505e
test: focus on a helper rather than a whole view (#7951) 2024-09-17 13:06:10 -05:00
Robert Sparks 8362b45c8e
fix: optimize and debug has_role and can_manage_some_groups (#7949)
* fix: optimize can_manage_some_groups

* fix: improve cache key

* refactor: extra_role_qs to kwargs and bugfix to cache key

* fix: restrict groupman_role matches to active states

* chore: styling, decommenting, black
2024-09-17 13:05:56 -05:00
Sangho Na 9d583ab9eb
fix: Use email or name when building community list view (#7203)
* fix: Use email or name when building community list view

instead of email

* test: add test case

* chore: remove debug

* fix: use name in community list menu when no active email is found

---------

Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
2024-09-16 10:06:16 -05:00
Robert Sparks cc1eade4f8
fix: correct headers for charter evaluation email (#7937) 2024-09-16 08:57:05 -05:00
Robert Sparks 3b5058a516
fix: start to reconcile internal inconsistencies wrt multiple from values (#7935) 2024-09-16 08:56:51 -05:00
Jennifer Richards f5c132a20a
refactor: helper for session recording URL; fix test (#7933)
* refactor: session recording URL label helper

* test: update tests, avoid tz dependence

* test: use date_today()
2024-09-13 16:42:51 -05:00
Robert Sparks 65547a7a9d
fix: rectify mixed types in gathering mailtrigger recipients (#7932) 2024-09-12 17:04:12 -05:00
Kesara Rathnayake f0f2b6d8b6
test: Use timezone aware datetime (#7918)
* test: Use timezone aware datetime

* fixup! test: Use timezone aware datetime
2024-09-12 12:47:53 -05:00
Sangho Na 8d608a1282
test: check HTML content with whitespace ignored (#7921) 2024-09-12 12:47:15 -05:00
Sangho Na 80599f29f0
fix: Include missing related drafts in IPR searches (#7836)
* fix: Include missing related drafts in IPR searches

* refactor: extract drafts, sort docs

* chore: indent loop and conditionals to improve readability

* test: handle whitespaces added to IPR search result page

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2024-09-10 17:22:45 -05:00