Commit graph

145 commits

Author SHA1 Message Date
Henrik Levkowetz 9f998e5bbc Tweaked code to correct access to document metadata and actions, adding RGs to the groups and group secretaries to the roles which are given access.
- Legacy-Id: 5935
2013-07-31 17:11:19 +00:00
Henrik Levkowetz 8b1b38d57e Added group secretaries to those authorise to edit group document meta-information.
- Legacy-Id: 5933
2013-07-31 16:07:16 +00:00
Henrik Levkowetz b090f1e92c Merged [5903] from adam@nostrum.com:
Added tooltip capability to document tabs, and tooltips for disabled IESG Evaluation/Review tab.  Fixes bug #448.
 - Legacy-Id: 5931
Note: SVN reference [5903] has been migrated to Git commit d87379c177
2013-07-31 14:16:37 +00:00
Henrik Levkowetz 3decaf3300 Added back the 'Request Publication' action (regression loss) on draft pages for the non-ietf streams.
- Legacy-Id: 5921
2013-07-30 14:56:25 +00:00
Henrik Levkowetz 12bd97c7cf Added convenience methods to the Document class to recursively retrieve all forward / reverse relationship of a kind or set of kinds.
- Legacy-Id: 5912
2013-07-29 13:31:18 +00:00
Henrik Levkowetz 7a131cd777 Fixed the handling of help pages for doc states.
- Legacy-Id: 5911
2013-07-29 13:25:10 +00:00
Adam Roach d87379c177 Fixed bug #448 -- added tooltip capability to document tabs
- Legacy-Id: 5903
2013-07-27 14:25:01 +00:00
Henrik Levkowetz 9d2db7c6e4 Additional fix for diff regression: make the RFC part of the version list.
- Legacy-Id: 5884
2013-07-25 19:44:44 +00:00
Henrik Levkowetz a055370da1 Removed debug statement.
- Legacy-Id: 5883
2013-07-25 19:29:05 +00:00
Henrik Levkowetz 75fa9bb0e4 Additional fix for diff regression: make the RFC part of the version list.
- Legacy-Id: 5882
2013-07-25 19:26:14 +00:00
Henrik Levkowetz 5eac4a86ce Additional fix for diff regression: make the RFC part of the version list.
- Legacy-Id: 5881
2013-07-25 19:24:47 +00:00
Henrik Levkowetz 6a2ae39913 Fixed a regression: restore diff pane in history page for RFCs.
- Legacy-Id: 5880
2013-07-25 18:52:24 +00:00
Henrik Levkowetz 3c4bee32e5 Fixed a regression: display of full draft/rfc text now again obeys the full_draft cookie setting.
- Legacy-Id: 5879
2013-07-25 18:29:37 +00:00
Henrik Levkowetz cbfe489ff5 Merged in more shim-layer removals from olau@iola.dk
(-r5465:HEAD from branch/iola/shimfree).  Copying relevant
commit messages here:

 - Deleted dead code in many places.

 - Renamed id-something to draft-something, make the "is
   this eligible for expiration" logic clearer

 - Added a name for IPR search URL

 - Revamped the ballot popup view

 - URL reversed the IPR search link instead of hardcoding it

 - Cleaned up search views and remove dead code, port them to the new DB
   schema, hack related views in iesg/ and wginfo/ to use the new search
   interfaces, avoid camelCase in search GET parameters (with
   backwards-compat fallback), add some simple search unit tests, remove
   caching from views_search.py index pages as they're now pretty fast to
   generate, rewrite ballot popup JS, regularize some CSS classes to use
   hyphen-notation rather than camelCase, move some of the search
   templates to doc/.

   idrfc/ now mostly contains some wrapper code still in use by other
   subdirs, some ported code not yet moved, and dead code.

 - Fixed output bug in test crawler and print referrer upon errors so it's
   easier to figure out where a link came from

 - Added /doc/in-last-call/ to crawler, report original page as referrer in
   a redirect chain rather than intermediate URL

 - Ported idindex to new schema, speed them up, add tests, refactor index
   page in views_search to share code with the text index file, get rid
   of some special-case idindex filters from ietf_filters, move
   "/drafts/" redirects to a file in /doc/

 - Ported /idtracker/status/ and /idtracker/status/last-call/ overview of
   drafts in IESG process to new schema in /doc/iesg/ and
   /doc/iesg/last-call/

 - Added redirects for all of /idtracker/*, removed all view code and other
   dead code from idtracker/

 - Removed the idtracker sitemap indexing drafts - in its current form,
   it adds nothing of value to the HTML-based /doc/all/ view, and it's
   pretty slow

 - Ported idtracker feeds to new schema, move them to doc/, cleaned up
   idtracker/ - only templatetags/ietf_filters and proxy code is left
 - Legacy-Id: 5836
2013-07-17 20:52:39 +00:00
Henrik Levkowetz 68b05b609a Various fixes due to clear up tree conflicts and other bugs resulting from
the [5830] merge.
 - Legacy-Id: 5834
Note: SVN reference [5830] has been migrated to Git commit e678659b56
2013-07-16 14:02:43 +00:00
Henrik Levkowetz e678659b56 Merged in a lot of shim-layer removals from olau@iola.dk
(-r5194:5465 from branch/iola/shimfree).  Copying relevant
commit messages here:

  - Removed .related many to many relationship, it's not really useful
    since we always have to restrict on the relationship type anyway,
    instead add two helpers for doing the necessary queries (in both
    directions)

  - Added migration for transforming the .desc on the new_revision events
    into something more akin to what is actually shown in the history page

  - Added migration for blanking IESG notes that just consist of "RFC
    XXXX", these have been superfluous for some time

  - Grant stream chairs access to changing the stream on a draft

  - Hacked the format_history_text filter to be less weird, using the same
    formatting for snippets and full text, also link up legacy ballot set
    events

  - Moved the decoraters + utilities to new ietfauth/utils.py file

  - Added simple helper to Email to identify invalid email addresses (from
    legacy author entries)

  - Used new new_revision .desc format for when drafts are submitted

  - Improved the looks of the button class by adding extra contrast and a
    linear gradient. Currently the gradient is only visible in fairly
    recent browsers.

  - Rewrote draft and RFC tabs in terms of the new schema, porting
    write-up and history tabs as well

  - Fixed two bugs in RFC Editor syncing: make sure documents we don't know
    beforehand get a "draft" type and make sure individually submitted
    drafts get the type="individ" group instead of NULL

  - Made the CSS-styled button feel a bit nicer to use by flattening the
    active state, also introduce some temporary styles until browsers
    catch up with the standard syntax

  - Added migrations for fixing 1) a dummy RFC entry, 2) three stand-alone
    RFCs that didn't get their doc.type set, 3) a big bunch of historic
    stand-alone RFCs that have doc.group=None - set these to the
    individual submission "none" group for the time being so the view code
    doesn't have to deal with a special case.

    In some cases this is wrong since there actually was a WG associated
    but unfortunately fixing them properly requires detective work
    (probably parsing the RFCs) and in at least some cases recreating
    historic WGs. In case someone ends up doing this, the documents to
    check can still be found with

    Document.objects.filter(name__startswith="rfc", group__type="individ")
    since there are almost no new RFCs that didn't went through the I-D
    process.

  - Merged the I-D and RFC views by showing I-D information on RFCs too.
    I-Ds that have been published as RFCs redirect to the RFC URL. Also
    support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.

  - Fixed revision augmentation so events after RFC publication gets a "RFC"
    designation

  - Fixed a bug with tabs not using provided name but rather doc.name

  - Displaying draft-iesg state rather than doc.friendly_state as IESG state,
    also show a notice that the IESG state refers to post-RFC processing
    if it does, like the old separate RFC page did

  - Fixed the RFC number doc.note migration to catch combined "RFC XXX; BCP
    XXX" notes too, use the opportunity to remove inserted HTML tags from
    notes and rely on linebreaksbr filter instead (the other thing was a
    left-over from the Perl days), update the various uses of the note to
    reflect that

  - Refactored slightly to make views_doc.py independent of other idrfc code

  - Moveed idrfc/views_doc.py to doc/ with associated templates, replace the
    somewhat fragile simple URL tests for views_doc.py with ordinary unit
    tests. The new tests are still fairly basic but at least test more
    than the URL tests did.

  - Made sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
    RFC0123 in the alias table with a new migration and a change to the
    RFC Editor sync, this in turn makes /doc/std1/ do the right thing

  - Now /doc/std1/ works, we can actually do a local link in
    urlize_ietf_docs rather than linking to the tools.ietf.org server

  - Fixed history text formatter: sanitize HTML before adding linebreaks and
    non-breaking spaces, this cuts the time to render a history page with
    long comments in half

  - Added a test crawler that walks through the crawlable part of the site,
    reporting errors and slow pages

  - Got rid of initial "No record" positions when showing old positions,
    it's just noise

  - Added a .select_related() to the document main tab to reduce the number
    of DB queries, unfortunately it seems it doesn't really help with
    Django 1.2.x due to a bug (Document inherits from DocumentInfo which
    makes things a bit more complicated)

  - Introduced a simple cache in doc.get_state so repeated reads don't
    cause a DB query

  - Cleaned up the search code in preparation for removal of the shim-layer;
    use a static button and don't send extraneous GET parameters

  - Removed dead code in several places
 - Legacy-Id: 5830
2013-07-15 20:55:24 +00:00
Henrik Levkowetz 1aacb9fa45 Save document before set_state, to maintain database consistency.
- Legacy-Id: 5820
2013-07-14 14:52:00 +00:00
Henrik Levkowetz 1d7218df94 Save document before set_state, to maintain database consistency.
- Legacy-Id: 5819
2013-07-14 14:41:01 +00:00
Robert Sparks a741642717 Added editing last call messages, requesting, issuing and tracking IETF LCs to status-change documents
Added a Cancel button to the form that allows editing the relations for status-change documents
Added instructions to the agenda section 3.3

This adds states to status-change- documents and has a migration that must be applied.

This fixes bug #1039
 - Legacy-Id: 5770
2013-06-01 21:01:45 +00:00
Henrik Levkowetz bd0c07290a Merged in branch/iola/milestones, which provides datatracker support for management of WG milestones.
- Legacy-Id: 5739
2013-05-15 22:07:23 +00:00
Ole Laursen 7892e29036 Port idtracker feeds to new schema, move them to doc/, clean up
idtracker/ - only templatetags/ietf_filters and proxy code is left
 - Legacy-Id: 5643
2013-04-11 14:20:42 +00:00
Ole Laursen ec920d5a83 Add redirects for all of /idtracker/*, remove all view code and other
dead code from idtracker/
 - Legacy-Id: 5640
2013-04-11 11:54:35 +00:00
Ole Laursen 4db36b0fbc Add a generic state help page, make provisions for displaying
IESG I-D states in it
 - Legacy-Id: 5635
2013-04-10 16:11:27 +00:00
Ole Laursen 3d1eb07afe Port idindex to new schema, speed them up, add tests, refactor index
page in views_search to share code with the text index file, get rid
of some special-case idindex filters from ietf_filters, move
"/drafts/" redirects to a file in /doc/
 - Legacy-Id: 5634
2013-04-10 11:48:07 +00:00
Henrik Levkowetz 0a76a26ed7 Fixed the additional nit mentioned in issue #974 better. Together with earlier commits, this fixes #974.
- Legacy-Id: 5632
2013-04-08 20:21:09 +00:00
Henrik Levkowetz 7a98fff79c Merged [5476] from rjsparks@nostrum.com:
* Added a document type for changing the publication status of other documents, and the UI for manipulating them.
* Added charters, conflict reviews, and status changes to the AD's \'My Documents\' page
* Improved the presentation of all document types on the Agenda, Future Telechats, Scribe and Moderator package pages
* Made the reverse name for document relationships explicit rather than deriving them from forward names
* Added a way to get to the underlying Document (when it exists) from an RfcWrapper
* Unified several common forms used by different document types
 - Legacy-Id: 5629
Note: SVN reference [5476] has been migrated to Git commit 10b4f7a4dc
2013-04-07 19:11:18 +00:00
Henrik Levkowetz 7ac4113751 Import math as needed. Related to [5626] and issue #974.
- Legacy-Id: 5628
Note: SVN reference [5626] has been migrated to Git commit fb1df9e2eb
2013-04-07 17:10:19 +00:00
Henrik Levkowetz f3833e1d17 Fixed another issue with the ballot counts (unreachable code). See issue #974.
- Legacy-Id: 5627
2013-04-05 14:07:59 +00:00
Henrik Levkowetz fb1df9e2eb Fixed the ballots needed count error in two more places. See issue #974.
- Legacy-Id: 5626
2013-04-05 14:06:13 +00:00
Henrik Levkowetz b183273c72 Add new tag 'rev-wg' to the list of valid annotation tags for the ietf stream. Note: This list and those on nearby lines needs to be refactored into a table, instead of sitting in the code.
- Legacy-Id: 5623
2013-04-05 11:19:35 +00:00
Ole Laursen e94d1df549 Clean up search views and remove dead code, port them to the new DB
schema, hack related views in iesg/ and wginfo/ to use the new search
interfaces, avoid camelCase in search GET parameters (with
backwards-compat fallback), add some simple search unit tests, remove
caching from views_search.py index pages as they're now pretty fast to
generate, rewrite ballot popup JS, regularize some CSS classes to use
hyphen-notation rather than camelCase, move some of the search
templates to doc/.

idrfc/ now mostly contains some wrapper code still in use by other
subdirs, some ported code not yet moved, and dead code.
 - Legacy-Id: 5611
2013-04-04 13:42:57 +00:00
Ole Laursen 5a1a2b4f65 Revamp the ballot popup view
- Legacy-Id: 5609
2013-04-04 13:26:08 +00:00
Joel M. Halpern fe13ee8dfa Repair the ballot requirements string
- Legacy-Id: 5516
2013-03-09 18:30:29 +00:00
Henrik Levkowetz 2f3476690f In order that document states (which may be used by old documents) should not need to be removed when state machines change and states go out of use, all document states have a 'used' field. The code which accesses the state fields have not been requiring that used=True for the states returned, which is an error. Fixed this by adding 'used=True' to all State.objects.get() and State.objects.filter() call where it's relevant.
- Legacy-Id: 5486
2013-03-05 23:24:41 +00:00
Robert Sparks 10b4f7a4dc * Added a document type for changing the publication status of other documents, and the UI for manipulating them.
* Added charters, conflict reviews, and status changes to the AD's "My Documents" page
* Improved the presentation of all document types on the Agenda, Future Telechats, Scribe and Moderator package pages
* Made the reverse name for document relationships explicit rather than deriving them from forward names
* Added a way to get to the underlying Document (when it exists) from an RfcWrapper
* Unified several common forms used by different document types
 - Legacy-Id: 5476
2013-03-01 15:47:51 +00:00
Robert Sparks 33e2a0766e Repairing migration merge conflict
- Legacy-Id: 5423
2013-02-04 02:34:01 +00:00
Robert Sparks 8a7c5ac977 All documents show on the AD status page now
- Legacy-Id: 5422
2013-02-04 02:24:14 +00:00
Robert Sparks c67661311f Improved validaiton of status change document name
added the ability to start a status change when looking at an RFC (populating the start from accordingly)
Made changes and proposed changes show on the RFC pages
 - Legacy-Id: 5330
2013-01-28 16:25:42 +00:00
Robert Sparks 589ff698ee Merge forward complete
- Legacy-Id: 5328
2013-01-24 21:28:27 +00:00
Ole Laursen 4b312de464 Introduce a simple cache in doc.get_state so repeated reads don't
cause a DB query
 - Legacy-Id: 5314
2013-01-21 14:01:33 +00:00
Ole Laursen 06f4ed4cf3 Add a .select_related() to the document main tab to reduce the number
of DB queries, unfortunately it seems it doesn't really help with
Django 1.2.x due to a bug (Document inherits from DocumentInfo which
makes things a bit more complicated)
 - Legacy-Id: 5313
2013-01-21 12:27:26 +00:00
Ole Laursen ab6a7f85c0 Get rid of initial "No record" positions when showing old positions,
it's just noise
 - Legacy-Id: 5312
2013-01-21 11:54:56 +00:00
Ole Laursen 9bcc4a9f3d Remove ballot.tsv view and comment out the ballot.json view in urls.py
- Legacy-Id: 5299
2013-01-18 13:54:33 +00:00
Ole Laursen 7998371ace Make sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
RFC0123 in the alias table with a new migration and a change to the
RFC Editor sync, this in turn makes /doc/std1/ do the right thing
 - Legacy-Id: 5296
2013-01-18 13:47:31 +00:00
Ole Laursen accf6d4470 Move idrfc/views_doc.py to doc/ with associated templates, replace the
somewhat fragile simple URL tests for views_doc.py with ordinary unit
tests. The new tests are still fairly basic but at least test more
than the URL tests did.
 - Legacy-Id: 5295
2013-01-18 13:17:00 +00:00
Ole Laursen 1a3aa3b443 Refactor slightly to make views_doc.py independent of other idrfc code
- Legacy-Id: 5294
2013-01-18 10:32:05 +00:00
Ole Laursen ce081cb31d Fix the RFC number doc.note migration to catch combined "RFC XXX; BCP
XXX" notes too, use the opportunity to remove inserted HTML tags from
notes and rely on linebreaksbr filter instead (the other thing was a
left-over from the Perl days), update the various uses of the note to
reflect that
 - Legacy-Id: 5289
2013-01-17 17:10:19 +00:00
Ole Laursen 188c619635 Display draft-iesg state rather than doc.friendly_state as IESG state,
also show a notice that the IESG state refers to post-RFC processing
if it does, like the old separate RFC page did
 - Legacy-Id: 5288
2013-01-17 16:02:50 +00:00
Ole Laursen 5efcc5fbef Fix revision augmentation so events after RFC publication gets a "RFC"
designation
 - Legacy-Id: 5286
2013-01-17 15:39:57 +00:00
Ole Laursen c0ecb78761 Merge the I-D and RFC views by showing I-D information on RFCs too.
I-Ds that have been published as RFCs redirect to the RFC URL. Also
support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.
 - Legacy-Id: 5285
2013-01-17 13:28:42 +00:00