altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
4407 commits 1 branch 0 tags 2.6 GiB
Commit graph

3763 commits

Author SHA1 Message Date
Ole Laursen 87ca10d122 Remove usage of log_state_changed (and duplicate in 
doc/utils_charter.py) in favour of add_state_change_event which has
slightly better API but otherwise does basically the same except it
sets an event type we can later search for. Also expand tests slightly
to exercise three more templates.
 - Legacy-Id: 7129
 2014-01-15 17:52:00 +00:00
Ole Laursen 6b2d50db93 Implement missing charter tests as found by the coverage check 
- Legacy-Id: 7127
 2014-01-14 15:50:03 +00:00
Ole Laursen 7e00fa1424 Move the Secretariat group email utility to wginfo and the rest of the wgcharter stuff to doc/(views|urls|utils)_charter.py alongside the other document types 
- Legacy-Id: 7121
 2014-01-13 16:08:58 +00:00
Ole Laursen c4313a4f42 Add rel="nofollow" to a couple of the account links to prevent the 
test crawler from going to /account/login/ and getting an error back,
with this change the crawler currently runs without reporting any
errors
 - Legacy-Id: 7114
 2014-01-13 12:21:46 +00:00
Ole Laursen 591e90a7a0 Put a proper command-line interface on the test crawler, spit out number of errors (if any), also add wrapper script for running the test-crawler and idindex generation scripts, in the future other (safe, non-mutating) scripts operating on real data can be added too 
- Legacy-Id: 7107
 2014-01-12 16:55:42 +00:00
Ole Laursen be8eb96bec Get rid of a bunch of DB queries in all_id2_txt 
- Legacy-Id: 7106
 2014-01-12 14:16:37 +00:00
Ole Laursen fe6c2d67c4 Replace the Http404 in release/views.py if the changelog file is not 
found with a simple error message, this mimicks the way the rest of the
Datatracker is handling missing files and avoids an annoying 404 when
running the test-crawler without all directories set up
 - Legacy-Id: 7105
 2014-01-10 17:55:50 +00:00
Ole Laursen 5dcd140a63 Improve test-crawler regexp so it can catch and visit linked feed URLs 
- Legacy-Id: 7104
 2014-01-10 17:34:33 +00:00
Ole Laursen b4dfae121b Integrate old patch for warning on the request for publication page if 
intended std level and consensus is not filled in for the draft before
sending it (as per discussion with Alice Russo) - the consensus check
is skipped for ISE drafts
 - Legacy-Id: 7103
 2014-01-10 17:16:12 +00:00
Ole Laursen 2196e75550 Remove more Javascript left-over includes from nomcom/ and one in community/ 
- Legacy-Id: 7100
 2014-01-10 14:57:45 +00:00
Ole Laursen 2922495e65 Fix bug in community list, the show_field templatetag is now getting 
the fields already instantiated while the tag was expecting to
instantiate them
 - Legacy-Id: 7099
 2014-01-10 14:50:17 +00:00
Ole Laursen ab382a726f While cleaning up the Javascript includes in the nomcom app, it turns 
out nomcom.js is included in the wrong pages, and on the pages it is
actually useful in, it's obsolete, so delete it together with the
obsoleted AJAX view and the other JS left-over cruft in nomcom/, this
fixes an include 404 and removes the remaining dependency on
jquery-1.5.1 apart from the Secretariat tools
 - Legacy-Id: 7097
 2014-01-10 14:06:36 +00:00
Ole Laursen f685e45ca5 Add select_related to PositionNomineeField in nomcom app to save a 
bunch of database queries
 - Legacy-Id: 7095
 2014-01-10 13:13:03 +00:00
Ole Laursen 1fb05041cc Fix duplicate name in recently added stream tests 
- Legacy-Id: 7093
 2014-01-09 18:11:12 +00:00
Ole Laursen 29c72ab386 Add missing tests for group documents in text format and an AJAX view 
- Legacy-Id: 7092
 2014-01-09 18:08:42 +00:00
Ole Laursen f591735b7d Fix subtle search bug found by stream pages tests, the query was 
checking a StreamName against the slug, which happened to work with
MySQL because the stream name is the same as the slug, just uppercase
- but MySQL is case insensitive
 - Legacy-Id: 7091
 2014-01-09 17:52:42 +00:00
Ole Laursen be475b8996 Add missing tests of stream document pages 
- Legacy-Id: 7090
 2014-01-09 17:51:05 +00:00
Ole Laursen 0b27ff13ec Add missing test of AJAX person search view, found by coverage check 
- Legacy-Id: 7089
 2014-01-09 17:19:56 +00:00
Ole Laursen 72db45734b Add missing sync notify page test, found by coverage check 
- Legacy-Id: 7088
 2014-01-09 17:13:10 +00:00
Ole Laursen 84136cb5ae Add missing doc page tests, found by the coverage check 
- Legacy-Id: 7087
 2014-01-09 17:03:59 +00:00
Ole Laursen 86f2baea0a Move group feed from wgcharter (where it historically ended up) to wginfo, add test 
- Legacy-Id: 7086
 2014-01-09 16:24:54 +00:00
Ole Laursen 7dcaed414d Add a simple test of the dajaxice.core.js hack for the time being 
- Legacy-Id: 7084
 2014-01-08 18:13:10 +00:00
Ole Laursen 3db6ae14a9 Add missing test of IPR details page, as found by coverage check 
- Legacy-Id: 7083
 2014-01-08 18:07:43 +00:00
Ole Laursen 5c63ed982a Implement missing iesg test of milestones page, as found by the 
coverage check
 - Legacy-Id: 7082
 2014-01-08 17:59:00 +00:00
Ole Laursen 09859b9e6a Implement missing submit tests as spotted by the coverage check 
- Legacy-Id: 7081
 2014-01-08 17:47:39 +00:00
Ole Laursen 954c8fcedb Fix spelling mistake in patterns that are ignored in coverage check 
- Legacy-Id: 7080
 2014-01-08 17:41:40 +00:00
Ole Laursen 5e7d8c6c08 Fix auth check for editing the metadata of a submission - the path 
without an access token would not allow a Secretariat user but instead
always throw an exception
 - Legacy-Id: 7079
 2014-01-08 17:40:22 +00:00
Ole Laursen 8dc19fd17e Improve the coverage checker, skip some trivial views (redirects and 
flat templates)
 - Legacy-Id: 7078
 2014-01-08 17:00:37 +00:00
Ole Laursen c7a2c64c10 Get rid of fixtures that were added for the meeting tests previously, they are not used anymore, and incomplete so will not load with Django 1.6 
- Legacy-Id: 7070
 2013-12-24 16:14:05 +00:00
Ole Laursen d5b14f3fb3 Rewrite meeting tests: add fake data generator, rewrite the 
SimpleUrlTest tests to work with fake data and expand them a bit (they
are still pretty basic), rewrite the agenda editing tests to work with
the small generated fake data, delete those tests that are trivial or
only testing fixture facts as opposed to actually exercising the code,
combine some of them, expand most to actually check the returned JSON
and generally clean up the copy-paste mess of incorrect comments and
incorrect POST data.

At this point, no tests are using the real data base test machinery,
so one can run the full test suite with just

  python manage.py test --settings=settings_sqlitetest

This takes about 72 seconds one a 2.4 GHz Intel Core 2. The
test-crawler and other real data tests take somewhat longer, though.
 - Legacy-Id: 7069
 2013-12-24 16:09:33 +00:00
Ole Laursen 3408b73872 Use request.POST directly instead of aliasing it to update_dict, add a 
FIXME on permission naming
 - Legacy-Id: 7068
 2013-12-24 15:59:01 +00:00
Ole Laursen f8b1568c87 Rewrite meeting PUTs to POSTs. For no apparent reason, parts of the 
meeting AJAX code is using PUT instead of POST (even if it's not
PUT'ing in the literal sense but POST'ing). Theoretical discussions
aside, Django has poor support for PUTs turned POSTs so rewriting them
removes the need for a couple of hacks, and makes it easier to test.
 - Legacy-Id: 7067
 2013-12-24 15:13:33 +00:00
Ole Laursen 083b3138c6 Rename group AJAX URL parameter to acronym instead of groupname since 
it is in fact the acronym, not the name of the group
 - Legacy-Id: 7064
 2013-12-24 12:49:25 +00:00
Ole Laursen c098fb4f07 Regularize meeting_json to take num instead of meeting_num like the 
other meeting AJAX views
 - Legacy-Id: 7060
 2013-12-23 17:19:49 +00:00
Ole Laursen 77bd8772b5 Fix interesting syntax error in group_session_mapping, += was mistyped 
as =+ which is legal (assignment followed by unary +)
 - Legacy-Id: 7059
 2013-12-23 16:59:21 +00:00
Ole Laursen b4fa414406 Make agenda_permission use user_is_person, rewrite it to be a little 
less verbose
 - Legacy-Id: 7054
 2013-12-23 16:43:44 +00:00
Ole Laursen e69ba1e8c4 Fix spelling mistakes in comments for Constraint 
- Legacy-Id: 7053
 2013-12-23 16:08:36 +00:00
Ole Laursen b42a1165d7 Use .first() and prevent an extra .count() query in TimeSlot.session 
- Legacy-Id: 7052
 2013-12-23 15:40:10 +00:00
Ole Laursen 7dc534f325 Add a couple of select_related fields to edit_timeslots to reduce 
number of DB queries from 400 to 13
 - Legacy-Id: 7051
 2013-12-23 13:25:22 +00:00
Ole Laursen d6d80a4a77 Make a couple of the utility methods in meeting.models use .first(), 
fix potential bug in slot_to_the_right, test on location_id instead of
location in build_timeslices to speed up the edit timeslots view
 - Legacy-Id: 7050
 2013-12-23 13:24:40 +00:00
Ole Laursen a5f5eb84d3 With the new test discovery mechanism in Django 1.6 (inherited from 
unittest2 in Python 2.7), manually importing tests from files starting
with test* will run them twice, so don't do that
 - Legacy-Id: 7030
 2013-12-20 13:08:38 +00:00
Ole Laursen 3fa1834986 Remove Person.objects.by_username/by_email for now - they aren't actually in use, the email one looks suspicious in that it takes the email from the User object, and the username one does not seem generally useful; also remove the unit tests of these two which was relying on an incomplete fixture 
- Legacy-Id: 7029
 2013-12-20 12:13:02 +00:00
Ole Laursen fa489ce37a Upgrade Dajaxice to latest version from github (0.5.5) to make meeting agenda code work with CSRF, with url conf import fix and using json instead of deprecated simplejson from Django - add a simple view to serve dajaxice.core.js which we need because we are not using the staticfiles collection step (apparently Dajaxice hooks into that through a somewhat complicated hack) 
- Legacy-Id: 7028
 2013-12-20 11:59:09 +00:00
Ole Laursen 88860edba4 Use user_is_person to determine whether user is schedule owner in 
agenda AJAX, instead of complicated try except
 - Legacy-Id: 7027
 2013-12-20 11:55:25 +00:00
Ole Laursen fdb6baf4e6 Use collections.OrderedDict instead of the SortedDict bundled with Django 
- Legacy-Id: 7026
 2013-12-20 11:00:07 +00:00
Ole Laursen 38c153c03d Remove usage of distinct(field) in meeting/helpers.py, Django 
complains that it doesn't work on MySQL and the two uses appear
superfluous anyway since they only return the field being distincted
 - Legacy-Id: 7018
 2013-12-19 16:06:37 +00:00
Ole Laursen 2cc2323b06 Speed up IPR list by adding a prefetch_related() call 
- Legacy-Id: 7017
 2013-12-19 11:53:41 +00:00
Ole Laursen defb116721 Use prefetch_related to reduce the number of queries on the search page and in idindex generation, adjust a couple of members on Document slightly to not filter on relations (filtering doesn't work with prefetch_related) 
- Legacy-Id: 6992
 2013-12-18 16:58:34 +00:00
Ole Laursen a656cf8a8b Add .prefetch_related on liaison list page to reduce the number of DB 
queries (from 571 to 28)
 - Legacy-Id: 6991
 2013-12-18 16:30:18 +00:00
Ole Laursen cb4d5b7c2b Simplify make_test_data a bit by using the create_person helper for the chair and WG delegate, regularize the naming of those 
- Legacy-Id: 6990
 2013-12-18 16:27:02 +00:00