Commit graph

11840 commits

Author SHA1 Message Date
Lars Eggert 97df94f41d
fix: Add footer with group interim ics calendar to announce email (#5279)
* fix: Add footer with group interim ics calendar to announce email

Fixes #2939

* Fix test
2023-03-03 10:32:15 -06:00
Robert Sparks fce28e78f9
fix: case sensitivity for Subscribed.email (#5270) 2023-03-03 09:05:17 -06:00
Lars Eggert 6f8cba5cd6
fix: Truncate text agenda labels to not overflow colums (#5276)
* fix: Truncate text agenda labels to not overflow colums

Also tweak the spacing some and add a guard for an undefined field.

Fixes #1313

* Fix test
2023-03-03 08:56:09 -06:00
Jennifer Richards 8041cd5c40
fix: Avoid unwanted whitespace when action_holder_badge is empty (#5266) 2023-03-02 15:17:39 -06:00
Lars Eggert 276dd08794
fix: Don't offer already-disabled API keys for disablement (#5262)
* fix: Don't offer already-disabled API keys for disablement

Fixes #3441

* Remove test class
2023-03-02 10:18:51 -06:00
Jennifer Richards 963b1bd197
test: Use actual room pk instead of assuming keys start at 1 (#5255) 2023-03-01 15:08:40 -06:00
Lars Eggert 5fc93bb8ca
fix: Link to IPR details not history in email (#5252)
* fix: Link to IPR details not history in email

Fixes #5251

* Fix test
2023-03-01 13:02:31 -06:00
Lars Eggert 4f9be6e8a0
fix: Restore correct operation of column sort headers. (#5253)
Fixes #5234. Was broken in c061caa.
2023-03-01 10:45:25 -06:00
Robert Sparks 82f23da2b3
Merge remote-tracking branch 'ietf-tools/main' into feat/postgres 2023-02-28 16:25:46 -06:00
Jennifer Richards 91a6c9a0df
chore: Remove unused ajax_get_utc() view and related plumbing (#5239)
* chore: Remove unused get_ajax_utc() view and related plumbing

* chore: Remove accidentally committed code
2023-02-28 14:36:55 -06:00
Jennifer Richards 0377ebdd28
feat: Put agenda.csv in meeting TZ and add agenda-utc.csv endpoint (#5226)
* fix: Let csv.writer handle encoding for agenda_csv view

* style: Use 'is None' instead of '== None'

* feat: Display times in meeting time for agenda.csv

* feat: Provide agenda-utc.csv view

* test: Test agenda.csv time zone and agenda-utc.csv endpoint
2023-02-28 14:31:07 -06:00
Robert Sparks 1f990bce1d
Merge branch 'main' into feat/postgres 2023-02-28 14:19:59 -06:00
Robert Sparks e8f4ddd26b
fix: adjust type of fk from community to doc (#5240) 2023-02-28 14:14:30 -06:00
Jennifer Richards 1eb16c9002
fix: Let csv.writer handle encoding for agenda_csv view (#5225) 2023-02-28 11:57:16 -06:00
Robert Sparks 74990cfcb8
fix: improve api key delete form validation and tests (#5236) 2023-02-28 11:54:45 -06:00
Jennifer Richards 9a1de57c9e
fix: Only consider ietf meetings as "next" for agenda_ical or agenda_json (#5238)
* style: Clean up get_meeting() signature and code style

* chore: Remove unused parameter from agenda_ical() view's signature

* fix: Only consider ietf meetings as "next" in agenda_ical

* fix: Only consider ietf meetings as "next" in agenda_json

* test: Test agenda_json "next meeting" and clean up agenda_ical test

* style: Reformat new tests using Black style
2023-02-28 11:47:20 -06:00
Lars Eggert cf94b896c8
feat: Add reminder that AD changes for approved documents are unusual (#5231) 2023-02-28 10:21:39 -06:00
Jennifer Richards 8e16b4405b
fix: Support time zones in agenda.txt; restore agenda-utc.txt (#5233)
* fix: Format times in display timezone in agenda.txt template

* chore: Remove unused and non-timezone-friendly TimeSlot.time_desc()

* feat: Dispatch agenda-utc.txt URL

* refactor: Use None to indicate lack of utc parameter to view

* feat: Show display timezone in agenda.txt template

* refactor: Combine URL regexes for the agenda.txt to a single entry

* test: Update tests for agenda.txt/agenda-csv.txt

* fix: Remove ':' added to time formats in agenda.txt template
2023-02-28 10:16:39 -06:00
Ryan Cross e469addcb2
feat: move IETF Activity reports from external text based to HTML pages (#5180)
* feat: move IETF Activity reports from external text based to HTML pages

* fix: use date_today(), fix fencepost problem

* fix: use is_meeting_report template variable instead of is_monthly_report
2023-02-27 16:58:59 -06:00
Robert Sparks f010766654
Merge remote-tracking branch 'ietf-tools/main' into feat/postgres 2023-02-27 12:55:47 -06:00
Lars Eggert caf80efd84
feat: Prefill the abstract, shepherd and AD info into a ballot writeup (#5218)
* feat: Prefill the abstract, shepherd and AD info into a ballot writeup

* Suggestions from @rjsparks

* Remove instructions to add IANA Expert template.

* Make "notes" fields for various bodies conditioned on the doc stream
2023-02-27 12:19:39 -06:00
Jennifer Richards a2bdd3109c
fix: Use session.order_in_meeting() in the agenda (#5222) 2023-02-27 12:18:12 -06:00
Robert Sparks 5c9a3642bd
fix: point menu item for editoral stream to rswg documents (#5206)
* fix: connect the menu item for the editoral stream to the rswg documents page.

* chore: repair merge damage

* fix: address review by shortcircuiting redirects
2023-02-27 08:40:43 -06:00
Jennifer Richards 0ec12647e1
fix: Add order_number to sessions in group.views.meetings() (#5209) 2023-02-24 15:07:45 -06:00
Robert Sparks cbe534ee06
fix: use the intended state machine in person doc searches (#5204)
* fix: use the intended state machine in  person doc searches

* chore: apply black to two touched functions
2023-02-24 12:27:17 -06:00
Jennifer Richards 91be593c82
fix: Use more robust filename/rev matching for meeting materials (#5192)
* fix: Use more robust filename/rev matching for meeting materials

* chore: Remove debug statement

* test: Update test to catch bug fixed by this PR

* fix: Be more discerning when parsing revision

* test: Update test to exercise revision parsing/validation

* style: Apply Black styling to replaced code
2023-02-24 12:26:53 -06:00
Lars Eggert 02f8bf20ef
feat: Add a "report errata button" (#5193)
And also rename "report a bug" to "report a datatracker bug", in the hopes of
reducing GitHub tickets that are not datatracker-related.
2023-02-24 09:13:00 -06:00
Robert Sparks b9baa6270e
chore: remove a stray space that crashes black (#5185) 2023-02-23 08:50:24 -06:00
Kesara Rathnayake cedf6a47ab
feat: Include previous draft URL in /api/rfcdiff-latest-json (#5172) 2023-02-22 12:09:32 -06:00
Lars Eggert d6d1525da2
feat: Add group stats sunburst plots to active WG page (#5126)
* feat: Add group stats sunburst plots to active WG page

* Cleanups

* Sort/color areas consistently

* Move graphs to area page

* Move sunbursts

* Add test

* Move most sunbursts to modals

* Remove parametrization from URLs

* Fix test

* Make `only_active` a bool

* Reformat

* Reformat more
2023-02-22 12:05:06 -06:00
Jennifer Richards 42096989ec
feat: Include remote instructions and onsite tool in ics files (#5182)
* feat: Add remote_instructions for sessions to agenda.ics

* feat: Add webex/meetecho/remote_instructions to upcoming.ics

* fix: Remove location-based details from interims in upcoming.ics

Interim sessions don't ever seem to have locations, so they won't use
the new code anyway. Leave in the remote-instructions.

* test: Test inclusion/exclusion of remote_instructions in upcoming.ics

* test: Test inclusion/exclusion of remote_instructions in agenda.ics

* feat: Include onsite tool link in agenda.ics

* test: Test inclusion of meetecho onsite and remote URLs in agenda.ics
2023-02-22 11:34:28 -06:00
Lars Eggert 90b6cf4ba5
fix: Don't show replaced, expired or otherwise abandoned docs for AD (#5162)
* fix: Don't show replaced, expired or otherwise abandoned docs for AD

Fixes #5153 and #2889.

* Fix filter conditions

* Update ietf/doc/views_search.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-02-21 17:18:52 -06:00
Lars Eggert cb7abbceab
fix: Prevent ADs and chairs from being added to bethere constraint (#5169)
* fix: Prevent ADs and chairs from added to `bethere` constraint

Fixes #5163 and #3890

* Fix tests and change from "people" to "participants", to hopefully make it
clearer it's not ADs and chairs.

* Rewrap

* Update ietf/secr/sreq/forms.py

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
Co-authored-by: Jennifer Richards <jennifer@painless-security.com>
2023-02-21 11:03:33 -06:00
Jennifer Richards dcdc4af3e0
feat: Use case-insensitive matching for document searches (#5166)
* fix: Use case insensitive match for group acronym in doc search

* fix: Use case insensitive match for doc.search_by_name view

* fix: Use case insensitive match for doc names in ipr.search view

* test: Test case insensitivity in doc search/search_for_name
2023-02-21 10:21:29 -06:00
Jennifer Richards 50601345aa
fix: Sort rooms by ascending capacity in schedule editor (#5178)
* fix: Order rooms by ascending capacity in schedule editor

* chore: Revert unrelated changes accidentally included in commit
2023-02-21 10:18:13 -06:00
Robert Sparks 0ce2b8ef54
fix: cache page content, not page menus (#5170)
* fix: cache page content, not page menus

* fix: close the new cache tags
2023-02-21 10:13:45 -06:00
Robert Sparks c38ade6e1b
feat: treat django auth username as case insensitive throughout the datatracker (#5165)
* feat: insensitive username matching at django authentication

* feat: use iexact when using the User object manager

* fix: more places to ignore username case

* fix: remove unused management command

* fix: avoid get when probing for object existance

* fix: force lowercase new usernames in secr/rolodex

* fix: use explicit arguments when creating user
2023-02-21 10:01:03 -06:00
Jennifer Richards 6a3694e814
fix: Guard against null form-group around name fields in sreq view (#5175) 2023-02-21 09:53:57 -06:00
Jennifer Richards 957f560ac2
feat: Grab slides for reorder using the handle instead of entire row (#5176) 2023-02-21 09:43:06 -06:00
Lars Eggert 07b10b221b
fix: Point to IAB liaison page from datatracker liaison pages (#5168)
Fixes #4971
2023-02-17 17:33:15 -06:00
Kesara Rathnayake f70ce3eaab
fix: Move rfcdiff-latest-json API call from /doc to /api (#5155)
Old /doc/rfcdiff-latest-json/ URL is changed to a permanent redirect to
/api/doc/rfcdiff-latest-json/
2023-02-17 10:39:47 -06:00
Lars Eggert 81ffad9852
fix: add distinct() to sync/discrepancies (#5167)
Fixes #5129
2023-02-17 09:54:07 -06:00
Jennifer Richards f9c2376d27
feat: Return to expected schedule after editing sessions/timeslots (#5158)
* fix: Return to the expected schedule after editing session dteails

* style: Avoid confusing nested double-quotes in html template

* feat: When possible, add "back to agenda" button to edit_timeslots

* chore: Propagate 'sched' to links/includes in timeslot_edit.html

* chore: Propagate 'sched' to links/includes in edit_timeslot() view

* chore: Propagate 'sched' to links/includes in create_timeslot() view

* test: Test sched param propagation in timeslot edit views

* test: Test sched param propagation in session edit view

* test: Fix URL in test_edit_meeting_schedule
2023-02-16 09:57:18 -06:00
Lars Eggert 8734193974
feat: Style preformatted alert messages better (#5152)
* feat: Style preformatted alert messages better

* Fix test
2023-02-16 09:05:32 -06:00
Lars Eggert 0900db01b5
Use viewport-width-based "fluid typography" for font scaling. (#5151)
Instead of media queries. Simplifies the CSS, is more robust, and works for more
screen sizes.
2023-02-15 16:05:29 -06:00
Robert Sparks 9ea8523e85
feat: add target to bibxml-ids (#5148) 2023-02-15 11:37:56 -06:00
Lars Eggert 182158b5c0
fix: Also extract document names from XML seriesInfo attributes and XInclude URLs (#5037)
* fix: Also extract document names from XML seriesInfo attributes

The old code only looked in the anchor string for the document names of
references, which doesn't work if the anchor uses a mnemonic. This caused lots
of missed references for many documents.

* No need to import lxml anymore

* Add tests

* Handle xinclude to bibxml URLs

* Wrap line

* Apply suggestion from @rjsparks

* Undo erroneous additions

* Address suggestion from @rjsparks
2023-02-14 17:07:54 -06:00
Lars Eggert d96c8f7b75
chore: Update to fullcalendar@6 (#5125)
* chore: Update to fullcalendar@6

Also properly apply bs5 styling to upcoming meeting calendar.

* Fix test
2023-02-14 16:22:35 -06:00
Lars Eggert 1e3c826810
fix: Fix document display on very narrow screens (#5080)
Issue by @martinthomson
2023-02-14 16:05:40 -06:00
Jennifer Richards a10464a250
chore: Fix reference to misspelled migration
The migration with the misspelled name already ran on production, so
we have to recreate the typo in the reference to it.
2023-02-14 12:58:45 -04:00
Robert Sparks 7a86a1c2cb
chore: tighten migration dependencies 2023-02-13 17:25:54 -06:00
Jennifer Richards 5abfcd4d71
chore: Update migration numberings/deps 2023-02-13 16:26:25 -04:00
Robert Sparks e1206fa91e
Merge remote-tracking branch 'upstream/main' into feat/postgres 2023-02-13 09:17:05 -06:00
Lars Eggert 800da449f5
fix: Restore responsive font sizes for rfc2html renderings (#5136) 2023-02-13 08:09:42 -06:00
Lars Eggert 1ffe661f6c
fix: add_links_in_new_revision_events wasn't doing anything, remove (#5103)
* fix: `add_links_in_new_revision_events` wasn't doing anything, remove

Whatever `add_links_in_new_revision_events` was supposed to do, it didn't do it.
The linkification of things has been happening via the `format_history_text`
template tag.

* Remove import
2023-02-11 10:31:05 -06:00
Lars Eggert ac0b9ae5e5
fix: Need to linkify during Markdown rendering (#5066)
* fix: Need to linkify during Markdown rendering

* Don't depend on mdx_linkify

* Also linkify IETF docs as part of the Markdown conversion

* Add test case

* Disable automatic links via angle brackets for email addresses

* Inline the markdown test files
2023-02-11 10:13:20 -06:00
Lars Eggert 35f1d21302
fix: Fix deferring ballots from the "edit position" view (#5106)
Fixes #4903
2023-02-11 10:11:05 -06:00
Lars Eggert f8b48f4c43
fix: use Internet-Draft more consistently across the UI (#5104)
* s/Internet Draft/Internet-Draft/i

* s/draft/Internet-Draft/i or s/draft/I-D/i

* s/ID/I-D/

* Fix tests

* a -> an

* Undo case-change to ASCII

* Address code review comments

* Add migrations

* Add merged migration

* fix: straighten out migrations

* fix: finish straightening out migrations

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-02-11 10:09:28 -06:00
Jennifer Richards 45e8f6816e
fix: Link chat log button to chatlog SessionPresentation if available (#5131) 2023-02-11 10:04:27 -06:00
Jennifer Richards 6c31c73eab
feat: Improve links to meeting tools from group pages (#5130)
* chore: Remove unused template parameter from {%include%}

* feat: Add "Meeting tools" section to group session details panel

* feat: Use better label for recordings section after session has ended

* feat: Define template tag to store timezone.now in the render context

* fix: Use get_now tag in session_buttons_include.html

* fix: Update session_details_panel.html to use get_now tag

* refactor: Inject timezone_now from a context processor instead of tag

* chore: Remove unused imports

* chore: Remove unused {%load%}

* chore: Revert renaming of dateformat.py
2023-02-11 10:00:30 -06:00
Lars Eggert 82e0940f2d
fix: Don't show stale area URLs (#5107)
* fix: Don't show stale area URLs

Fixes #4840

* Remove the old code
2023-02-10 14:39:46 -06:00
Lars Eggert 6a6a3db3b9
fix: Don't try to further linkify rfc2html output (#5112)
* fix: Don't try to further linkify rfc2html output

Fixes #5111

* Fix test
2023-02-10 14:33:54 -06:00
Robert Sparks 4309a4bb50
fix: allow rswg chairs to request sessions (#5124)
Fixes #5122
2023-02-10 14:15:16 -06:00
Lars Eggert e280b25d0f
fix: Identify cancelled meetings in calendar (#5117)
Fixes #4815
2023-02-09 17:07:48 -06:00
Jennifer Richards 1fc2042265
feat: Allow agenda_note to be edited from the schedule editor (#5115)
* feat: Add agenda_note to the SessionDetailsForm

* fix: Add hidden agenda_note field to session_details_form.html

* fix: Stop using agenda_note to filter sessions in import_audio_files()

* chore: Migrate sessions with agenda_note='CANCELED' to canceled state
2023-02-09 17:02:41 -06:00
Robert Sparks 6bbad15b3d
fix: restore generation of rswg/rsab chair aliases (#5121) 2023-02-09 16:57:42 -06:00
Jennifer Richards dd7bed47b0
fix: Preserve remote_instructions and short name in secr.sreq.edit() (#5113) 2023-02-08 15:49:18 -06:00
Lars Eggert c5562fbbea
chore: Update deps (#5084)
* chore: Update deps

* Deal with html-validate changes

* Update fullcalendar

* Delete things
2023-02-08 11:18:54 -06:00
Lars Eggert eec98f01d4
fix: Add period after description of important date. (#5105)
Also make the table sortable and searchable.
2023-02-08 11:13:31 -06:00
Jennifer Richards 7cbc70237a
feat: Allow secretariat to request/edit sessions without sending email (#5110) 2023-02-08 10:43:12 -06:00
Lars Eggert 6b8d57ec3f
chore: Remove unused ietf/secr/middleware/dbquery.py (#5109)
Fixes #4303
2023-02-08 09:57:03 -06:00
Jennifer Richards 6cfbab63ba
fix: Use session name instead of timeslot name on agenda (#5086)
* fix: Use session name instead of timeslot name on agenda

* test: Fix failing playwright test

* test: Test name/slotName values from agenda_extract_schedule()

* chore: Migrate sessions to use timeslot names for IETF meetings
2023-02-07 14:40:23 -06:00
Lars Eggert cda2cfd119
fix: Handle plaintext documents with lines of 80ch (#5098) 2023-02-07 13:15:01 -06:00
Robert Sparks 84d766232b
Merge remote-tracking branch 'upstream/main' into feat/postgres 2023-02-07 12:20:36 -06:00
Lars Eggert 35d124106a
fix: Limit overflow-wrap: break-word to paragraphs and references (#5078)
Fixes #5073.

Thanks @martinthomson
2023-02-06 11:40:46 -06:00
Lars Eggert 1afce6669d
fix: Fix HTML validation issues (#5081) 2023-02-06 09:40:38 -06:00
Lars Eggert f61c531f0d
fix: Don't include the modal inside a button group, it breaks the styling (#5085) 2023-02-06 09:35:10 -06:00
Robert Sparks fac5a8cf0d
fix: restore IRTF non-meeting groups to agenda (#5077)
* fix: restore IRTF non-meeting groups to agenda

Fixes #5010

* fix: account for changes to entry from #5065
2023-02-02 17:03:03 -06:00
Jennifer Richards 0fd8df4e00
test: Set DateField to a date, not a datetime, in factory (#5075) 2023-02-02 13:06:45 -06:00
Martin Thomson bfe25fce5a
feat: Lighter styling on internal irefs (#5071)
Documents like
https://datatracker.ietf.org/doc/html/draft-ietf-ohai-ohttp-06 use a
tagging scheme for certain keywords that turns them into links.  This
can be useful in giving people the ability to quickly jump to the
definition of an important term, but it tends to produce a lot of visual
noise.  The resulting links are blue and underlined, which can be
distracting when there are lots of these links.

This change removes styling for these links.  If there is an `<iref>`
tag (which renders as an empty `<span>`) immediately preceding a link
and that link is tagged `class="internal"`, link styling is removed.
These will still result in the cursor changing to a pointer, but the
blue and underlining will reduce line noise.

Note that this change depends on a corresponding change in kramdown-rfc
that reorders the generation of the iref and xref tags.  The above
document will not change in appearance as a result, because that version
of kramdown-rfc generated the tags in the wrong order.  A new version
generated with an updated kramdown-rfc is forthcoming.
2023-02-02 10:12:58 -06:00
Robert Sparks 189018a879
feat: disallow collisions with legacy draft names with capital letters (#5068) 2023-02-01 15:11:19 -06:00
Jennifer Richards 760a01ad91
fix: Handle proceedings for "notmeet" sessions correctly (#5065) 2023-02-01 10:47:37 -06:00
Lars Eggert 7ddc09ef25
fix: Break long words in cards to prevent layout jumps (#5064) 2023-02-01 10:37:20 -06:00
Lars Eggert 2954044b36
fix: Don't show time or ical link for unscheduled sessions (#5063)
* fix: Don't show time for unscheduled sessions

Fixes #5016

* Don't show the ical button either
2023-02-01 10:32:34 -06:00
Robert Sparks 2a1602d9bb
Merge remote-tracking branch 'origin/main' into feat/postgres 2023-01-31 16:57:03 -06:00
Jennifer Richards 98d7b15dfb
fix: Only send password reset email to known, active addresses (#5061)
* fix: Only send password reset email to known, active addresses

Limits password reset to Users with a Person and at least one active
address on file. Avoids the possibility of sending a password reset to
a spoofed address as in CVE-2019-19844.

* test: Use factory instead of explicit construction

* test: Test that a User with no Person cannot reset password

* fix: Fix handling of User.person field when it's null

* test: Test that reset emails are sent to known, active addresses
2023-01-31 13:56:33 -06:00
Robert Sparks afac1f8f19
feat: enable editorial stream adoption and balloting (#5011)
* feat: enable editorial stream adoption and balloting

* fix: bring tests into line with refactor

* feat: force intended_std_level to Informational when adopting into a non-ietf stream.

* fix: improve blocking position labels and email content

* fix: simplify pointer to group on doc main page for rswg docs

* fix: recover from merge typos

* fix: correct defer and clear ballot behavior

* fix: improve publication request access logic

* fix: clean up broken editorial state

* fix: adjust test to match migrations
2023-01-31 13:50:51 -06:00
Jennifer Richards 7e2b062f12
feat: Limit schedule generator by session purpose (#5055)
* feat: Limit schedule generator by session purpose

* feat: Raise exceptions if no sessions/timeslots are found
2023-01-31 12:59:21 -06:00
Robert Sparks 413fd8872e
fix: remove unneeded value from test post (#5045) 2023-01-31 12:57:18 -06:00
Robert Sparks a202cf4bf9
feat: Case Insensitive Email.address field (#5046)
* fix: address mypy quibble

* fix: use citext for Email.address

* test: confirm adding case-varied email fails
2023-01-30 11:52:38 -06:00
Lars Eggert b95f5108d1
fix: Restore value attribute needed for backend logic (#5053)
Fixes #5042
2023-01-30 10:01:47 -06:00
Jennifer Richards 837877119b
fix: Sort agenda editor rows by room size first (#5043)
* fix: Sort agenda editor rows by room size first

* test: Update selectors in test_edit_meeting_schedule()
2023-01-27 16:29:51 -06:00
Jennifer Richards 408c1ea9a4
fix: Show overfull style based on max, not sum, of session durations (#5044)
* fix: Show overfull style based on max, not sum, of session durations

* style: Avoid shadowing 'sessions' from outer scope
2023-01-27 16:24:24 -06:00
Robert Sparks 6de27154ed
Merge remote-tracking branch 'origin/main' into feat/postgres 2023-01-27 12:45:35 -06:00
Jennifer Richards 23f38e2ebc
fix: Fix broken add/modify ADs in the secr app (#5040) 2023-01-27 12:01:22 -06:00
Robert Sparks 0ea04b26d5
fix: use faker directly for non-factory managed faked things (#5041) 2023-01-27 12:00:36 -06:00
Jennifer Richards 185c4d556c
fix: Show links for more session types on the agenda (#5038)
* fix: Show links for more session types on the agenda

* test: Update test to expect buttons on additional sessions

* test: Update the past meeting test case also
2023-01-27 11:55:05 -06:00
Robert Sparks c04feb5765
Merge remote-tracking branch 'origin/main' into feat/postgres 2023-01-26 10:37:50 -06:00
Robert Sparks 5560c28c82
fix: only show irtf stream ballot and publication buttons to the IRTF chair (#5036) 2023-01-25 15:10:31 -06:00
Robert Sparks 742fc4ead2
feat: show session purposes on the meeting request page (#5034) 2023-01-25 15:09:55 -06:00
Jennifer Richards 040af97c11
refactor: Simplify tests and comply with StandardJS style (#5026)
* refactor: Simplify tests and comply with StandardJS style

Use === instead of ==, except where it's used to match both null and
undefined.

* style: further tweaks
2023-01-25 15:09:13 -06:00
Lars Eggert 61f7984d5c
fix: Handle unset cookies correctly (#5023)
Fixes #5015
2023-01-24 09:02:21 -06:00
Jennifer Richards db3506e8c7
fix: Use settings.TIME_ZONE when looking up telechat agenda_date() (#5020) 2023-01-23 18:06:51 -06:00
Jennifer Richards c35afca507
test: Use DEADLINE_TZINFO to validate reminder due date calculation (#5019) 2023-01-23 18:05:53 -06:00
Robert Sparks 43c7e92d9d
feat: remove the format element from the bibxml-id source of truth (#5017) 2023-01-23 18:03:19 -06:00
Jennifer Richards ec7c7b3701
chore: Upgrade to bleach v6 (#5021)
* build: Bump bleach requirement to 6.0.0

* fix: Update bleach configuration for compatibility with v6 changes
2023-01-23 13:29:45 -06:00
Robert Sparks 2351629fcc
Merge remote-tracking branch 'origin/main' into feat/postgres 2023-01-23 10:28:14 -06:00
Jennifer Richards c6663eb593
fix: Separately show proceedings sessions with different names (#5005)
* refactor: Update call to deprecated add_event_info_to_session_qs

* feat: Gather proceedings sessions in the view, grouped by name

* feat: Begin using new session data format in templates (WIP)

* feat: Show non-meeting groups (WIP)

Non-meeting groups (all sessions are notmeet) now show up on the proceedings.
Session materials associated with these groups are not shown, need to restore
that functionality.

* refactor: Rework template data, show materials for notmeet groups (WIP)

* fix: Restore "No agenda", etc, when meeting materials are not present

* chore: Remove commented out old code

* fix: Restore contents in non-area sections of proceedings

* chore: Remove commented-out stale code

* fix: Suppress duplicate agendas for a group on proceedings

* refactor: Generalize agenda deduplication and apply to minutes

* refactor: Format multiple items per session; apply to bluesheets

* refactor: Apply _format_materials to recordings, slides, and drafts

* chore: Add comment about limitations of test_proceedings() test

* test: Test separation of named sessions in the proceedings
2023-01-20 15:16:48 -06:00
Lars Eggert 570bd141ae
Limit the width of the document selectors to the width of the parent. (#4968)
* Limit the width of the document selectors to the width of the parent.

It's unfortunately not responsive (select2 limitation), but better
than being too long.

* Force "text-overflow: ellipsis" to hide the beginning of a doc name
2023-01-18 10:40:32 -06:00
Lars Eggert e209cae279
Add a datatracker button to the htmlized side pane (#4970)
Fixes #4944
2023-01-18 10:39:43 -06:00
Lars Eggert cfce342ff6
fix: Linewrap lines > 72ch in htmlized view (#4974)
* fix: Linewrap lines > 72ch in htmlized view

* fix: Make Safari break long words (URLs)

* Use same fix as d242f1ff1f
2023-01-18 10:39:15 -06:00
Lars Eggert faf68bc290
fix: Change versions in htmlized sidebar version picker based on shown doc rev (#4977)
Also fix an issue with the revisions list only linking to the latest
version in some cases.

Fixes #4972
2023-01-18 10:38:41 -06:00
Lars Eggert 28ec22aad9
fix: Move the entire RFC5742-related text into the alert box (#4978) 2023-01-18 10:37:12 -06:00
Lars Eggert d7a7033a42
fix: Let charter revisions be variable length in the version paginator (#4989)
* fix: Let charter revisions be variable length in the version paginator

Fixes #4988

* Address review comments. Also make major charter revisions bold for readability.
2023-01-18 10:36:21 -06:00
Lars Eggert 1f87ff164f
fix: Add bug report button to htmlized view (#4999)
Fixes #4998
2023-01-18 10:34:18 -06:00
Lars Eggert a9e3b926f7
fix: rfc2html creates a "a" tag without href for references, handle that (#4975) 2023-01-17 10:20:13 -06:00
Lars Eggert 6dd295b1a5
Insert nav subheadings in the right place. (#4967)
* Insert nav subheadings in the right place.

Fixes #4924

* Undo erroneous commit
2023-01-12 12:23:11 -06:00
Robert Sparks 84e8daffaa
feat: chair aliases for research area groups (#4966) 2023-01-12 12:22:47 -06:00
Lars Eggert 715b1d1934
Update deps (#4969)
* Update deps

* Disable warning

* Fix typo
2023-01-12 09:21:54 -06:00
Jennifer Richards 250692997e
test: SearchableField.has_changed() should handle non-list initial val (#4965) 2023-01-10 15:13:37 -06:00
Robert Sparks 3fb521eb53
fix: test on postgres. POST and check intended pks. (#4949)
* fix: test on postgres. post and check intended pks.

* fix: pass and check intended pks

* fix: pass intended pk

* fix: get an actually usable group type for test

* fix: use a review assignment pk instead of the review request pk

* fix: Use pks of sessions, not schedtimesessassignments

* fix: test for actual pk and do not rely on case-insensitive LIKE

* fix: test for actual pk

* chore: spelling correction: nomine -> nominee
2023-01-10 10:28:43 -06:00
Robert Sparks 0cc907f957
fix: restore display of additional resources (#4956) 2023-01-10 10:19:43 -06:00
Robert Sparks ec2b7d0d04
Merge remote-tracking branch 'upstream/main' into feat/postgres 2023-01-06 17:29:49 -06:00
Jennifer Richards 2993322958
fix: Listify initial field value when SearchableField.max_entries == 1 (#4951)
* fix: Listify initial field value when SearchableField.max_entries == 1

* fix: Don't convert initial=None to initial=[None] in has_changed()
2023-01-06 16:06:00 -06:00
Jennifer Richards de62fd72d9
fix: Allow additional draft forms to be added to IPR disclosure edit form (#4952)
* chore: Remove commented-out template content

* fix: Correctly number newly added draft_form inputs on IPR edit form

* fix: Initialize select2 when adding a new field instance
2023-01-06 15:24:08 -06:00
Jennifer Richards 364250a291
feat: Generate a partial schedule when there are more sessions than timeslots (#4950)
* refactor: move session/timeslot selection for sched editor to querysets

Purpose here is to make it easier to reuse the session and timeslot selection
logic between the schedule editor and the schedule generator. Additionally
resolves a todo-list item to unify the list of TimeSlotType ids in the
IGNORE_TIMESLOT_TYPES tuple and the SessionQuerySet.requests() method.

* refactor: use new helpers to select sessions/slots for sched generator

* refactor: eliminate some code lint

* feat: Split sched gen TimeSlot into scheduled/unscheduled variants

(work in progress)

* feat: First pass at supporting unscheduled timeslots

(work in progress)

* feat: Handle unscheduled timeslots in make_capacity_adjustments()

(work in progress)

* feat: Handle unscheduled timeslots in time-relation constraint check

(work in progress)

* feat: Reflect unsched timeslots in messages from by schedule generator

* fix: Prevent exception in pretty_print() if base schedule not assigned

* refactor: Avoid flood of time relation constraint warning messages

* test: update test_too_many_sessions
2023-01-06 11:13:58 -06:00
Robert Sparks 1f0ab6418f
chore: update test name fixture (#4925) 2022-12-21 14:28:07 -06:00
Robert Sparks 795c182df8
Merge remote-tracking branch 'origin/main' into feat/postgres 2022-12-20 08:31:02 -06:00
Robert Sparks 0f35f5df3a
fix: handle names with endings that might parse as versions better (#4897)
* fix: Use the doc name matched by fuzzy_find_documents when rendering

Fixes #4855

* Follow suggestion by @rjsparks

* fix: handle names with endings that might parse as versions better

Co-authored-by: Lars Eggert <lars@eggert.org>
2022-12-20 08:16:08 -06:00
Jennifer Richards a8780dc439
test: fix (and simplify) changed email address generation (#4919) 2022-12-19 13:33:51 -06:00
Lars Eggert 4b1c10f6ab
feat: Add preference to make citation links go straight to cited docs (#4886)
* feat: Add preference to make citation links go straight to cited documents

* Use localStorage
2022-12-19 13:30:08 -06:00
Jennifer Richards 30f852179c
test: ensure author fields are actually changed by test (#4918) 2022-12-19 11:07:15 -06:00
Lars Eggert bc2b5f72ef
More fixes for HTMLization and PDFization (#4899)
* More fixes for HTMLization and PDFization

* Remove print

* More fixed from @martinthomson

* Hopefully fix #4885

* Apply suggestion from @rjsparks
2022-12-19 09:04:44 -06:00
Lars Eggert c3e7c1e188
feat: Linkify state descriptions (#4916) 2022-12-19 09:03:44 -06:00
Lars Eggert cab9b1c5e5
fix: Remove spurious title attribute (#4917) 2022-12-19 09:01:06 -06:00
Jennifer Richards 27469c1264
fix: do not create ReviewRequestDocEvent when assigning a review req (#4913)
* fix: do not create ReviewRequestDocEvent when assigning a review req

* test: test docevent creation
2022-12-16 15:17:10 -06:00
Lars Eggert ad5cf0bb01
fix: Fix layout issue in ballot modals on narrow screens (#4911)
* fix: Fix layout issue in ballot modals on narrow screens

Fixes #4902

* Also apply change to old positions

* Fix tests

* Use badge to indicate former ADs
2022-12-16 13:09:55 -06:00
Lars Eggert e6e0d8fc1a
feat: Diff arbitrary versions from new HTMLization page (#4863)
* feat: Diff arbitrary versions from new HTMLization page

Fixes #4859

* Rework this based on @rjsparks' suggestion. Not quite done yet.

* Progress

* Fix HTML

* Don't show compare buttons if there aren't at least two versions

* Remove spurious title attribute

* Use and style select2 for the version diff dropdowns

* Roll in code review suggestions

* Some tests!
2022-12-16 10:46:05 -06:00
Robert Sparks 3d802497f4
Merge remote-tracking branch 'upstream/main' into feat/postgres 2022-12-15 09:58:24 -06:00
Lars Eggert 8a599b749b
fix: Set font size from cookie before DOM is ready, to avoid flickering (#4882)
* fix: Set font size from cookie before DOM is ready, to avoid flickering

* fix: Use localStorage instead of cookies where possible
2022-12-15 09:36:30 -06:00
Jennifer Richards 38748cb10b
refactor: add guards/type hints to build_file_urls() (#4896)
* refactor: add guards/type hints to build_file_urls()

* fix: compare doc.type_id, not doc.type, with string value

* test: add cursory test of build_file_urls()
2022-12-14 17:22:26 -06:00
Lars Eggert 36e6b98394
fix: Fix sidebar hiding functionality (#4891)
Broken by #4860
Fixes #4858
2022-12-14 15:11:41 -06:00
Robert Sparks 912c7b5ee3
fix: simplify migrations when building postgres db image (#4889)
* chore: remove the effectively unused DATABASE_TEST_OPTIONS setting

* fix: simplify default settings_local so that db-include-fix.py is not needed in CI

* fix: simplify migrations in db-pg-migrate.sh
2022-12-13 17:37:24 -05:00
Jennifer Richards 3d47a9069c
fix: eliminate race condition when creating a review Document (#4876) 2022-12-13 14:45:42 -06:00
Jennifer Richards 73fcf51709
fix: handle both rev is None and '' in document_main (#4887) 2022-12-13 12:22:43 -06:00
Lars Eggert 017b5f54d1
fix: Force font-size and line-height for plaintext PDFization (#4879)
Fixes #4343
2022-12-13 10:10:14 -06:00
Lars Eggert 49f586ed4f
fix: Apply CSS suggestion by @martinthomson (#4872)
Fixes #4869
2022-12-13 08:41:35 -06:00
Jennifer Richards 5a1fc4c2ab
fix: use a single Meeting instance for all assignments in agenda views (#4877) 2022-12-12 16:33:08 -06:00
Lars Eggert f0966e43f5
fix: Don't show checker validations on HTMLization page (#4873)
Modals in static sidebars don't work; fixing this needs a larger rework.

Fixes #4865
2022-12-12 13:25:21 -06:00
Robert Sparks 572733d3f1
feat: validate the document notify field (#4856)
* feat: validate the document notify field

* chore: fix spelling in comment

* feat: be more explicit in notify validation, preserving input order.

* fix: restrict notify duplicate check to nameaddrs. Add tests.
2022-12-12 13:16:41 -06:00