Commit graph

12439 commits

Author SHA1 Message Date
Jennifer Richards 81dc5554a8
test: unpin django-stubs and update mypy (#6901)
* chore: Unpin django-stubs / update mypy

* test: Use "app.model" for ManyToManyField

django-stubs requires "app.model" instead of just "model" for
ManyToManyField lazy model references.

See https://github.com/typeddjango/django-stubs/issues/1802
2024-01-10 09:53:43 -06:00
Robert Sparks 3312913c6f
fix: better archive search links for group documents (#6835) 2024-01-09 15:17:11 -06:00
Lars Eggert e24fb601db
chore: Replace markup_txt with rfc2html (#6632)
* chore: Replace markup_txt with rfc2html

* Suppress HTML issues

* Remove comment

* Suppress harder

* Suppress even more

* Fix test

* Ignore vnu "duplicate ID" errors

* Undo accidental commit

* Fix RFCs

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2024-01-05 12:29:28 -06:00
Robert Sparks 88bc604949
fix: filter draft documents that became RFCs out of docs by ad (#6884) 2024-01-05 08:10:24 -06:00
Lars Eggert 5174e399ed
fix: Adjust dark theme to make range slider more visible (#6885)
Fixes #6881
2024-01-05 07:47:39 -06:00
Robert Sparks 678feca759
fix: remove unneeded (and broken) redirect (#6866) 2024-01-04 12:08:06 -06:00
Robert Sparks 2331b7541b
Merge pull request #6878 from pselkirk/fix-6861
fix: Correctly display the last pre-RFC rev of a draft
2024-01-04 11:01:08 -06:00
Paul Selkirk 02e0d960a4 fix: Correctly display the last pre-RFC rev of a draft 2024-01-04 00:50:08 -05:00
Paul Selkirk b445119428
fix: Properly set AD as action holder when submitting to IESG for publication (#6854)
* fix: Properly set AD as action holder when submitting to IESG for publication (#5227)

The clear intent of `to_iesg` is that
a) the document AD should be the group AD, if not already set, and
b) the document Action Holder should be the document AD;
but there was an order-of-operation error,
such that the Action Holder remained empty.

* refactor: Don't take values out of the parent scope, don't insert values into the parent scope

* refactor: Streamline DocEvent creation
2024-01-03 16:30:06 -06:00
Robert Sparks bbc64d30fd
fix: count RFCs correctly for doc/ad (#6833)
* fix: count RFCs correctly for doc/ad

* chore: improve query legibility
2024-01-03 10:37:44 -06:00
Paul Selkirk 748bcc328f
fix: Wrap weasyprint to catch exceptions (#6728)
* fix: Wrap weasyprint to catch exceptions (#6324)

* test: Restore socket function after test

* test: Use mock instead of monkeying with sockets

* refactor: Log the error

* fix: Don't catch non-Exception interruptions

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-12-27 11:56:38 -06:00
Paul Selkirk 288b69d0f3
fix: Allow reassignment of withdrawn review assignment (#6723) (#6850) 2023-12-27 11:09:45 -06:00
Paul Selkirk 1450ecde99
fix: Retain date of cancelled virtual interim meeting (#6708) (#6852) 2023-12-27 10:39:13 -06:00
Robert Sparks 2c11b544f1
fix: show state help for the editorial stream (#6836) 2023-12-26 08:53:52 -06:00
Robert Sparks c328ff7425
fix: improve idnits2_state document creation time calculations (#6832)
* fix: improve idnits2_state document creation time calculations

* chore: apply black to the idnits2_state function
2023-12-21 17:52:55 -06:00
Paul Selkirk 359a107fc5
fix: Include RFCs when searching on a draft name (#6787) (#6827) 2023-12-21 17:27:32 -06:00
Robert Sparks bc74977fcc
fix: 404 requests for bibtex for none draft or rfc documents (#6834)
* fix: 404 requests for bibtex for none draft or rfc documents

* test: test rejecting the types with factories already being imported
2023-12-21 16:27:48 -06:00
Paul Selkirk c1e40ff100
feat: Allow entering agenda text directly (#6792)
* feat: Allow entering agenda text directly (#6532)

* fix: Hide label as well as file/text input box

* refactor: Package javascript for static/dist

* fix: Fix test cases broken by view changes

* test: Add test case for entering agenda text

* refactor: assertRedirects
2023-12-20 16:40:13 -06:00
Lars Eggert db8fba486b
fix: Deduplicate referenced_by (#6820)
Fixes #6808
2023-12-20 16:36:55 -06:00
Robert Sparks ca664c4162
fix: don't create a volunteer object when a person has already volunt… (#6809)
* fix: don't create a volunteer object when a person has already volunteered

* fix: safer create

* refactor: use shorthand from django

* fix: also protect volunteer from datatracker from race
2023-12-18 16:49:27 -06:00
Jennifer Richards 7d447802d2
fix: no dups on stream documents view (#6804) 2023-12-18 10:45:51 -06:00
Jennifer Richards 149f82f578
fix: Include refs to pre-RFC drafts as refs to the RFC (#6784)
* fix: clean up shadowed name in document_referenced_by.html

* fix: include refs to rfc's came_from_draft()

* fix: include refs to draft's became_rfc()

* fix: Count indirect refs by RFCs

* refactor: break indirect ref_by counting to its own fn

* fix: only count refs to pre-rfc draft, not post-draft rfc

(and rename a method)

* test: test referenced_by_rfcs methods

The test_referenced_by_rfcs_as_rfc_or_draft() test
fails because there's a bug!

* test: actually, do double-count refs to rfc/draft

Let's do include refs to an rfc and its precursor draft
as separate refs. This almost surely indicates a data
error because it would mean an rfc referenced both an
rfc and the draft that it came from. That should never
be allowed, so at least let some light fall on it if
it happens.

* chore: Add docstring to document_referenced_by view
2023-12-18 09:11:53 -06:00
Lars Eggert f5bd078351
fix: AD queue graphs and AD doc list sorting (#6752)
* Fix AD queue graphs and AD doc list sorting.

Fixes #6700
Fixes #6720

* Fix the issue @rdanyliw found. Hopefully.

* More fixes

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-12-14 15:05:00 -06:00
Robert Sparks 4216c129fe
fix: change verbosity of api key purge mgmt command (#6758)
* fix: change verbosity of api key purge mgmt command

* test: adjust mgmt command test arguments
2023-12-14 15:04:27 -06:00
Paul Selkirk cfaf84f08f
refactor: Convert custom form template to bootstrap (#6763)
* refactor: Convert custom form template to bootstrap

* refactor: Match form fields to old version
2023-12-14 14:19:22 -06:00
Ryan Cross e9d44d41f0
feat: Capture volunteers from the registration system (#6605)
* feat: Capture volunteers from the registration system. Fixes #5938

* fix: allow withdrawn field to be null

* docs: add explanatory code comments

* fix: identify current nomcom by is_accepting_volunteers

* fix: use auto_now_add instead of auto_now

* fix: update migration

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-12-14 13:46:27 -06:00
Robert Sparks 501a5b8e58
fix: consider subseries when calculating downref (#6777) 2023-12-14 09:35:30 -06:00
Jennifer Richards 6083205cc8
fix: Update group dependencies for new rfc model (#6773)
* fix: Avoid accessing slug when state is None

* fix: ignore pre-rfc drafts as rfc-to-rfc references

* fix: also ignore pre-rfc to pre-rfc refs

* chore: remove breakpoint

* fix: ignore subseries non-downrefs

* fix: label nodes as RFCS when possible

* fix: get "rfc" flag right

* chore: Remove comment, answer seems to be "no"

* refactor: Specify state type; drop redundant source doc type check

We're only admitting source__type="draft", so
no need to check it again in filter queries

* refactor: Specify state type in old code
2023-12-14 09:29:55 -06:00
Robert Sparks 6ccf9080b4
Merge pull request #6776 from rjsparks/statsfixes
fix: gather interesting years for stats accounting for published rfcs
2023-12-13 15:22:58 -06:00
Robert Sparks e130a301de
fix: gather interesting years for stats accounting for published rfcs 2023-12-13 13:14:38 -06:00
Robert Sparks d74d5ed233
fix: ignore attempts to look for versions of rfcs, but find the rfc. 2023-12-13 11:54:22 -06:00
Robert Sparks e211dc57d4
feat!: RFCs and subseries as Document types 2023-12-11 09:36:21 -06:00
Robert Sparks 4823dfe8eb
chore: move some things that had been moved but later touched in main again (#6751) 2023-12-07 18:27:08 -04:00
Jennifer Richards cbe710d3fd
fix: Migrate and handle subseries IprDocRels (#6745)
* chore: Stash orig IprDocRel document alias

* chore: Point IprDocRel at subseries docs

* fix: Fix IprDocRel.document usage in templates

* fix: Handle subseries in IprDocRel.formatted_name()

* refactor: Better presentation of IprDocRel subseries

* fix: Allow blank originaldocumentaliasname
2023-12-07 15:40:18 -04:00
Jennifer Richards dd41234bb4
fix: Allow blank originaltargetaliasname (#6748) 2023-12-07 15:01:55 -04:00
Jennifer Richards 8351b4528f
test: RFC pub date is in RPC_TZINFO (#6747) 2023-12-07 11:57:24 -04:00
Jennifer Richards 2e2960a2af
refactor: Use type_id="rfc" in migration (#6746) 2023-12-07 11:38:03 -04:00
Robert Sparks ce918c4d18
chore: remove management commands already removed in main 2023-12-05 13:14:52 -06:00
Robert Sparks 402186477f
chore: reorder migrations 2023-12-05 12:15:17 -06:00
Robert Sparks 03e161bae9
chore: merge branch 'main' into feat/rfc 2023-12-05 09:12:11 -06:00
Paul Selkirk 5006ea53e6
fix: Reject obvious bad encoding pastes into the Submitter field in submissions (#6702) 2023-12-04 13:10:36 -06:00
Robert Sparks e7bf4e0931
fix: replace copy of draft minutes on iesg moderator page with a link 2023-11-30 12:04:31 -06:00
Jennifer Richards e3ba021e1d
feat: Teach ajax_select2_search about subseries (#6709)
* feat: Teach ajax_select2_search about subseries

* refactor: "draft,rfc" -> "all" in a missed spot
2023-11-30 11:22:32 -04:00
Jennifer Richards ddebdf0263
test: Add delay to upcoming mtg filter tests (#6707) 2023-11-29 16:02:27 -06:00
Jennifer Richards b281919d4c
feat: Sort RFCs on subseries views; fix page title (#6704)
* feat: Sort RFCs on subseries doc pages

* feat: Sort RFCs on subseries index pages

* fix: Show subseries doc name as page title

* refactor: Use prettystdname filter for consistency
2023-11-29 12:34:18 -06:00
Jennifer Richards b011f0ab32
fix: Show requested rev if it is current, even w/o dochistory (#6703) 2023-11-29 08:20:46 -06:00
Jennifer Richards d1909fd0c3
fix: Combine Group and GroupHistory when counting (#6701)
* fix: Combine Group and GroupHistory when counting

* refactor: Use same symbol in parallel iterators

* fix: Handle group acronym changes in assertion

* refactor: Avoid reference to GroupHistory in assertions

* chore: Revert so assertion fails on changed acronym

The filtering and meeting displays disagree on how to handle this,
so let's get a notification if it comes up in production.
2023-11-28 14:06:36 -06:00
Kesara Rathnayake f442d6c0af
fix: Remove extra spaces in bibtex (#6688) 2023-11-27 08:13:14 -06:00
Robert Sparks 9dec409b41
feat: iab workshops (#6684)
* feat: iab workshops

* chore: keep names fixture up to date
2023-11-27 08:09:30 -06:00
Nicolas Giard 8bd5d9481f
fix: chatlog component missing pinia + agenda switch to text dark mode colors (#6653) 2023-11-22 12:43:20 -06:00