Commit graph

3999 commits

Author SHA1 Message Date
Henrik Levkowetz b31c781603 Reverted changes to document ballot colours -- the colours that came in with
the shimfree merge [5836] don't work as well for some kinds of
colour-blindness.
 - Legacy-Id: 5839
Note: SVN reference [5836] has been migrated to Git commit cbfe489ff5
2013-07-17 21:59:53 +00:00
Henrik Levkowetz b42703ef7a Changelog entry for 4.60
- Legacy-Id: 5838
2013-07-17 21:19:45 +00:00
Henrik Levkowetz 51284a8871 Added an index page at /help/state, listing the document states that
have help information.
 - Legacy-Id: 5837
2013-07-17 20:55:35 +00:00
Henrik Levkowetz cbfe489ff5 Merged in more shim-layer removals from olau@iola.dk
(-r5465:HEAD from branch/iola/shimfree).  Copying relevant
commit messages here:

 - Deleted dead code in many places.

 - Renamed id-something to draft-something, make the "is
   this eligible for expiration" logic clearer

 - Added a name for IPR search URL

 - Revamped the ballot popup view

 - URL reversed the IPR search link instead of hardcoding it

 - Cleaned up search views and remove dead code, port them to the new DB
   schema, hack related views in iesg/ and wginfo/ to use the new search
   interfaces, avoid camelCase in search GET parameters (with
   backwards-compat fallback), add some simple search unit tests, remove
   caching from views_search.py index pages as they're now pretty fast to
   generate, rewrite ballot popup JS, regularize some CSS classes to use
   hyphen-notation rather than camelCase, move some of the search
   templates to doc/.

   idrfc/ now mostly contains some wrapper code still in use by other
   subdirs, some ported code not yet moved, and dead code.

 - Fixed output bug in test crawler and print referrer upon errors so it's
   easier to figure out where a link came from

 - Added /doc/in-last-call/ to crawler, report original page as referrer in
   a redirect chain rather than intermediate URL

 - Ported idindex to new schema, speed them up, add tests, refactor index
   page in views_search to share code with the text index file, get rid
   of some special-case idindex filters from ietf_filters, move
   "/drafts/" redirects to a file in /doc/

 - Ported /idtracker/status/ and /idtracker/status/last-call/ overview of
   drafts in IESG process to new schema in /doc/iesg/ and
   /doc/iesg/last-call/

 - Added redirects for all of /idtracker/*, removed all view code and other
   dead code from idtracker/

 - Removed the idtracker sitemap indexing drafts - in its current form,
   it adds nothing of value to the HTML-based /doc/all/ view, and it's
   pretty slow

 - Ported idtracker feeds to new schema, move them to doc/, cleaned up
   idtracker/ - only templatetags/ietf_filters and proxy code is left
 - Legacy-Id: 5836
2013-07-17 20:52:39 +00:00
Henrik Levkowetz bd76041df3 On request form the secretariat, added a note to the new I-D announcement
messages about there being a couple of minutes delay between submission and
the appearance of htmlized document and diff on the tools servers.
 - Legacy-Id: 5835
2013-07-17 10:00:05 +00:00
Henrik Levkowetz 68b05b609a Various fixes due to clear up tree conflicts and other bugs resulting from
the [5830] merge.
 - Legacy-Id: 5834
Note: SVN reference [5830] has been migrated to Git commit e678659b56
2013-07-16 14:02:43 +00:00
Henrik Levkowetz e678659b56 Merged in a lot of shim-layer removals from olau@iola.dk
(-r5194:5465 from branch/iola/shimfree).  Copying relevant
commit messages here:

  - Removed .related many to many relationship, it's not really useful
    since we always have to restrict on the relationship type anyway,
    instead add two helpers for doing the necessary queries (in both
    directions)

  - Added migration for transforming the .desc on the new_revision events
    into something more akin to what is actually shown in the history page

  - Added migration for blanking IESG notes that just consist of "RFC
    XXXX", these have been superfluous for some time

  - Grant stream chairs access to changing the stream on a draft

  - Hacked the format_history_text filter to be less weird, using the same
    formatting for snippets and full text, also link up legacy ballot set
    events

  - Moved the decoraters + utilities to new ietfauth/utils.py file

  - Added simple helper to Email to identify invalid email addresses (from
    legacy author entries)

  - Used new new_revision .desc format for when drafts are submitted

  - Improved the looks of the button class by adding extra contrast and a
    linear gradient. Currently the gradient is only visible in fairly
    recent browsers.

  - Rewrote draft and RFC tabs in terms of the new schema, porting
    write-up and history tabs as well

  - Fixed two bugs in RFC Editor syncing: make sure documents we don't know
    beforehand get a "draft" type and make sure individually submitted
    drafts get the type="individ" group instead of NULL

  - Made the CSS-styled button feel a bit nicer to use by flattening the
    active state, also introduce some temporary styles until browsers
    catch up with the standard syntax

  - Added migrations for fixing 1) a dummy RFC entry, 2) three stand-alone
    RFCs that didn't get their doc.type set, 3) a big bunch of historic
    stand-alone RFCs that have doc.group=None - set these to the
    individual submission "none" group for the time being so the view code
    doesn't have to deal with a special case.

    In some cases this is wrong since there actually was a WG associated
    but unfortunately fixing them properly requires detective work
    (probably parsing the RFCs) and in at least some cases recreating
    historic WGs. In case someone ends up doing this, the documents to
    check can still be found with

    Document.objects.filter(name__startswith="rfc", group__type="individ")
    since there are almost no new RFCs that didn't went through the I-D
    process.

  - Merged the I-D and RFC views by showing I-D information on RFCs too.
    I-Ds that have been published as RFCs redirect to the RFC URL. Also
    support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.

  - Fixed revision augmentation so events after RFC publication gets a "RFC"
    designation

  - Fixed a bug with tabs not using provided name but rather doc.name

  - Displaying draft-iesg state rather than doc.friendly_state as IESG state,
    also show a notice that the IESG state refers to post-RFC processing
    if it does, like the old separate RFC page did

  - Fixed the RFC number doc.note migration to catch combined "RFC XXX; BCP
    XXX" notes too, use the opportunity to remove inserted HTML tags from
    notes and rely on linebreaksbr filter instead (the other thing was a
    left-over from the Perl days), update the various uses of the note to
    reflect that

  - Refactored slightly to make views_doc.py independent of other idrfc code

  - Moveed idrfc/views_doc.py to doc/ with associated templates, replace the
    somewhat fragile simple URL tests for views_doc.py with ordinary unit
    tests. The new tests are still fairly basic but at least test more
    than the URL tests did.

  - Made sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
    RFC0123 in the alias table with a new migration and a change to the
    RFC Editor sync, this in turn makes /doc/std1/ do the right thing

  - Now /doc/std1/ works, we can actually do a local link in
    urlize_ietf_docs rather than linking to the tools.ietf.org server

  - Fixed history text formatter: sanitize HTML before adding linebreaks and
    non-breaking spaces, this cuts the time to render a history page with
    long comments in half

  - Added a test crawler that walks through the crawlable part of the site,
    reporting errors and slow pages

  - Got rid of initial "No record" positions when showing old positions,
    it's just noise

  - Added a .select_related() to the document main tab to reduce the number
    of DB queries, unfortunately it seems it doesn't really help with
    Django 1.2.x due to a bug (Document inherits from DocumentInfo which
    makes things a bit more complicated)

  - Introduced a simple cache in doc.get_state so repeated reads don't
    cause a DB query

  - Cleaned up the search code in preparation for removal of the shim-layer;
    use a static button and don't send extraneous GET parameters

  - Removed dead code in several places
 - Legacy-Id: 5830
2013-07-15 20:55:24 +00:00
Henrik Levkowetz c9cfc8fa77 Cleaned up the changelog formatting to conform to rst.
- Legacy-Id: 5828
2013-07-15 12:44:33 +00:00
Henrik Levkowetz 539dd58888 Set version info and settings back to development mode
- Legacy-Id: 5827
2013-07-15 07:32:23 +00:00
Henrik Levkowetz baad13bf7c Set version info to release version 4.53 before branching.
- Legacy-Id: 5825
2013-07-15 07:32:20 +00:00
Henrik Levkowetz 77bb8c7323 Changelog entry for 4.53
- Legacy-Id: 5824
2013-07-15 07:32:18 +00:00
Henrik Levkowetz 3105101cc5 Changed test running and test data generation to work with database rollback
(for instance with InnoDB).

Added settings.DATABASE_TEST_OPTIONS which can be used to force for instance
InnoDB use during testing.

Using this has the potential of reducing the time it takes to run the test
suite substantially; a few test runs indicate a reduction in test run time by
50% on a run-of-the-mill linux server.
 - Legacy-Id: 5823
2013-07-15 07:21:34 +00:00
Henrik Levkowetz eb10724796 Changed liaison attachment code to use the correct document type slug.
- Legacy-Id: 5822
2013-07-15 07:14:20 +00:00
Henrik Levkowetz 96771f7340 Updated tests to not depend on the record ids of generated test data.
- Legacy-Id: 5821
2013-07-15 07:10:27 +00:00
Henrik Levkowetz 1aacb9fa45 Save document before set_state, to maintain database consistency.
- Legacy-Id: 5820
2013-07-14 14:52:00 +00:00
Henrik Levkowetz 1d7218df94 Save document before set_state, to maintain database consistency.
- Legacy-Id: 5819
2013-07-14 14:41:01 +00:00
Henrik Levkowetz be7e968da6 Applied fix from https://code.djangoproject.com/attachment/ticket/3615/defer_constraint_checks.diff to defer constraint checks when loading fixtures.
- Legacy-Id: 5818
2013-07-14 14:22:26 +00:00
Henrik Levkowetz cbfcd6bba8 Corrected changelog (adding missing release date and maintainer information).
- Legacy-Id: 5817
2013-07-14 14:11:36 +00:00
Henrik Levkowetz 5955e5eefe Set version info and settings back to development mode
- Legacy-Id: 5816
2013-07-14 14:04:24 +00:00
Henrik Levkowetz 9c5f300444 Set version info to release version 4.52 before branching.
- Legacy-Id: 5814
2013-07-14 14:04:21 +00:00
Henrik Levkowetz 245a676a47 Changelog entry for 4.52
- Legacy-Id: 5813
2013-07-14 14:04:20 +00:00
Henrik Levkowetz bb7fbd8cab Merged [5794] to [5800] from olau@iola.dk:
* Skip IANA - Review Needed and Version Changed - Review Needed changes from
    IANA as it turns out that the Datatracker is the authoritative source on
    these states. Also improve logging so that the raw JSON from IANA is
    dumped, the parsed JSON on imported changes is dumped and we write to
    syslog before starting a sync script in the notification view.

  * Only add charter state change link when chartering, it doesn't make sense
    for an approved charter. Fixes #861.

  * Don't display group.comments on the charter document page. Apparently
    group.comments have been used by the Secretariat in the past for
    chartering comments, but it's not possible to edit the field and the whole
    thing doesn't make sense from a modelling perspective - a feature like
    this should probably use the note field on the charter.  Fixes issue
    #1048.

  * Don't crash if an attachment has been created already, just reuse it -
    this case shouldn't actually happen, but apparently sometimes does,
    probably due to a concurrency issue

  * Add link to charter pages from the milestones editing page (besides the
    cancel button), fixes #1044.

  * Special-case proposed working groups with respect to milestones, they get
    the charter milestones on the WG charter page rather than the current set

  * Show approved milestones on /doc/charter-xyz/ page if the charter is
    approved instead of only showing proposed milestones for proposed charters
 - Legacy-Id: 5812
Note: SVN reference [5794] has been migrated to Git commit a603b8e056

Note: SVN reference [5800] has been migrated to Git commit 0f69f87a56
2013-07-14 14:00:39 +00:00
Henrik Levkowetz 718ff112b5 Remove dajaxice; not needed until we manage to merge in agenda scheduling code.
- Legacy-Id: 5811
2013-07-14 13:57:40 +00:00
Henrik Levkowetz 1af953e4fb Fixed problem with caching of utc agenda -- use a separate cache name for this.
- Legacy-Id: 5810
2013-07-14 12:46:52 +00:00
Henrik Levkowetz a971124ac1 Permit unicode milestone text (using unicode() instead of str() in comparison when looking for milestone changes). Fixes issue #1065.
- Legacy-Id: 5809
2013-07-11 21:36:31 +00:00
Ryan Cross 3655dbb36e fixed 2 bugs where combined sessions aren't being handled properly in edit() and remove()
- Legacy-Id: 5807
2013-07-08 18:51:13 +00:00
Ryan Cross d19fe19ce0 add Standardization Level to drafts view/edit
- Legacy-Id: 5804
2013-06-24 23:30:30 +00:00
Ryan Cross 45ec7a97a1 TICKET:928 use correct role in session request notification email
- Legacy-Id: 5802
2013-06-24 22:52:13 +00:00
Ole Laursen 0f69f87a56 Skip IANA - Review Needed and Version Changed - Review Needed changes
from IANA as it turns out that the Datatracker is the authoritative
source on these states. Also improve logging so that the raw JSON from
IANA is dumped, the parsed JSON on imported changes is dumped and we
write to syslog before starting a sync script in the notification view.
 - Legacy-Id: 5800
2013-06-21 16:48:05 +00:00
Ole Laursen 57b0ca9cab Only add charter state change link when chartering, it doesn't make
sense for an approved charter. Fixes #861.
 - Legacy-Id: 5799
2013-06-21 15:13:46 +00:00
Ole Laursen 3c58e4743a Don't display group.comments on the charter document page. Apparently
group.comments have been used by the Secretariat in the past for
chartering comments, but it's not possible to edit the field and the
whole thing doesn't make sense from a modelling perspective - a
feature like this should probably use the note field on the charter.
Fixes issue #1048.
 - Legacy-Id: 5798
2013-06-21 14:55:53 +00:00
Ole Laursen fce33cd034 Don't crash if an attachment has been created already, just reuse it - this case shouldn't actually happen, but apparently sometimes does, probably due to a concurrency issue
- Legacy-Id: 5797
2013-06-21 14:15:30 +00:00
Ole Laursen f75100b061 Add link to charter pages from the milestones editing page (besides
the cancel button), fixes #1044.
 - Legacy-Id: 5796
2013-06-18 12:21:30 +00:00
Ole Laursen f2b4906f8b Special-case proposed working groups with respect to milestones, they
get the charter milestones on the WG charter page rather than the
current set
 - Legacy-Id: 5795
2013-06-18 11:56:48 +00:00
Ole Laursen a603b8e056 Show approved milestones on /doc/charter-xyz/ page if the charter is
approved instead of only showing proposed milestones for proposed charters
 - Legacy-Id: 5794
2013-06-18 11:23:55 +00:00
Henrik Levkowetz f50337695e Added a list of releases below the release notes at /releases/*
- Legacy-Id: 5791
2013-06-14 13:13:20 +00:00
Henrik Levkowetz 7875331805 From RjS: Added a case in the render_ballot_icon() filter for statchg documents.
- Legacy-Id: 5789
2013-06-11 15:25:22 +00:00
Henrik Levkowetz c696c0618d Removed duplicate '.errorlist' style.
- Legacy-Id: 5788
2013-06-11 10:46:47 +00:00
Henrik Levkowetz b6098566a9 Fixed missing name change when moving settings from rfceditor module to settings.py.
- Legacy-Id: 5787
2013-06-11 10:45:20 +00:00
Henrik Levkowetz c1c529f9ae Merged [5614] and [5622] from mcr@sandelman.ca: added dajaxice.
- Legacy-Id: 5786
Note: SVN reference [5614] has been migrated to Git commit 7e0e027149a37e2fac0b2809e8a18c896f660687

Note: SVN reference [5622] has been migrated to Git commit bde631c87ffd2ce5a93fe3c0559aafef04d23b1f
2013-06-10 20:47:51 +00:00
Henrik Levkowetz ec2550db84 Merged [5613] from mcr@sandelman.ca: include a way to dump timedeltafields so that it is possible to save data to fixtures.
- Legacy-Id: 5785
Note: SVN reference [5613] has been migrated to Git commit 32cb1d83e78d890cc286fb47131489a74dda4b21
2013-06-10 20:33:07 +00:00
Emilio A. Sánchez López dd3948cbe7 Change date format. Removed feedback id.
See #975
 - Legacy-Id: 5784
2013-06-10 16:41:13 +00:00
Emilio A. Sánchez López 8a2931021d Wrap feedback comments to avoid wide lines.
See #975
 - Legacy-Id: 5783
2013-06-10 15:17:54 +00:00
Emilio A. Sánchez López 8638a1eca1 Remove debug code
See #975
 - Legacy-Id: 5782
2013-06-10 11:04:01 +00:00
Emilio A. Sánchez López 49117c1622 Nominations are processed first and then the rest of feedback.
Select multiple resizable when selecting a nominee.
Fixed command that gets the feedback from email to retrieve the full address on the from header.
Added a "feedback pending" link in the top bar.
Fixed escaped html tags when displaying comments from feedback.
See #975
 - Legacy-Id: 5781
2013-06-10 10:42:11 +00:00
Henrik Levkowetz 8330afa082 Set version info and settings back to development mode
- Legacy-Id: 5780
2013-06-09 20:03:35 +00:00
Henrik Levkowetz bf81451a6c Set version info to release version 4.51 before branching.
- Legacy-Id: 5778
2013-06-09 20:03:32 +00:00
Henrik Levkowetz 2b519700a5 Changelog entry for 4.51
- Legacy-Id: 5777
2013-06-09 20:03:29 +00:00
Henrik Levkowetz a4d486ab26 Use argument 'draft' for document instead of 'approved_draft_name' when sending sync notifications to the RFC-Editor.
- Legacy-Id: 5776
2013-06-09 17:55:47 +00:00
Henrik Levkowetz 88e1d725c5 Moved settings for RFC-Editor sync to settings.py.
- Legacy-Id: 5775
2013-06-09 17:50:19 +00:00