Commit graph

87 commits

Author SHA1 Message Date
Henrik Levkowetz 7d4b1656bb Changed a test which changed a WG acronym, since this will (and should)
fail now -- we don't want to permit acronym changes.
 - Legacy-Id: 6440
2013-10-13 21:11:10 +00:00
Henrik Levkowetz 390309412f Changed the WG edit form so that once an acronym has been set, the acronym
field is read-only; also changed the form validation to not permit changes
to an existing acronym.
 - Legacy-Id: 6432
2013-10-12 15:33:54 +00:00
Henrik Levkowetz e4f4467725 Changed tests to use our own subclassed TestCase, and changed almost all fixtures to be perma_fixtures.
- Legacy-Id: 6320
2013-09-30 20:36:20 +00:00
Henrik Levkowetz a132e6720a Fixed 2 issues with the wg document list: Wrong heading for the related docs, and candidate wg docs listed as wg docs, rather than related docs.
- Legacy-Id: 6130
2013-09-10 15:43:17 +00:00
Ole Laursen 742dbace24 Move views and templatetags from idrfc/ to doc, the I-D specific views
go into views_draft.py and tests in tests_draft.py; what's left in
idrfc is wrapper code, templates and the ballot_icon templatetag
 - Legacy-Id: 6051
2013-08-14 10:32:25 +00:00
Ole Laursen ed7d8f2dd5 Remove debug print
- Legacy-Id: 6004
2013-08-09 15:57:47 +00:00
Ole Laursen 214b1e0a3b Be more strict when chartering a new group, only accept [a-z][a-z0-9]+
as acronym (specifically not hyphens), closes #1080.
 - Legacy-Id: 5965
2013-08-07 15:23:37 +00:00
Ole Laursen 52cefc5909 Don't include WGs without areas in the area-based overviews of WGs
(1wg-summary.txt and 1wg-charters.txt) to prevent crashes, fixes issue
#1083
 - Legacy-Id: 5963
2013-08-07 12:49:47 +00:00
Henrik Levkowetz cbfe489ff5 Merged in more shim-layer removals from olau@iola.dk
(-r5465:HEAD from branch/iola/shimfree).  Copying relevant
commit messages here:

 - Deleted dead code in many places.

 - Renamed id-something to draft-something, make the "is
   this eligible for expiration" logic clearer

 - Added a name for IPR search URL

 - Revamped the ballot popup view

 - URL reversed the IPR search link instead of hardcoding it

 - Cleaned up search views and remove dead code, port them to the new DB
   schema, hack related views in iesg/ and wginfo/ to use the new search
   interfaces, avoid camelCase in search GET parameters (with
   backwards-compat fallback), add some simple search unit tests, remove
   caching from views_search.py index pages as they're now pretty fast to
   generate, rewrite ballot popup JS, regularize some CSS classes to use
   hyphen-notation rather than camelCase, move some of the search
   templates to doc/.

   idrfc/ now mostly contains some wrapper code still in use by other
   subdirs, some ported code not yet moved, and dead code.

 - Fixed output bug in test crawler and print referrer upon errors so it's
   easier to figure out where a link came from

 - Added /doc/in-last-call/ to crawler, report original page as referrer in
   a redirect chain rather than intermediate URL

 - Ported idindex to new schema, speed them up, add tests, refactor index
   page in views_search to share code with the text index file, get rid
   of some special-case idindex filters from ietf_filters, move
   "/drafts/" redirects to a file in /doc/

 - Ported /idtracker/status/ and /idtracker/status/last-call/ overview of
   drafts in IESG process to new schema in /doc/iesg/ and
   /doc/iesg/last-call/

 - Added redirects for all of /idtracker/*, removed all view code and other
   dead code from idtracker/

 - Removed the idtracker sitemap indexing drafts - in its current form,
   it adds nothing of value to the HTML-based /doc/all/ view, and it's
   pretty slow

 - Ported idtracker feeds to new schema, move them to doc/, cleaned up
   idtracker/ - only templatetags/ietf_filters and proxy code is left
 - Legacy-Id: 5836
2013-07-17 20:52:39 +00:00
Henrik Levkowetz 68b05b609a Various fixes due to clear up tree conflicts and other bugs resulting from
the [5830] merge.
 - Legacy-Id: 5834
Note: SVN reference [5830] has been migrated to Git commit e678659b56
2013-07-16 14:02:43 +00:00
Henrik Levkowetz 96771f7340 Updated tests to not depend on the record ids of generated test data.
- Legacy-Id: 5821
2013-07-15 07:10:27 +00:00
Henrik Levkowetz bb7fbd8cab Merged [5794] to [5800] from olau@iola.dk:
* Skip IANA - Review Needed and Version Changed - Review Needed changes from
    IANA as it turns out that the Datatracker is the authoritative source on
    these states. Also improve logging so that the raw JSON from IANA is
    dumped, the parsed JSON on imported changes is dumped and we write to
    syslog before starting a sync script in the notification view.

  * Only add charter state change link when chartering, it doesn't make sense
    for an approved charter. Fixes #861.

  * Don't display group.comments on the charter document page. Apparently
    group.comments have been used by the Secretariat in the past for
    chartering comments, but it's not possible to edit the field and the whole
    thing doesn't make sense from a modelling perspective - a feature like
    this should probably use the note field on the charter.  Fixes issue
    #1048.

  * Don't crash if an attachment has been created already, just reuse it -
    this case shouldn't actually happen, but apparently sometimes does,
    probably due to a concurrency issue

  * Add link to charter pages from the milestones editing page (besides the
    cancel button), fixes #1044.

  * Special-case proposed working groups with respect to milestones, they get
    the charter milestones on the WG charter page rather than the current set

  * Show approved milestones on /doc/charter-xyz/ page if the charter is
    approved instead of only showing proposed milestones for proposed charters
 - Legacy-Id: 5812
Note: SVN reference [5794] has been migrated to Git commit a603b8e056

Note: SVN reference [5800] has been migrated to Git commit 0f69f87a56
2013-07-14 14:00:39 +00:00
Henrik Levkowetz a971124ac1 Permit unicode milestone text (using unicode() instead of str() in comparison when looking for milestone changes). Fixes issue #1065.
- Legacy-Id: 5809
2013-07-11 21:36:31 +00:00
Ole Laursen f2b4906f8b Special-case proposed working groups with respect to milestones, they
get the charter milestones on the WG charter page rather than the
current set
 - Legacy-Id: 5795
2013-06-18 11:56:48 +00:00
Henrik Levkowetz bd0c07290a Merged in branch/iola/milestones, which provides datatracker support for management of WG milestones.
- Legacy-Id: 5739
2013-05-15 22:07:23 +00:00
Ole Laursen e94d1df549 Clean up search views and remove dead code, port them to the new DB
schema, hack related views in iesg/ and wginfo/ to use the new search
interfaces, avoid camelCase in search GET parameters (with
backwards-compat fallback), add some simple search unit tests, remove
caching from views_search.py index pages as they're now pretty fast to
generate, rewrite ballot popup JS, regularize some CSS classes to use
hyphen-notation rather than camelCase, move some of the search
templates to doc/.

idrfc/ now mostly contains some wrapper code still in use by other
subdirs, some ported code not yet moved, and dead code.
 - Legacy-Id: 5611
2013-04-04 13:42:57 +00:00
Henrik Levkowetz 2f3476690f In order that document states (which may be used by old documents) should not need to be removed when state machines change and states go out of use, all document states have a 'used' field. The code which accesses the state fields have not been requiring that used=True for the states returned, which is an error. Fixed this by adding 'used=True' to all State.objects.get() and State.objects.filter() call where it's relevant.
- Legacy-Id: 5486
2013-03-05 23:24:41 +00:00
Ole Laursen bbe51020d4 Move milestones branch out of the way to prepare for merge with trunk
[[Split portion of a mixed commit.]]
 - Legacy-Id: 5185.1
2013-01-15 16:12:31 +00:00
Ole Laursen b19f6d8060 Merge in milestones branch
- Legacy-Id: 5091
2012-12-03 14:36:30 +00:00
Henrik Levkowetz 9a302b63dc Limit the 1wg-summary list and friends to WGs, (excluding the 'iesg' area which lists the areas as subgroups, for instance).
- Legacy-Id: 5063
2012-11-14 11:32:33 +00:00
Henrik Levkowetz 5787ca1ca6 Merged [4825] from rjsparks@nostrum.com:
Updated tests to deal with the mandatory state field
 - Legacy-Id: 4941
2012-10-21 15:34:39 +00:00
Henrik Levkowetz 6a5a5c2200 Merged [4811] from rjsparks@nostrum.com:
Cleaned up setting wg state, leaving events, and facilitated creating an initial charter for an existing unchartered group
 - Legacy-Id: 4940
2012-10-21 15:04:58 +00:00
Henrik Levkowetz d0214d3b25 Merged [4806] from rjsparks@nostrum.com:
Better handling for BoFs, particularly those that won't create WGs
 - Legacy-Id: 4939
2012-10-21 14:40:02 +00:00
Henrik Levkowetz d9619aaa0a Updated wginfo/tests.py to work with the merged wginfo/edit.py which requires the wg state to be set.
- Legacy-Id: 4938
2012-10-21 14:37:02 +00:00
Ole Laursen b100a4ca26 Don't try to check if anonymous users are chairs of the WG
- Legacy-Id: 4606
2012-07-07 19:57:52 +00:00
Ole Laursen 27935fb7a2 Don't prompt for the day of the month in setting up milestones,
instead set the deadline to the last day of the month, also remove any
references to the day of the month from the output
 - Legacy-Id: 4596
2012-07-05 18:57:15 +00:00
Robert Sparks f3fd4db35c Merge forward complete - checkpointing before fixing popup position dialogs
- Legacy-Id: 4595
2012-07-04 19:35:46 +00:00
Ole Laursen 95b144515e Email the WG too when making changes to milestones, although filter
out any "Adding milestone for review" changes
 - Legacy-Id: 4593
2012-07-04 18:31:18 +00:00
Ole Laursen 0e619af3b3 Don't restrict milestone search for drafts to drafts belonging to
group, there are probably going to be some that are not associated at
some point
 - Legacy-Id: 4588
2012-07-04 16:45:59 +00:00
Ole Laursen 317c0ce683 Fix bug in copying docs attribute when resetting charter milestones,
accidentally named the new milestone the same as the old
 - Legacy-Id: 4579
2012-07-03 23:15:41 +00:00
Ole Laursen 02509a4d8c Fix a couple of bugs in handling editing documents associated with
milestones, also include those documents in the initial output on the
edit page
 - Legacy-Id: 4558
2012-06-30 18:27:55 +00:00
Ole Laursen 488add5004 Add script and code (and tests) to send milestone reminders to ADs
(for reviews) and group chairs.
 - Legacy-Id: 4557
2012-06-30 16:46:31 +00:00
Henrik Levkowetz 1370942f54 Add a way to reach charter urls given a wg name rather than the charter document name.
- Legacy-Id: 4556
2012-06-29 00:38:31 +00:00
Ole Laursen 2b5345cf67 Add some polish, send email notifications on milestone changes
- Legacy-Id: 4544
2012-06-28 19:00:24 +00:00
Ole Laursen 471d5de21e Add a review step when submitting milestones to try to help people
catch errors
 - Legacy-Id: 4543
2012-06-28 17:33:52 +00:00
Ole Laursen 4ef6cd7543 Add option to reject review milestone, not only accept it, for ADs
- Legacy-Id: 4542
2012-06-28 13:58:34 +00:00
Ole Laursen 319a202900 Finish charter milestones support so they're merged in after approval
of the charter, also replace references to WGs in wgcharter with a
more generic counterpart so will be easier to add support for RGs if
someone ever gets that far (will still need testing and probably some
minor adjustments though).
 - Legacy-Id: 4534
2012-06-27 16:24:04 +00:00
Henrik Levkowetz adeafe8df2 Changed the group link on the personal doc list page to use the group acronym instead of whole name, and made the acronym a link to the wg documents page.
- Legacy-Id: 4531
2012-06-27 10:46:36 +00:00
Ole Laursen 8929413a71 Merged in changes from former milestones branch
- Legacy-Id: 4516
2012-06-26 18:09:43 +00:00
Ole Laursen 6c1e87b773 Move milestones branch out of the way to prepare for merge with trunk to get latest charter changes in
[[Split portion of a mixed commit.]]
 - Legacy-Id: 4514.1
2012-06-26 17:47:53 +00:00
Robert Sparks 51ab8123d9 merged in from 4.20-ise
- Legacy-Id: 4502
2012-06-22 20:25:17 +00:00
Henrik Levkowetz afe3ee71b8 Merged in fixes from Ole, from branch/charter:r4382-4407, and some changes from Henrik (removing the use of pos.blocked in views_ballot.py, and setting a ballot id in idrfc/testsREDESIGN.py) to make idrfc.EditPositionTestCase succeed.
- Legacy-Id: 4444
2012-06-10 16:22:16 +00:00
Ole Laursen 88d083ff72 Turn chartering process around so one submits the charter text before
putting the charter document into the review state and emailing the
Secretariat.
 - Legacy-Id: 4404
2012-05-07 17:18:45 +00:00
Ole Laursen 79b4c0843b Add confirmation step so that the new charter effort page allows one
to continue from a BoF (with a warning with confirmation being ticked)
and continue from a WG (with another warning and confirmation not
being ticked). Also allow overriding a historically used acronym (one
that's in the GroupHistory) after confirmation.
 - Legacy-Id: 4402
2012-05-07 16:04:45 +00:00
Ole Laursen 2dbed6a439 Don't show request closing WG link if group is proposed.
- Legacy-Id: 4401
2012-05-07 15:57:22 +00:00
Ole Laursen 07382a07a4 Add an entry to the group history when closing a group is being
requested and use that to put a notice on the WG page.
 - Legacy-Id: 4399
2012-05-04 17:46:35 +00:00
Henrik Levkowetz 1714428150 Tweak the error messages for acronym collisions in the create-wg form.
- Legacy-Id: 4395
2012-05-04 15:01:02 +00:00
Ole Laursen fc01365352 Remove silly acronym-has-changed check in conclude WG view.
- Legacy-Id: 4393
2012-05-04 14:41:16 +00:00
Ole Laursen 06908f3241 Rename label for WG conclude request so it's clear one is only
requesting the conclusion, not actually closing it.
 - Legacy-Id: 4392
2012-05-04 14:28:42 +00:00
Ole Laursen 286b2fc687 Increase size of conclusion request textarea.
- Legacy-Id: 4391
2012-05-04 14:26:25 +00:00