Commit graph

343 commits

Author SHA1 Message Date
Ole Laursen 99d8e69f0b Remove idrfc/templatetags/
- Legacy-Id: 6054
2013-08-14 15:14:47 +00:00
Ole Laursen 6ac0920af0 Move idrfc/ templates to doc/ and subdirectories in doc/, move ported ballot_icon template tag, delete dead code
- Legacy-Id: 6052
2013-08-14 14:10:46 +00:00
Ole Laursen 742dbace24 Move views and templatetags from idrfc/ to doc, the I-D specific views
go into views_draft.py and tests in tests_draft.py; what's left in
idrfc is wrapper code, templates and the ballot_icon templatetag
 - Legacy-Id: 6051
2013-08-14 10:32:25 +00:00
Ole Laursen 2cf79bb04c Move update_telechat from idrfc.utils to doc.utils, port remaining
code to using log_state_changed from doc.utils, remove idrfc/utils.py
 - Legacy-Id: 6050
2013-08-13 16:44:07 +00:00
Ole Laursen 484293d190 Remove debug print
- Legacy-Id: 6048
2013-08-13 15:43:56 +00:00
Ole Laursen de7ae60985 Move markup_txt.py from idrfc/ to utils/
- Legacy-Id: 6046
2013-08-13 14:33:22 +00:00
Ole Laursen 13a15b6111 Remove unused fixture generation (for old schema)
- Legacy-Id: 6005
2013-08-09 16:13:51 +00:00
Ole Laursen ff2c1ae3cc Remove the testurl list tests from idrfc, these are now handled
through explicit unit tests (and the test crawler which can be run
with "bin/test-crawl")
 - Legacy-Id: 6002
2013-08-09 15:00:07 +00:00
Ole Laursen ec2f0cabbf Delete dead code from idrfc, and delete some obsolete imports too
- Legacy-Id: 6001
2013-08-09 14:55:51 +00:00
Henrik Levkowetz b02d0bdd1c Corrected reset of document group on document stream change.
- Legacy-Id: 5934
2013-07-31 17:06:12 +00:00
Henrik Levkowetz d7879978f1 Merged [5901] from adam@nostrum.com:
Added a document link to the emails sent on discuss/comment changes.  Fixes bug #916
 - Legacy-Id: 5930
Note: SVN reference [5901] has been migrated to Git commit 30dec0ec09
2013-07-31 14:08:36 +00:00
Henrik Levkowetz 941378d201 Merged [5900] from rjsparks@nostrum.com:
Adds related documents to the set of documents checked for IPR declarations when building last call text. Partially addresses #1071.
 - Legacy-Id: 5929
Note: SVN reference [5900] has been migrated to Git commit c69a33217e
2013-07-31 14:04:12 +00:00
Henrik Levkowetz 2cc0542666 Merged [5897] from suresh.krishnan@ericsson.com:
Fixes the last call processing code to identify the new placeholder writeup.
Fixes issue #884.
 - Legacy-Id: 5927
Note: SVN reference [5897] has been migrated to Git commit 8d4a171431
2013-07-31 13:56:35 +00:00
Henrik Levkowetz 6794113320 Merged [5898] from adam@nostrum.com, with
additional tweaks from henrik: Added the capability to search for all kinds
 of documents in the main datatracker search page.  Fixes bug #838.
 - Legacy-Id: 5926
Note: SVN reference [5898] has been migrated to Git commit b14a8d0cee
2013-07-31 12:45:32 +00:00
Henrik Levkowetz 6d8a7afa5f Modified the doc stream-change edit form to reset doc.group to None on stream changes. Fixes issue #1078.
- Legacy-Id: 5915
2013-07-30 10:02:42 +00:00
Henrik Levkowetz 4e42c65e92 Fixed double plural 's' caused by the use of 'pluralize' in the template *and* plural forms for the group headers returned by fill_in_search_attributes(). Fixes issue #1077.
- Legacy-Id: 5914
2013-07-30 09:42:53 +00:00
Adam Roach 30dec0ec09 Fixed bug #916
- Legacy-Id: 5901
2013-07-27 13:45:29 +00:00
Robert Sparks c69a33217e Adds related documents to the set of documents checked for IPR declarations when building last call text
- Legacy-Id: 5900
2013-07-27 13:07:00 +00:00
Adam Roach b14a8d0cee Fixed bug #838
- Legacy-Id: 5898
2013-07-27 12:26:24 +00:00
Suresh Krishnan 8d4a171431 Fixing the last call processing code to identify the new placeholder writeup.
- Legacy-Id: 5897
2013-07-27 12:01:21 +00:00
Henrik Levkowetz 942efacb08 Added a guard to prevent duplicate RFC-Editor notifications for approved documents, and added logging to the notification routine.
- Legacy-Id: 5852
2013-07-23 22:28:19 +00:00
Henrik Levkowetz 55d8a49b57 Refactored the new AD dashboard view to re-use code and templates the same way the refactored previous view did.
- Legacy-Id: 5846
2013-07-19 23:49:15 +00:00
Henrik Levkowetz cf3fac2959 Added back in the ad2 view lost in the shimfree merge.
- Legacy-Id: 5845
2013-07-19 20:37:52 +00:00
Henrik Levkowetz dfee10aa92 Restored the functionality of showing both AD and Shepherd for documents
shown for searches and document lists.
 - Legacy-Id: 5842
2013-07-18 15:42:30 +00:00
Henrik Levkowetz cbfe489ff5 Merged in more shim-layer removals from olau@iola.dk
(-r5465:HEAD from branch/iola/shimfree).  Copying relevant
commit messages here:

 - Deleted dead code in many places.

 - Renamed id-something to draft-something, make the "is
   this eligible for expiration" logic clearer

 - Added a name for IPR search URL

 - Revamped the ballot popup view

 - URL reversed the IPR search link instead of hardcoding it

 - Cleaned up search views and remove dead code, port them to the new DB
   schema, hack related views in iesg/ and wginfo/ to use the new search
   interfaces, avoid camelCase in search GET parameters (with
   backwards-compat fallback), add some simple search unit tests, remove
   caching from views_search.py index pages as they're now pretty fast to
   generate, rewrite ballot popup JS, regularize some CSS classes to use
   hyphen-notation rather than camelCase, move some of the search
   templates to doc/.

   idrfc/ now mostly contains some wrapper code still in use by other
   subdirs, some ported code not yet moved, and dead code.

 - Fixed output bug in test crawler and print referrer upon errors so it's
   easier to figure out where a link came from

 - Added /doc/in-last-call/ to crawler, report original page as referrer in
   a redirect chain rather than intermediate URL

 - Ported idindex to new schema, speed them up, add tests, refactor index
   page in views_search to share code with the text index file, get rid
   of some special-case idindex filters from ietf_filters, move
   "/drafts/" redirects to a file in /doc/

 - Ported /idtracker/status/ and /idtracker/status/last-call/ overview of
   drafts in IESG process to new schema in /doc/iesg/ and
   /doc/iesg/last-call/

 - Added redirects for all of /idtracker/*, removed all view code and other
   dead code from idtracker/

 - Removed the idtracker sitemap indexing drafts - in its current form,
   it adds nothing of value to the HTML-based /doc/all/ view, and it's
   pretty slow

 - Ported idtracker feeds to new schema, move them to doc/, cleaned up
   idtracker/ - only templatetags/ietf_filters and proxy code is left
 - Legacy-Id: 5836
2013-07-17 20:52:39 +00:00
Henrik Levkowetz e678659b56 Merged in a lot of shim-layer removals from olau@iola.dk
(-r5194:5465 from branch/iola/shimfree).  Copying relevant
commit messages here:

  - Removed .related many to many relationship, it's not really useful
    since we always have to restrict on the relationship type anyway,
    instead add two helpers for doing the necessary queries (in both
    directions)

  - Added migration for transforming the .desc on the new_revision events
    into something more akin to what is actually shown in the history page

  - Added migration for blanking IESG notes that just consist of "RFC
    XXXX", these have been superfluous for some time

  - Grant stream chairs access to changing the stream on a draft

  - Hacked the format_history_text filter to be less weird, using the same
    formatting for snippets and full text, also link up legacy ballot set
    events

  - Moved the decoraters + utilities to new ietfauth/utils.py file

  - Added simple helper to Email to identify invalid email addresses (from
    legacy author entries)

  - Used new new_revision .desc format for when drafts are submitted

  - Improved the looks of the button class by adding extra contrast and a
    linear gradient. Currently the gradient is only visible in fairly
    recent browsers.

  - Rewrote draft and RFC tabs in terms of the new schema, porting
    write-up and history tabs as well

  - Fixed two bugs in RFC Editor syncing: make sure documents we don't know
    beforehand get a "draft" type and make sure individually submitted
    drafts get the type="individ" group instead of NULL

  - Made the CSS-styled button feel a bit nicer to use by flattening the
    active state, also introduce some temporary styles until browsers
    catch up with the standard syntax

  - Added migrations for fixing 1) a dummy RFC entry, 2) three stand-alone
    RFCs that didn't get their doc.type set, 3) a big bunch of historic
    stand-alone RFCs that have doc.group=None - set these to the
    individual submission "none" group for the time being so the view code
    doesn't have to deal with a special case.

    In some cases this is wrong since there actually was a WG associated
    but unfortunately fixing them properly requires detective work
    (probably parsing the RFCs) and in at least some cases recreating
    historic WGs. In case someone ends up doing this, the documents to
    check can still be found with

    Document.objects.filter(name__startswith="rfc", group__type="individ")
    since there are almost no new RFCs that didn't went through the I-D
    process.

  - Merged the I-D and RFC views by showing I-D information on RFCs too.
    I-Ds that have been published as RFCs redirect to the RFC URL. Also
    support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.

  - Fixed revision augmentation so events after RFC publication gets a "RFC"
    designation

  - Fixed a bug with tabs not using provided name but rather doc.name

  - Displaying draft-iesg state rather than doc.friendly_state as IESG state,
    also show a notice that the IESG state refers to post-RFC processing
    if it does, like the old separate RFC page did

  - Fixed the RFC number doc.note migration to catch combined "RFC XXX; BCP
    XXX" notes too, use the opportunity to remove inserted HTML tags from
    notes and rely on linebreaksbr filter instead (the other thing was a
    left-over from the Perl days), update the various uses of the note to
    reflect that

  - Refactored slightly to make views_doc.py independent of other idrfc code

  - Moveed idrfc/views_doc.py to doc/ with associated templates, replace the
    somewhat fragile simple URL tests for views_doc.py with ordinary unit
    tests. The new tests are still fairly basic but at least test more
    than the URL tests did.

  - Made sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
    RFC0123 in the alias table with a new migration and a change to the
    RFC Editor sync, this in turn makes /doc/std1/ do the right thing

  - Now /doc/std1/ works, we can actually do a local link in
    urlize_ietf_docs rather than linking to the tools.ietf.org server

  - Fixed history text formatter: sanitize HTML before adding linebreaks and
    non-breaking spaces, this cuts the time to render a history page with
    long comments in half

  - Added a test crawler that walks through the crawlable part of the site,
    reporting errors and slow pages

  - Got rid of initial "No record" positions when showing old positions,
    it's just noise

  - Added a .select_related() to the document main tab to reduce the number
    of DB queries, unfortunately it seems it doesn't really help with
    Django 1.2.x due to a bug (Document inherits from DocumentInfo which
    makes things a bit more complicated)

  - Introduced a simple cache in doc.get_state so repeated reads don't
    cause a DB query

  - Cleaned up the search code in preparation for removal of the shim-layer;
    use a static button and don't send extraneous GET parameters

  - Removed dead code in several places
 - Legacy-Id: 5830
2013-07-15 20:55:24 +00:00
Henrik Levkowetz bb7fbd8cab Merged [5794] to [5800] from olau@iola.dk:
* Skip IANA - Review Needed and Version Changed - Review Needed changes from
    IANA as it turns out that the Datatracker is the authoritative source on
    these states. Also improve logging so that the raw JSON from IANA is
    dumped, the parsed JSON on imported changes is dumped and we write to
    syslog before starting a sync script in the notification view.

  * Only add charter state change link when chartering, it doesn't make sense
    for an approved charter. Fixes #861.

  * Don't display group.comments on the charter document page. Apparently
    group.comments have been used by the Secretariat in the past for
    chartering comments, but it's not possible to edit the field and the whole
    thing doesn't make sense from a modelling perspective - a feature like
    this should probably use the note field on the charter.  Fixes issue
    #1048.

  * Don't crash if an attachment has been created already, just reuse it -
    this case shouldn't actually happen, but apparently sometimes does,
    probably due to a concurrency issue

  * Add link to charter pages from the milestones editing page (besides the
    cancel button), fixes #1044.

  * Special-case proposed working groups with respect to milestones, they get
    the charter milestones on the WG charter page rather than the current set

  * Show approved milestones on /doc/charter-xyz/ page if the charter is
    approved instead of only showing proposed milestones for proposed charters
 - Legacy-Id: 5812
Note: SVN reference [5794] has been migrated to Git commit a603b8e056

Note: SVN reference [5800] has been migrated to Git commit 0f69f87a56
2013-07-14 14:00:39 +00:00
Ole Laursen a603b8e056 Show approved milestones on /doc/charter-xyz/ page if the charter is
approved instead of only showing proposed milestones for proposed charters
 - Legacy-Id: 5794
2013-06-18 11:23:55 +00:00
Henrik Levkowetz 7875331805 From RjS: Added a case in the render_ballot_icon() filter for statchg documents.
- Legacy-Id: 5789
2013-06-11 15:25:22 +00:00
Henrik Levkowetz 88e1d725c5 Moved settings for RFC-Editor sync to settings.py.
- Legacy-Id: 5775
2013-06-09 17:50:19 +00:00
Robert Sparks a741642717 Added editing last call messages, requesting, issuing and tracking IETF LCs to status-change documents
Added a Cancel button to the form that allows editing the relations for status-change documents
Added instructions to the agenda section 3.3

This adds states to status-change- documents and has a migration that must be applied.

This fixes bug #1039
 - Legacy-Id: 5770
2013-06-01 21:01:45 +00:00
Henrik Levkowetz a92636fe52 Don't try to save a new doc state and a state_change_event if the new state is the same as the old state. Fixes issue #1045.
- Legacy-Id: 5759
2013-05-28 16:15:00 +00:00
Henrik Levkowetz bd0c07290a Merged in branch/iola/milestones, which provides datatracker support for management of WG milestones.
- Legacy-Id: 5739
2013-05-15 22:07:23 +00:00
Henrik Levkowetz 34825fc207 Fixed exception when creating log message when setting a document shepherd to None.
- Legacy-Id: 5730
2013-05-14 19:44:47 +00:00
Henrik Levkowetz f1c274fe04 Fixed nonstandard indentation.
- Legacy-Id: 5727
2013-05-14 18:18:57 +00:00
Henrik Levkowetz a3ce05bcc7 A different fix for the shepherd writeup edit test.
- Legacy-Id: 5699
2013-05-06 16:35:36 +00:00
Henrik Levkowetz aff678bb11 Fixed a problem with checking shepherd writeup editing permissions for logged-in users with no associated person object.
- Legacy-Id: 5695
2013-05-03 09:46:25 +00:00
Henrik Levkowetz 53b1719860 Merged [5645],[5646] and [5647] from olau@iola.dk:
Added support for notifying the RFC Editor upon draft approval

Added action to post to RFC Editor on non-IESG publication requests too

Fixed a bug that the CC on the announcement copy sent to IANA wasn't
cleared causing people on the CC to get duplicate emails
 - Legacy-Id: 5680
2013-04-21 15:53:16 +00:00
Henrik Levkowetz 7c35da472a Applied a patch from rjsparks@nostrum.com:
This fixes an issue with /doc/ad2 that is python library version related:

     ageseconds = (datetime.datetime.now()-doc.latest_event(type=3D'changed_document').time).total_seconds()

AttributeError: 'datetime.timedelta' object has no attribute 'total_seconds'

The production system is using 2.6, and that was a 2.7 feature.
 - Legacy-Id: 5665
2013-04-18 22:19:33 +00:00
Henrik Levkowetz 927efe2b7c Merged [5600] and [5602] from rjsparks@nostrum.com:
Changed the header to last call messages to IETF Announce and to IANA to make
replying to the announcement less likely to create an unnecessary ticket.
 - Legacy-Id: 5652
Note: SVN reference [5602] has been migrated to Git commit 19dcf10316
2013-04-15 22:24:22 +00:00
Henrik Levkowetz d18dc43af7 Merged [5569] and [5572] from rjsparks@nostrum.com:
Small fixes in 4.43 and showing the shepherd (when there is one)
on search results, documents for this ad, and wg document lists.
Fixes bug #972.
 - Legacy-Id: 5651
Note: SVN reference [5572] has been migrated to Git commit 22b6085987
2013-04-15 22:21:37 +00:00
Ole Laursen 7892e29036 Port idtracker feeds to new schema, move them to doc/, clean up
idtracker/ - only templatetags/ietf_filters and proxy code is left
 - Legacy-Id: 5643
2013-04-11 14:20:42 +00:00
Ole Laursen 8da7c6f56d Port /idtracker/status/ and /idtracker/status/last-call/ overview of
drafts in IESG process to new schema in /doc/iesg/ and
/doc/iesg/last-call/
 - Legacy-Id: 5638
2013-04-11 11:19:51 +00:00
Ole Laursen 4db36b0fbc Add a generic state help page, make provisions for displaying
IESG I-D states in it
 - Legacy-Id: 5635
2013-04-10 16:11:27 +00:00
Ole Laursen 3d1eb07afe Port idindex to new schema, speed them up, add tests, refactor index
page in views_search to share code with the text index file, get rid
of some special-case idindex filters from ietf_filters, move
"/drafts/" redirects to a file in /doc/
 - Legacy-Id: 5634
2013-04-10 11:48:07 +00:00
Henrik Levkowetz becd10a81d Merged [5570] from rjsparks@nostrum.com:
Moves the interface to edit shepherds and sheperd writeups out of the 
wgtracker interface and into the doc views (via idrfc).
Added a little to the simple authorization code (can_edit_) in idrfc.
Added a way to reset the writeup to the current templates (leaving 
extension points to take templates for non-ietf stream documents).
Fixes bug #967.

Implementation notes:
Currently reused EmailsField -- in the long 
run a better approach will be to build a similar PersonField.

This also fixes tickets #834 and #691 (which were effectively duplicates 
of #967)
 - Legacy-Id: 5631
Note: SVN reference [5570] has been migrated to Git commit 3bc9e9a7add65bf135d669381cb5d93c5a2e3e19
2013-04-07 20:40:15 +00:00
Henrik Levkowetz 68b697ccfc Merged [5595] from rjsparks@nostrum.com:
Tweaked the grouping code to not break documents of the same type up
 - Legacy-Id: 5630
Note: SVN reference [5595] has been migrated to Git commit 581280be11
2013-04-07 19:14:10 +00:00
Henrik Levkowetz 7a98fff79c Merged [5476] from rjsparks@nostrum.com:
* Added a document type for changing the publication status of other documents, and the UI for manipulating them.
* Added charters, conflict reviews, and status changes to the AD's \'My Documents\' page
* Improved the presentation of all document types on the Agenda, Future Telechats, Scribe and Moderator package pages
* Made the reverse name for document relationships explicit rather than deriving them from forward names
* Added a way to get to the underlying Document (when it exists) from an RfcWrapper
* Unified several common forms used by different document types
 - Legacy-Id: 5629
Note: SVN reference [5476] has been migrated to Git commit 10b4f7a4dc
2013-04-07 19:11:18 +00:00
Ole Laursen e94d1df549 Clean up search views and remove dead code, port them to the new DB
schema, hack related views in iesg/ and wginfo/ to use the new search
interfaces, avoid camelCase in search GET parameters (with
backwards-compat fallback), add some simple search unit tests, remove
caching from views_search.py index pages as they're now pretty fast to
generate, rewrite ballot popup JS, regularize some CSS classes to use
hyphen-notation rather than camelCase, move some of the search
templates to doc/.

idrfc/ now mostly contains some wrapper code still in use by other
subdirs, some ported code not yet moved, and dead code.
 - Legacy-Id: 5611
2013-04-04 13:42:57 +00:00
Ole Laursen d70fb9b4b1 Delete dead code, rename id-something to draft-something, make the "is
this eligible for expiration" logic clearer
 - Legacy-Id: 5606
2013-04-04 13:22:08 +00:00