Commit graph

122 commits

Author SHA1 Message Date
Jennifer Richards 394e32e022
fix: lock session requests for new meetings (#8251)
* fix: lock session requests for new meetings

* fix: lint
2024-11-22 08:13:53 -06:00
Ryan Cross c9e14cb45a
refactor: remove unused physical bluesheet functions (#6525)
* refactor: remove unused secr/console app

* refactor: remove unused secr/areas app

* refactor: remove unused physical bluesheets functions

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-10-23 18:31:47 -05:00
Robert Sparks b4a692fac1
fix: show session times in meeting timezone when announcing scheduling (#5622) 2023-05-15 14:55:37 -05:00
Jennifer Richards a653582cf7
fix: timezone fixes from last few comparisons with tzaware-obe 2022-09-28 13:21:50 -03:00
Jennifer Richards 2e3686b08e
refactor: simplify getting timedelta.days 2022-09-23 12:26:31 -03:00
Jennifer Richards 1280422e1c
fix: create timeslots in new meeting TZ when duplicating (#4485) 2022-09-20 14:59:35 -03:00
Jennifer Richards fe7fc4b871
fix: miscellaneous tz fixes (#4481)
* fix: use meeting timezone for date comparison in agenda.html

* fix: use meeting timezone in interim_meeting_cancellation_notice.txt

* fix: use meeting timezone in interim_session_cancellation_notice.txt

* fix: use meeting timezone for secr misc sessions tab

* fix: use meeting tz for editing misc sessions

* fix: handle times with day outside usual choices in secr app

* fix: handle TZ correctly for reg sessions and timeslots in secr app

* fix: handle timezone in session_schedule_notification.txt

* fix: fix broken references in interim session cancellation template

* test: use meeting timezone as element id for meeting/timeslot editing
2022-09-20 13:18:05 -03:00
Jennifer Richards a8d4bec70a
chore: remove stray debug statement (#4469) 2022-09-16 16:04:22 -03:00
Jennifer Richards 22b87a2b08
chore: fix errors breaking tests (#4448) 2022-09-14 10:22:48 -03:00
Jennifer Richards 32054111df
fix: fix failing tests and eliminate naive datetime warnings (#4402)
* test: fix timestamp construction in several doc tests

* refactor: rename date2datetime to datetime_from_date and clarify code

* chore: helper to get tzinfo for PRODUCTION_TIMEZONE

* fix: fix timezone handling in make_last_call()

* test: fix datetime generation in doc.tests_charter

* refactor: remove PRODUCTION_TIMEZONE setting

Replaces the PRODUCTION_TIMEZONE setting with a constant,
DEADLINE_TZINFO, in ietf.utils.timezone.

* test: be more careful about timezone in tests_charter.py

* test: be more careful about timezone in doc/tests.py

* fix: fix timezone handling affecting doc.tests_draft

* fix: fix timezone handling affecting tests_irsg_ballot.py

* fix: fix timezone handling affecting tests_review.py

* fix: fix timezone handling affecting last ietf.doc tests

* fix: fix timezone handling affecting last ietf.group tests

* fix: fix timezone handling affecting ietf.iesg tests

* fix: handle timezones in get_8989_eligibility_querysets

* fix: handle timezones affecting ietfauth tests

* fix: return tz-aware datetime from utc_from_string

* fix: specify timezone for constants in ipr_rfc_number()

* fix: specify tz for ipr deadlines

* fix: handle timezones affecting liaisons tests

* fix: treat leap day in get_8989_eligibility_querysets()

Manual cherry-pick of 248d6474

* test: treat leap day properly in nomcom tests

* fix: fix timezone handling affecting nomcom tests

* test: fix timezone handling in review tests

* fix: fix timezone handling affecting secr.meetings tests

* fix: handle both pytz and zoneinfo timezones in ietf.utils.timezone

* fix: fix timezone handling affecting secr.proceedings tests

* refactor: use make_aware() helper in secr.meetings tests

* test: fix timezone handling in secr.telechat tests

* fix: fix timezone handling affecting stats tests

* fix: eliminate tz-naive helpers affecting sync email parsing

* fix: include timezone data when serializing DeletedEvent data

* fix: fix timezone handling affecting sync tests

* style: remove unused import
2022-09-01 13:07:28 -03:00
Jennifer Richards ebebdbed3e
refactor: replace datetime.now and datetime.today with timezone.now (#4211)
* refactor: replace datetime.now with timezone.now

* refactor: migrate model fields to use timezone.now as default

* refactor: replace datetime.today with timezone.now

datetime.datetime.today() is equivalent to datetime.datetime.now(); both
return a naive datetime with the current local time.

* refactor: rephrase datetime.now(tz) as timezone.now().astimezone(tz)

This is effectively the same, but is less likely to encourage accidental
use of naive datetimes.

* refactor: revert datetime.today() change to old migrations

* refactor: change a missed datetime.now to timezone.now

* chore: renumber timezone_now migration

* chore: renumber migrations
2022-08-25 13:45:16 -03:00
Robert Sparks 9c236ea2a2
chore: remove unneeded logging and code marked unreachable that has not been reached. (#4305)
* chore: remove unneeded logging and code marked unreachable that has not been reached.

* fix: remove noop save override
2022-08-04 11:25:31 -05:00
Jennifer Richards 6c260a5b7e Merge 7.45.1.dev0 into Bootstrap 5 update branch. Made a first pass at reconciling differences.
- Legacy-Id: 19945
2022-02-17 20:09:49 +00:00
Lars Eggert cf629a42ad And more fixes.
- Legacy-Id: 19877
2022-01-25 10:14:25 +00:00
Robert Sparks 9b54c9d3c9 Merged in [19763] from jennifer@painless-security.com:
Add ability to import session minutes from notes.ietf.org. Mock out calls to the requests library in tests. Call markdown library through a util method. Fixes #3489.
 - Legacy-Id: 19767
Note: SVN reference [19763] has been migrated to Git commit fd0df6f619
2021-12-09 22:43:19 +00:00
Jennifer Richards fd0df6f619 Add ability to import session minutes from notes.ietf.org. Mock out calls to the requests library in tests. Call markdown library through a util method. Fixes #3489. Commit ready for merge.
- Legacy-Id: 19763
2021-12-09 17:16:19 +00:00
Jennifer Richards 71ca72d8b8 Add tests of meeting forms for the new session purpose work and a few other untested parts. Fix a few bugs uncovered. Commit ready for merge.
- Legacy-Id: 19672
2021-11-17 01:43:15 +00:00
Jennifer Richards 1054f90873 Snapshot of dev work to add session purpose annotation
- Legacy-Id: 19415
2021-10-12 17:08:58 +00:00
Jennifer Richards 336d762123 Allow configuration of group conflict types used for each meeting Fixes #2770. Commit ready for merge.
- Legacy-Id: 19266
2021-07-30 17:50:24 +00:00
Robert Sparks 3697180cc1 Reverted merge of timezone-aware migration efforts.
- Legacy-Id: 18792
2021-01-12 16:54:20 +00:00
Henrik Levkowetz 59b49c846b Fixed a number of TimeSlot-related issues, in particular related to getting the correct date from a timeslot. Also fixed the displayed slot times in the new schedule editors to show local times, not UTC times.
- Legacy-Id: 18785
2020-12-19 22:55:11 +00:00
Henrik Levkowetz 774e752a54 Snapshot of timezone-aware datatracker code. Tests pass, and the test-crawler shows only expected differences. Trunk changes merged in up to r18768.
- Legacy-Id: 18770
2020-12-16 23:53:37 +00:00
Jennifer Richards 79971e14c7 Allow cancellation of individual sessions of multi-session interim meeting. Fixes #2959. Commit ready for merge.
- Legacy-Id: 18724
2020-12-01 17:37:09 +00:00
Henrik Levkowetz 227f83b0da Changed the autogeneration of schedule names to use slugified user (person) name, rather than login. Logins are mostly email addresses, and may contain characters not permitted in the URL pattern for schedule names, and are less readable in the contexts where schedule names are used.
- Legacy-Id: 18567
2020-10-08 12:01:42 +00:00
Ole Laursen a39fa7f967 New branch from trunk @ r18382 for meeting improvements, with iola/meeting-improvement-r17835 merged in
- Legacy-Id: 18385
2020-08-20 09:36:41 +00:00
Ole Laursen c78ffbcd18 Introduce support for setting a base schedule on a schedule. All
assignments on the base schedule are shown in the pages for the
schedule, read-only.

This allows managing things like breaks and misc sessions separately
from the regular WG sessions.

Base schedules are not allowed to be the base of other base schedules
(the hierarchy can only be one level deep) to simplify the mental
model and the code.

Add link for creating new schedules instead of relying on copying
Empty-Schedule and change the meeting creation code to no longer
create the special Empty-Schedule. Instead a "base" schedule is
created and a first schedule with the name and permissions of the user
creating the meeting, using "base" as base.

Speed up a couple of the Secretariat/AD agenda views by adding
prefetches.
 - Legacy-Id: 18355
2020-08-11 17:34:32 +00:00
Robert Sparks 2b10465aa7 Convert IRTF area groups into their own group type rather than attempting to overload AG. Fixes #3027. Commit ready for merge.
- Legacy-Id: 18298
2020-07-28 18:54:44 +00:00
Henrik Levkowetz c60e915751 Fixed an issue with secr.meetings.views.send_notifications() that could occur if a session didn't have a timeslot set.
- Legacy-Id: 18135
2020-07-03 12:44:13 +00:00
Henrik Levkowetz 129d62e666 Added 'remote_instructions' as an editable field for misc. sessions in the secretariat app, in order to be able to set remote access URLs.
- Legacy-Id: 18118
2020-07-01 14:14:05 +00:00
Ole Laursen 45ed2c5a2c Add support in the new meeting schedule editor for making a tombstone
session when rescheduling a session after the schedule is made the
official meeting schedule.

Show both cancelled and rescheduled sessions as tombstones in the new
meeting schedule editor.

Add support for showing rescheduled tombstones in the meeting agenda
views.

Adjust the Secretariat session tool so that it's not possible to
(re)cancel cancelled or rescheduled tombstones.
 - Legacy-Id: 18108
2020-06-30 16:55:24 +00:00
Ryan Cross 3f6081a5b9 Add support for variable length meetings to secr/meetings app. Commit ready for merge
- Legacy-Id: 17590
2020-04-06 22:54:36 +00:00
Ole Laursen 568670c060 Turn sessions into regular sessions and non-sessions into misc.
sessions in the UI and code to avoid ambiguity.

This doesn't change the data in the DB except for uses of
TimeSlotTypeName where 'session' is now 'regular'.
 - Legacy-Id: 17128
2019-12-06 20:02:26 +00:00
Ole Laursen 3957743b85 Move Session.status, .requested, and .requested_by to a new SchedulingEvent
- Legacy-Id: 17122
2019-12-05 12:41:09 +00:00
Ole Laursen 0555879777 Rename Meeting.agenda to Meeting.schedule together with a bunch of
related internal things
 - Legacy-Id: 17051
2019-11-18 17:22:19 +00:00
Ryan Cross 9a82586e1b Fix issue where third session requests, which rerequire AD approval, get left with approved status, instead of scheduled, after Secretraiat sends out notifications of official schedule. Fixes #2765. Commit ready for merge.
- Legacy-Id: 16607
2019-07-31 23:02:20 +00:00
Ryan Cross b5850d5c7f Remove ability to cancel a break session. Fixes #2703. Commit ready for merge.
- Legacy-Id: 16092
2019-03-23 17:00:52 +00:00
Ryan Cross 2842ad12bb Fix issue where cancelling one break session causes other breaks to get cancelled. Fixes #2699. Commit ready for merge.
- Legacy-Id: 16085
2019-03-23 14:49:33 +00:00
Henrik Levkowetz e55a079591 Merged in [15787] from rcross@amsl.com:
Rework page flow and forms of secr/meetings app.  Fixes #2609.
 - Legacy-Id: 15794
Note: SVN reference [15787] has been migrated to Git commit e634dc2488
2018-11-30 20:48:40 +00:00
Ryan Cross e634dc2488 Rework page flow and forms of secr/meetings app. Fixes #2609. Commit ready for merge.
- Legacy-Id: 15787
2018-11-21 22:43:04 +00:00
Henrik Levkowetz e471386cf2 Merged in [15715] from rcross@amsl.com:
Fix issue where new non-session location field value isn't saved.  Fixes #2625.
 - Legacy-Id: 15756
Note: SVN reference [15715] has been migrated to Git commit a47fba833f
2018-11-12 13:35:17 +00:00
Ryan Cross a47fba833f Fix issue where new non-session location field value isn't saved. Fixes #2625. Commit ready for merge.
- Legacy-Id: 15715
2018-11-05 04:25:20 +00:00
Henrik Levkowetz c24092d2f7 Merged in [15335] from rcross@amsl.com:
Fixed the ordering of meeting select in secr/meetings.  Fixes #2539.
 - Legacy-Id: 15373
2018-07-17 14:36:36 +00:00
Henrik Levkowetz 1504c6b13e Merged in [15328] from rcross@amsl.com:
Give secretariat the ability to cancel non-working group sessions. Fixes #2537.
 - Legacy-Id: 15363
Note: SVN reference [15328] has been migrated to Git commit ec279682d2
2018-07-15 20:08:44 +00:00
Ryan Cross ec279682d2 Give secretariat the ability to cancel non-working group sessions. Fixes #2537. Commit ready for merge.
- Legacy-Id: 15328
2018-07-14 16:14:35 +00:00
Henrik Levkowetz 1ece5f1f3b Removed premature save of upload document state (doing it after verifying that the save to file worked instead). Tweaked materials documents revision extraction regexes. Added a test on no change of materials rev after failed upload. Corrected the naming of materials in make_meeting_test_data. Refined the test crawl of meeting materials pages.
- Legacy-Id: 14865
2018-03-19 01:05:52 +00:00
Henrik Levkowetz 4c6aa091b1 Added date information to the 'scheduled session' emails, and also a link to an ical file for the group sessions. Fixes issue #2461.
- Legacy-Id: 14722
2018-03-02 16:43:56 +00:00
Henrik Levkowetz de0c60884f Added a missing pyflakes pragma.
- Legacy-Id: 14713
2018-02-28 16:58:35 +00:00
Henrik Levkowetz 28bd9eadda Make sure that sessions listed in session scheduling notification emails are listed in time order. Fixes issue #2460.
- Legacy-Id: 14712
2018-02-28 13:28:51 +00:00
Henrik Levkowetz 92db803bac Removed code that has been marked unreachable for more than 5 months.
- Legacy-Id: 14472
2017-12-29 19:48:18 +00:00
Ryan Cross b9bf77b543 Changed to not check timeslot type on delete because other types now have this option. Commit ready for merge
- Legacy-Id: 14211
2017-10-16 20:37:15 +00:00