Commit graph

107 commits

Author SHA1 Message Date
Ole Laursen 7f277a8fbb Replace user.get_profile() with user.person, the profile stuff is deprecated since Django 1.5
- Legacy-Id: 6968
2013-12-18 10:13:40 +00:00
Ole Laursen ea24f5c3bd Import slugify from django.utils.text (introduced in Django 1.5)
- Legacy-Id: 6967
2013-12-18 10:00:58 +00:00
Ole Laursen d1782297ab assertEquals -> assertEqual in tests, the former is deprecated
- Legacy-Id: 6964
2013-12-17 12:52:24 +00:00
Ole Laursen 42ade6273c Turn on CSRF protection - all forms must from now on have a {% csrf_token %}
- Legacy-Id: 6963
2013-12-17 12:50:24 +00:00
Ole Laursen 36dd439027 Rewrite ifequal/endifequal template tags to if tags with ==/!=
- Legacy-Id: 6961
2013-12-17 10:42:34 +00:00
Ole Laursen d66ac15fc2 Rewrite a bunch of HttpResponseRedirect + url reverse calls to instead
take advantage of the redirect shortcut (introduced in Django 1.1)
 - Legacy-Id: 6960
2013-12-17 10:23:42 +00:00
Ole Laursen 84a9f49053 mimetype -> content_type (mimetype is deprecated)
- Legacy-Id: 6945
2013-12-16 16:53:47 +00:00
Ole Laursen d86789608a Remove use of "groupgroup" fixture from Secretariat apps, it looks
like they don't actually depend on it, and the fixture itself is
unfortunately not complete so Django refuses to load it
 - Legacy-Id: 6938
2013-12-16 13:16:29 +00:00
Ole Laursen 0c2c5a7573 Rewrite url tags in Secretariat templates to new syntax
- Legacy-Id: 6936
2013-12-16 13:05:38 +00:00
Ole Laursen e1025e67ae Fix some oddities in secauth.py
- Legacy-Id: 6934
2013-12-16 12:48:43 +00:00
Ole Laursen 2eb8566d2f Remove : after label_tag in templates, the colon is now included in the label_tag itself
- Legacy-Id: 6930
2013-12-13 17:34:05 +00:00
Ole Laursen 0006b9ddcc Make sure all model forms have a Meta.fields attribute
- Legacy-Id: 6927
2013-12-13 17:20:02 +00:00
Ole Laursen e324f5551e Fix some {% url %} tags with commas between arguments, which is not valid with the new url syntax
- Legacy-Id: 6925
2013-12-13 17:00:12 +00:00
Ole Laursen 9b720d2a70 Fix bug in Secretariat MeetingModelForm, exclude was missing a , to be a tuple
- Legacy-Id: 6896
2013-12-12 12:12:03 +00:00
Ole Laursen 12960d9204 Fix bug in Secretariat GroupMilestoneForm, exclude was missing a , to be a tuple
- Legacy-Id: 6895
2013-12-12 12:11:09 +00:00
Ole Laursen fcb2dad155 Fix bug in Secretariat EditPersonForm, exclude was missing a , to be a tuple
- Legacy-Id: 6894
2013-12-12 12:10:05 +00:00
Ole Laursen fdd03eee8c Use validate_email instead of email_re to validate email
- Legacy-Id: 6893
2013-12-12 12:09:17 +00:00
Ole Laursen d1e60e533c Fix a couple of problems in previous URL conversion commit
- Legacy-Id: 6887
2013-12-11 17:13:49 +00:00
Ole Laursen 6a98fec2c3 Use built-in json module in Python instead of simplejson bundled with Django
- Legacy-Id: 6883
2013-12-11 16:59:19 +00:00
Ole Laursen 883853f09c Fix bug, TemplateView takes template_name, not template as parameter
- Legacy-Id: 6880
2013-12-11 16:43:34 +00:00
Ole Laursen cfa0d47ca0 Port to new class-based generic redirect and simple template views, remove utils.lazy.reverse_lazy, it's now included in Django
- Legacy-Id: 6878
2013-12-11 16:36:09 +00:00
Ole Laursen f5b2cfbc42 Make MEDIA_URL end in slash
- Legacy-Id: 6874
2013-12-11 15:29:38 +00:00
Ole Laursen 56f36018a2 Fix bug in secr test
- Legacy-Id: 6843
2013-12-07 19:29:32 +00:00
Ole Laursen f935577f77 Remove some unused references to SimpleUrlTestCase
- Legacy-Id: 6838
2013-12-07 13:30:41 +00:00
Ole Laursen 77fc3ec134 Rewrite simple URL test in secr/sreq/tests.py to use fake data
- Legacy-Id: 6836
2013-12-07 13:10:36 +00:00
Ole Laursen 947c973724 Remove reference to redesign
- Legacy-Id: 6832
2013-12-07 12:30:58 +00:00
Ole Laursen da91b15e16 Remove some references to shim layer
- Legacy-Id: 6822
2013-12-06 18:08:37 +00:00
Ole Laursen ad9503f1ed Removing remaining traces of shim layer usage in meeting
- Legacy-Id: 6817
2013-12-06 16:10:10 +00:00
Ole Laursen e63ac36b8f Remove shim layer from ietfauth, delete some dead code and migrate
remaining importers of ietfauth.decorators to ietfauth.utils
 - Legacy-Id: 6797
2013-12-05 16:24:03 +00:00
Ole Laursen 28abe3dc0d Remove unused idtracker.models import
- Legacy-Id: 6780
2013-12-03 18:35:29 +00:00
Ole Laursen bb2d070679 Redo tests for IPR to cover all views, fix some bugs and add some
finishing touches
 - Legacy-Id: 6779
2013-12-03 18:33:07 +00:00
Ole Laursen e9638cb1c2 Port IPR module to new schema, remove some cruft
- Legacy-Id: 6774
2013-12-02 16:34:00 +00:00
Ole Laursen 78d9bfff24 Move send_scheduled_announcement functionality to messages/utils.py
- Legacy-Id: 6768
2013-11-28 13:05:51 +00:00
Ole Laursen 35939cc20c Remove references to old announcement models and remove the model definitions
- Legacy-Id: 6767
2013-11-27 16:45:05 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch
- Legacy-Id: 6764
2013-11-27 12:55:50 +00:00
Ole Laursen ecf68dbb05 Revamp and clean up submit models:
- Rename IdSubmissionDetail to Submission
- Rename various submission fields to correspond to the conventions in
  the new schema
- Use a name model for the states instead of IdSubmissionStatus
- Drop the TempIdAuthor model which is based on splitting up author
  names
- Add a simple textual SubmissionEvent for tracking events in the
  lifetime of a submission
- Delete a bunch of obsolete fields
- Make sure all submission have an access key so we can depend on it
- Add state for when approval is needed from previous authors

A couple of migrations take care of transforming the
IdSubmissionDetail and moving data over/cleaning it up.

Also revamp the submit view code:

- Make form code do validation/cleaning only so there's a clear
  separation of concerns
- Reduce uses of inheritance that made the code hard to follow -
  forms now don't inherit from each other, views don't call each other
  but instead reuse common utilities, templates share CSS/utilities
  instead of relying on inheritance
- Move email rendering/sending to separate file
- Drop the in-grown terminology use (auto post vs. manual posts)
- Make the status page explain who is emailed for what purpose
- Add history table with recorded events
- Make the status page handle its post actions by itself instead of
  duplicating most of the setup logic in a number of simple views
- Fix a couple of minor bugs and handle some edge cases better
- Expand tests with a couple of more cases

Possibly the submit tool could still use more help text added to
explain the process, ideally what's explained in the tool instructions
page should be inlined or self-evident.
 - Legacy-Id: 6714
2013-11-15 13:30:32 +00:00
Ole Laursen e0be9bcb95 Remove unused and bitrotten get_authors_email
- Legacy-Id: 6711
2013-11-15 12:50:24 +00:00
Ole Laursen e6b0ef4323 Fix spelling error in validation
- Legacy-Id: 6709
2013-11-15 11:04:12 +00:00
Ryan Cross dbff28dbb2 change draft replace action: move document to archive directory
- Legacy-Id: 6643
2013-11-03 01:38:23 +00:00
Ole Laursen 9842eef405 For no good reason, agenda_data took request as first parameter, remove this as it makes testing harder
- Legacy-Id: 6487
2013-10-25 12:53:54 +00:00
Henrik Levkowetz edcc97aded Merged in branch/amsl/1.50@6388 from rcross@amsl.com, with secretariat tool
announcement fixes, permission fixes, and agenda database schema fixes.
 - Legacy-Id: 6473
2013-10-21 20:29:15 +00:00
Ole Laursen 10dceef26d Refactor IESG agenda pages, put the agenda structure in a helper function in agenda.py, build the agenda up around this structure, and reuse this everywhere instead of duplicating the structure in various templates and the JSON view - this also fixes a couple of minor bugs where the copy-pasted copies were not entirely in sync
- Legacy-Id: 6454
2013-10-16 13:07:09 +00:00
Ole Laursen de2ed527b4 Fix indentation problem with ballot writeup in Secretariat telechat tool and fix problem with unescaped << and >>
- Legacy-Id: 6453
2013-10-16 12:04:27 +00:00
Ole Laursen f6ff2a8082 Delete all old WGAction stuff, it's superceded by the WG charter
support, clean up iesg/models.py a bit
 - Legacy-Id: 6411
2013-10-10 16:12:34 +00:00
Ole Laursen 55c7c69679 Remove unused secr/ copy of agenda outline template (from iesg/)
- Legacy-Id: 6396
2013-10-09 12:41:59 +00:00
Ole Laursen bd34270cbc Port IESG agenda pages to new schema, add tests for them, move agenda
utilities to agenda.py, fix a couple of things, remove obsolete test
versions of agenda view, add support for viewing future IESG agendas
through /agenda/YYYY-MM-DD/* (useful when testing)
 - Legacy-Id: 6395
2013-10-09 12:40:42 +00:00
Ole Laursen 53ec62a5c9 Fix a bug in the Secretariat telechat menu, "232" -> "s232"
- Legacy-Id: 6394
2013-10-09 12:16:14 +00:00
Henrik Levkowetz e4f4467725 Changed tests to use our own subclassed TestCase, and changed almost all fixtures to be perma_fixtures.
- Legacy-Id: 6320
2013-09-30 20:36:20 +00:00
Ole Laursen c191a691e0 Remove "names" fixture from all tests, since it's now loaded once just
after creating the test database through the global test fixture
mechanism - this speeds up multiple tests considerably
 - Legacy-Id: 6305
2013-09-29 17:35:59 +00:00
Henrik Levkowetz 7bb999e09e Undid gratuitous changes.
- Legacy-Id: 6284
2013-09-26 21:35:18 +00:00