Commit graph

191 commits

Author SHA1 Message Date
Henrik Levkowetz 7ecfac6308 Merged in personal/henrik/django-1.7@9020 which upgrades Django from 1.6.0 to 1.7.4 and applies the needed changes to the datatracker code to work with release 1.7.x.
- Legacy-Id: 9028
2015-02-08 21:16:44 +00:00
Henrik Levkowetz 028b7e315a Reverted to [9025] because commit [9026] failed (it was incomplete with a broken working dir).
- Legacy-Id: 9027
Note: SVN reference [9026] has been migrated to Git commit 4a3749a66b
2015-02-08 20:03:16 +00:00
Henrik Levkowetz 4a3749a66b Merged in personal/henrik/django-1.7@9020 which upgrades Django from 1.6.0 to 1.7.4 and applies the needed changes to the datatracker code to work with release 1.7.x.
- Legacy-Id: 9026
2015-02-08 19:16:46 +00:00
Henrik Levkowetz 0db48f3db0 Merged in [8840] from rjsparks@nostrum.com:\n Automatically ensure Alias records exists when Person records are changed, relieving multiple code locations of that responsibility. Fixes bug #1550.
- Legacy-Id: 8873
Note: SVN reference [8840] has been migrated to Git commit b0b3a31b10bb35eb00d29f27d75d21c3cc4edc4e
2015-01-20 22:32:01 +00:00
Henrik Levkowetz 25eb00c925 New django-1.7 initial migrations. Circular references exist, requiring explicit --fake migration for doc, dbtemplate and community apps.
- Legacy-Id: 8823
2014-12-22 17:07:38 +00:00
Henrik Levkowetz dd15785936 Removing south migrations as part of the django 1.7 changeover to builtin migrations.
- Legacy-Id: 8820
2014-12-22 16:44:35 +00:00
Henrik Levkowetz 770b36d575 Added generated (and sometimes manually tweaked) resources.py files.
- Legacy-Id: 8744
2014-12-14 20:33:25 +00:00
Henrik Levkowetz bd6d0775e1 Require posting confirmation for some particular draft name prefixes.
- Legacy-Id: 8591
2014-11-08 03:15:20 +00:00
Henrik Levkowetz 4cc4f5080c Merged in [8254] from rjsparks@nostrum.com:\n Don't send mail to unknown-email-* addresses. Fixes bug #1471.
- Legacy-Id: 8365
Note: SVN reference [8254] has been migrated to Git commit f7f29a62588eac9b2aaf26cd0401a910fa48403f
2014-09-28 18:51:21 +00:00
Henrik Levkowetz 8e0200abc9 Merged in [8238] from rjsparks@nostrum.com:\n Look in the right place in the filesystem for the files bits when building reference relations during submit. Fixes bug #1467.
- Legacy-Id: 8362
Note: SVN reference [8238] has been migrated to Git commit c6e22bc429e3c77fd2d5be6d78c20a0c90cbc80b
2014-09-28 18:32:00 +00:00
Henrik Levkowetz 1c439cda48 Merged in [8236] from rjsparks@nostrum.com:\n Log what rebuild_reference_relations returns to diagnose #1467.
- Legacy-Id: 8360
Note: SVN reference [8236] has been migrated to Git commit b95b769267907f2ac8430893b153a7c82756265b
2014-09-28 17:53:02 +00:00
Henrik Levkowetz 9ff2b9ff9a Merged in support for RG pages, from branch/iola/rg-support.
- Legacy-Id: 7866
2014-06-09 20:52:14 +00:00
Henrik Levkowetz 2a8fbb4063 Added validation of successful draft title extraction on draft submission upload, to avoid a later exception when trying to store draft information for a draft with a null title.
- Legacy-Id: 7730
2014-05-10 10:39:33 +00:00
Henrik Levkowetz b5df5c836e Merged in [7587] from rjsparks@nostrum.com:
Anyone with a role in a group could preapprove drafts. Changed that to an explicit subset of roles. Fixes ticket 998.
 - Legacy-Id: 7609
Note: SVN reference [7587] has been migrated to Git commit 5ba0a274933e61e242ebcbf72b2f37e27d1da60d
2014-04-13 20:42:26 +00:00
Henrik Levkowetz 45ed4e6da3 Merged [7421] from olau@iola.dk: Fix a crash bug in the redirection logic that occurs when someone
posts a draft without an access token from the email confirmation step
 - Legacy-Id: 7600
Note: SVN reference [7421] has been migrated to Git commit c0e34dbcad
2014-04-12 18:32:20 +00:00
Henrik Levkowetz b02b0a96df All tests pass, except for some pyflakes tests which I believe are fixed in trunk.
- Legacy-Id: 7579
2014-04-06 20:04:36 +00:00
Ole Laursen 25625a0241 Add support for RG Chairs for pre-approving draft submissions. Also fixup the preapproval JS so it auto-focuses the draft name text input when you click one of the prefilled names.
- Legacy-Id: 7542
2014-03-25 12:14:41 +00:00
Henrik Levkowetz 870be71f79 Made ietf/submit pyflakes-clean.
- Legacy-Id: 7499
2014-03-16 08:03:15 +00:00
Henrik Levkowetz 02031a01b9 Cleaned out some (arbitrary) submodule name imports into ietf.utils, and made the corresponding import statements import the names directly from the correct submodules.
- Legacy-Id: 7495
2014-03-16 07:09:38 +00:00
Henrik Levkowetz 5bef5d11ae Made doc/ pyflakes-clean.
- Legacy-Id: 7462
2014-03-15 16:09:47 +00:00
Ole Laursen c0e34dbcad Fix a crash bug in the redirection logic that occurs when someone
posts a draft without an access token from the email confirmation step
 - Legacy-Id: 7421
2014-03-06 11:27:50 +00:00
Henrik Levkowetz 2f274bdad8 Changed the use of non-existing variable 'ascii' to 'person.ascii'. Fixes a server failure for person alias creation during draft submissions.
- Legacy-Id: 7277
2014-02-20 12:39:34 +00:00
Henrik Levkowetz e593d9d640 Added a warning to the draft submission page about upcoming submission cut-offs. Added a value in settings.py for the number of days before the first cut-off to display the waring.
- Legacy-Id: 7233
2014-02-11 19:28:59 +00:00
Ole Laursen 09859b9e6a Implement missing submit tests as spotted by the coverage check
- Legacy-Id: 7081
2014-01-08 17:47:39 +00:00
Ole Laursen 5e7d8c6c08 Fix auth check for editing the metadata of a submission - the path
without an access token would not allow a Secretariat user but instead
always throw an exception
 - Legacy-Id: 7079
2014-01-08 17:40:22 +00:00
Ole Laursen 7f277a8fbb Replace user.get_profile() with user.person, the profile stuff is deprecated since Django 1.5
- Legacy-Id: 6968
2013-12-18 10:13:40 +00:00
Ole Laursen d66ac15fc2 Rewrite a bunch of HttpResponseRedirect + url reverse calls to instead
take advantage of the redirect shortcut (introduced in Django 1.1)
 - Legacy-Id: 6960
2013-12-17 10:23:42 +00:00
Ole Laursen d1207bf000 Delete some dead code from submission form
- Legacy-Id: 6892
2013-12-12 12:08:58 +00:00
Ole Laursen cfa0d47ca0 Port to new class-based generic redirect and simple template views, remove utils.lazy.reverse_lazy, it's now included in Django
- Legacy-Id: 6878
2013-12-11 16:36:09 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch
- Legacy-Id: 6764
2013-11-27 12:55:50 +00:00
Ole Laursen 12722a68fa Remove backtrace email code from submit __init__.py, after the submit revamp I think I am responsible for all remaining bugs and not esanchez@yaco.es, and the code sometimes annoyingly interferes (through a bug in admin) with loading the submit module in the shell
- Legacy-Id: 6722
2013-11-19 16:14:27 +00:00
Ole Laursen ce316c0adb assertEquals -> assertEqual in submit/tests.py (the former is apparently deprecated)
- Legacy-Id: 6719
2013-11-15 16:24:38 +00:00
Ole Laursen 9f1f7790e2 Add bin/expire-submissions script for making sure old submissions are canceled automatically
- Legacy-Id: 6718
2013-11-15 16:22:29 +00:00
Ole Laursen 650d8316eb Make the submit tool use the access token framework with a bit of backwards compatibility glue
- Legacy-Id: 6717
2013-11-15 16:09:05 +00:00
Ole Laursen ecf68dbb05 Revamp and clean up submit models:
- Rename IdSubmissionDetail to Submission
- Rename various submission fields to correspond to the conventions in
  the new schema
- Use a name model for the states instead of IdSubmissionStatus
- Drop the TempIdAuthor model which is based on splitting up author
  names
- Add a simple textual SubmissionEvent for tracking events in the
  lifetime of a submission
- Delete a bunch of obsolete fields
- Make sure all submission have an access key so we can depend on it
- Add state for when approval is needed from previous authors

A couple of migrations take care of transforming the
IdSubmissionDetail and moving data over/cleaning it up.

Also revamp the submit view code:

- Make form code do validation/cleaning only so there's a clear
  separation of concerns
- Reduce uses of inheritance that made the code hard to follow -
  forms now don't inherit from each other, views don't call each other
  but instead reuse common utilities, templates share CSS/utilities
  instead of relying on inheritance
- Move email rendering/sending to separate file
- Drop the in-grown terminology use (auto post vs. manual posts)
- Make the status page explain who is emailed for what purpose
- Add history table with recorded events
- Make the status page handle its post actions by itself instead of
  duplicating most of the setup logic in a number of simple views
- Fix a couple of minor bugs and handle some edge cases better
- Expand tests with a couple of more cases

Possibly the submit tool could still use more help text added to
explain the process, ideally what's explained in the tool instructions
page should be inlined or self-evident.
 - Legacy-Id: 6714
2013-11-15 13:30:32 +00:00
Henrik Levkowetz 71d797bcb8 Refines Joel's fix to show clearly who receives draft submission confirmation emails, to show a more detailed warning text when the submitter isn't in the addressee list. Fixes issue #1097.
- Legacy-Id: 6659
2013-11-06 15:29:02 +00:00
Ole Laursen 422a20fe3d Add replaces field which is apparently in the database, but not in
models.py which confuses South
 - Legacy-Id: 6658
2013-11-06 15:24:22 +00:00
Ole Laursen 4635c1ce0f Move helpers for the admin on IdSubmissionDetail to admin.py
- Legacy-Id: 6657
2013-11-06 15:23:08 +00:00
Ole Laursen b46f0ba733 Get rid of submit/error_manager.py which is apparently unused
- Legacy-Id: 6656
2013-11-06 15:21:19 +00:00
Ole Laursen 2daff23f02 Remove shim layer from submit code
- Legacy-Id: 6654
2013-11-05 16:59:13 +00:00
Henrik Levkowetz dcc61a7eee Merged [6638] from jmh@joelhalpern.com:
Include confirmation addresses in ID-Submission success notice.
Fixes issue #1097.
 - Legacy-Id: 6653
Note: SVN reference [6638] has been migrated to Git commit 72885f4524
2013-11-05 15:03:25 +00:00
Joel M. Halpern 72885f4524 Include confirmation addresses in ID-Submission success notice.
Fixes issue #1097.
 - Legacy-Id: 6638
2013-11-02 23:29:21 +00:00
Robert Sparks b18249222b Refines Bill Fenner's regex based search through documents for references.
Populates RelatedDocument with relations for references for each type draft Document.
Replaces these reference relationships with updated copies on draft submission.
Note to deployer: This migration takes around 10 minutes to complete on a fast development laptop.
 - Legacy-Id: 6572
2013-10-30 20:51:11 +00:00
Henrik Levkowetz e4f4467725 Changed tests to use our own subclassed TestCase, and changed almost all fixtures to be perma_fixtures.
- Legacy-Id: 6320
2013-09-30 20:36:20 +00:00
Ole Laursen c191a691e0 Remove "names" fixture from all tests, since it's now loaded once just
after creating the test database through the global test fixture
mechanism - this speeds up multiple tests considerably
 - Legacy-Id: 6305
2013-09-29 17:35:59 +00:00
Henrik Levkowetz 1dae75ee59 The exception string for submission upload read errors seems to have changed after we switched to wsgi, from "Client read error" to "request data read error". Now looking for just "read error".
- Legacy-Id: 6264
2013-09-26 06:29:28 +00:00
Ole Laursen 742dbace24 Move views and templatetags from idrfc/ to doc, the I-D specific views
go into views_draft.py and tests in tests_draft.py; what's left in
idrfc is wrapper code, templates and the ballot_icon templatetag
 - Legacy-Id: 6051
2013-08-14 10:32:25 +00:00
Ole Laursen 867f7a8149 Get rid of some pre-redesign dead code in submit to get rid of idrfc import
- Legacy-Id: 6047
2013-08-13 14:47:49 +00:00
Henrik Levkowetz 6baea429aa Merged in the nomcom app from ejimenez@yaco.es and esanchez@yaco.es, and accompanying dbtemplate app and the (standard) docutils module. Added some tweaks to get all tests to pass and migrations to run.
- Legacy-Id: 5948
2013-08-06 10:09:29 +00:00
Henrik Levkowetz 1e03a04eca Changed the mimetype detection code to only read first 4k block of file, not the whole file.
- Legacy-Id: 5878
2013-07-25 18:28:18 +00:00