Commit graph

627 commits

Author SHA1 Message Date
Robert Sparks 7587d564d4 Added GroupExtResources to the group about page, and added the ability to edit them.
- Legacy-Id: 17685
2020-04-24 21:47:24 +00:00
Robert Sparks 2de9eb93b5 Added validation to the migrations. Added external resources to the draft display page. Built an editor for DocExternalResources.
- Legacy-Id: 17683
2020-04-24 16:14:43 +00:00
Robert Sparks 672f9bce26 Added display-name. Refined migrations.
- Legacy-Id: 17646
2020-04-15 19:54:29 +00:00
Robert Sparks c055d37dcb Removed extref app. Refined population migrations.
- Legacy-Id: 17509
2020-03-22 19:27:28 +00:00
Robert Sparks 316dd183d9 first run at external resources
- Legacy-Id: 17470
2020-03-19 23:32:24 +00:00
Robert Sparks 79bb245f8a Move charters for replaced groups to a new replaced state. Close any outstanding ballots on them. Fixes #2889, #2873, and #1286. Commit ready for merge.
- Legacy-Id: 17396
2020-03-06 16:47:59 +00:00
Robert Sparks afb818c298 Allow review team secretaries and the secretariat to reset the next reviewer in queue for review teams using the RotateAlphabetically policy. Partially addresses #2879. Commit ready for merge.
- Legacy-Id: 17325
2020-02-21 23:08:20 +00:00
Robert Sparks 3568e72ec5 Default use_milestone_dates to True. Allow changing use_milestone_dates from the edit milestone dates form for charters if it is the initial chartering effort. Fixes #2884. Commit ready for merge.
- Legacy-Id: 17287
2020-02-11 18:53:40 +00:00
Robert Sparks 7c3a4ce3f5 Only show groups in reasonable states when showing current chartering efforts (otherwise crufty charter states can would lead to abandoned or replaced groups showing here). Fixes #2872. Commit ready for merge.
- Legacy-Id: 17246
2020-01-17 20:14:22 +00:00
Robert Sparks b4ac9f83f1 Restrict the ability to change whether a group uses milestone dates to the ADs and the secretariat. Fixes #2869. Commit ready for merge.
- Legacy-Id: 17234
2020-01-16 21:19:29 +00:00
Robert Sparks f0f522322a Be clear about who changed a group's personnel in the resulting email message. Fixes #2868. Commit ready for merge.
- Legacy-Id: 17233
2020-01-15 21:38:44 +00:00
Henrik Levkowetz e99f1cdc86 Merged in [17185] from rjsparks@nostrum.com:
Adds support for dateless milestones. Fixes #2799.
 - Legacy-Id: 17198
Note: SVN reference [17185] has been migrated to Git commit 42e5163b09
2020-01-08 16:07:29 +00:00
Robert Sparks 42e5163b09 Adds support for dateless milestones. Fixes #2799. Commit ready for merge.
- Legacy-Id: 17185
2020-01-06 20:48:53 +00:00
Robert Sparks f71e9995a7 Dateless milestone work. Commit in preparation for merging forward.
- Legacy-Id: 17174
2019-12-24 21:38:26 +00:00
Henrik Levkowetz 06fe583351 Merged /branch/iola/meeting-improvement-r16992@17152 from olau@iola.dk:
* Renamed Meeting.agenda to Meeting.schedule together with a bunch of related
   internal things

* Moved Session.status, .requested, and .requested_by to a new SchedulingEvent.

* Turned sessions into regular sessions and non-sessions into misc.
  sessions in the UI and code to avoid ambiguity.

  This doesn't change the data in the DB except for uses of
  TimeSlotTypeName where 'session' is now 'regular'.
 - Legacy-Id: 17153
2019-12-17 23:43:07 +00:00
Ole Laursen 568670c060 Turn sessions into regular sessions and non-sessions into misc.
sessions in the UI and code to avoid ambiguity.

This doesn't change the data in the DB except for uses of
TimeSlotTypeName where 'session' is now 'regular'.
 - Legacy-Id: 17128
2019-12-06 20:02:26 +00:00
Henrik Levkowetz 6f8263eb6e Added fallback handling from utf-8 to latin1 when reading charter text files.
- Legacy-Id: 17126
2019-12-06 14:17:22 +00:00
Ole Laursen 3957743b85 Move Session.status, .requested, and .requested_by to a new SchedulingEvent
- Legacy-Id: 17122
2019-12-05 12:41:09 +00:00
Henrik Levkowetz fcb6806d17 Merged in work from sasha@dashcare.nl on Review Queue Managemnt:
This abstracts queue management, making it possible to implement different
policies for each team. It provides two concrete policies:
RotateAlphabeticallyReviewerQueuePolicy, which rotates an alphabetically
ordered reviewer list with consideration for skip indications, and is the
default policy; and LeastRecentlyUsedReviewerQueuePolicy, a simple
least-recently-used policy.  Also see issues #2721 and #2656.
 - Legacy-Id: 17121
2019-12-04 23:02:52 +00:00
Henrik Levkowetz 7ec09554bb Merged in [17069] from sasha@dashcare.nl:
Fix #2074, fix #2358 - Add history for assignments, requests and unavailability.
 - Legacy-Id: 17104
Note: SVN reference [17069] has been migrated to Git commit 65d84155b6
2019-11-26 16:09:43 +00:00
Henrik Levkowetz 994e5b36b5 Merged in [17083] from kivinen@iki.fi:
Moved hard coded defaults for max items to show and days to show to
the settings.py.
 - Legacy-Id: 17099
Note: SVN reference [17083] has been migrated to Git commit 90428d6d5f
2019-11-23 04:46:51 +00:00
Sasha Romijn 10a7bee637 Merge reviewer-queue-management on top of 6.111.1.dev0
- Legacy-Id: 17094
2019-11-22 12:35:28 +00:00
Tero Kivinen 90428d6d5f Moved hard coded defaults for max items to show and days to show to
the settings.py. Commit ready for merge.
 - Legacy-Id: 17083
2019-11-21 07:27:20 +00:00
Sasha Romijn 65d84155b6 Fix #2074, fix #2358 - Add history for assignments, requests and unavailability.
Commit ready for merge.
 - Legacy-Id: 17069
2019-11-20 11:29:14 +00:00
Henrik Levkowetz 19eb5de983 Merged in [17044] from valery@smyslov.net:
Make it clearer that a chair can't revise materials for a meeting once the proceedings deadline has passed

    Fixes issue #2612.
 - Legacy-Id: 17067
Note: SVN reference [17044] has been migrated to Git commit 182dae28a8
2019-11-20 10:10:31 +00:00
Sasha Romijn 3db8a0f39d Fix issue where queue might not advance correctly while managing
unassigned reviews, when some reviewers have a skip count.
 - Legacy-Id: 17060
2019-11-19 11:53:12 +00:00
Henrik Levkowetz e070aacc86 Merged in [17034] from kivinen@iki.fi:
Added two new configuration settings for the review team secretary,
one to set how many days to include in the reviewers list, and
another one to limit the number of completed items in the list for
each person. This version replaces the one I did earlier, and includes
much more test cases to test different limits on the reviewers page.
 - Legacy-Id: 17057
Note: SVN reference [17034] has been migrated to Git commit b5d864499f
2019-11-19 10:24:50 +00:00
Sasha Romijn 554a839864 Fix #2336 - Add "select me next for an assignment".
Reviewers can set this flag in their reviewer settings, which triggers
a mail to be sent to the secretary. They are then kept on top of the
recommended assignment order. This flag is automatically reset when any
assignment is made to the reviewer.
 - Legacy-Id: 17048
2019-11-18 12:30:11 +00:00
Valery Smyslov 182dae28a8 Fixes issue #2612. Commit ready for merge.
- Legacy-Id: 17044
2019-11-18 08:48:15 +00:00
Tero Kivinen b5d864499f Added two new configuration settings for the review team secretary,
one to set how many days to include in the reviewers list, and
another one to limit the number of completed items in the list for
each person. This version replaces the one I did earlier, and includes
much more test cases to test different limits on the reviewers page.
Commit ready for merge.
 - Legacy-Id: 17034
2019-11-16 09:41:55 +00:00
Jim Fenton 020d4a393c Adds Closing note field to state specific WG edit. Fixes #2779. Commit ready for merge.
- Legacy-Id: 17028
2019-11-16 05:46:51 +00:00
Sasha Romijn ce812a3a4f - Make skipping unavailable reviews the default, except for the
reviewer_overview page.
- Make default_reviewer_rotation_list use a consistent return type
 - Legacy-Id: 16986
2019-11-11 14:47:37 +00:00
Sasha Romijn b5a31c3c6a Update some terminology and docstrings.
- Legacy-Id: 16983
2019-11-11 12:31:16 +00:00
Robert Sparks 5c08b4096a Disregard unassigned reviews when building the sets to compare when checking for race-conditions on assigning reviews. Partially addresses #2821. Commit ready for merge.
- Legacy-Id: 16977
2019-11-07 16:16:33 +00:00
Henrik Levkowetz b7724c43d7 Changed some # type: ignore statements to work with the latest mypy
- Legacy-Id: 16968
2019-11-05 22:41:18 +00:00
Sasha Romijn e518824a69 Initial refactoring of the current reviewer assignment code.
- Legacy-Id: 16961
2019-11-05 16:39:31 +00:00
Henrik Levkowetz cee82e9f43 Merged in [16934] from sasha@dashcare.nl:
Fix #2088 - Sort unassigned review requests by doc name by default.
 - Legacy-Id: 16952
Note: SVN reference [16934] has been migrated to Git commit f075eced5c
2019-11-02 16:31:48 +00:00
Henrik Levkowetz 77a56473c3 Merged in [16933] from sasha@dashcare.nl:
Fix #2119 - Allow specifying review type for suggested reviews in LC and telechat
If a review is suggested on the 'manage unassigned reviews' page, and
the document is in both last call and telechat, the assign form now asks
for the type of review that should be assigned.
This commit also fixes two bugs in this process:
- Comparisons in some cases between strings and integers
  (group/views.py:1485/1487)
- Rejections when assigning suggested reviews, as they could be
  considered a newly opened request due to not having a pk
  (group/views.py:1508)
 - Legacy-Id: 16951
Note: SVN reference [16933] has been migrated to Git commit ee4bc0cb07
2019-10-31 17:31:21 +00:00
Sasha Romijn eab14ea1c5 Early work to extract reviewer policy from review/utils.py.
- Legacy-Id: 16950
2019-10-31 15:01:14 +00:00
Henrik Levkowetz a37bd907cc Merged in [16926] from rjsparks@nostrum.com:
Flipped a sense to put the grace period on the right side of 'today' when sending review overdue reminders to team secretaries. Fixes #2816.
 - Legacy-Id: 16940
Note: SVN reference [16926] has been migrated to Git commit 7560e116bf
2019-10-30 13:01:53 +00:00
Sasha Romijn f075eced5c Fix #2088 - Sort unassigned review requests by doc name by default.
Commit ready for merge.
 - Legacy-Id: 16934
2019-10-28 12:27:15 +00:00
Sasha Romijn ee4bc0cb07 Fix #2119 - Allow specifying review type for suggested reviews in LC and telechat
If a review is suggested on the "manage unassigned reviews" page, and
the document is in both last call and telechat, the assign form now asks
for the type of review that should be assigned.

This commit also fixes two bugs in this process:
- Comparisons in some cases between strings and integers
  (group/views.py:1485/1487)
- Rejections when assigning suggested reviews, as they could be
  considered a newly opened request due to not having a pk
  (group/views.py:1508)
  
Commit ready for merge.
 - Legacy-Id: 16933
2019-10-28 11:43:48 +00:00
Henrik Levkowetz 00fb8d4b43 Merged in [16923] from sasha@dashcare.nl:
Fix #2087 - Show doc authors and WG chairs in unassigned reviews views.
 - Legacy-Id: 16931
Note: SVN reference [16923] has been migrated to Git commit 93797b3fc1
2019-10-26 20:26:21 +00:00
Robert Sparks 7560e116bf Flipped a sense to put the grace period on the right side of "today" when sending review overdue reminders to team secretaries. Fixes #2816. Commit ready for merge.
- Legacy-Id: 16926
2019-10-25 20:32:16 +00:00
Sasha Romijn 93797b3fc1 Fix #2087 - Show doc authors and WG chairs in unassigned reviews views.
Commit ready for merge.
 - Legacy-Id: 16923
2019-10-24 07:25:47 +00:00
Henrik Levkowetz 91d0a79a16 Merged in [16904] from sasha@dashcare.nl:
Fix #2118 - Always list all last call drafts in assignment summary.
If a draft is scheduled for a telechat, but also assigned for LC review,
it will now be listed both in the telechat section and under 'last calls'.
 - Legacy-Id: 16913
Note: SVN reference [16904] has been migrated to Git commit 82c63b49f3
2019-10-23 15:16:30 +00:00
Henrik Levkowetz 399d0e1797 Merged in [16902] from sasha@dashcare.nl:
Ref #2526 - Fix test failure in [16895]
This also makes a small text clarification, which was also the initial
reason for the test failure.
 - Legacy-Id: 16912
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0

Note: SVN reference [16902] has been migrated to Git commit 78a1464e77
2019-10-23 13:31:46 +00:00
Henrik Levkowetz 97be7f31ea Merged in [16895] from sasha@dashcare.nl:
Fix #2526 - List previous reviews in assignments email.
This includes a migration to update the database templates. Note that
not all templates currently included them (secdir at least), and
previous reviews are only listed in templates that included */** before.
As before, previous reviews are only included if they are done by the
same reviewer(s) as the current assignment.
This also fixes a bug in database template 182
(/group/defaults/email/open_assignments.txt) which referred to 
r.review_request..doc.rev and r.review_request..requested_rev
in the template, and updates the test to use the current version of
template 182.
 - Legacy-Id: 16911
Note: SVN reference [16895] has been migrated to Git commit ef1e8006f0
2019-10-22 22:09:08 +00:00
Henrik Levkowetz 4a486a6c4d Merged in [16891] from sasha@dashcare.nl:
Fix #2198 - Set default start date for UnavailabilityPeriod to today.
 - Legacy-Id: 16910
Note: SVN reference [16891] has been migrated to Git commit a7a2ee4a39
2019-10-22 21:20:51 +00:00
Sasha Romijn 82c63b49f3 Fix #2118 - Always list all last call drafts in assignment summary.
If a draft is scheduled for a telechat, but also assigned for LC review,
it will now be listed both in the telechat section and under "last calls".

Commit ready for merge.
 - Legacy-Id: 16904
2019-10-22 14:55:04 +00:00