Commit graph

41 commits

Author SHA1 Message Date
Ole Laursen 742dbace24 Move views and templatetags from idrfc/ to doc, the I-D specific views
go into views_draft.py and tests in tests_draft.py; what's left in
idrfc is wrapper code, templates and the ballot_icon templatetag
 - Legacy-Id: 6051
2013-08-14 10:32:25 +00:00
Henrik Levkowetz 55d8a49b57 Refactored the new AD dashboard view to re-use code and templates the same way the refactored previous view did.
- Legacy-Id: 5846
2013-07-19 23:49:15 +00:00
Henrik Levkowetz cf3fac2959 Added back in the ad2 view lost in the shimfree merge.
- Legacy-Id: 5845
2013-07-19 20:37:52 +00:00
Henrik Levkowetz cbfe489ff5 Merged in more shim-layer removals from olau@iola.dk
(-r5465:HEAD from branch/iola/shimfree).  Copying relevant
commit messages here:

 - Deleted dead code in many places.

 - Renamed id-something to draft-something, make the "is
   this eligible for expiration" logic clearer

 - Added a name for IPR search URL

 - Revamped the ballot popup view

 - URL reversed the IPR search link instead of hardcoding it

 - Cleaned up search views and remove dead code, port them to the new DB
   schema, hack related views in iesg/ and wginfo/ to use the new search
   interfaces, avoid camelCase in search GET parameters (with
   backwards-compat fallback), add some simple search unit tests, remove
   caching from views_search.py index pages as they're now pretty fast to
   generate, rewrite ballot popup JS, regularize some CSS classes to use
   hyphen-notation rather than camelCase, move some of the search
   templates to doc/.

   idrfc/ now mostly contains some wrapper code still in use by other
   subdirs, some ported code not yet moved, and dead code.

 - Fixed output bug in test crawler and print referrer upon errors so it's
   easier to figure out where a link came from

 - Added /doc/in-last-call/ to crawler, report original page as referrer in
   a redirect chain rather than intermediate URL

 - Ported idindex to new schema, speed them up, add tests, refactor index
   page in views_search to share code with the text index file, get rid
   of some special-case idindex filters from ietf_filters, move
   "/drafts/" redirects to a file in /doc/

 - Ported /idtracker/status/ and /idtracker/status/last-call/ overview of
   drafts in IESG process to new schema in /doc/iesg/ and
   /doc/iesg/last-call/

 - Added redirects for all of /idtracker/*, removed all view code and other
   dead code from idtracker/

 - Removed the idtracker sitemap indexing drafts - in its current form,
   it adds nothing of value to the HTML-based /doc/all/ view, and it's
   pretty slow

 - Ported idtracker feeds to new schema, move them to doc/, cleaned up
   idtracker/ - only templatetags/ietf_filters and proxy code is left
 - Legacy-Id: 5836
2013-07-17 20:52:39 +00:00
Henrik Levkowetz e678659b56 Merged in a lot of shim-layer removals from olau@iola.dk
(-r5194:5465 from branch/iola/shimfree).  Copying relevant
commit messages here:

  - Removed .related many to many relationship, it's not really useful
    since we always have to restrict on the relationship type anyway,
    instead add two helpers for doing the necessary queries (in both
    directions)

  - Added migration for transforming the .desc on the new_revision events
    into something more akin to what is actually shown in the history page

  - Added migration for blanking IESG notes that just consist of "RFC
    XXXX", these have been superfluous for some time

  - Grant stream chairs access to changing the stream on a draft

  - Hacked the format_history_text filter to be less weird, using the same
    formatting for snippets and full text, also link up legacy ballot set
    events

  - Moved the decoraters + utilities to new ietfauth/utils.py file

  - Added simple helper to Email to identify invalid email addresses (from
    legacy author entries)

  - Used new new_revision .desc format for when drafts are submitted

  - Improved the looks of the button class by adding extra contrast and a
    linear gradient. Currently the gradient is only visible in fairly
    recent browsers.

  - Rewrote draft and RFC tabs in terms of the new schema, porting
    write-up and history tabs as well

  - Fixed two bugs in RFC Editor syncing: make sure documents we don't know
    beforehand get a "draft" type and make sure individually submitted
    drafts get the type="individ" group instead of NULL

  - Made the CSS-styled button feel a bit nicer to use by flattening the
    active state, also introduce some temporary styles until browsers
    catch up with the standard syntax

  - Added migrations for fixing 1) a dummy RFC entry, 2) three stand-alone
    RFCs that didn't get their doc.type set, 3) a big bunch of historic
    stand-alone RFCs that have doc.group=None - set these to the
    individual submission "none" group for the time being so the view code
    doesn't have to deal with a special case.

    In some cases this is wrong since there actually was a WG associated
    but unfortunately fixing them properly requires detective work
    (probably parsing the RFCs) and in at least some cases recreating
    historic WGs. In case someone ends up doing this, the documents to
    check can still be found with

    Document.objects.filter(name__startswith="rfc", group__type="individ")
    since there are almost no new RFCs that didn't went through the I-D
    process.

  - Merged the I-D and RFC views by showing I-D information on RFCs too.
    I-Ds that have been published as RFCs redirect to the RFC URL. Also
    support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.

  - Fixed revision augmentation so events after RFC publication gets a "RFC"
    designation

  - Fixed a bug with tabs not using provided name but rather doc.name

  - Displaying draft-iesg state rather than doc.friendly_state as IESG state,
    also show a notice that the IESG state refers to post-RFC processing
    if it does, like the old separate RFC page did

  - Fixed the RFC number doc.note migration to catch combined "RFC XXX; BCP
    XXX" notes too, use the opportunity to remove inserted HTML tags from
    notes and rely on linebreaksbr filter instead (the other thing was a
    left-over from the Perl days), update the various uses of the note to
    reflect that

  - Refactored slightly to make views_doc.py independent of other idrfc code

  - Moveed idrfc/views_doc.py to doc/ with associated templates, replace the
    somewhat fragile simple URL tests for views_doc.py with ordinary unit
    tests. The new tests are still fairly basic but at least test more
    than the URL tests did.

  - Made sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
    RFC0123 in the alias table with a new migration and a change to the
    RFC Editor sync, this in turn makes /doc/std1/ do the right thing

  - Now /doc/std1/ works, we can actually do a local link in
    urlize_ietf_docs rather than linking to the tools.ietf.org server

  - Fixed history text formatter: sanitize HTML before adding linebreaks and
    non-breaking spaces, this cuts the time to render a history page with
    long comments in half

  - Added a test crawler that walks through the crawlable part of the site,
    reporting errors and slow pages

  - Got rid of initial "No record" positions when showing old positions,
    it's just noise

  - Added a .select_related() to the document main tab to reduce the number
    of DB queries, unfortunately it seems it doesn't really help with
    Django 1.2.x due to a bug (Document inherits from DocumentInfo which
    makes things a bit more complicated)

  - Introduced a simple cache in doc.get_state so repeated reads don't
    cause a DB query

  - Cleaned up the search code in preparation for removal of the shim-layer;
    use a static button and don't send extraneous GET parameters

  - Removed dead code in several places
 - Legacy-Id: 5830
2013-07-15 20:55:24 +00:00
Ole Laursen 8da7c6f56d Port /idtracker/status/ and /idtracker/status/last-call/ overview of
drafts in IESG process to new schema in /doc/iesg/ and
/doc/iesg/last-call/
 - Legacy-Id: 5638
2013-04-11 11:19:51 +00:00
Ole Laursen 4db36b0fbc Add a generic state help page, make provisions for displaying
IESG I-D states in it
 - Legacy-Id: 5635
2013-04-10 16:11:27 +00:00
Henrik Levkowetz becd10a81d Merged [5570] from rjsparks@nostrum.com:
Moves the interface to edit shepherds and sheperd writeups out of the 
wgtracker interface and into the doc views (via idrfc).
Added a little to the simple authorization code (can_edit_) in idrfc.
Added a way to reset the writeup to the current templates (leaving 
extension points to take templates for non-ietf stream documents).
Fixes bug #967.

Implementation notes:
Currently reused EmailsField -- in the long 
run a better approach will be to build a similar PersonField.

This also fixes tickets #834 and #691 (which were effectively duplicates 
of #967)
 - Legacy-Id: 5631
Note: SVN reference [5570] has been migrated to Git commit 3bc9e9a7add65bf135d669381cb5d93c5a2e3e19
2013-04-07 20:40:15 +00:00
Henrik Levkowetz 7a98fff79c Merged [5476] from rjsparks@nostrum.com:
* Added a document type for changing the publication status of other documents, and the UI for manipulating them.
* Added charters, conflict reviews, and status changes to the AD's \'My Documents\' page
* Improved the presentation of all document types on the Agenda, Future Telechats, Scribe and Moderator package pages
* Made the reverse name for document relationships explicit rather than deriving them from forward names
* Added a way to get to the underlying Document (when it exists) from an RfcWrapper
* Unified several common forms used by different document types
 - Legacy-Id: 5629
Note: SVN reference [5476] has been migrated to Git commit 10b4f7a4dc
2013-04-07 19:11:18 +00:00
Ole Laursen e94d1df549 Clean up search views and remove dead code, port them to the new DB
schema, hack related views in iesg/ and wginfo/ to use the new search
interfaces, avoid camelCase in search GET parameters (with
backwards-compat fallback), add some simple search unit tests, remove
caching from views_search.py index pages as they're now pretty fast to
generate, rewrite ballot popup JS, regularize some CSS classes to use
hyphen-notation rather than camelCase, move some of the search
templates to doc/.

idrfc/ now mostly contains some wrapper code still in use by other
subdirs, some ported code not yet moved, and dead code.
 - Legacy-Id: 5611
2013-04-04 13:42:57 +00:00
Henrik Levkowetz 2f3476690f In order that document states (which may be used by old documents) should not need to be removed when state machines change and states go out of use, all document states have a 'used' field. The code which accesses the state fields have not been requiring that used=True for the states returned, which is an error. Fixed this by adding 'used=True' to all State.objects.get() and State.objects.filter() call where it's relevant.
- Legacy-Id: 5486
2013-03-05 23:24:41 +00:00
Robert Sparks 8a7c5ac977 All documents show on the AD status page now
- Legacy-Id: 5422
2013-02-04 02:24:14 +00:00
Robert Sparks c67661311f Improved validaiton of status change document name
added the ability to start a status change when looking at an RFC (populating the start from accordingly)
Made changes and proposed changes show on the RFC pages
 - Legacy-Id: 5330
2013-01-28 16:25:42 +00:00
Robert Sparks 589ff698ee Merge forward complete
- Legacy-Id: 5328
2013-01-24 21:28:27 +00:00
Ole Laursen 9bcc4a9f3d Remove ballot.tsv view and comment out the ballot.json view in urls.py
- Legacy-Id: 5299
2013-01-18 13:54:33 +00:00
Ole Laursen accf6d4470 Move idrfc/views_doc.py to doc/ with associated templates, replace the
somewhat fragile simple URL tests for views_doc.py with ordinary unit
tests. The new tests are still fairly basic but at least test more
than the URL tests did.
 - Legacy-Id: 5295
2013-01-18 13:17:00 +00:00
Ole Laursen 6062e16c2d Email IANA and RFC Editor when a draft is pulled from the queue at the
Datatracker, add page for editing IANA states, add more info to the
/doc/draft-XXXXX/doc.json dump for the RFC Editor, add page for
editing consensus, add page for requesting publication at the RFC
Editor for alternate streams (this will email the RFC Editor and set
the draft in the appropriate state), make it possible for alternate
streams to change the intended RFC status of a draft in the stream,
refactor how IANA copies are handled slightly so it's less code, put
drafts automatically in IANA Review "Need Review" state upon last
call, fix a bug in ballot issuing, remove a bit of dead code
 - Legacy-Id: 4857
2012-09-17 16:15:45 +00:00
Henrik Levkowetz 798f7697af Merged [4600] from rjsparks@nostrum.com:
* Adds a new document type for conflict reviews, with a ballot for the IESG 5742 response to a review request
* Integrated the new document type into the iESG agenda views (including RSS feeds)* Removed the Edit and Add buttons from the document main view.
* Replaced Add with actions appropriate for the document type, such as "Begin IESG Processing" or "Begin IETF Conflict Review", and made most data directly editable on the document's main page, depending on access permissions.
* Removed a manual editing step that the secretariat had to perform when sending conflict review messages. The view now composes the message correctly given the stream.
* Added a pencil icon motif to differentiate fields that are editable.
* Generalized several views and helper functions to use Document instead of (e.g.) IdWrapper
* Generalized reading documents from the repository
* Added a way to get from IdWrapper  to the underlying Document to facilitate migrating way from the Wrapper classes* Added many helpers to Document to assist with migrating off IdWrapper
* Minor fixes and other changes
  * Fixes to document main view to avoid (silent) template failures. 
  * Began removing some of the code that is no longer reachable post-migration  * Corrected the behavior of the undefer code and added test cases for it
  * Improved initial population of notification lists and added the ability to regenerate the initial list
* Made the test code that scans for template coverage more robust
* Deployment notes:
  * new setting: CONFLICT_REVIEW_PATH. The associated directory will need to be created

This branch fixes bugs #805, #744 and #812
 - Legacy-Id: 4652
Note: SVN reference [4600] has been migrated to Git commit 798e7a50e7
2012-07-28 16:29:28 +00:00
Henrik Levkowetz 5d97058c8b Applied ballot popup patch from olau@iola.dk.
- Legacy-Id: 4629
2012-07-27 20:09:23 +00:00
Henrik Levkowetz a1ea63c16a Ballot ids are limited to integers, rather than being descriptive as intended at one point. Adjusted the url regexes accordingly. Patch from olau@iola.dk.
- Legacy-Id: 4610
2012-07-10 09:52:56 +00:00
Robert Sparks f3fd4db35c Merge forward complete - checkpointing before fixing popup position dialogs
- Legacy-Id: 4595
2012-07-04 19:35:46 +00:00
Henrik Levkowetz 6a58f8ec20 Start getting rid of the name= parameter of the urlconf. At first they look helpful, but it's a great bother to have to search for where every damn name is, instead of just reading it out of the code in the template or urlreverse.
- Legacy-Id: 4575
2012-07-03 20:27:56 +00:00
Henrik Levkowetz 8a57be6b80 There are old drafts which contain '+' in the name. Accept that in the urlpatterns so url reverses work.
- Legacy-Id: 4523
2012-06-27 08:40:25 +00:00
Robert Sparks 51ab8123d9 merged in from 4.20-ise
- Legacy-Id: 4502
2012-06-22 20:25:17 +00:00
Henrik Levkowetz 3683a6af26 Backporting patches from production system.
- Legacy-Id: 4487
2012-06-21 00:35:33 +00:00
Ole Laursen 278776f597 Fix regexp fix - [.-_] does not mean "dot or dash or underscore", it
means all characters between dot and underscore
 - Legacy-Id: 4478
2012-06-20 11:13:46 +00:00
Ole Laursen 95c2b07691 Include _ in allowed document name regexp, we currently have 7 drafts
with _ in the database despite it not being valid - they can be found
with:
select name from doc_document where name like '%\_%' and type_id = "draft";
 - Legacy-Id: 4477
2012-06-20 11:00:35 +00:00
Henrik Levkowetz 839df60480 Merged in charter branch fixes from olau@iola.dk, from r4354 through r4381.
- Legacy-Id: 4382
2012-05-04 11:47:30 +00:00
Ole Laursen eaf09d9dc5 Move charter state help to /doc/help/state/charter/.
- Legacy-Id: 4379
2012-05-03 19:23:24 +00:00
Henrik Levkowetz bcd28cc45f Merged in fixes to the migration from olau@iola.dk. Merged in charter branch from olau@iola.dk. Added various fixes and correction of merge errors.
- Legacy-Id: 4353
2012-05-02 19:35:32 +00:00
Ole Laursen 47b466eaae Move charter urls from /wgcharter/<group-acronym> to
/doc/<doc-name>/charter/ since they now all concern the actual charter
documents rather than the WG (this removes some redundant code).
 - Legacy-Id: 4271
2012-04-10 18:11:03 +00:00
Ole Laursen a9817e555a Some fixes to generic doc ballot view, fix edit position and send
ballot comment email views, moving them to
/doc/foo-bar/ballot/[id]/position/ and ../emailposition/.
 - Legacy-Id: 4249
2012-04-03 14:53:38 +00:00
Ryan Cross cbc660e7fb Ticket #673 Add ability to clear ballot
- Legacy-Id: 4212
2012-03-24 14:48:24 +00:00
Ole Laursen c6f59d2c7c Give document tab URLs names.
- Legacy-Id: 4167
2012-03-22 18:20:03 +00:00
Ole Laursen a1b5671ead Preliminary generalization of /doc/ tabs with top factored out, main
page being specific, writeup page generic with some specific code to
setup writeups (only charter ported), history page being generic
(I-D/RFC not ported, needs two event hack fixes), and ballot page
not done, pending on multi-ballot solution.
 - Legacy-Id: 4091
2012-03-15 16:38:56 +00:00
Ole Laursen 328ecb08c3 Replace old charter branches with new branch based on conversion branch and some preliminary work on generalizing document handling
[[Split portion of a mixed commit.]]
 - Legacy-Id: 3883.1
2012-01-31 17:38:27 +00:00
Henrik Levkowetz 12f344054d Merged [2949] from rjsparks@nostrum.com:
Adds a view of documents currently in IETF Last Call

Fixes bug #630
 - Legacy-Id: 2957
Note: SVN reference [2949] has been migrated to Git commit 2cb9e0050a2970e5c5576b46ce75a0b7095532fd
2011-03-26 14:43:24 +00:00
Henrik Levkowetz 6080c7ec02 Don't permit just any characters in the document name; limit this to characters we currently permit in the names, or which has occurred in posted documents. Fixes a problem where non-ascii characters were propagated to the database search and caused collation sequence exceptions, instead of giving 404 errors.
- Legacy-Id: 2813
2011-02-04 12:20:10 +00:00
Henrik Levkowetz 4228daad55 Merged [2613] from fenner@fenron.net:
Split the /doc/ tabs into separate pages. Use
<link rel=prefetch> to ask the tabs to be prefetched
when the first tab is loaded, as documented at
https://developer.mozilla.org/en/Link_prefetching_FAQ .
This fixes #533.
 - Legacy-Id: 2630
Note: SVN reference [2613] has been migrated to Git commit 9391941b867e2f7ce24369be9df009d0ceda9e95
2010-11-06 09:16:59 +00:00
Henrik Levkowetz 28e0f982c5 Merged [2412], [2413] and [2480] from rjsparks@nostrum.com, from log:sprint/78/rjs@2480. Splits the ballot writeups page into three pages, for a more understandable user interface.
- Legacy-Id: 2517
Note: SVN reference [2412] has been migrated to Git commit f87a9376b985814435b1e9b8bb5d73a45fd7292d

Note: SVN reference [2413] has been migrated to Git commit 6835826cb3d5ad1e1558b828bd9d349d5feffa98

Note: SVN reference [2480] has been migrated to Git commit ec80763835dbaad0c68c3bdaee41fdeb92876897
2010-09-16 10:04:48 +00:00
Henrik Levkowetz 266b7820d0 Merged from log:branch/2.00@2363: Current release branch head to trunk.
- Legacy-Id: 2365
2010-07-21 12:48:05 +00:00