Commit graph

14065 commits

Author SHA1 Message Date
Nicolas Giard 742ce5a08e
chore: make dev container use base image 2022-05-24 16:49:37 -04:00
Lars Eggert 53c1377717
ci: Add watchman to image (#4014)
This speeds up repeated runs of `parcel`, but unfortunately not the initial one.
2022-05-24 15:42:20 -05:00
Robert Sparks 0e599ea864
fix: show session name on meeting/upcoming. Fixes #4010. (#4017)
* fix: show session name on meeting/upcoming. Fixes #4010.

* fix: remove stray right paren
2022-05-24 15:23:47 -05:00
Nicolas Giard 8e0ff71709
ci: remove pip install from base docker image 2022-05-24 16:17:08 -04:00
Nicolas Giard 0eb9cb4f57
ci: use new app base docker image for tests 2022-05-24 15:59:43 -04:00
Nicolas Giard a7d080b4df
ci: build app base docker image 2022-05-24 15:50:01 -04:00
Lars Eggert bf22223877
Update d3 (#4016)
* Over to slate

* Port to d3@4

* Port to d3@5

* Port to d3@7 (current release)

* Fix axis font size
2022-05-24 11:07:14 -05:00
Lars Eggert 9a24ee7e94
fix: Make AD position colors more noticeable (#4013)
* fix: Make AD position colors more noticeable

Also remove the striping of the table, which makes it easier to notice which
documents are missing a ballot.

* Make "yes" a bit darker

* Stripe the table for non-ADs
2022-05-24 09:51:34 -05:00
Lars Eggert 0a8641cc75
fix: Fix whitespace at end of link (#4015) 2022-05-24 08:55:59 -05:00
Nicolas Giard 9316429e0e
chore: remove workspace chown from dev init script + add warning when using root 2022-05-21 00:18:24 -04:00
Robert Sparks 49cf639f16
fix: improve person selection when receiving IANA email (#3993) 2022-05-20 16:20:26 -05:00
Robert Sparks c89f7c89c5
feat: begin supporting the new rfc editor model (#3960)
* feat: restructure rfcedtype groups. add rpc, rswg, rsab.

* feat: show rfc editor groups on menu

* feat: add the editorial stream

* fix: repair broken html and extent dest coverage.

* chore: address Lars review comment

* chore: update copyright notices.
2022-05-20 12:22:17 -05:00
Nicolas Giard b6186f1fab
chore(dev): fix uid/gid mapping for non-vscode devs (#3981)
* chore: fix uid/gid mapping for non-vscode devs

* chore: fix volume ownership in devcontainer

* chore: use zsh in init script + remove temp mounted folders

* chore: ignore group mapping error during devcontainer build

* chore: fix ownership when running as root on host

* chore: use new docker compose command format + fix root check

* chore: improve uid/gid mapping message output

* chore: include chromedriver permission fix

* chore: skip parent dev image and install node directly instead of nvm

* chore: reapply gitignore changes + better dev help message
2022-05-20 09:10:41 -05:00
Lars Eggert fa17ddd705
refactor: tweak the horrible code in SearchableField (#3957)
* Fix: Tweak the horrible code in SearchableField so another corner case works

Fixes #3940. Hopefully doesn't break anything.

* fix: remove incorrect remaining loop.

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-05-19 12:38:10 -05:00
Lars Eggert 8ef92312d0
fix: Don't urlencode all resource URLs (#3988)
While this does suppress errors, it breaks even valid URLs. Instead, just
suppress the validation error for those few cases in the database.
2022-05-19 12:31:29 -05:00
Lars Eggert 820b70a4f1
chore: Remove some unneeded things from .gitignore (#3945)
* chore: Remove some unneeded things from .gitignore

* Address review comments
2022-05-19 11:51:18 -05:00
Lars Eggert f39e70a0a0
fix: Don't add newlines at EOF, it cause visible whitespace for HTML includes (#3989) 2022-05-19 08:21:12 -05:00
Lars Eggert a1518e4dcb
fix(ui): debounce the scroll event to make chrome happy (#3958)
* fix: Debounce the scroll event, to make Chrome happy

* Address review comments

* fix: Prevent overscrolling from scrolling the main content

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-05-18 14:01:22 -05:00
Lars Eggert de6d8b2b2a
fix: Prevent righthand-nav from overlapping the footer on short screens (#3980)
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-05-18 13:19:23 -05:00
Lars Eggert de7ff7e84e
test: fix more validation issues (#3975)
* fix: Avoid numeric IDs on NomCom pages

* fix: Correctly group last names with lowercase/i18n parts

* Remove some unneeded CSS

* fix: Remove extra div closing tag
2022-05-18 10:58:39 -05:00
Jennifer Richards 4a5583845e
fix(ui): import moment.js library with moment-timezone support in wrapper (#3977)
* fix: import moment.js library with moment-timezone support in wrapper

Packaging changes broke the mechanism used to make moment.tz available
to javascript code. This eliminates the separate moment.js and
moment-timezone-with-data-10-year-range.js wrappers and instead
imports the timezone-augmented version directly. This provides both
the timezone support and the regular moment features.

* refactor: put moment on window instead of global for consistency
2022-05-18 09:23:07 -05:00
Nicolas Giard 2b94db2161
ci: run tests on PRs with node + python dependencies changes 2022-05-17 00:17:17 -04:00
Robert Sparks 502ed78f8e
chore: clean unused /etc directory (#3963) 2022-05-14 08:12:55 -05:00
Robert Sparks 249db17ae7
chore: keep the database in sync with django-simple-history (#3967) 2022-05-14 08:12:35 -05:00
Nicolas Giard 8a7f67d4d1
test: make tests run without root access (#3968) 2022-05-14 08:11:44 -05:00
Nicolas Giard f1472ffcac
chore: run devcontainer as user vscode instead of root (#3948) 2022-05-13 14:13:50 -05:00
Lars Eggert f4ce041dcc
fix: Add whitespace before "for" (#3951) 2022-05-13 14:13:14 -05:00
Lars Eggert f6c95be1fc
chore: Update deps (#3954) 2022-05-13 14:08:26 -05:00
Lars Eggert 75a32d2210
fix: Link to reviews from search status column (#3955)
* fix: Link to reviews from search status column

Fixes #3953

* fix: Make the notices about exceeded state times less obtrusive

* Fix tests
2022-05-13 14:05:42 -05:00
Lars Eggert b265bac1fe
fix: Fix action holder form buttons (#3956)
Fixes #3943
2022-05-13 14:01:14 -05:00
Lars Eggert 39525a1cd0
fix: escape the ballot comments (#3952)
I wonder if other fields that have class `pasted` would need to be escaped, too?
2022-05-12 12:17:48 -05:00
Jennifer Richards cb996c5c0b
fix: refactor/correct calculation of week-view event start/end times (#3947)
* fix: use DST-friendly tz calculation for TimeSlot end times

Around DST changes, localize(time + duration).astimezone() is not
the same as localize(time).astimezone() + duration. The latter allows
tz-aware times to do their magic and give correct clock times.

* fix: refactor/correct calculation of week-view event start/end times

There were bugs in the timestamp calculations around DST switchover.
This corrects those and tries to clarify and improve documentation in
the relevant code.
2022-05-11 16:08:47 -05:00
Nicolas Giard 636ebd7c81
chore: remove browser dropdown from report bug issue template 2022-05-10 18:51:35 -04:00
Nicolas Giard ed80308225
chore: update issue config links 2022-05-10 18:33:31 -04:00
Nicolas Giard 98108e020b
chore: fix new request issue template filename 2022-05-10 18:31:49 -04:00
Nicolas Giard 58ad3db836
chore: add new feature issue template 2022-05-10 18:30:36 -04:00
Nicolas Giard 7f8c58355f
chore: fix issue template 2022-05-10 18:25:31 -04:00
Nicolas Giard 25390ab896
chore: update issue template wording 2022-05-10 18:24:58 -04:00
Lars Eggert 5f8d4ed718
More HTML nitfixing (#3934)
* Unicode messages are triggered by both db content and tests

* Make ids unique

* Avoid "No value found" message on page

* Strip HTML from history entries, it's often broken

* Check HTML sources for occurrences of "** No value found for" and fix them

* Fix another occurrence of "** No value found for"

* Fix more occurrences of "** No value found for"

* Fix document revision stripping

* Force breaks of long (garbage) words

* Check URL validity before urlizing them

* Handle some additional corner cases

* Linkify action items

* Don't create profile/email links for System

* Handle headings with HTML elements in them better

* Fix comment

* Fix another occurrence of "** No value found for"

* Better I-D URLization that handles more edge cases. Also, test for them.

* Remove print

* Handle charters better

* Cache for one day
2022-05-10 12:37:14 -05:00
Robert Sparks 47b89c1112
chore: alter CSP to enable analytics (#3941) 2022-05-09 13:38:50 -05:00
Robert Sparks cdd86b9d5e
ci: show makemigrations output (#3932)
* ci: show makemigrations output

* chore: remove unused releasetest settings
2022-05-03 20:54:25 -05:00
Robert Sparks def13a872a
chore: catchup with pytz country (#3933) 2022-05-03 20:54:02 -05:00
Robert Sparks d4ebbe41e8
feat: improve notes imports by using de-gfm -4. Related to #3851. (#3930) 2022-05-03 18:04:48 -05:00
Nicolas Giard 3606dbef38
ci: fix makemigrations echo during pr checks + build 2022-05-03 18:31:50 -04:00
Lars Eggert 5598762608
fix: add more HTML validation & fixes (#3891)
* Update vnu.jar

* Fix py2 -> py3 issue

* Run pyupgrade

* test: Add default-jdk to images

* test: Add option to also validate HTML with vnu.jar

Since it's already installed in bin. Don't do this by default, since it
increases the time needed for tests by ~50%.

* fix: Stop the urlizer from urlizing in linkified mailto: text

* More HTML fixes

* More HTML validation fixes

* And more HTML fixes

* Fix floating badge

* Ignore unicode errors

* Only URLize docs that are existing

* Final fixes

* Don't URLize everything during test-crawl

* Feed HTML into vnu using python rather than Java to speed things up

* Allow test-crawl to start vnu on a different port

* Increase retry count to vnu. Restore batch size to 30.

* More HTML validation fixes

* Use urllib3 to make requests to vnu, since overriding requests_mock is tricky

* Undo commit of unmodified file

* Also urlize ftp links

* Fix matching of file name

* More HTML fixes

* Add `is_valid_url` filter

* weekday -> data-weekday

* urlencode URLs

* Add and use vnu_fmt_message. Bump vnu max buffer.

* Simplify doc_exists

* Don't add tab link to mail archive if the URL is invalid

* Run urlize_ietf_docs before linkify

Reduces the possibility of generating incorrect HTML

* Undo superfluous change

* Runner fixes

* Consolidate vnu message filtering into vnu_filter_message

* Correctly handle multiple persons with same name

* Minimze diff

* Fix HTML nits

* Print source snippet in vnu_fmt_message

* Only escape if there is something to escape

* Fix snippet

* Skip crufty old IPR declarations

* Only include modal when needed. Add handles.

* Fix wordwrap+linkification

* Update ietf/doc/templatetags/ietf_filters.py

* Update ietf/doc/templatetags/tests_ietf_filters.py

* Don't right-align second column
2022-05-03 13:55:48 -05:00
Nicolas Giard f778058005
ci: add db migrations checks to tests and build workflows (#3920)
* ci: add db migrations checks to tests and build workflows

* ci: refactor migrations check expression

* chore: rework conditional and exit

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-05-03 12:06:41 -05:00
Lars Eggert 19796c56c9
fix: Stretch righthand-nav to viewport edge (#3921)
* fix: Stretch righthand-nav to viewport edge

Fixes #3848

* Also improve tz-select display, while we're here

* Change func name
2022-05-03 09:35:10 -05:00
Lars Eggert 169ab1c10f
fix: Adopt -> Manage adoption (#3922)
Fixes #3877
2022-05-03 09:32:24 -05:00
Lars Eggert f4b8fc1d0d
fix: 2023 -> 2023 in document shepherd template (#3923) 2022-05-03 09:30:17 -05:00
Jennifer Richards 681fae2af5
test: decode email payloads before validating (#3926) 2022-05-03 09:29:42 -05:00