Commit graph

519 commits

Author SHA1 Message Date
Henrik Levkowetz 726fcbf27d Removed all __future__ imports.
- Legacy-Id: 17391
2020-03-05 23:53:42 +00:00
Henrik Levkowetz e9a37d8ac8 Removed six.text_type(), changed six.moves.urllib to plain urllib, and removed now unused six imports.
- Legacy-Id: 17385
2020-03-05 14:41:41 +00:00
Henrik Levkowetz 095c3a2ccb Fixed an issue where the lookup of recognized country names during draft submission grabbed the unicode name instead of the ascii name for non-ascii country strings in XML submissions.
- Legacy-Id: 17345
2020-02-26 17:20:13 +00:00
Henrik Levkowetz a7baacf519 Added missing .as_strings() to some gather_address_lists() calls, in order to assign strings rather than lists to Message CharField instances. Fixed a Message content_type setting.
- Legacy-Id: 17337
2020-02-26 16:59:18 +00:00
Henrik Levkowetz 9439f718d4 Wrapped more code in an exception block, in order not to continue processing after an XML parse exception. Fixes issue #2885.
- Legacy-Id: 17305
2020-02-18 20:20:09 +00:00
Henrik Levkowetz e79eb56c01 Changed the xml parser settings for legacy xml draft submissions to remove comments before converting to .txt. Fixes and issue with comments in <artwork> text.
- Legacy-Id: 17297
2020-02-16 15:48:45 +00:00
Henrik Levkowetz 65ca6e240c Added some raw_id fields to avoid long page load times
- Legacy-Id: 17267
2020-01-30 22:13:29 +00:00
Henrik Levkowetz 096c08aac4 Added a test case for draft submission errors due to periods in document names.
- Legacy-Id: 17251
2020-01-18 15:07:51 +00:00
Henrik Levkowetz 060539cf1f Added a suggestion to the error message issued for invalid characters in document names found in draft submission XML files, when the invalid character is a period. In this particular case, the problem most likely is inclusion of the filename extension in the document name. Fixes issue #2874.
- Legacy-Id: 17250
2020-01-18 15:06:17 +00:00
Henrik Levkowetz edf28348aa Changed draft submission field validation taking place in clean() to associate the errors with the field in question, rather than raising them as general form errors.
- Legacy-Id: 17249
2020-01-18 15:01:35 +00:00
Henrik Levkowetz 76ee1b8cdf Fixed a Py3 issue trying run .decode() on (already decoded) str.
- Legacy-Id: 17248
2020-01-18 14:59:08 +00:00
Henrik Levkowetz 3db48727ea Specified explicit UTF-8 decoding of submission checker output
- Legacy-Id: 17194
2020-01-07 22:26:00 +00:00
Henrik Levkowetz 6482254a03 Merged in ^/branch/akayla/irsg/6.113.1.dev0 from peter@akayla.com.
This provides support for IRSG ballots, similar to the IESG ballots support which has been in use for quite some time.  The IRSG ballots differ from IESG ballots in a number of ways, described in detail in the RFP and SoW for this work and implemented here.
 - Legacy-Id: 17164
2019-12-20 15:00:55 +00:00
Henrik Levkowetz 202d112e0d Added handling for a decoding exception during submission processing.
- Legacy-Id: 17151
2019-12-16 13:32:51 +00:00
Peter E. Yee bb7e504d14 12/13 merged into 6.113.1.dev0 with migration ordering failure
- Legacy-Id: 17149
2019-12-13 19:53:45 +00:00
Henrik Levkowetz ac6b664fa5 Added normalization of draft title extracted from submitted XML.
- Legacy-Id: 17119
2019-12-02 16:24:51 +00:00
Henrik Levkowetz c486ec8003 Fixed naming of staged xml draft submission files and tweaked the arguments for the xml2rfc parser invocation for xml draft submissions. Added some more logging.
- Legacy-Id: 17075
2019-11-21 04:35:31 +00:00
Henrik Levkowetz 98dc8e99f3 Changed the call arguments for submission tool conversion from XML to v3 text to match those of the standalone tool. Fixes an issue where <sourecode> would have line ends stripped when converted by the datatracker.
- Legacy-Id: 17021
2019-11-12 18:27:01 +00:00
Henrik Levkowetz b7724c43d7 Changed some # type: ignore statements to work with the latest mypy
- Legacy-Id: 16968
2019-11-05 22:41:18 +00:00
Henrik Levkowetz bf299bbfb5 Be more liberal with v3 xml submissions.
- Legacy-Id: 16956
2019-11-04 18:13:22 +00:00
Henrik Levkowetz 994e0ba6cc Moved the code that generates .txt and .html draft files from .xml to a place where potential errors can be caught and displayed better. Related to ticket #2814.
- Legacy-Id: 16862
2019-10-15 14:33:35 +00:00
Henrik Levkowetz 5b3b9c2791 Reverting the previous commit
- Legacy-Id: 16857
2019-10-10 18:32:49 +00:00
Henrik Levkowetz c58f370104 Updated requirements3.txt. Explicitly listing mypy version requirements is counter-productive as it is determined by django-stubs.
- Legacy-Id: 16856
2019-10-10 18:31:25 +00:00
Henrik Levkowetz 9d4ca615d3 Merged in [16607] from rcross@amsl.com:
Fix issue where third session requests, which rerequire AD approval, get left with approved status, instead of scheduled, after Secretraiat sends out notifications of official schedule.  Fixes #2765.
 - Legacy-Id: 16817
Note: SVN reference [16607] has been migrated to Git commit 9a82586e1b
2019-10-02 20:55:54 +00:00
Henrik Levkowetz 07375b46f8 Added log.unreachable() for the code that creates unknown-email-*' addresses. Addresses issue #2696.
- Legacy-Id: 16814
2019-10-02 17:45:44 +00:00
Henrik Levkowetz 33e8733b91 Fixed up mypy issues or added type:ignore comments as needed for a clean mypy run.
- Legacy-Id: 16772
2019-09-30 15:42:18 +00:00
Henrik Levkowetz e0479d8d13 Changed the call signature of docevent_from_submission() to take an optional Person object, rather than person name. Added a type hint for the signature.
- Legacy-Id: 16764
2019-09-29 20:00:49 +00:00
Henrik Levkowetz a1db2d5aef Tweaked the condition for waiving submission email confirmation slightly.
- Legacy-Id: 16760
2019-09-27 06:12:55 +00:00
Henrik Levkowetz 3939c0b88c Changed draft submission to not require an email round-trip when the submitter is logged in. Added corresponding test cases.
- Legacy-Id: 16749
2019-09-26 14:43:26 +00:00
Henrik Levkowetz 466bd0675e Added asciiFullname and asciiSurname attributes to the XML submission test template.
- Legacy-Id: 16748
2019-09-26 14:41:48 +00:00
Henrik Levkowetz 125ec9b3b7 Added a template interpolation variable for document title to the submission test text template.
- Legacy-Id: 16747
2019-09-26 14:40:36 +00:00
Henrik Levkowetz eabf121abe Added code to detect conflicting information for draft name, revision, and title when both XML and text versions of a document are submitted.
- Legacy-Id: 16746
2019-09-26 14:38:47 +00:00
Henrik Levkowetz 78889979a1 Changed the draft submission form and views so that an email address is required for each author in order to complete self-service draft submission. It is possible to add these as metadata updates, but this will lead to submission through the secretariat (and the email addresses will still be required). Also updated related templates to make the handling of form section headings more consistent.
- Legacy-Id: 16745
2019-09-23 17:26:16 +00:00
Henrik Levkowetz a3f59ee9a2 Added conversion of version 3 XML draft submissions to v3 HTML, in addition to text. Added a link to HTML versions (when present) to the document status page, and renamed the link to the htmlized version to 'htmlized'. Converted the submission XML test-file to version 3. Added test code to check that HTML is generated for version 3 XML submissions.
- Legacy-Id: 16737
2019-09-20 14:24:44 +00:00
Henrik Levkowetz 44f42cdb3a Undid the previous commit
- Legacy-Id: 16735
2019-09-20 11:30:04 +00:00
Henrik Levkowetz e3e9f676b7 Added class 'bg-danger' to submission error messages. The big 'Meta-Data errors found' pane on red background is so noticeable that class 'text-danger' which gives bold text is insufficient to stand out clearly. Adding 'bg-danger' gives the specific error messages red background, too.
- Legacy-Id: 16734
2019-09-20 11:28:53 +00:00
Henrik Levkowetz 8e313e4ed5 Adjusted migrations for Python2/3 compatibility.
- Legacy-Id: 16633
2019-08-08 17:11:14 +00:00
Henrik Levkowetz 22e0d39e4b Fixed an issue where text file charset information would be overwritten on upload of multiple files for a draft. Fixes issue #2768.
- Legacy-Id: 16626
2019-08-06 15:41:13 +00:00
Henrik Levkowetz 915d8e3c2a Added LookupError to the exceptions caught during text upload decoding, leading to upload form validation error.
- Legacy-Id: 16573
2019-07-22 15:47:40 +00:00
Henrik Levkowetz e03784132d Merged changes from current trunk to Py3 branch.
- Legacy-Id: 16468
2019-07-16 15:36:16 +00:00
Henrik Levkowetz bdc73e771a Python2/3 compatibility: replaced six.ensure_text() with either six.text_type or django's force_text(), depending on the case, and fixed a variable scope issue.
- Legacy-Id: 16461
2019-07-16 13:20:05 +00:00
Henrik Levkowetz 8c6eb3a30a Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc.
- Legacy-Id: 16458
2019-07-15 19:14:04 +00:00
Henrik Levkowetz ea8c84d2f6 Python2/3 compatibility: used @python_2_unicode_compatible to provide __unicode__() versions of __str__() methods.
- Legacy-Id: 16455
2019-07-15 18:01:26 +00:00
Henrik Levkowetz 99a7f9c263 Python2/3 compatibility: Added force_str or force_bytes in some places, to ensure the argument right type
- Legacy-Id: 16453
2019-07-15 17:13:46 +00:00
Henrik Levkowetz 855716e1d5 Py2/3 compatibility: Added __future__ import
- Legacy-Id: 16448
2019-07-15 15:46:06 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3
- Legacy-Id: 16446
2019-07-15 15:40:51 +00:00
Henrik Levkowetz f481f5c3e6 Replaced use of six with the equivalent pure python3 constructs.
- Legacy-Id: 16428
2019-07-08 10:43:47 +00:00
Henrik Levkowetz 48bab56be9 Removed a print() call
- Legacy-Id: 16420
2019-07-07 13:04:20 +00:00
Henrik Levkowetz 1225f8af6b Refactored submission code to be clearer and only do mimetype extraction in one place, made the point where files are saved less obscure, fixed bytes/str issues for file read and write, fixed regex strings, fixed variable name visibility due to scope changes in py3.
- Legacy-Id: 16375
2019-07-04 15:49:42 +00:00
Henrik Levkowetz 2e92652eaa Changed a regex to use an r string. Added decoding of command pipe output.
- Legacy-Id: 16374
2019-07-04 15:45:18 +00:00