Commit graph

905 commits

Author SHA1 Message Date
Jennifer Richards 117e07e5ff
Merge pull request #5935 from rjsparks/fixups3
fix: repair various doc view and tests
2023-07-07 11:47:13 -03:00
Robert Sparks 799d3a1a3e
fix: adjusted bibtex view and tests 2023-07-06 17:24:05 -05:00
Jennifer Richards fc284be6d8
fix: Deal with rfc doc types for references/referenced_by views 2023-07-06 17:44:32 -03:00
Robert Sparks f53a849660
fix: various corrections to rfc main document view and tests (#5931) 2023-07-06 17:24:35 -03:00
Jennifer Richards 8f0b459050
refactor: Replace is_rfc() tests (#5925)
* refactor: Remove is_rfc() - test type_id instead

* fix: Guard against unknown pub_date

This should not ever come up - we have a published_rfc event for
every rfc. Should investigate fixing pub_date() to always return a val.
2023-07-06 12:07:53 -03:00
Jennifer Richards 5d9d87897d
fix: Show rfc documents via document_main view (#5919)
* fix: Fix friendly_state() for drafts in rfc state

* refactor: Change became-rfc to became_rfc for consistency

* refactor: Begin handling RFCs separatly in document_main

WIP

* chore: Hide reviews and conflict reviews for RFCs

* chore: Remove irrelevant fields from rfc doc view

* chore: Remove unused variables

* chore: Remove "Versions" field from document_rfc.html

* chore: Hide "Nits" button for RFC documents
2023-07-05 17:30:20 -03:00
Jennifer Richards 771296bbe6
feat: Link rfc/draft document history pages (#5894)
* fix: Do not show "rev" column for rfc document history

* style: Reformat document_history() using Black

* refactor: Use "is not None" instead of "!= None"

* refactor: Convert dict() to dict literal

* fix: Migrate group, stream, and ad from draft to rfc Document

* feat: Link rfc/draft history pages
2023-06-28 17:51:31 -03:00
Jennifer Richards f2c2957925
refactor: Represent RFCs as their own DocType (#5835)
* feat: Add RFC DocTypeName, StateType, and States

* refactor: Rename rfc_number() to deprecated_rfc_number()

* feat: Add rfc_number field to DocInfo

* feat: Add DocRelationshipName "became-rfc"

* chore: First-pass migration to create rfc Documents

* chore: create_rfc_documents migration depends on new names

* refactor: Rename variable

* fix: Fix revname / downcase name for "became-rfc" DocRelationshipName

* chore: Remove debugging print statements

* feat: Point rfc aliases at rfc Documents

* test: Refactor RFC factories

* refactor: Rewrite is_rfc() in terms of type_id

* test: Use RfcFactory as base for IndividualRfcFactory

* refactor: Replace calls to deprecated_rfc_number()

* refactor: Remove deprecated_rfc_number() method

* test: Import WgRfcFactory
2023-06-20 15:28:16 -03:00
Jennifer Richards c8dcda0fae
refactor: Do not use canonical_name() for charters (#5818)
* fix: Enforce naming of charter docs in submit()

* style: Reformat submit() with Black

* refactor: Remove redundant check of charter name

* style: Reformat charter_with_milestones_txt with Black

* refactor: Drop canonical_name, use Path in charter_with_milestones_txt

* style: Reformat review_announcement_text() with Black

* style: Reformat action_announcement_text() with Black

* refactor: Change uses of charter.canonical_name() to charter.name

* refactor: Skip docialias when retrieving charter

* refactor: Change canonical_name() to name in utils_charter.py

* refactor: Use Path in read_charter_text()

* refactor: Drop canonical_name, minor refactor of tests_charter.py

* refactor: charter.name instead of canonical_name in milestones.py

* refactor: charter.name instead of canonical_name in tests_info.py

* refactor: Remove unused functions in ietf/secr/utils/groups.py

* refactor: charter.canonical_name -> charter.name in templates

* refactor: Remove charter handling from canonical_name

Temporarily raise an exception for testing

* refactor: Refactor get_charter_text() without canonical_name

* refactor: Remove raise when canonical_name called on a charter

* fix: Add back missing ".txt" extension

* test: Test rejection of invalid charter names
2023-06-14 08:32:21 -05:00
Lars Eggert 818f0a9938
fix: Add definition of DOWNREF from RFC3967 (#5789)
Fixes #2788, #5759
2023-06-08 15:14:14 -05:00
Robert Sparks 0864b73aab
fix: use slowpages to cache doc/active (#5781) 2023-06-07 15:35:17 -05:00
Robert Sparks 3fc77633a7
fix: protect htmlize and opengraph templates from fake dochistory objects (#5764) 2023-06-05 20:19:25 -05:00
Jennifer Richards 1922a6066e
Merge pull request #5700 from ietf-tools/main
chore: main -> django4
2023-05-31 10:59:09 -03:00
Nicolas Giard 0a11892414
chore: use variable for static.ietf.org references (#5692) 2023-05-25 17:23:18 -05:00
Jennifer Richards cdec6cc0aa
Merge pull request #5655 from ietf-tools/main
chore: Merge main into feat/django4
2023-05-18 15:15:42 -03:00
Robert Sparks f9322391dd
fix: change trac.ietf.org links to what they redirect to now (#5651) 2023-05-18 08:31:54 -05:00
Nicolas Giard 12f1cb200a
feat: set fonts for htmlized doc template (#5636) 2023-05-16 14:56:36 -05:00
Jennifer Richards 00f3f01e7e
fix: {% endif %}, not {% end %} 2023-05-12 18:52:35 -03:00
Jennifer Richards 32ed1b7c4a
refactor: Replace deprecated {% ifequal %} with {% if %} 2023-05-12 18:33:15 -03:00
Ian Williams a778377bb8
fix(doc): Replace iconography for position's email status with text label (#5421)
* fix(doc): Use text badges for email status

BI's envelope icons with status icons are difficult to read.
Use text labels instead (keeping the same tooltip).

Fixes #3855.

* test(doc): Fix failing ballot message tests

Some ballot message changes have been modified to correctly identify
what type of document this ballot is for.

Works on #3855

* test(doc): Remove debugging statement

Accidental inclusion of debug statement.

Works on #3855
2023-03-27 13:58:51 +09:00
Jim Fenton d25eca930d
fix(doc): remove revision from shepherd writeup title (#5413)
Fixes #4200
2023-03-25 16:15:34 +09:00
Lars Eggert 8f8a3489ea
fix: Add reviewer name to review assignment summary (#5363)
* fix: Add reviewer name to review assignment summary

Fixes #5360

* Address code review

* Fix test harder
2023-03-20 10:23:45 -05:00
Lars Eggert 57030e4303
fix: Pre-sort WG doc table on date (#5361)
Fixes #5341.

Also remove some js code that was only used on the old agenda
page while I'm here.
2023-03-17 12:07:25 -05:00
Lars Eggert 1d87686a2b
fix: Add missing closing brace in meta tag and updated/obsoleted-by info (#5265)
* fix: Add missing closing brace in meta tag

Fixes #3379

* Also fix "obsoleted by" meta information

* name -> canonical_name
2023-03-03 10:49:15 -06:00
Jennifer Richards 8041cd5c40
fix: Avoid unwanted whitespace when action_holder_badge is empty (#5266) 2023-03-02 15:17:39 -06:00
Lars Eggert cf94b896c8
feat: Add reminder that AD changes for approved documents are unusual (#5231) 2023-02-28 10:21:39 -06:00
Lars Eggert caf80efd84
feat: Prefill the abstract, shepherd and AD info into a ballot writeup (#5218)
* feat: Prefill the abstract, shepherd and AD info into a ballot writeup

* Suggestions from @rjsparks

* Remove instructions to add IANA Expert template.

* Make "notes" fields for various bodies conditioned on the doc stream
2023-02-27 12:19:39 -06:00
Lars Eggert 02f8bf20ef
feat: Add a "report errata button" (#5193)
And also rename "report a bug" to "report a datatracker bug", in the hopes of
reducing GitHub tickets that are not datatracker-related.
2023-02-24 09:13:00 -06:00
Robert Sparks 9ea8523e85
feat: add target to bibxml-ids (#5148) 2023-02-15 11:37:56 -06:00
Lars Eggert 35f1d21302
fix: Fix deferring ballots from the "edit position" view (#5106)
Fixes #4903
2023-02-11 10:11:05 -06:00
Lars Eggert f8b48f4c43
fix: use Internet-Draft more consistently across the UI (#5104)
* s/Internet Draft/Internet-Draft/i

* s/draft/Internet-Draft/i or s/draft/I-D/i

* s/ID/I-D/

* Fix tests

* a -> an

* Undo case-change to ASCII

* Address code review comments

* Add migrations

* Add merged migration

* fix: straighten out migrations

* fix: finish straightening out migrations

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-02-11 10:09:28 -06:00
Lars Eggert 6a6a3db3b9
fix: Don't try to further linkify rfc2html output (#5112)
* fix: Don't try to further linkify rfc2html output

Fixes #5111

* Fix test
2023-02-10 14:33:54 -06:00
Lars Eggert 1afce6669d
fix: Fix HTML validation issues (#5081) 2023-02-06 09:40:38 -06:00
Lars Eggert 7ddc09ef25
fix: Break long words in cards to prevent layout jumps (#5064) 2023-02-01 10:37:20 -06:00
Robert Sparks afac1f8f19
feat: enable editorial stream adoption and balloting (#5011)
* feat: enable editorial stream adoption and balloting

* fix: bring tests into line with refactor

* feat: force intended_std_level to Informational when adopting into a non-ietf stream.

* fix: improve blocking position labels and email content

* fix: simplify pointer to group on doc main page for rswg docs

* fix: recover from merge typos

* fix: correct defer and clear ballot behavior

* fix: improve publication request access logic

* fix: clean up broken editorial state

* fix: adjust test to match migrations
2023-01-31 13:50:51 -06:00
Lars Eggert 61f7984d5c
fix: Handle unset cookies correctly (#5023)
Fixes #5015
2023-01-24 09:02:21 -06:00
Robert Sparks 43c7e92d9d
feat: remove the format element from the bibxml-id source of truth (#5017) 2023-01-23 18:03:19 -06:00
Lars Eggert 570bd141ae
Limit the width of the document selectors to the width of the parent. (#4968)
* Limit the width of the document selectors to the width of the parent.

It's unfortunately not responsive (select2 limitation), but better
than being too long.

* Force "text-overflow: ellipsis" to hide the beginning of a doc name
2023-01-18 10:40:32 -06:00
Lars Eggert e209cae279
Add a datatracker button to the htmlized side pane (#4970)
Fixes #4944
2023-01-18 10:39:43 -06:00
Lars Eggert faf68bc290
fix: Change versions in htmlized sidebar version picker based on shown doc rev (#4977)
Also fix an issue with the revisions list only linking to the latest
version in some cases.

Fixes #4972
2023-01-18 10:38:41 -06:00
Lars Eggert d7a7033a42
fix: Let charter revisions be variable length in the version paginator (#4989)
* fix: Let charter revisions be variable length in the version paginator

Fixes #4988

* Address review comments. Also make major charter revisions bold for readability.
2023-01-18 10:36:21 -06:00
Lars Eggert 1f87ff164f
fix: Add bug report button to htmlized view (#4999)
Fixes #4998
2023-01-18 10:34:18 -06:00
Robert Sparks 0cc907f957
fix: restore display of additional resources (#4956) 2023-01-10 10:19:43 -06:00
Lars Eggert 4b1c10f6ab
feat: Add preference to make citation links go straight to cited docs (#4886)
* feat: Add preference to make citation links go straight to cited documents

* Use localStorage
2022-12-19 13:30:08 -06:00
Lars Eggert ad5cf0bb01
fix: Fix layout issue in ballot modals on narrow screens (#4911)
* fix: Fix layout issue in ballot modals on narrow screens

Fixes #4902

* Also apply change to old positions

* Fix tests

* Use badge to indicate former ADs
2022-12-16 13:09:55 -06:00
Lars Eggert e6e0d8fc1a
feat: Diff arbitrary versions from new HTMLization page (#4863)
* feat: Diff arbitrary versions from new HTMLization page

Fixes #4859

* Rework this based on @rjsparks' suggestion. Not quite done yet.

* Progress

* Fix HTML

* Don't show compare buttons if there aren't at least two versions

* Remove spurious title attribute

* Use and style select2 for the version diff dropdowns

* Roll in code review suggestions

* Some tests!
2022-12-16 10:46:05 -06:00
Lars Eggert 36e6b98394
fix: Fix sidebar hiding functionality (#4891)
Broken by #4860
Fixes #4858
2022-12-14 15:11:41 -06:00
Lars Eggert f0966e43f5
fix: Don't show checker validations on HTMLization page (#4873)
Modals in static sidebars don't work; fixing this needs a larger rework.

Fixes #4865
2022-12-12 13:25:21 -06:00
Lars Eggert 5af9b82927
fix: Properly hide the sidebar on medium and smaller viewports (#4860)
Fixes #4858.
2022-12-09 08:17:21 -06:00
Lars Eggert 7991dadc5e
feat: Add links to tools, so people know where to file issues. (#4851)
* feat: Add links to tools, so people know where to file issues.

* Remove spurious character
2022-12-08 13:58:04 -06:00