Commit graph

919 commits

Author SHA1 Message Date
Henrik Levkowetz 14c748df98 Changed the creation of temporary test dirs to use names which include the test class name, in order to make it possible to run test cases in parallel. Disabled coverage testing when running in parallel (those classes cannot be pickled and distributed to the test runner threads, and also won't pass coverage data back). Tweaked the TestCase.tempdir() method.
- Legacy-Id: 13157
2017-03-27 21:41:18 +00:00
Henrik Levkowetz 605fa26ec3 Made relative paths work for the create_group_wikis commnand. Added wiki and svn dir patterns to docker/settings_local.py.
- Legacy-Id: 13150
2017-03-27 17:07:48 +00:00
Ole Laursen 5608ad0061 Move the assert on new X in the test coverage up before the percentage
to try get the list of URLs out before the percentage
 - Legacy-Id: 13144
2017-03-27 08:45:20 +00:00
Ole Laursen ef4d55f0c9 Apply patch from Henrik Levkowetz to fix some problems of author parse
errors where the affiliation is mistakenly thought to be an extra
author (some of these still remain)
 - Legacy-Id: 13142
2017-03-27 08:33:49 +00:00
Henrik Levkowetz d2c2d80341 Merged in [13112] from lars@netapp.com:
Fix various \'RemovedInDjango20Warning\' warnings.
 - Legacy-Id: 13141
Note: SVN reference [13112] has been migrated to Git commit 8a70e9773d
2017-03-26 22:06:47 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Henrik Levkowetz 3f92aee755 Added the rfcmarkup module. This will be changed to a library dependency when the module is published.
- Legacy-Id: 13038
2017-03-20 13:48:13 +00:00
Henrik Levkowetz 53481eebd8 Added a utility function to create a test-class specific temporary directory.
- Legacy-Id: 13026
2017-03-19 19:25:26 +00:00
Henrik Levkowetz bb5096da8a Added more email validation for draft submission author emails, and blocked some baths that could lead to bad email addresses ('none') being set as document author email addresses.
- Legacy-Id: 13010
2017-03-14 14:07:21 +00:00
Henrik Levkowetz 7b3ce6e795 Improved the log.assertion() and unreachable() functions to send a deeper traceback when reporting by email, rather than just the last stack frame.
- Legacy-Id: 12999
2017-03-13 05:37:02 +00:00
Henrik Levkowetz fe8cd06a76 Back out the htmlization code for the moment.
- Legacy-Id: 12997
2017-03-12 12:12:44 +00:00
Henrik Levkowetz 319a4850d6 Added rfcmarkup code. Will probably be migrated to a separate lib in time.
- Legacy-Id: 12994
2017-03-11 14:02:16 +00:00
Henrik Levkowetz 58dae78a43 Modified the REST API to provide group descriptions taken from the group charters if group.description is blank.
- Legacy-Id: 12993
2017-03-11 13:46:19 +00:00
Henrik Levkowetz 4daf66d11c Added DocEvent rev= parameter througout the code.
- Legacy-Id: 12978
2017-03-06 15:08:21 +00:00
Henrik Levkowetz ff31644ccf Tweaked assertion() and unreachable() to raise an exception instead of sending email (to the test mailbox ...) when running the test suite.
- Legacy-Id: 12977
2017-03-06 14:31:45 +00:00
Henrik Levkowetz 0bcb4ae30c Fixed a problem with assertion() and unreachable(), which could break if certain names (like 'args') were set in the calling frame.
- Legacy-Id: 12975
2017-03-06 13:51:08 +00:00
Henrik Levkowetz 3c6f00869f Dead code removal: meeting models and test_utils.
- Legacy-Id: 12965
2017-03-04 05:19:39 +00:00
Henrik Levkowetz 49ba774ae3 Updated unreachable() marking.
- Legacy-Id: 12962
2017-03-04 05:14:51 +00:00
Henrik Levkowetz 3a21e03f8d Marked a function as unrachable. Added support in send_mail_message for the Message.msgid field.
- Legacy-Id: 12954
2017-03-03 15:43:43 +00:00
Henrik Levkowetz ea70381f29 Merged in [12950] from rcross@amsl.com:
Fixes #2219.  Area Group chairs are denied material management access.
 - Legacy-Id: 12951
Note: SVN reference [12950] has been migrated to Git commit c6d1a59aa4
2017-03-02 21:21:07 +00:00
Henrik Levkowetz 5bb5ca727b Created a special function log.unreachable() to mark code unreachable, and changed a function name from log.affirm() to log.assertion().
- Legacy-Id: 12933
2017-02-28 20:16:52 +00:00
Henrik Levkowetz 5928bd9faa Added svn symlink check and creation to test setup. Forced test settings to use an empty INTERNAL_IPS list for consistency in code coverage figures.
- Legacy-Id: 12929
2017-02-28 18:02:30 +00:00
Henrik Levkowetz 4f12513b1f Tweaked the affirm() failure message.
- Legacy-Id: 12925
2017-02-27 16:42:23 +00:00
Henrik Levkowetz 5f053ad21a Cleaned up the remaining explicit url names, using dotted-paths to view
functions instead.  In all almost 700 changes.
 - Legacy-Id: 12923
2017-02-26 23:21:49 +00:00
Henrik Levkowetz 9fb1a8e05f Tweaked an import to make Python 2to3 able to handle it.
- Legacy-Id: 12922
2017-02-26 10:54:33 +00:00
Henrik Levkowetz 84527c9df6 Added some code to utils.urls.url() to output remaining explicit url names together with the matching dotted-path to the view function.
- Legacy-Id: 12921
2017-02-25 20:32:20 +00:00
Henrik Levkowetz 49af9b4e1a Added an affirm(statement_string) function, which acts like an assert, and lets us trigger an email message with traceback when the statement to affirm is False. Use instead of assert if we still want the server to produce a response, even if something is seriously wrong.
- Legacy-Id: 12901
2017-02-23 11:48:55 +00:00
Henrik Levkowetz 988a2b808f Added explicit charset setting and consistent encoding to several email paths through the datatracker. After introducing support for non-ascii names in email addresses, using role.formatted_email() to insert names into email content doesn't work any more, since uncode names will now be rfc2047-encoded in formatted_email(). Added another method role.name_and_email() for this case. Replaced another case of '%s <%s>' name-and-email formatting with formataddr(). Fixed some tests which did not send unicode email bodies to the email functions. Fixes issue #2017.
- Legacy-Id: 12896
2017-02-21 19:17:10 +00:00
Henrik Levkowetz c889856dfa Added a validator to Document.title to prevent control chars in the title (complementing a recent cleanup of more than 120 instances of document titles containing vertical tabs)
- Legacy-Id: 12893
2017-02-20 20:47:37 +00:00
Henrik Levkowetz 858d855eff Changed the new account creation to require a proper name at the same time as the account password is set, before actually creating the account. Also tweaked the password strength and confirmation code.
- Legacy-Id: 12892
2017-02-20 16:50:39 +00:00
Henrik Levkowetz 8930d29a8e Merged in Django-1.10 upgrade work from ^/personal/henrik/6.43.1-django-1.10
- Legacy-Id: 12881
2017-02-19 18:18:00 +00:00
Henrik Levkowetz cf4a4b02a7 Reworked the email address handling in order to be able to support non-ascii names as part of email address fields. Reworked the generation of user names in the test suite to generate names from multiple non-ascii locales. Fixes issue #2080.
- Legacy-Id: 12872
2017-02-18 21:50:18 +00:00
Henrik Levkowetz c344a18bdf Fixed an issue with the test-crawler which could cause false positives for urls containing apostrophe.
- Legacy-Id: 12851
2017-02-16 09:58:34 +00:00
Ole Laursen d2e85a3aa3 Apply draft parser patch from Henrik to improve the patch on trunk to
combine paragraphs across page splits - this makes the country part of
the parser find more countries
 - Legacy-Id: 12848
2017-02-15 19:10:59 +00:00
Ole Laursen b2ff10b0f2 Add support for extracting the country line from the author addresses
to the draft parser (incorporating patch from trunk), store the
extracted country instead of trying to turn it into an ISO country
code, add country and continent name models and add initial data for
those, add helper function for cleaning the countries, add author
country and continent charts, move the affiliation models to
stats/models.py, fix a bunch of bugs.
 - Legacy-Id: 12846
2017-02-15 18:43:57 +00:00
Ole Laursen 882579bab3 Don't check url reverses on the form admin:blahblah for the time being
- Legacy-Id: 12845
2017-02-15 18:39:35 +00:00
Henrik Levkowetz 44ad914fba Tweaked the company name extraction code in class Draft.
- Legacy-Id: 12842
2017-02-15 14:09:54 +00:00
Henrik Levkowetz bb5e5b97ba Another tweak to handle page break paragraph joins better in class Draft.
- Legacy-Id: 12840
2017-02-14 17:41:30 +00:00
Henrik Levkowetz 6158221fa8 Tweaked the author extraction to recognize short lines as paragraph ends, not only lines ending in '.' or ':'
- Legacy-Id: 12837
2017-02-14 14:23:15 +00:00
Henrik Levkowetz 7f607c51d2 Changed from old-style to new-style middleware.
- Legacy-Id: 12824
2017-02-12 17:07:48 +00:00
Henrik Levkowetz a1606e8f7d Added a 'htmlfilters' tag library containing 'removetags'
- Legacy-Id: 12823
2017-02-12 17:05:55 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's,
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
2017-02-11 14:43:01 +00:00
Henrik Levkowetz 19d585255a Django 1.10 does not permit the view argument to url() to be a string any more. Changed all cases view arguments to url() which were strings to instead reference the actual imported function.
- Legacy-Id: 12815
2017-02-10 14:49:16 +00:00
Henrik Levkowetz 49a899fe66 Added support for management of trac wikis for explicitly named groups, such as the IESG and IAOC. Tweaked the dummy-run handling of the create_group_wikis management command.
- Legacy-Id: 12789
2017-02-08 16:37:31 +00:00
Henrik Levkowetz de3976bec0 Merged in Django 1.9 upgrade work from ^/personal/henrik/6.41.1-django-1.9
- Legacy-Id: 12764
2017-01-31 15:13:01 +00:00
Henrik Levkowetz 55b430b525 Merged in [12748] from rcross@amsl.com:
Fixes #2172.  Add Requested Resources and People who must be there, to email notifications of session requests.
 - Legacy-Id: 12757
Note: SVN reference [12748] has been migrated to Git commit eeb35e997d
2017-01-30 23:22:45 +00:00
Henrik Levkowetz 40e8380751 Merged django 1.9 work forward to copy of trunk @6.41.0
- Legacy-Id: 12756
2017-01-30 23:13:02 +00:00
Ryan Cross eeb35e997d Fixes #2172. Add Requested Resources and People who must be there, to email notifications of session requests. Commit ready for merge.
- Legacy-Id: 12748
2017-01-27 23:32:52 +00:00
Ole Laursen 90051a1575 Add support for displaying and editing author affiliation and country
when submitting a draft, replace the Submission.authors line-based
text field with a JSON field
 - Legacy-Id: 12745
2017-01-27 16:10:31 +00:00
Ole Laursen 4426e3386f Add assertNoFormPostErrors for use instead of testing the status code
of form post responses to make it easier to see what goes wrong when
the form in a test suddently doesn't validate
 - Legacy-Id: 12744
2017-01-27 13:27:19 +00:00
Ole Laursen 9308948195 Add person, affiliation and country (through django-countries) to
DocumentAuthor, rename author field to email and make it optional (for
modeling old email-less submissions), remove the authors many to many
referencing field from Document as it is not really pointing the right
place.

Update the Secretariat tools to show affiliation and country.

Add migration for getting rid of the fake email addresses that the
migration script created some years ago (just set the author email
field to null).
 - Legacy-Id: 12739
2017-01-26 17:10:08 +00:00
Henrik Levkowetz 79c44d25ea Changed settings_sqlitetest so that local developer additions to context processors and middleware classes are avoided.
- Legacy-Id: 12723
2017-01-24 20:42:51 +00:00
Henrik Levkowetz 6f5c0fdd23 Added a trac-admin role name, for help in assigning trac-admin rights to trac instances. Extended the create_group_wikis management command to create and update wikis for groups of type 'team','ag' and 'dir', in addition to 'wg','rg' and 'area'; and also add people with role trac-admin in the group or in the secretariat to those given TRAC_ADMIN permissions in a Trac instance.
- Legacy-Id: 12721
2017-01-24 17:21:11 +00:00
Henrik Levkowetz a5d1aca525 Save database object before using it.
- Legacy-Id: 12716
2017-01-23 19:42:03 +00:00
Henrik Levkowetz 613f0c8233 Pyflakes fixes.
- Legacy-Id: 12714
2017-01-23 18:35:58 +00:00
Henrik Levkowetz bdbddc8efd Rewrote a test to provide on-disk files instead of StringIO files to argparse (it seems optparse could handle this, but argparse can't).
- Legacy-Id: 12713
2017-01-23 18:23:05 +00:00
Henrik Levkowetz 450c39af23 Changed the failure leeway of the code coverage test percentage from 0.005% back to 0.02%.
- Legacy-Id: 12707
2017-01-19 20:01:19 +00:00
Ole Laursen aebfe44f9e Add simple detection of formal languages used in draft, partially
based on the code in getauthors by Jari Arkko
 - Legacy-Id: 12657
2017-01-16 16:08:56 +00:00
Ole Laursen 34a9f36534 Add helper for getting word count from draft
- Legacy-Id: 12655
2017-01-16 11:35:48 +00:00
Henrik Levkowetz 6eec4c2648 Converted all management commands which set up additional command-line switches to use the argparse approach instead of the deprecated optparse approach.
- Legacy-Id: 12645
2017-01-11 18:42:38 +00:00
Henrik Levkowetz 7b95411f58 The context_instance parameter to render_to_response() and render_to_string() is now deprecated. Fixed this, and generally changed the idiom render_to_response('template.html', {}, RequestContext(request)) to the newer and simpler render(request, 'template.html', {}). About 200 instances.
- Legacy-Id: 12637
2017-01-09 21:26:30 +00:00
Henrik Levkowetz 9c095365dd Commented out debug output from ietf.utils.urls.url(). Tweaked the url() handling of django views.
- Legacy-Id: 12634
2017-01-09 16:32:38 +00:00
Henrik Levkowetz eb5aa9a691 Django 1.9: Refined the autonaming url() replacement.
- Legacy-Id: 12622
2016-12-22 18:08:21 +00:00
Henrik Levkowetz d5460b8f7f Django 1.9: Merged work forward to copy of latest release.
- Legacy-Id: 12621
2016-12-22 17:30:50 +00:00
Henrik Levkowetz bfc44dea82 Django 1.9: Added an alternative implementation of urls() which derives an url pattern name from the callable, in order to maintain DRY for url patterns.
- Legacy-Id: 12617
2016-12-22 17:20:29 +00:00
Henrik Levkowetz 3944ab95cc Django 1.9: Supplied a required argument to TemplateDoesNotExist()
- Legacy-Id: 12616
2016-12-22 17:14:51 +00:00
Henrik Levkowetz 471bbde4d5 Django 1.9: Adjusted import path
- Legacy-Id: 12615
2016-12-22 17:13:26 +00:00
Henrik Levkowetz ec0d6a7e4f Merged in [12593] from rjsparks@nostrum.com:
Send mail to team secretaries when a review is explicitly requested. Change the From and Subject for assignment emails to reviewers to make it clearer what the review is for and who assigned it. Fixes #2053 and #2114.
 - Legacy-Id: 12602
Note: SVN reference [12593] has been migrated to Git commit 10f4892eae
2016-12-21 18:01:00 +00:00
Henrik Levkowetz 7e6baf15b7 Merged in [12588] from rjsparks@nostrum.com:
Change how we display review text to follow the tecnique used with other large blocks of pasted or imported text (shepherds writeups for instance). Fixes #2104.
 - Legacy-Id: 12600
Note: SVN reference [12588] has been migrated to Git commit 7c182375af
2016-12-21 17:26:03 +00:00
Henrik Levkowetz 8e9858379b Fixed some pyflakes and form initialization issues with the upgrade to DurationField.
- Legacy-Id: 12599
2016-12-21 17:03:39 +00:00
Henrik Levkowetz 67b2fc1107 Extended the form fields used for duration to accept additional formats, including formats the secretariat are currently using, in order to avoid trouble with the TimedeltaField --> DurationField transition.
- Legacy-Id: 12598
2016-12-21 15:26:32 +00:00
Robert Sparks 10f4892eae Send mail to team secretaries when a review is explicitly requested. Change the From and Subject for assignment emails to reviewers to make it clearer what the review is for and who assigned it. Fixes #2053 and #2114. Commit ready for merge.
- Legacy-Id: 12593
2016-12-19 22:32:03 +00:00
Robert Sparks 7c182375af Change how we display review text to follow the tecnique used with other large blocks of pasted or imported text (shepherds writeups for instance). Fixes #2104. Commit ready for merge.
- Legacy-Id: 12588
2016-12-19 20:38:51 +00:00
Henrik Levkowetz 481a96c935 Changed the handling of skip tests and messages in order to show which tests will be skipped, and why, at the start of a test run.
- Legacy-Id: 12568
2016-12-17 21:49:53 +00:00
Henrik Levkowetz b14e981e66 Merged in [12520] from rjsparks@nostrum.com:
Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072.
 - Legacy-Id: 12544
Note: SVN reference [12520] has been migrated to Git commit b24bdb5bc3
2016-12-15 20:55:40 +00:00
Henrik Levkowetz 65481b5df7 Moved warnings settings from manage.py and test_runner.py to one single place, settings.py. Decreased the verbosity level when invoking 'loaddata' from the test runner.
- Legacy-Id: 12535
2016-12-15 13:25:20 +00:00
Henrik Levkowetz 8e56935cfd Undid commit 12527, which contained much too much.
- Legacy-Id: 12528
2016-12-15 10:38:54 +00:00
Henrik Levkowetz e3c6e0ac6b Changed the state shown in all_id.txt for drafts which have entered IESG processing, but then been replaced, to show as 'Replaced' instead of 'In IESG Processing'. This is consistent with how they are shown in all_id2.txt.
- Legacy-Id: 12527
2016-12-15 10:36:15 +00:00
Robert Sparks b24bdb5bc3 Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072. Commit ready for merge.
- Legacy-Id: 12520
2016-12-14 23:26:32 +00:00
Henrik Levkowetz 03d90163a5 Merged django-1.8 work forward to copy of 6.39.1
- Legacy-Id: 12504
2016-12-10 19:32:46 +00:00
Henrik Levkowetz 2978798f39 Made serialization work for RegexStringValidator
- Legacy-Id: 12492
2016-12-09 12:40:21 +00:00
Henrik Levkowetz 57eb5844e5 Merged in [12489] from rjsparks@nostrum.com:
Save a new reviewrequest for each team requested in the request form. Fixes #2094.
 - Legacy-Id: 12491
Note: SVN reference [12489] has been migrated to Git commit 4fff1ab101e4f7cd27dc8ded889e09905866076f
2016-12-09 12:01:48 +00:00
Henrik Levkowetz 2c27d5c611 Moved optional text wrapping before html escaping in markup_unicode(), used by get_unicode_document_content(). Fixes a problem with lines being wrapped when they should not be.
- Legacy-Id: 12480
2016-12-08 16:27:05 +00:00
Henrik Levkowetz 217b31f109 Made the RegexStringValidator deconstructible so we can generate migrations.
- Legacy-Id: 12476
2016-12-07 19:28:01 +00:00
Henrik Levkowetz 6304bfda69 Fixed template_coverage_collection initialisation. Tweaked a message. Updated coverage numbers.
- Legacy-Id: 12471
2016-12-07 11:33:33 +00:00
Henrik Levkowetz db7e554c5e Changed to using TestCase from ietf.utils, and turned off coverage checking when loading templates in TemplateChecksTestCase.
- Legacy-Id: 12470
2016-12-07 11:31:31 +00:00
Henrik Levkowetz b628a0844b Changed to using TestCase from ietf.utils in some places, for consistent test-suite failure output.
- Legacy-Id: 12467
2016-12-07 11:03:32 +00:00
Henrik Levkowetz 7dfbe51913 Don't count the template loading done in TemplateChecksTestCase towards template coverage numbers.
- Legacy-Id: 12464
2016-12-06 15:55:39 +00:00
Henrik Levkowetz e4ce339235 Merged in [12461] from rjsparks@nostrum.com:
Added migration to fetch text from reviews in the mail archives and populate the review documents. Fixes #2064.  Will patch into production.
 - Legacy-Id: 12463
Note: SVN reference [12461] has been migrated to Git commit 63a9599bafdcacf49f1bb374b2156d8473da93d1
2016-12-05 21:03:49 +00:00
Henrik Levkowetz 8f6e51839f Fixed some additional places to use the new settings.TEMPLATES structure.
- Legacy-Id: 12459
2016-12-05 19:04:27 +00:00
Henrik Levkowetz 14776bae70 Merged django18 work forward to r12447
- Legacy-Id: 12455
2016-12-05 15:03:40 +00:00
Henrik Levkowetz 0bb7854591 Merged django18 work forward to 6.39
- Legacy-Id: 12449
2016-12-05 14:01:25 +00:00
Henrik Levkowetz b897519fff Changed the test runner to use the verbosity set on the command line when loading fixtures.
- Legacy-Id: 12446
2016-12-05 12:56:53 +00:00
Henrik Levkowetz 5959b3a46a Added a validator for the reviewer settings' Filter Regexp field, to make sure that we don't later hit exceptions when trying to compile and use the regexp entered.
- Legacy-Id: 12439
2016-12-01 21:30:39 +00:00
Henrik Levkowetz b914f46313 Merged in ^/branch/iola/review-tracker-r12128@12397, bringing in the review tool functionality described in RFC7735. This adds the ability to set up review management pages for review teams such as genart, secdir, opsdir, etc.; letting the review team secretaries manage requested and completed reviews; letting the reviewers keep track of and document their reviews, and more. See the RFC for full specification, and the branch commit log for a full commit history.
- Legacy-Id: 12419
2016-11-29 14:54:19 +00:00
Henrik Levkowetz cec0f33817 Removed unused stuff.
- Legacy-Id: 12409
2016-11-28 21:20:28 +00:00
Henrik Levkowetz 53d68af9cd Adapted the utils template tests to the new template handling in Django 1.8.
- Legacy-Id: 12407
2016-11-28 21:05:17 +00:00
Henrik Levkowetz 554ec2d78c Removed an unused import
- Legacy-Id: 12406
2016-11-28 21:04:15 +00:00
Henrik Levkowetz 623ce0e1bd Merged in [12378] from rjsparks@nostrum.com:
Change the lines saying that a test has failed to make it easier to cut-paste to run the failed test again.
 - Legacy-Id: 12386
Note: SVN reference [12378] has been migrated to Git commit be51bc2e78
2016-11-18 10:45:40 +00:00
Robert Sparks be51bc2e78 Change the lines saying that a test has failed to make it easier to cut-paste to run the failed test again. Commit ready for merge.
- Legacy-Id: 12378
2016-11-17 02:52:45 +00:00
Henrik Levkowetz 964d34282f Added common patterns for template file names to ignore when testing template parsing and template test coverage.
- Legacy-Id: 12354
2016-11-16 02:14:32 +00:00
Henrik Levkowetz bb7d3b476f Tweaked the create_group_wiki management command and its test to show more information on failures.
- Legacy-Id: 12273
2016-11-07 17:13:09 +00:00
Henrik Levkowetz 888bd44a10 Stash the test results summary in ./.testresults instead of ./testresults, to avoid visual littering.
- Legacy-Id: 12272
2016-11-07 17:11:48 +00:00
Henrik Levkowetz 8d1aca19cc Rewrote the template coverage loader function to a proper template loader class.
- Legacy-Id: 12261
2016-11-03 20:51:06 +00:00
Henrik Levkowetz f7cf00b7ec Use get_or_create when creating test data, to avoid duplicate key warnings.
- Legacy-Id: 12259
2016-11-03 20:48:38 +00:00
Henrik Levkowetz 7b6407dfed Rewrote the test runner command-line switch declarations to use parser.add_argument() instead of the now unsupported option_list class attribute.
- Legacy-Id: 12251
2016-11-03 20:07:22 +00:00
Henrik Levkowetz 1d6853037e Updated the create_group_wikis management command with additional switches to make it easier to do test deployment of individual wikis.
- Legacy-Id: 12240
2016-10-30 18:10:41 +00:00
Henrik Levkowetz aec77c2385 Rewrote Document.href() to not do database queries when possible, as that has a big performance impact. Fixed a number of tests which relied on href() not doing the right thing for simplified test data. Added caching of canonical_name(), which can be quite heavy. Additional refactoring in a number of places, to use better test data and avoid test failures for good code :-)
- Legacy-Id: 12226
2016-10-28 16:59:42 +00:00
Henrik Levkowetz a1934d1713 Refined the sql debug view at the bottom of each page. Added a column showing the WHERE clause, as that is quite helpful in working out where a given query is coming from. Added an sql_debug template variable to make it easier to switch between the sql debug view and using the django-debug-toolbar.
- Legacy-Id: 12225
2016-10-28 16:46:05 +00:00
Henrik Levkowetz 681395ff8e Added a column to the debug view of sql queries which indicate whether a query originated in view code or template rendering.
- Legacy-Id: 12217
2016-10-26 18:49:58 +00:00
Henrik Levkowetz 27cd21155c Fixed a bug in testing for directory existence in the test setup.
- Legacy-Id: 12185
2016-10-19 22:38:28 +00:00
Henrik Levkowetz c22842a7c4 Made the wiki glue test skippable, in case the python subversion bindings are unavailable. Added creation of temporary directories also for the svn repositores created for wikis during testing.
- Legacy-Id: 12183
2016-10-19 21:14:20 +00:00
Henrik Levkowetz ba5c17ecfd Merged in a management command which provides glue code for creation and maintenance of Trac issue tracker and wiki installations per group. New groups of type wg, rg, and area will autmatically receive a Trac instance.
- Legacy-Id: 12182
2016-10-19 18:08:05 +00:00
Henrik Levkowetz f9b4955880 Tweaked the settings a bit, to avoid problems if changing TRAC_WIKI_DIR_ROOT after TRAC_WIKI_DIR_PATTERN has been set. Added a --wiki-dir-pattern switch to the management command.
- Legacy-Id: 12181
2016-10-19 14:56:57 +00:00
Henrik Levkowetz d400b88239 Added a test for the create_group_wikis management command.
- Legacy-Id: 12180
2016-10-19 14:53:58 +00:00
Henrik Levkowetz 41945d5525 Reverted unintended commit
- Legacy-Id: 12179
2016-10-19 14:47:17 +00:00
Henrik Levkowetz b2aae7dc35 Ignore the virtualenv-created directories under env/
- Legacy-Id: 12178
2016-10-19 14:44:44 +00:00
Henrik Levkowetz 887455c1d5 Make sure to not include draft name in the title extracted from draft text.
- Legacy-Id: 12176
2016-10-19 12:18:59 +00:00
Ole Laursen 4b987436c0 Fix a missing HttpResponseForbidden in review statistics, make the
review test code use a separate reviewer and reviewsecretary user to
avoid confounding things - also let these use Unicode in their names
to check for Unicode trouble.
 - Legacy-Id: 12175
2016-10-19 11:58:49 +00:00
Henrik Levkowetz f33eab6770 Install custom wiki pages before default pages, as we refuse to overwrite an existing page.
- Legacy-Id: 12174
2016-10-18 19:32:19 +00:00
Henrik Levkowetz 4cd3c484be New management command create_group_wikis. Work in progress.
- Legacy-Id: 12149
2016-10-14 15:03:13 +00:00
Ole Laursen 958ba5ba95 Make new branch from trunk and merge in review-tracker-r11921
- Legacy-Id: 12129
2016-10-13 16:38:47 +00:00
Henrik Levkowetz e7b76917ae Added a missing string format parmameter.
- Legacy-Id: 12116
2016-10-11 12:53:14 +00:00
Ole Laursen 227fdd7953 Add reviews to search results and IESG agenda. Support restricting
review types so that teams will only have those review types
listed and suggested that they are configured to have.

Fix a couple of things in the importer after having tested it on all
the databases. Set unavailable end date >= 2020 to indefinite.

Fix a couple of bugs.
 - Legacy-Id: 12095
2016-10-06 14:47:41 +00:00
Henrik Levkowetz a842e19452 Moved some code and tweaked settings to ignore sql debug functions when calculating code coverage.
- Legacy-Id: 12070
2016-09-30 21:30:04 +00:00
Henrik Levkowetz 3854c832a0 Change things so that the reorder_by setting has an effect on the test ordering. It didn't before, as CoverageTest was a subclass of the earlier entries in the reorder_by setting.
- Legacy-Id: 12039
2016-09-26 17:48:26 +00:00
Henrik Levkowetz 7f772641d4 Change the cache key construction to deal with query arguments containing spaces. Fixes 500 errors which would otherwise occur.
- Legacy-Id: 12035
2016-09-25 13:53:22 +00:00
Ole Laursen 99beb58291 Implement a round-robin rotation scheme for reviewers instead of
relying on when they last reviewed. In-order assignments automatically
move the rotation forwards while out-of-order assignments increment
the skip next of the assigned reviewer. Include rotation in open
review assignments email. Fix a couple of issues in the importer.
 - Legacy-Id: 12015
2016-09-21 16:52:50 +00:00
Ole Laursen 6da25e6bd9 Add personal review overview page for reviewers, add page for editing
reviewer availability settings, emailing the reviewer/secretary as
necessary, add tests for these pages. Fix a bunch of bugs.
 - Legacy-Id: 11998
2016-09-19 16:05:32 +00:00
Ole Laursen 0a8f3dbe02 Make it so that we don't have two persons with the same name in the
test data (prevents the duplicate warning email from being generated
on each test run)
 - Legacy-Id: 11997
2016-09-19 15:14:58 +00:00
Henrik Levkowetz ec684e1b4e Added a pylint rc-file, and fixed or silenced a number of issues found by pylint using the settings .pylintrc (which enable only error checking).
- Legacy-Id: 11941
2016-09-08 14:48:59 +00:00
Henrik Levkowetz 22e2b0ab88 Added a return value used by ietf.middleware.SMTPExceptionMiddleware.process_exception().
- Legacy-Id: 11940
2016-09-08 09:37:22 +00:00
Ole Laursen 74a02be9bf Create new branch from trunk@r11921, and merge review-tracker-r11360 into it
- Legacy-Id: 11923
2016-09-06 10:17:12 +00:00
Ole Laursen 1f7d4870a8 Refactor role handling in group editing slightly and add support for
editing reviewer roles in review teams. Also fix a couple of review
related bugs.
 - Legacy-Id: 11921
2016-09-05 12:33:54 +00:00
Ole Laursen 0958bcba4a Fill in the list_email attribute on the test review team
- Legacy-Id: 11845
2016-08-23 14:05:45 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method.
- Legacy-Id: 11840
2016-08-23 10:52:08 +00:00
Ole Laursen 426542771a Turn ReviewRequest.deadline into a date field with no time
- Legacy-Id: 11801
2016-08-17 15:10:39 +00:00
Henrik Levkowetz 523bfce86d Tweaked meetecho URLs, with new template string formatting filter.
- Legacy-Id: 11689
2016-07-16 17:15:21 +00:00
Henrik Levkowetz c7cecf66e9 Added a test case for group home.
- Legacy-Id: 11652
2016-07-13 19:20:13 +00:00
Henrik Levkowetz e3020686a8 Added a global declaration
- Legacy-Id: 11647
2016-07-13 16:00:41 +00:00
Henrik Levkowetz 0d160b9672 Guard get array value against array==None in log.getcaller()
- Legacy-Id: 11641
2016-07-13 12:56:02 +00:00
Henrik Levkowetz 402a099e4e Added a modified slugify function and template filter, which converts slashes to dashes instead of eliding them. This is necessary in order to be able to distinguish the slugified room names like 'Schinkel I/II' from 'Schinkel III'.
- Legacy-Id: 11589
2016-07-10 13:58:30 +00:00
Ole Laursen 19fff81a4f Rework closing a review request so the logic is reusable, add the more
specific close reasons to the database migration, add
ReviewRequest.requested_by so it's possible to notify the requester of
a review that it has been dropped.
 - Legacy-Id: 11520
2016-07-05 16:05:00 +00:00
Ole Laursen e2e66522c7 Add review request page for review teams and first draft of manage
review requests page.

Add importer for importing review data from the existing Perl tool
(WIP, gets most but not all of the interesting information out).

Fix various bugs.
 - Legacy-Id: 11508
2016-07-01 16:06:16 +00:00
Henrik Levkowetz f8804b4f2c Added 3 tests which checks 1) that all templates can be parsed and loaded, 2) that url template-tags refer to an urlconf callback that exists, and 3) that static template-tags resolve to urls that work. This was prompted by some 500 errors earlier which weren't caught by existing texts.
- Legacy-Id: 11483
2016-06-28 04:48:50 +00:00
Henrik Levkowetz a405449150 Cached the list of template paths in test_runner.py so we can call it multiple times cheaply.
- Legacy-Id: 11482
2016-06-28 04:44:25 +00:00
Henrik Levkowetz a36cf95572 Refactored the code to skip coverage testing a bit, and added skipping of template and url coverage.
- Legacy-Id: 11472
2016-06-24 15:39:59 +00:00
Henrik Levkowetz 64070fa3bf Added the ability to list absolute coverage data, not only show relative differences, to the coverage_changes management command.
- Legacy-Id: 11460
2016-06-22 22:05:50 +00:00
Henrik Levkowetz 6fa181763b Changed the code test coverage checking to never register coverage counts for tests that are sometimes skipped. Removed now unwanted skip settings from the releasetest settings.
- Legacy-Id: 11453
2016-06-21 20:39:28 +00:00
Henrik Levkowetz f083e88592 Made interim meeting test data use zero-padded sequence numbers.
- Legacy-Id: 11424
2016-06-20 18:52:09 +00:00
Henrik Levkowetz df84098980 Fixed a bug in find-history-replacement-active-at() where multiple history entries with the same timestamp would be unordered. This led to the wrong historic group info being shown in some cases (e.g., meeting/86/agenda would show dmmnew instead of dmm, leading to wrong agenda links)
- Legacy-Id: 11410
2016-06-19 12:52:36 +00:00
Henrik Levkowetz d298785fda Merged in ^/branch/amsl/interim@11230, which provides interim meeting management support. Also fixes issues #1961, #1962 and #1964.
- Legacy-Id: 11402
2016-06-17 14:16:27 +00:00
Ole Laursen 7b95f46ecb Merge review-tracker branch with new branch from trunk
- Legacy-Id: 11364
2016-06-14 13:57:20 +00:00
Ole Laursen 7cbe36fb62 Implement completing a review with tests. One can currently
enter/upload content or retrieve it from an IETF mailarch archive
through integrated searching support. Support for partial completion.
 - Legacy-Id: 11360
2016-06-14 11:28:53 +00:00
Ole Laursen b790781de9 Add return statements to remaining email sending function so it's
possibly to get the message back. We need the message and its
Message-ID in the review tracking code, to be able to link to it in
the mail archive.
 - Legacy-Id: 11359
2016-06-14 09:54:37 +00:00
Henrik Levkowetz 9eacdbf2c6 Merged in ^/personal/henrik/6.21.1-biophoto@11313, with work from rjsparks@nostrum.com and henrik@levkowetz.com which provides support for profile biography and photo.
- Legacy-Id: 11314
2016-06-10 19:36:47 +00:00
Henrik Levkowetz 14a4ea177c Merged in ^/personal/rjs/6.21.1.dev0@11257
- Legacy-Id: 11259
2016-06-01 16:37:01 +00:00
Henrik Levkowetz a32b121efb Changed some instances of error strings from ascii to unicode in order to avoid problems with unicode error messages, such as the file size indications generated by django.template.defaultfilters.filesizeformat().
- Legacy-Id: 11220
2016-05-22 14:40:37 +00:00
Ole Laursen 44e135345c Add a page for displaying a review request, add support for
withdrawing requests, add tests for these two pages
 - Legacy-Id: 11217
2016-05-20 14:14:31 +00:00
Ole Laursen 54c4c5efc5 Make the test data new revision event a proper NewRevisionDocEvent so
it's consistent with what the code expects
 - Legacy-Id: 11205
2016-05-19 15:33:02 +00:00
Henrik Levkowetz 02773059f2 Better usage help for the coverage_changes management command.
- Legacy-Id: 11193
2016-05-15 15:01:50 +00:00
Ole Laursen b599dca51d Override the django-bootstrap3 default help-text-and-errors rendering
to separate the unrelated concepts
 - Legacy-Id: 11177
2016-05-10 16:44:45 +00:00
Ryan Cross facead5d95 Add inteirm meeting request disapprove and cancel capabilities
- Legacy-Id: 11135
2016-04-26 23:05:53 +00:00
Ryan Cross be6e536769 add pending and detail views and tests.
- Legacy-Id: 11125
2016-04-20 23:57:52 +00:00
Henrik Levkowetz d96f0fe964 Added a django management command to populate yang model libraries from RFCs and drafts.
- Legacy-Id: 11110
2016-04-08 17:18:54 +00:00
Henrik Levkowetz adb8625635 Introduced caching for the api resources.
- Legacy-Id: 10929
2016-03-15 23:12:04 +00:00
Henrik Levkowetz 846a02c3f9 Fixed pyflakes complaints introduced with pyflakes 1.1.0
- Legacy-Id: 10896
2016-03-04 21:24:26 +00:00
Henrik Levkowetz 76bb233b70 Refactored draft submission checks so that new checkers can be slotted in through a configuration in settings.py. Refactored the calling of idnits to use the new API, and added a pyang validation check.
- Legacy-Id: 10894
2016-03-04 20:08:29 +00:00
Henrik Levkowetz 15460b3cff Merged in [10718] from olau@iola.dk:
Set daemon = True on the thread in the SMTP test server running while
running tests. This fixes the annoying problem of the python process
staying alive after certain bugs in the test invocation or after a
plain Ctrl + c.
 - Legacy-Id: 10859
Note: SVN reference [10718] has been migrated to Git commit d67a96b4f0
2016-02-25 20:04:57 +00:00
Henrik Levkowetz b19aae788e Tweaked the output of the check_referential_integrity script to specify the through table name for m2m relationships.
- Legacy-Id: 10838
2016-02-12 13:50:57 +00:00
Henrik Levkowetz c9136286be Merged in [10809] from rjsparks@nostrum.com:
Further tweaks to rendering messages from the messaging framework.
 - Legacy-Id: 10817
Note: SVN reference [10809] has been migrated to Git commit 214b81991e
2016-02-10 17:54:59 +00:00
Henrik Levkowetz 7e1a9c288a Merged in [10804] from rjsparks@nostrum.com:
Some tweaks to handle rendering django messaging framework messages a little better.
 - Legacy-Id: 10813
Note: SVN reference [10804] has been migrated to Git commit c3e81c179b
2016-02-10 17:12:59 +00:00
Robert Sparks 214b81991e Further tweaks to rendering messages from the messaging framework. Commit ready for merge.
- Legacy-Id: 10809
2016-02-09 19:56:26 +00:00
Robert Sparks c3e81c179b Some tweaks to handle rendering django messaging framework messages a little better. Commit ready to merge.
- Legacy-Id: 10804
2016-02-08 22:09:50 +00:00
Henrik Levkowetz 2c2ac888d0 Updated the API tests to avoid deprecation warnings from a new version of Tastypie (0.13.1).
- Legacy-Id: 10796
2016-02-07 15:33:40 +00:00
Robert Sparks 757397330c Addresses issues uncovered by the test-crawler. Adds missing DocAlias records for several document types. Creates DocAlias objects when createing Document objects for those document types. Identifies places in code to touch when we are ready to expose the bluesheets and recording document types at /doc/. (The data rows and the content store need work before doing so).
- Legacy-Id: 10731
2016-01-25 19:40:35 +00:00
Henrik Levkowetz d3c5609cde Added some tests for the group role email utility functions used by the alias generation scripts. Tempted to start using factory boy, but will wait till Robert's work in the nomcom branch comes in.
- Legacy-Id: 10544
2015-12-04 23:10:01 +00:00
Henrik Levkowetz f5ca3a12bc Fixed a bug in the header/footer stripping done before abstract extraction when a draft is submitted.
- Legacy-Id: 10519
2015-11-24 20:01:31 +00:00
Henrik Levkowetz 09e3f4e96d Added a management command to check referential integrity, original code
conceived and written by rjsparks@nostrum.com, with some additions and
adaptation as a management command by henrik@levkowetz.com.

This integrity checker, when run on the IETF database in November 2015,
seemed to have a factor on the order of 100 better speed and lower memory
consumption than the code in
https://stackoverflow.com/questions/4734645/is-there-a-tool-to-check-database-integrity-in-django

No exact figure is available, as the latter had to be killed when it had
taken all available ram (~14G) on the development machine, and started to
cause heavy swapping.
 - Legacy-Id: 10508
2015-11-19 21:40:37 +00:00
Henrik Levkowetz cc84668862 Updated utils resources.py
- Legacy-Id: 10489
2015-11-14 23:47:02 +00:00
Henrik Levkowetz 1759f1b38e Updated utils/resources.py to include an endpoint for the new DumpInfo table.
- Legacy-Id: 10488
2015-11-14 23:41:25 +00:00
Henrik Levkowetz 29b30c6c3c Added a utility model to hold information on when a given database dump has been done.
- Legacy-Id: 10480
2015-11-14 22:59:14 +00:00
Henrik Levkowetz 2191ec3cbd Removed logging through ietf.utils.log.log when running tests -- should shave another 15% off the test suite run time.
- Legacy-Id: 10454
2015-11-08 14:26:41 +00:00
Henrik Levkowetz fdc7dea3df Merged in [10097] from olau@iola.dk, in order to speed up the test suite.
- Legacy-Id: 10453
Note: SVN reference [10097] has been migrated to Git commit 99a9cb5569
2015-11-08 14:24:19 +00:00
Henrik Levkowetz cf7d794b09 Modified the test data to use some AD and WG chair names that contain non-ascii characters, and fixed test issues found.
- Legacy-Id: 10418
2015-11-04 07:34:56 +00:00
Ole Laursen 86c3a430d1 Merge in ^/branch/iola/event-saving-refactor-r10076, fixing a few problems
- Legacy-Id: 10298
2015-10-27 10:37:06 +00:00
Henrik Levkowetz f1a08564d1 Added a new machine-readable list of IPR declarations per draft, which also searches through related documents. Extended make_test_data() with a replaced document for the test draft.
- Legacy-Id: 10272
2015-10-23 16:34:44 +00:00
Henrik Levkowetz bfa222b782 Added a switch to the 'test' command, to write short test results to file, changing the default which used to be to always write these.
- Legacy-Id: 10270
2015-10-22 20:37:03 +00:00
Henrik Levkowetz c17ea94b08 Updated the code to use version 4.0.1 of coverage.py for code coverage measurements. Moved the code which starts coverage measurement to settings_sqlitetest.py to avoid coverage measurements running when not doing tests. Did some additional coveage measurement refactoring.
- Legacy-Id: 10238
2015-10-18 20:01:57 +00:00
Henrik Levkowetz 90b97468a9 Changed to use a gzipped release coverage JSON file, instead of a plain JSON file, if the name given in settings.py ends in .gz. Reduces the current release coverage file size from ~1.6MB to ~200kB. This is a preparation for saving more information in the release coverage file than we currently do.
- Legacy-Id: 10235
2015-10-18 14:32:36 +00:00
Henrik Levkowetz 499a2180a3 Removed unused imports.
- Legacy-Id: 10231
2015-10-18 12:29:17 +00:00
Henrik Levkowetz cf4cbf76f3 Reverted mixed merge.
- Legacy-Id: 10230
2015-10-18 12:14:30 +00:00
Henrik Levkowetz 349b2b511a Removed unused imports.
- Legacy-Id: 10229
2015-10-18 12:12:50 +00:00
Henrik Levkowetz 4a80395a63 Removed support for perma_fixtures, using the blobal test fixtures instead.
- Legacy-Id: 10228
2015-10-18 11:49:15 +00:00
Ole Laursen e1f0917659 Summary: Add new document saving API, Document.save_with_history(events).
The new API requires at least one event and will automatically save a
snapshot of the document and related state. Document.save() will now
throw an exception if called directly, as the new API is intended to
ensure that documents are saved with both an appropriate snapsnot and
relevant history log, both of which are easily defeated by just
calling .save() directly.

To simplify things, the snapshot is generated after the changes to a
document have been made (in anticipation of coming changes), instead
of before as was usual.

While revising the existing code to work with this API, a couple of
missing events was discovered:

- In draft expiry, a "Document has expired" event was only generated
  in case an IESG process had started on the document - now it's
  always generated, as the document changes its state in any case

- Synchronization updates like title and abstract amendmends from the
  RFC Editor were silently (except for RFC publication) applied and
  not accompanied by a descriptive event - they now are

- do_replace in the Secretariat tools now adds an event

- Proceedings post_process in the Secretariat tools now adds an event

- do_withdraw in the Secretariat tools now adds an event

A migration is needed for snapshotting all documents, takes a while to
run. It turns out that a single document had a bad foreign key so the
migration fixes that too.
 - Legacy-Id: 10101
2015-09-28 14:01:03 +00:00
Ole Laursen 99a9cb5569 Summary: Switch to a much faster password hasher when running unit
tests, the default, more secure one took ~20% of the test time
 - Legacy-Id: 10097
2015-09-23 09:49:48 +00:00
Henrik Levkowetz fb66c1856f Merged in [9669] from olau@iola.dk:
Summary: Make the meeting agenda code use the historic info available
for groups. In the process, added some select_related/prefetch_related
code to cut the number of database queries in the agenda down from
4000-5000 to about 50. Rewritten agenda CSV code to use Python arrays
rather than a template for improved readability/reuse. Rewritten week
view to assemble its data in Python. Plus a few other minor cleanups,
e.g. lame_description is now gone.
Fixes #1088. Branch
 - Legacy-Id: 10005
Note: SVN reference [9669] has been migrated to Git commit acda84208d
2015-08-10 19:46:11 +00:00
Henrik Levkowetz 2fe8dcb4c2 Added a very simple html version of the json API, to make it easier to explore the api manually.
- Legacy-Id: 9991
2015-08-09 16:28:55 +00:00
Henrik Levkowetz 6de3974be7 Misc stuff.
- Legacy-Id: 9954
2015-08-01 15:07:49 +00:00
Henrik Levkowetz a23846c8be Changed the storage format for code coverage in *coverage.json, in order to be able to calculate code coverage percentages for a subset of tested files.
- Legacy-Id: 9953
2015-08-01 15:07:21 +00:00
Henrik Levkowetz 7a059c908a Cleaned up bower_storage a bit.
- Legacy-Id: 9952
2015-08-01 15:03:40 +00:00
Henrik Levkowetz 9cec8a0587 Added code to the test_runner to force SERVE_CDN_FILES_LOCALLY_IN_DEV_MODE to True during testing, to avoid triggering the system checks error which doesn't find the CDN symlink expected when serving static files via CDN.
- Legacy-Id: 9910
2015-07-28 11:02:00 +00:00
Henrik Levkowetz 6468a43840 Moved and renamed the file and class for the storage helper which lets us find static files managed by bower, to better reflect the function.
- Legacy-Id: 9909
2015-07-28 10:40:26 +00:00
Adam Roach 5cb7c82e39 Check that email is sent to chairs of both replaced and replacing document
- Legacy-Id: 9808
2015-07-18 16:07:26 +00:00
Ole Laursen acda84208d Summary: Make the meeting agenda code use the historic info available
for groups. In the process, added some select_related/prefetch_related
code to cut the number of database queries in the agenda down from
4000-5000 to about 50. Rewritten agenda CSV code to use Python arrays
rather than a template for improved readability/reuse. Rewritten week
view to assemble its data in Python. Plus a few other minor cleanups,
e.g. lame_description is now gone.

Fixes #1088. Branch ready for merge.
 - Legacy-Id: 9669
2015-06-17 13:37:16 +00:00
Robert Sparks 85cfe0ed8a Show leadership when and where mail was sent at the time it is sent. Commit ready for merge.
- Legacy-Id: 9608
2015-05-07 16:29:17 +00:00
Henrik Levkowetz e3799dca2e Fixed a bug in TestCase.assertValidHtml().
- Legacy-Id: 9563
2015-04-26 20:10:48 +00:00
Henrik Levkowetz 5a5289d1ad Added pip and setuptools, required in virtualenv, to requirements.txt in order to simplify buildbot testing of package installation and version testing.
- Legacy-Id: 9560
2015-04-26 19:12:16 +00:00
Henrik Levkowetz 09f3f51c77 Added support for an 'origin' template tag which will insert the name of the template file (within a html comment) into the page content when TEMPLATE_DEBUG is True; with the purpose of more easily being able to identify the templates from which page content comes.
- Legacy-Id: 9550
2015-04-24 20:38:36 +00:00
Henrik Levkowetz 6055215ab2 Removed local copy of html5lib, added html5lib to requirements.txt, and updated utils/html.py to work with htm5lib 0.999.
- Legacy-Id: 9547
2015-04-24 18:07:26 +00:00
Henrik Levkowetz 02cd366ff0 Merged in trunk@9440, containing the changes for version 5.13.1; and updated tests which look at HTML content to work with the facelift changes.
- Legacy-Id: 9446
2015-04-11 18:24:20 +00:00
Henrik Levkowetz 625347cd2f Merged trunk@9354 to facelift copy
- Legacy-Id: 9357
2015-04-02 06:51:34 +00:00
Robert Sparks a6c64d2b12 Remove sessonly, replacing the idea with a separate State. Add tests checking how materials show on agenda views. Commit ready for merge.
- Legacy-Id: 9351
2015-04-01 16:00:05 +00:00
Ryan Cross 34a16483fa Improve test coverage of secr.drafts. Commit ready for merge.
- Legacy-Id: 9307
2015-03-21 20:26:53 +00:00
buildbot 70396be450 Updated test
- Legacy-Id: 9241
2015-03-17 17:38:15 +00:00
buildbot cedb115038 Added exception capture and error message when the --release switch to coverage_changes specify a release for which there aren't any data. Also tweaked the diff output for code coverage changes.
- Legacy-Id: 9239
2015-03-17 16:15:04 +00:00
Henrik Levkowetz 0b971f635d Added test coverage data to the release pages if available for the release. Added saving of html pages for the code coverage to a directory in the static files area. If a code coverage report is available, a link to it will be shown on the release page of the current release. Renamed some setting variables related to test coverage to be more explicit and precise.
- Legacy-Id: 9201
2015-03-14 19:08:37 +00:00
Henrik Levkowetz 4b80218548 Merged in [9185] from rcross@amsl.com:
Add DocEvent and SubmissionEvent to merge-person-records.
 - Legacy-Id: 9197
Note: SVN reference [9185] has been migrated to Git commit cadf07fab3
2015-03-14 15:47:24 +00:00
Henrik Levkowetz d4f0ad4955 Fixed a pyflakes nit.
- Legacy-Id: 9189
2015-03-13 16:04:40 +00:00
Henrik Levkowetz f499ba8096 Started the code coverage measurements earlier, in order to make the apparent code coverage of model files less confusing.
- Legacy-Id: 9188
2015-03-13 16:02:31 +00:00
Henrik Levkowetz f15e515baf Added a fudge factor to the coverage test, in order to make it easier to do minor code changes.
- Legacy-Id: 9187
2015-03-13 15:56:13 +00:00
Henrik Levkowetz 1d28ec8f5b Made the test runner try multiple port numbers for the SMTP server, in order to handle the case where multiple test suites are in progress on the same host (which can happen when multiple buildbot slaves are running tests at the same time).
- Legacy-Id: 9186
2015-03-13 15:47:12 +00:00
Henrik Levkowetz d7f44d6e86 Tweaked test to match earlier coverage_changes output format tweak.
- Legacy-Id: 9168
2015-03-08 14:32:14 +00:00
Henrik Levkowetz e4c15de834 Tweaked the coverage_changes output slightly.
- Legacy-Id: 9165
2015-03-08 13:19:46 +00:00
Henrik Levkowetz 5ee64000c3 Changed the test runner to read json files as utf-8.
- Legacy-Id: 9163
2015-03-07 22:28:21 +00:00
Henrik Levkowetz b7095b573f Added a managment command to show the difference in coverage data between the latest release and the latest test run, and a test for the same.
- Legacy-Id: 9162
2015-03-07 22:27:02 +00:00
Henrik Levkowetz 381d37986c Python's pathlib is now available for both 2.x and 3.x, and is well established. Removed the ietf/utils/path.py fallback, and added pathlib to requirements.txt
- Legacy-Id: 9161
2015-03-07 17:17:50 +00:00
Henrik Levkowetz 0be1ad9a2d Fixed a bug in the template coverage expression. Tweaked the informative text prefacing app coverage figures.
- Legacy-Id: 9157
2015-03-06 23:22:54 +00:00
Henrik Levkowetz e94ac990fc Added per-app coverage measurements, to make the numbers shown when not running the full tests suite a bit more meaningful.
- Legacy-Id: 9156
2015-03-06 20:42:20 +00:00
Henrik Levkowetz 86997e1e95 Turned the api.py file into a module. Moved the makeresources management command to the api module. Added some api tests. Added crawling of api files to the test-crawler. Adjusted some resource files discovered by the test suite and test-crawler. Removed a bunch of empty model files.
- Legacy-Id: 9144
2015-03-03 20:23:36 +00:00
Henrik Levkowetz dba3db444c Added test code coverage measurements using coverage.py, integrated as a test in the test suite. This test compares the current code coverage of tests with that saved for the latest release. Also converted the URL and template coverage measurements into tests, comparing current with the latest release. The result of this is that the coverage tests will fail if new code is added without sufficient test coverage to at least match that of the latest release. Over time, this should encourage gradually improved test coverage as seen for both code, templates, and urls. Coverage data is also saved to file, and can be read by the 'coverage' shell command to produce html or text reports.
- Legacy-Id: 9103
2015-02-19 23:42:34 +00:00
Ole Laursen a225fd5069 Make new branch from trunk and merge facelift-r9007 into it, fixing a few merge conflicts
- Legacy-Id: 9072
2015-02-12 10:43:52 +00:00
Henrik Levkowetz f3b22aa300 Added django.setup() to some additional scripts, as required under Django 1.7.
- Legacy-Id: 9069
2015-02-11 06:52:07 +00:00
Henrik Levkowetz 7ecfac6308 Merged in personal/henrik/django-1.7@9020 which upgrades Django from 1.6.0 to 1.7.4 and applies the needed changes to the datatracker code to work with release 1.7.x.
- Legacy-Id: 9028
2015-02-08 21:16:44 +00:00
Henrik Levkowetz 028b7e315a Reverted to [9025] because commit [9026] failed (it was incomplete with a broken working dir).
- Legacy-Id: 9027
Note: SVN reference [9026] has been migrated to Git commit 4a3749a66b
2015-02-08 20:03:16 +00:00
Henrik Levkowetz 4a3749a66b Merged in personal/henrik/django-1.7@9020 which upgrades Django from 1.6.0 to 1.7.4 and applies the needed changes to the datatracker code to work with release 1.7.x.
- Legacy-Id: 9026
2015-02-08 19:16:46 +00:00
Ole Laursen eccd8d27c4 Make new branch from trunk (r9007) and merge facelift-r8876 into it, fixing a few merge conflicts
- Legacy-Id: 9014
2015-02-06 14:08:34 +00:00
Henrik Levkowetz 970059617e Added back a general setting (removed from the Django framework in 1.7) to avoid base64-encoding of UTF-8 email messages.
- Legacy-Id: 9012
2015-02-06 12:33:24 +00:00
Robert Sparks 4988d9378c Avoid an issue with python.email breaking To header field values that it has to encode in bad places. Fixes #1589. Commit ready for merge.
- Legacy-Id: 8961
2015-02-03 20:18:27 +00:00
Ole Laursen 8d5cd02922 Summary: Add a placeholder for datepicker fields
- Legacy-Id: 8916
2015-01-26 12:53:43 +00:00
Ole Laursen b3823d5768 Summary: Fix comment on insert_after_in_ordered_dict
- Legacy-Id: 8897
2015-01-22 17:42:52 +00:00
Ole Laursen d0999c8b5e Merge facelift-r8510 branch with trunk. The IPR tool still has some non-facelifted parts and ideosyncracies. Fix a couple of minor bugs (including infamous empty licensing choice) in the IPR code, and port the IPR views to use the render shortcut.
- Legacy-Id: 8896
2015-01-22 17:38:05 +00:00
Henrik Levkowetz 49d86d691b Merged in [8861] from rcross@amsl.com:
Changes to allow upload of bluesheets in materials upload page.  Primarily for use with Interim meetings.
 - Legacy-Id: 8891
Note: SVN reference [8861] has been migrated to Git commit 40efbf4f57
2015-01-21 20:32:18 +00:00
Henrik Levkowetz be1c255be1 Merged in [8854] from rjsparks@nostrum.com:
This is the second step towards ADs out of GroupInfo into Role.
The use of group.ad has been scrubbed from the code and templates.
  - Those places that set group.ad have been directly manipulate Role objects instead
  - Most places that read group.ad now use a new group.ad_role() that returns a Role object, simplifing some views.
Related to #1555 and #1557.
 - Legacy-Id: 8888
Note: SVN reference [8854] has been migrated to Git commit 65804be683
2015-01-21 19:56:57 +00:00
Henrik Levkowetz f15ba3346b Merged in [8846] from rjsparks@nostrum.com:
Added tests for document urls that provide a revision for all the document types the view code currently handles. Refactored parts of Document and DocHistory into DocumentInfo to get the tests to pass.  (but careful review is probably warranted).
 - Legacy-Id: 8880
Note: SVN reference [8846] has been migrated to Git commit ce5bda1835b32640d17136d09262f654fade94d4
2015-01-21 19:01:47 +00:00
Henrik Levkowetz 0db48f3db0 Merged in [8840] from rjsparks@nostrum.com:\n Automatically ensure Alias records exists when Person records are changed, relieving multiple code locations of that responsibility. Fixes bug #1550.
- Legacy-Id: 8873
Note: SVN reference [8840] has been migrated to Git commit b0b3a31b10bb35eb00d29f27d75d21c3cc4edc4e
2015-01-20 22:32:01 +00:00
Ryan Cross 40efbf4f57 Changes to allow upload of bluesheets in materials upload page. Primarily for use with Interim meetings. Commit ready for merge.
- Legacy-Id: 8861
2015-01-12 18:45:50 +00:00
Ryan Cross e686c5c7f5 Allow upload of bluesheets via materials upload interface
- Legacy-Id: 8857
2015-01-09 21:29:57 +00:00
Robert Sparks 65804be683 This is the second step towards ADs out of GroupInfo into Role.
The use of group.ad has been scrubbed from the code and templates.
  - Those places that set group.ad have been directly manipulate Role objects instead
  - Most places that read group.ad now use a new group.ad_role() that returns a Role object, simplifing some views.

Related to #1555 and #1557.

Commit ready for merge.
 - Legacy-Id: 8854
2015-01-09 18:52:06 +00:00
Henrik Levkowetz 5183042d58 Merged in branch/amsl/iprtool/5.7.4@8734 from rcross@amsl.com, providing new IPR models, refactored code, and improved list, search, and management interfaces.
- Legacy-Id: 8808
2014-12-21 19:26:33 +00:00
Henrik Levkowetz a9b91deead Added a file which was missed in the 5.8.0 release.
- Legacy-Id: 8759
2014-12-18 18:37:53 +00:00
Henrik Levkowetz 00e4818ceb Alternative DRY definition of the REST api top URL; this time in ietf/urls.py. This in itself is nicer, but I'm not so sure about the use of reverse() everywhere else, instead of referring to settings.
- Legacy-Id: 8752
2014-12-17 21:26:32 +00:00
Henrik Levkowetz 3cb39d462e Define the REST api top url in settings.py, rather than having literals in multiple places in the code.
- Legacy-Id: 8751
2014-12-17 21:06:05 +00:00
Henrik Levkowetz 9cb2f17f0f Added a refinement to the pyflakes management command, to make it clearer where exceptions while running pyflakes originate.
- Legacy-Id: 8747
2014-12-14 20:35:35 +00:00
Henrik Levkowetz ed2458feac Tests for the restapi.
- Legacy-Id: 8745
2014-12-14 20:34:03 +00:00
Henrik Levkowetz 147cc96a51 Added a management command to generate (and update) resource files for tastypie, in order to have to manually maintain the resource files needed by tastypie when models are added (model changes will have to be handled manually, or by removing the old class from the resources and auto-generate it again).
- Legacy-Id: 8743
2014-12-14 20:32:12 +00:00
Ole Laursen 1d51a43be4 Summary: Fix the yyyymmdd to strftime format converter to use a single
pass through the format so that it actually works correctly
 - Legacy-Id: 8732
2014-12-12 11:24:15 +00:00
Ole Laursen 8e4459ad59 Summary: Add helper for inserting a value after another value in an
OrderedDict (or Django's SortedDict)
 - Legacy-Id: 8719
2014-11-30 14:47:17 +00:00
Ole Laursen c7342d2f30 Summary: Add specialized DateField for triggering Bootstrap datepicker
- Legacy-Id: 8712
2014-11-25 16:43:50 +00:00
Henrik Levkowetz f2d3d4213a Reworked the generation of draft aliases and WG aliases, after trying out the output of the previous version for real. This code seems to work better, based on tests on ietfa.
- Legacy-Id: 8633
2014-11-11 01:09:30 +00:00
Robert Sparks 5ca9581072 Reworked smtp error warning and logging to not use hard-to-read context_managers. Fixes bug #1390. Commit ready to merge.
- Legacy-Id: 8584
2014-11-04 19:49:22 +00:00
Henrik Levkowetz 1bf4356002 Improved regex for the Dr.-Ing. honorific fix.
- Legacy-Id: 8509
2014-10-29 06:53:34 +00:00
Henrik Levkowetz 770f79e601 Added 'Dr.-Ing.' to the recognised honorifics in the author extraction code.
- Legacy-Id: 8508
2014-10-29 06:24:41 +00:00
Henrik Levkowetz 46cb5cbdca Did a number of changes to the author extraction method of class Draft in order to make it able to match up names with double-word family names on the first page (A. Foo Bar) with (familyname, given-name) ordering (Foo Bar Any) in the Authors' Addresses section. Regression tested against 200+ known good author extraction results. A number of stronger restrictions in regular expressions had to be introduced to avoid regression, which is probably all to the good.
- Legacy-Id: 8507
2014-10-28 15:45:47 +00:00
Henrik Levkowetz e3077c6e50 Fixed a bug in the new ISO-date code for draft metadata extraction.
- Legacy-Id: 8502
2014-10-27 17:01:16 +00:00
Henrik Levkowetz 4dddf14be0 Added support for ISO-format dates (or RFC 3339 dates, if you will) to the date parsing done for the submission tool. Also refined the regexes a bit to avoid false matches on for instance things like 'Juniper 2014'.
- Legacy-Id: 8501
2014-10-27 16:51:19 +00:00
Henrik Levkowetz 9d5a9c143e Reverted changes in ietf/utils/draft.py which should not have been part of [8499].
- Legacy-Id: 8500
Note: SVN reference [8499] has been migrated to Git commit a8ddac15e2
2014-10-27 16:35:50 +00:00
Henrik Levkowetz a8ddac15e2 Merged in [8498] from rjsparks@nostrum.com:\n Reworked logic flow for editing shepherds. Added message to inform the user when the shepherd is not changed. Fixes bug #1508.
- Legacy-Id: 8499
Note: SVN reference [8498] has been migrated to Git commit 055202dee4
2014-10-27 16:01:51 +00:00
Henrik Levkowetz 704589b4c7 Merged in branch/iola/people-cleanup @ [8471] from olau@iola.dk, which
enhances a number of pages in the datatracker where forms contain fields
  where a person should be chosen, such as for instance when choosing the
  shepherd of a document, so that they uniformly display choices which show
  both email address and name.

  Furthermore, changes have been made so as to make the email address
  uniformly act as reference to the person record.  

  Autocompletion is now consistently provided when looking for the email
  address or name of the person to choose.  

  This solves a number of issues where it has been difficult to choose the
  correct Person/Email combination, and where the correct email address to use
  for an association has been unavailable previously.
 - Legacy-Id: 8472
Note: SVN reference [8471] has been migrated to Git commit d62f2343e8
2014-10-25 21:05:50 +00:00
Henrik Levkowetz d4e5f070af Merged in [8293] from rjsparks@nostrum.com:\n XXX: Should what is now captured in the list of STATUSCHANGE_RELATIONS instead be captured in the database in name_docrelationshipname?
Refactored editing the notify field to remove redundant code.
Changed the default notification list to include .all for documents, and the wg list for wg documents.
Allowed recalculating the notification list for all document types.
Improved the calculated notification list value for charters, conflict-reviews, and status-changes.
Adds shepherds to the notification list when they are assigned to a document.
Adds the working group email list to the notification list when a document is adopted.
Fixes #1438
 - Legacy-Id: 8385
Note: SVN reference [8293] has been migrated to Git commit 640c5eb52ace8bb6d2c1b3ca6c14ef10ad0f324f
2014-10-12 17:32:11 +00:00
Henrik Levkowetz 4cc4f5080c Merged in [8254] from rjsparks@nostrum.com:\n Don't send mail to unknown-email-* addresses. Fixes bug #1471.
- Legacy-Id: 8365
Note: SVN reference [8254] has been migrated to Git commit f7f29a62588eac9b2aaf26cd0401a910fa48403f
2014-09-28 18:51:21 +00:00
Ole Laursen f7ac066059 Integrate Secretariat tools MultiEmailField with the one in
utils/fields.py, also fix a couple of issues in NomCom tool (spelling
bugs and avoid overwriting base_fields on forms with dynamic data)
 - Legacy-Id: 8276
2014-08-17 14:39:23 +00:00
Ole Laursen f291a466d7 Change Document.shepherd to point to the email address rather than the
person, add migration to fix the existing shepherds, fix wording and
max entries on change shepherd page to be more self-explanatory
 - Legacy-Id: 8268
2014-08-13 11:40:01 +00:00
Henrik Levkowetz a73163993a Rewrote the draft-alias and group-alias generation scripts to generate matching aliases and virtual files for postfix.
- Legacy-Id: 8055
2014-07-08 14:25:14 +00:00
Henrik Levkowetz 09f654b1f4 Merged in branch/iola/team-support from olau@iola.dk. This generalises and extends the group support for WGs and RGs so that also other groups, such as for instance the Edu Team, can have pages.
- Legacy-Id: 8013
2014-07-02 19:30:07 +00:00
Henrik Levkowetz 8aba7e97fc Provide a better message if pyflakes fails due to syntax errors in a python file.
- Legacy-Id: 8011
2014-07-01 21:12:03 +00:00
Henrik Levkowetz f00f589e66 Renamed a very specialized function from email_secretariat() to email_iesg_secretary_re_charter().
- Legacy-Id: 7923
2014-06-17 16:31:12 +00:00
Ole Laursen f9ee750afd Make it possible to adjust the name of new materials upon upload, also fix a couple of warnings from PyFlakes
- Legacy-Id: 7914
2014-06-13 12:30:42 +00:00
Robert Sparks 393422b36b Improves the robustness of the SMTP error handling utilities. Fixes bug #1409. Commit ready for merge.
- Legacy-Id: 7766
2014-05-22 01:28:33 +00:00
Robert Sparks bf4f3ad75f Made several changes to better handle non-ascii UTF-8 in email messages.
Used multipart mime when including the original message in an error message to the secretariat.
Modified the way IANA review email is parsed.
Added non-ascii UTF-8 tests to the IANA review email parser and to the SMTP Exception handling code.

Commit ready for merge.
 - Legacy-Id: 7673
2014-04-29 18:45:37 +00:00
Henrik Levkowetz 4b6ca22ff7 Merged in [7635] from rjsparks@nostrum.com:
Replumbed how SMTP Exceptions are handled, which involved refactoring several mail functions
 - Legacy-Id: 7637
Note: SVN reference [7635] has been migrated to Git commit 73b0831b57
2014-04-24 22:14:57 +00:00
Robert Sparks 73b0831b57 Replumbed how SMTP Exceptions are handled, which involved refactoring several mail functions
- Legacy-Id: 7635
2014-04-24 18:29:01 +00:00
Henrik Levkowetz fe5d53fc40 Merged in [7591] from rjsparks@nostrum.com:
Adds a real (if simple) SMTP server to the test framework and tests handling of exceptions and rejected addresses. Fixes ticket #1314.
 - Legacy-Id: 7613
Note: SVN reference [7591] has been migrated to Git commit 54919f01343995ab154d27dcfaf7a60b15dd5eee
2014-04-16 19:40:57 +00:00
Henrik Levkowetz 454c9d83cb Fixed support for verbosity and overwrite flags for the import_htpasswd command, which was lost in [7583].
- Legacy-Id: 7585
Note: SVN reference [7583] has been migrated to Git commit 4c0d52d9ed
2014-04-09 18:34:18 +00:00
Henrik Levkowetz 4c0d52d9ed Split out the actual htpasswd import functionality from the BaseCommand subclass, so we can call it from elsewhere.
- Legacy-Id: 7583
2014-04-09 18:28:42 +00:00
Henrik Levkowetz 156b0d4e3a Changed the code to use django's own authentication, instead of http basic auth. This will let people log out, and will also use stronger password hashing than basic auth. Added a login page, and logout links, and links from the logged in username (in the upper right corner) to the user's profile page.
- Legacy-Id: 7580
2014-04-07 18:56:44 +00:00
Henrik Levkowetz b02b0a96df All tests pass, except for some pyflakes tests which I believe are fixed in trunk.
- Legacy-Id: 7579
2014-04-06 20:04:36 +00:00
Henrik Levkowetz 3a3b386a0e A htpasswd import script, for the transition from basic http auth to Django native authentication.
- Legacy-Id: 7578
2014-04-06 17:20:31 +00:00
Henrik Levkowetz 8c42989d5d Pyflakes cleanup compliant with pyflakes 0.8.1, which seems to find things 0.8.0 didn't fin.
- Legacy-Id: 7558
2014-04-01 16:25:18 +00:00
Henrik Levkowetz af4c6e253c Exclude empty email addresses from the send list.
- Legacy-Id: 7552
2014-03-27 22:09:37 +00:00
Henrik Levkowetz 0643f3c542 Added a pyflakes test.
- Legacy-Id: 7505
2014-03-16 18:24:31 +00:00
Henrik Levkowetz b9cbb236dd Renamed flakes.py to pyflakes, and fixed the import setup so it won't try to import itself. Added verbosity control.
- Legacy-Id: 7502
2014-03-16 18:16:37 +00:00
Henrik Levkowetz 6606538453 Fixed mistaken outcomment.
- Legacy-Id: 7497
2014-03-16 07:48:59 +00:00
Henrik Levkowetz 49edc7404e Made ietf/utils pyflakes-clean.
- Legacy-Id: 7496
2014-03-16 07:26:03 +00:00
Henrik Levkowetz 02031a01b9 Cleaned out some (arbitrary) submodule name imports into ietf.utils, and made the corresponding import statements import the names directly from the correct submodules.
- Legacy-Id: 7495
2014-03-16 07:09:38 +00:00
Henrik Levkowetz b9c38d3c06 Merged pyflakes fixes forward to new copy of trunk.
- Legacy-Id: 7463
2014-03-15 16:27:05 +00:00
Henrik Levkowetz 5bef5d11ae Made doc/ pyflakes-clean.
- Legacy-Id: 7462
2014-03-15 16:09:47 +00:00
Henrik Levkowetz b91524fabc Merged [7368] from rjsparks@nostrum.com: Improves the detail in the messages sent when creating tickets about failed sent email.
Changes a locally defined exception name to look less like one already defined in smtplib.
This is related to ticket #1208.
 - Legacy-Id: 7382
Note: SVN reference [7368] has been migrated to Git commit 08f13239c9beb6dcb0be978e800b82c4104b61e7
2014-03-01 18:13:43 +00:00
Henrik Levkowetz 0eefa5760c Added a management command to run pyflakes, with the added feature of being able to mark individual lines with # pyflakes:ignore, which is needed in some cases.
- Legacy-Id: 7367
2014-02-25 20:22:20 +00:00
Henrik Levkowetz 3f55454724 Merged [7292] from rjsparks@nostrum.com: Allow 1-3 digit RFCs in status change documents.
Fixes bug #1321
 - Legacy-Id: 7295
Note: SVN reference [7292] has been migrated to Git commit 31808eccb2
2014-02-24 23:10:21 +00:00
Robert Sparks 31808eccb2 Allow 1-3 digit RFCs in status change documents.
Fixes bug #1321
Commit ready for merge
 - Legacy-Id: 7292
2014-02-24 15:43:32 +00:00
Henrik Levkowetz 9ea9ba1d66 Merged in [7138] from rjsparks@nostrum.com:
Reworked SMTP Exception handling, adding sending a ticket to the secretariat when there are errors handing messages off for delivery.
Added SMTP exception handling to send-scheduled-mail.
This is related to ticket #1208
 - Legacy-Id: 7256
Note: SVN reference [7138] has been migrated to Git commit 64727c1c33
2014-02-17 18:55:37 +00:00
Henrik Levkowetz 5d1bdde730 Added control by the --verbosity switch of the not loaded template test and not tested urls test, so they only will be run for verbosity greater than 1.
- Legacy-Id: 7244
2014-02-16 16:49:34 +00:00
Henrik Levkowetz 35cadc1763 Don't show deprecation warning during tests for verbosity < 2
- Legacy-Id: 7205
2014-02-04 21:35:19 +00:00
Ole Laursen e2554a6a0c It turns out that Django resetting the user if REMOTE_USER is not passed in is a problem on live to, so switch the whole code base to using the middleware to set REMOTE_USER from the logged in user if not passed in from the outside
- Legacy-Id: 7167
2014-01-24 14:30:00 +00:00
Ole Laursen 591e90a7a0 Put a proper command-line interface on the test crawler, spit out number of errors (if any), also add wrapper script for running the test-crawler and idindex generation scripts, in the future other (safe, non-mutating) scripts operating on real data can be added too
- Legacy-Id: 7107
2014-01-12 16:55:42 +00:00
Ole Laursen 86f2baea0a Move group feed from wgcharter (where it historically ended up) to wginfo, add test
- Legacy-Id: 7086
2014-01-09 16:24:54 +00:00
Ole Laursen 954c8fcedb Fix spelling mistake in patterns that are ignored in coverage check
- Legacy-Id: 7080
2014-01-08 17:41:40 +00:00
Ole Laursen 8dc19fd17e Improve the coverage checker, skip some trivial views (redirects and
flat templates)
 - Legacy-Id: 7078
2014-01-08 17:00:37 +00:00
Ole Laursen cb4d5b7c2b Simplify make_test_data a bit by using the create_person helper for the chair and WG delegate, regularize the naming of those
- Legacy-Id: 6990
2013-12-18 16:27:02 +00:00
Ole Laursen 72e36bde55 Don't output coverage data if there are test failures
- Legacy-Id: 6959
2013-12-17 10:08:12 +00:00
Ole Laursen beda4bafcd Fix bug with coverage testing
- Legacy-Id: 6937
2013-12-16 13:06:41 +00:00
Ole Laursen 7aa3737c3b Reenable RemoteUserMiddleware, it turns out the Secretariat tests are
using REMOTE_USER to auth instead of logging in - instead include a
little middleware class that adds the REMOTE_USER header during
testing.

Also fix problem with the empty test_label hack not working with
double-dotted Secretariat apps.
 - Legacy-Id: 6935
2013-12-16 12:59:27 +00:00
Ole Laursen 77e03c7355 Fix bugs in stream edit test
- Legacy-Id: 6933
2013-12-16 11:55:15 +00:00
Ole Laursen 7f25469c6b Drop the group/person/role global fixtures, the fixture loader in
Django 1.6 refuses to load them because they have dangling foreign
keys, and in rewriting them it turns out it is easier to do so in code
- so refactor the test data generation code to have a separate
function with the unchanging base data and call that from the global
fixture setup
 - Legacy-Id: 6917
2013-12-13 15:58:36 +00:00
Ole Laursen c9984e40fc Call base class fixture handling in perma_fixtures hack rather than
duplicating the (now incorrect) code from the base class
 - Legacy-Id: 6915
2013-12-13 15:39:34 +00:00
Ole Laursen b4706af925 Fix problem with tests and RemoteUserMiddleware - it interferes with
the tests, also fix bug in previous test runner refactor
 - Legacy-Id: 6914
2013-12-13 15:37:04 +00:00
Ole Laursen dec6862787 Make GLOBAL_TEST_FIXTURES support Python functions as fixtures
- Legacy-Id: 6906
2013-12-13 13:13:03 +00:00
Ole Laursen c470e57dae Port test runner to new Django interface
- Legacy-Id: 6903
2013-12-13 11:22:40 +00:00
Ole Laursen cfa0d47ca0 Port to new class-based generic redirect and simple template views, remove utils.lazy.reverse_lazy, it's now included in Django
- Legacy-Id: 6878
2013-12-11 16:36:09 +00:00
Ole Laursen 3053bef4cc Resurrect URL coverage making it work with all tests, and move it to the test runner together with the template coverage report
- Legacy-Id: 6844
2013-12-07 19:31:32 +00:00
Ole Laursen f6fa699992 Fix MultiEmailField to use validate_email for validation
- Legacy-Id: 6835
2013-12-07 12:54:24 +00:00
Ole Laursen 58afa08edf Remove import of unused FKAsOneToOne
- Legacy-Id: 6834
2013-12-07 12:49:32 +00:00
Ole Laursen 924d58f935 Remove model field utilities that were needed because of brokenness in the old schema
- Legacy-Id: 6833
2013-12-07 12:37:29 +00:00
Ole Laursen 3e709e3f24 Remove proxies
- Legacy-Id: 6826
2013-12-07 12:01:57 +00:00
Ole Laursen bb2d070679 Redo tests for IPR to cover all views, fix some bugs and add some
finishing touches
 - Legacy-Id: 6779
2013-12-03 18:33:07 +00:00
Ole Laursen 9457669310 Merge in changes from the old shimfree branch
- Legacy-Id: 6764
2013-11-27 12:55:50 +00:00
Ole Laursen 6174e72036 Rename unique key to random key as it is not really unique, add function for generating an access token from the key
- Legacy-Id: 6716
2013-11-15 16:07:10 +00:00
Ole Laursen e98abbf56d Change the port accepted for debug purposes to 2025 instead of 1025 to
not conflict with the port on the live server
 - Legacy-Id: 6715
2013-11-15 13:55:10 +00:00
Ole Laursen fd01ddd215 Make the mail code detect USING_DEBUG_EMAIL_SERVER which if set to
true and EMAIL_HOST and EMAIL_PORT is set to localhost:1025 will turn
on debugging which essentially makes it send emails; also added
instructions for starting the debugging SMTP server bundled with
Python

  python -m smtpd -n -c DebuggingServer localhost:1025

in a comment near the code
 - Legacy-Id: 6713
2013-11-15 12:57:31 +00:00
Ole Laursen 322e15e9a9 Add generate_unique_key utility for generating access tokens (like
abda31fee90aabe...)
 - Legacy-Id: 6712
2013-11-15 12:52:33 +00:00
Henrik Levkowetz 258ac770b3 Better handling of draft name extraction when there's no extension given.
- Legacy-Id: 6675
2013-11-06 22:18:51 +00:00
Henrik Levkowetz 7925223ef8 Merged [6622] from rjsparks@nostrum.com:
Refines Bill Fenner's regex based search through documents for references.
Populates RelatedDocument with relations for references for each type draft Document.
Replaces these reference relationships with updated copies on draft submission.

Note to deployer: There is a script to run in patches/fill_in_references.py that does the work of bringing the database up to date. It takes around 10 minutes to complete on a fast development laptop.

fixes bug #1173
 - Legacy-Id: 6633
Note: SVN reference [6622] has been migrated to Git commit a677a70df3
2013-11-02 23:04:28 +00:00
Robert Sparks a677a70df3 Refines Bill Fenner's regex based search through documents for references.
Populates RelatedDocument with relations for references for each type draft Document.
Replaces these reference relationships with updated copies on draft submission.

Note to deployer: There is a script to run in patches/fill_in_references.py that does the work of bringing the database up to date. It takes around 10 minutes to complete on a fast development laptop.

fixes bug #1173
 - Legacy-Id: 6622
2013-11-02 21:11:07 +00:00
Robert Sparks e309ff92b3 Don't insert references to self.
Move the data filler from a migration to a standalone script
 - Legacy-Id: 6620
2013-11-02 20:59:43 +00:00
Henrik Levkowetz 84eee2e83c Extract the proper directory to combine with the relative path of the urlist diff master, instead of using getcwd() .
- Legacy-Id: 6618
2013-11-02 20:23:47 +00:00
Robert Sparks b18249222b Refines Bill Fenner's regex based search through documents for references.
Populates RelatedDocument with relations for references for each type draft Document.
Replaces these reference relationships with updated copies on draft submission.
Note to deployer: This migration takes around 10 minutes to complete on a fast development laptop.
 - Legacy-Id: 6572
2013-10-30 20:51:11 +00:00
Henrik Levkowetz 2e6fa148f3 Tweaked the testurl diff output text.
- Legacy-Id: 6534
2013-10-29 22:22:54 +00:00
Henrik Levkowetz da8c38f55d Tweaked the display of testurl.list diff failures against known-good masters.
- Legacy-Id: 6494
2013-10-27 10:03:43 +00:00
Henrik Levkowetz d8e3e32ee7 Set TEMPLATE_STRING_TO_INVALID to '' during testing.
- Legacy-Id: 6493
2013-10-27 10:02:21 +00:00
Henrik Levkowetz e27e4dbb1f Changed the 'pipe' utility to work with commands taking input
on standard in, also when providing an emtpy string as input.
This is now different from providing 'None' as the input
argument, or omitting it.
 - Legacy-Id: 6485
2013-10-23 20:45:07 +00:00
Henrik Levkowetz 65d505edf3 Fixed some bugs in the method which saves a copy of a page which failed a
testurl diff test.
 - Legacy-Id: 6450
2013-10-15 17:37:30 +00:00
Henrik Levkowetz b951a187a7 If we have a diff with a known-good master in a testurl.list file, save the
failed file for inspection.
 - Legacy-Id: 6447
2013-10-14 18:38:13 +00:00
Henrik Levkowetz bc0e4e5614 Tweaked the makefixture command to not recurse on reverse relationships.
- Legacy-Id: 6446
2013-10-14 18:36:20 +00:00
Henrik Levkowetz e5c5d4cafa Tweaked the return handling for urltest diffs.
- Legacy-Id: 6444
2013-10-13 23:43:50 +00:00
Henrik Levkowetz ec05016585 Added a test assertion in the case of a failed urltest diff, to have the
test noticed as failed.
 - Legacy-Id: 6441
2013-10-13 21:12:23 +00:00
Henrik Levkowetz 90e95e6f15 Repurpose the 'master' column in testurl.list files to point to a local
known-good master file, for comparisons.
 - Legacy-Id: 6433
2013-10-13 17:46:19 +00:00
Ole Laursen f6ff2a8082 Delete all old WGAction stuff, it's superceded by the WG charter
support, clean up iesg/models.py a bit
 - Legacy-Id: 6411
2013-10-10 16:12:34 +00:00
Henrik Levkowetz 3020c5f7eb Imported a new version of the draft metadata extraction module, which
calculates page numbers more reliably, doesn't include duplicates in
the list of referenced drafts, and other minor tweaks.
 - Legacy-Id: 6362
2013-10-04 13:50:14 +00:00
Henrik Levkowetz a07f47a4a0 Added a new TestCase class, subclassing django.test.TestCase, in order to
be able to add fixtures once and for all for all tests, instead of loading
them again and again for each test, if running on a database that supports
transaction rollbacks.  In this case, fixtures specified in the perma_fixtures
class attribute will be loaded permanently, and not re-loaded.  Fixtures
specifice as before, in a fixtures class attribute, will be treated as
before.

The downside of this is that as fixtures are loaded and not unloaded, they
can conflict with each other.  The requirements on consistency becomes much
greater.  The effect of this has been to require quite a bit of changes to
the simplified creations of various objects in make_test_data() in cases
where identically named objects occur in fixtures.  Where completely
fictitious objects are created, no conflicts appear.

Also re-wrote parts of test_runner.py to permit global fixtures, loaded
before any tests are run and shared by all.
 - Legacy-Id: 6318
2013-09-30 20:22:24 +00:00
Henrik Levkowetz b335ef3b5c Imported a newer version of makefixture from github. It handles reverse relationships in a less hackish way than my hack.
- Legacy-Id: 6314
2013-09-30 14:24:14 +00:00
Ole Laursen 52febb2fc0 Fix spelling bug in global[e] test fixtures
- Legacy-Id: 6311
2013-09-30 12:17:15 +00:00
Henrik Levkowetz 4b568f8d22 Empty models.py, needed to make django look for management/commands/.
- Legacy-Id: 6310
2013-09-29 21:15:06 +00:00
Henrik Levkowetz 6e9e1930e2 Added a makefixture management command, from http://djangosnippets.org/snippets/918/, somewhat hacked.
- Legacy-Id: 6307
2013-09-29 20:50:51 +00:00
Ole Laursen f13837ef5f Add support for global test fixtures to avoid loading them for all
tests
 - Legacy-Id: 6304
2013-09-29 17:32:52 +00:00
Henrik Levkowetz 2a2389d17f Merged in branch/iola/shimfree@6083. This cleans up and moves relevant code from idrfc/ to doc/. There should now only be a bit of old wrapper code left in idrfc; that will go away when the remaining models which use it are cleaned up.
- Legacy-Id: 6117
2013-09-09 17:45:36 +00:00
Henrik Levkowetz ed020c8b8e Add Auto-Submitted and Precedence header fields to outgoing email messages.
- Legacy-Id: 6071
2013-08-17 15:33:56 +00:00
Ole Laursen de7ae60985 Move markup_txt.py from idrfc/ to utils/
- Legacy-Id: 6046
2013-08-13 14:33:22 +00:00
Henrik Levkowetz 6baea429aa Merged in the nomcom app from ejimenez@yaco.es and esanchez@yaco.es, and accompanying dbtemplate app and the (standard) docutils module. Added some tweaks to get all tests to pass and migrations to run.
- Legacy-Id: 5948
2013-08-06 10:09:29 +00:00
Henrik Levkowetz 8675711c27 Merged [5902],[5904] from markus.stenberg@iki.fi:
Added support and scripts for generation of wg- and draft-aliases.  Fixes issue #713.
 - Legacy-Id: 5937
Note: SVN reference [5902] has been migrated to Git commit e5b551f4ce

Note: SVN reference [5904] has been migrated to Git commit e68e51cc55
2013-08-01 12:44:49 +00:00
Henrik Levkowetz 4ed0337cae Made the code which uses the 'magic' module to determine file type and encoding work with both the old and new interface to python-magic.
- Legacy-Id: 5876
2013-07-25 14:45:01 +00:00
Henrik Levkowetz cbfe489ff5 Merged in more shim-layer removals from olau@iola.dk
(-r5465:HEAD from branch/iola/shimfree).  Copying relevant
commit messages here:

 - Deleted dead code in many places.

 - Renamed id-something to draft-something, make the "is
   this eligible for expiration" logic clearer

 - Added a name for IPR search URL

 - Revamped the ballot popup view

 - URL reversed the IPR search link instead of hardcoding it

 - Cleaned up search views and remove dead code, port them to the new DB
   schema, hack related views in iesg/ and wginfo/ to use the new search
   interfaces, avoid camelCase in search GET parameters (with
   backwards-compat fallback), add some simple search unit tests, remove
   caching from views_search.py index pages as they're now pretty fast to
   generate, rewrite ballot popup JS, regularize some CSS classes to use
   hyphen-notation rather than camelCase, move some of the search
   templates to doc/.

   idrfc/ now mostly contains some wrapper code still in use by other
   subdirs, some ported code not yet moved, and dead code.

 - Fixed output bug in test crawler and print referrer upon errors so it's
   easier to figure out where a link came from

 - Added /doc/in-last-call/ to crawler, report original page as referrer in
   a redirect chain rather than intermediate URL

 - Ported idindex to new schema, speed them up, add tests, refactor index
   page in views_search to share code with the text index file, get rid
   of some special-case idindex filters from ietf_filters, move
   "/drafts/" redirects to a file in /doc/

 - Ported /idtracker/status/ and /idtracker/status/last-call/ overview of
   drafts in IESG process to new schema in /doc/iesg/ and
   /doc/iesg/last-call/

 - Added redirects for all of /idtracker/*, removed all view code and other
   dead code from idtracker/

 - Removed the idtracker sitemap indexing drafts - in its current form,
   it adds nothing of value to the HTML-based /doc/all/ view, and it's
   pretty slow

 - Ported idtracker feeds to new schema, move them to doc/, cleaned up
   idtracker/ - only templatetags/ietf_filters and proxy code is left
 - Legacy-Id: 5836
2013-07-17 20:52:39 +00:00
Henrik Levkowetz e678659b56 Merged in a lot of shim-layer removals from olau@iola.dk
(-r5194:5465 from branch/iola/shimfree).  Copying relevant
commit messages here:

  - Removed .related many to many relationship, it's not really useful
    since we always have to restrict on the relationship type anyway,
    instead add two helpers for doing the necessary queries (in both
    directions)

  - Added migration for transforming the .desc on the new_revision events
    into something more akin to what is actually shown in the history page

  - Added migration for blanking IESG notes that just consist of "RFC
    XXXX", these have been superfluous for some time

  - Grant stream chairs access to changing the stream on a draft

  - Hacked the format_history_text filter to be less weird, using the same
    formatting for snippets and full text, also link up legacy ballot set
    events

  - Moved the decoraters + utilities to new ietfauth/utils.py file

  - Added simple helper to Email to identify invalid email addresses (from
    legacy author entries)

  - Used new new_revision .desc format for when drafts are submitted

  - Improved the looks of the button class by adding extra contrast and a
    linear gradient. Currently the gradient is only visible in fairly
    recent browsers.

  - Rewrote draft and RFC tabs in terms of the new schema, porting
    write-up and history tabs as well

  - Fixed two bugs in RFC Editor syncing: make sure documents we don't know
    beforehand get a "draft" type and make sure individually submitted
    drafts get the type="individ" group instead of NULL

  - Made the CSS-styled button feel a bit nicer to use by flattening the
    active state, also introduce some temporary styles until browsers
    catch up with the standard syntax

  - Added migrations for fixing 1) a dummy RFC entry, 2) three stand-alone
    RFCs that didn't get their doc.type set, 3) a big bunch of historic
    stand-alone RFCs that have doc.group=None - set these to the
    individual submission "none" group for the time being so the view code
    doesn't have to deal with a special case.

    In some cases this is wrong since there actually was a WG associated
    but unfortunately fixing them properly requires detective work
    (probably parsing the RFCs) and in at least some cases recreating
    historic WGs. In case someone ends up doing this, the documents to
    check can still be found with

    Document.objects.filter(name__startswith="rfc", group__type="individ")
    since there are almost no new RFCs that didn't went through the I-D
    process.

  - Merged the I-D and RFC views by showing I-D information on RFCs too.
    I-Ds that have been published as RFCs redirect to the RFC URL. Also
    support alias URLs so e.g. /doc/bcpXXXX redirects to /doc/rfcXXXX.

  - Fixed revision augmentation so events after RFC publication gets a "RFC"
    designation

  - Fixed a bug with tabs not using provided name but rather doc.name

  - Displaying draft-iesg state rather than doc.friendly_state as IESG state,
    also show a notice that the IESG state refers to post-RFC processing
    if it does, like the old separate RFC page did

  - Fixed the RFC number doc.note migration to catch combined "RFC XXX; BCP
    XXX" notes too, use the opportunity to remove inserted HTML tags from
    notes and rely on linebreaksbr filter instead (the other thing was a
    left-over from the Perl days), update the various uses of the note to
    reflect that

  - Refactored slightly to make views_doc.py independent of other idrfc code

  - Moveed idrfc/views_doc.py to doc/ with associated templates, replace the
    somewhat fragile simple URL tests for views_doc.py with ordinary unit
    tests. The new tests are still fairly basic but at least test more
    than the URL tests did.

  - Made sure RFC's (and BCP/STD/FYI) are stored as RFC123 instead of
    RFC0123 in the alias table with a new migration and a change to the
    RFC Editor sync, this in turn makes /doc/std1/ do the right thing

  - Now /doc/std1/ works, we can actually do a local link in
    urlize_ietf_docs rather than linking to the tools.ietf.org server

  - Fixed history text formatter: sanitize HTML before adding linebreaks and
    non-breaking spaces, this cuts the time to render a history page with
    long comments in half

  - Added a test crawler that walks through the crawlable part of the site,
    reporting errors and slow pages

  - Got rid of initial "No record" positions when showing old positions,
    it's just noise

  - Added a .select_related() to the document main tab to reduce the number
    of DB queries, unfortunately it seems it doesn't really help with
    Django 1.2.x due to a bug (Document inherits from DocumentInfo which
    makes things a bit more complicated)

  - Introduced a simple cache in doc.get_state so repeated reads don't
    cause a DB query

  - Cleaned up the search code in preparation for removal of the shim-layer;
    use a static button and don't send extraneous GET parameters

  - Removed dead code in several places
 - Legacy-Id: 5830
2013-07-15 20:55:24 +00:00
Henrik Levkowetz 3105101cc5 Changed test running and test data generation to work with database rollback
(for instance with InnoDB).

Added settings.DATABASE_TEST_OPTIONS which can be used to force for instance
InnoDB use during testing.

Using this has the potential of reducing the time it takes to run the test
suite substantially; a few test runs indicate a reduction in test run time by
50% on a run-of-the-mill linux server.
 - Legacy-Id: 5823
2013-07-15 07:21:34 +00:00
Robert Sparks a741642717 Added editing last call messages, requesting, issuing and tracking IETF LCs to status-change documents
Added a Cancel button to the form that allows editing the relations for status-change documents
Added instructions to the agenda section 3.3

This adds states to status-change- documents and has a migration that must be applied.

This fixes bug #1039
 - Legacy-Id: 5770
2013-06-01 21:01:45 +00:00
Henrik Levkowetz 5bee7ac538 Provide the necessary message information to the user confirmation messaging. Fixes issue #1049.
- Legacy-Id: 5767
2013-05-31 16:32:25 +00:00
Henrik Levkowetz bd0c07290a Merged in branch/iola/milestones, which provides datatracker support for management of WG milestones.
- Legacy-Id: 5739
2013-05-15 22:07:23 +00:00
Henrik Levkowetz 927efe2b7c Merged [5600] and [5602] from rjsparks@nostrum.com:
Changed the header to last call messages to IETF Announce and to IANA to make
replying to the announcement less likely to create an unnecessary ticket.
 - Legacy-Id: 5652
Note: SVN reference [5602] has been migrated to Git commit 19dcf10316
2013-04-15 22:24:22 +00:00
Ole Laursen 3d1eb07afe Port idindex to new schema, speed them up, add tests, refactor index
page in views_search to share code with the text index file, get rid
of some special-case idindex filters from ietf_filters, move
"/drafts/" redirects to a file in /doc/
 - Legacy-Id: 5634
2013-04-10 11:48:07 +00:00
Henrik Levkowetz 7a98fff79c Merged [5476] from rjsparks@nostrum.com:
* Added a document type for changing the publication status of other documents, and the UI for manipulating them.
* Added charters, conflict reviews, and status changes to the AD's \'My Documents\' page
* Improved the presentation of all document types on the Agenda, Future Telechats, Scribe and Moderator package pages
* Made the reverse name for document relationships explicit rather than deriving them from forward names
* Added a way to get to the underlying Document (when it exists) from an RfcWrapper
* Unified several common forms used by different document types
 - Legacy-Id: 5629
Note: SVN reference [5476] has been migrated to Git commit 10b4f7a4dc
2013-04-07 19:11:18 +00:00
Robert Sparks 19dcf10316 Changed the header to last call messages to IETF Announce and to IANA to make replying to the announcement less likely to create an unnecessary ticket
- Legacy-Id: 5602
2013-03-27 19:04:50 +00:00
Henrik Levkowetz cc60a1aa5d Restored fix to utils/mail.py.
- Legacy-Id: 5521
2013-03-09 20:06:11 +00:00
Henrik Levkowetz e1a7bf92ff Added logging for mail sending problems.
- Legacy-Id: 5489
2013-03-06 19:36:06 +00:00
Henrik Levkowetz 2f3476690f In order that document states (which may be used by old documents) should not need to be removed when state machines change and states go out of use, all document states have a 'used' field. The code which accesses the state fields have not been requiring that used=True for the states returned, which is an error. Fixed this by adding 'used=True' to all State.objects.get() and State.objects.filter() call where it's relevant.
- Legacy-Id: 5486
2013-03-05 23:24:41 +00:00
Robert Sparks 10b4f7a4dc * Added a document type for changing the publication status of other documents, and the UI for manipulating them.
* Added charters, conflict reviews, and status changes to the AD's "My Documents" page
* Improved the presentation of all document types on the Agenda, Future Telechats, Scribe and Moderator package pages
* Made the reverse name for document relationships explicit rather than deriving them from forward names
* Added a way to get to the underlying Document (when it exists) from an RfcWrapper
* Unified several common forms used by different document types
 - Legacy-Id: 5476
2013-03-01 15:47:51 +00:00
Henrik Levkowetz c4015a302b Added variations on the recognized date formats during submitted draft parsing, such that comma need not be followed by whitespace in the formats using comma as a separator between some of the fields. Added extraction of drafts referenced by a document, in addition to RFCs referenced.
- Legacy-Id: 5456
2013-02-24 20:17:22 +00:00
Robert Sparks 589ff698ee Merge forward complete
- Legacy-Id: 5328
2013-01-24 21:28:27 +00:00
Ole Laursen accf6d4470 Move idrfc/views_doc.py to doc/ with associated templates, replace the
somewhat fragile simple URL tests for views_doc.py with ordinary unit
tests. The new tests are still fairly basic but at least test more
than the URL tests did.
 - Legacy-Id: 5295
2013-01-18 13:17:00 +00:00
Ole Laursen 6e89f3b606 Merge changes from old milestones branch
- Legacy-Id: 5198
2013-01-15 16:45:19 +00:00
Henrik Levkowetz 1fbcd783f3 Merged branch/iola/statesync up to @5118 to trunk.
- Legacy-Id: 5147
2012-12-20 20:32:03 +00:00
Henrik Levkowetz 9d9e2851e0 Test the argument list, not the tuple of argument tuple.
- Legacy-Id: 5134
2012-12-16 18:30:25 +00:00
Henrik Levkowetz 97a7ab30db Added simple logging of test runs, to make it easier to be sure that tests has been run successfully on the latest code.
- Legacy-Id: 5131
2012-12-15 22:47:11 +00:00
Ole Laursen b19f6d8060 Merge in milestones branch
- Legacy-Id: 5091
2012-12-03 14:36:30 +00:00
Henrik Levkowetz 4946a3f694 Updated draft submission author extraction module to handle dash-separated double given names.
- Legacy-Id: 5088
2012-12-03 13:17:33 +00:00
Emilio Jiménez 65afd10d4a Refactor mange group views:
* Create a new models NomComGroup with public_key field. Default type is nomcom
 * News urls and views to separate members and chair forms
 * Add rolodex url when person not found.
 * Views access is only for secretariat and chair roles
See #904
 - Legacy-Id: 5069
2012-11-22 10:46:39 +00:00
Emilio Jiménez 230f6cfae7 view only accessible by the secretariat that allows to assign the email of the members and the chair of the NomCom
See #904
 - Legacy-Id: 5066
2012-11-20 00:40:57 +00:00
Henrik Levkowetz 0e67b2c758 Tweaked the handling of the syslog module not being available on windows.
- Legacy-Id: 5058
2012-11-07 21:41:02 +00:00
Ole Laursen 45cf853524 Dump redacted events in DeletedEvent table
- Legacy-Id: 5025
2012-11-07 14:59:17 +00:00
Ole Laursen daa5d49adb Fix RFC Editor group acronym to be rfceditor in test data
- Legacy-Id: 5024
2012-11-07 14:58:49 +00:00
Henrik Levkowetz cfcce2f03e Merged [5000] from rjsparks@nostrum.com:
Made it more obvious when an intended status or shepherding AD is not set
Removed an unused template
Show reset approval text immediately.

Fixes bug #900
 - Legacy-Id: 5015
Note: SVN reference [5000] has been migrated to Git commit 2470ad77dd
2012-11-07 13:01:34 +00:00
Henrik Levkowetz cfe466eb37 Merged [4991] from adam@nostrum.com:
Fixing time column wrapping problem that exhibits in (at least) Safari.
 - Legacy-Id: 5008
Note: SVN reference [4991] has been migrated to Git commit 5e384591fd
2012-11-06 15:23:17 +00:00
Henrik Levkowetz 8aa4922978 Remove dependency on syslog module -- it won't be available under Python 2.7 under Windows.
- Legacy-Id: 4974
2012-10-30 22:17:24 +00:00
Henrik Levkowetz 45585957ef Added support for reverse-order (i.e., Japanese, Chinese, and other) names with uppercase family name in the draft submission author extraction.
- Legacy-Id: 4949
2012-10-23 12:33:21 +00:00
Henrik Levkowetz d0214d3b25 Merged [4806] from rjsparks@nostrum.com:
Better handling for BoFs, particularly those that won't create WGs
 - Legacy-Id: 4939
2012-10-21 14:40:02 +00:00
Henrik Levkowetz c5e364dbfc Added a script to create NewRevisionDocEvent entries for charter files.
- Legacy-Id: 4859
2012-09-19 19:50:37 +00:00
Ole Laursen 6062e16c2d Email IANA and RFC Editor when a draft is pulled from the queue at the
Datatracker, add page for editing IANA states, add more info to the
/doc/draft-XXXXX/doc.json dump for the RFC Editor, add page for
editing consensus, add page for requesting publication at the RFC
Editor for alternate streams (this will email the RFC Editor and set
the draft in the appropriate state), make it possible for alternate
streams to change the intended RFC status of a draft in the stream,
refactor how IANA copies are handled slightly so it's less code, put
drafts automatically in IANA Review "Need Review" state upon last
call, fix a bug in ballot issuing, remove a bit of dead code
 - Legacy-Id: 4857
2012-09-17 16:15:45 +00:00
Ole Laursen 85d2cdddc2 Add POST interface for IANA/RFC Editor for triggering updates, add
discrepancies report for seeing differences between the
Datatracker/RFC Editor/IANA, add tests of IANA/RFC Editor integration,
add script for weekly discrepancies emails
 - Legacy-Id: 4851
2012-09-17 15:57:48 +00:00
Ole Laursen 9fdcbc38ab Add time zone helpers for converting between local IETF db time and UTC
- Legacy-Id: 4849
2012-09-17 15:51:33 +00:00
Henrik Levkowetz 7467fa48a5 Tweaked the author extraction code to handle company names in the author list on the first page, when the company names contain a comma, such as for instance 'Foo Bar, Inc'.
- Legacy-Id: 4781
2012-08-22 12:52:32 +00:00
Henrik Levkowetz eb28ac8177 Removed the ValueError exceptions introduced in the previous revision of the draft author extraction code. Fixes issue #858.
- Legacy-Id: 4753
2012-08-06 15:16:53 +00:00
Henrik Levkowetz 798f7697af Merged [4600] from rjsparks@nostrum.com:
* Adds a new document type for conflict reviews, with a ballot for the IESG 5742 response to a review request
* Integrated the new document type into the iESG agenda views (including RSS feeds)* Removed the Edit and Add buttons from the document main view.
* Replaced Add with actions appropriate for the document type, such as "Begin IESG Processing" or "Begin IETF Conflict Review", and made most data directly editable on the document's main page, depending on access permissions.
* Removed a manual editing step that the secretariat had to perform when sending conflict review messages. The view now composes the message correctly given the stream.
* Added a pencil icon motif to differentiate fields that are editable.
* Generalized several views and helper functions to use Document instead of (e.g.) IdWrapper
* Generalized reading documents from the repository
* Added a way to get from IdWrapper  to the underlying Document to facilitate migrating way from the Wrapper classes* Added many helpers to Document to assist with migrating off IdWrapper
* Minor fixes and other changes
  * Fixes to document main view to avoid (silent) template failures. 
  * Began removing some of the code that is no longer reachable post-migration  * Corrected the behavior of the undefer code and added test cases for it
  * Improved initial population of notification lists and added the ability to regenerate the initial list
* Made the test code that scans for template coverage more robust
* Deployment notes:
  * new setting: CONFLICT_REVIEW_PATH. The associated directory will need to be created

This branch fixes bugs #805, #744 and #812
 - Legacy-Id: 4652
Note: SVN reference [4600] has been migrated to Git commit 798e7a50e7
2012-07-28 16:29:28 +00:00
Henrik Levkowetz 0c49999fc9 Updated utils/draft.py and modified the submit app code accordingly.
New features (keep in mind that utils/draft.py can be run standalone
to do extraction of draft author data, too):

  * The handling of author info formatted in columns causes problems
    in the face of an author named for instance A. Author with the
    company 'Al Author and Associates', causing breakage of email
    addresses longer than 'Al Author and'.  Tweaked the recognition
    of column data to require multiple (not only one) space around
    'and'.

  * Added support for extraction of author affiliation.

  * Tweaked the meaning of -t, --timestamp and added --notimestamp; and
    made the default be to emit leading timestamps based ont the draft
    file time.

  * Added support for running author extraction on RFCs, by not bailing
    out on not finding a draft name when RFC information is available.

  * Added support for additional date formats and author name formats.

  * Improved creation date extraction -- previously, the first supported
    date format which was recognized on the first page of the draft would
    be used, rather than the first date in a supported format.  This could
    cause errors if the Status of Memo section or Abstract contained a
    date occurring at the start of a line.

  * Tweaked the honorific regex to make things work better for the case
    when the full name in the author's address section includes a first
    name which isn't part of the first-page abbreviated name.  Fixes
    problems with draft-chiappa-lisp-introduction and similar.

  * Added a special case for people who provide their email address as
    'foo&cisco.com' instead of 'foo@cisco.com'.  Bah.

  * Added an alternative, more human-readable key-value-pair attribute
    output mode with a '-a' switch.

  * Tweaded the first-name regex to capture cases where the first name
    is indicated with an alternate first letter: 'Y(J) Stein'.  Fixes
    problems with draft-anavi-tdmoip and similar.
 - Legacy-Id: 4612
2012-07-11 12:51:33 +00:00
Robert Sparks f3fd4db35c Merge forward complete - checkpointing before fixing popup position dialogs
- Legacy-Id: 4595
2012-07-04 19:35:46 +00:00
Ole Laursen 6050cbf76a Give test groups a list_email so we can email them
- Legacy-Id: 4592
2012-07-04 18:29:53 +00:00
Henrik Levkowetz 1bc2f7daa2 Tweak test setup message for site_id change.
- Legacy-Id: 4567
2012-07-03 13:42:36 +00:00
Henrik Levkowetz aa00b6e35d Remove old duplicate debug.py
- Legacy-Id: 4565
2012-07-03 11:31:30 +00:00
Henrik Levkowetz 350914da15 Minor cleanup of test_runner.py. Added guards against settings which can make tests inexplicably fail. Updated check to avoid running tests on production server.
- Legacy-Id: 4564
2012-07-03 11:31:11 +00:00
Ole Laursen b68bf9b0b8 Fix comment
- Legacy-Id: 4561
2012-07-02 18:10:41 +00:00
Ole Laursen 419f387bce Make find_history_active_at return the original object if it is
currently active, otherwise we can't see from the return value whether
a given time predates the history set. The downside is that the caller
may now need to check whether it got a history object or the same
object back.
 - Legacy-Id: 4560
2012-07-02 18:09:42 +00:00
Ole Laursen 488add5004 Add script and code (and tests) to send milestone reminders to ADs
(for reviews) and group chairs.
 - Legacy-Id: 4557
2012-06-30 16:46:31 +00:00
Ole Laursen 6c1e87b773 Move milestones branch out of the way to prepare for merge with trunk to get latest charter changes in
[[Split portion of a mixed commit.]]
 - Legacy-Id: 4514.1
2012-06-26 17:47:53 +00:00
Robert Sparks 51ab8123d9 merged in from 4.20-ise
- Legacy-Id: 4502
2012-06-22 20:25:17 +00:00
Henrik Levkowetz 839df60480 Merged in charter branch fixes from olau@iola.dk, from r4354 through r4381.
- Legacy-Id: 4382
2012-05-04 11:47:30 +00:00
Ole Laursen 3ec4dffd24 Check and sanitize text file upload (code is factored out in a new
helper so it can be reused elsewhere in the future).
 - Legacy-Id: 4380
2012-05-04 11:37:16 +00:00
Henrik Levkowetz bcd28cc45f Merged in fixes to the migration from olau@iola.dk. Merged in charter branch from olau@iola.dk. Added various fixes and correction of merge errors.
- Legacy-Id: 4353
2012-05-02 19:35:32 +00:00
Ole Laursen 8a8ddb0cc6 Add started_iesg_process event back in in test data as it's still
useful there
 - Legacy-Id: 4276
2012-04-16 13:57:18 +00:00
Ole Laursen e4a9d8c7aa Finish ballot support for charters (apart from non-generic ballot
deferral), remove a bunch of now obsolete charter code.
 - Legacy-Id: 4255
2012-04-04 18:09:03 +00:00
Ole Laursen 480cb04cd6 Save announcements generated by the system as Messages, adding an
extra relation to be able to associate a draft with the message
 - Legacy-Id: 3917
2012-02-08 21:05:28 +00:00
Ole Laursen 980d4e6444 Move new schema models from redesign/ to ietf/
- Legacy-Id: 3855
2012-01-24 17:17:24 +00:00
Ole Laursen f3685e7af1 Turn expiration into an explicit expires attribute on document, set
that on submission of new revision and resurrection
 - Legacy-Id: 3801
2012-01-12 12:03:45 +00:00
Ole Laursen 31aef86164 Merge charter branch with the UI hooks disabled for the time being
- Legacy-Id: 3800
2012-01-11 15:04:13 +00:00
Ole Laursen 9ae5f6a456 Make test runner multi-DB-aware
- Legacy-Id: 3786
2011-12-23 13:15:27 +00:00
Ole Laursen de0fc12ce8 Port telechat dates
- Legacy-Id: 3774
2011-12-20 13:12:12 +00:00
Ole Laursen 498dc38507 Port to Django 1.2, replacing built-in patched Django with Django 1.2.7 (with patches applied on top) and replacing South with South 0.7.3
- Legacy-Id: 3773
2011-12-15 14:13:54 +00:00
Ole Laursen 79ea179ff9 Comment out verbose mail server debug output for the time being
- Legacy-Id: 3719
2011-11-28 17:52:27 +00:00
Ole Laursen 03d1877802 Interpret settings.EMAIL_COPY_TO="" as "don't send a copy"
- Legacy-Id: 3717
2011-11-28 17:21:29 +00:00
Ole Laursen ea4e79cacb Fix empty_outbox to actually work as intended when outbox is imported elsewhere
- Legacy-Id: 3702
2011-11-24 16:36:19 +00:00
Ole Laursen 367d6b2116 Port recently merged stream delegate management in ietfworkflows to new schema
- Legacy-Id: 3687
2011-11-22 21:15:49 +00:00
Ole Laursen 5a4c23ea92 Merge with trunk
- Legacy-Id: 3676
2011-11-21 16:41:21 +00:00
Ole Laursen 5d291f222c Remove .state and .*_state on Document in favour of generic states
mapping, port the codebase to use these states
 - Legacy-Id: 3660
2011-11-16 18:18:06 +00:00
Ole Laursen ce74be89ef Use the test mode in the mail code when running automated tests instead of
reinventing the wheel in test_runner
 - Legacy-Id: 3620
2011-11-15 11:24:33 +00:00
Ole Laursen ea7f45d56e Port ietfworkflows and wgchairs to new schema, fix missing state
setting in I-D submission, add tests
 - Legacy-Id: 3617
2011-11-14 19:40:20 +00:00
Ole Laursen f7eefe8ee2 Finally get the mail system during automated test to send the real
message (i.e. pretend to do) instead of sending a copy, should make it
a bit easier to write tests
 - Legacy-Id: 3595
2011-11-08 11:48:57 +00:00
Henrik Levkowetz 5351319a9d Change the signatures of ietf.utils.mail functions using toUser to reflect that it's used as a boolean, not something else.
- Legacy-Id: 3522
2011-10-26 13:30:20 +00:00
Henrik Levkowetz f46f893de9 Don't try to output draft metadata (in standalone mode) for a file if the extraction failed.
- Legacy-Id: 3505
2011-10-25 13:58:55 +00:00
Henrik Levkowetz 43f1d5da93 Improved extraction of draft title during submission. Fixed a problem where the scan for an author's email address was prematurely terminated because another author's affiliation also was part of this author's address information.
- Legacy-Id: 3445
2011-10-13 14:36:26 +00:00
Ole Laursen 6f10d2f3f7 Port submit to new schema, adding a set of tests and fixing some bugs
- Legacy-Id: 3436
2011-09-21 19:29:50 +00:00
Ole Laursen 022bc51e23 Move unaccent helpers
- Legacy-Id: 3426
2011-09-16 11:32:33 +00:00
Ole Laursen 5c5d534104 Add person foreign key on Role to link the role and person directly instead of through Email, this will allow us to use non-personal emails on roles
- Legacy-Id: 3418
2011-09-14 14:01:17 +00:00
Henrik Levkowetz 7f8eea3b9d * Speeded up things and increased reliability by looking for a
recognizable author's address section, and not searching for
    author names earlier in the document if found.  Fixes a known
    bad case where the author name occurred in the middle of a draft.

  * Added handling for the case where an author name is followed by 
    parentheses which are not closed on the same line.

  * Some refactoring.
 - Legacy-Id: 3417
2011-09-14 12:31:48 +00:00
Ole Laursen 7f5fd62a3d Add simple test for ID submission, needs more extensive checking
- Legacy-Id: 3416
2011-09-05 17:14:47 +00:00
Ole Laursen 0769a07756 Port add delegate, add test, fix bug with first form in delegate
adding not checking whether found persons have a login
 - Legacy-Id: 3393
2011-08-29 14:08:27 +00:00
Ole Laursen 646e8b8615 Port WG Delegate deletion with new test
- Legacy-Id: 3383
2011-08-26 17:37:44 +00:00
Ole Laursen f11b558d00 Refactor slightly to get rid of clunky "ex-ad" role, any future uses
should use GroupHistory/RoleHistory instead
 - Legacy-Id: 3370
2011-08-24 20:49:30 +00:00
Ole Laursen b9e1753ef6 Port and proxy liaison views to new schema and add a bunch of tests
- Legacy-Id: 3350
2011-08-22 23:15:35 +00:00
Martin Qvist b73c5358e7 Added corrections and tests as discussed with Ole.
- Legacy-Id: 3349
2011-08-22 19:54:25 +00:00
Ole Laursen 2bf8e0a45d Move fixture generation for names to name app, add liaison edit test,
fix some liaison bugs
 - Legacy-Id: 3347
2011-08-22 12:37:56 +00:00
Ole Laursen e831dc3e89 Add generic find_history_active_at(obj, time), refactor to use it
- Legacy-Id: 3303
2011-08-12 09:41:50 +00:00
Ole Laursen 67e317d535 Merged in changes from conversion branch fixing a couple of problems
- Legacy-Id: 3285
2011-08-04 15:09:54 +00:00
Henrik Levkowetz 804e7cb795 Add some debug output utility functions.
- Legacy-Id: 3262
2011-07-27 16:33:50 +00:00