Lars Eggert
6eabd4a3a1
chore: Use codespell
to fix typos in comments. ( #4794 )
...
First part of replacement of #4651
2022-11-28 10:36:36 -06:00
Jennifer Richards
5a55ec0959
test: fix date-related timezone errors in tests ( #4717 )
...
* test: compare UTC dates in test_search_mail_archive()
* test: compare datetimes, not dates, in action holders test
* test: adjust test to match TZ used for IPR notification message
* test: fix timezone in date_today() calls for liaisons tests
* test: use settings.TIME_ZONE for date in nomination tests
* test: correctly use settings.TIME_ZONE instead of system time zone
2022-11-07 09:54:35 +00:00
Jennifer Richards
3220bf3c40
chore: replace last few datetime.date.today() calls with date_today()
2022-10-18 12:45:47 -03:00
Jennifer Richards
da70acfdff
Merge branch 'feat/tzaware' into jennifer/yet-more-tz-fixes
...
# Conflicts:
# ietf/ietfauth/utils.py
# ietf/meeting/tests_views.py
# ietf/stats/tests.py
2022-10-17 16:39:45 -03:00
Jennifer Richards
f3bdbf0ed4
Merge branch 'feat/tzaware' into jennifer/main-for-tzaware-merge
...
# Conflicts:
# ietf/meeting/tests_js.py
# ietf/meeting/tests_models.py
# ietf/meeting/tests_views.py
# ietf/meeting/views.py
# ietf/name/fixtures/names.json
# ietf/templates/meeting/agenda.html
# ietf/templates/meeting/session_buttons_include.html
# ietf/templates/meeting/timeslot_start_end.html
2022-10-14 16:35:57 -03:00
Robert Sparks
6dd6165444
fix: correct meeting attendance calculations ( #4536 )
...
* fix: correct meeting attendance calculations
* test: change meetingregistration factory defaults
* test: Setup stats tests to verify counts honor meeting.Attended
But the tests aren't actually looking to see what numbers get generated yet.
* test: add test for attendance cross-talk between meetings
* fix: limit attendance count query to single meeting
* refactor: rename attendance.online to .remote
* fix: only count a given person as onsite or remote, but never both
* test: align tests with cleanup
Co-authored-by: Jennifer Richards <jennifer@painless-security.com>
2022-10-13 10:55:57 -05:00
Jennifer Richards
7b1b7f5273
Merge branch 'feat/tzaware' into dev/tzaware-main-merge
2022-10-11 14:57:34 -03:00
Robert Sparks
97d21800d0
feat: include checkins at the registration desk in nomcom eligibility calculations ( #4519 )
...
* chore: rename utility functions to reflect rfc guiding them
* feat: include new checkedin flag in nomcom calculations
* fix: reflect history a bit more accurately.
* fix: address review comment on readability
* fix: finish what c44000d started
2022-10-07 16:17:28 -05:00
Jennifer Richards
a653582cf7
fix: timezone fixes from last few comparisons with tzaware-obe
2022-09-28 13:21:50 -03:00
Jennifer Richards
32054111df
fix: fix failing tests and eliminate naive datetime warnings ( #4402 )
...
* test: fix timestamp construction in several doc tests
* refactor: rename date2datetime to datetime_from_date and clarify code
* chore: helper to get tzinfo for PRODUCTION_TIMEZONE
* fix: fix timezone handling in make_last_call()
* test: fix datetime generation in doc.tests_charter
* refactor: remove PRODUCTION_TIMEZONE setting
Replaces the PRODUCTION_TIMEZONE setting with a constant,
DEADLINE_TZINFO, in ietf.utils.timezone.
* test: be more careful about timezone in tests_charter.py
* test: be more careful about timezone in doc/tests.py
* fix: fix timezone handling affecting doc.tests_draft
* fix: fix timezone handling affecting tests_irsg_ballot.py
* fix: fix timezone handling affecting tests_review.py
* fix: fix timezone handling affecting last ietf.doc tests
* fix: fix timezone handling affecting last ietf.group tests
* fix: fix timezone handling affecting ietf.iesg tests
* fix: handle timezones in get_8989_eligibility_querysets
* fix: handle timezones affecting ietfauth tests
* fix: return tz-aware datetime from utc_from_string
* fix: specify timezone for constants in ipr_rfc_number()
* fix: specify tz for ipr deadlines
* fix: handle timezones affecting liaisons tests
* fix: treat leap day in get_8989_eligibility_querysets()
Manual cherry-pick of 248d6474
* test: treat leap day properly in nomcom tests
* fix: fix timezone handling affecting nomcom tests
* test: fix timezone handling in review tests
* fix: fix timezone handling affecting secr.meetings tests
* fix: handle both pytz and zoneinfo timezones in ietf.utils.timezone
* fix: fix timezone handling affecting secr.proceedings tests
* refactor: use make_aware() helper in secr.meetings tests
* test: fix timezone handling in secr.telechat tests
* fix: fix timezone handling affecting stats tests
* fix: eliminate tz-naive helpers affecting sync email parsing
* fix: include timezone data when serializing DeletedEvent data
* fix: fix timezone handling affecting sync tests
* style: remove unused import
2022-09-01 13:07:28 -03:00
Jennifer Richards
b85ecce89f
fix: treat leap day properly in nomcom eligibility calc ( #4393 )
...
* fix: treat leap day in get_8989_eligibility_querysets()
* test: treat leap day properly in nomcom tests
2022-08-31 16:03:38 -05:00
Jennifer Richards
ebebdbed3e
refactor: replace datetime.now and datetime.today with timezone.now ( #4211 )
...
* refactor: replace datetime.now with timezone.now
* refactor: migrate model fields to use timezone.now as default
* refactor: replace datetime.today with timezone.now
datetime.datetime.today() is equivalent to datetime.datetime.now(); both
return a naive datetime with the current local time.
* refactor: rephrase datetime.now(tz) as timezone.now().astimezone(tz)
This is effectively the same, but is less likely to encourage accidental
use of naive datetimes.
* refactor: revert datetime.today() change to old migrations
* refactor: change a missed datetime.now to timezone.now
* chore: renumber timezone_now migration
* chore: renumber migrations
2022-08-25 13:45:16 -03:00
Robert Sparks
fe1f51aede
fix: Compute 8989 eligibility using actual attendance data. ( #4236 )
2022-07-21 12:58:32 -05:00
Robert Sparks
087265118d
feat: csv export of nomcom volunteers. Fixes #4127 . ( #4146 )
2022-07-06 14:13:41 -05:00
Robert Sparks
66feccbc67
test: avoid edge case in test factory. Fixes #3513 . ( #3736 )
2022-03-24 09:13:33 -03:00
Jennifer Richards
6c260a5b7e
Merge 7.45.1.dev0 into Bootstrap 5 update branch. Made a first pass at reconciling differences.
...
- Legacy-Id: 19945
2022-02-17 20:09:49 +00:00
Lars Eggert
335a39d4fc
More fixes.
...
- Legacy-Id: 19884
2022-01-28 13:00:47 +00:00
Lars Eggert
5132661b06
More test fixes
...
- Legacy-Id: 19803
2022-01-05 11:25:25 +00:00
Lars Eggert
f974fd3c04
Fix more things
...
- Legacy-Id: 19762
2021-12-09 06:41:00 +00:00
Jennifer Richards
8759955597
Allow nomcom chair to edit liaisons as well as members and generate GroupEvents when changed. Share code between group and nomcom for this purpose. Fixes #3376 . Commit ready for merge.
...
- Legacy-Id: 19710
2021-11-24 16:40:05 +00:00
Lars Eggert
333d1c40ac
Merge ^/personal/lars/7.39.1.dev3
...
- Legacy-Id: 19649
2021-11-12 11:55:55 +00:00
Robert Sparks
181da11a5c
Use rfc8989 for 2022 nomcom eligibility. Fixes #3442 . Commit ready for merge.
...
- Legacy-Id: 19621
2021-11-10 14:59:33 +00:00
Lars Eggert
bb5810a934
Labels are badges in bs5.
...
- Legacy-Id: 19616
2021-11-10 11:15:46 +00:00
Jennifer Richards
81d9234d54
Use temporary directories instead of "real" filesystem for tests. Fixes #3414 . Commit ready for merge.
...
- Legacy-Id: 19555
2021-11-05 19:45:57 +00:00
Robert Sparks
76a8a29756
Bring the nomcom factories and tests into agreement around what a valid year for a nomcom can be. Fixes #3315 . Commit ready for merge.
...
- Legacy-Id: 19148
2021-06-23 16:17:09 +00:00
Robert Sparks
06f6b12b18
Refine volunteer list view. Show rfc8989 paths. Commit ready for merge.
...
- Legacy-Id: 19139
2021-06-22 20:09:40 +00:00
Robert Sparks
86102b9980
Allow people to volunteer for NomCom via the datatracker. Commit ready for merge.
...
- Legacy-Id: 19104
2021-06-10 20:35:50 +00:00
Robert Sparks
b8771006b3
Merged in [18999] from rjsparks@nostrum.com:
...
Correct invalid date assumption in rfc8989 eligibility tests.
- Legacy-Id: 19001
Note: SVN reference [18999] has been migrated to Git commit 53fa35c148e2d9a3a01987601de5d20edb0c401f
2021-05-18 18:00:40 +00:00
Robert Sparks
fd38a9bf96
Add RFC 8989 nomcom eligibility calculations. Commit ready for merge.
...
- Legacy-Id: 18975
2021-05-06 19:42:09 +00:00
Robert Sparks
bcc280fe9b
tightened edge for group office rule
...
- Legacy-Id: 18972
2021-05-06 13:51:29 +00:00
Robert Sparks
216ec499df
Checkpointing. Remaining work: convert meetingregistation fixup to a migration and a mgmt comment. Flesh out testing of 8989 rule 2 and fix the known edge case bug. Remove old implementation and connect UI to the new implementation.
...
- Legacy-Id: 18971
2021-05-01 19:57:04 +00:00
Robert Sparks
3697180cc1
Reverted merge of timezone-aware migration efforts.
...
- Legacy-Id: 18792
2021-01-12 16:54:20 +00:00
Henrik Levkowetz
774e752a54
Snapshot of timezone-aware datatracker code. Tests pass, and the test-crawler shows only expected differences. Trunk changes merged in up to r18768.
...
- Legacy-Id: 18770
2020-12-16 23:53:37 +00:00
Jim Fenton
431a112bf1
Added NomCom membership history page. Fixes issue #3006 . Branch ready for merge.
...
- Legacy-Id: 18601
2020-10-12 02:36:16 +00:00
Henrik Levkowetz
efcdc4d917
Updated meeting attendance and nomcom eligibility calculations to take the MeetingRegistration.attendance flag into account.
...
- Legacy-Id: 17955
2020-06-09 21:00:07 +00:00
Henrik Levkowetz
bc05e7a8d0
Refactored many instances of msg.get_payload(decode=True).decode('utf-8') and similar to get_payload_text(msg), which uses msg.get_charset() to get the actual charset to do the decoding, in a consistent manner. Also removed some instances of force_str, but more remain.
...
- Legacy-Id: 17807
2020-05-16 20:20:05 +00:00
Henrik Levkowetz
f10ddadc0e
Merged in changes from trunk up to r17584.
...
- Legacy-Id: 17593
2020-04-07 16:02:52 +00:00
Henrik Levkowetz
dc4c05ec5b
Changed the object factory instances of nomcom private key and cert to be byte objects (matching the production settings), and fixed the issue with nomcom key handling under Py3 found by fenton@bluepopcorn.net. Did some renaming in nomcom/tests.py to better match setup/teardown function names to functionality.
...
- Legacy-Id: 17536
2020-03-25 13:36:29 +00:00
Henrik Levkowetz
726fcbf27d
Removed all __future__ imports.
...
- Legacy-Id: 17391
2020-03-05 23:53:42 +00:00
Henrik Levkowetz
ab173cb2eb
Removed further six usage: six.string_types, six.integer_types, six.moves.urllib instances.
...
- Legacy-Id: 17390
2020-03-05 20:46:58 +00:00
Henrik Levkowetz
fa4adeb374
Fixed a number of bad Message.content_type settings.
...
- Legacy-Id: 17339
2020-02-26 17:05:53 +00:00
Jennifer Richards
cd77c76372
Add links to user profiles from nominee list and feedback page. Fixes #2839 . Commit ready for merge.
...
- Legacy-Id: 17275
2020-02-05 21:10:47 +00:00
Robert Sparks
cca04b6330
Correct construction for a reverse URL in an edge case. Fixes #2815 . Commit ready for merge.
...
- Legacy-Id: 16907
2019-10-22 18:24:57 +00:00
Henrik Levkowetz
bdc73e771a
Python2/3 compatibility: replaced six.ensure_text() with either six.text_type or django's force_text(), depending on the case, and fixed a variable scope issue.
...
- Legacy-Id: 16461
2019-07-16 13:20:05 +00:00
Henrik Levkowetz
8c6eb3a30a
Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc.
...
- Legacy-Id: 16458
2019-07-15 19:14:04 +00:00
Henrik Levkowetz
1e115539c4
The previous nomcom.fields.EncryptedTextField relied on initial cleartext content having the same type as ciphertext. Under Python3, that's not the case (ciphertext has type bytes). Rewrote the nomcom app and tests to handle capture of comments and encryption to the Feedback.comments ciphertext differently.
...
- Legacy-Id: 16350
2019-07-01 11:59:59 +00:00
Henrik Levkowetz
97a555936d
Changed a large number of test assertions to use assertContains() and removed separate, now unnecessary,status_code checks. Also changed many assertTrue(... in ...) to use assertIn().
...
- Legacy-Id: 16346
2019-06-30 21:03:34 +00:00
Henrik Levkowetz
15e74e89cb
Converted instances of assertTrue(text in response.content) to the recommended assertContains(response, text), and similar for assertFalse(... in ...)
...
- Legacy-Id: 16336
2019-06-29 13:43:31 +00:00
Henrik Levkowetz
3ec7e864be
Converted leading tabs to spaces in ietf/**/*.py
...
- Legacy-Id: 16310
2019-06-27 14:51:02 +00:00
Henrik Levkowetz
d7f5c84182
Initial 2to3 patch with added copyright statement updates.
...
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00