On the main page of a document and in document search results, a new
button allows review team members to add a review wish for that document.
For reviewers that are only on one team, this essentially works
identical to tracking a document. Reviewers that are on multiple teams
are lead through an intermediate step to select a review team, and then
returned to their search or document page.
Commit ready for merge.
- Legacy-Id: 16939
If a review is suggested on the "manage unassigned reviews" page, and
the document is in both last call and telechat, the assign form now asks
for the type of review that should be assigned.
This commit also fixes two bugs in this process:
- Comparisons in some cases between strings and integers
(group/views.py:1485/1487)
- Rejections when assigning suggested reviews, as they could be
considered a newly opened request due to not having a pk
(group/views.py:1508)
Commit ready for merge.
- Legacy-Id: 16933
- For team secretaries, a button "Submit unsolicited review" will now
appear next to "Request review" on the document's main page.
- If the secretary is a secretary for multiple teams, they are taken
through an intermediate page to select for which team they are
submitting their review.
- The form is similar (and using the same code) as the usual review
completion, with a few extra fields for the review type and reviewer,
which would usually already be known.
- When submitting the review, a ReviewRequest and ReviewAssignment are
automatically created. The assignment is then immediately closed in
the usual way.
- Other workflows are unchanged.
The issues with the review form in #2061 are slightly worse for the
unsolicited review scenario, but that will be improved when #2061 is
fixed.
Commit ready for merge.
- Legacy-Id: 16924
On the stats page, a single stacked bar graph is now shown which
combines in time and late reviews, replacing the separate graphs for
these statistics.
Tests for the charts are also expanded to validate the actual
graph content for both stacked and non-stacked charts.
Commit ready for merge.
- Legacy-Id: 16852
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.
Commit ready for merge.
- Legacy-Id: 16792
The interleaved_migrations_test currently fails due to the various
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.
Commit ready for merge.
- Legacy-Id: 16705
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
Commit ready for merge.
- Legacy-Id: 16704
Use unversioned slide link from the materials popup from the agenda page. Fixes#2756.
- Legacy-Id: 16612
Note: SVN reference [16594] has been migrated to Git commit 51a874dec4a06a707eb3547f6dd443cfbed94bd4
Change how the session details page links to documents to not link to a specific version. Fixes#2758. See also #2756.
- Legacy-Id: 16610
Note: SVN reference [16592] has been migrated to Git commit c6c086b122dbd57cb6a55ed7f68be4a8dfd877b6
Example of using webtest. The full testcase was not converted because the add_rule form is modified in-flight by javascript when a control value is changed.
- Legacy-Id: 16609
Note: SVN reference [16590] has been migrated to Git commit e89f200abc0d9af7609e4bff3592f87eddee1359
Add quotes around document name in the mailarchive search link on a document's main page. Fixes#2659.
- Legacy-Id: 16606
Note: SVN reference [16569] has been migrated to Git commit b4a40313c95511693ae8a361aabb355878555fb7
Show a calendar of upcoming meetings. Fixes#2719.
- Legacy-Id: 16602
Note: SVN reference [16589] has been migrated to Git commit d3b70a46b882979fabb82972921a6ad177c06b08
Added Closing Notes to history and about pages for groups. Fixes issue #2725.
- Legacy-Id: 16586
Note: SVN reference [16559] has been migrated to Git commit 93b4d6fcc4
Partially addresses issue #1926 still displaying markdown as text. Fixes#2704.
- Legacy-Id: 16576
Note: SVN reference [16557] has been migrated to Git commit f76c46bef0
Rework how SlideSuggestion objects name their files. Improve the UI when there are multiple pending suggestions for updating the same presentation.
- Legacy-Id: 16570
Note: SVN reference [16554] has been migrated to Git commit 1e8eb0ed6d227e32816c4bc352a7301691eaaaac
primary keys from character strings to integers, and makes corresponding code
changes.
This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.
Changing the primary keys to integers should also improve efficiency.
Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time. The total set of migrations are expected to have
a runtime on the order of 2 hours.
- Legacy-Id: 16237
- Legacy-Id: 16163
Note: SVN reference [16124] has been migrated to Git commit e101d94065
Note: SVN reference [16154] has been migrated to Git commit 758757038a
Show minutes on the popup for the meeting materials button on the agenda page when those minutes are available. Fixes#2711.
- Legacy-Id: 16162
Note: SVN reference [16152] has been migrated to Git commit 88f49ed2b4
