Commit graph

1460 commits

Author SHA1 Message Date
Robert Sparks c6f55a3306 Fixed some test scaffolding that used non-existent keys (uncovered by recent improvements in sqlite3 integrity checking). Commit ready for merge.
- Legacy-Id: 18130
2020-07-02 20:05:02 +00:00
Henrik Levkowetz 47a2174e80 Django 2.2 does not wrap single queries in transactions, for performance reasons. This caused some template tags that did database lookups to trigger exceptions. Fixed by moving the lookups (which would not normally change between apache reloads) out from the template tag code to module scope. Adding new groups of type ['ag','area','team','dir','program'] will now require a reload to show up in the group menu.
- Legacy-Id: 18086
2020-06-27 17:28:50 +00:00
Henrik Levkowetz dc5ca4eebc Merged in Django 2.1 upgrade changes.
- Legacy-Id: 18060
2020-06-24 20:51:00 +00:00
Henrik Levkowetz dc7581fef4 Changed NullBoleanField() to BooleanField(null=True), according to the 2.1 upgrade recommendations.
- Legacy-Id: 18051
2020-06-24 20:33:57 +00:00
Robert Sparks f7b1ce1fce Remove abandoned charters from any future telechats. Fixes #3003. Commit ready for merge.
- Legacy-Id: 18037
2020-06-22 21:22:54 +00:00
Henrik Levkowetz bc05e7a8d0 Refactored many instances of msg.get_payload(decode=True).decode('utf-8') and similar to get_payload_text(msg), which uses msg.get_charset() to get the actual charset to do the decoding, in a consistent manner. Also removed some instances of force_str, but more remain.
- Legacy-Id: 17807
2020-05-16 20:20:05 +00:00
Henrik Levkowetz 02804ba163 Fixed a case of too few format string parameters.
- Legacy-Id: 17768
2020-05-10 14:14:50 +00:00
Henrik Levkowetz 81197f044c Tweaked a 404 message to differentiate between two not-found cases.
- Legacy-Id: 17767
2020-05-10 14:13:39 +00:00
Henrik Levkowetz 29ccca849a Added a second link to htmlized draft content (on the datatracker) in addition to the link to the tools hosted htmlized document.
- Legacy-Id: 17760
2020-05-06 18:23:47 +00:00
Henrik Levkowetz 0b51e9a2b3 Removed a debug statement.
- Legacy-Id: 17732
2020-05-04 20:59:44 +00:00
Henrik Levkowetz 35a2a145fa Merged in [17708] from rjsparks@nostrum.com:
Remove 'point raised - writup needed' from the set of substates the IESG can use with a document. Fixes #2968.
 - Legacy-Id: 17731
Note: SVN reference [17708] has been migrated to Git commit fa492c3947
2020-05-04 20:50:17 +00:00
Henrik Levkowetz 3e6a1cfb11 Limited the data for 'New draft revisions over time' on the personal profile page to type='draft'.
- Legacy-Id: 17720
2020-05-01 11:37:32 +00:00
Robert Sparks fa492c3947 Remove "point raised - writup needed" from the set of substates the IESG can use with a document. Fixes #2968. Commit ready for merge.
- Legacy-Id: 17708
2020-04-29 20:32:31 +00:00
Henrik Levkowetz 9aeda11a29 Removed some Py2 compatibility decorators.
- Legacy-Id: 17673
2020-04-21 13:54:31 +00:00
Henrik Levkowetz f10ddadc0e Merged in changes from trunk up to r17584.
- Legacy-Id: 17593
2020-04-07 16:02:52 +00:00
Henrik Levkowetz 98fab6c05b Merged in [17562] from jennifer@painless-security.com:
Add tooltips with doc name to 'updates' and 'obsoletes' links. Fixes #2866;
 - Legacy-Id: 17569
Note: SVN reference [17562] has been migrated to Git commit 2d6179c1a5
2020-03-31 13:03:15 +00:00
Jennifer Richards 2d6179c1a5 Add tooltips with doc name to "updates" and "obsoletes" links. Fixes #2866; Commit ready for merge.
- Legacy-Id: 17562
2020-03-30 20:22:05 +00:00
Henrik Levkowetz 37f39163d1 Prevent an exception on missing author.email.person when listing author emails.
- Legacy-Id: 17554
2020-03-27 16:14:29 +00:00
Henrik Levkowetz 50bb971fc3 Merged in [17496] from rjsparks@nostrum.com:
Remove the rest of the log.assertions checking that iesg_state existed in places we expected it to.  Removed unnecessary imports.
 - Legacy-Id: 17522
Note: SVN reference [17496] has been migrated to Git commit db5d11ea32
2020-03-23 22:34:03 +00:00
Henrik Levkowetz c6be826113 Merged in [17495] from rjsparks@nostrum.com:
Remove log.assertion that was checking that we covered the edges when we changed documents to always have an iesg state.
 - Legacy-Id: 17517
Note: SVN reference [17495] has been migrated to Git commit f2b106cf8c
2020-03-23 11:16:19 +00:00
Henrik Levkowetz 970248a3d6 Merged in [17494] from rjsparks@nostrum.com:
Use current email addresses when we have them when listing document authors. Fixes #1902.
 - Legacy-Id: 17516
Note: SVN reference [17494] has been migrated to Git commit 8583a0a098
2020-03-22 23:55:49 +00:00
Robert Sparks db5d11ea32 Remove the rest of the log.assertions checking that iesg_state existed in places we expected it to. Commit ready for merge.
- Legacy-Id: 17496
2020-03-21 22:11:33 +00:00
Robert Sparks f2b106cf8c Remove log.assertion that was checking that we covered the edges when we changed documents to always have an iesg state. Commit ready for merge.
- Legacy-Id: 17495
2020-03-21 22:07:15 +00:00
Robert Sparks 8583a0a098 Use current email addresses when we have them when listing document authors. Fixes #1902. Commit ready for merge.
- Legacy-Id: 17494
2020-03-21 21:36:58 +00:00
Henrik Levkowetz 87bf4e8d58 Make sure to strip possible mail header field values of whitespace before applying email.utils.unquite(). Resolution by kivinen@iki.fi, Fixes issue #2899.
- Legacy-Id: 17485
2020-03-21 17:34:37 +00:00
Henrik Levkowetz 08130f4986 Merged in [17396] from rjsparks@nostrum.com:
Move charters for replaced groups to a new replaced state. Close any outstanding ballots on them. Fixes #2889, #2873, and #1286.
 - Legacy-Id: 17420
Note: SVN reference [17396] has been migrated to Git commit 79bb245f8a
2020-03-11 19:21:43 +00:00
Henrik Levkowetz ec13af6c43 Added a guard against accessing attributes of None.
- Legacy-Id: 17409
2020-03-08 13:18:58 +00:00
Henrik Levkowetz 638fbc592e Added a data migration to fix up some incorrect external URLs for reviews.
- Legacy-Id: 17402
2020-03-07 14:21:41 +00:00
Robert Sparks 79bb245f8a Move charters for replaced groups to a new replaced state. Close any outstanding ballots on them. Fixes #2889, #2873, and #1286. Commit ready for merge.
- Legacy-Id: 17396
2020-03-06 16:47:59 +00:00
Henrik Levkowetz 726fcbf27d Removed all __future__ imports.
- Legacy-Id: 17391
2020-03-05 23:53:42 +00:00
Henrik Levkowetz ab173cb2eb Removed further six usage: six.string_types, six.integer_types, six.moves.urllib instances.
- Legacy-Id: 17390
2020-03-05 20:46:58 +00:00
Henrik Levkowetz e9a37d8ac8 Removed six.text_type(), changed six.moves.urllib to plain urllib, and removed now unused six imports.
- Legacy-Id: 17385
2020-03-05 14:41:41 +00:00
Henrik Levkowetz a14e38a1a1 Replaced most cases of using of urlopen(), instead using the higher-level 'requests' module where it simplifies the code.
- Legacy-Id: 17380
2020-03-03 17:34:42 +00:00
Henrik Levkowetz 94e4dc7c74 Python3 is more ticklish about comparing strings to None than Py2. Fixed an issue with this in generate_sort_key() for document searches.
- Legacy-Id: 17373
2020-03-02 12:47:05 +00:00
Henrik Levkowetz 07747b26c3 Fixed an issue with tests mocking urlopen() responses, and tweaked error messages on bad results in sync/rfceditor.py
- Legacy-Id: 17356
2020-02-27 15:05:27 +00:00
Henrik Levkowetz bea0c59d6e Fixed a string vs list issue for Message from form case.
- Legacy-Id: 17338
2020-02-26 17:01:00 +00:00
Henrik Levkowetz a7baacf519 Added missing .as_strings() to some gather_address_lists() calls, in order to assign strings rather than lists to Message CharField instances. Fixed a Message content_type setting.
- Legacy-Id: 17337
2020-02-26 16:59:18 +00:00
Henrik Levkowetz ab34ecbb58 Merged in [17288] from rjsparks@nostrum.com:
Make internal review email about an RG use the IRSG instead of the IESG in text and addresses. Fixes #2881.
 - Legacy-Id: 17307
Note: SVN reference [17288] has been migrated to Git commit 4cce1b5e08
2020-02-18 22:04:15 +00:00
Henrik Levkowetz 0a6260cf16 Merged in [17286] from rjsparks@nostrum.com:
Add Reply-To to the default group review text. Fixes #2883.
 - Legacy-Id: 17292
Note: SVN reference [17286] has been migrated to Git commit 7e09dea02c
2020-02-13 00:33:37 +00:00
Henrik Levkowetz 5e6ea5b2e8 Merged in [17284] from jennifer@painless-security.com:
Create DocEvent when related IprDisclosure is posted or removed. Fixes #2811.
 - Legacy-Id: 17291
Note: SVN reference [17284] has been migrated to Git commit b02b42da81
2020-02-12 23:11:26 +00:00
Robert Sparks 4cce1b5e08 Make internal review email about an RG use the IRSG instead of the IESG in text and addresses. Fixes #2881. Commit ready for merge.
- Legacy-Id: 17288
2020-02-11 20:17:42 +00:00
Robert Sparks 7e09dea02c Add Reply-To to the default group review text. Fixes #2883. Commit ready for merge.
- Legacy-Id: 17286
2020-02-11 15:39:20 +00:00
Jennifer Richards b02b42da81 Create DocEvent when related IprDisclosure is posted or removed. Fixes #2811. Commit ready for merge.
- Legacy-Id: 17284
2020-02-07 20:41:13 +00:00
Henrik Levkowetz 32e9692f54 Fixed a py2/py3 issue in sync.rfceditor.post_approved_draft(), and enhanced tests to execute the failing code (with Mock functions) instead of skipping the code.
- Legacy-Id: 17265
2020-01-28 22:37:50 +00:00
Henrik Levkowetz 82baf773d8 Merged in [17228] from rjsparks@nostrum.com:
Improve admin handling of DocumentURL. Fixes #2865.
 - Legacy-Id: 17231
Note: SVN reference [17228] has been migrated to Git commit 0040a85395
2020-01-14 13:43:56 +00:00
Henrik Levkowetz 3fe48041da Merged in [17227] from rjsparks@nostrum.com:
Allow document Additional URLs to become empty. Fixes #2864.
 - Legacy-Id: 17229
Note: SVN reference [17227] has been migrated to Git commit 0c0cc5dcf5
2020-01-14 11:09:21 +00:00
Robert Sparks 0040a85395 Improve admin handling of DocumentURL. Fixes #2865. Commit ready for merge.
- Legacy-Id: 17228
2020-01-13 19:33:35 +00:00
Robert Sparks 0c0cc5dcf5 Allow document Additional URLs to become empty. Fixes #2864. Commit ready for merge.
- Legacy-Id: 17227
2020-01-13 19:03:58 +00:00
Henrik Levkowetz 288f4135e3 Added (currently inactive) code to trigger exceptions on failure to resolve template variables during tests, and added fixes for a couple of places that triggered such exceptions.
- Legacy-Id: 17226
2020-01-13 17:16:43 +00:00
Henrik Levkowetz d2b2bb1417 Merged in [17219] from rjsparks@nostrum.com:
Update some uses of pos.ad in templates to pos.balloter. Fixes #2863.
 - Legacy-Id: 17224
Note: SVN reference [17219] has been migrated to Git commit af0a9954fe
2020-01-13 15:01:40 +00:00