Commit graph

22 commits

Author SHA1 Message Date
Jennifer Richards 6df0377fa1 Fix several review reminder problems.
Send secretary's review reminders to secretary instead of assignee. 
Send unconfirmed assignment reminders based on assignment age and CC secretaries. 
Correctly separate open review reminders by review team.

Fixes #3482. Fixes #3324. Commit ready for merge.
 - Legacy-Id: 19848
2022-01-14 19:14:06 +00:00
Robert Sparks 3697180cc1 Reverted merge of timezone-aware migration efforts.
- Legacy-Id: 18792
2021-01-12 16:54:20 +00:00
Henrik Levkowetz 774e752a54 Snapshot of timezone-aware datatracker code. Tests pass, and the test-crawler shows only expected differences. Trunk changes merged in up to r18768.
- Legacy-Id: 18770
2020-12-16 23:53:37 +00:00
Henrik Levkowetz ac38dba94b Ran scripts invoked from bin/hourly and bin/daily through pyflakes3 and test invocation, and tweaked the code (with an added comment) to consistently require virtualenv to be set up before script invocation.
- Legacy-Id: 17269
2020-01-30 22:19:42 +00:00
Henrik Levkowetz 83de8b9f1e Changed print() statements to syslog logging in a cron-invoked script, to remove non-error output. Fixes issue #2849.
- Legacy-Id: 17163
2019-12-20 14:31:28 +00:00
Henrik Levkowetz c474b42f2d Send review reminders output to log, rather than stdout (since this is run from cron, stdout and stderr should be quiet if nothing unexpected happens)
- Legacy-Id: 16878
2019-10-18 14:46:59 +00:00
Henrik Levkowetz a66fa82b06 Fixed some review reminders issues.
- Legacy-Id: 16863
2019-10-15 16:46:12 +00:00
Henrik Levkowetz be641ac22a Merged in [16792] from sasha@dashcare.nl:
Fix #2475 - Send opt-in reminders for unconfirmed review assignments.
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.
 - Legacy-Id: 16846
Note: SVN reference [16792] has been migrated to Git commit 486b6daa29
2019-10-08 15:57:28 +00:00
Henrik Levkowetz 678f8a5787 Merged in [16765] from sasha@dashcare.nl:
Refs #2277 - Send daily reminders of overdue reviews to secretaries
 - Legacy-Id: 16839
Note: SVN reference [16765] has been migrated to Git commit cc64992204
2019-10-08 10:41:37 +00:00
Henrik Levkowetz 09e38dffa0 Merged in [16705] from sasha@dashcare.nl:
Fix #2337 - Send periodic reminders of open reviews every X days (opt-in)
The interleaved_migrations_test currently fails due to the various 
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.
 - Legacy-Id: 16823
Note: SVN reference [16705] has been migrated to Git commit ec56a03ec6
2019-10-04 17:09:57 +00:00
Henrik Levkowetz 4c3e869d5c Merged in [16704] from sasha@dashcare.nl:
Fix #2231 - Send reminders before long UnavailabilityPeriods expire
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
 - Legacy-Id: 16822
Note: SVN reference [16704] has been migrated to Git commit 179c151f9e
2019-10-04 14:07:54 +00:00
Sasha Romijn 486b6daa29 Fix #2475 - Send opt-in reminders for unconfirmed review assignments.
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.

Commit ready for merge.
 - Legacy-Id: 16792
2019-10-01 13:01:19 +00:00
Sasha Romijn cc64992204 Refs #2277 - Send daily reminders of overdue reviews to secretaries
Commit ready for merge.
 - Legacy-Id: 16765
2019-09-30 12:27:43 +00:00
Sasha Romijn ec56a03ec6 Fix #2337 - Send periodic reminders of open reviews every X days (opt-in)
The interleaved_migrations_test currently fails due to the various 
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.

Commit ready for merge.
 - Legacy-Id: 16705
2019-09-05 15:02:56 +00:00
Sasha Romijn 179c151f9e Fix #2231 - Send reminders before long UnavailabilityPeriods expire
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
Commit ready for merge.
 - Legacy-Id: 16704
2019-09-05 11:59:40 +00:00
Sasha Romijn 296b126c70 Ref #2231 - Fix send-review-reminders and add it to daily cron
This fixes a syntax error and a Python 3 incompatibility, and adds
send-review-reminders to the daily cron script.

Important notes:
- I have not tested to what degree the existing reminders work as they
  should, as that's out of scope. It does have tests.
- I can't assess whether the virtualenv activation works in the
  production setup, and it may be obsolete as bin/daily also
  activates the virtualenv.
- The same Python 3 incompatibility (execfile() no longer exists) seems
  to exist in various other scripts.
  
Commit ready for merge.
 - Legacy-Id: 16703
2019-09-05 10:50:39 +00:00
Henrik Levkowetz 8726e74709 Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself.
- Legacy-Id: 16177
2019-04-30 16:54:06 +00:00
Henrik Levkowetz bb4fe3fbbf Undid previous commit
- Legacy-Id: 16153
2019-04-22 19:22:42 +00:00
Robert Sparks a4db66564c Checkpoint. Ended up chasing group.views_review before stats.
- Legacy-Id: 16030
2019-03-13 22:02:10 +00:00
Robert Sparks e91d706d5b Checkpointing. This is an incomplete idea. The tests will fail massively.
- Legacy-Id: 15985
2019-03-01 23:19:47 +00:00
Henrik Levkowetz 5e3f3378d3 Updated scripts in ietf/bin/ to look in env/bin/ for the virtualenv activation script.
- Legacy-Id: 12560
2016-12-16 17:50:04 +00:00
Ole Laursen ceec1254f2 Add review team secretary reminders, like those for reviewers
- Legacy-Id: 12283
2016-11-08 16:24:28 +00:00
Renamed from ietf/bin/send-reviewer-reminders (Browse further)