Commit graph

69 commits

Author SHA1 Message Date
Robert Sparks 6dd6165444
fix: correct meeting attendance calculations (#4536)
* fix: correct meeting attendance calculations

* test: change meetingregistration factory defaults

* test: Setup stats tests to verify counts honor meeting.Attended

But the tests aren't actually looking to see what numbers get generated yet.

* test: add test for attendance cross-talk between meetings

* fix: limit attendance count query to single meeting

* refactor: rename attendance.online to .remote

* fix: only count a given person as onsite or remote, but never both

* test: align tests with cleanup

Co-authored-by: Jennifer Richards <jennifer@painless-security.com>
2022-10-13 10:55:57 -05:00
Robert Sparks 9c236ea2a2
chore: remove unneeded logging and code marked unreachable that has not been reached. (#4305)
* chore: remove unneeded logging and code marked unreachable that has not been reached.

* fix: remove noop save override
2022-08-04 11:25:31 -05:00
Robert Sparks b988850985
fix: avoid mutables as defaults. Compute date default arguments at runtime rather than loadtime. (#4144) 2022-07-06 14:39:36 -05:00
rpcross 698f031b7f
feat: separate MeetingRegistration rows for each registration type. updates the registration API (#3641)
* Registration API Update

- change MeetingRegistration.reg_type field to hold only one type
- allow multiple MeetingRegistration records per person/meeting
  (one for each reg_type)

* Fix scope claims

* Add meeting 114 to MeetingRegistration migration

* fix: update stats views for MeetingRegistration model use changes

* refactor: remove unused imports
2022-06-16 15:39:34 -05:00
Robert Sparks 3697180cc1 Reverted merge of timezone-aware migration efforts.
- Legacy-Id: 18792
2021-01-12 16:54:20 +00:00
Henrik Levkowetz 774e752a54 Snapshot of timezone-aware datatracker code. Tests pass, and the test-crawler shows only expected differences. Trunk changes merged in up to r18768.
- Legacy-Id: 18770
2020-12-16 23:53:37 +00:00
Henrik Levkowetz 536789517d Added a sort of author names for stability of some stats pages. Commit ready for merge.
- Legacy-Id: 18751
2020-12-11 16:57:29 +00:00
Henrik Levkowetz ac5e88b82b Added a context processor to make settings generally available in page templates. Split the SECRETARIAT_TICKET_EMAIL setting into SECRETARIAT_ACTION_EMAIL and SECRETARIAT_INFO_EMAIL, with different addresses. Updated places with hardcoded ietf-action@ietf.org addresses to use the settings value, and updated some places to use ietf-infor@ietf.org instead of the ietf-action address. Fixes issue #3081.
- Legacy-Id: 18501
2020-09-17 11:10:27 +00:00
Henrik Levkowetz 57938b039d Converted many cases of plain-text 403 messages to use a properly styled page instead, with a login link when appropriate. Also changed some API endpoint 400 responses to a more correct 403.
- Legacy-Id: 18339
2020-08-06 10:59:52 +00:00
Henrik Levkowetz 8a6026ce6e Added a MeetingRegistration.attended field, to keep apart meeting attendence and meeting registration before attendance.
- Legacy-Id: 17954
2020-06-09 20:58:35 +00:00
Henrik Levkowetz 726fcbf27d Removed all __future__ imports.
- Legacy-Id: 17391
2020-03-05 23:53:42 +00:00
Sasha Romijn f651320ef3 Fix #2331 - Show stacked bar graph for in time and late reviews.
On the stats page, a single stacked bar graph is now shown which
combines in time and late reviews, replacing the separate graphs for
these statistics.

Tests for the charts are also expanded to validate the actual
graph content for both stacked and non-stacked charts.

Commit ready for merge.
 - Legacy-Id: 16852
2019-10-09 15:46:22 +00:00
Henrik Levkowetz a5e31c3f40 Py2/3 compatibility: Added __future__ import.
- Legacy-Id: 16452
2019-07-15 15:52:18 +00:00
Henrik Levkowetz e55c42b20f Tweaked code to prevent sort comparison of str with None.
- Legacy-Id: 16397
2019-07-04 20:58:25 +00:00
Henrik Levkowetz f13887de7c Removed superfluous iter() and fixed instances where sorted() had to compare None and int.
- Legacy-Id: 16352
2019-07-01 14:07:21 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates.
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias.
- Legacy-Id: 16261
2019-06-15 12:00:48 +00:00
Henrik Levkowetz a2cafded25 Changed DocAlias to be many-to-many, in order to be able to handle STD aliases referring to multiple RFCs.
- Legacy-Id: 16249
2019-06-14 20:38:14 +00:00
Henrik Levkowetz 8726e74709 Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself.
- Legacy-Id: 16177
2019-04-30 16:54:06 +00:00
Henrik Levkowetz bb4fe3fbbf Undid previous commit
- Legacy-Id: 16153
2019-04-22 19:22:42 +00:00
Henrik Levkowetz cfcefc2e32 Merged in [16144] from housley@vigilsec.com:
Remove some clutter from I-D upload page.  The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes #2057.
 - Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
2019-04-22 17:39:26 +00:00
Robert Sparks 6dc25cae1a Bring time series stats back into line with what was before. Note there was an off-by-one-day bug in the month-binning in prior releases.
- Legacy-Id: 16075
2019-03-20 20:04:06 +00:00
Henrik Levkowetz 23ad24d2aa Put a length limit to generated cache keys in stats/views.py, to avoid tickling memcached's limit of 250.
- Legacy-Id: 16037
2019-03-17 11:16:38 +00:00
Robert Sparks 4b147f2ef8 More cleanup and correction. Caught a pervasive misuse of a state-name
- Legacy-Id: 16036
2019-03-15 20:39:06 +00:00
Robert Sparks 3678d20b0b Some cleanup around stats. Things are well except for the time series graphs.
- Legacy-Id: 16035
2019-03-15 16:50:59 +00:00
Henrik Levkowetz 080f6b4385 Added group links to the past meetings page, and also important dates links to IETF meetings with important-date pages.
- Legacy-Id: 15053
2018-04-18 13:15:30 +00:00
Henrik Levkowetz 010910a847 Tweaked the meeting date format in the attendees per meeting bargraph tooltip.
- Legacy-Id: 14952
2018-03-28 06:37:31 +00:00
Henrik Levkowetz 176022f57b Added meeting dates to the meeting stats overview graph.
- Legacy-Id: 14947
2018-03-26 22:58:14 +00:00
Henrik Levkowetz dac30f6ff7 Changed the name of a loop variable so as not to obscure a previous local variable.
- Legacy-Id: 14946
2018-03-26 21:42:10 +00:00
Henrik Levkowetz 68f64e9ecb Don't show future meetings in the meeting stats overview.
- Legacy-Id: 14945
2018-03-26 21:39:41 +00:00
Henrik Levkowetz 4c297ba4c0 Changed settings so that cache keys used by memcached includes the release version, in order to avoid stale and incorrect cache content on new release deployment. Made it easier to pick out cache key composition by normalizing the variable name. Adjusted cache prefix and the composition of some keys to have a unique and consistent cache key prefix.
- Legacy-Id: 14943
2018-03-26 21:26:20 +00:00
Henrik Levkowetz c8ebcf1f88 Merged in [14879] from kivinen@iki.fi:
Backfilled IETF meetings starting from 1 and backfilled the attendee numbers for them. Modified the overview attendee statistics page to use different colors for different venue continents.
 - Legacy-Id: 14898
Note: SVN reference [14879] has been migrated to Git commit 75dbe017a6
2018-03-22 00:01:57 +00:00
Tero Kivinen 75dbe017a6 Backfilled IETF meetings starting from 1 and backfilled the attendee numbers for them. Modified the overview attendee statistics page to use different colors for different venue continents. Commit ready for merge.
- Legacy-Id: 14879
2018-03-20 17:28:48 +00:00
Henrik Levkowetz 954d79c684 Added a guard against iterating over None in stats.views.document_stats()
- Legacy-Id: 14250
2017-10-31 18:07:08 +00:00
Henrik Levkowetz 20b4250ea5 Reduced the size of stats data transferred from the server by an order of magnitude for author stats pages by not sending complete lists of item names per table item (we're only displaying them when there are few to display, anyway). Added caching of the resulting stats data for 24 hours. The caching was not possible in all cases before the data reduction, due to an item size limit of 1 MByte in memcached.
- Legacy-Id: 13534
2017-06-05 22:32:15 +00:00
Henrik Levkowetz 91b4063669 Added 24 hour caching of the author and meeting stats pages. Sorted the django imports and combined 2 imports from the same module.
- Legacy-Id: 13494
2017-06-02 10:21:12 +00:00
Henrik Levkowetz d5eb59c5a6 Changed the extension filtering from using a blacklist to a whitelist, to avoid a lot of incorrect types.
- Legacy-Id: 13487
2017-06-01 20:19:38 +00:00
Henrik Levkowetz 64b9615aa7 Changed most instances of 'registrations' to 'attendees' in the meeting statistics code (as that's what the numbers show)
- Legacy-Id: 13486
2017-06-01 20:17:16 +00:00
Henrik Levkowetz b6b45166bf Added email address to the MeetingRegistration model, and also to the fields imported from ietf.org/registration/attendees/NN . Changed the bin counting code for attendee-related stats to use names plus email as unique string, rather than only names.
- Legacy-Id: 13481
2017-05-31 23:08:23 +00:00
Ole Laursen c9d7089e43 Fix tooltip on overview chart
- Legacy-Id: 13269
2017-05-05 10:49:40 +00:00
Ole Laursen 365143f615 Don't show legend on overview chart with only one unlabelled entry
- Legacy-Id: 13268
2017-05-05 10:46:49 +00:00
Ole Laursen aff12f708a Add registration country pie chart for to present at the meeting, add
meeting stats test, fix a couple of bugs
 - Legacy-Id: 13267
2017-05-05 10:33:56 +00:00
Ole Laursen a2b8819cfe Add meeting statistics - overview and country/continent across
meetings + detail pages with country and continent
 - Legacy-Id: 13264
2017-05-04 15:55:15 +00:00
Ole Laursen 2c4f14c967 Make bins use a set to prevent duplicates. Those should only be a
problem with aliased bins, but use sets everywhere anyway for
consistency.
 - Legacy-Id: 13177
2017-03-30 14:50:23 +00:00
Ole Laursen 5b677dc6ba Merge author stats branch into new branch from trunk
- Legacy-Id: 13159
2017-03-28 14:36:40 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Ole Laursen 33e9577967 Add yearly charts for affiliation, country and continent, fix some bugs
- Legacy-Id: 12894
2017-02-21 17:07:38 +00:00
Ole Laursen c61babb418 Add citation and h-index statistics
- Legacy-Id: 12869
2017-02-17 17:43:14 +00:00
Ole Laursen d5e98c9644 Add mail to link to Secretariat on country page in case people are
missing a country or alias, adjust wording a bit on status page.
 - Legacy-Id: 12866
2017-02-17 10:21:34 +00:00
Ole Laursen 6964337853 Move bug fixes
- Legacy-Id: 12864
2017-02-16 18:45:46 +00:00