Commit graph

48 commits

Author SHA1 Message Date
Robert Sparks 6dd6165444
fix: correct meeting attendance calculations (#4536)
* fix: correct meeting attendance calculations

* test: change meetingregistration factory defaults

* test: Setup stats tests to verify counts honor meeting.Attended

But the tests aren't actually looking to see what numbers get generated yet.

* test: add test for attendance cross-talk between meetings

* fix: limit attendance count query to single meeting

* refactor: rename attendance.online to .remote

* fix: only count a given person as onsite or remote, but never both

* test: align tests with cleanup

Co-authored-by: Jennifer Richards <jennifer@painless-security.com>
2022-10-13 10:55:57 -05:00
Ryan Cross 2d48c84360
feat: Add tracking checked-in to MeetingRegistration and the registration API. (#4280)
* feat: add field MeetingRegistration.checkedin to track onsite checkin

* feat: add handling of ticket_type, checkedin to get_meeting_registation_data. Fixes #3672
2022-07-26 13:17:19 -05:00
rpcross 698f031b7f
feat: separate MeetingRegistration rows for each registration type. updates the registration API (#3641)
* Registration API Update

- change MeetingRegistration.reg_type field to hold only one type
- allow multiple MeetingRegistration records per person/meeting
  (one for each reg_type)

* Fix scope claims

* Add meeting 114 to MeetingRegistration migration

* fix: update stats views for MeetingRegistration model use changes

* refactor: remove unused imports
2022-06-16 15:39:34 -05:00
Lars Eggert 74f2a85d64
refactor: replace flot with highcharts (#4030)
* chore: Replace flot with highcharts

Since flot hasn't been updated since 2014 and was only used in one
place. Simplify how highcharts is initialized and used, and re-enable
pre-bs5 export functionality.

* Fix tests

* Remove some console.log statements
2022-05-31 17:05:27 -05:00
Robert Sparks 3697180cc1 Reverted merge of timezone-aware migration efforts.
- Legacy-Id: 18792
2021-01-12 16:54:20 +00:00
Henrik Levkowetz a708bdf895 Refactored out a new test case DrafTestCase in order to re-use it to set up test directories with draft content, and updated the StatisticsTest to subclass it.
- Legacy-Id: 18783
2020-12-19 22:42:36 +00:00
Henrik Levkowetz 774e752a54 Snapshot of timezone-aware datatracker code. Tests pass, and the test-crawler shows only expected differences. Trunk changes merged in up to r18768.
- Legacy-Id: 18770
2020-12-16 23:53:37 +00:00
Henrik Levkowetz 8a6026ce6e Added a MeetingRegistration.attended field, to keep apart meeting attendence and meeting registration before attendance.
- Legacy-Id: 17954
2020-06-09 20:58:35 +00:00
Henrik Levkowetz 726fcbf27d Removed all __future__ imports.
- Legacy-Id: 17391
2020-03-05 23:53:42 +00:00
Sasha Romijn f651320ef3 Fix #2331 - Show stacked bar graph for in time and late reviews.
On the stats page, a single stacked bar graph is now shown which
combines in time and late reviews, replacing the separate graphs for
these statistics.

Tests for the charts are also expanded to validate the actual
graph content for both stacked and non-stacked charts.

Commit ready for merge.
 - Legacy-Id: 16852
2019-10-09 15:46:22 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3
- Legacy-Id: 16446
2019-07-15 15:40:51 +00:00
Henrik Levkowetz 41438e5c4d Fixed some bytes/str issues and unused imports.
- Legacy-Id: 16391
2019-07-04 20:51:10 +00:00
Henrik Levkowetz 15e74e89cb Converted instances of assertTrue(text in response.content) to the recommended assertContains(response, text), and similar for assertFalse(... in ...)
- Legacy-Id: 16336
2019-06-29 13:43:31 +00:00
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias.
- Legacy-Id: 16261
2019-06-15 12:00:48 +00:00
Henrik Levkowetz a2cafded25 Changed DocAlias to be many-to-many, in order to be able to handle STD aliases referring to multiple RFCs.
- Legacy-Id: 16249
2019-06-14 20:38:14 +00:00
Henrik Levkowetz 8726e74709 Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself.
- Legacy-Id: 16177
2019-04-30 16:54:06 +00:00
Henrik Levkowetz bb4fe3fbbf Undid previous commit
- Legacy-Id: 16153
2019-04-22 19:22:42 +00:00
Henrik Levkowetz cfcefc2e32 Merged in [16144] from housley@vigilsec.com:
Remove some clutter from I-D upload page.  The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes #2057.
 - Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
2019-04-22 17:39:26 +00:00
Robert Sparks 3678d20b0b Some cleanup around stats. Things are well except for the time series graphs.
- Legacy-Id: 16035
2019-03-15 16:50:59 +00:00
Robert Sparks 0856990683 Checkpoint. Most tests do not fail. Oddness with an API resource, and with one template's coverage
- Legacy-Id: 16031
2019-03-14 18:39:40 +00:00
Henrik Levkowetz 2b811b3d3d Updated the tests to always use @ietf.org addresses where appropriate, and not do so when not appropriate. All test user login addresses have been changed away from @ietf.org.
- Legacy-Id: 15988
2019-03-04 20:08:48 +00:00
Henrik Levkowetz 3508f59f52 Merged in [15596] from rjsparks@nostrum.com:
improved coverage for several tests.
 - Legacy-Id: 15600
Note: SVN reference [15596] has been migrated to Git commit 6f18ae882532433ba86322b33c34f5f1b0350cb9
2018-10-19 14:27:13 +00:00
Henrik Levkowetz ef3cbf4684 Merged in [15595] from rjsparks@nostrum.com:
Converted stats, submit, sync. and utils/test to use factories. Excluded utils/test_data from coverage checks.
 - Legacy-Id: 15599
Note: SVN reference [15595] has been migrated to Git commit 39e76a836996ec9ed8ea449c92bdfae91c3dbaae
2018-10-19 12:54:58 +00:00
Henrik Levkowetz 7b1224ebad Merged in ^/personal/sbirkholz/meeting_registration_more_fixes, which adds creation of missing person records when importing meeting registration data. Tweaked the resulting code some.
- Legacy-Id: 14092
2017-08-31 18:48:53 +00:00
Ryan Cross 044b89169a Strip whitespace from registration data during import. Includes migration for existing data. Fixes #2356. Commit ready for merge.
- Legacy-Id: 14088
2017-08-29 19:58:32 +00:00
Seth Birkholz 8b5a639b82 This should be the final fix to
resolve the meeting registration problem where a Person object
 was not being created
 - Legacy-Id: 14076
2017-08-24 19:04:40 +00:00
Henrik Levkowetz 24273da256 Backed out commit 14000; the code is not idempotent and will create duplicate Person objects.
- Legacy-Id: 14004
2017-07-29 14:02:41 +00:00
Seth Birkholz 6359192cbb Commit ready for merge. This commit implements fixes suggested by Henrik to the MeetingRegistration class
- added tests
    - reverted 'obj' to 'object'
    - removed check for valid email
    - identifing person by Email.person rather than Person.user__username
    - used a simpler form of unidecode logic.  TBD: the previous code was stolen from elsewhere in the code which should also be simplified.
    - Person.name now uses firstname + lastname rather than email.
 - Legacy-Id: 13969
2017-07-25 20:20:00 +00:00
Henrik Levkowetz 64b9615aa7 Changed most instances of 'registrations' to 'attendees' in the meeting statistics code (as that's what the numbers show)
- Legacy-Id: 13486
2017-06-01 20:17:16 +00:00
Henrik Levkowetz b6b45166bf Added email address to the MeetingRegistration model, and also to the fields imported from ietf.org/registration/attendees/NN . Changed the bin counting code for attendee-related stats to use names plus email as unique string, rather than only names.
- Legacy-Id: 13481
2017-05-31 23:08:23 +00:00
Ole Laursen aff12f708a Add registration country pie chart for to present at the meeting, add
meeting stats test, fix a couple of bugs
 - Legacy-Id: 13267
2017-05-05 10:33:56 +00:00
Ole Laursen a2b8819cfe Add meeting statistics - overview and country/continent across
meetings + detail pages with country and continent
 - Legacy-Id: 13264
2017-05-04 15:55:15 +00:00
Ryan Cross 7fb035c061 Add Registration models
- Legacy-Id: 13182
2017-04-03 20:36:39 +00:00
Ole Laursen d9585b4b73 Add some extra test data to exercise the statistics better
- Legacy-Id: 13167
2017-03-29 09:06:12 +00:00
Ole Laursen 5b677dc6ba Merge author stats branch into new branch from trunk
- Legacy-Id: 13159
2017-03-28 14:36:40 +00:00
Lars Eggert 8a70e9773d Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Ole Laursen 33e9577967 Add yearly charts for affiliation, country and continent, fix some bugs
- Legacy-Id: 12894
2017-02-21 17:07:38 +00:00
Ole Laursen 6964337853 Move bug fixes
- Legacy-Id: 12864
2017-02-16 18:45:46 +00:00
Ole Laursen 9d8874d8b1 Add a suggestion to fix the country name when submitting a draft in
case we can't parse it and it's not empty, add page with list of
countries (to be able to refer people to it), add ISO codes as country
aliases - the country alias code is now more intelligent with respect
to case so it's easier to keep these aliases explicitly
 - Legacy-Id: 12862
2017-02-16 17:56:23 +00:00
Ole Laursen b2ff10b0f2 Add support for extracting the country line from the author addresses
to the draft parser (incorporating patch from trunk), store the
extracted country instead of trying to turn it into an ISO country
code, add country and continent name models and add initial data for
those, add helper function for cleaning the countries, add author
country and continent charts, move the affiliation models to
stats/models.py, fix a bunch of bugs.
 - Legacy-Id: 12846
2017-02-15 18:43:57 +00:00
Ole Laursen ef251c6bc7 Add author affiliation chart.
Also add a model for registering an alias for an affiliation so that
we can group affiliations that are considered the same for statistical
purposes, and a model for registering unimportant endings like Inc.
and GmbH.

Affiliation grouping is done through three means: stripping
uninteresting endings, merging entries that only differ in case and
aliases that map from case-insensitive alias to name.

Stripping endings and merging based on case seem to reduce the number
of needed manually maintained aliases greatly.
 - Legacy-Id: 12785
2017-02-03 18:49:43 +00:00
Ole Laursen a9525ab4f4 Revamp stats selector UI a bit to accomodate statistics counting
authors (instead of documents), add stats with documents per author
 - Legacy-Id: 12766
2017-01-31 16:32:20 +00:00
Ole Laursen b645a8c0f9 Expand document stats test
- Legacy-Id: 12753
2017-01-30 14:01:40 +00:00
Ole Laursen 6378594033 Add word count and submit format statistics
- Legacy-Id: 12656
2017-01-16 11:36:38 +00:00
Ole Laursen 656ed8c89d Add statistics for pages in documents, refactoring a bit to share more code
- Legacy-Id: 12639
2017-01-10 18:27:15 +00:00
Ole Laursen 13f3b4ed1a Add simple test for document stats
- Legacy-Id: 12631
2017-01-06 16:46:28 +00:00
Ole Laursen 4b987436c0 Fix a missing HttpResponseForbidden in review statistics, make the
review test code use a separate reviewer and reviewsecretary user to
avoid confounding things - also let these use Unicode in their names
to check for Unicode trouble.
 - Legacy-Id: 12175
2016-10-19 11:58:49 +00:00
Ole Laursen 6d7bfd7b37 Actually commit the statistics section.
- Legacy-Id: 12125
2016-10-13 15:36:14 +00:00