Commit graph

880 commits

Author SHA1 Message Date
Henrik Levkowetz d78379054c Merged in [17484] from valery@smyslov.net:
When requesting a new WG session, and retrieving information about the previous session, look back to the previous time the group met, instead of simply checking the previous IETF meeting and maybe not finding any information to retrieve.
 - Legacy-Id: 17504
Note: SVN reference [17484] has been migrated to Git commit 88f11669fd
2020-03-22 15:19:23 +00:00
Ryan Cross a99c37cd47 On session request form make Special Requests field smaller and display 200 character limit. Fixes #2875. Commit ready for merge.
- Legacy-Id: 17492
2020-03-21 21:27:18 +00:00
Ryan Cross 3969d6c931 Prevent use of capital letters in group acronym. Fixes #2709. Commit ready for merge.
- Legacy-Id: 17491
2020-03-21 21:01:34 +00:00
Ryan Cross 5d3601334e Remove redundant URL secr/groups/search because search page is available here secr/groups. Resolves issue with Add link. Fixes #2708. Commit ready for merge.
- Legacy-Id: 17489
2020-03-21 20:17:59 +00:00
Ryan Cross 5649bfdfd1 Remove drafts secretariat tool because this functionality is now provided by the core Datatracker. Moved ID reports to proceedings tool. Fixes #1655. Commit ready for merge.
- Legacy-Id: 17488
2020-03-21 19:52:12 +00:00
Valery Smyslov 88f11669fd #2882
- Legacy-Id: 17484
2020-03-21 17:25:20 +00:00
Henrik Levkowetz 726fcbf27d Removed all __future__ imports.
- Legacy-Id: 17391
2020-03-05 23:53:42 +00:00
Henrik Levkowetz ab173cb2eb Removed further six usage: six.string_types, six.integer_types, six.moves.urllib instances.
- Legacy-Id: 17390
2020-03-05 20:46:58 +00:00
Henrik Levkowetz e9a37d8ac8 Removed six.text_type(), changed six.moves.urllib to plain urllib, and removed now unused six imports.
- Legacy-Id: 17385
2020-03-05 14:41:41 +00:00
Sasha Romijn e70579175e Clarify wording in session request form regarding conflicts with BOFs.
- Legacy-Id: 17377
2020-03-03 14:52:28 +00:00
Henrik Levkowetz fff56bb557 Merged in [17336] from rcross@amsl.com:
Add rfp-announce@ietf.org to Announcement app To: address list. Changed name of secr dashboard from WG Chair Dahsboard to IETF Dashboard.
 - Legacy-Id: 17359
Note: SVN reference [17336] has been migrated to Git commit b1b27e648c
2020-02-27 19:54:37 +00:00
Henrik Levkowetz af0c189018 Fixed a test to be more specific when looking for a generated Message object, to make sure to get the right one.
- Legacy-Id: 17342
2020-02-26 17:15:09 +00:00
Henrik Levkowetz 5951a6473f Added html unescape for email addresses from form data that might use html entities for angle brackets.
- Legacy-Id: 17341
2020-02-26 17:11:54 +00:00
Henrik Levkowetz fa4adeb374 Fixed a number of bad Message.content_type settings.
- Legacy-Id: 17339
2020-02-26 17:05:53 +00:00
Ryan Cross b1b27e648c Add rfp-announce@ietf.org to Announcement app To: address list. Changed name of secr dashboard from WG Chair Dahsboard to IETF Dashboard. Commit ready for merge.
- Legacy-Id: 17336
2020-02-26 00:17:20 +00:00
Henrik Levkowetz fa9427769a Added cleaning of the session request form's 'comments' field, to convert any html entered to text. Related to [17322].
- Legacy-Id: 17324
Note: SVN reference [17322] has been migrated to Git commit eb88abc394
2020-02-21 21:36:18 +00:00
Henrik Levkowetz eb88abc394 Removed an instance of 'autoescape off' for submitted meeting session comments in a template, since it is not needed in practice, in order to avoid an XSS injection opportunity.
- Legacy-Id: 17322
2020-02-21 15:32:41 +00:00
Sasha Romijn 825a054d19 Add support for structured entry and storage of joint sessions in meetings.
- Also adds additional tests for the SessionForm
- Fixes a javascript error in session requests for non-WG groups,
  that could cause incorrect form behaviour.
- Expands the tests added in [17289] a bit.
 - Legacy-Id: 17321
Note: SVN reference [17289] has been migrated to Git commit a227813dc5
2020-02-21 13:27:11 +00:00
Sasha Romijn 1bfcf2e699 Fix issue in [17289] where wg_adjacent could be shown as a conflict.
- Legacy-Id: 17293
Note: SVN reference [17289] has been migrated to Git commit a227813dc5
2020-02-14 13:39:42 +00:00
Sasha Romijn a227813dc5 Add support for the timerange, wg_adjacent and time_relation constraints.
This adds three new constraints to the database and relevant UIs:
- timerange: "This WG can't meet during these timeframes"
- wg_adjacent: "Schedule adjacent to another WG (directly following,
  no breaks, same room)"
- time_relation: schedule the two sessions of one WG on subsequent
  days or with at least one day seperation
 - Legacy-Id: 17289
2020-02-12 10:42:38 +00:00
Henrik Levkowetz 7009605527 Merged in [17273] from rcross@amsl.com:
Update link to session request tool instructions.
 - Legacy-Id: 17282
Note: SVN reference [17273] has been migrated to Git commit 2d97cb65f7
2020-02-06 13:46:16 +00:00
Ryan Cross 2d97cb65f7 Update link to session request tool instructions. Commit ready for merge.
- Legacy-Id: 17273
2020-02-04 21:02:33 +00:00
Henrik Levkowetz 2eafa85b46 Merged in [17217] from olau@iola.dk:
Tighten validation of session conflicts in the session request tool,
preventing conflicts where source = target. Make sure the 'use
previous session' button doesn't carry forward conflicts that are no
longer valid.
Also fix a bug with the group list in the dropdowns being computed
statically at module import time instead of being queried dynamically
upon each page request.
 - Legacy-Id: 17222
Note: SVN reference [17217] has been migrated to Git commit c34fec535f
2020-01-13 14:14:31 +00:00
Ole Laursen c34fec535f Tighten validation of session conflicts in the session request tool,
preventing conflicts where source = target. Make sure the "use
previous session" button doesn't carry forward conflicts that are no
longer valid.

Also fix a bug with the group list in the dropdowns being computed
statically at module import time instead of being queried dynamically
upon each page request.

Commit ready for merge
 - Legacy-Id: 17217
2020-01-10 17:42:43 +00:00
Henrik Levkowetz b14cba5f15 Refactored some document methods to align better with Django's get_absolute_url(), and added Person.get_absolute_uri()
- Legacy-Id: 17189
2020-01-07 13:33:02 +00:00
Henrik Levkowetz 6482254a03 Merged in ^/branch/akayla/irsg/6.113.1.dev0 from peter@akayla.com.
This provides support for IRSG ballots, similar to the IESG ballots support which has been in use for quite some time.  The IRSG ballots differ from IESG ballots in a number of ways, described in detail in the RFP and SoW for this work and implemented here.
 - Legacy-Id: 17164
2019-12-20 15:00:55 +00:00
Peter E. Yee bb7e504d14 12/13 merged into 6.113.1.dev0 with migration ordering failure
- Legacy-Id: 17149
2019-12-13 19:53:45 +00:00
Ole Laursen 173b242e37 Request regular sessions with type session, fix the request test to
check the type
 - Legacy-Id: 17144
2019-12-09 18:20:27 +00:00
Ole Laursen 60a48d4638 Fix bug introduced in previous commit (exclude became filter)
- Legacy-Id: 17143
2019-12-09 18:09:54 +00:00
Ole Laursen 568670c060 Turn sessions into regular sessions and non-sessions into misc.
sessions in the UI and code to avoid ambiguity.

This doesn't change the data in the DB except for uses of
TimeSlotTypeName where 'session' is now 'regular'.
 - Legacy-Id: 17128
2019-12-06 20:02:26 +00:00
Ole Laursen 3957743b85 Move Session.status, .requested, and .requested_by to a new SchedulingEvent
- Legacy-Id: 17122
2019-12-05 12:41:09 +00:00
Ole Laursen 0555879777 Rename Meeting.agenda to Meeting.schedule together with a bunch of
related internal things
 - Legacy-Id: 17051
2019-11-18 17:22:19 +00:00
Henrik Levkowetz b7724c43d7 Changed some # type: ignore statements to work with the latest mypy
- Legacy-Id: 16968
2019-11-05 22:41:18 +00:00
Henrik Levkowetz a288401fd1 Type checking tweaks.
- Legacy-Id: 16866
2019-10-15 16:50:43 +00:00
Henrik Levkowetz 9d4ca615d3 Merged in [16607] from rcross@amsl.com:
Fix issue where third session requests, which rerequire AD approval, get left with approved status, instead of scheduled, after Secretraiat sends out notifications of official schedule.  Fixes #2765.
 - Legacy-Id: 16817
Note: SVN reference [16607] has been migrated to Git commit 9a82586e1b
2019-10-02 20:55:54 +00:00
Henrik Levkowetz bee8d13a57 Removed some test assertions which are incorrect after the previous commit
- Legacy-Id: 16806
2019-10-01 22:13:20 +00:00
Henrik Levkowetz 038e90649d From rcross@amsl.com: Don't copy breaks etc, when creating new Empty Schedule for meetings. Fixes issue #2713.
- Legacy-Id: 16805
2019-10-01 20:30:40 +00:00
Henrik Levkowetz 33e8733b91 Fixed up mypy issues or added type:ignore comments as needed for a clean mypy run.
- Legacy-Id: 16772
2019-09-30 15:42:18 +00:00
Henrik Levkowetz 4ed73d2ba9 Removed unused .py file
- Legacy-Id: 16767
2019-09-30 15:35:03 +00:00
Ryan Cross f950f1b8ea Remove temporary print statements. Commit ready for merge.
- Legacy-Id: 16702
2019-09-03 21:16:10 +00:00
Henrik Levkowetz 8472cf2226 Merged in [16630] from rjsparks@nostrum.com:
Rework how we are labeling constraints to provide a quick-fix for session requests at IETF106. Turned off several javascript functions that added/enforced old (possibly no longer correct) semantics for the session request forms. Fixes #2754.
 - Legacy-Id: 16699
Note: SVN reference [16630] has been migrated to Git commit 10422f87d2
2019-09-03 16:43:12 +00:00
Henrik Levkowetz e021eb8924 Merged in [16629] from rjsparks@nostrum.com:
Removing unused template. I think it was an artifact of the Django 1.2 to 1.6 conversion from 6 years ago.
 - Legacy-Id: 16698
Note: SVN reference [16629] has been migrated to Git commit 798a57c9ab
2019-09-03 14:46:14 +00:00
Henrik Levkowetz b2be7975c9 Merged in [16600] from rjsparks@nostrum.com:
Fixed a subtle bug in the code that converts slides to PDF that was writing back into settings.
 - Legacy-Id: 16645
Note: SVN reference [16600] has been migrated to Git commit b4714f95579efcb5051438239a5df002036c9975
2019-08-10 18:06:40 +00:00
Robert Sparks 10422f87d2 Rework how we are labeling constraints to provide a quick-fix for session requests at IETF106. Turned off several javascript functions that added/enforced old (possibly no longer correct) semantics for the session request forms. Fixes #2754. Commit ready for merge.
- Legacy-Id: 16630
2019-08-07 02:03:15 +00:00
Robert Sparks 798a57c9ab Removing unused template. I think it was an artifact of the Django 1.2 to 1.6 conversion from 6 years ago.
- Legacy-Id: 16629
2019-08-06 21:41:10 +00:00
Ryan Cross 9a82586e1b Fix issue where third session requests, which rerequire AD approval, get left with approved status, instead of scheduled, after Secretraiat sends out notifications of official schedule. Fixes #2765. Commit ready for merge.
- Legacy-Id: 16607
2019-07-31 23:02:20 +00:00
Henrik Levkowetz e03784132d Merged changes from current trunk to Py3 branch.
- Legacy-Id: 16468
2019-07-16 15:36:16 +00:00
Henrik Levkowetz bdc73e771a Python2/3 compatibility: replaced six.ensure_text() with either six.text_type or django's force_text(), depending on the case, and fixed a variable scope issue.
- Legacy-Id: 16461
2019-07-16 13:20:05 +00:00
Henrik Levkowetz 8c6eb3a30a Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc.
- Legacy-Id: 16458
2019-07-15 19:14:04 +00:00
Henrik Levkowetz ea8c84d2f6 Python2/3 compatibility: used @python_2_unicode_compatible to provide __unicode__() versions of __str__() methods.
- Legacy-Id: 16455
2019-07-15 18:01:26 +00:00
Henrik Levkowetz a5e31c3f40 Py2/3 compatibility: Added __future__ import.
- Legacy-Id: 16452
2019-07-15 15:52:18 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3
- Legacy-Id: 16446
2019-07-15 15:40:51 +00:00
Henrik Levkowetz 0679eaa8d4 Removed unused imports.
- Legacy-Id: 16402
2019-07-04 21:06:57 +00:00
Henrik Levkowetz f480799af9 Undid unintentional bulk commit
- Legacy-Id: 16401
2019-07-04 21:04:46 +00:00
Henrik Levkowetz fc09a59950 Added decode() of command pipe output.
- Legacy-Id: 16400
2019-07-04 21:01:39 +00:00
Henrik Levkowetz fbc131c73f Replaced an obsolete file() call with open().
- Legacy-Id: 16396
2019-07-04 20:57:36 +00:00
Henrik Levkowetz f33ecaa1a4 Fixed a test that compared an int with a meeting number string. Changed meeting test data to use meeting number 72 instead of 42, because proceedings code gives 404 for meetings before 65. Changed a number of StringIO() to BytesIO().
- Legacy-Id: 16378
2019-07-04 16:01:32 +00:00
Henrik Levkowetz 8c66e95a57 Test changes to match production group type changes for some special groups.
- Legacy-Id: 16357
2019-07-01 18:30:59 +00:00
Henrik Levkowetz f5ae2541ad Replaced multiple asserts with assertContains().
- Legacy-Id: 16353
2019-07-01 14:09:12 +00:00
Henrik Levkowetz f76d8bf776 Replaced multiple asserts with assertContains().
- Legacy-Id: 16349
2019-07-01 11:53:46 +00:00
Henrik Levkowetz f1172b5647 Replaced multiple asserts with assertContains().
- Legacy-Id: 16348
2019-07-01 11:47:36 +00:00
Henrik Levkowetz 15e74e89cb Converted instances of assertTrue(text in response.content) to the recommended assertContains(response, text), and similar for assertFalse(... in ...)
- Legacy-Id: 16336
2019-06-29 13:43:31 +00:00
Henrik Levkowetz 484dcece5f Changed all model __unicode__() methods to __str__()
- Legacy-Id: 16330
2019-06-28 21:07:08 +00:00
Henrik Levkowetz 3ec7e864be Converted leading tabs to spaces in ietf/**/*.py
- Legacy-Id: 16310
2019-06-27 14:51:02 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates.
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz f9cd72168f Updated some functions and views in secr/srec/ to use GroupFeatures instead of harcoded lists of group types.
- Legacy-Id: 16301
2019-06-23 11:52:58 +00:00
Henrik Levkowetz da5ff11538 Make session requests also work for ad-hoc groups, which may not have a parent area.
- Legacy-Id: 16300
2019-06-20 21:43:41 +00:00
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias.
- Legacy-Id: 16261
2019-06-15 12:00:48 +00:00
Henrik Levkowetz a2cafded25 Changed DocAlias to be many-to-many, in order to be able to handle STD aliases referring to multiple RFCs.
- Legacy-Id: 16249
2019-06-14 20:38:14 +00:00
Henrik Levkowetz 815602351f This is a series of 50 migrations that changes the Document and DocAlias
primary keys from character strings to integers, and makes corresponding code
changes.

This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.

Changing the primary keys to integers should also improve efficiency.  

Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time.  The total set of migrations are expected to have
a runtime on the order of 2 hours.
 - Legacy-Id: 16237
2019-06-10 11:32:46 +00:00
Henrik Levkowetz 33e0f8c35d Merged in [16126] from housley@vigilsec.com:
Allow Secretariat to handle downrefs when they approve a document
 - Legacy-Id: 16134
Note: SVN reference [16126] has been migrated to Git commit 8c7e75101d
2019-04-08 17:02:02 +00:00
Russ Housley 746ed7a524 Tests for IESG Telechat moderator package changes related to downrefs
- Legacy-Id: 16125
2019-04-01 19:22:08 +00:00
Henrik Levkowetz f54d6cd23d Merged in [16092] from rcross@amsl.com:
Remove ability to cancel a break session.  Fixes #2703.
 - Legacy-Id: 16105
Note: SVN reference [16092] has been migrated to Git commit b5850d5c7f
2019-03-26 15:53:41 +00:00
Henrik Levkowetz 5707df2770 Merged in [16088] from rcross@amsl.com:
Fix multiple issues with secretariat non-session view, including indicator of cancelled sessions.  Fixes #2701.
 - Legacy-Id: 16097
Note: SVN reference [16088] has been migrated to Git commit 41966122dd
2019-03-24 15:04:43 +00:00
Henrik Levkowetz 3252183d61 Merged in [16087] from housley@vigilsec.com:
Add downward references to telechat moderator package and Secretariat telechat pages.
 - Legacy-Id: 16093
Note: SVN reference [16087] has been migrated to Git commit 268b99bd56
2019-03-23 17:19:52 +00:00
Ryan Cross b5850d5c7f Remove ability to cancel a break session. Fixes #2703. Commit ready for merge.
- Legacy-Id: 16092
2019-03-23 17:00:52 +00:00
Ryan Cross 41966122dd Fix multiple issues with secretariat non-session view, including indicator of cancelled sessions. Fixes #2701. Commit ready for merge.
- Legacy-Id: 16088
2019-03-23 16:02:00 +00:00
Russ Housley 268b99bd56 Add downward references to telechat moderator package and Secretariat telechat pages. Commit ready for merge.
- Legacy-Id: 16087
2019-03-23 15:36:07 +00:00
Ryan Cross 2842ad12bb Fix issue where cancelling one break session causes other breaks to get cancelled. Fixes #2699. Commit ready for merge.
- Legacy-Id: 16085
2019-03-23 14:49:33 +00:00
Henrik Levkowetz 682ddee8e4 Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly.
- Legacy-Id: 16020
2019-03-11 17:01:33 +00:00
Henrik Levkowetz d57088b1f3 Modified one call and one exception point related to on_behalf_of() use for email sending.
- Legacy-Id: 16008
2019-03-06 19:13:15 +00:00
Henrik Levkowetz 55bd2e5e42 Fixed some unintentional wg list address changes, and added some other test mail address changes.
- Legacy-Id: 15994
2019-03-04 20:54:38 +00:00
Henrik Levkowetz 435a0da12d Added on_behalf_of() calls for from addresses needing it throughout the code.
- Legacy-Id: 15992
2019-03-04 20:14:19 +00:00
Henrik Levkowetz ccb9074bc7 Temporary fix for a potential server 500. Expecting a better fix from Ryan.
- Legacy-Id: 15959
2019-02-21 15:26:40 +00:00
Henrik Levkowetz ef97f2a821 Merged in GroupFeatures refactoring and expansion from ^/personal/henrik/6.89.4.dev0@15911.
- Legacy-Id: 15912
2019-01-24 15:25:01 +00:00
Henrik Levkowetz 57a4c9f41f Added 9 new group features, and changed list-like char fields to json fields, to get better support for using the values as lists. Modified code to use the group features instead of explicit lists of group types in many places in the code.
- Legacy-Id: 15908
2019-01-22 18:11:46 +00:00
Henrik Levkowetz 4e8ef492fc Modified the rolodex code to make sure we capture information about the origin of email addresses if they are added by the secretariat, to ensure GPR compliance.
- Legacy-Id: 15898
2019-01-18 18:27:29 +00:00
Robert Sparks 25cc00f925 Refactored DocumentInfo to address overloading the external_url field with strings that are not URLs. Commit ready for merge.
- Legacy-Id: 15864
2019-01-02 22:55:00 +00:00
Robert Sparks 6118975620 Added an explicit ID-Exists state for the IESG state machine. Reworked code so that the IESG state machine always has a state. Added the ability to release a document from a working group, research group, or the independent stream. Releasing a document removes all stream state, and sets the document to have no stream.
- Legacy-Id: 15809
2018-12-11 22:38:05 +00:00
Henrik Levkowetz e55a079591 Merged in [15787] from rcross@amsl.com:
Rework page flow and forms of secr/meetings app.  Fixes #2609.
 - Legacy-Id: 15794
Note: SVN reference [15787] has been migrated to Git commit e634dc2488
2018-11-30 20:48:40 +00:00
Ryan Cross 4322bdaa6a Add missing template. Remove unused templates. Comit ready for merge.
- Legacy-Id: 15791
2018-11-29 18:21:40 +00:00
Ryan Cross e634dc2488 Rework page flow and forms of secr/meetings app. Fixes #2609. Commit ready for merge.
- Legacy-Id: 15787
2018-11-21 22:43:04 +00:00
Henrik Levkowetz 1149ebcacf Merged in [15722] from rcross@amsl.com:
Add link to meeting/../agendas/list.  Fixes #2627.
 - Legacy-Id: 15762
Note: SVN reference [15722] has been migrated to Git commit b15a008c40
2018-11-12 16:52:56 +00:00
Henrik Levkowetz 18c7e90d94 Merged in [15719] from rcross@amsl.com:
Removed resources field from secr/meetings/../rooms.
Tweaked CSS for this page to eliminate horizontal scrolling. 
Includes new base templates to facilitate transition to bootstrap.
Fixes #2628.
 - Legacy-Id: 15759
Note: SVN reference [15719] has been migrated to Git commit afbcc4e0ad
2018-11-12 14:17:32 +00:00
Henrik Levkowetz d284c56ed5 Removed a print statement from a test.
- Legacy-Id: 15758
2018-11-12 14:11:34 +00:00
Henrik Levkowetz 3fdaf0d572 Merged in [15717] from rcross@amsl.com:
Rework buttons on secr/meetings. Fixes #2629.
 - Legacy-Id: 15757
Note: SVN reference [15717] has been migrated to Git commit 44b01c6404
2018-11-12 13:54:41 +00:00
Henrik Levkowetz e471386cf2 Merged in [15715] from rcross@amsl.com:
Fix issue where new non-session location field value isn't saved.  Fixes #2625.
 - Legacy-Id: 15756
Note: SVN reference [15715] has been migrated to Git commit a47fba833f
2018-11-12 13:35:17 +00:00
Henrik Levkowetz 5cba7fc8a8 Added exclusion of cancelled session when doing audio file import. Fixes an server 500 error when a cancelled session is shown in the same room and timeslot as an actual session.
- Legacy-Id: 15752
2018-11-11 14:33:45 +00:00
Ryan Cross b15a008c40 Add link to meeting/../agendas/list. Fixes #2627. Commit ready for merge.
- Legacy-Id: 15722
2018-11-06 03:19:21 +00:00
Ryan Cross afbcc4e0ad Removed resources field from secr/meetings/../rooms.
Tweaked CSS for this page to eliminate horizontal scrolling. 
Includes new base templates to facilitate transition to bootstrap.
Fixes #2628.  Commit ready for merge.
 - Legacy-Id: 15719
2018-11-05 10:01:05 +00:00
Ryan Cross 44b01c6404 Rework buttons on secr/meetings. Fixes #2629. Commit ready for merge.
- Legacy-Id: 15717
2018-11-05 05:45:33 +00:00
Ryan Cross a47fba833f Fix issue where new non-session location field value isn't saved. Fixes #2625. Commit ready for merge.
- Legacy-Id: 15715
2018-11-05 04:25:20 +00:00
Henrik Levkowetz b4ec0acf9e Merged in [15603] from rjsparks@nostrum.com:
Change some text and button labels to make the workflow for commiting group schedules more self-documenting.
 - Legacy-Id: 15617
Note: SVN reference [15603] has been migrated to Git commit 2abc51ae8356f1ee76642578f5d24d00dc641fc1
2018-10-30 13:38:14 +00:00
Henrik Levkowetz 3508f59f52 Merged in [15596] from rjsparks@nostrum.com:
improved coverage for several tests.
 - Legacy-Id: 15600
Note: SVN reference [15596] has been migrated to Git commit 6f18ae882532433ba86322b33c34f5f1b0350cb9
2018-10-19 14:27:13 +00:00
Robert Sparks 87bda66740 Converted several secr apps to use factories for tests. Commit ready for merge.
- Legacy-Id: 15568
2018-10-12 22:08:31 +00:00
Robert Sparks 5c57cf1b91 Used factories instead of make_test_data for malinglists, mailtrigger, message, person, secr/announcement, and secr/areas tests. Commit ready for merge.
- Legacy-Id: 15551
2018-10-10 05:36:34 +00:00
Henrik Levkowetz 17994b4cf2 Merged in [15522] from rcross@amsl.com:
Make email address read-only in rolodex edit form.  Fixes #2602.
 - Legacy-Id: 15529
Note: SVN reference [15522] has been migrated to Git commit dd2487e946
2018-10-07 20:34:37 +00:00
Ryan Cross dd2487e946 Make email address read-only in rolodex edit form. Fixes #2602. Commit ready for merge
- Legacy-Id: 15522
2018-10-05 00:23:10 +00:00
Henrik Levkowetz 5b3c961677 Removed the 2.5 hour session length choice for IETF 103, since there will be no Friday sessions that meeting.
- Legacy-Id: 15477
2018-09-20 14:05:00 +00:00
Ryan Cross c6bc55207c Change content-type of ajax_get_liaison_info to application/json. Commit ready for merge.
- Legacy-Id: 15450
2018-09-12 20:53:53 +00:00
Henrik Levkowetz 993765d513 Merged in [15423] from rcross@amsl.com:
Remove WG milestone management from secretariat groups app.
 - Legacy-Id: 15425
Note: SVN reference [15423] has been migrated to Git commit f8b107ef5a
2018-08-10 14:01:18 +00:00
Henrik Levkowetz fcbbe08eba Removed video url import from youtube, which is not needed any more given the /api/meeting/session/video/url API endpoint. This also prevents duplicate video URLs.
- Legacy-Id: 15424
2018-08-10 12:54:27 +00:00
Ryan Cross f8b107ef5a Remove WG milestone management from secretariat groups app. Commit ready for merge.
- Legacy-Id: 15423
2018-08-10 05:13:43 +00:00
Henrik Levkowetz f060e4d1ea Merged in [15351] from rcross@amsl.com:
Update secr/drafts/tests_views to align with view logic.  Fixes #2480.
 - Legacy-Id: 15384
Note: SVN reference [15351] has been migrated to Git commit 7df5ed1ca4
2018-07-18 18:45:31 +00:00
Henrik Levkowetz 6b20768b3e Merged in [15345] from rcross@amsl.com:
Remove duplicate functionality in secr/drafts.  Fixes #2540.
 - Legacy-Id: 15379
Note: SVN reference [15345] has been migrated to Git commit 2d6083060a
2018-07-18 15:04:00 +00:00
Henrik Levkowetz c24092d2f7 Merged in [15335] from rcross@amsl.com:
Fixed the ordering of meeting select in secr/meetings.  Fixes #2539.
 - Legacy-Id: 15373
2018-07-17 14:36:36 +00:00
Henrik Levkowetz 5385aa39b8 Added a missing template.
- Legacy-Id: 15365
2018-07-16 15:49:49 +00:00
Henrik Levkowetz 1504c6b13e Merged in [15328] from rcross@amsl.com:
Give secretariat the ability to cancel non-working group sessions. Fixes #2537.
 - Legacy-Id: 15363
Note: SVN reference [15328] has been migrated to Git commit ec279682d2
2018-07-15 20:08:44 +00:00
Ryan Cross 7df5ed1ca4 Update secr/drafts/tests_views to align with view logic. Fixes #2480. Commit ready for merge.
- Legacy-Id: 15351
2018-07-14 20:59:17 +00:00
Ryan Cross 2d6083060a Remove duplicate functionality in secr/drafts. Fixes #2540. Commit ready for merge.
- Legacy-Id: 15345
2018-07-14 19:25:09 +00:00
Ryan Cross 9e09a1b531 Fix ordering of meeting select in secr/meetings. Fixes #2539. Commit ready for merge.
- Legacy-Id: 15339
2018-07-14 17:08:23 +00:00
Ryan Cross ec279682d2 Give secretariat the ability to cancel non-working group sessions. Fixes #2537. Commit ready for merge.
- Legacy-Id: 15328
2018-07-14 16:14:35 +00:00
Henrik Levkowetz c219f2f998 Merged in [15266] from rcross@amsl.com:
Update blue sheet template.  Replace start time / end time with date.
 - Legacy-Id: 15271
Note: SVN reference [15266] has been migrated to Git commit e65748103b705e5dddea75bc550884498f42e75e
2018-06-20 04:10:22 +00:00
Henrik Levkowetz 4db4dd16b0 Merged in ^/personal/henrik/6.79.1-gdpr@15180 containing GDPR-adaptations.
- Legacy-Id: 15181
2018-05-28 11:26:24 +00:00
Henrik Levkowetz 81e78c70a0 Added guards against asking for properties on None in a couple of places.
- Legacy-Id: 15173
2018-05-26 08:34:27 +00:00
Henrik Levkowetz 6c3ec5b18e Added Email origin to Email record creation throughout the codebase.
- Legacy-Id: 15149
2018-05-17 16:56:26 +00:00
Henrik Levkowetz f0c0753e28 Added email origin information to some function calls that needed it.
- Legacy-Id: 15130
2018-05-05 12:49:10 +00:00
Henrik Levkowetz a66639299d Removed all references to the removed Person.affiliation field.
- Legacy-Id: 15129
2018-05-05 12:47:55 +00:00
Robert Sparks f64bf957f3 Restored a test that was unintentionally removed. Removed unused templates. Related to #2513. Commit ready for merge.
- Legacy-Id: 15114
2018-05-03 18:42:59 +00:00
Robert Sparks 7d2ac8306e Removed the already disabled "Make RFC" functionality from /secr/drafts. Fixes #2513. Commit ready for merge.
- Legacy-Id: 15113
2018-05-03 17:35:38 +00:00
Robert Sparks 82681b28dd Removed the "announce" functionality from /secr/drafts. Addresses part of #2513. Commit ready for merge.
- Legacy-Id: 15112
2018-05-03 17:26:11 +00:00
Robert Sparks c3241bddac Removed the "replaces" functionality from /secr/drafts. Addresses part of #2513. Commit ready for merge.
- Legacy-Id: 15111
2018-05-03 17:17:14 +00:00
Henrik Levkowetz 53c4ac36db Removed the Person.address field, which is not being used. This was a legacy from the 2001 perl-based datatracker tables. Fixes issue #2504.
- Legacy-Id: 15095
2018-04-27 14:00:33 +00:00
Ryan Cross 4ae0982fb0 Fix issue where user can make two session request submissions, corrupting data. Also, ignore deleted session requests in edit view. Commit ready for merge
- Legacy-Id: 15055
2018-04-18 23:23:20 +00:00
Henrik Levkowetz a1c79a075d Merged in ^/personal/henrik/6.76.1-meetecho-api/ which provides new API endpoint to let video urls be associated with sessions. Also added some more checks to the test_api_set_session_video_url() test.
- Legacy-Id: 14969
2018-03-29 15:25:36 +00:00
Henrik Levkowetz 0ef66ae9e2 Added optional arguments title and user to create_recording(), to make it possible to affect those attributes.
- Legacy-Id: 14966
2018-03-29 11:02:58 +00:00
Henrik Levkowetz 4e5050a6e1 Merged in [14902] from rjsparks@nostrum.com:
Test coverage improvements for ietf/secr/telechat/views.
 - Legacy-Id: 14916
Note: SVN reference [14902] has been migrated to Git commit 1386a90de8
2018-03-25 00:18:44 +00:00
Henrik Levkowetz 70b2cb5841 Merged in [14900] from rjsparks@nostrum.com:
Improvements to test coverage for ietf/secr/drafts/views.py.
 - Legacy-Id: 14915
Note: SVN reference [14900] has been migrated to Git commit 79f2f5869f
2018-03-24 22:06:39 +00:00
Robert Sparks 1386a90de8 Test coverage improvements for ietf/secr/telechat/views. Commit ready for merge.
- Legacy-Id: 14902
2018-03-22 18:44:38 +00:00
Robert Sparks 79f2f5869f Improvements to test coverage for ietf/secr/drafts/views.py. Commit ready for merge.
- Legacy-Id: 14900
2018-03-22 15:34:50 +00:00
Henrik Levkowetz c8ebcf1f88 Merged in [14879] from kivinen@iki.fi:
Backfilled IETF meetings starting from 1 and backfilled the attendee numbers for them. Modified the overview attendee statistics page to use different colors for different venue continents.
 - Legacy-Id: 14898
Note: SVN reference [14879] has been migrated to Git commit 75dbe017a6
2018-03-22 00:01:57 +00:00
Tero Kivinen 75dbe017a6 Backfilled IETF meetings starting from 1 and backfilled the attendee numbers for them. Modified the overview attendee statistics page to use different colors for different venue continents. Commit ready for merge.
- Legacy-Id: 14879
2018-03-20 17:28:48 +00:00
Henrik Levkowetz 1ece5f1f3b Removed premature save of upload document state (doing it after verifying that the save to file worked instead). Tweaked materials documents revision extraction regexes. Added a test on no change of materials rev after failed upload. Corrected the naming of materials in make_meeting_test_data. Refined the test crawl of meeting materials pages.
- Legacy-Id: 14865
2018-03-19 01:05:52 +00:00
Henrik Levkowetz a7b9c4b733 Merged in [14845] from rcross@amsl.com:
Remove unused roles/forms.py.
 - Legacy-Id: 14859
Note: SVN reference [14845] has been migrated to Git commit 01bfbff170
2018-03-18 14:09:14 +00:00
Ryan Cross 01bfbff170 Remove unused roles/forms.py. Commit ready for merge
- Legacy-Id: 14845
2018-03-17 15:49:02 +00:00
Robert Sparks e630793802 Simple coverage tests for ietf/secr/drafts/reports.py. Commit ready for merge.
- Legacy-Id: 14830
2018-03-15 23:11:43 +00:00
Henrik Levkowetz 278d868d28 Added handling for when file magic doesn't return a definitive encoding for a file. Added a test case to excercise error cases.
- Legacy-Id: 14782
2018-03-13 16:45:50 +00:00
Henrik Levkowetz 8f4f50d5c4 Added a new argument encoding= to handle_upload_file() in order to be able to deal better with various upload encodings.
- Legacy-Id: 14780
2018-03-13 13:56:00 +00:00
Henrik Levkowetz 6e9bb00f13 Changed html cleaning to differentiate between fragment cleaning and document cleaning. Added an lxml-based cleaner for document cleaning, also permitting <style> tags (but not external style sheets).
- Legacy-Id: 14775
2018-03-13 12:48:22 +00:00
Henrik Levkowetz 2fd344f810 Tweaks to handle text types better and make set operation clearer.
- Legacy-Id: 14745
2018-03-07 21:10:47 +00:00
Henrik Levkowetz 802f201d81 Modified the sanitizer and upload handler to strip also the content of some tags, and to produce valid files (if the content is otherwise valid).
- Legacy-Id: 14744
2018-03-07 19:00:24 +00:00
Henrik Levkowetz 2828683cee Replaced html sanitization code that called html5lib directly with calls to bleach, and upgraded the requirements to let us use the latest html5lib and bleach.
- Legacy-Id: 14739
2018-03-06 18:35:34 +00:00
Henrik Levkowetz b92ad2f992 Added sanitization of uploaded html content for session agendas and minutes, and did some refactoring of the upload form classes.
- Legacy-Id: 14738
2018-03-06 15:55:30 +00:00
Henrik Levkowetz ad2139dc8f Fixed a settings typo.
- Legacy-Id: 14725
2018-03-03 18:30:19 +00:00
Henrik Levkowetz 4c6aa091b1 Added date information to the 'scheduled session' emails, and also a link to an ical file for the group sessions. Fixes issue #2461.
- Legacy-Id: 14722
2018-03-02 16:43:56 +00:00
Henrik Levkowetz de0c60884f Added a missing pyflakes pragma.
- Legacy-Id: 14713
2018-02-28 16:58:35 +00:00
Henrik Levkowetz 28bd9eadda Make sure that sessions listed in session scheduling notification emails are listed in time order. Fixes issue #2460.
- Legacy-Id: 14712
2018-02-28 13:28:51 +00:00
Henrik Levkowetz 28d64fe593 Removed unused imports
- Legacy-Id: 14675
2018-02-22 00:14:03 +00:00
Henrik Levkowetz 19980de327 Fixed a bug in the queryset argument of a form field declaration.
- Legacy-Id: 14669
2018-02-22 00:05:46 +00:00
Henrik Levkowetz 26bf387356 Replaced direct assignment to m2m fields with .clear() and .set()
- Legacy-Id: 14666
2018-02-21 23:58:25 +00:00
Henrik Levkowetz 06362ec046 Got rid of old migrations and created new initial migrations.
- Legacy-Id: 14662
2018-02-21 23:46:22 +00:00
Henrik Levkowetz 5638cf3da3 Changed all usage of ForeignKey and OneToOneFiled in model.py files to the compatibility versions from ietf.utils.models.
- Legacy-Id: 14661
2018-02-20 15:36:05 +00:00
Robert Sparks dfc1d2aa9a Warn when putting a draft on a telechat that is so close that directorates will probably not have time to complete a review. Fixes #2381. Commit ready for merge.
- Legacy-Id: 14539
2018-01-18 22:14:30 +00:00
Henrik Levkowetz edcfcd11f1 Added more logging during draft resurrection. Added a guard agains draft status changes while the draft expiration loop is running.
- Legacy-Id: 14488
2018-01-06 16:01:21 +00:00
Henrik Levkowetz 92db803bac Removed code that has been marked unreachable for more than 5 months.
- Legacy-Id: 14472
2017-12-29 19:48:18 +00:00
Henrik Levkowetz f697d9ecb6 Merged in [14404] from rjsparks@nostrum.com:
Include an explicitly set Responsible ADs email addresses in generated aliases when a document has a group.
 - Legacy-Id: 14424
Note: SVN reference [14404] has been migrated to Git commit e36cad65ed
2017-12-15 23:57:41 +00:00
Henrik Levkowetz 1f976da5c1 Third part of document read refactoring, after [14406] and [14410]. This replaces all usage of the non-unicode-aware get_document_content() function with unicode-aware Document.text() or Document.text_or_error() methods. This was triggered by yet another report of unicode content not being shown properly, and should fix all instances of document (drafts, agendas, minutes, etc.) display in the datatracker not handling unicode characters properly.
- Legacy-Id: 14411
Note: SVN reference [14406] has been migrated to Git commit 967ece7e7d

Note: SVN reference [14410] has been migrated to Git commit 660c81c272
2017-12-11 16:23:51 +00:00
Henrik Levkowetz 660c81c272 Tweaked the file content read refactoring in [14406] to try latin-1 conversion if unicode doesn't work.
- Legacy-Id: 14410
Note: SVN reference [14406] has been migrated to Git commit 967ece7e7d
2017-12-10 17:48:09 +00:00
Henrik Levkowetz 967ece7e7d Started refactoring of reading text from document files (drafts, charters, etc.) in order to normalise on one way of doing this, and making that return unicode rather than undecoded bytes. This is the first step of two, in order to gauge the possible issues and report on discrepancies.
- Legacy-Id: 14406
2017-12-08 21:51:11 +00:00
Henrik Levkowetz 98d234cd86 Refactored the handling of BallotDocEvent in tests, only creating them as needed, in preparation for stricter checks on state transitions to avoid mismatches between state and ballot.
- Legacy-Id: 14380
2017-11-30 16:02:31 +00:00
Ryan Cross bf3a49466f Improve test coverage for ietf.secr.sreq. Commit ready for merge
- Legacy-Id: 14362
2017-11-11 09:33:27 +00:00
Henrik Levkowetz 4f83548b49 Added a new field Meeting.days to capture the length of a meeting. This is necessary now that we have previous meetings officially starting Sunday, lasting to Friday, and future meetings starting Saturday, Lasting to Friday. We use Meeting.days to calculate Meeting.end_date(). Meeting.get_ietf_monday() and two cut_off() methods have also been updated to be instance methods instead of class methods, and to not assume that a meeting starts on Sunday.
- Legacy-Id: 14225
2017-10-25 13:38:15 +00:00
Ryan Cross b9bf77b543 Changed to not check timeslot type on delete because other types now have this option. Commit ready for merge
- Legacy-Id: 14211
2017-10-16 20:37:15 +00:00
Ryan Cross 4a71c1476f Fix issue creating new timeslots in secretariat scheduling tool caused by changing the meeting start date to a Saturday. Commit ready for merge.
- Legacy-Id: 14189
2017-10-05 20:28:39 +00:00
Henrik Levkowetz cbda2679a9 Removed some unreachable code.
- Legacy-Id: 14150
2017-09-22 14:45:21 +00:00
Ryan Cross a85a76247a Change announcement tool access function to use data from AnnouncementFrom objects. Fixes #2362. Commit ready for merge
- Legacy-Id: 14103
2017-09-06 21:29:59 +00:00
Henrik Levkowetz 868427a645 Merged in [13996] from rcross@amsl.com:
Move Announcement app From addresses out of code and into database table.  Fixes #1681.
 - Legacy-Id: 14006
Note: SVN reference [13996] has been migrated to Git commit d49787a0f6060e7db64f5a0e684bf1d980f85290
2017-07-29 18:12:45 +00:00
Henrik Levkowetz 0d1feacb42 Merged in [13957] from rjsparks@nostrum.com:
Moves Important Dates into the datatracker. Fixes #2338.
 - Legacy-Id: 13962
Note: SVN reference [13957] has been migrated to Git commit 2e6f26af23
2017-07-21 16:30:04 +00:00
Robert Sparks 2e6f26af23 Moves Important Dates into the datatracker. Fixes #2338. Commit ready for merge.
- Legacy-Id: 13957
2017-07-21 10:29:56 +00:00
Henrik Levkowetz 3d5862a9d4 Changed get_timeslot_for_filename() to not blow up in the presence of duplicate timeslots.
- Legacy-Id: 13952
2017-07-20 12:43:38 +00:00
Jean Mahoney 8bb332d8e8 Made email subject 'I-D ACTION:<draft>' consistent with other 'I-D Action: <draft>' email subjects. Fixes #1519. Commit ready for merge.
- Legacy-Id: 13892
2017-07-15 11:05:29 +00:00
Henrik Levkowetz ccf170bb5f Modified a test to make it less sensitive to timing vagaries causing arbitrary failures.
- Legacy-Id: 13846
2017-07-12 15:24:39 +00:00
Henrik Levkowetz d2395f9521 Merged in [13832] from rjsparks@nostrum.com:
Treat Area Groups similar to Working Groups and Research Groups where it makes sense to do so.
 - Legacy-Id: 13836
Note: SVN reference [13832] has been migrated to Git commit 2c92aa213d
2017-07-11 21:57:01 +00:00
Robert Sparks 2c92aa213d Treat Area Groups similar to Working Groups and Research Groups where it makes sense to do so. Commit ready for merge.
- Legacy-Id: 13832
2017-07-11 19:12:21 +00:00
Henrik Levkowetz 900174ae57 Added log.unreachable() calls to some functions believed to be unused.
- Legacy-Id: 13818
2017-07-09 15:01:21 +00:00
Henrik Levkowetz c5b52ae91e Merged in [13775] from rcross@amsl.com:
Refactor session edit page.  Add button to cancel a session, which sets the status.  Fixes #2296.
 - Legacy-Id: 13776
Note: SVN reference [13775] has been migrated to Git commit 9ac9493a70
2017-07-05 21:35:59 +00:00
Ryan Cross 9ac9493a70 Refactor session edit page. Add button to cancel a session, which sets the status. Fixes #2296. Commit ready for merge.
- Legacy-Id: 13775
2017-07-05 20:23:10 +00:00
Henrik Levkowetz 9415d65341 Merged in [13727] from rcross@amsl.com:
Remove legacy external interim meeting listing.  Install redirect to /meeting/past.  Fixes #2166.
 - Legacy-Id: 13742
Note: SVN reference [13727] has been migrated to Git commit 7d244c9a38
2017-06-30 18:36:10 +00:00
Henrik Levkowetz ad3701e457 Fixed an issue with the test_edit_replace_user() test
- Legacy-Id: 13740
2017-06-30 11:49:18 +00:00
Henrik Levkowetz ade8973015 Merged in [13726] from rcross@amsl.com:
Update secr.rolodex app to deactivate old Users when replaced on edit.  Fixes #2001.
 - Legacy-Id: 13735
Note: SVN reference [13726] has been migrated to Git commit a251076903
2017-06-29 20:39:52 +00:00
Ryan Cross 7d244c9a38 Remove legacy external interim meeting listing. Install redirect to /meeting/past. Fixes #2166. Commit ready for merge.
- Legacy-Id: 13727
2017-06-29 00:09:36 +00:00
Ryan Cross a251076903 Update secr.rolodex app to deactivate old Users when replaced on edit. Fixes #2001. Commit ready for merge.
- Legacy-Id: 13726
2017-06-28 20:43:28 +00:00
Henrik Levkowetz 2070bbfed6 Merged in [13722] and [13712] from rcross@amsl.com:
Remove all use of request.session from secretariat apps.  Add tests for affected views.  Fixes #1455.
 - Legacy-Id: 13724
Note: SVN reference [13712] has been migrated to Git commit 915b445bcffcd4687fb1677230b98282d22dd9a0

Note: SVN reference [13722] has been migrated to Git commit 3a2cb9d3d846168f75d9796b4e5383bdf10b1f60
2017-06-28 14:55:10 +00:00
Henrik Levkowetz b42f1cbeb5 Replaced the use of unaccent.asciify(), which has similar functionality to unidecode.unidecode(). Changed the draft parser to work exclusively with unicode text, which both makes the removal of unaccent easier, and takes us closer to Py35 compatibility. Adjusted callers of the draft parser to send in unicode.
- Legacy-Id: 13673
2017-06-18 18:23:18 +00:00
Henrik Levkowetz 7ecf7dfa44 Merged in [13615] and [13627]from rcross@amsl.com:
Changed views that use GET requests to delete objects to use POST.
Fixes #1796.
 - Legacy-Id: 13654
Note: SVN reference [13615] has been migrated to Git commit 3ccb550888

Note: SVN reference [13627] has been migrated to Git commit b908caf95c
2017-06-16 14:20:01 +00:00
Ryan Cross b908caf95c Add missing confirm_delete.html. Commit ready for merge.
- Legacy-Id: 13627
2017-06-14 16:27:46 +00:00
Ryan Cross 3ccb550888 Change views that use GET requests to delete objects to use POST. Fixes #1796. Commit ready for merge.
- Legacy-Id: 13615
2017-06-13 23:33:31 +00:00
Henrik Levkowetz bd0a772f17 Added a guard against trying to get the room ID from a timeslot without location in the secretariat schedule view.
- Legacy-Id: 13592
2017-06-13 09:59:05 +00:00
Henrik Levkowetz 6bf0e558ea Merged in [13588] from rcross@amsl.com:
Initialize Empty-Schedule with special sessions from previous meeting on creation.  Fixes #1500.
 - Legacy-Id: 13591
Note: SVN reference [13588] has been migrated to Git commit 8a98ba2516
2017-06-12 22:27:04 +00:00
Ryan Cross 8a98ba2516 Initialize Empty-Schedule with special sessions from previous meeting on creation. Fixes #1500. Commit ready for merge.
- Legacy-Id: 13588
2017-06-12 21:39:52 +00:00