altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity
14645 commits 1 branch 0 tags 2.6 GiB
Commit graph

311 commits

Author SHA1 Message Date
Jennifer Richards 27469c1264
fix: do not create ReviewRequestDocEvent when assigning a review req (#4913) 
* fix: do not create ReviewRequestDocEvent when assigning a review req

* test: test docevent creation
 2022-12-16 15:17:10 -06:00
Lars Eggert 6eabd4a3a1
chore: Use codespell to fix typos in comments. (#4794) 
First part of replacement of #4651
 2022-11-28 10:36:36 -06:00
Lars Eggert d16a9e77a7
fix: Fix transient test failures due to i18n names (#4695) 
* Search for escaped name in HTML output

* Need to check for `plain_name()` in sent emails

* Normalize i18n Unicode names in the same way the database does
 2022-11-06 12:29:49 +00:00
Jennifer Richards cbc6d159a5
fix: convert LastCallDocEvent.expires to DEADLINE_TZINFO to get date 2022-10-25 10:03:18 -03:00
Jennifer Richards 2d875d534d
chore: migrate fields whose defaults changed to date_today 2022-10-18 12:46:14 -03:00
Jennifer Richards 3220bf3c40
chore: replace last few datetime.date.today() calls with date_today() 2022-10-18 12:45:47 -03:00
Jennifer Richards da70acfdff
Merge branch 'feat/tzaware' into jennifer/yet-more-tz-fixes 
# Conflicts:
#	ietf/ietfauth/utils.py
#	ietf/meeting/tests_views.py
#	ietf/stats/tests.py
 2022-10-17 16:39:45 -03:00
Jennifer Richards 7b1b7f5273
Merge branch 'feat/tzaware' into dev/tzaware-main-merge 2022-10-11 14:57:34 -03:00
Jennifer Richards cb9e576fb4
fix: return False from has_role() when role_names is the empty list (#4541) 
* fix: return False from has_role() when role_names is the empty list

* chore: add comments clarifying the effect of Q()
 2022-10-07 16:05:37 -05:00
Jennifer Richards a653582cf7
fix: timezone fixes from last few comparisons with tzaware-obe 2022-09-28 13:21:50 -03:00
Jennifer Richards c5e5a00ff3
fix: fill in tzinfo for datetime.fromtimestamp() calls 
Unix timestamp is defined to be UTC and fromtimetamp correctly turns
it into whatever timezone you request. In most cases, just need to
specify *something* to avoid creating naive datetimes.
 2022-09-22 12:36:35 -03:00
Jennifer Richards 32054111df
fix: fix failing tests and eliminate naive datetime warnings (#4402) 
* test: fix timestamp construction in several doc tests

* refactor: rename date2datetime to datetime_from_date and clarify code

* chore: helper to get tzinfo for PRODUCTION_TIMEZONE

* fix: fix timezone handling in make_last_call()

* test: fix datetime generation in doc.tests_charter

* refactor: remove PRODUCTION_TIMEZONE setting

Replaces the PRODUCTION_TIMEZONE setting with a constant,
DEADLINE_TZINFO, in ietf.utils.timezone.

* test: be more careful about timezone in tests_charter.py

* test: be more careful about timezone in doc/tests.py

* fix: fix timezone handling affecting doc.tests_draft

* fix: fix timezone handling affecting tests_irsg_ballot.py

* fix: fix timezone handling affecting tests_review.py

* fix: fix timezone handling affecting last ietf.doc tests

* fix: fix timezone handling affecting last ietf.group tests

* fix: fix timezone handling affecting ietf.iesg tests

* fix: handle timezones in get_8989_eligibility_querysets

* fix: handle timezones affecting ietfauth tests

* fix: return tz-aware datetime from utc_from_string

* fix: specify timezone for constants in ipr_rfc_number()

* fix: specify tz for ipr deadlines

* fix: handle timezones affecting liaisons tests

* fix: treat leap day in get_8989_eligibility_querysets()

Manual cherry-pick of 248d6474

* test: treat leap day properly in nomcom tests

* fix: fix timezone handling affecting nomcom tests

* test: fix timezone handling in review tests

* fix: fix timezone handling affecting secr.meetings tests

* fix: handle both pytz and zoneinfo timezones in ietf.utils.timezone

* fix: fix timezone handling affecting secr.proceedings tests

* refactor: use make_aware() helper in secr.meetings tests

* test: fix timezone handling in secr.telechat tests

* fix: fix timezone handling affecting stats tests

* fix: eliminate tz-naive helpers affecting sync email parsing

* fix: include timezone data when serializing DeletedEvent data

* fix: fix timezone handling affecting sync tests

* style: remove unused import
 2022-09-01 13:07:28 -03:00
Jennifer Richards ebebdbed3e
refactor: replace datetime.now and datetime.today with timezone.now (#4211) 
* refactor: replace datetime.now with timezone.now

* refactor: migrate model fields to use timezone.now as default

* refactor: replace datetime.today with timezone.now

datetime.datetime.today() is equivalent to datetime.datetime.now(); both
return a naive datetime with the current local time.

* refactor: rephrase datetime.now(tz) as timezone.now().astimezone(tz)

This is effectively the same, but is less likely to encourage accidental
use of naive datetimes.

* refactor: revert datetime.today() change to old migrations

* refactor: change a missed datetime.now to timezone.now

* chore: renumber timezone_now migration

* chore: renumber migrations
 2022-08-25 13:45:16 -03:00
Robert Sparks b988850985
fix: avoid mutables as defaults. Compute date default arguments at runtime rather than loadtime. (#4144) 2022-07-06 14:39:36 -05:00
Robert Sparks 249db17ae7
chore: keep the database in sync with django-simple-history (#3967) 2022-05-14 08:12:35 -05:00
Jennifer Richards 69caacea29
test: prevent periodic failure of test_send_reminder_all_open_reviews() (#3584) 2022-03-07 13:20:14 -06:00
Jennifer Richards 6df0377fa1 Fix several review reminder problems. 
Send secretary's review reminders to secretary instead of assignee. 
Send unconfirmed assignment reminders based on assignment age and CC secretaries. 
Correctly separate open review reminders by review team.

Fixes #3482. Fixes #3324. Commit ready for merge.
 - Legacy-Id: 19848
 2022-01-14 19:14:06 +00:00
Robert Sparks 5c28a85cf1 Merged in [19555] from jennifer@painless-security.com: 
Use temporary directories instead of 'real' filesystem for tests. Fixes #3414.
 - Legacy-Id: 19561
Note: SVN reference [19555] has been migrated to Git commit 81d9234d54
 2021-11-08 18:16:56 +00:00
Jennifer Richards 81d9234d54 Use temporary directories instead of "real" filesystem for tests. Fixes #3414. Commit ready for merge. 
- Legacy-Id: 19555
 2021-11-05 19:45:57 +00:00
Robert Sparks cd748cd760 Update internal references to trac.tools.ietf.org to point to trac.ietf.org. Remove several links into tools.ietf.org. Commit ready for merge. 
- Legacy-Id: 19422
 2021-10-13 21:43:44 +00:00
Robert Sparks b99eecc1ae Bring the factory-boy and Faker dependencies forward through some minor breaking changes. Stop using the deprecated fr_QC locale in Faker. Commit ready for merge. 
- Legacy-Id: 19270
 2021-08-03 22:22:35 +00:00
Jennifer Richards 92c9f856a4 Refactor reviewer queue policy handling of "skip" setting. Fixes #3038. Commit ready for merge. 
- Legacy-Id: 18833
 2021-02-16 19:31:50 +00:00
Robert Sparks d8a24a8e2a Corrected a typo in a test. 
- Legacy-Id: 18767
 2020-12-15 20:34:47 +00:00
Robert Sparks e059ec3d70 Merged in [18743] from rjsparks@nostrum.com: 
Cleaning some pyflakes that made it into the last commit.
 - Legacy-Id: 18760
Note: SVN reference [18743] has been migrated to Git commit 3697a9e9a4
 2020-12-11 21:57:14 +00:00
Robert Sparks 17ab884b19 Merged in [18736] from rjsparks@nostrum.com: 
Fixup document that had no type. Remove dangling review document. Fixes #3145.
 - Legacy-Id: 18759
Note: SVN reference [18736] has been migrated to Git commit 708ab108e6
 2020-12-11 21:53:14 +00:00
Robert Sparks 3697a9e9a4 Cleaning some pyflakes that made it into the last commit. Commit ready for merge. 
- Legacy-Id: 18743
 2020-12-08 15:50:43 +00:00
Robert Sparks 708ab108e6 Fixup document that had no type. Remove dangling review document. Fixes #3145. Commit ready for merge. 
- Legacy-Id: 18736
 2020-12-07 19:36:47 +00:00
Henrik Levkowetz 8ebef27026 Related to issue #2186: The issue asked for changing review requests from state 'assigned' back to state 'requested' if the last associated assignment is withdrawn. However, the code to implement this makes the change for all assignment states, and also when there has been no state change. Changed to be more discerning. 
- Legacy-Id: 18722
 2020-12-01 15:36:04 +00:00
Robert Sparks 863582e56a Completed repair migration for disconnected and confused reviews. Branch ready for merge. 
- Legacy-Id: 18522
 2020-09-25 16:08:09 +00:00
Robert Sparks a2a0fdfae8 Early migration, mostly comments, committed to facilitate conversation. 
- Legacy-Id: 18515
 2020-09-23 15:28:33 +00:00
Henrik Levkowetz a1b1a919ab Merged in [18373] from mark@painless-security.com: 
Filter out reviewers who have rejected reviewing this document in the past from the list of suggested reviewers.  Fixes #2996.
 - Legacy-Id: 18448
Note: SVN reference [18373] has been migrated to Git commit d105f8ba5b
 2020-08-31 11:21:07 +00:00
Mark J. Donnelly d105f8ba5b Filter out reviewers who have rejected reviewing this document in the past from the list of suggested reviewers. Fixes #2996. Commit ready for merge. 
- Legacy-Id: 18373
 2020-08-13 15:03:54 +00:00
Henrik Levkowetz 8fcfd2073a Added a migration where Django 2.0 captures more model information than 1.11 did. 
- Legacy-Id: 17845
 2020-05-20 07:31:35 +00:00
Henrik Levkowetz bc05e7a8d0 Refactored many instances of msg.get_payload(decode=True).decode('utf-8') and similar to get_payload_text(msg), which uses msg.get_charset() to get the actual charset to do the decoding, in a consistent manner. Also removed some instances of force_str, but more remain. 
- Legacy-Id: 17807
 2020-05-16 20:20:05 +00:00
Henrik Levkowetz 2b68095b82 Merged in [17794] from mark@painless-security.com: 
Add the 'msg' variable for interpolation on reviewer availability change emails, and reformat the add-a-period email.  Fixes #2891.
 - Legacy-Id: 17799
Note: SVN reference [17794] has been migrated to Git commit 96bc71f51f150cec7043aca60d0156d35847019b
 2020-05-15 11:33:03 +00:00
Henrik Levkowetz 9aeda11a29 Removed some Py2 compatibility decorators. 
- Legacy-Id: 17673
 2020-04-21 13:54:31 +00:00
Henrik Levkowetz 02e0ccf441 Removed a renamed migration 
- Legacy-Id: 17620
 2020-04-14 19:29:09 +00:00
Henrik Levkowetz f10ddadc0e Merged in changes from trunk up to r17584. 
- Legacy-Id: 17593
 2020-04-07 16:02:52 +00:00
Henrik Levkowetz 87bf4e8d58 Make sure to strip possible mail header field values of whitespace before applying email.utils.unquite(). Resolution by kivinen@iki.fi, Fixes issue #2899. 
- Legacy-Id: 17485
 2020-03-21 17:34:37 +00:00
Henrik Levkowetz 89ec88dd7d - Legacy-Id: 17401 2020-03-07 12:46:53 +00:00
Henrik Levkowetz a69ffdc87a Added a migration 
- Legacy-Id: 17399
 2020-03-06 21:01:13 +00:00
Henrik Levkowetz 726fcbf27d Removed all __future__ imports. 
- Legacy-Id: 17391
 2020-03-05 23:53:42 +00:00
Henrik Levkowetz ab173cb2eb Removed further six usage: six.string_types, six.integer_types, six.moves.urllib instances. 
- Legacy-Id: 17390
 2020-03-05 20:46:58 +00:00
Henrik Levkowetz e9a37d8ac8 Removed six.text_type(), changed six.moves.urllib to plain urllib, and removed now unused six imports. 
- Legacy-Id: 17385
 2020-03-05 14:41:41 +00:00
Henrik Levkowetz af6ca37513 Admin model tweak, added a raw_id_field. 
- Legacy-Id: 17382
 2020-03-03 21:00:35 +00:00
Henrik Levkowetz 941a27bf72 Fixed a Py2/3 issue with review.mailarchive.construct_query_url(). 
- Legacy-Id: 17379
 2020-03-03 17:00:13 +00:00
Henrik Levkowetz 1017c21167 Renamed a migration to conform to migration naming conventions, using underscores instead of dashes in the name. 
- Legacy-Id: 17376
 2020-03-03 12:22:48 +00:00
Henrik Levkowetz 0487cfce3e Changed ReviewerSettings history change-reason field to TextField 
- Legacy-Id: 17184
 2020-01-06 18:50:36 +00:00
Henrik Levkowetz 49fc0d7a71 Change varchar(100) to text field for HistoricalReviewerSettings.history_change_reason, to accomodate longer change descriptions. 
- Legacy-Id: 17171
 2019-12-21 19:56:16 +00:00
Henrik Levkowetz d9c19449ce Fixed a migration overlap issue. 
- Legacy-Id: 17123
 2019-12-05 18:04:37 +00:00